Change in vdsm[master]: Skip broken tests feature
Igor Lvovsky has posted comments on this change. Change subject: Skip broken tests feature .. Patch Set 8: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia380b2a5f5027e88926f61f4a762c1afec9f0203 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Wenchao Xia xiaw...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Optimize _getConfigValue to return multiple values
Igor Lvovsky has uploaded a new change for review.
Change subject: Optimize _getConfigValue to return multiple values
..
Optimize _getConfigValue to return multiple values
Change-Id: I15ff5542095d51f33f5f1970b81a4a0cbfb30632
Signed-off-by: Igor Lvovsky ilvov...@redhat.com
---
M vdsm/configNetwork.py
1 file changed, 19 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/7306/1
diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py
index 7e3379e..fb283ff 100755
--- a/vdsm/configNetwork.py
+++ b/vdsm/configNetwork.py
@@ -373,9 +373,11 @@
cfg += conf
# Check whether we need to preserve prev ip/mask/gateway
if not ipaddr and os.path.exists(cf):
-ipaddr = self._getConfigValue(cf, 'IPADDR')
-netmask = self._getConfigValue(cf, 'NETMASK')
-gateway = self._getConfigValue(cf, 'GATEWAY')
+confParams = self._getConfigValue(cf, ['IPADDR', 'NETMASK',
+ 'GATEWAY'])
+ipaddr = confParams['IPADDR']
+netmask = confParams['NETMASK']
+gateway = confParams['GATEWAY']
if ipaddr:
cfg = cfg + 'IPADDR=%s\nNETMASK=%s\n' % (pipes.quote(ipaddr),
@@ -485,12 +487,12 @@
self._backup(self.NET_CONF_PREF + bridge)
self._removeFile(self.NET_CONF_PREF + bridge)
-def _getConfigValue(self, conffile, entry):
+def _getConfigValue(self, conffile, entries):
-Get value from network configuration file
+Get values from network configuration file
-:param entry: entry to look for (entry=value)
-:type entry: string
+:param entry: entries to look for (entry=value)
+:type entry: list
:returns: value for entry (or None)
:rtype: string
@@ -498,13 +500,14 @@
Search for entry in conffile and return
its value or None if not found
+confParams = dict(zip(entries, len(entries)*[None]))
with open(conffile) as f:
-entries = [ line for line in f.readlines()
-if line.startswith(entry + '=') ]
-if len(entries) != 0:
-value = entries[0].split('=', 1)[1]
-return value.strip()
-return None
+for line in f.readlines():
+key, val = line.split('=', 1)
+if key.strip() in confParams:
+confParams[key.strip()] = val.strip()
+
+return confParams
def _updateConfigValue(self, conffile, entry, value, delete=False):
@@ -551,7 +554,7 @@
for nic in nics:
cf = self.NET_CONF_PREF + nic
-mtuval = self._getConfigValue(cf, 'MTU')
+mtuval = self._getConfigValue(cf, ['MTU'])['MTU']
if not mtuval is None:
if int(mtuval) mtu:
mtu = mtuval
@@ -570,7 +573,7 @@
_netinfo = netinfo.NetInfo()
cf = self.NET_CONF_PREF + bridge
-currmtu = self._getConfigValue(cf, 'MTU')
+currmtu = self._getConfigValue(cf, ['MTU'])['MTU']
if currmtu is None:
return
@@ -591,7 +594,7 @@
if vlan == delvlan:
continue
cf = self.NET_CONF_PREF + vlan
-mtu = self._getConfigValue(cf, 'MTU')
+mtu = self._getConfigValue(cf, ['MTU'])['MTU']
newmtu = max(newmtu, mtu)
if newmtu != currmtu:
--
To view, visit http://gerrit.ovirt.org/7306
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15ff5542095d51f33f5f1970b81a4a0cbfb30632
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Optimize _getConfigValue to return multiple values
oVirt Jenkins CI Server has posted comments on this change. Change subject: Optimize _getConfigValue to return multiple values .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/513/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7306 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15ff5542095d51f33f5f1970b81a4a0cbfb30632 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#832765 - Rewrite vdsm-restore-net-config as python module
Dan Kenigsberg has posted comments on this change. Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module .. Patch Set 10: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#832765 - Rewrite vdsm-restore-net-config as python module
Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module .. BZ#832765 - Rewrite vdsm-restore-net-config as python module Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Signed-off-by: Igor Lvovsky ilvov...@redhat.com --- M vdsm/Makefile.am A vdsm/vdsm-restore-net-config D vdsm/vdsm-restore-net-config.in 3 files changed, 46 insertions(+), 52 deletions(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skip broken tests feature
Dan Kenigsberg has posted comments on this change. Change subject: Skip broken tests feature .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/3966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia380b2a5f5027e88926f61f4a762c1afec9f0203 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Wenchao Xia xiaw...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skip broken tests feature
Dan Kenigsberg has submitted this change and it was merged. Change subject: Skip broken tests feature .. Skip broken tests feature We can't have broken tests upstream, it confuses people who write patches and makes them think they broke the functionality. Add this to tests you know are broken to help others Change-Id: Ia380b2a5f5027e88926f61f4a762c1afec9f0203 Signed-off-by: Saggi Mizrahi smizr...@redhat.com --- M tests/configNetworkTests.py M tests/testValidation.py 2 files changed, 17 insertions(+), 1 deletion(-) Approvals: Dan Kenigsberg: Verified Igor Lvovsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia380b2a5f5027e88926f61f4a762c1afec9f0203 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Wenchao Xia xiaw...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Reelated to BZ#846323 - Adding deprecated decorator.
Eduardo has uploaded a new change for review. Change subject: Reelated to BZ#846323 - Adding deprecated decorator. .. Reelated to BZ#846323 - Adding deprecated decorator. Change-Id: I9e30eb912f78cc2dcd846ff0b0273a0a8016cac7 Signed-off-by: Eduardo ewars...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/7308/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 2227c03..b04f083 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -1698,6 +1698,7 @@ return dict(uuid=lvm.getVG(vgname).uuid) +@deprecated @public def removeVG(self, vgUUID, options = None): -- To view, visit http://gerrit.ovirt.org/7308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9e30eb912f78cc2dcd846ff0b0273a0a8016cac7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Reelated to BZ#846323 - Adding deprecated decorator.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Reelated to BZ#846323 - Adding deprecated decorator. .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/514/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e30eb912f78cc2dcd846ff0b0273a0a8016cac7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#846323 - Search PV's belonging to the VG in removeVG.
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#846323 - Search PV's belonging to the VG in removeVG. .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/515/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica565f74774fd1dcce7c18361aef5e1464c78b68 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Haim Ateya hat...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#848299 - Fix delete VLANed network with custom MTU
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#848299 - Fix delete VLANed network with custom MTU .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/516/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I485c8bd3dfa84c421dab2c5d121ad7a5efc348a3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#846004 - IP on nic/bond should be preserved when VLAN add...
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#846004 - IP on nic/bond should be preserved when VLAN added .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/517/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6481c64c285b8a9bd6f6cc49c1c84507c91603 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Optimize _getConfigValue to return multiple values
oVirt Jenkins CI Server has posted comments on this change. Change subject: Optimize _getConfigValue to return multiple values .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/518/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7306 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15ff5542095d51f33f5f1970b81a4a0cbfb30632 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#848299 - Fix delete VLANed network with custom MTU
Dan Kenigsberg has posted comments on this change. Change subject: BZ#848299 - Fix delete VLANed network with custom MTU .. Patch Set 3: I would prefer that you didn't submit this (1 inline comment) File vdsm/configNetwork.py Line 582: for vlan in vlans: Line 583: if vlan == delvlan: Line 584: continue Line 585: iface = iface + '.' + vlan Line 586: cf = netinfo.NET_CONF_DIR + iface this has to be NET_CONF_PREF. who is going to add ifcfg- to the file name? Line 587: mtu = self._getConfigValue(cf, 'MTU') Line 588: newmtu = max(newmtu, mtu) Line 589: Line 590: if newmtu != currmtu: -- To view, visit http://gerrit.ovirt.org/7214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I485c8bd3dfa84c421dab2c5d121ad7a5efc348a3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840594 Fix netinfo when libvirt bridge does not exist.
Dan Kenigsberg has posted comments on this change. Change subject: BZ#840594 Fix netinfo when libvirt bridge does not exist. .. Patch Set 4: Verified verified with libvirt net without a compatible bridge. -- To view, visit http://gerrit.ovirt.org/7127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2538a8ce2fafd8efed834b87b20a63d058afd96b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840594 Fix netinfo when libvirt bridge does not exist.
Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#840594 Fix netinfo when libvirt bridge does not exist. .. BZ#840594 Fix netinfo when libvirt bridge does not exist. In the case where a bridge that is configured in libvirt is manually removed or renamed, netinfo throws an exception when trying to discover which ports are assigned to the bridge. This patch catches the OSError exception of trying to list the ports of a non- existing bridge interface, effectively filtering the non-existing interface from the network capabilities. Also adds a unittest for getting network information of non-existing bridges. Change-Id: I2538a8ce2fafd8efed834b87b20a63d058afd96b Signed-off-by: Antoni S. Puimedon asegu...@redhat.com --- M tests/netinfoTests.py M vdsm/netinfo.py 2 files changed, 23 insertions(+), 3 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2538a8ce2fafd8efed834b87b20a63d058afd96b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#849315 vdsm-reg: return proper exit code from upgrade scr...
Dan Kenigsberg has posted comments on this change. Change subject: BZ#849315 vdsm-reg: return proper exit code from upgrade script .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d0c3d60c3d80ea50ede6b22f931b091ec625836 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: Yaniv Kaul yk...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#849315 vdsm-reg: return proper exit code from upgrade scr...
Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#849315 vdsm-reg: return proper exit code from upgrade script .. BZ#849315 vdsm-reg: return proper exit code from upgrade script main returns boolean, while exit code of True is actually program status of failure. Change-Id: I4d0c3d60c3d80ea50ede6b22f931b091ec625836 Signed-off-by: Alon Bar-Lev alo...@redhat.com --- M vdsm_reg/vdsm-upgrade 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d0c3d60c3d80ea50ede6b22f931b091ec625836 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: Yaniv Kaul yk...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#848299 - Fix delete VLANed network with custom MTU
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#848299 - Fix delete VLANed network with custom MTU .. Patch Set 4: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/519/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I485c8bd3dfa84c421dab2c5d121ad7a5efc348a3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#846004 - IP on nic/bond should be preserved when VLAN add...
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#846004 - IP on nic/bond should be preserved when VLAN added .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/520/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6481c64c285b8a9bd6f6cc49c1c84507c91603 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Optimize _getConfigValue to return multiple values
oVirt Jenkins CI Server has posted comments on this change. Change subject: Optimize _getConfigValue to return multiple values .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/521/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7306 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15ff5542095d51f33f5f1970b81a4a0cbfb30632 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#846004 - IP on nic/bond should be preserved when VLAN add...
Dan Kenigsberg has posted comments on this change. Change subject: BZ#846004 - IP on nic/bond should be preserved when VLAN added .. Patch Set 3: I would prefer that you didn't submit this (2 inline comments) File vdsm/configNetwork.py Line 371: cfg = DEVICE=%s\nONBOOT=%s\n % (pipes.quote(name), Line 372: pipes.quote(onboot)) Line 373: cfg += conf Line 374: # Check whether we need to preserve prev ip/mask/gateway Line 375: if not ipaddr and os.path.exists(cf): it sound like a too-low level to preserve these values... Assume we have an ifcfg-eth0 with IPADDR defined. It would stay there, even if the nic is to be connected to a bridge, and no one wants it to have an IP address of its own. Line 376: ipaddr = self._getConfigValue(cf, 'IPADDR') Line 377: netmask = self._getConfigValue(cf, 'NETMASK') Line 378: gateway = self._getConfigValue(cf, 'GATEWAY') Line 379: Line 374: # Check whether we need to preserve prev ip/mask/gateway Line 375: if not ipaddr and os.path.exists(cf): Line 376: ipaddr = self._getConfigValue(cf, 'IPADDR') Line 377: netmask = self._getConfigValue(cf, 'NETMASK') Line 378: gateway = self._getConfigValue(cf, 'GATEWAY') btw, why only these params? shouldn't we maintain MTU, too? Line 379: Line 380: if ipaddr: Line 381: cfg = cfg + 'IPADDR=%s\nNETMASK=%s\n' % (pipes.quote(ipaddr), Line 382: pipes.quote(netmask)) -- To view, visit http://gerrit.ovirt.org/7259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6481c64c285b8a9bd6f6cc49c1c84507c91603 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Optimize _getConfigValue to return multiple values
Dan Kenigsberg has posted comments on this change. Change subject: Optimize _getConfigValue to return multiple values .. Patch Set 3: I would prefer that you didn't submit this (1 inline comment) File vdsm/configNetwork.py Line 486: subprocess.call([constants.EXT_BRCTL, 'delbr', bridge]) Line 487: self._backup(self.NET_CONF_PREF + bridge) Line 488: self._removeFile(self.NET_CONF_PREF + bridge) Line 489: Line 490: def _getConfigValue(self, conffile, entries): now this function has become way to similar to netinfo.getIfaceCfg() please consider using it all over the place. Line 491: Line 492: Get values from network configuration file Line 493: Line 494: :param entry: entries to look for (entry=value) -- To view, visit http://gerrit.ovirt.org/7306 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15ff5542095d51f33f5f1970b81a4a0cbfb30632 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: return proper exit code from bootstrap scripts
Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: return proper exit code from bootstrap scripts .. Patch Set 1: (1 inline comment) File vds_bootstrap/setup Line 173: execfn += [random_num] Line 174: execfn.append(str(int(rebootAfterInstallation))) Line 175: logging.debug(trying to run %s script cmd = '%s',script, string.join(execfn, )) Line 176: proc = subprocess.Popen(execfn) Line 177: proc.communicate() I had a vague memory of having asked this once, but I do not recall this answer of yours. sorry. I'll trust you that nowadays, stderr is not lost. stdout needs funny BSTRAP encoding in order to be handled by Engine. Line 178: if proc.returncode == 0: Line 179: return True Line 180: else: Line 181: logging.debug(script %s doen not exist,script) -- To view, visit http://gerrit.ovirt.org/7301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cf1d2ad402641394da52099c157fc34cf49cad1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: return proper exit code from bootstrap scripts
Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: return proper exit code from bootstrap scripts .. Patch Set 4: Looks good to me, approved Alon, I see no benefit in these frequent rebasing. For me, it only adds to the noise level. Thanks for this cleanup. -- To view, visit http://gerrit.ovirt.org/7301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cf1d2ad402641394da52099c157fc34cf49cad1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: remove temporary files even if some missing
Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: remove temporary files even if some missing .. Patch Set 2: I can live with a more brutal remove. -- To view, visit http://gerrit.ovirt.org/7302 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f69af679e798846e15faa0b9674aeeadc6d01e4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: remove temporary files even if some missing
Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: remove temporary files even if some missing .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7302 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f69af679e798846e15faa0b9674aeeadc6d01e4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: send complete bootstrap from engine
Dan Kenigsberg has submitted this change and it was merged. Change subject: bootstrap: send complete bootstrap from engine .. bootstrap: send complete bootstrap from engine CURRENT BEHAVIOR vds_installer.py is part of ovirt-engine, upon bootstrap, the script is sent to the node using ssh. Then vds_installer.py pulls vds-bootstrap* files using HTTP from engine. The vds_installer.py and vds_bootstrap pulls ssh public key from engine using HTTP. NEW BEHAVIOR vds_installer.py was moved into the vdsm-bootstrap and renamed to setup. vdsm-bootstrap repository was updated to create directory per bootstrap interface with 'setup' script. ovirt-engine copies public key to node in similar way of firewall rules. At bootstrap time, engine create tar archive from the bootstrap directory, cache it and pipe the archive into node in order to extract it and run the setup script. No HTTP communication is needed. No conflict with existing files. BACKWARD COMPATIBILITY Leave vds_bootstrap.py, vds_bootstrap_complete.py, deployUtil.py to be used by older engines. This should be removed in future. SCRIPTS MODIFICATIONS Set umask 0077 so only running user can access files. Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Signed-off-by: Alon Bar-Lev alo...@redhat.com --- M .gitignore M vds_bootstrap/Makefile.am A vds_bootstrap/setup M vds_bootstrap/vds_bootstrap.py M vdsm.spec.in M vdsm_reg/Makefile.am M vdsm_reg/deployUtil.py.in 7 files changed, 444 insertions(+), 28 deletions(-) Approvals: Alon Bar-Lev: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com Gerrit-Reviewer: Ofer Schreiber oschr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: return proper exit code from bootstrap scripts
Dan Kenigsberg has submitted this change and it was merged. Change subject: bootstrap: return proper exit code from bootstrap scripts .. bootstrap: return proper exit code from bootstrap scripts This is quick and dirty solution to return valid exit code from bootstrap scripts, until now exit code of vds_bootstrap* was wrong, however the vds_bootstrap.py did not check for exit code at all, and... engine did not as well. Now engine checks return code so proper code is requried. Change-Id: I5cf1d2ad402641394da52099c157fc34cf49cad1 Signed-off-by: Alon Bar-Lev alo...@redhat.com --- M vds_bootstrap/setup M vds_bootstrap/vds_bootstrap.py M vds_bootstrap/vds_bootstrap_complete.py 3 files changed, 32 insertions(+), 7 deletions(-) Approvals: Alon Bar-Lev: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cf1d2ad402641394da52099c157fc34cf49cad1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Preserve MTU on bond/nic when VLAN without MTU added
Igor Lvovsky has uploaded a new change for review. Change subject: Preserve MTU on bond/nic when VLAN without MTU added .. Preserve MTU on bond/nic when VLAN without MTU added Change-Id: I48ef1ddd11ae3a9d450d55cf5c68be3b83af5b03 Signed-off-by: Igor Lvovsky ilvov...@redhat.com --- M vdsm/configNetwork.py 1 file changed, 16 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/7322/1 diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py index 7374ef5..199adfa 100755 --- a/vdsm/configNetwork.py +++ b/vdsm/configNetwork.py @@ -368,16 +368,23 @@ gateway=None, bootproto=None, mtu=None, onboot='yes', **kwargs): Create ifcfg-* file with proper fields per device cf = self.NET_CONF_PREF + name +# Check whether we need to preserve prev ip/mask/gateway/mtu +confParams = None +if os.path.exists(cf): +confParams = self._getConfigValue(cf, ['IPADDR', 'NETMASK', + 'GATEWAY', 'MTU']) + cfg = DEVICE=%s\nONBOOT=%s\n % (pipes.quote(name), pipes.quote(onboot)) cfg += conf -# Check whether we need to preserve prev ip/mask/gateway -if not ipaddr and os.path.exists(cf): -confParams = self._getConfigValue(cf, ['IPADDR', 'NETMASK', - 'GATEWAY']) -ipaddr = confParams['IPADDR'] -netmask = confParams['NETMASK'] -gateway = confParams['GATEWAY'] + +if confParams: +if not ipaddr: +ipaddr = confParams['IPADDR'] +netmask = confParams['NETMASK'] +gateway = confParams['GATEWAY'] +if not mtu: +mtu = confParams['MTU'] if ipaddr: cfg = cfg + 'IPADDR=%s\nNETMASK=%s\n' % (pipes.quote(ipaddr), @@ -392,7 +399,8 @@ cfg = cfg + 'BOOTPROTO=%s\n' % pipes.quote(bootproto) if mtu: -cfg = cfg + 'MTU=%d\n' % mtu +cfg = cfg + 'MTU=%s\n' % mtu + cfg += 'NM_CONTROLLED=no\n' BLACKLIST = ['TYPE', 'NAME', 'DEVICE', 'bondingOptions', 'force', 'blockingdhcp', -- To view, visit http://gerrit.ovirt.org/7322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I48ef1ddd11ae3a9d450d55cf5c68be3b83af5b03 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Restore previous MTU on bond when VLAN with bigger MTU remov...
Igor Lvovsky has uploaded a new change for review. Change subject: Restore previous MTU on bond when VLAN with bigger MTU removed .. Restore previous MTU on bond when VLAN with bigger MTU removed Change-Id: Ifefa5dec03be7795e528821a4d17991eb0f60aea Signed-off-by: Igor Lvovsky ilvov...@redhat.com --- M vdsm/configNetwork.py 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/7323/1 diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py index 199adfa..14b9cfb 100755 --- a/vdsm/configNetwork.py +++ b/vdsm/configNetwork.py @@ -609,6 +609,8 @@ if newmtu != currmtu: if bonding: +cf = self.NET_CONF_PREF + bonding +self._updateConfigValue(cf, 'MTU', newmtu, newmtu is None) slaves = netinfo.slaves(bonding) for slave in slaves: cf = self.NET_CONF_PREF + slave -- To view, visit http://gerrit.ovirt.org/7323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifefa5dec03be7795e528821a4d17991eb0f60aea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Preserve MTU on bond/nic when VLAN without MTU added
oVirt Jenkins CI Server has posted comments on this change. Change subject: Preserve MTU on bond/nic when VLAN without MTU added .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/522/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48ef1ddd11ae3a9d450d55cf5c68be3b83af5b03 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Restore previous MTU on bond when VLAN with bigger MTU remov...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Restore previous MTU on bond when VLAN with bigger MTU removed .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/523/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifefa5dec03be7795e528821a4d17991eb0f60aea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#848299 - Fix delete VLANed network with custom MTU
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#848299 - Fix delete VLANed network with custom MTU .. Patch Set 5: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/524/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I485c8bd3dfa84c421dab2c5d121ad7a5efc348a3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#846004 - IP on nic/bond should be preserved when VLAN add...
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#846004 - IP on nic/bond should be preserved when VLAN added .. Patch Set 4: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/525/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6481c64c285b8a9bd6f6cc49c1c84507c91603 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Optimize _getConfigValue to return multiple values
oVirt Jenkins CI Server has posted comments on this change. Change subject: Optimize _getConfigValue to return multiple values .. Patch Set 4: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/526/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7306 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15ff5542095d51f33f5f1970b81a4a0cbfb30632 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Optimize _getConfigValue to return multiple values
Dan Kenigsberg has posted comments on this change. Change subject: Optimize _getConfigValue to return multiple values .. Patch Set 4: I would prefer that you didn't submit this reinstating my previous score -- To view, visit http://gerrit.ovirt.org/7306 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15ff5542095d51f33f5f1970b81a4a0cbfb30632 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#846004 - IP on nic/bond should be preserved when VLAN add...
Dan Kenigsberg has posted comments on this change. Change subject: BZ#846004 - IP on nic/bond should be preserved when VLAN added .. Patch Set 4: I would prefer that you didn't submit this (1 inline comment) File vdsm/configNetwork.py Line 370: cf = self.NET_CONF_PREF + name Line 371: cfg = DEVICE=%s\nONBOOT=%s\n % (pipes.quote(name), Line 372: pipes.quote(onboot)) Line 373: cfg += conf Line 374: # Check whether we need to preserve prev ip/mask/gateway I do not see my main issue related by this version... Line 375: if not ipaddr and os.path.exists(cf): Line 376: ipaddr = self._getConfigValue(cf, 'IPADDR') Line 377: netmask = self._getConfigValue(cf, 'NETMASK') Line 378: gateway = self._getConfigValue(cf, 'GATEWAY') -- To view, visit http://gerrit.ovirt.org/7259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6481c64c285b8a9bd6f6cc49c1c84507c91603 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix a race existing in the singleton interface of clientIF
Adam Litke has posted comments on this change. Change subject: Fix a race existing in the singleton interface of clientIF .. Patch Set 1: Verified; Looks good to me, but someone else must approve Verified that this fixes the issue for me. Thanks for the patch Mark. Dan, please apply. -- To view, visit http://gerrit.ovirt.org/7283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d907f5613963438c99749da674bb6588a23fe38 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding hooks support for NIC hotplug
Dan Kenigsberg has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug
..
Patch Set 1: (4 inline comments)
Thanks, Izik, for this patch. I think it would be cool to add more hook
locations to vdsm.
I have a couple of questions inside. Please update the man page in this commit,
too.
File vdsm/hooks.py
Line 173: return _runHooksDir(domxml, 'after_vm_set_ticket', vmconf=vmconf,
Line 174: raiseError=False, params=params)
Line 175:
Line 176:
Line 177: def before_nic_hotplug(domxml, vmconf={}):
it's not domxml, but nicxml, or something.
Line 178: return _runHooksDir(domxml, 'before_vm_hotplug', vmconf=vmconf)
Line 179:
Line 180:
Line 181: def after_nic_unplug(domxml, vmconf={}):
Line 178: return _runHooksDir(domxml, 'before_vm_hotplug', vmconf=vmconf)
Line 179:
Line 180:
Line 181: def after_nic_unplug(domxml, vmconf={}):
Line 182: return _runHooksDir(domxml, 'after_vm_unplug', vmconf=vmconf)
I think you don't want this hook to raiseError. if the hook script fails,
nothing is to be canceled.
Line 183:
Line 184:
Line 185: def before_vdsm_start():
Line 186: return _runHooksDir(None, 'before_vdsm_start', raiseError=False)
File vdsm/libvirtvm.py
Line 1401: try:
Line 1402: self._dom.attachDevice(nicXml)
Line 1403: except libvirt.libvirtError, e:
Line 1404: self.log.error(Hotplug failed, exc_info=True)
Line 1405: nicXml = hooks.after_nic_unplug(nicXml, self.conf)
we've never had a similar hook, placed in a fail condition. I suppose that it
is here in order to release resources that where allocated in
before_nic_hotplug.
I find the naming quite misleading - there was *no* unplug in this case. Maybe
another name (after_nic_hotplug_fail??) would make it clearer, maybe something
completely different.
Line 1406: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 1407: return errCode['noVM']
Line 1408: return {'status' : {'code':
errCode['hotplugNic']['status']['code'],
Line 1409: 'message': e.message}}
Line 1455: self.saveState()
Line 1456:
Line 1457: try:
Line 1458: self._dom.detachDevice(nicXml)
Line 1459: hooks.after_nic_unplug(nicXml, self.conf)
does this really need to sit in the try-block?
Line 1460: except libvirt.libvirtError, e:
Line 1461: self.log.error(Hotunplug failed, exc_info=True)
Line 1462: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 1463: return errCode['noVM']
--
To view, visit http://gerrit.ovirt.org/7224
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Itzik Brown itz...@mellanox.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding hooks support for NIC hotplug
Dan Kenigsberg has posted comments on this change. Change subject: Adding hooks support for NIC hotplug .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) oh, updating the unit test would be appreciated, too. File vdsm_hooks/Makefile.am Line 73:before_vm_destroy \ Line 74:after_vm_destroy \ Line 75: before_vm_set_ticket \ Line 76:after_vm_set_ticket \ Line 77: before_nic_plug \ you're not the first, but please use tabs here, like most of the hooks. Line 78: after_nic_unplug \ Line 79:before_vdsm_start \ Line 80:after_vdsm_stop Line 81: -- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itz...@mellanox.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#846323 - Search PV's belonging to the VG in removeVG.
Ayal Baron has posted comments on this change. Change subject: BZ#846323 - Search PV's belonging to the VG in removeVG. .. Patch Set 2: I would prefer that you didn't submit this (2 inline comments) File vdsm/storage/lvm.py Line 859: Line 860: Line 861: def removeVG(vgName): Line 862: pvs = tuple(pv for pv in _lvminfo._pvs.iterkeys() Line 863: if not isinstance(pv, Stub) and pv.vg_name == vgName) This should be done *after* call to vgremove Line 864: # PVS needs to be reloaded anyhow: if vg is removed they are staled, Line 865: # if vg remove failed, something must be wrong with devices and we want Line 866: # cache updated as well Line 867: _lvminfo._invalidatepvs(pvs) Line 863: if not isinstance(pv, Stub) and pv.vg_name == vgName) Line 864: # PVS needs to be reloaded anyhow: if vg is removed they are staled, Line 865: # if vg remove failed, something must be wrong with devices and we want Line 866: # cache updated as well Line 867: _lvminfo._invalidatepvs(pvs) invalidating before removing VG is raceful (can be refreshed before removal of vg) Line 868: # Remove the vg from the cache Line 869: _lvminfo._vgs.pop(vgName, None) Line 870: # and now destroy it Line 871: cmd = [vgremove, -f, vgName] -- To view, visit http://gerrit.ovirt.org/7066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica565f74774fd1dcce7c18361aef5e1464c78b68 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Haim Ateya hat...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix a race existing in the singleton interface of clientIF
Dan Kenigsberg has posted comments on this change. Change subject: Fix a race existing in the singleton interface of clientIF .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d907f5613963438c99749da674bb6588a23fe38 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix a race existing in the singleton interface of clientIF
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix a race existing in the singleton interface of clientIF .. Fix a race existing in the singleton interface of clientIF There's a race in getInstance() between clientIF initialization and MOM thread. If for some reason the initialization of clientIF is slowed down and not finished before MOM calls vdsm API, an exception will happen in MOM thread due to that the parameter 'log' is missing. The fix is just moving the parameter check into the protection of the singleton lock. Then MOM thread will be blocked if it tries to access vdsm API when the initialization of clientIF is ongoing. Change-Id: I6d907f5613963438c99749da674bb6588a23fe38 Signed-off-by: Mark Wu wu...@linux.vnet.ibm.com --- M vdsm/clientIF.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Adam Litke: Verified; Looks good to me, but someone else must approve Royce Lv: Looks good to me, but someone else must approve Mark Wu: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d907f5613963438c99749da674bb6588a23fe38 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add deathSignal options to better popen
Dan Kenigsberg has posted comments on this change. Change subject: Add deathSignal options to better popen .. Patch Set 10: Looks good to me, but someone else must approve I would have expected that you, of all people, would add a unit test for the new functionality. -- To view, visit http://gerrit.ovirt.org/6241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
