Change in vdsm[master]: wip vdsm: improve message when trying to attach import domai...
Oved Ourfali has posted comments on this change. Change subject: wip vdsm: improve message when trying to attach import domain with wrong permissions (#842146) .. Patch Set 4: (1 inline comment) File vdsm/storage/storageServer.py Line 416: def _getLocalPath(self): Line 417: return os.path.join(self.localPathBase, self._path.replace(_, __).replace(/, _)) Line 418: Line 419: def checkTarget(self): Line 420: return os.path.exists(self._path) and os.path.isdir(self._path) Currently, the validateDirAccess function checks for os.R_OK and os.X_OK. Weird that it doesn't check for W_OK. Changing it will effect all locations that use it, but it seems right, as we obviously need write permissions there, right? Line 421: Line 422: def checkLink(self): Line 423: lnPath = self._getLocalPath() Line 424: if os.path.lexists(lnPath): -- To view, visit http://gerrit.ovirt.org/7339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76880b1445f259431d7aa691eda676e1210308e4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added xml option in gluster command execution.
Bala.FA has posted comments on this change.
Change subject: Added xml option in gluster command execution.
..
Patch Set 1: (2 inline comments)
File vdsm/gluster/cli.py
Line 62: DISCONNECTED = 'DISCONNECTED'
Line 63: UNKNOWN = 'UNKNOWN'
Line 64:
Line 65:
Line 66: def _execGluster(cmd, xml=False):
Done
Line 67: if not xml:
Line 68: return utils.execCmd(cmd)
Line 69:
Line 70: cmd.append('--xml')
Line 77: msg = tree.find('opErrstr').text
Line 78: except (etree.ParseError, AttributeError):
Line 79: raise ge.GlusterXmlErrorException(err=out)
Line 80: if rv == '0':
Line 81: return (None, (tree, out))
The return value is (err, xmlout), here err=(rv, msg), xmlout=(tree, out).
Either one is set based on rv.
Issue in raising exception is that each command function should catch and raise
again with appropriate exception specific to the function.
If this is OK, I can do the change accordingly
Line 82: else:
Line 83: return ((rv, [msg]), None)
Line 84:
Line 85:
--
To view, visit http://gerrit.ovirt.org/6999
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I385f992005d446b417be84eb7ff484e4edf6e5b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: infra: adding debug log to vdsm daemon init script
Yaniv Bronhaim has posted comments on this change. Change subject: infra: adding debug log to vdsm daemon init script .. Patch Set 7: Verified -- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 9: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/608/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: infra: adding debug log to vdsm daemon init script
oVirt Jenkins CI Server has posted comments on this change. Change subject: infra: adding debug log to vdsm daemon init script .. Patch Set 7: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/609/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: improve message when trying to attach import domain wi...
Oved Ourfali has posted comments on this change. Change subject: vdsm: improve message when trying to attach import domain with wrong permissions (#842146) .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/7339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76880b1445f259431d7aa691eda676e1210308e4 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: improve message when trying to attach import domain wi...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: improve message when trying to attach import domain with wrong permissions (#842146) .. Patch Set 5: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/610/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76880b1445f259431d7aa691eda676e1210308e4 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: improve message when trying to attach import domain wi...
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: improve message when trying to attach import domain with wrong permissions (#842146) .. Patch Set 5: (1 inline comment) Commit Message Line 3: AuthorDate: 2012-08-22 11:14:41 +0300 Line 4: Commit: Oved Ourfali oourf...@redhat.com Line 5: CommitDate: 2012-08-23 10:31:23 +0300 Line 6: Line 7: vdsm: improve message when trying to attach import domain with wrong permissions (#842146) Please drop the vdsm: prefix. We know this is a Vdsm patch. Please adhere to project standard about mentioning the BZ#. I think they are currently Bug-Id: BZ#XX Line 8: Line 9: https://bugzilla.redhat.com/842146 Line 10: Line 11: When a storage domain is attached, and there is something wrong with the -- To view, visit http://gerrit.ovirt.org/7339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76880b1445f259431d7aa691eda676e1210308e4 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#846004 - IP on nic/bond should be preserved when VLAN add...
Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#846004 - IP on nic/bond should be preserved when VLAN added .. BZ#846004 - IP on nic/bond should be preserved when VLAN added Change-Id: I5a6481c64c285b8a9bd6f6cc49c1c84507c91603 Signed-off-by: Igor Lvovsky ilvov...@redhat.com --- M vdsm/configNetwork.py 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a6481c64c285b8a9bd6f6cc49c1c84507c91603 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#846004 - IP on nic/bond should be preserved when VLAN add...
Dan Kenigsberg has posted comments on this change. Change subject: BZ#846004 - IP on nic/bond should be preserved when VLAN added .. Patch Set 7: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6481c64c285b8a9bd6f6cc49c1c84507c91603 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Restore previous MTU on bond when VLAN with bigger MTU remov...
Dan Kenigsberg has posted comments on this change. Change subject: Restore previous MTU on bond when VLAN with bigger MTU removed .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifefa5dec03be7795e528821a4d17991eb0f60aea Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Restore previous MTU on bond when VLAN with bigger MTU remov...
Dan Kenigsberg has submitted this change and it was merged. Change subject: Restore previous MTU on bond when VLAN with bigger MTU removed .. Restore previous MTU on bond when VLAN with bigger MTU removed Change-Id: Ifefa5dec03be7795e528821a4d17991eb0f60aea Signed-off-by: Igor Lvovsky ilvov...@redhat.com --- M vdsm/configNetwork.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifefa5dec03be7795e528821a4d17991eb0f60aea Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configNetwork: use MTU as int in setNewMtu
Dan Kenigsberg has posted comments on this change. Change subject: configNetwork: use MTU as int in setNewMtu .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/7360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ab6c3c624c284a8ffed34f16836a1d3d75f8eea Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: improve message when trying to attach import domain with wro...
oVirt Jenkins CI Server has posted comments on this change. Change subject: improve message when trying to attach import domain with wrong permissions .. Patch Set 6: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/611/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76880b1445f259431d7aa691eda676e1210308e4 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add simple VM creation functional test
Deepak C Shetty has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
File tests/functional/vmTests.py
Line 44: kernelPath = /boot/vmlinuz- + kernelVer
Line 45: initramfsPath = /boot/initramfs-%s.img % kernelVer
Line 46: vmid = str(uuid.uuid4())
Line 47: conf = {'display': 'vnc',
Line 48: 'initrd': initramfsPath,
Can we say display:local so that we keep the baggage minimum, since we can't
remove it.
Line 49: 'kernel': kernelPath,
Line 50: # Fedora uses dracut to create initramfs. The following
Line 51: # arguments will be interpreted by init scripts
created by
Line 52: # dracut.
Line 66: while True:
Line 67: vmUp = self.isVMUp(vmid)
Line 68: guestUp = self.isGuestUp(vmid)
Line 69: if vmUp and guestUp:
Line 70: break
Wouldn't it be better to check for isGuestUp only when Vm is up, else don't do
it.?
Line 71: now = time.time()
Line 72: if now - start timeout:
Line 73: raise Exception(Creating VM timeout.\n
Line 74: VM Up: %r, Guest Up: %r.\n
--
To view, visit http://gerrit.ovirt.org/7396
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0d86ce20a547ef809d5407fe12d6ade474c4d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: make vdsm/libvirtvm.py PEP 8 clean
Antoni Segura Puimedon has posted comments on this change.
Change subject: make vdsm/libvirtvm.py PEP 8 clean
..
Patch Set 5: (2 inline comments)
This one is quite close to it. Just a couple of changes and I'll gladly give a
+1.
File vdsm/libvirtvm.py
Line 2114: #'allocation' will give the qcow2 image size
Line 2115: #D. Berrange
Line 2116: capacity, alloc, physical =
self._dom.blockInfo(d.path, 0)
Line 2117: if (physical (alloc + config.getint(
Line 2118: 'irs',
I think It'd be easier to read if the condition would be formatted like in 2198.
Line 2119:
'volume_utilization_chunk_mb'))):
Line 2120: self.log.warn('%s = %s/%s error %s phys: %s
alloc: %s '
Line 2121: 'Ingnoring already managed
event.',
Line 2122: blockDevAlias, d.domainID,
d.volumeID,
Line 2191: self.guestAgent.stop()
Line 2192: if self._dom:
Line 2193: try:
Line 2194: self._dom.destroyFlags(
Line 2195:
libvirt.VIR_DOMAIN_DESTROY_GRACEFUL)
Too much indentation, I believe.
Line 2196: except libvirt.libvirtError, e:
Line 2197: if (e.get_error_code() ==
Line 2198: libvirt.VIR_ERR_OPERATION_FAILED):
Line 2199: self.log.warn(Failed to destroy VM '%s'
--
To view, visit http://gerrit.ovirt.org/6561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12735cc8fdaeb91c77f63e16a262b0cd8acfbba4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtvm: unsetPortMirroring just before hotunplug
Dan Kenigsberg has uploaded a new change for review. Change subject: libvirtvm: unsetPortMirroring just before hotunplug .. libvirtvm: unsetPortMirroring just before hotunplug Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248 Signed-off-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/libvirtvm.py 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/7425/1 diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py index acc9399..e3d8915 100644 --- a/vdsm/libvirtvm.py +++ b/vdsm/libvirtvm.py @@ -1436,6 +1436,10 @@ break if nic: +if hasattr(nic, 'portMirroring'): +for network in nic.portMirroring: +supervdsm.getProxy().unsetPortMirroring(network, nic.name) + nicXml = nic.getXML().toprettyxml(encoding='utf-8') self.log.debug(Hotunplug NIC xml: %s, nicXml) else: -- To view, visit http://gerrit.ovirt.org/7425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: add to PEP8_WHITELIST
Dan Kenigsberg has uploaded a new change for review.
Change subject: tc: add to PEP8_WHITELIST
..
tc: add to PEP8_WHITELIST
Change-Id: I1b3b1d8de08ea8fac5cd3debb53f22d7a7a8ad87
Signed-off-by: Dan Kenigsberg dan...@redhat.com
---
M Makefile.am
M tests/tcTests.py
M vdsm/tc.py
3 files changed, 28 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/7426/1
diff --git a/Makefile.am b/Makefile.am
index 5f17f63..e617c6a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -89,6 +89,7 @@
vdsm/storage/volume.py \
vdsm/supervdsm.py \
vdsm/supervdsmServer.py \
+ vdsm/tc.py \
vdsm_cli \
vdsm_hooks/fileinject/before_vm_start.py \
vdsm_hooks/promisc/after_vm_start.py \
@@ -99,7 +100,8 @@
vdsm_hooks/vhostmd/after_vm_destroy.py \
vdsm_hooks/vhostmd/before_vm_start.py \
vdsm_reg/createDaemon.py \
- vdsm_reg/define.py
+ vdsm_reg/define.py \
+ $(NULL)
PEP8_BLACKLIST = \
restData.py
diff --git a/tests/tcTests.py b/tests/tcTests.py
index 7e09761..c60efff 100644
--- a/tests/tcTests.py
+++ b/tests/tcTests.py
@@ -43,12 +43,12 @@
class _Interface():
-def __init__(self):
-self.devName = self._generateRandomBridgeName()
+def __init__(self, prefix='vdsmtest-'):
+self.devName = self._generateRandomName(prefix)
-def _generateRandomBridgeName(self):
+def _generateRandomName(self, prefix):
char_set = string.ascii_letters + string.digits
-return 'vdsmtest-' + ''.join(random.sample(char_set, 5))
+return prefix + ''.join(random.sample(char_set, 5))
def _ifUp(self):
check_call([EXT_IP, link, set, self.devName, up])
@@ -162,7 +162,7 @@
return popen.stdout.read()
def _addIngress(self):
-tc.qdisc_add_ingress(self._bridge.devName)
+tc.qdisc_replace_ingress(self._bridge.devName)
self.assertTrue(qdisc ingress in self._showQdisc(),
Could not add an ingress qdisc to the device.)
@@ -231,24 +231,31 @@
_tap0 = _Tap()
_tap1 = _Tap()
-_bridge0 = _Bridge()
-_bridge1 = _Bridge()
+_tap2 = _Tap()
+_bridge0 = _Bridge('src-')
+_bridge1 = _Bridge('target-')
+_bridge2 = _Bridge('target2-')
@ValidateRunningAsRoot
def setUp(self):
_checkDependencies()
self._tap0.addDevice()
self._tap1.addDevice()
+self._tap2.addDevice()
self._bridge0.addDevice()
self._bridge1.addDevice()
+self._bridge2.addDevice()
self._bridge0.addIf(self._tap0.devName)
self._bridge1.addIf(self._tap1.devName)
+self._bridge2.addIf(self._tap2.devName)
def tearDown(self):
self._tap0.delDevice()
self._tap1.delDevice()
+self._tap2.delDevice()
self._bridge0.delDevice()
self._bridge1.delDevice()
+self._bridge2.delDevice()
def _sendPing(self):
self._tap1.startListener(self._ICMP)
@@ -264,9 +271,15 @@
def testMirroring(self):
tc.setPortMirroring(self._bridge0.devName, self._bridge1.devName)
-self.assertTrue(self._sendPing(), Bridge received no mirrored ping
+self.assertTrue(self._sendPing(), Bridge received no mirrored ping
requests.)
tc.unsetPortMirroring(self._bridge0.devName, self._bridge1.devName)
-self.assertFalse(self._sendPing(), Bridge received mirrored ping
+self.assertFalse(self._sendPing(), Bridge received mirrored ping
requests, but mirroring is unset.)
+
+def testMirroringWithDistraction(self):
+setting another mirror action should not obstract the first one
+tc.setPortMirroring(self._bridge0.devName, self._bridge2.devName)
+self.testMirroring()
+tc.unsetPortMirroring(self._bridge0.devName, self._bridge2.devName)
diff --git a/vdsm/tc.py b/vdsm/tc.py
index 9998bd1..db699df 100644
--- a/vdsm/tc.py
+++ b/vdsm/tc.py
@@ -94,7 +94,6 @@
raise
-
def filter_replace(dev, parent, filt):
command = [EXT_TC, 'filter', 'replace', 'dev', dev, 'parent', parent]
if filt.prio:
@@ -118,10 +117,12 @@
'parent', 'root', 'prio']
_process_request(command)
+
def qdisc_get_devid(dev):
command = [EXT_TC, 'qdisc', 'show', 'dev', dev]
out = _process_request(command)
return out.split(' ')[2]
+
def qdisc_del(dev, queue):
try:
@@ -131,6 +132,7 @@
if e.errCode != ERR_DEV_NOEXIST:
raise
+
def set_promisc(dev, on=True):
promisc = 'promisc'
if not on:
--
To view, visit http://gerrit.ovirt.org/7426
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b3b1d8de08ea8fac5cd3debb53f22d7a7a8ad87
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
Change in vdsm[master]: tc: list some information about filters
Antoni Segura Puimedon has posted comments on this change. Change subject: tc: list some information about filters .. Patch Set 3: Looks good to me, but someone else must approve I'll verify the unit test asap as well. -- To view, visit http://gerrit.ovirt.org/7298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22953e6d09f846cae18d15a54cd6e5c9e4519e20 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: rename qdisc_replace_prio()
Antoni Segura Puimedon has posted comments on this change. Change subject: tc: rename qdisc_replace_prio() .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9628244a144ece23b793e260e077dcee9698eba Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use quiesce only if qgaEnable is enabled
Federico Simoncelli has posted comments on this change. Change subject: Use quiesce only if qgaEnable is enabled .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/7143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a44758949d7a328117f4d759d8d9df1183eb058 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: list some information about filters
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: list some information about filters .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/612/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22953e6d09f846cae18d15a54cd6e5c9e4519e20 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use quiesce only if qgaEnable is enabled
Dan Kenigsberg has submitted this change and it was merged. Change subject: Use quiesce only if qgaEnable is enabled .. Use quiesce only if qgaEnable is enabled Do not attempt to use the quiesce live snapshot flag if the guest agent channel is not present. Signed-off-by: Federico Simoncelli fsimo...@redhat.com Change-Id: I8a44758949d7a328117f4d759d8d9df1183eb058 --- M vdsm/libvirtvm.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Ayal Baron: Looks good to me, approved Mark Wu: Looks good to me, but someone else must approve Federico Simoncelli: Verified Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a44758949d7a328117f4d759d8d9df1183eb058 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: refine unsetPortMirroring
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: refine unsetPortMirroring .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/613/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09b315e7398c2293dc6f84ab63853b70308b2875 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: rename qdisc_replace_prio()
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: rename qdisc_replace_prio() .. Patch Set 3: Build Failed http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/614/ : FAILURE -- To view, visit http://gerrit.ovirt.org/7300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9628244a144ece23b793e260e077dcee9698eba Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtvm: unsetPortMirroring just before hotunplug
oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirtvm: unsetPortMirroring just before hotunplug .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/615/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: add to PEP8_WHITELIST
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: add to PEP8_WHITELIST .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/616/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b3b1d8de08ea8fac5cd3debb53f22d7a7a8ad87 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ship the version file with the tarballs
Alon Bar-Lev has posted comments on this change. Change subject: Ship the version file with the tarballs .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b72a1740803a9401e4b5a4504a4faa07c29f2b9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: list some information about filters
Antoni Segura Puimedon has posted comments on this change. Change subject: tc: list some information about filters .. Patch Set 3: Verified Unit tests work without any issue. -- To view, visit http://gerrit.ovirt.org/7298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22953e6d09f846cae18d15a54cd6e5c9e4519e20 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: rename qdisc_replace_prio()
Antoni Segura Puimedon has posted comments on this change. Change subject: tc: rename qdisc_replace_prio() .. Patch Set 3: Fails; I would prefer that you didn't submit this (1 inline comment) On running tcTests, this patch breaks them. File vdsm/tc.py Line 34: Exception.__init__(self, self.errCode, self.message, self.command) Line 35: Line 36: def setPortMirroring(network, target): Line 37: qdisc_replace_ingress(network) Line 38: add_filter(network, target, ':') Shouldn't this patch change this line's method as well? Line 39: qdisc_replace_parent(network) Line 40: devid = qdisc_get_devid(network) Line 41: add_filter(network, target, devid) Line 42: set_promisc(network, True) -- To view, visit http://gerrit.ovirt.org/7300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9628244a144ece23b793e260e077dcee9698eba Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Produce the domain in the domain monitor thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: Produce the domain in the domain monitor thread .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/617/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: make vdsm/libvirtvm.py PEP 8 clean
Zhou Zheng Sheng has posted comments on this change. Change subject: make vdsm/libvirtvm.py PEP 8 clean .. Patch Set 6: Thanks Antoni! -- To view, visit http://gerrit.ovirt.org/6561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12735cc8fdaeb91c77f63e16a262b0cd8acfbba4 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP]Add text-based console support
ShaoHe Feng has posted comments on this change. Change subject: [WIP]Add text-based console support .. Patch Set 1: I would prefer that you didn't submit this why not use fix port? such as ssh vmuuid@adrress -p port. or ssh vmname@adrress -p port -- To view, visit http://gerrit.ovirt.org/7165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69904bf7aafd4f764a256d4075c9bf71d988e7c5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: make vdsm/libvirtvm.py PEP 8 clean
oVirt Jenkins CI Server has posted comments on this change. Change subject: make vdsm/libvirtvm.py PEP 8 clean .. Patch Set 6: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/618/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/6561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12735cc8fdaeb91c77f63e16a262b0cd8acfbba4 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add simple VM creation functional test
oVirt Jenkins CI Server has posted comments on this change. Change subject: add simple VM creation functional test .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/619/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb0d86ce20a547ef809d5407fe12d6ade474c4d2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add simple VM creation functional test
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 2: (2 inline comments)
File tests/functional/vmTests.py
Line 44: kernelPath = /boot/vmlinuz- + kernelVer
Line 45: initramfsPath = /boot/initramfs-%s.img % kernelVer
Line 46: vmid = str(uuid.uuid4())
Line 47: conf = {'display': 'vnc',
Line 48: 'initrd': initramfsPath,
Tried to set display to local, but it causes an exception in vdsm/vm.py
Traceback (most recent call last):
File /usr/share/vdsm/vm.py, line 569, in _startUnderlyingVm
self._run()
File /usr/share/vdsm/libvirtvm.py, line 1311, in _run
devices = self.buildConfDevices()
File /usr/share/vdsm/vm.py, line 416, in buildConfDevices
devices[VIDEO_DEVICES] = self.getConfVideo()
File /usr/share/vdsm/vm.py, line 460, in getConfVideo
'device': devType})
I am a little confused after reading the related code. It seems that there is
no obvious way to create a VM without a display device. Can anyone show me the
correct conf dict for this purpose?
Line 49: 'kernel': kernelPath,
Line 50: # Fedora uses dracut to create initramfs. The following
Line 51: # arguments will be interpreted by init scripts
created by
Line 52: # dracut.
Line 66: while True:
Line 67: vmUp = self.isVMUp(vmid)
Line 68: guestUp = self.isGuestUp(vmid)
Line 69: if vmUp and guestUp:
Line 70: break
Done
Line 71: now = time.time()
Line 72: if now - start timeout:
Line 73: raise Exception(Creating VM timeout.\n
Line 74: VM Up: %r, Guest Up: %r.\n
--
To view, visit http://gerrit.ovirt.org/7396
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0d86ce20a547ef809d5407fe12d6ade474c4d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: improve message when trying to attach import domain with wro...
Ayal Baron has posted comments on this change. Change subject: improve message when trying to attach import domain with wrong permissions .. Patch Set 6: Looks good to me, but someone else must approve (1 inline comment) File vdsm/storage/storageServer.py Line 190: raise Line 191: Line 192: self._mount.mount(self.options, self._vfsType) Line 193: Line 194: if self.isConnected(): check is irrelevant here. Line 195: try: Line 196: validatePermissions(self.getMountObj().getRecord().fs_file) Line 197: except StorageServerAccessPermissionError: Line 198: self.disconnect() -- To view, visit http://gerrit.ovirt.org/7339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76880b1445f259431d7aa691eda676e1210308e4 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: improve message when trying to attach import domain with wro...
Oved Ourfali has posted comments on this change. Change subject: improve message when trying to attach import domain with wrong permissions .. Patch Set 7: addressed Ayal's comments (removed the redundant test). -- To view, visit http://gerrit.ovirt.org/7339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76880b1445f259431d7aa691eda676e1210308e4 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: improve message when trying to attach import domain with wro...
oVirt Jenkins CI Server has posted comments on this change. Change subject: improve message when trying to attach import domain with wrong permissions .. Patch Set 7: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/620/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76880b1445f259431d7aa691eda676e1210308e4 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
Joey Boggs has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: make TCException more accessible programmatically
Dan Kenigsberg has uploaded a new change for review. Change subject: tc: make TCException more accessible programmatically .. tc: make TCException more accessible programmatically Change-Id: I110fd34ea36e773fc46019e0ef1af79bb795a44f Signed-off-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/tc.py 1 file changed, 5 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/7433/1 diff --git a/vdsm/tc.py b/vdsm/tc.py index ddf7281..1bb38d1 100644 --- a/vdsm/tc.py +++ b/vdsm/tc.py @@ -18,20 +18,20 @@ # Refer to the README and COPYING files for full details of the license # -from subprocess import list2cmdline from collections import namedtuple import storage.misc from vdsm.constants import EXT_TC, EXT_IFCONFIG ERR_DEV_NOEXIST = 2 -PROC_ERROR_MSG = 'error executing command %s error: %s' + class TrafficControlException(Exception): -def __init__(self, errCode, message): +def __init__(self, errCode, message, command): self.errCode = errCode self.message = message -Exception.__init__(self, self.errCode, self.message) +self.command = command +Exception.__init__(self, self.errCode, self.message, self.command) def setPortMirroring(network, target): qdisc_add_ingress(network) @@ -49,8 +49,7 @@ def _process_request(command): retcode, out, err = storage.misc.execCmd(command, raw=True, sudo=False) if retcode != 0: -msg = PROC_ERROR_MSG % (list2cmdline(command), err) -raise TrafficControlException(retcode, msg) +raise TrafficControlException(retcode, err, command) return out def qdisc_add_ingress(dev): -- To view, visit http://gerrit.ovirt.org/7433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I110fd34ea36e773fc46019e0ef1af79bb795a44f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: silently ignore ingress qdisc re-creation
Dan Kenigsberg has uploaded a new change for review. Change subject: tc: silently ignore ingress qdisc re-creation .. tc: silently ignore ingress qdisc re-creation We should allow starting up two VMs monitorring a single bridge. Change-Id: Ib58c14cc8bfd5fe6e6a3efe86a1b1da4658a2b0f Signed-off-by: Dan Kenigsberg dan...@redhat.com --- M tests/tcTests.py M vdsm/tc.py 2 files changed, 12 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/7434/1 diff --git a/tests/tcTests.py b/tests/tcTests.py index c28fae1..23f8e64 100644 --- a/tests/tcTests.py +++ b/tests/tcTests.py @@ -162,7 +162,7 @@ return popen.stdout.read() def _addIngress(self): -tc.qdisc_add_ingress(self._bridge.devName) +tc.qdisc_replace_ingress(self._bridge.devName) self.assertTrue(qdisc ingress in self._showQdisc(), Could not add an ingress qdisc to the device.) diff --git a/vdsm/tc.py b/vdsm/tc.py index 1bb38d1..6b970ad 100644 --- a/vdsm/tc.py +++ b/vdsm/tc.py @@ -34,7 +34,7 @@ Exception.__init__(self, self.errCode, self.message, self.command) def setPortMirroring(network, target): -qdisc_add_ingress(network) +qdisc_replace_ingress(network) add_filter(network, target, ':') qdisc_replace_parent(network) devid = qdisc_get_devid(network) @@ -52,9 +52,17 @@ raise TrafficControlException(retcode, err, command) return out -def qdisc_add_ingress(dev): + +def qdisc_replace_ingress(dev): command = [EXT_TC, 'qdisc', 'add', 'dev', dev, 'ingress'] -_process_request(command) +try: +_process_request(command) +except TrafficControlException as e: +if e.message == 'RTNETLINK answers: File exists\n': +pass +else: +raise + def add_filter(dev, target, parentId=':'): command = [EXT_TC, 'filter', 'add', 'dev', dev, 'parent', -- To view, visit http://gerrit.ovirt.org/7434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib58c14cc8bfd5fe6e6a3efe86a1b1da4658a2b0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
Hello Bala.FA, Saggi Mizrahi, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/7436
to review the following change.
Change subject: added glusterVolumeProfileInfo verb
..
added glusterVolumeProfileInfo verb
Following is the output structure
{ 'statusCode' : CODE,
'volumeName' : VOLUME-NAME,
'brickCount' : BRICK-COUNT,
'bricks' : {
BRICK-NAME: {
'cumulativeStats': {
'blockStat': [
{ 'size': SIZE,
'read': READ-COUNT,
'write': WRITE-COUNT
}, ...],
'fopStat': [
{ 'name': FOP-NAME,
'hits': HITS,
'latencyAvg': AVERAGE-LATENCY,
'latencyMin': MINIMUM-LATENCY,
'latencyMax': MAXIMUM-LATENCY
}, ...],
'duration': DURATION,
'totalRead': TOTAL-READ,
'totalWrite': TOTAL-WRITE },
'intervalStats': {
'blockStat': [
{ 'size': SIZE,
'read': READ-COUNT,
'write': WRITE-COUNT
}, ...],
'fopStat': [
{ 'name': FOP-NAME,
'hits': HITS,
'latencyAvg': AVERAGE-LATENCY,
'latencyMin': MINIMUM-LATENCY,
'latencyMax': MAXIMUM-LATENCY
}, ...],
'duration': DURATION,
'totalRead': TOTAL-READ,
'totalWrite': TOTAL-WRITE }}, ...}}
Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c
Signed-off-by: Timothy Asir tjeya...@redhat.com
---
M vdsm/gluster/api.py
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
M vdsm_cli/vdsClientGluster.py
4 files changed, 81 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/7436/1
diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index dc3ec0b..9073791 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -229,6 +229,11 @@
def volumeProfileStop(self, volumeName, options=None):
self.svdsmProxy.glusterVolumeProfileStop(volumeName)
+@exportAsVerb
+def volumeProfileInfo(self, volumeName, options=None):
+status = self.svdsmProxy.glusterVolumeProfileInfo(volumeName)
+return {'profileInfo': status}
+
def getGlusterMethods(gluster):
l = []
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index 2618aa1..059bff4 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -155,6 +155,54 @@
return volumeInfoDict
+def _parseGlusterVolumeProfileInfo(tree):
+fopCumulative = []
+blkCumulative = []
+fopInterval = []
+blkInterval = []
+bricks = {}
+for brick in tree.findall('volProfile/brick'):
+for block in brick.findall('cumulativeStats/blockStats/block'):
+blkCumulative.append({'size': block.find('size').text,
+ 'read': block.find('reads').text,
+ 'write': block.find('writes').text})
+for fop in brick.findall('cumulativeStats/fopStats/fop'):
+fopCumulative.append({'name': fop.find('name').text,
+ 'hits': fop.find('hits').text,
+ 'latencyAvg': fop.find('avgLatency').text,
+ 'latencyMin': fop.find('minLatency').text,
+ 'latencyMax': fop.find('maxLatency').text})
+for block in brick.findall('intervalStats/blockStats/block'):
+blkInterval.append({'size': block.find('size').text,
+'read': block.find('reads').text,
+'write': block.find('writes').text})
+for fop in brick.findall('intervalStats/fopStats/fop'):
+fopInterval.append({'name': fop.find('name').text,
+'hits': fop.find('hits').text,
+'latencyAvg': fop.find('avgLatency').text,
+'latencyMin': fop.find('minLatency').text,
+'latencyMax': fop.find('maxLatency').text})
+bricks[brick.find('brickName').text] = {
+'cumulativeStats': {
+'blockStats': blkCumulative,
+'fopStats': fopCumulative,
+'duration': brick.find('cumulativeStats/duration').text,
+'totalRead': brick.find('cumulativeStats/totalRead').text,
+'totalWrite': brick.find('cumulativeStats/totalWrite').text},
+'intervalStats': {
+
Change in vdsm[master]: Added glusterVolumeProfileStop verb
Hello Bala.FA, Saggi Mizrahi, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/7435
to review the following change.
Change subject: Added glusterVolumeProfileStop verb
..
Added glusterVolumeProfileStop verb
Change-Id: Ie25c7da7208eb4bf68f67d945fb7c63b44886040
Signed-off-by: Timothy Asir tjeya...@redhat.com
---
M vdsm/gluster/api.py
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
M vdsm_cli/vdsClientGluster.py
4 files changed, 27 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/7435/1
diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index 135f4bb..dc3ec0b 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -225,6 +225,10 @@
def volumeProfileStart(self, volumeName, options=None):
self.svdsmProxy.glusterVolumeProfileStart(volumeName)
+@exportAsVerb
+def volumeProfileStop(self, volumeName, options=None):
+self.svdsmProxy.glusterVolumeProfileStop(volumeName)
+
def getGlusterMethods(gluster):
l = []
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index 9d05568..2618aa1 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -568,3 +568,12 @@
if err:
raise ge.GlusterVolumeProfileStartFailedException(err[0], err[1])
return True
+
+
+@exportToSuperVdsm
+def volumeProfileStop(volumeName):
+command = _getGlusterVolCmd() + [profile, volumeName, stop]
+err, res = _execGluster(command, xml=True)
+if err:
+raise ge.GlusterVolumeProfileStopFailedException(err[0], err[1])
+return True
diff --git a/vdsm/gluster/exception.py b/vdsm/gluster/exception.py
index 29078a9..f5dfb73 100644
--- a/vdsm/gluster/exception.py
+++ b/vdsm/gluster/exception.py
@@ -323,6 +323,11 @@
message = Volume profile start failed
+class GlusterVolumeProfileStopFailedException(GlusterVolumeException):
+code = 4158
+message = Volume profile stop failed
+
+
# Host
class GlusterHostException(GlusterException):
code = 4400
diff --git a/vdsm_cli/vdsClientGluster.py b/vdsm_cli/vdsClientGluster.py
index 1f5d52a..0a253fe 100644
--- a/vdsm_cli/vdsClientGluster.py
+++ b/vdsm_cli/vdsClientGluster.py
@@ -203,6 +203,10 @@
status = self.s.glusterVolumeProfileStart(args[0])
return status['status']['code'], status['status']['message']
+def do_glusterVolumeProfileStop(self, args):
+status = self.s.glusterVolumeProfileStop(args[0])
+return status['status']['code'], status['status']['message']
+
def getGlusterCmdDict(serv):
return {
@@ -364,4 +368,9 @@
('volume_name\n\tvolume_name is existing volume name',
'start gluster volume profile'
)),
+'glusterVolumeProfileStop':
+(serv.do_glusterVolumeProfileStop,
+ ('volume_name\n\tvolume_name is existing volume name',
+ 'stop gluster volume profile'
+ )),
}
--
To view, visit http://gerrit.ovirt.org/7435
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie25c7da7208eb4bf68f67d945fb7c63b44886040
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 4: Looks good to me, approved Thanks, Joey Douglas. -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. vdsm-upgrade: use python scripts from ovirtnode Replace /usr/libexec/ovirt-config-boot call from deployUtil._logExec to the newer python scripts from ovirtnode. Tested: * Installed ovirt-node 2.5.0-2.0 (upgrading to: 2.5.1-1.0) * mkdir /data/updates * Copied 2.5 image to /data/updates/ovirt-node-image.iso * mount -o loop /data/updates/ovirt-node-image.iso /live * Update in /etc/vdsm-reg/vdsm-reg.conf upgrade_mount_point=/live * service vdsm-reg restart * /usr/share/vdsm-reg/vdsm-upgrade * reboot Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com --- M vdsm_reg/vdsm-reg.conf.in M vdsm_reg/vdsm-upgrade 2 files changed, 9 insertions(+), 17 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Joey Boggs: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: list some information about filters
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: list some information about filters .. Patch Set 4: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/621/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22953e6d09f846cae18d15a54cd6e5c9e4519e20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: make TCException more accessible programmatically
Antoni Segura Puimedon has posted comments on this change. Change subject: tc: make TCException more accessible programmatically .. Patch Set 1: Verified; Looks good to me, but someone else must approve It is cleaner and richer this way. -- To view, visit http://gerrit.ovirt.org/7433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I110fd34ea36e773fc46019e0ef1af79bb795a44f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: make TCException more accessible programmatically
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: make TCException more accessible programmatically .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/625/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I110fd34ea36e773fc46019e0ef1af79bb795a44f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: make TCException more accessible programmatically
Dan Kenigsberg has submitted this change and it was merged. Change subject: tc: make TCException more accessible programmatically .. tc: make TCException more accessible programmatically Change-Id: I110fd34ea36e773fc46019e0ef1af79bb795a44f Signed-off-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/tc.py 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Antoni Segura Puimedon: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I110fd34ea36e773fc46019e0ef1af79bb795a44f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: silently ignore ingress qdisc re-creation
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: silently ignore ingress qdisc re-creation .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/626/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib58c14cc8bfd5fe6e6a3efe86a1b1da4658a2b0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: silently ignore ingress qdisc re-creation
Antoni Segura Puimedon has posted comments on this change. Change subject: tc: silently ignore ingress qdisc re-creation .. Patch Set 1: (1 inline comment) Just a small typo in the commit message. After that it is approved. Commit Message Line 5: CommitDate: 2012-08-23 16:18:42 +0300 Line 6: Line 7: tc: silently ignore ingress qdisc re-creation Line 8: Line 9: We should allow starting up two VMs monitorring a single bridge. s/monitorring/monitoring/ Line 10: Line 11: Change-Id: Ib58c14cc8bfd5fe6e6a3efe86a1b1da4658a2b0f -- To view, visit http://gerrit.ovirt.org/7434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib58c14cc8bfd5fe6e6a3efe86a1b1da4658a2b0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: refine unsetPortMirroring
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: refine unsetPortMirroring .. Patch Set 5: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/627/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09b315e7398c2293dc6f84ab63853b70308b2875 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: rename qdisc_replace_prio()
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: rename qdisc_replace_prio() .. Patch Set 5: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/628/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9628244a144ece23b793e260e077dcee9698eba Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtvm: unsetPortMirroring just before hotunplug
oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirtvm: unsetPortMirroring just before hotunplug .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/629/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: rename qdisc_replace_prio()
Antoni Segura Puimedon has posted comments on this change. Change subject: tc: rename qdisc_replace_prio() .. Patch Set 5: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9628244a144ece23b793e260e077dcee9698eba Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added xml option in gluster command execution.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added xml option in gluster command execution. .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/630/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/6999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I385f992005d446b417be84eb7ff484e4edf6e5b6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added glusterVolumeProfileStart verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added glusterVolumeProfileStart verb .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/631/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I279977bb4dc3631162ce22668612103896646afe Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added glusterVolumeProfileStop verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added glusterVolumeProfileStop verb .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/632/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie25c7da7208eb4bf68f67d945fb7c63b44886040 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/633/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: infra: adding debug log to vdsm daemon init script
Eli Mesika has posted comments on this change. Change subject: infra: adding debug log to vdsm daemon init script .. Patch Set 7: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added xml option in gluster command execution.
Dan Kenigsberg has posted comments on this change. Change subject: Added xml option in gluster command execution. .. Patch Set 3: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/6999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I385f992005d446b417be84eb7ff484e4edf6e5b6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add simple VM creation functional test
Deepak C Shetty has posted comments on this change. Change subject: add simple VM creation functional test .. Patch Set 3: Looks good to me, but someone else must approve Pending the need to investigate display:local over vnc. -- To view, visit http://gerrit.ovirt.org/7396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb0d86ce20a547ef809d5407fe12d6ade474c4d2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: Fix make rpm for filter tests.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: Fix make rpm for filter tests. .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/636/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb3cee09f16202f4e69728b5aaf36e54f39e8d82 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhorn...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: Fix make rpm for filter tests.
Dan Kenigsberg has posted comments on this change. Change subject: tc: Fix make rpm for filter tests. .. Patch Set 2: (1 inline comment) File tests/Makefile.am Line 50: Line 51: dist_noinst_DATA = \ Line 52:run_tests_local.sh \ Line 53:cpu_info.out \ Line 54:tc_filter_show.out \ was this intentional to have this file both on noinst and in vdsmtests? I now notice that we have more of the same problem: glob_1c60971a-8647-44ac-ae33-6520887f8843.out and other files are missing from vdsm-tests rpm. Line 55:route_info.out \ Line 56:glob_1c60971a-8647-44ac-ae33-6520887f8843.out \ Line 57:lvs_3386c6f2-926f-42c4-839c-38287fac8998.out Line 58: -- To view, visit http://gerrit.ovirt.org/7442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb3cee09f16202f4e69728b5aaf36e54f39e8d82 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhorn...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: infra: adding debug log to vdsm daemon init script
Dan Kenigsberg has posted comments on this change. Change subject: infra: adding debug log to vdsm daemon init script .. Patch Set 7: I would prefer that you didn't submit this I think it would be nice if you not only define the function, but also use it - I think it makes sense to call it in log_failure_msg/log_success_msg. -- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: infra: adding debug log to vdsm daemon init script
Dan Kenigsberg has posted comments on this change. Change subject: infra: adding debug log to vdsm daemon init script .. Patch Set 7: but really. please explain the motivation of this. why running the script with -xv is not enough for debugging? -- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: Fix make rpm for filter tests.
Antoni Segura Puimedon has posted comments on this change. Change subject: tc: Fix make rpm for filter tests. .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/7442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb3cee09f16202f4e69728b5aaf36e54f39e8d82 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhorn...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
Douglas Schilling Landgraf has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 9: I would prefer that you didn't submit this (1 inline comment) File vdsm/vdsmd.init.in Line 402: # run service for restart instead of using initctl, both works Line 403: # the same and works on fedora and rhel Line 404: # /sbin/initctl restart libvirtd 2/dev/null || : Line 405: debug_log running restart for libvirt Line 406: /sbin/service libvirtd restart Hi Yaniv, Why don't we us if ! upstart_libvirt; then service libvirt... else initctl ? I think most of vdsmd.init script already uses like that. Line 407: } Line 408: Line 409: Line 410: RETVAL=0 -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: Fix make rpm for filter tests.
Dan Kenigsberg has posted comments on this change. Change subject: tc: Fix make rpm for filter tests. .. Patch Set 3: Looks good to me, approved Thanks! -- To view, visit http://gerrit.ovirt.org/7442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb3cee09f16202f4e69728b5aaf36e54f39e8d82 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhorn...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: Fix make rpm for filter tests.
Dan Kenigsberg has submitted this change and it was merged. Change subject: tc: Fix make rpm for filter tests. .. tc: Fix make rpm for filter tests. Change-Id: Idb3cee09f16202f4e69728b5aaf36e54f39e8d82 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com --- M tests/Makefile.am M tests/tcTests.py M vdsm.spec.in 3 files changed, 5 insertions(+), 1 deletion(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb3cee09f16202f4e69728b5aaf36e54f39e8d82 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhorn...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: silently ignore ingress qdisc re-creation
Dan Kenigsberg has posted comments on this change. Change subject: tc: silently ignore ingress qdisc re-creation .. Patch Set 2: Verified; Looks good to me, approved After that it is approved. -- To view, visit http://gerrit.ovirt.org/7434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib58c14cc8bfd5fe6e6a3efe86a1b1da4658a2b0f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: silently ignore ingress qdisc re-creation
Dan Kenigsberg has submitted this change and it was merged. Change subject: tc: silently ignore ingress qdisc re-creation .. tc: silently ignore ingress qdisc re-creation We should allow starting up two VMs monitoring a single bridge. Change-Id: Ib58c14cc8bfd5fe6e6a3efe86a1b1da4658a2b0f Signed-off-by: Dan Kenigsberg dan...@redhat.com --- M tests/tcTests.py M vdsm/tc.py 2 files changed, 12 insertions(+), 4 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib58c14cc8bfd5fe6e6a3efe86a1b1da4658a2b0f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up
..
Patch Set 9: (1 inline comment)
File vdsm/vdsmd.init.in
Line 425: }
Line 426:
Line 427: stop_libvirtd_sysv() {
Line 428: # stop libvirt SysV service if we intend to configure upstart
Line 429: if ! upstart_libvirt; then
humm, reading the comment looks like ! is not required. Better check with Dan.
Line 430: debug_log stopping libvirt service..
Line 431: /sbin/chkconfig libvirtd off
Line 432: /sbin/service libvirtd stop
Line 433: fi
--
To view, visit http://gerrit.ovirt.org/7331
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Upgrade a data domain on attachSD when required
Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Upgrade a data domain on attachSD when required .. [WIP] Upgrade a data domain on attachSD when required RHBZ: 844367 Signed-off-by: Federico Simoncelli fsimo...@redhat.com Change-ID: I65dfd6dd339569fbaf276f3942a001c174423b1a --- M vdsm/storage/sp.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/7444/1 diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index da403d9..4d2e0cf 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -935,7 +935,7 @@ # If you remove this condition, remove it from # public_createStoragePool too. -if dom.isData() and domVers != mstVers: +if dom.isData() and domVers mstVers: raise se.MixedSDVersionError(dom.sdUUID, domVers, self.masterDomain.sdUUID, mstVers) -- To view, visit http://gerrit.ovirt.org/7444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I65dfd6dd339569fbaf276f3942a001c174423b1a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Upgrade a data domain on attachSD when required
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Upgrade a data domain on attachSD when required .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/638/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65dfd6dd339569fbaf276f3942a001c174423b1a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: rename qdisc_replace_prio()
Dan Kenigsberg has posted comments on this change. Change subject: tc: rename qdisc_replace_prio() .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9628244a144ece23b793e260e077dcee9698eba Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: rename qdisc_replace_prio()
Dan Kenigsberg has submitted this change and it was merged. Change subject: tc: rename qdisc_replace_prio() .. tc: rename qdisc_replace_prio() This funciton replaces a PRIO qdisc. Let us call it accordingly Change-Id: If9628244a144ece23b793e260e077dcee9698eba Signed-off-by: Dan Kenigsberg dan...@redhat.com --- M tests/tcTests.py M vdsm/tc.py 2 files changed, 5 insertions(+), 4 deletions(-) Approvals: Antoni Segura Puimedon: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9628244a144ece23b793e260e077dcee9698eba Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Produce the domain in the domain monitor thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: Produce the domain in the domain monitor thread .. Patch Set 4: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/639/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Update the lvm rules permissions with sanlock
Federico Simoncelli has uploaded a new change for review.
Change subject: Update the lvm rules permissions with sanlock
..
Update the lvm rules permissions with sanlock
The MODE keyword in the lvm rules wasn't used by udev. However a newer
version shipped with Fedora 17 is considering its value.
The MODE and the GROUP values should be updated to allow sanlock to
access the ids and the leases LVs.
RHBZ: 850440
Change-Id: Idfca402c4264788a4e01349cc72e5fa3587b6222
Signed-off-by: Federico Simoncelli fsimo...@redhat.com
---
M vdsm/storage/12-vdsm-lvm.rules
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/7446/1
diff --git a/vdsm/storage/12-vdsm-lvm.rules b/vdsm/storage/12-vdsm-lvm.rules
index b7a9d4c..398992d 100644
--- a/vdsm/storage/12-vdsm-lvm.rules
+++ b/vdsm/storage/12-vdsm-lvm.rules
@@ -25,11 +25,11 @@
ENV{DM_VG_NAME}==[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9],
ENV{DM_LV_NAME}==[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]_MERGE,
OWNER:=vdsm, GROUP:=qemu, GOTO=lvm_end
ENV{DM_VG_NAME}==[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9],
ENV{DM_LV_NAME}==_remove_me_[a-zA-Z0-9][a-zA-Z0-9][a-zA-Z0-9][a-zA-Z0-9][a-zA-Z0-9][a-zA-Z0-9][a-zA-Z0-9][a-zA-Z0-9]_[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9],
OWNER:=vdsm, GROUP:=qemu, GOTO=lvm_end
ENV{DM_VG_NAME}==[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9],
ENV{DM_LV_NAME}==metadata, MODE:=0600, OWNER:=vdsm, GROUP:=qemu,
GOTO=lvm_end
-ENV{DM_VG_NAME}==[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9],
ENV{DM_LV_NAME}==ids, MODE:=0600, OWNER:=vdsm, GROUP:=qemu,
GOTO=lvm_end
+ENV{DM_VG_NAME}==[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9],
ENV{DM_LV_NAME}==ids, MODE:=0660, OWNER:=vdsm, GROUP:=sanlock,
GOTO=lvm_end
ENV{DM_VG_NAME}==[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9],
ENV{DM_LV_NAME}==inbox, MODE:=0600, OWNER:=vdsm, GROUP:=qemu,
GOTO=lvm_end
ENV{DM_VG_NAME}==[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9],
ENV{DM_LV_NAME}==outbox, MODE:=0600, OWNER:=vdsm, GROUP:=qemu,
GOTO=lvm_end
-ENV{DM_VG_NAME}==[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9],
ENV{DM_LV_NAME}==leases, MODE:=0600, OWNER:=vdsm, GROUP:=qemu,
GOTO=lvm_end
+ENV{DM_VG_NAME}==[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9],
ENV{DM_LV_NAME}==leases, MODE:=0660, OWNER:=vdsm, GROUP:=sanlock,
GOTO=lvm_end
-# FIXME: make special lvs vdsm-only readable (MODE doesn't work)
+# FIXME: make special lvs vdsm-only readable, MODE doesn't work on rhel6
LABEL=lvm_end
--
To view, visit http://gerrit.ovirt.org/7446
To unsubscribe,
Change in vdsm[master]: Update the lvm rules permissions with sanlock
oVirt Jenkins CI Server has posted comments on this change. Change subject: Update the lvm rules permissions with sanlock .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/640/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfca402c4264788a4e01349cc72e5fa3587b6222 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: add to PEP8_WHITELIST
Douglas Schilling Landgraf has posted comments on this change. Change subject: tc: add to PEP8_WHITELIST .. Patch Set 1: I would prefer that you didn't submit this Dan, not sure if this happened with you as well (with a clean repo): git fetch git://gerrit.ovirt.org/vdsm refs/changes/26/7426/1 git cherry-pick FETCH_HEAD error: could not apply 9c2ac6d... tc: add to PEP8_WHITELIST hint: after resolving the conflicts, mark the corrected paths -1 = since I have a question and maybe rebase is needed. -- To view, visit http://gerrit.ovirt.org/7426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b3b1d8de08ea8fac5cd3debb53f22d7a7a8ad87 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: make vdsm/libvirtvm.py PEP 8 clean
Douglas Schilling Landgraf has posted comments on this change. Change subject: make vdsm/libvirtvm.py PEP 8 clean .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12735cc8fdaeb91c77f63e16a262b0cd8acfbba4 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make libvirtvm.py PEP8 compliant
Saggi Mizrahi has posted comments on this change.
Change subject: Make libvirtvm.py PEP8 compliant
..
Patch Set 1: (3 inline comments)
File vdsm/libvirtvm.py
Line 81: config.getint('vars',
'vm_sample_net_interval'),
Line 82: config.getint('vars',
'vm_sample_net_window'))
Line 83:
Line 84: self.addStatsFunction(self.highWrite, self.updateVolumes,
Line 85: self.sampleCpu, self.sampleDisk,
self.sampleDiskLatency,
Only in function declarations. When using a function you don't need to align
the arguments.
http://www.python.org/dev/peps/pep-0008/#id12
# Extra indentation is not necessary.
foo = long_function_name(
var_one, var_two,
var_three, var_four)
Line 86: self.sampleNet)
Line 87:
Line 88: def _highWrite(self):
Line 89: if not self._vm._volumesPrepared:
Line 118: vmDrive.apparentsize =
int(volSize['apparentsize'])
Line 119:
Line 120: def _sampleCpu(self):
Line 121: state, maxMem, memory, nrVirtCpu, cpuTime =
self._vm._dom.info()
Line 122: return cpuTime / (1000 ** 3)
Spaces around operators.
http://www.python.org/dev/peps/pep-0008/#id20
Line 123:
Line 124: def _sampleDisk(self):
Line 125: if not self._vm._volumesPrepared:
Line 126: # Avoid queries from storage during recovery process
Line 269: 'writeLatency': '0',
Line 270: 'flushLatency': '0'}
Line 271: try:
Line 272: (dLatency['readLatency'], dLatency['writeLatency'],
Line 273: dLatency['flushLatency']) =
_avgLatencyCalc(sInfo[dName],
I don't think the spec specifies that.
Line 274: eInfo[dName])
Line 275: except (KeyError, TypeError):
Line 276: self._log.debug(Disk %s latency not available,
dName)
Line 277: else:
--
To view, visit http://gerrit.ovirt.org/7422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32570c2d1a2efa4a5446caa6d973a10b4c84d996
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make libvirtvm.py PEP8 compliant
Saggi Mizrahi has posted comments on this change. Change subject: Make libvirtvm.py PEP8 compliant .. Patch Set 1: (1 inline comment) File vdsm/libvirtvm.py Line 269: 'writeLatency': '0', Line 270: 'flushLatency': '0'} Line 271: try: Line 272: (dLatency['readLatency'], dLatency['writeLatency'], Line 273: dLatency['flushLatency']) = _avgLatencyCalc(sInfo[dName], Further more it would break indentation being a multiply of four. Line 274: eInfo[dName]) Line 275: except (KeyError, TypeError): Line 276: self._log.debug(Disk %s latency not available, dName) Line 277: else: -- To view, visit http://gerrit.ovirt.org/7422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32570c2d1a2efa4a5446caa6d973a10b4c84d996 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move fencing logic out of API.py
Saggi Mizrahi has posted comments on this change.
Change subject: Move fencing logic out of API.py
..
Patch Set 4: (3 inline comments)
File vdsm_api/vdsmapi-schema.json
Line 305: #
Line 306: # Since: 4.10.0
Line 307: ##
Line 308: {'command': {'class': 'Global', 'name': 'fenceNode'},
Line 309: 'data': {'addr': 'str', 'bladePort': 'int', 'agent': 'str',
'username': 'str',
I'll change the type,
And for now I think that just having it being anything but port will make
things far less confusing.
Line 310: 'password': 'str', 'action': 'FenceNodeAction', '*secure':
'bool',
Line 311: '*options': 'str'},
Line 312: 'returns': {'*power': 'FenceNodePowerStatus'}}
Line 313:
File vdsm/fenceAgent.py
Line 99: power = 'on'
Line 100: elif p.returncode == 2:
Line 101: power = 'off'
Line 102: else:
Line 103: power = 'unknown'
That what the original code contained. I'm just moving it around.
Line 104:
Line 105: return power
Line 106:
Line 107:
Line 108: def fenceNode(addr, port, agent, username, password, action,
Line 109: secure=False, options='', cancelEvent=None):
Line 110:
Line 111: if action not in ('on', 'off', 'reboot'):
Line 112: raise ValueError('illegal action ' + action)
Log what? It's pretty obvious what happened here. Someone sent the wrong value.
Line 113:
Line 114: inp = _buildInput(addr, port, agent, username, password, action,
secure,
Line 115: options)
Line 116:
--
To view, visit http://gerrit.ovirt.org/7190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I944c6548a42612f705a410fb4290215451bca035
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: add to PEP8_WHITELIST
Dan Kenigsberg has posted comments on this change. Change subject: tc: add to PEP8_WHITELIST .. Patch Set 1: I would prefer that you didn't submit this yes... I'm afraid that something fishy is going on with this topic branch of mine. A couple of changes do not show up after being pushed: for example, this change includes more stuff than it should have, and it did not update with my most resent push. I hope we are not on the verge of db corruption. -- To view, visit http://gerrit.ovirt.org/7426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b3b1d8de08ea8fac5cd3debb53f22d7a7a8ad87 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sort the pep8 whitelist list
Dan Kenigsberg has submitted this change and it was merged. Change subject: Sort the pep8 whitelist list .. Sort the pep8 whitelist list Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Signed-off-by: Saggi Mizrahi smizr...@redhat.com --- M Makefile.am 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Ewoud Kohl van Wijngaarden: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sort the pep8 whitelist list
Dan Kenigsberg has posted comments on this change. Change subject: Sort the pep8 whitelist list .. Patch Set 13: Looks good to me, approved The commit message is now wrong, but this little patch annoyed us enough. -- To view, visit http://gerrit.ovirt.org/6246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make libvirtvm.py PEP8 compliant
Antoni Segura Puimedon has posted comments on this change.
Change subject: Make libvirtvm.py PEP8 compliant
..
Patch Set 1: No score
(3 inline comments)
As Zhou Zheng Sheng said, there is a patch that is doing the same task, I
reviewed both to the best of my ability and I attach now some comments that
help clarify my earlier comments. I admit that I might be mistaken in my
interpretations so I will leave the score to 0 and hope that somebody will have
a more definitive knowledge about these points than I do.
File vdsm/libvirtvm.py
Line 81: config.getint('vars',
'vm_sample_net_interval'),
Line 82: config.getint('vars',
'vm_sample_net_window'))
Line 83:
Line 84: self.addStatsFunction(self.highWrite, self.updateVolumes,
Line 85: self.sampleCpu, self.sampleDisk,
self.sampleDiskLatency,
note that in the example you pose there is no argument in the first line, thus
it is allowed as you show. I am under the understanding that it is not the case
when there are arguments in the line that opens the brackets.
Line 86: self.sampleNet)
Line 87:
Line 88: def _highWrite(self):
Line 89: if not self._vm._volumesPrepared:
Line 118: vmDrive.apparentsize =
int(volSize['apparentsize'])
Line 119:
Line 120: def _sampleCpu(self):
Line 121: state, maxMem, memory, nrVirtCpu, cpuTime =
self._vm._dom.info()
Line 122: return cpuTime / (1000 ** 3)
You are right about the spaces, I overlooked them, what caught my attentions
was the presence of unneeded parenthesis.
Line 123:
Line 124: def _sampleDisk(self):
Line 125: if not self._vm._volumesPrepared:
Line 126: # Avoid queries from storage during recovery process
Line 269: 'writeLatency': '0',
Line 270: 'flushLatency': '0'}
Line 271: try:
Line 272: (dLatency['readLatency'], dLatency['writeLatency'],
Line 273: dLatency['flushLatency']) =
_avgLatencyCalc(sInfo[dName],
It is a block, thus, I believe (although I could very well be mistaken), should
follow the rules of indentation inside parenthesis like the example in:
http://www.python.org/dev/peps/pep-0008/#maximum-line-length
Note:
- The alignment to beginning parenthesis in the if.
- The alignment in the raise ValueError statement (no multiples of four but
aligned to call beginning parenthesis).
Line 274: eInfo[dName])
Line 275: except (KeyError, TypeError):
Line 276: self._log.debug(Disk %s latency not available,
dName)
Line 277: else:
--
To view, visit http://gerrit.ovirt.org/7422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32570c2d1a2efa4a5446caa6d973a10b4c84d996
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Produce the domain in the domain monitor thread
Ayal Baron has posted comments on this change. Change subject: Produce the domain in the domain monitor thread .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix PEP8 violations in vm.py
Saggi Mizrahi has uploaded a new change for review.
Change subject: Fix PEP8 violations in vm.py
..
Fix PEP8 violations in vm.py
Change-Id: I369a1dbfcf49cf1a8b1ac61fe88dd2fe3ea93b8e
Signed-off-by: Saggi Mizrahi smizr...@redhat.com
---
M Makefile.am
M vdsm/vm.py
2 files changed, 118 insertions(+), 69 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/7449/1
diff --git a/Makefile.am b/Makefile.am
index 611fec4..7a07608c 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -90,6 +90,7 @@
vdsm/storage/volume.py \
vdsm/supervdsm.py \
vdsm/supervdsmServer.py \
+ vdsm/vm.py \
vdsm_cli \
vdsm_hooks/fileinject/before_vm_start.py \
vdsm_hooks/promisc/after_vm_start.py \
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 949a3ee..549eb8f 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -20,7 +20,9 @@
import os
import time
-import threading, logging
+import threading
+import logging
+import math
from vdsm import constants
import tempfile
import pickle
@@ -50,6 +52,7 @@
A module containing classes needed for VM communication.
+
def isVdsmImage(drive):
return all(k in drive.keys() for k in ('volumeID', 'domainID', 'imageID',
'poolID'))
@@ -67,13 +70,17 @@
if not a.startswith('__')]
return .join(attrs)
-class _MigrationError(RuntimeError): pass
+
+class _MigrationError(RuntimeError):
+pass
+
class MigrationSourceThread(threading.Thread):
A thread that takes care of migration on the source vdsm.
_ongoingMigrations = threading.BoundedSemaphore(1)
+
@classmethod
def setMaxOutgoingMigrations(cls, n):
Set the initial value of the _ongoingMigrations semaphore.
@@ -81,8 +88,8 @@
must not be called after any vm has been run.
cls._ongoingMigrations = threading.BoundedSemaphore(n)
-def __init__ (self, vm, dst='', dstparams='',
- mode='remote', method='online', **kwargs):
+def __init__(self, vm, dst='', dstparams='', mode='remote',
+method='online', **kwargs):
self.log = vm.log
self._vm = vm
self._dst = dst
@@ -92,19 +99,23 @@
self._machineParams = {}
self._downtime = kwargs.get('downtime') or \
config.get('vars', 'migration_downtime')
-self.status = {'status': {'code': 0, 'message': 'Migration in
process'}, 'progress': 0}
+self.status = {'status': {
+'code': 0,
+'message': 'Migration in process'}, 'progress': 0
+}
threading.Thread.__init__(self)
self._preparingMigrationEvt = False
self._migrationCanceledEvt = False
-def getStat (self):
+def getStat(self):
Get the status of the migration.
return self.status
def _setupVdsConnection(self):
-if self._mode == 'file': return
+if self._mode == 'file':
+return
self.remoteHost = self._dst.split(':')[0]
# FIXME: The port will depend on the binding being used.
# This assumes xmlrpc
@@ -188,7 +199,11 @@
def _finishSuccessfully(self):
if self._mode != 'file':
self._vm.setDownStatus(NORMAL, Migration succeeded)
-self.status = {'status': {'code': 0, 'message': 'Migration done'},
'progress': 100}
+self.status = {
+'status': {
+'code': 0,
+'message': 'Migration done'},
+'progress': 100}
else:
# don't pickle transient params
for ignoreParam in ('displayIp', 'display', 'pid'):
@@ -203,7 +218,11 @@
self._vm.cif.teardownVolumePath(self._dstparams)
self._vm.setDownStatus(NORMAL, SaveState succeeded)
-self.status = {'status': {'code': 0, 'message': 'SaveState done'},
'progress': 100}
+self.status = {
+'status': {
+'code': 0,
+'message': 'SaveState done'},
+'progress': 100}
def run(self):
try:
@@ -240,12 +259,15 @@
def __str__(self):
return Bad volume specification + RuntimeError.__str__(self)
-class DoubleDownError(RuntimeError): pass
+
+class DoubleDownError(RuntimeError):
+pass
VALID_STATES = ('Down', 'Migration Destination', 'Migration Source',
'Paused', 'Powering down', 'RebootInProgress',
'Restoring state', 'Saving State',
'Up', 'WaitForLaunch')
+
class Vm(object):
@@ -271,7 +293,7 @@
self.conf = {'pid': '0'}
self.conf.update(params)
self.cif = cif
-self.log = SimpleLogAdapter(self.log, {vmId : self.conf['vmId']})
+self.log = SimpleLogAdapter(self.log, {vmId: self.conf['vmId']})
Change in vdsm[master]: Fix PEP8 violations in vm.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix PEP8 violations in vm.py .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/641/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I369a1dbfcf49cf1a8b1ac61fe88dd2fe3ea93b8e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make IRS methods bypass API.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: Make IRS methods bypass API.py .. Patch Set 4: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/642/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf7dc90462e47b9f067959df7325b57cbaa82241 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Move vm logic to it's own module
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Move vm logic to it's own module .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/643/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc54c1d0ab7ad535d825dcd72fd2f4583b690f44 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make libvirtvm.py PEP8 compliant
oVirt Jenkins CI Server has posted comments on this change. Change subject: Make libvirtvm.py PEP8 compliant .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/644/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32570c2d1a2efa4a5446caa6d973a10b4c84d996 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant indiration for getting vm status
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove redundant indiration for getting vm status .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/645/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I789155bb2dc1b7df911c949c08567c8f34b600ee Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move fencing logic out of API.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move fencing logic out of API.py .. Patch Set 5: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/646/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I944c6548a42612f705a410fb4290215451bca035 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move fenceNode out of API.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move fenceNode out of API.py .. Patch Set 6: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/647/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7191 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idaba551333a0f289abaff11dc113e09c426d591a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
