Change in vdsm[master]: Testing storageTest.py as CI job. Do NOT MERGE!

2014-01-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Testing storageTest.py as CI job. Do NOT MERGE! .. Patch Set 13: Verified-1 Build Failed

Change in vdsm[ovirt-3.4]: execCmd with sudo=root raise require tty fault when running ...

2014-01-27 Thread ybronhei
Hello Alon Bar-Lev, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/23739 to review the following change. Change subject: execCmd with sudo=root raise require tty fault when running as root

Change in vdsm[ovirt-3.4]: execCmd with sudo=root raise require tty fault when running ...

2014-01-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: execCmd with sudo=root raise require tty fault when running as root .. Patch Set 1: Verified-1 Build Failed

Change in vdsm[master]: vm: implement recommended clock settings

2014-01-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: implement recommended clock settings .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6074/ :

Change in vdsm[master]: vdsm: add support for PCI passthrough

2014-01-27 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: vdsm: add support for PCI passthrough .. Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/22462/5//COMMIT_MSG Commit Message: Line 3: AuthorDate:

Change in vdsm[master]: gluster: fix vdsmapi gluster json schema error

2014-01-27 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: fix vdsmapi gluster json schema error .. gluster: fix vdsmapi gluster json schema error Updates schema file for task info, task summary and

Change in vdsm[master]: gluster: fix vdsmapi gluster json schema error

2014-01-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: gluster: fix vdsmapi gluster json schema error .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21755 To unsubscribe, visit

Change in vdsm[master]: gluster: Fix vdsm-tool crash report detected by abrt

2014-01-27 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: gluster: Fix vdsm-tool crash report detected by abrt .. Patch Set 1: See discussion at [1], May 21 and on. [1] http://gerrit.ovirt.org/#/c/14866/ -- To view,

Change in vdsm[master]: Changing python-cpopen requirement

2014-01-27 Thread ybronhei
Yaniv Bronhaim has abandoned this change. Change subject: Changing python-cpopen requirement .. Abandoned already merged requirement for cpopen = 1.3 -- To view, visit http://gerrit.ovirt.org/22936 To unsubscribe, visit

Change in vdsm[master]: Avoid spec error outputs during installing VDSM

2014-01-27 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Avoid spec error outputs during installing VDSM .. Patch Set 1: so we don't want that? or should i get more reviewers' comments? -- To view, visit

Change in vdsm[master]: Testing storageTest.py as CI job. Do NOT MERGE!

2014-01-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Testing storageTest.py as CI job. Do NOT MERGE! .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6073/ : SUCCESS

Change in vdsm[master]: vdsm: Utilize CallbackChain in vm.shutdown

2014-01-27 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Utilize CallbackChain in vm.shutdown .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/23457 To unsubscribe, visit

Change in vdsm[master]: vdsm.spec: vdsm should own metadata supervdsm logs

2014-01-27 Thread dougsland
Douglas Schilling Landgraf has uploaded a new change for review. Change subject: vdsm.spec: vdsm should own metadata supervdsm logs .. vdsm.spec: vdsm should own metadata supervdsm logs /var/log/vdsm/metadata.log

Change in vdsm[master]: vdsm: Utilize CallbackChain in vm.shutdown

2014-01-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Utilize CallbackChain in vm.shutdown .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6076/ : SUCCESS

Change in vdsm[master]: vdsm.spec: vdsm should own metadata supervdsm logs

2014-01-27 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm.spec: vdsm should own metadata supervdsm logs .. Patch Set 1: Verified+1 Not including mom.log which I am assuming should be owned by mom rpm.

Change in vdsm[master]: [WIP] add a json rpc funtional test which sets up a VM

2014-01-27 Thread iheim
Itamar Heim has abandoned this change. Change subject: [WIP] add a json rpc funtional test which sets up a VM .. Abandoned no comment for 60 days post last ping. abandoning. please re-open if/when relevant and/or ping

Change in vdsm[master]: stats: report detailed VM down status

2014-01-27 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 4: Code-Review+1 (3 comments) http://gerrit.ovirt.org/#/c/22631/4/vdsm/vm.py File vdsm/vm.py: Line

Change in vdsm[master]: stats: report detailed VM down status

2014-01-27 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 4: -Code-Review (Oops sorry, it wasn't a +1) -- To view, visit http://gerrit.ovirt.org/22631 To

Change in vdsm[master]: vdsm.spec: vdsm should own metadata supervdsm logs

2014-01-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm.spec: vdsm should own metadata supervdsm logs .. Patch Set 1: Code-Review-1 (2 comments) /var/log/vdsm/mom.log is created by the mom module of the vdsm

Change in vdsm[master]: vdsm.spec: own metadata supervdsm mom logs

2014-01-27 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm.spec: own metadata supervdsm mom logs .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/23754/1/vdsm.spec.in File vdsm.spec.in: Line

Change in vdsm[master]: utils: Extend pgrep to accept multiple process names

2014-01-27 Thread osvoboda
Ondřej Svoboda has abandoned this change. Change subject: utils: Extend pgrep to accept multiple process names .. Abandoned The ability to pgrep 'dhclient' and 'dhcpcd' in one run was supposed for an earlier version of the

Change in vdsm[master]: vdsm.spec: own metadata supervdsm mom logs

2014-01-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm.spec: own metadata supervdsm mom logs .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6078/ : SUCCESS

Change in vdsm[ovirt-3.4]: execCmd with sudo=root raise require tty fault when running ...

2014-01-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: execCmd with sudo=root raise require tty fault when running as root .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23739 To

Change in vdsm[master]: Moving response implementation of getAllVmStats to API.py

2014-01-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Moving response implementation of getAllVmStats to API.py .. Patch Set 3: Verified-1 Build Failed

Change in vdsm[ovirt-3.4]: netconfig: set ETHTOOL_OPTS when a NIC goes up

2014-01-27 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: netconfig: set ETHTOOL_OPTS when a NIC goes up .. netconfig: set ETHTOOL_OPTS when a NIC goes up There's broken hardware out there where lro needs to to be

Change in vdsm[master]: jsonrpc: Vdsm changes

2014-01-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Vdsm changes .. Patch Set 22: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6084/ : SUCCESS

Change in vdsm[master]: utils: Moved pgrep and getCmdArgs from storage/misc

2014-01-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Moved pgrep and getCmdArgs from storage/misc .. Patch Set 6: Verified-1 Build Failed

Change in vdsm[master]: introducing downloadFromStream verb

2014-01-27 Thread laravot
Liron Ar has abandoned this change. Change subject: introducing downloadFromStream verb .. Abandoned I've thought about problematic scenario, abandoning and will re-upload it. -- To view, visit http://gerrit.ovirt.org/23281

Change in vdsm[master]: sysvinit: Ensure that iscsid is started

2014-01-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sysvinit: Ensure that iscsid is started .. Patch Set 4: Verified+1 Fix commit message, addressing Dan comments. Copying verify status as code was not changed. --

Change in vdsm[master]: sysvinit: Ensure that iscsid is started

2014-01-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sysvinit: Ensure that iscsid is started .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6086/ : SUCCESS

Change in vdsm[master]: jsonrpc: Vdsm changes

2014-01-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Vdsm changes .. Patch Set 23: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6085/ : SUCCESS

Change in vdsm[master]: utils: Moved pgrep and getCmdArgs from storage/misc

2014-01-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Moved pgrep and getCmdArgs from storage/misc .. Patch Set 5: Verified-1 Build Failed

Change in vdsm[master]: dump the core of a VM

2014-01-27 Thread fromani
Francesco Romani has posted comments on this change. Change subject: dump the core of a VM .. Patch Set 17: (2 comments) http://gerrit.ovirt.org/#/c/7329/17/vdsm_api/vdsmapi-schema.json File vdsm_api/vdsmapi-schema.json:

Change in vdsm[master]: sysvinit: Ensure that iscsid is started

2014-01-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: sysvinit: Ensure that iscsid is started .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/23601/4//COMMIT_MSG Commit Message: Line 21:

Change in vdsm[master]: sysvinit: Ensure that iscsid is started

2014-01-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sysvinit: Ensure that iscsid is started .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6087/ : SUCCESS

Change in vdsm[master]: sysvinit: Ensure that iscsid is started

2014-01-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: sysvinit: Ensure that iscsid is started .. Patch Set 5: Verified+1 Code-Review+2 Copying score after a minor change to the commit message. -- To view, visit

Change in vdsm[master]: stats: report detailed VM down status

2014-01-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6088/ : SUCCESS

Change in vdsm[master]: sysvinit: Ensure that iscsid is started

2014-01-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sysvinit: Ensure that iscsid is started .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6089/ : SUCCESS

Change in vdsm[master]: sysvinit: Ensure that iscsid is started

2014-01-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sysvinit: Ensure that iscsid is started .. Patch Set 6: Verified+1 Code-Review+1 New commit message is better, copying verify status since code was not changed.

Change in vdsm[master]: sysvinit: Ensure that iscsid is started

2014-01-27 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: sysvinit: Ensure that iscsid is started .. sysvinit: Ensure that iscsid is started vdsm is starting the iscsid daemon when it starts, but iscsid start

Change in vdsm[master]: sysvinit: Ensure that iscsid is started

2014-01-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: sysvinit: Ensure that iscsid is started .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23601 To unsubscribe, visit

Change in vdsm[ovirt-3.4]: netconfig: set ETHTOOL_OPTS when a NIC goes up

2014-01-27 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: netconfig: set ETHTOOL_OPTS when a NIC goes up .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23761 To unsubscribe, visit

Change in vdsm[master]: vdsm.spec: own metadata supervdsm mom logs

2014-01-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm.spec: own metadata supervdsm mom logs .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/23754/1/vdsm.spec.in File vdsm.spec.in: Line 614: # VDSM

Change in vdsm[ovirt-3.4]: sysvinit: Ensure that iscsid is started

2014-01-27 Thread nsoffer
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/23770 to review the following change. Change subject: sysvinit: Ensure that iscsid is started .. sysvinit: Ensure that iscsid

Change in vdsm[ovirt-3.4]: sysvinit: Ensure that iscsid is started

2014-01-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sysvinit: Ensure that iscsid is started .. Patch Set 1: Verified+1 Verified on master. -- To view, visit http://gerrit.ovirt.org/23770 To unsubscribe, visit

Change in vdsm[master]: vdsm.spec: own metadata supervdsm mom logs

2014-01-27 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm.spec: own metadata supervdsm mom logs .. vdsm.spec: own metadata supervdsm mom logs /var/log/vdsm/metadata.log /var/log/vdsm/supervdsm.log

Change in vdsm[master]: vdsm.spec: own metadata supervdsm mom logs

2014-01-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm.spec: own metadata supervdsm mom logs .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23754 To unsubscribe, visit

Change in vdsm[master]: vdsm.spec: own metadata supervdsm mom logs

2014-01-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm.spec: own metadata supervdsm mom logs .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/316/

Change in vdsm[ovirt-3.4]: sysvinit: Ensure that iscsid is started

2014-01-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: sysvinit: Ensure that iscsid is started .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23770 To unsubscribe, visit

Change in vdsm[master]: utils: Moved pgrep and getCmdArgs from storage/misc

2014-01-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: utils: Moved pgrep and getCmdArgs from storage/misc .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23040 To unsubscribe, visit

Change in vdsm[master]: host-deploy: getChainFromSSL: acquire chain from session and...

2014-01-27 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: host-deploy: getChainFromSSL: acquire chain from session and not negotiation .. Patch Set 1: Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1058016

Change in vdsm[master]: host-deploy: getChainFromSSL: acquire chain from session and...

2014-01-27 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: host-deploy: getChainFromSSL: acquire chain from session and not negotiation .. host-deploy: getChainFromSSL: acquire chain from session and not negotiation

Change in vdsm[master]: host-deploy: getChainFromSSL: acquire chain from session and...

2014-01-27 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: host-deploy: getChainFromSSL: acquire chain from session and not negotiation .. Patch Set 1: Code-Review+1 verified as standalone -- To view, visit

Change in vdsm[master]: host-deploy: getChainFromSSL: acquire chain from session and...

2014-01-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: host-deploy: getChainFromSSL: acquire chain from session and not negotiation .. Patch Set 1: Build Successful

Change in vdsm[ovirt-3.3]: sysvinit: Ensure that iscsid is started

2014-01-27 Thread nsoffer
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/23778 to review the following change. Change subject: sysvinit: Ensure that iscsid is started .. sysvinit: Ensure that iscsid

Change in vdsm[ovirt-3.3]: sysvinit: Ensure that iscsid is started

2014-01-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sysvinit: Ensure that iscsid is started .. Patch Set 1: According to Eyal, this is the place for zstream patches. -- To view, visit http://gerrit.ovirt.org/23778

Change in vdsm[ovirt-3.3]: netconf.ifcfg: fix sloppy backport

2014-01-27 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: netconf.ifcfg: fix sloppy backport .. netconf.ifcfg: fix sloppy backport In recent commit 6241e067 I have broken the ovirt-3.3 branch by refering to

Change in vdsm[ovirt-3.3]: netconf.ifcfg: fix sloppy backport

2014-01-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netconf.ifcfg: fix sloppy backport .. Patch Set 1: Verified+1 Code-Review+2 Reverified, now with the correct code. -- To view, visit

Change in vdsm[ovirt-3.4]: vdsm.spec: own metadata supervdsm mom logs

2014-01-27 Thread dougsland
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/23786 to review the following change. Change subject: vdsm.spec: own metadata supervdsm mom logs .. vdsm.spec: own metadata

Change in vdsm[ovirt-3.4]: vdsm.spec: vdsm should own vdsm.log

2014-01-27 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm.spec: vdsm should own vdsm.log .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/23718 To unsubscribe, visit

Change in vdsm[ovirt-3.4]: vdsm.spec: own metadata supervdsm mom logs

2014-01-27 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm.spec: own metadata supervdsm mom logs .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/23786 To unsubscribe, visit

Change in vdsm[master]: configurator: use sanlock group for sanlock check

2014-01-27 Thread dougsland
Douglas Schilling Landgraf has uploaded a new change for review. Change subject: configurator: use sanlock group for sanlock check .. configurator: use sanlock group for sanlock check During the check if sanlock service is

Change in vdsm[master]: configurator: use sanlock group for sanlock check

2014-01-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator: use sanlock group for sanlock check .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6092/ :

Change in vdsm[master]: configurator: use sanlock group for sanlock check

2014-01-27 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: configurator: use sanlock group for sanlock check .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/23788 To unsubscribe, visit

Change in vdsm[master]: jsonrpc: Vdsm changes

2014-01-27 Thread barumuga
Bala.FA has posted comments on this change. Change subject: jsonrpc: Vdsm changes .. Patch Set 23: (2 comments) Poitr, could you share some context/design about this patch? Sorry, I might have missed that.

Change in vdsm[master]: jsonrpc: Vdsm changes

2014-01-27 Thread tjeyasin
Timothy Asir has posted comments on this change. Change subject: jsonrpc: Vdsm changes .. Patch Set 23: (6 comments) http://gerrit.ovirt.org/#/c/19497/23/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 51:

Change in vdsm[master]: vm: implement recommended clock settings

2014-01-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: implement recommended clock settings .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6093/ : SUCCESS