Change in vdsm[ovirt-3.3]: packaging: update python-cpopen requirement to 1.3

2014-02-23 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: packaging: update python-cpopen requirement to 1.3 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24874 To unsubscribe, visit

Change in vdsm[ovirt-3.3]: spec: add BuildRequires: python-cpopen

2014-02-23 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: spec: add BuildRequires: python-cpopen .. Patch Set 1: please add reviewed on link, can't find the change-id in master -- To view, visit

Change in vdsm[ovirt-3.3]: spec: add BuildRequires: python-cpopen

2014-02-23 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: spec: add BuildRequires: python-cpopen .. Patch Set 1: oh sorry, didn't notice the abandoned status. -- To view, visit http://gerrit.ovirt.org/24873 To

Change in vdsm[master]: [WIP] lvm: Add an option to replace locking type 4

2014-02-23 Thread ewarszaw
Eduardo has posted comments on this change. Change subject: [WIP] lvm: Add an option to replace locking type 4 .. Patch Set 2: Code-Review-1 (4 comments) http://gerrit.ovirt.org/#/c/23645/2/vdsm/storage/lvm.py File

Change in vdsm[master]: Fix in testLeakFd to avoid potential races during the check

2014-02-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix in testLeakFd to avoid potential races during the check .. Fix in testLeakFd to avoid potential races during the check To avoid corrupted tests

Change in vdsm[master]: vdsm-reg: collect vdsm-config.log

2014-02-23 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-reg: collect vdsm-config.log .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24862/1//COMMIT_MSG Commit Message: Line 7: collect you change the

Change in vdsm[master]: vm: snapshot transient disk check should be per disk

2014-02-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: snapshot transient disk check should be per disk .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24867 To unsubscribe, visit

Change in vdsm[master]: Reload daemon file after each install

2014-02-23 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Reload daemon file after each install .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24535 To unsubscribe, visit

Change in vdsm[master]: Reload daemon file after each install

2014-02-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Reload daemon file after each install .. Reload daemon file after each install Currently we load the daemon file only on first install. After upgrade

Change in vdsm[ovirt-3.4]: Reload daemon file after each install

2014-02-23 Thread ybronhei
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/24898 to review the following change. Change subject: Reload daemon file after each install .. Reload daemon file after each

Change in vdsm[ovirt-3.4]: Reload daemon file after each install

2014-02-23 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Reload daemon file after each install .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24898 To unsubscribe, visit

Change in vdsm[master]: vdsm-reg: collect vdsm-config.log

2014-02-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-reg: collect vdsm-config.log .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24862/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-02-21

Change in vdsm[master]: vdsm-reg: collect vdsm-config.log

2014-02-23 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-reg: collect vdsm-config.log .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24862/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-02-21

Change in vdsm[master]: [WIP] lvm: Add an option to replace locking type 4

2014-02-23 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: [WIP] lvm: Add an option to replace locking type 4 .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/23645/2/vdsm/storage/lvm.py File

Change in vdsm[master]: [WIP] Towards a more (block) secure HSM.

2014-02-23 Thread abaron
Ayal Baron has posted comments on this change. Change subject: [WIP] Towards a more (block) secure HSM. .. Patch Set 7: (3 comments) http://gerrit.ovirt.org/#/c/2218/7/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 310:

Change in vdsm[master]: [WIP] lvm: Add an option to replace locking type 4

2014-02-23 Thread abaron
Ayal Baron has posted comments on this change. Change subject: [WIP] lvm: Add an option to replace locking type 4 .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/23645/2/vdsm/storage/lvm.py File vdsm/storage/lvm.py:

Change in vdsm[master]: [WIP] Create storage domain using command type 1

2014-02-23 Thread ewarszaw
Eduardo has posted comments on this change. Change subject: [WIP] Create storage domain using command type 1 .. Patch Set 2: (5 comments) http://gerrit.ovirt.org/#/c/23646/2/vdsm/storage/blockSD.py File

Change in vdsm[master]: [WIP] Create storage pool using command type 1

2014-02-23 Thread abaron
Ayal Baron has posted comments on this change. Change subject: [WIP] Create storage pool using command type 1 .. Patch Set 2: (5 comments) http://gerrit.ovirt.org/#/c/23647/2/vdsm/storage/blockSD.py File

Change in vdsm[master]: [WIP] Create storage domain using command type 1

2014-02-23 Thread ewarszaw
Eduardo has posted comments on this change. Change subject: [WIP] Create storage domain using command type 1 .. Patch Set 2: Code-Review-1 -- To view, visit http://gerrit.ovirt.org/23646 To unsubscribe, visit

Change in vdsm[master]: vm: snapshot transient disk check should be per disk

2014-02-23 Thread laravot
Liron Ar has posted comments on this change. Change subject: vm: snapshot transient disk check should be per disk .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24867/2/vdsm/vm.py File vdsm/vm.py: Line 3955:

Change in vdsm[master]: [WIP] Create storage pool using command type 1

2014-02-23 Thread ewarszaw
Eduardo has posted comments on this change. Change subject: [WIP] Create storage pool using command type 1 .. Patch Set 2: Code-Review-1 (6 comments) http://gerrit.ovirt.org/#/c/23647/2/vdsm/storage/blockSD.py File

Change in vdsm[master]: vm: snapshot transient disk check should be per disk

2014-02-23 Thread laravot
Liron Ar has posted comments on this change. Change subject: vm: snapshot transient disk check should be per disk .. Patch Set 2: Code-Review-1 -- To view, visit http://gerrit.ovirt.org/24867 To unsubscribe, visit

Change in vdsm[ovirt-3.3]: vm: recover must finish with libvirt connection

2014-02-23 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: vm: recover must finish with libvirt connection .. Patch Set 3: Code-Review-1 the bz you attached is targeted to 3.4 -- To view, visit

Change in vdsm[master]: [WIP] lvm: Add an option to replace locking type 4

2014-02-23 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: [WIP] lvm: Add an option to replace locking type 4 .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/23645/2/vdsm/storage/lvm.py File

Change in vdsm[ovirt-3.3]: packaging: update python-cpopen requirement to 1.3

2014-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: packaging: update python-cpopen requirement to 1.3 .. Patch Set 2: Build Successful

Change in vdsm[master]: [WIP] destroy storage pool using command type 1

2014-02-23 Thread ewarszaw
Eduardo has posted comments on this change. Change subject: [WIP] destroy storage pool using command type 1 .. Patch Set 1: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/24398/1/vdsm/storage/blockSD.py File

Change in vdsm[master]: [WIP] destroy storage pool using command type 1

2014-02-23 Thread ewarszaw
Eduardo has posted comments on this change. Change subject: [WIP] destroy storage pool using command type 1 .. Patch Set 1: After review the engine part: 1) all the regular domains are detached and removed. 2) destroy

Change in vdsm[master]: [WIP] Create storage domain using command type 1

2014-02-23 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: [WIP] Create storage domain using command type 1 .. Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/23646/2/vdsm/storage/blockSD.py File

Change in vdsm[master]: [WIP] Create storage domain using command type 1

2014-02-23 Thread ewarszaw
Eduardo has posted comments on this change. Change subject: [WIP] Create storage domain using command type 1 .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/23646/2/vdsm/storage/lvm.py File vdsm/storage/lvm.py: Line

Change in vdsm[master]: vdsm-reg: collect vdsm-config.log

2014-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-reg: collect vdsm-config.log .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6460/ : SUCCESS

Change in vdsm[master]: Use same constants for configuring and check configure of sa...

2014-02-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Use same constants for configuring and check configure of sanlock .. Patch Set 3: Code-Review-1 I should probably say that I share Federico's about class

Change in vdsm[master]: xmlrpc: Support HTTP 1.1

2014-02-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: xmlrpc: Support HTTP 1.1 .. Patch Set 6: Verified+1 Rebase over dependent patch. Verified on RHEL 6.5 host and ovirt-engine 3.4 beta2: - starting and stopping vms

Change in vdsm[master]: threadLocal: Cleanup thread local storage

2014-02-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: threadLocal: Cleanup thread local storage .. Patch Set 4: Verified+1 Rebase over current master. Verified on RHEL 6.5 host and ovirt-engine 3.4 beta2: - starting

Change in vdsm[master]: utils: Ensure that XMLRPC threads do not delay shutdown

2014-02-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Ensure that XMLRPC threads do not delay shutdown .. Patch Set 2: Verified+1 Rebase over dependent patch. Verified on RHEL 6.5 host and ovirt-engine 3.4

Change in vdsm[master]: xmlrpc: Support HTTP 1.1

2014-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: xmlrpc: Support HTTP 1.1 .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6461/ : SUCCESS

Change in vdsm[master]: threadLocal: Cleanup thread local storage

2014-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: threadLocal: Cleanup thread local storage .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6463/ : SUCCESS

Change in vdsm[master]: utils: Ensure that XMLRPC threads do not delay shutdown

2014-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Ensure that XMLRPC threads do not delay shutdown .. Patch Set 2: Build Successful

Change in vdsm[master]: vdsm-reg: eliminate the VDSMBRIDGE macro

2014-02-23 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-reg: eliminate the VDSMBRIDGE macro .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24814 To unsubscribe, visit

Change in vdsm[master]: utils: Ensure that XMLRPC threads do not delay shutdown

2014-02-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: utils: Ensure that XMLRPC threads do not delay shutdown .. utils: Ensure that XMLRPC threads do not delay shutdown The threads created by the XMLRPC

Change in vdsm[master]: threadLocal: Cleanup thread local storage

2014-02-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: threadLocal: Cleanup thread local storage .. Patch Set 4: Code-Review+2 I like the code and I trust the verification. -- To view, visit

Change in vdsm[master]: threadLocal: Cleanup thread local storage

2014-02-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: threadLocal: Cleanup thread local storage .. threadLocal: Cleanup thread local storage We keep some data in thread local storage, but never clean up.

Change in vdsm[master]: xmlrpc: Support HTTP 1.1

2014-02-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Support HTTP 1.1 .. Patch Set 6: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/24294/6//COMMIT_MSG Commit Message: Line 16: methods are used

Change in vdsm[ovirt-3.3]: packaging: update python-cpopen requirement to 1.3

2014-02-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: packaging: update python-cpopen requirement to 1.3 .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24874 To unsubscribe, visit

Change in vdsm[master]: stats: report detailed VM down status

2014-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/353/ :