Change in vdsm[master]: tests: modprobe validation handle failure

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: modprobe validation handle failure
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I276cc2cf2205323648364c62b9db8f40e14cc983
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Mapping bonding option value names to numerics

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Mapping bonding option value names to numerics
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f4c16b1523822a2d53d4525841ff8741af6296c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net func tests: ip config drop on bond slaves

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net func tests: ip config drop on bond slaves
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17e848d86ab5423ac885f1d3db81d1e72c7a2dbe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: modprobe validation handle failure

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: tests: modprobe validation handle failure
..

tests: modprobe validation handle failure

On validation failure, add a skip action with
a proper message.

Change-Id: I276cc2cf2205323648364c62b9db8f40e14cc983
Signed-off-by: Edward Haas 
---
M tests/modprobe.py
1 file changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/49538/1

diff --git a/tests/modprobe.py b/tests/modprobe.py
index 82e2237..90b6fc1 100644
--- a/tests/modprobe.py
+++ b/tests/modprobe.py
@@ -18,6 +18,7 @@
 # Refer to the README and COPYING files for full details of the license
 import os
 from functools import wraps
+from nose.plugins.skip import SkipTest
 
 from vdsm import utils
 
@@ -37,6 +38,9 @@
 if not os.path.exists('/sys/module/dummy'):
 cmd_modprobe = [modprobe.cmd, "dummy"]
 rc, out, err = utils.execCmd(cmd_modprobe, sudo=True)
+if rc != 0:
+raise SkipTest("This test requires dummy module")
+
 return f(*args, **kwargs)
 return wrapper
 
@@ -51,6 +55,9 @@
 if not os.path.exists('/sys/module/bonding'):
 cmd_modprobe = [modprobe.cmd, "bonding"]
 rc, out, err = utils.execCmd(cmd_modprobe, sudo=True)
+if rc != 0:
+raise SkipTest("This test requires bonding module")
+
 return f(*args, **kwargs)
 
 return wrapper
@@ -66,5 +73,8 @@
 if not os.path.exists('/sys/module/veth'):
 cmd_modprobe = [modprobe.cmd, "veth"]
 rc, out, err = utils.execCmd(cmd_modprobe, sudo=True)
+if rc != 0:
+raise SkipTest("This test requires veth module")
+
 return f(*args, **kwargs)
 return wrapper


-- 
To view, visit https://gerrit.ovirt.org/49538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I276cc2cf2205323648364c62b9db8f40e14cc983
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: snapshot - enabling memory snapshot for diskless VM

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/49535/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3137
Line 3138
Line 3139
Line 3140
Line 3141
This allows memory snapshot without any disks - does this snapshot make sense? 
can you preview this snapshot?

When using cinder disk, the memory snapshot is stored on another domain. Do we 
save this vm in the ovf store of both domains? What happens when you detach the 
domain containing the memory snapshot?

Having vm with memory snapshots on another domain (the user have no control on 
this domain) seems like unwanted behavior.


-- 
To view, visit https://gerrit.ovirt.org/49535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lib: daemon: autodetect online cpus for affinity

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: lib: daemon: autodetect online cpus for affinity
..


Patch Set 8: Code-Review-1

(21 comments)

https://gerrit.ovirt.org/#/c/49402/8/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 206: ('connection_stats_timeout', '3600',
Line 207: 'Time in seconds defining how frequently we log transport 
stats'),
Line 208: 
Line 209: ('cpu_affinity', 'auto',
Line 210: 'Comma separated whitelist of CPU cores, expressed as 
integers '
Describe the comma separated list format after auto, since auto is preferred.
Line 211: 'starting from zero, or the special string value "auto".'
Line 212: 'This options selects the CPU cores on which VDSM is 
allowed '
Line 213: 'to run. Use the empty value to disable the affinity, 
allowing '
Line 214: 'Vdsm to run on all the online cores. '


Line 209: ('cpu_affinity', 'auto',
Line 210: 'Comma separated whitelist of CPU cores, expressed as 
integers '
Line 211: 'starting from zero, or the special string value "auto".'
Line 212: 'This options selects the CPU cores on which VDSM is 
allowed '
Line 213: 'to run. Use the empty value to disable the affinity, 
allowing '
Describe the empty value last, as this is the worst option for users.
Line 214: 'Vdsm to run on all the online cores. '
Line 215: 'The default is "auto", meaning Vdsm will pick the first 
online '
Line 216: 'core, starting with the second one. If only the first 
core is '
Line 217: 'online, it will pin on the first core.'


Line 213: 'to run. Use the empty value to disable the affinity, 
allowing '
Line 214: 'Vdsm to run on all the online cores. '
Line 215: 'The default is "auto", meaning Vdsm will pick the first 
online '
Line 216: 'core, starting with the second one. If only the first 
core is '
Line 217: 'online, it will pin on the first core.'
Describe the default first, as this is the option that most people will use.
Line 218: 'Valid examples: "1", "0,1", "0,2,3", "auto"'),
Line 219: 
Line 220: ('ssl_implementation', '@SSL_IMPLEMENTATION@',
Line 221: 'Specifies which ssl implementation should be used. '


Line 214: 'Vdsm to run on all the online cores. '
Line 215: 'The default is "auto", meaning Vdsm will pick the first 
online '
Line 216: 'core, starting with the second one. If only the first 
core is '
Line 217: 'online, it will pin on the first core.'
Line 218: 'Valid examples: "1", "0,1", "0,2,3", "auto"'),
Show valid examples in order of preferences:

"auto", "1", "1,2", ""

Don't show 0,1 or 0,2,3, these are bad settings.
Line 219: 
Line 220: ('ssl_implementation', '@SSL_IMPLEMENTATION@',
Line 221: 'Specifies which ssl implementation should be used. '
Line 222: 'There are 2 options: '


https://gerrit.ovirt.org/#/c/49402/8/lib/vdsm/taskset.py
File lib/vdsm/taskset.py:

Line 24: from . import constants
Line 25: from . import utils
Line 26: 
Line 27: 
Line 28: AUTOMATIC = "auto"
AUTO? make it look like the value.
Line 29: 
Line 30: 
Line 31: _SYS_ONLINE_CPUS = "/sys/devices/system/cpu/online"
Line 32: 


Line 26: 
Line 27: 
Line 28: AUTOMATIC = "auto"
Line 29: 
Line 30: 
Les keep one or zero empty line between these constants.
Line 31: _SYS_ONLINE_CPUS = "/sys/devices/system/cpu/online"
Line 32: 
Line 33: 
Line 34: def get(pid):


Line 81: """
Line 82: Return a frozenset which contains identifiers of online CPUs,
Line 83: as non-negative integers.
Line 84: """
Line 85: return _expand_range(_read_contents(_SYS_ONLINE_CPUS))
_read_contents does not add any value, why not inline it here?
Line 86: 
Line 87: 
Line 88: def pick_cpu(cpu_set):
Line 89: """


Line 84: """
Line 85: return _expand_range(_read_contents(_SYS_ONLINE_CPUS))
Line 86: 
Line 87: 
Line 88: def pick_cpu(cpu_set):
Why pick a cpu from the given set, instead of reading the online cpus and 
returning the best cpu?
Line 89: """
Line 90: Autoselect the best CPU VDSM should pin to.
Line 91: `cpu_set' is any iterable which produces the sequence of all
Line 92: available CPUs, among which VDSM should pick the best one.


Line 86: 
Line 87: 
Line 88: def pick_cpu(cpu_set):
Line 89: """
Line 90: Autoselect the best CPU VDSM should pin to.
Autoselect -> Select
Line 91: `cpu_set' is any iterable which produces the sequence of all
Line 92: available CPUs, among which VDSM should pick the best one.
Line 93: """
Line 94: cpu_list = sorted(cpu_set)


Line 102: # Let's play nice, and try to find a quieter spot.
Line 103: return cpu_list[1]
Line 104: 
Line 105: # no 

Change in vdsm[master]: vm: snapshot - enabling memory snapshot for diskless VM

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..


Patch Set 1:

Daniel, please check why jenkins is failing, explain if the failure is relevant 
to this patch, report ci failures to infra mailing list, and test failures to 
devel mailing list.

-- 
To view, visit https://gerrit.ovirt.org/49535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: snapshot - enabling memory snapshot for diskless VM

[derez]

Daniel Erez has posted comments on this change.

Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/49535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: snapshot - enabling memory snapshot for diskless VM

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/49535/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-12-01 21:00:52 +0200
Line 4: Commit: Daniel Erez 
Line 5: CommitDate: 2015-12-01 21:09:15 +0200
Line 6: 
Line 7: vm: snapshot - enabling memory snapshot for diskless VM
Vm with cinder disk is not diskless  - how about:

enabling memory snapshot without disks

And then explain the possible configurations and settings that lead to this 
flow:

- Unchecking the disks in the snapshot dialog
- Vm with only cinder disks
- Vm without disks
Line 8: 
Line 9: Taking a memory snapshot of a VM without disks should be
Line 10: supported (or merely with Cinder/LUN disks for that matter).
Line 11: 


-- 
To view, visit https://gerrit.ovirt.org/49535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net func tests: ip config drop on bond slaves

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net func tests: ip config drop on bond slaves
..

net func tests: ip config drop on bond slaves

Moving an interface to a bond should flush/drop
its ip configuration.

Existing test changed to reflect this logic.
[test_drop_initial_bond_slaves_ip_config]

Change-Id: I17e848d86ab5423ac885f1d3db81d1e72c7a2dbe
Signed-off-by: Edward Haas 
---
M tests/functional/networkTests.py
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/49539/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index be27dc2..8a44802 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -2680,7 +2680,7 @@
 
 @cleanupNet
 @ValidateRunningAsRoot
-def test_keep_initial_bond_slaves_ip_config(self):
+def test_drop_initial_bond_slaves_ip_config(self):
 with dummyIf(2) as nics:
 nic_1, nic_2 = nics
 addrAdd(nic_1, IP_ADDRESS, IP_CIDR)
@@ -2692,8 +2692,8 @@
 
 ipv4addrs = self.vdsm_net.netinfo.nics[nic_1]['ipv4addrs']
 ipv6addrs = self.vdsm_net.netinfo.nics[nic_1]['ipv6addrs']
-self.assertIn(IP_ADDRESS_AND_CIDR, ipv4addrs)
-self.assertIn(IPv6_ADDRESS_AND_CIDR, ipv6addrs)
+self.assertEqual([], ipv4addrs)
+self.assertEqual([], ipv6addrs)
 
 status, msg = self.vdsm_net.setupNetworks(
 {}, {BONDING_NAME: {'remove': True}}, NOCHK)


-- 
To view, visit https://gerrit.ovirt.org/49539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I17e848d86ab5423ac885f1d3db81d1e72c7a2dbe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lib: daemon: autodetect online cpus for affinity

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: lib: daemon: autodetect online cpus for affinity
..


Patch Set 8:

(3 comments)

https://gerrit.ovirt.org/#/c/49402/8//COMMIT_MSG
Commit Message:

Line 24: the only option is to make VDSM smarter, and let it learn the
Line 25: set of online cpus when it starts.
Line 26: After VDSM starts, the kernel is smart enough to handle the offlining
Line 27: of one cpu where some processes are pinned, so the problem
Line 28: is just the startup.
Too much history...
Line 29: 
Line 30: We add a function to learn from the kernel which cpus are online,
Line 31: using a file from /sys pseudo-filesystem. The layout of /sys,
Line 32: like /proc, is part of the kernel ABI, so there are only small


Line 30: We add a function to learn from the kernel which cpus are online,
Line 31: using a file from /sys pseudo-filesystem. The layout of /sys,
Line 32: like /proc, is part of the kernel ABI, so there are only small
Line 33: breakage concerns [1][2]. Furthermore, we already rely on /sys
Line 34: for other VDSM flows, so this patch doesn't add fragility
Can you check how libvirt is returning the cpu status? Maybe they have more 
robust way?
Line 35: 
Line 36: We add a special value to the cpu_affinity tunable, to let
Line 37: VDSM autoselect one cpu, or to let the admin explicitely
Line 38: select the cpus on which VDSM could run.


Line 33: breakage concerns [1][2]. Furthermore, we already rely on /sys
Line 34: for other VDSM flows, so this patch doesn't add fragility
Line 35: 
Line 36: We add a special value to the cpu_affinity tunable, to let
Line 37: VDSM autoselect one cpu, or to let the admin explicitely
autoselect one cpu -> select automatically best cpu

And not description of how we pick the best cpu and why.
Line 38: select the cpus on which VDSM could run.
Line 39: 
Line 40: [1] https://www.kernel.org/doc/Documentation/ABI/README
Line 41: [2] 
https://www.kernel.org/doc/Documentation/ABI/testing/sysfs-devices-system-cpu


-- 
To view, visit https://gerrit.ovirt.org/49402
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba834f67a43ce766308036cbd079107340ed69d8
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Add alerts when replica count is not 3

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Add alerts when replica count is not 3
..


Patch Set 3:

Ala, please address Piotr comment about the schema.

-- 
To view, visit https://gerrit.ovirt.org/49475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29023470a17c48d396cb58eec0660de7faba4ee0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Add alerts when replica count is not 3

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Add alerts when replica count is not 3
..


Patch Set 3:

(3 comments)

https://gerrit.ovirt.org/#/c/49475/3/tests/storageServerTests.py
File tests/storageServerTests.py:

Line 224
Line 225
Line 226
Line 227
Line 228
We also needs tests for alerts management:
- connect/disconnect clear existing alerts (all classes)
- failed connect keeps alerts (not clear by disconnect called as cleanup)
- alerts empty when creating connection (all classes)


Line 241: storageServer.supervdsm.glusterVolumeInfo = glusterVolumeInfo
Line 242: 
Line 243: gluster = GlusterFSConnection(spec="192.168.122.1:/music")
Line 244: gluster.validate()
Line 245: if (gluster.alerts):
The test will pass if you never return any alert :-)

You should test that alerts == [] when alert_code is None, and alert contains 
the expected alert when alert_code is not None.

To make this nicer, create one test for supported replica count and one test 
for unsupported. We need only permutations for the replica count, like the old 
test.
Line 246: self.assertEquals(gluster.alerts[0][0].info()['code'],


Line 243: gluster = GlusterFSConnection(spec="192.168.122.1:/music")
Line 244: gluster.validate()
Line 245: if (gluster.alerts):
Line 246: self.assertEquals(gluster.alerts[0][0].info()['code'],
Line 247:   alert_code)
should test:
- got one alert

  len(gluster.alerts) == 1

- alert.code is expected

  gluster.alerts[0].code == code


-- 
To view, visit https://gerrit.ovirt.org/49475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29023470a17c48d396cb58eec0660de7faba4ee0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: alerts: Introduce the alerts module

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: alerts: Introduce the alerts module
..


Patch Set 2:

(1 comment)

Piotr, code generating alerts will return them to engine. We have existing code 
when getting information about domains, and new code (next patch), returning 
alerts after successful connection to storage server.

In the future, we can use events to send these alerts. This is just the way to 
keep alert information until you deliver it to engine in whatever way, similar 
to storage/storage_exception.py and lib/vdsm/exception.py.

https://gerrit.ovirt.org/#/c/49474/2/lib/vdsm/alerts.py
File lib/vdsm/alerts.py:

Line 25: def __str__(self):
Line 26: return self.message.format(self=self)
Line 27: 
Line 28: def info(self):
Line 29: return {'code': self.code, 'message': str(self)}
> this really seems a response objects, as we seen in many other places. If s
response returns {status: {"code": ..., "message": ...}}

This is not a response, but the response status.

info() is a genric name when you return a dictionary describing some object. We 
can use other name like todict() or asdict() but I like info more. See for 
example the jobs module.

We certainly don't want to use the response module, which is a temporary hack 
needed because virt does not have proper exceptions with a response() method. 
We will be able to drop it when we finish 
https://gerrit.ovirt.org/#/q/status:open+topic:exceptions
Line 30: 
Line 31: 
Line 32: class UnsupportedReplicaCount(Alert):
Line 33: code = 7000


-- 
To view, visit https://gerrit.ovirt.org/49474
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6874f2ec39294888de01ba0a5c6e9d1d1a42c63b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: snapshot - enabling memory snapshot for diskless VM

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/49535/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3137
Line 3138
Line 3139
Line 3140
Line 3141
> Previewing a snapshot without disks can be previewed. Though it's probably 
Until now, memory snapshot without disk did nothing. This looks like a bug, but 
I don't think we should change it.

The only change needed is supporting memory snapshot with cinder disk. Do we 
have an easy way to tell that we have a cinder disk here? We can use the frozen 
boolean, but it is too sneaky.

Lets think about a better way to do this. There is no rush, cinder is a new 
feature, and I don't see any problem if will not support memory snapshot in the 
current build.


-- 
To view, visit https://gerrit.ovirt.org/49535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Add alerts when replica count is not 3

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Add alerts when replica count is not 3
..


Patch Set 3:

Pitor, there is no need to use events when you perform synchronous task such as 
connecting to storage server. The engine waits for reply and get the status and 
optional alerts.

If we move this to asynchronous task, I agree that posting notifications makes 
sense.

Anyway, events are optimization, they do not replace the response.

Finally, we do not use events in storage in 3.6, and this is urgent fix for 3.6.

-- 
To view, visit https://gerrit.ovirt.org/49475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29023470a17c48d396cb58eec0660de7faba4ee0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: snapshot - enabling memory snapshot for diskless VM

[derez]

Daniel Erez has posted comments on this change.

Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/49535/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-12-01 21:00:52 +0200
Line 4: Commit: Daniel Erez 
Line 5: CommitDate: 2015-12-01 21:09:15 +0200
Line 6: 
Line 7: vm: snapshot - enabling memory snapshot for diskless VM
> Vm with cinder disk is not diskless  - how about:
Done
Line 8: 
Line 9: Taking a memory snapshot of a VM without disks should be
Line 10: supported (or merely with Cinder/LUN disks for that matter).
Line 11: 


https://gerrit.ovirt.org/#/c/49535/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3137
Line 3138
Line 3139
Line 3140
Line 3141
> This allows memory snapshot without any disks - does this snapshot make sen
Previewing a snapshot without disks can be previewed. Though it's probably not 
very useful, it does make sense in some scenarios.

We currently require a master domain in order to use Cinder. So, the ram disk 
and ovf will be saved on one of the data domains. Detaching is blocked by the 
engine in case some VMs are using it. And it's not related to this patch any 
way... :) 

According to the current behavior, we already have some logic for selecting the 
target storage domain (free space, etc). Again, not related to this patch at 
all :)


-- 
To view, visit https://gerrit.ovirt.org/49535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Add alerts when replica count is not 3

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Add alerts when replica count is not 3
..


Patch Set 3:

I think a nicer solution would be to return a namedtuple from connect and 
disconnect:

Result = namedtuple("Result", "status, alerts")

def connect(self):
alerts = self.validate()
...
return Result(0, alerts)

def disconnect(self):
...
 return Result(0, [])

No need to subclass anything, just change the return values.

-- 
To view, visit https://gerrit.ovirt.org/49475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29023470a17c48d396cb58eec0660de7faba4ee0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: exception: Add exceptions for vdsm.define errors
..


Patch Set 5:

Francesco?

-- 
To view, visit https://gerrit.ovirt.org/48871
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01b736c06414a3af758ad6bdabddb6c25b620756
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Add alerts when replica count is not 3

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Add alerts when replica count is not 3
..


Patch Set 3: Code-Review-1

(4 comments)

Will be ok with little more work, but I don't like this code. Too much 
boilerplate code and too much change in code that do not need alerts.

https://gerrit.ovirt.org/#/c/49475/3/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 238
Line 239
Line 240
Line 241
Line 242
connect() uses disconnect() during cleanup. Since we clear the alerts on on 
disconnect, we will loose possible alerts during failures.

To make this correct, connect should never call disconnect, but a private 
method doing the same.

def disconnect(self):
self._alerts = []
self._disconnect()


Line 543
Line 544
Line 545
Line 546
Line 547
Clear the alerts, same for connect.


Line 641
Line 642
Line 643
Line 644
Line 645
Should also clear the alerts.


Line 348: 
Line 349: def validate(self):
Line 350: replicaCount = self.volinfo['replicaCount']
Line 351: if replicaCount not in self.ALLOWED_REPLICA_COUNTS:
Line 352: 
self._alerts.append([alerts.UnsupportedReplicaCount(replicaCount)])
Why do you append a list with one alert, instead of the alert itself?
Line 353: 
Line 354: def _get_backup_servers_option(self):
Line 355: servers = utils.unique(brick.split(":")[0] for brick
Line 356:in self.volinfo['bricks'])


-- 
To view, visit https://gerrit.ovirt.org/49475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29023470a17c48d396cb58eec0660de7faba4ee0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ImageManifest: create_image_dir

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ImageManifest: create_image_dir
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/43557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94a8cfdd9fb1f3c3fd4e4e2ab409bfd287829351
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: FakeLVM: support single LV and array in activateLVs

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: FakeLVM: support single LV and array in activateLVs
..

FakeLVM: support single LV and array in activateLVs

Change-Id: I091aab3c9ccab16e8d4d9693957a061afac1366d
Signed-off-by: Adam Litke 
---
M tests/storagefakelib.py
M tests/storagefakelibTests.py
2 files changed, 14 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/49547/1

diff --git a/tests/storagefakelib.py b/tests/storagefakelib.py
index 7d6092c..234cd57 100644
--- a/tests/storagefakelib.py
+++ b/tests/storagefakelib.py
@@ -126,6 +126,7 @@
 self.vgmd[vgName]['lv_count'] = str(lv_count)
 
 def activateLVs(self, vgName, lvNames):
+lvNames = real_lvm._normalizeargs(lvNames)
 for lv in lvNames:
 try:
 lv_md = self.lvmd[(vgName, lv)]
diff --git a/tests/storagefakelibTests.py b/tests/storagefakelibTests.py
index dcdfd19..f7bbfb2 100644
--- a/tests/storagefakelibTests.py
+++ b/tests/storagefakelibTests.py
@@ -29,6 +29,7 @@
 from storage import lvm as real_lvm
 
 
+@expandPermutations
 class FakeLVMSimpleVGTests(VdsmTestCase):
 VG_NAME = '1ffead52-7363-4968-a8c7-3bc34504d452'
 DEVICES = ['360014054d75cb132d474c0eae9825766']
@@ -257,9 +258,14 @@
   lvm.changeLVTags, self.VG_NAME, self.LV_NAME,
   delTags=("FOO",), addTags=("FOO",))
 
-def test_activatelv(self):
+@permutations([
+[LV_NAME],
+[[LV_NAME]],
+])
+def test_activatelv(self, lv_arg):
 """
-Create an inactive LV and then activate it.
+Create an inactive LV and then activate it.  Test that scalar and
+array based values are handled properly.
 
 lvm.createLV('1ffead52-7363-4968-a8c7-3bc34504d452',
  '54e3378a-b2f6-46ff-b2da-a9c82522a55e',
@@ -282,10 +288,11 @@
 with self.base_config() as lvm:
 lvm.createLV(self.VG_NAME, self.LV_NAME, str(self.LV_SIZE_MB),
  activate=False)
-lvm.activateLVs(self.VG_NAME, [self.LV_NAME])
-lv = lvm.getLV(self.VG_NAME, self.LV_NAME)
-self.assertTrue(lv.active)
-self.assertEqual('a', lv.attr.state)
+lvm.activateLVs(self.VG_NAME, lv_arg)
+for lv_name in real_lvm._normalizeargs(lv_arg):
+lv = lvm.getLV(self.VG_NAME, lv_name)
+self.assertTrue(lv.active)
+self.assertEqual('a', lv.attr.state)
 
 
 @expandPermutations


-- 
To view, visit https://gerrit.ovirt.org/49547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I091aab3c9ccab16e8d4d9693957a061afac1366d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: FakeLVM: Add changeLVTags

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: FakeLVM: Add changeLVTags
..

FakeLVM: Add changeLVTags

Change-Id: I169fffbc5d865bc987897655a1081b979910c589
Signed-off-by: Adam Litke 
---
M tests/storagefakelib.py
M tests/storagefakelibTests.py
2 files changed, 46 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/49546/1

diff --git a/tests/storagefakelib.py b/tests/storagefakelib.py
index bd098c1..7d6092c 100644
--- a/tests/storagefakelib.py
+++ b/tests/storagefakelib.py
@@ -141,6 +141,26 @@
 raise se.MissingTagOnLogicalVolume("%s/%s" % (vg, lv), tag)
 lv_md['tags'] += (tag,)
 
+def changeLVTags(self, vg, lv, delTags=(), addTags=()):
+try:
+lv_md = self.lvmd[(vg, lv)]
+except KeyError:
+raise se.LogicalVolumeReplaceTagError("LV %s does not exist",
+  "%s/%s" % (vg, lv))
+
+lvTags = set(lv_md['tags'])
+delTags = set(delTags)
+addTags = set(addTags)
+if delTags & addTags:
+raise se.LogicalVolumeReplaceTagError(
+"Cannot add and delete the same tag lv: `%s` tags: `%s`" %
+(lv, ", ".join(delTags.intersection(addTags
+
+# Adding an existing tag or removing a nonexistent tag are ignored
+lvTags |= addTags
+lvTags -= delTags
+lv_md['tags'] = tuple(lvTags)
+
 def lvPath(self, vgName, lvName):
 return os.path.join(self.root, "dev", vgName, lvName)
 
diff --git a/tests/storagefakelibTests.py b/tests/storagefakelibTests.py
index 3af4d54..dcdfd19 100644
--- a/tests/storagefakelibTests.py
+++ b/tests/storagefakelibTests.py
@@ -232,6 +232,31 @@
 lv = lvm.getLV(self.VG_NAME, self.LV_NAME)
 self.assertEqual((blockVolume.TAG_VOL_UNINIT, "FOO"), lv.tags)
 
+def test_changelvtags(self):
+"""
+Create a logical volume with an initial tag and replace it.
+"""
+with self.base_config() as lvm:
+lvm.createLV(self.VG_NAME, self.LV_NAME, str(self.LV_SIZE_MB),
+ initialTags=(blockVolume.TAG_VOL_UNINIT,))
+deltags = (blockVolume.TAG_VOL_UNINIT,)
+addtags = ("FOO",)
+lvm.changeLVTags(self.VG_NAME, self.LV_NAME,
+ delTags=deltags, addTags=addtags)
+lv = lvm.getLV(self.VG_NAME, self.LV_NAME)
+self.assertEqual(addtags, lv.tags)
+
+def test_changelvtags_add_and_delete_same_tag(self):
+"""
+Test that adding and removing the same tag is forbidden.
+
+"""
+with self.base_config() as lvm:
+lvm.createLV(self.VG_NAME, self.LV_NAME, str(self.LV_SIZE_MB))
+self.assertRaises(se.LogicalVolumeReplaceTagError,
+  lvm.changeLVTags, self.VG_NAME, self.LV_NAME,
+  delTags=("FOO",), addTags=("FOO",))
+
 def test_activatelv(self):
 """
 Create an inactive LV and then activate it.
@@ -281,6 +306,7 @@
 [se.CannotCreateLogicalVolume, 'createLV', ['vg', 'lv', '1024']],
 [se.LogicalVolumeDoesNotExistError, 'getLV', ['vg', 'lv']],
 [se.InaccessiblePhysDev, 'getPV', ['pv']],
+[se.LogicalVolumeReplaceTagError, 'changeLVTags', ['vg', 'lv']],
 ])
 def test_bad_args(self, exception, fn, args):
 with namedTemporaryDir() as tmpdir:


-- 
To view, visit https://gerrit.ovirt.org/49546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I169fffbc5d865bc987897655a1081b979910c589
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: add FakeSanlock.init_resource

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: add FakeSanlock.init_resource
..

tests: add FakeSanlock.init_resource

Change-Id: I61ec7d516dc77e318a1c2d4c10bf49ccfdc5098b
Signed-off-by: Adam Litke 
---
M tests/testrunner.py
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/49542/1

diff --git a/tests/testrunner.py b/tests/testrunner.py
index 7e68aaa..b37902e 100644
--- a/tests/testrunner.py
+++ b/tests/testrunner.py
@@ -52,6 +52,9 @@
 HOST_FAIL = 4
 HOST_DEAD = 5
 
+def init_resource(self, sdUUID, volUUID, lockDisk):
+pass
+
 
 sys.modules.update({'sanlock': FakeSanlock()})
 


-- 
To view, visit https://gerrit.ovirt.org/49542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61ec7d516dc77e318a1c2d4c10bf49ccfdc5098b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Introduce VolumeArtifacts

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Introduce VolumeArtifacts
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I352423e39a899b9b83ccf3b8f6c17ec433e9c353
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileVolume: refactor _putMetadata to support volume artifacts

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: fileVolume: refactor _putMetadata to support volume artifacts
..

fileVolume: refactor _putMetadata to support volume artifacts

When writing normal FileVolume metadata we use the standard metadata
path.  When creating a FileVolumeArtifact we need to write the metadata
to a different location.  Refactor _putMetadata and create a new method
_putArtifactMetadata for writing in the special location.

Change-Id: I5253b6692b8c58967bbd2c421abcce05c584d769
Signed-off-by: Adam Litke 
---
M vdsm/storage/fileVolume.py
1 file changed, 15 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/49545/1

diff --git a/vdsm/storage/fileVolume.py b/vdsm/storage/fileVolume.py
index bcc7a3a..70bb7a6 100644
--- a/vdsm/storage/fileVolume.py
+++ b/vdsm/storage/fileVolume.py
@@ -237,18 +237,26 @@
 self.file_setrw(self.getVolumePath(), rw=rw)
 
 @classmethod
-def _putMetadata(cls, metaId, meta):
-volPath, = metaId
-metaPath = cls._metaVolumePath(volPath)
-
+def __writeMetadata(cls, metaPath, meta):
 data = cls.formatMetadata(meta)
-
 with open(metaPath + ".new", "w") as f:
 f.write(data)
-
-sdUUID = getDomUuidFromVolumePath(volPath)
+
+sdUUID = getDomUuidFromVolumePath(metaPath)
 oop.getProcessPool(sdUUID).os.rename(metaPath + ".new", metaPath)
 
+@classmethod
+def _putMetadata(cls, metaId, meta):
+volPath, = metaId
+path = cls._metaVolumePath(volPath)
+cls.__writeMetadata(path, meta)
+
+@classmethod
+def putArtifactMetadata(cls, metaId, meta):
+volPath, = metaId
+path = cls._metaVolumePath(volPath) + ARTIFACT_FILEEXT
+cls.__writeMetadata(path, meta)
+
 def setImage(self, imgUUID):
 """
 Set image UUID


-- 
To view, visit https://gerrit.ovirt.org/49545
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5253b6692b8c58967bbd2c421abcce05c584d769
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileVolume: refactor _putMetadata to support volume artifacts

[automation]

gerrit-hooks has posted comments on this change.

Change subject: fileVolume: refactor _putMetadata to support volume artifacts
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49545
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5253b6692b8c58967bbd2c421abcce05c584d769
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileVolume: define file extension for volume artifacts metadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: fileVolume: define file extension for volume artifacts metadata
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id14e79d400d6936c8bb0da5dec39e3f9fb60c803
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: wip

[alitke]

Adam Litke has abandoned this change.

Change subject: wip
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/49549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ica3ddbd2bb3da5b699d8abb8977daef834bf6f29
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: wip

[automation]

gerrit-hooks has posted comments on this change.

Change subject: wip
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/49549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica3ddbd2bb3da5b699d8abb8977daef834bf6f29
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: wip: how can I test block volumes?

[automation]

gerrit-hooks has posted comments on this change.

Change subject: wip: how can I test block volumes?
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f584edabe61f6c5c473f722b7d1d20a505a5849
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: StorageDomainManifest: Manifest objects produce VolumeMetada...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata 
objects
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44040
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb2723c8ce2108b3e5ac2f35be2f59f083095e0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: FakeLVM: support single LV and array in activateLVs

[automation]

gerrit-hooks has posted comments on this change.

Change subject: FakeLVM: support single LV and array in activateLVs
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I091aab3c9ccab16e8d4d9693957a061afac1366d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: wip: how can I test block volumes?

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: wip: how can I test block volumes?
..

wip: how can I test block volumes?

Change-Id: I4f584edabe61f6c5c473f722b7d1d20a505a5849
Signed-off-by: Adam Litke 
---
M tests/storagetestlib.py
M tests/volumeartifacts_tests.py
M vdsm/storage/blockVolume.py
3 files changed, 42 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/49548/1

diff --git a/tests/storagetestlib.py b/tests/storagetestlib.py
index a3568b5..47cd3ab 100644
--- a/tests/storagetestlib.py
+++ b/tests/storagetestlib.py
@@ -53,7 +53,11 @@
 
 fake_lvm.createVG(sduuid, devices, blockSD.STORAGE_DOMAIN_TAG,
   blockSD.VG_METADATASIZE)
+os.makedirs(os.path.join(tmpdir, 'dev', sduuid))
 fake_lvm.createLV(sduuid, sd.METADATA, blockSD.SD_METADATA_SIZE)
+with open(fake_lvm.lvPath(sduuid, sd.METADATA), 'w') as f:
+os.ftruncate(f.fileno(), blockSD.SD_METADATA_SIZE << 20)
+
 
 # Create the rest of the special LVs
 for metafile, sizemb in sd.SPECIAL_VOLUME_SIZES_MIB.iteritems():
diff --git a/tests/volumeartifacts_tests.py b/tests/volumeartifacts_tests.py
index 9824973..7275e57 100644
--- a/tests/volumeartifacts_tests.py
+++ b/tests/volumeartifacts_tests.py
@@ -29,11 +29,6 @@
 from storage import blockSD, fileSD, image, volume, blockVolume, fileVolume
 
 
-class FakeDomainManifest(object):
-def __init__(self, sduuid):
-self.sdUUID = sduuid
-
-
 class VolumeArtifactsTestsMixin(object):
 def setUp(self):
 self.sduuid = str(uuid.uuid4())
@@ -104,9 +99,13 @@
 
 class FakeBlockVolumeMetadata(blockVolume.BlockVolumeMetadata):
 
-@classmethod
-def _putMetadata(cls, metaId, meta):
-fake_metadata[metaId] = meta
+def __init__(self, repoPath, sdUUID, imgUUID, volUUID):
+super(FakeBlockVolumeMetadata, self).__init__(
+repoPath, sdUUID, imgUUID, volUUID)
+
+#@classmethod
+#def _putMetadata(cls, metaId, meta):
+#fake_metadata[('vol_md', metaId)] = meta
 
 
 class BlockVolumeArtifactsTests(VolumeArtifactsTestsMixin, VdsmTestCase):
@@ -120,13 +119,24 @@
 lvm = FakeLVM(tmpdir)
 with MonkeyPatchScope([
 (blockSD, 'lvm', lvm),
+(blockSD, 'selectMetadata', self.fake_select_metadata),
 (blockVolume, 'lvm', lvm),
-(blockVolume, 'BlockVolumeMetadata',
- FakeBlockVolumeMetadata)]):
+#(blockVolume, 'BlockVolumeMetadata',
+# FakeBlockVolumeMetadata),
+#(image.ImageManifest, 'create_image_dir',
+# self.fake_create_image_dir)]):
+]):
 manifest = make_blocksd(tmpdir, lvm, sduuid=self.sduuid)
+fake_metadata[('sd_md', manifest.sdUUID)] = manifest._metadata
 self._fake_metadata = {}
 yield manifest
 
+def fake_select_metadata(self, sduuid):
+return fake_metadata[('sd_md', sduuid)]
+
+def fake_create_image_dir(self, sd_id, img_id):
+pass
+
 def test_size_adjusted(self):
 # Test that size is rounded up to LVM granularity
 pass
diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py
index 6af171b..d4fa8f2 100644
--- a/vdsm/storage/blockVolume.py
+++ b/vdsm/storage/blockVolume.py
@@ -78,7 +78,16 @@
vol_id)
 
 def validate(self):
-raise volume.VolumeArtifactsNotFound()
+try:
+lv = lvm.getLV(self.domain_manifest.sdUUID, self.vol_id)
+except se.LogicalVolumeDoesNotExistError:
+self.log.error("LV artifact missing: %s/%s",
+   self.domain_manifest.sdUUID, self.vol_id)
+raise volume.VolumeArtifactsNotFound()
+if TAG_VOL_ARTIFACT not in lv.tags:
+self.log.error("LV missing TAG_VOL_ARTIFACT tag: %s/%s",
+   self.domain_manifest.sdUUID, self.vol_id)
+raise volume.VolumeArtifactsNotFound()
 
 def create(self, size, vol_format, disk_type, desc,
parent_vol_id=volume.BLANK_UUID):
@@ -98,8 +107,13 @@
 tags = [TAG_VOL_ARTIFACT,
 TAG_PREFIX_PARENT + parent_vol_id,
 TAG_PREFIX_IMAGE + self.img_id]
-lvm.createLV(self.domain_manifest.sdUUID, self.vol_id, lv_size,
- activate=True, initialTags=tags)
+try:
+lvm.createLV(self.domain_manifest.sdUUID, self.vol_id, lv_size,
+ activate=True, initialTags=tags)
+except se.CannotCreateLogicalVolume as e:
+self.log.error("Failed to create LV %s/%s: %s",
+   self.domain_manifest.sdUUID, self.vol_id, e)
+raise volume.CannotCreateVolumeArtifacts()

Change in vdsm[master]: wip

[automation]

gerrit-hooks has posted comments on this change.

Change subject: wip
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica3ddbd2bb3da5b699d8abb8977daef834bf6f29
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: add FakeSanlock.init_resource

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: add FakeSanlock.init_resource
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61ec7d516dc77e318a1c2d4c10bf49ccfdc5098b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lvm: Allow multiple initial tags when creating an LV

[automation]

gerrit-hooks has posted comments on this change.

Change subject: lvm: Allow multiple initial tags when creating an LV
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2524f0127a7cb0eff5d7639b8ba1d916fd66af6a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: FakeLVM: Add changeLVTags

[automation]

gerrit-hooks has posted comments on this change.

Change subject: FakeLVM: Add changeLVTags
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169fffbc5d865bc987897655a1081b979910c589
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: wip

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: wip
..

wip

Change-Id: Ica3ddbd2bb3da5b699d8abb8977daef834bf6f29
Signed-off-by: Adam Litke 
---
M tests/volumeartifacts_tests.py
M vdsm/storage/blockVolume.py
M vdsm/storage/fileVolume.py
M vdsm/storage/volume.py
4 files changed, 41 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/49549/1

diff --git a/tests/volumeartifacts_tests.py b/tests/volumeartifacts_tests.py
index 7275e57..accd402 100644
--- a/tests/volumeartifacts_tests.py
+++ b/tests/volumeartifacts_tests.py
@@ -22,11 +22,13 @@
 from contextlib import contextmanager
 
 from testlib import VdsmTestCase, namedTemporaryDir
+from testlib import permutations, expandPermutations
 from storagetestlib import make_blocksd, make_filesd_manifest
 from storagefakelib import FakeLVM
 from monkeypatch import MonkeyPatchScope
 
 from storage import blockSD, fileSD, image, volume, blockVolume, fileVolume
+from storage.sdmprotect import sdm_verb
 
 
 class VolumeArtifactsTestsMixin(object):
@@ -38,8 +40,7 @@
 vol_id = str(uuid.uuid4())
 with self.fake_env() as manifest:
 artifacts = self.artifacts_class(manifest, img_id, vol_id)
-self.assertRaises(volume.VolumeArtifactsNotFound,
-  artifacts.validate)
+self.assertRaises(volume.VolumeArtifactsNotFound, artifacts.check)
 
 def test_create_in_new_image(self):
 img_id = str(uuid.uuid4())
@@ -150,9 +151,6 @@
 def fake_env(self):
 with namedTemporaryDir() as tmpdir:
 yield make_filesd_manifest(tmpdir)
-
-def test_create_in_existing_image(self):
-pass
 
 def test_create_fail_before_meta(self):
 pass
diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py
index d4fa8f2..2850d6e 100644
--- a/vdsm/storage/blockVolume.py
+++ b/vdsm/storage/blockVolume.py
@@ -145,6 +145,18 @@
  delTags=[TAG_VOL_ARTIFACT])
 
 
+def commit(self):
+pass
+
+def clean(self):
+pass
+
+def check(self):
+lvs = lvm.lvsByTag(self.domain_manifest.sdUUID, TAG_VOL_GARBAGE)
+if self.vol_id not in lvs:
+raise volume.VolumeArtifactsNotFound()
+
+
 class BlockVolumeMetadata(volume.VolumeMetadata):
 
 def __init__(self, repoPath, sdUUID, imgUUID, volUUID):
diff --git a/vdsm/storage/fileVolume.py b/vdsm/storage/fileVolume.py
index 1936565..b6f8db5 100644
--- a/vdsm/storage/fileVolume.py
+++ b/vdsm/storage/fileVolume.py
@@ -128,6 +128,22 @@
 self._oop.os.rename(self._get_artifacts_path(),
 self._existing_image_path())
 
+def clean(self):
+vol_path = os.path.join(self._get_artifacts_path(), self.vol_id)
+lease_path = vol_path + LEASE_FILEEXT
+meta_path = self._meta_file_create_path()
+# The order we remove artifacts is important.  In order for garbage
+# collection to work, meta_path must be the first thing created and the
+# last thing removed.
+for f in (vol_path, lease_path, meta_path):
+if self._oop.os.path.lexists(f):
+self.log.debug("Removing: %s", f)
+self._oop.os.unlink(f)
+
+def check(self):
+if not self._oop.os.path.exists(self._meta_file_create_path()):
+raise volume.VolumeArtifactsNotFound()
+
 def _get_artifacts_path(self):
 if self._artifacts_path:
 return self._artifacts_path
diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py
index e49180a..1bb32d6 100644
--- a/vdsm/storage/volume.py
+++ b/vdsm/storage/volume.py
@@ -214,6 +214,16 @@
 return apparentSize
 return req_size
 
+def clean(self):
+raise NotImplementedError()
+
+def check(self):
+raise NotImplementedError()
+
+@staticmethod
+def dismantle_volume(vol_md):
+raise NotImplementedError()
+
 
 class VolumeMetadata(object):
 log = logging.getLogger('Storage.VolumeMetadata')


-- 
To view, visit https://gerrit.ovirt.org/49549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica3ddbd2bb3da5b699d8abb8977daef834bf6f29
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: blockVolume: Introduce LV tag to ID block volume artifacts

[automation]

gerrit-hooks has posted comments on this change.

Change subject: blockVolume: Introduce LV tag to ID block volume artifacts
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I193699db2c462f11331bb91069a6fd3a5a1412b2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileVolume: define file extension for volume artifacts metadata

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: fileVolume: define file extension for volume artifacts metadata
..

fileVolume: define file extension for volume artifacts metadata

Change-Id: Id14e79d400d6936c8bb0da5dec39e3f9fb60c803
Signed-off-by: Adam Litke 
---
M vdsm/storage/fileVolume.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/49544/1

diff --git a/vdsm/storage/fileVolume.py b/vdsm/storage/fileVolume.py
index 50df797..bcc7a3a 100644
--- a/vdsm/storage/fileVolume.py
+++ b/vdsm/storage/fileVolume.py
@@ -37,6 +37,7 @@
 from threadLocal import vars
 
 META_FILEEXT = ".meta"
+ARTIFACT_FILEEXT = ".artifact"
 LEASE_FILEEXT = ".lease"
 LEASE_FILEOFFSET = 0
 


-- 
To view, visit https://gerrit.ovirt.org/49544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id14e79d400d6936c8bb0da5dec39e3f9fb60c803
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: blockVolume: Introduce LV tag to ID block volume artifacts

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: blockVolume: Introduce LV tag to ID block volume artifacts
..

blockVolume: Introduce LV tag to ID block volume artifacts

Change-Id: I193699db2c462f11331bb91069a6fd3a5a1412b2
Signed-off-by: Adam Litke 
---
M vdsm/storage/blockVolume.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/49543/1

diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py
index 71f67d4..c35cc6b 100644
--- a/vdsm/storage/blockVolume.py
+++ b/vdsm/storage/blockVolume.py
@@ -47,6 +47,7 @@
 TAG_PREFIX_IMAGE = "IU_"
 TAG_PREFIX_PARENT = "PU_"
 TAG_VOL_UNINIT = "OVIRT_VOL_INITIALIZING"
+TAG_VOL_ARTIFACT = "OVIRT_VOL_ARTIFACT"
 VOLUME_TAGS = [TAG_PREFIX_PARENT,
TAG_PREFIX_IMAGE,
TAG_PREFIX_MD,


-- 
To view, visit https://gerrit.ovirt.org/49543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I193699db2c462f11331bb91069a6fd3a5a1412b2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding python3 run for nosetests

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding python3 run for nosetests
..


Patch Set 16: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/48051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83355cce2af9125e6f017017905056956cd17081
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding python3 run for nosetests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adding python3 run for nosetests
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83355cce2af9125e6f017017905056956cd17081
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vm: Update time on VM after resume

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
..


Patch Set 4:

ping

-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: unit test for vm._waitForDriveRemoval
..


Patch Set 11: Code-Review+2

still looks good after big rebase

-- 
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1f86e17132a7099f109a5e33407c56dde40df2
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: unit test for vm._waitForDriveRemoval
..


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/48880/11/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2714: self.log.debug("Waiting for hotunplug to finish")
Line 2715: with utils.stopwatch("Hotunplug disk %s" % drive.name):
Line 2716: deadline = (utils.monotonic_time() +
Line 2717: config.getfloat('vars', 'hotunplug_timeout'))
Line 2718: sleep_time = config.getfloat('vars', 
'hotunplug_check_interval')
> not sure this should be float, but could be fixed later.
It must be for the tests, unless we monkeypatch the utils.monotonic_time() and 
time.sleep() during the tests.
Line 2719: while self._isDriveAttached(drive):
Line 2720: time.sleep(sleep_time)
Line 2721: if utils.monotonic_time() > deadline:
Line 2722: raise HotunplugTimeout("Timeout detaching drive 
%s"


-- 
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1f86e17132a7099f109a5e33407c56dde40df2
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Do not release host id during shutdown

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitor: Do not release host id during shutdown
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/49386/2//COMMIT_MSG
Commit Message:

Line 19: Now we detect when a monitor is stopped during a vdsm shutdown, and do
Line 20: not release the host id.
Line 21: 
Line 22: This change will effect users trying upgrade vdsm without putting a 
host
Line 23: to maintenance before the upgrade. This was never supported but users
> it was never recommended, but it may well have been in use. When a new vdsm
It may cause a reboot - sanlock refuse to stop because there are active
lockspaces, systemd will kill sanlock, and after 60-120 seconds the watchdog 
will reboot the machine.

Upgrading vdsm without putting the host to maintenance is forbidden. We do not 
support this.
Line 24: could get away with this by stopping vdsm. Now sanlock will refuse to
Line 25: stop after vdsm is stopped, and killing sanlock will cause the watchdog
Line 26: to reboot the machine.
Line 27: 


-- 
To view, visit https://gerrit.ovirt.org/49386
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib14fa48abf9c98fdce268c4675d71aab05c92b10
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding python3 run for nosetests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adding python3 run for nosetests
..


Patch Set 17:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83355cce2af9125e6f017017905056956cd17081
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[fromani]

Francesco Romani has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 1: Code-Review-1

(1 comment)

I'm  totally fine with the concept, not sure how this patch achieves that.

https://gerrit.ovirt.org/#/c/49507/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 172: for disk in params['disks']:
Line 173: _add_disk_info(conn, disk)
Line 174: vms.append(params)
Line 175: except InvalidVMConfiguration as e:
Line 176: logging.error('error parsing domain: %s', e)
which function/method can raise InvalidVMConfiguration?
I mean: _add_general_info could, and indeed we have try/except guard. What 
besides that?
Line 177: return {'status': doneCode, 'vmList': vms}
Line 178: 
Line 179: 
Line 180: def convert_external_vm(uri, username, password, vminfo, job_id, irs):


-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: check operation result for vm nic hotunplug
..


Patch Set 19: Code-Review+2

even better, thanks

-- 
To view, visit https://gerrit.ovirt.org/48473
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: move device attached check to device itself

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: move device attached check to device itself
..


Patch Set 14: Code-Review+2

please see my comment in 48473

-- 
To view, visit https://gerrit.ovirt.org/48881
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4df478798bc774c1134ca36879abd809ea2b6380
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding python3 run for nosetests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adding python3 run for nosetests
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83355cce2af9125e6f017017905056956cd17081
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: check operation result for vm nic hotunplug
..


Patch Set 19: Code-Review-1

too quick. I'm still happy with this patch per se, but I want to avoid 
attributes missing from the base class.
Marcin, please let's do one final step:
- post a simple patch adding xpath property to base class (devices.Core), doing 
the right thing (e.g. raise NotImplementedError like is_attached_to in the next 
patch)
- reshuffle this series to have this patch depend on the new one added

This way you can leave this patch unchanged, no score is lost and code is more 
consistent and less surprising.

-- 
To view, visit https://gerrit.ovirt.org/48473
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: unit test for vm._waitForDriveRemoval
..


Patch Set 11:

(1 comment)

added one inside comment, but can be fixed by a later patch

https://gerrit.ovirt.org/#/c/48880/11/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2714: self.log.debug("Waiting for hotunplug to finish")
Line 2715: with utils.stopwatch("Hotunplug disk %s" % drive.name):
Line 2716: deadline = (utils.monotonic_time() +
Line 2717: config.getfloat('vars', 'hotunplug_timeout'))
Line 2718: sleep_time = config.getfloat('vars', 
'hotunplug_check_interval')
not sure this should be float, but could be fixed later.
Line 2719: while self._isDriveAttached(drive):
Line 2720: time.sleep(sleep_time)
Line 2721: if utils.monotonic_time() > deadline:
Line 2722: raise HotunplugTimeout("Timeout detaching drive 
%s"


-- 
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1f86e17132a7099f109a5e33407c56dde40df2
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Do not release host id during shutdown

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitor: Do not release host id during shutdown
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/49386/2//COMMIT_MSG
Commit Message:

Line 19: Now we detect when a monitor is stopped during a vdsm shutdown, and do
Line 20: not release the host id.
Line 21: 
Line 22: This change will effect users trying upgrade vdsm without putting a 
host
Line 23: to maintenance before the upgrade. This was never supported but users
> It may cause a reboot - sanlock refuse to stop because there are active
And it also possible today:
- You stop vdsm, but it get stuck during shutdown, and systemd kills it after 
10 seconds, before it released the spm resource or all the lockspaces.
- You kill vdsm to upgrade it
Line 24: could get away with this by stopping vdsm. Now sanlock will refuse to
Line 25: stop after vdsm is stopped, and killing sanlock will cause the watchdog
Line 26: to reboot the machine.
Line 27: 


-- 
To view, visit https://gerrit.ovirt.org/49386
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib14fa48abf9c98fdce268c4675d71aab05c92b10
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: modprobe validation handle failure

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: tests: modprobe validation handle failure
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I276cc2cf2205323648364c62b9db8f40e14cc983
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: move device attached check to device itself

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: vm: move device attached check to device itself
..


Patch Set 14: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/48881
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4df478798bc774c1134ca36879abd809ea2b6380
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move refreshVolume

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: VolumeMetadata: move refreshVolume
..


Patch Set 21: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/42003/21/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:

Line 328: def refreshVolume(self):
: lvm.refreshLVs(self.sdUUID, (self.volUUID,))
Don't we need to remove it since it moved to md ?


-- 
To view, visit https://gerrit.ovirt.org/42003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5041428d8d2e73edc1aa1362fcea8801e5b9116
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: externalVMList Xen+Kvm support
..


Patch Set 13:

(1 comment)

https://gerrit.ovirt.org/#/c/48672/13//COMMIT_MSG
Commit Message:

Line 11: We want to use one verb to probe VMs information from Xen, KVM and
Line 12: vCenter, as well as old libvirt versions.
Line 13: Tested with RHEL 5.x and above.
Line 14: 
Line 15: Currently we externalVMList tested only with vCenter:
> ... we tested externalVMList ...
Done
Line 16: vpx://...
Line 17: 
Line 18: Adding support for Kvm via libvirt:
Line 19: qemu+tcp://user@host/system


-- 
To view, visit https://gerrit.ovirt.org/48672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net func tests: ip config drop on bond slaves

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net func tests: ip config drop on bond slaves
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17e848d86ab5423ac885f1d3db81d1e72c7a2dbe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: metadata write utils

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: VolumeMetadata: metadata write utils
..


Patch Set 21: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/41847
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia245c589ea6bc2cf9ac1b2b59b9073d1b5fc9595
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net func tests: ip config drop on bond slaves

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net func tests: ip config drop on bond slaves
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/49539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17e848d86ab5423ac885f1d3db81d1e72c7a2dbe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: init: wait for ipv4 with monitoring

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: init: wait for ipv4 with monitoring
..


Patch Set 9:

(2 comments)

https://gerrit.ovirt.org/#/c/46148/9/init/wait_for_ipv4s
File init/wait_for_ipv4s:

Line 39: devs
consider renaming this parameter and its usage to ifcfgs or devs_ifcfgs (or a 
better name) as those are file names.


Line 47: label
isn't this the name of the device? if so, why not name it as such?


-- 
To view, visit https://gerrit.ovirt.org/46148
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa9d53f8f436b5c5f11643ae03bdd768d555b83d
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Move getImageVolumes

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: VolumeMetadata: Move getImageVolumes
..


Patch Set 10: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/44043
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e99008b0df26a0bd2f714ac060ceee437e0060e
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: externalVMList Xen+Kvm support
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 1:

(1 comment)

> (1 comment)
 > 
 > I'm  totally fine with the concept, not sure how this patch
 > achieves that.
_add_vm is a part of a loop that collect VMs from external provider,
if there is unexpected error in one of the VMs we still able to return the VMs 
that we can import to the user for review.

https://gerrit.ovirt.org/#/c/49507/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 172: for disk in params['disks']:
Line 173: _add_disk_info(conn, disk)
Line 174: vms.append(params)
Line 175: except InvalidVMConfiguration as e:
Line 176: logging.error('error parsing domain: %s', e)
> which function/method can raise InvalidVMConfiguration?
XMLDec is one,
and we encounter in state (ie status).
We don't know if we will encounter more methods in the future and we don't want 
to fail the verb for one bad vm
Line 177: return {'status': doneCode, 'vmList': vms}
Line 178: 
Line 179: 
Line 180: def convert_external_vm(uri, username, password, vminfo, job_id, irs):


-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: move tc library under lib/vdsm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: move tc library under lib/vdsm
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49238
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb4f8499b8ebaaf927aa2df36b4107bd943fc69c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: split netinfo module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: split netinfo module
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49198
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I297b55f68f69c4ba0f1c854bcadddc087a2e9089
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: move network library under lib/vdsm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: move network library under lib/vdsm
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49239
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4ce5c149e8bb9a8296bf121b9961fb209cfd71c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: move tc library under lib/vdsm

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: move tc library under lib/vdsm
..


Patch Set 6:

(3 comments)

https://gerrit.ovirt.org/#/c/49238/6//COMMIT_MSG
Commit Message:

Line 10: logic changed
> change to logic?
Done


Line 10: aplphabetical
> alphabetical
Done


https://gerrit.ovirt.org/#/c/49238/6/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 47: api, errors, sourceroute
> One line per module import.
Done


-- 
To view, visit https://gerrit.ovirt.org/49238
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb4f8499b8ebaaf927aa2df36b4107bd943fc69c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Mapping bonding option value names to numerics

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Mapping bonding option value names to numerics
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f4c16b1523822a2d53d4525841ff8741af6296c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Do not release host id during shutdown

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitor: Do not release host id during shutdown
..


Patch Set 3:

* #1269768::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1269768::OK, public bug
* Check Product::#1269768::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49386
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib14fa48abf9c98fdce268c4675d71aab05c92b10
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: Prevent stop monitoring of a pool domain

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hsm: Prevent stop monitoring of a pool domain
..


Patch Set 4:

* #1282187::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1282187::OK, public bug
* Check Product::#1282187::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99555b230dfdab41384af0461e4b30c590b669b9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sp: Allow attaching of monitored domain

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sp: Allow attaching of monitored domain
..


Patch Set 4:

* #1269768::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1269768::OK, public bug
* Check Product::#1269768::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move newVolumeLease

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: VolumeMetadata: move newVolumeLease
..


Patch Set 21: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/42002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If18aa7d526d9eb334c638fdf4cc93d31a4943cb6
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sp: Allow attaching of monitored domain

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sp: Allow attaching of monitored domain
..


Patch Set 4:

This version cleans up the magic attaching code, using early returns to make 
the intent more clear. No behavior change.

-- 
To view, visit https://gerrit.ovirt.org/48217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: always return bond mode in Host.getCapabilities

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: always return bond mode in Host.getCapabilities
..


Patch Set 1:

* #1276445::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1276445::OK, public bug
* Check Product::#1276445::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49550
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I697af1c895db5ece99b3f940242b77f623caa8b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: always return bond mode in Host.getCapabilities

[mmirecki]

Marcin Mirecki has uploaded a new change for review.

Change subject: vm: always return bond mode in Host.getCapabilities
..

vm: always return bond mode in Host.getCapabilities

The 'mode' attribute in bonding options should always be returned in
Host.getCapabilities.

Change-Id: I697af1c895db5ece99b3f940242b77f623caa8b9
Bug-Url: https://bugzilla.redhat.com/1276445
Signed-off-by: Marcin Mirecki 
---
M lib/vdsm/netinfo.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/49550/1

diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index f3c9c0c..a30ac97 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -446,6 +446,7 @@
 opts = bondOpts(bond)
 mode = opts['mode'][-1] if 'mode' in opts else None
 defaults = getDefaultBondingOptions(mode)
+defaults.pop('mode', None)
 
 return dict(((opt, val[-1]) for (opt, val) in opts.iteritems()
  if val and val != defaults.get(opt)))


-- 
To view, visit https://gerrit.ovirt.org/49550
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I697af1c895db5ece99b3f940242b77f623caa8b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: snapshot - enabling memory snapshot for diskless VM

[derez]

Daniel Erez has posted comments on this change.

Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..


Patch Set 1:

That's not exactly correct - previewing a memory snapshot without disks 
prevents running the VM. That's worse than merely 'did nothing'. Running the VM 
would fail with an ugly exception in vdsm.

@Michal/Arik - shouldn't we support previewing a memory snapshot without disks?

-- 
To view, visit https://gerrit.ovirt.org/49535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: snapshot - enabling memory snapshot for diskless VM

[derez]

Daniel Erez has uploaded a new change for review.

Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..

vm: snapshot - enabling memory snapshot for diskless VM

Taking a memory snapshot of a VM without disks should be
supported (or merely with Cinder/LUN disks for that matter).

Hence, removing the early return on 'VM -> snapshot'
in case 'newDrives' is empty.

Instead, proper logging will be added on consecutive patches.

Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5
Bug-Url: https://bugzilla.redhat.com/1287066
Signed-off-by: Daniel Erez 
---
M vdsm/virt/vm.py
1 file changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/49535/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 8ec8b1d..8503f64 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3134,11 +3134,6 @@
 # safely access the blockDev property until after prepareVolumePath
 vmDrives[vmDevName] = vmDrive
 
-# If all the drives are the current ones, return success
-if len(newDrives) == 0:
-self.log.debug('all the drives are already in use, success')
-return {'status': doneCode}
-
 preparedDrives = {}
 
 for vmDevName, vmDevice in newDrives.iteritems():


-- 
To view, visit https://gerrit.ovirt.org/49535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: snapshot - enabling memory snapshot for diskless VM

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..


Patch Set 1:

* #1287066::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1287066::OK, public bug
* Check Product::#1287066::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Mapping bonding option value names to numerics

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Mapping bonding option value names to numerics
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f4c16b1523822a2d53d4525841ff8741af6296c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Require newer qemu version for el7

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: spec: Require newer qemu version for el7
..


spec: Require newer qemu version for el7

Prior to QEMU 2.3.0-13, it cannot yield while dumping a dirty map, which
may cause live merge to hang when merging large snapshots. QEMU 2.3.0-13
adds yield points, which prevents the aforementioned hanging.

We don't require the package on CentOS, since it is not available yet.

Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d
Bug-Url: https://bugzilla.redhat.com/1271173
Signed-off-by: Fred Rolland 
Reviewed-on: https://gerrit.ovirt.org/49009
Continuous-Integration: Jenkins CI
Reviewed-by: Allon Mureinik 
Reviewed-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/49205
Continuous-Integration: Francesco Romani 
Reviewed-by: Francesco Romani 
---
M vdsm.spec.in
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Allon Mureinik: Looks good to me, but someone else must approve
  Francesco Romani: Looks good to me, approved; Passed CI tests
  Freddy Rolland: Verified



-- 
To view, visit https://gerrit.ovirt.org/49205
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require ioprocess containing important fixes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require ioprocess containing important fixes
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49175
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d2ef42de1135df0c6265fa3eaf69a2682b98ed5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Require newer qemu version for el7

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 4:

* #1271173::Update tracker: OK
* Set MODIFIED::bug 1271173#1271173OK

-- 
To view, visit https://gerrit.ovirt.org/49205
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm.conf: Add drop-in dir

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm.conf: Add drop-in dir
..


Patch Set 4:

* #1279555::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279555::OK, public bug
* Check Product::#1279555::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48317
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I707a1865e8d60dc4dcdc0e681b52c07c75f1c409
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm.conf: Add drop-in dir

[fabiand]

Fabian Deutsch has posted comments on this change.

Change subject: vdsm.conf: Add drop-in dir
..


Patch Set 4:

Ping?

-- 
To view, visit https://gerrit.ovirt.org/48317
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I707a1865e8d60dc4dcdc0e681b52c07c75f1c409
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: clientIF: add logs during the recovery

[fromani]

Francesco Romani has posted comments on this change.

Change subject: clientIF: add logs during the recovery
..


Patch Set 4: -Code-Review Verified-1

temporary V-1 to avoid premature merges (before 3.6.1 released)

-- 
To view, visit https://gerrit.ovirt.org/49140
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31dddf0a2bc760c5ad383ff6bfee9a72adc87c4f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: PoC: enforcement of contract for notifications

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: PoC: enforcement of contract for notifications
..


Patch Set 1:

(4 comments)

https://gerrit.ovirt.org/#/c/49442/1/lib/api/notify-schema.yaml
File lib/api/notify-schema.yaml:

Line 37:type: string
Line 38:1.4:
Line 39:param:
Line 40:name: vm-id
Line 41:operation: removed
we should have the ability to specify the complete deprecation of an event.


https://gerrit.ovirt.org/#/c/49442/1/lib/api/notifyapi.py
File lib/api/notifyapi.py:

Line 1: 2014
2015


https://gerrit.ovirt.org/#/c/49442/1/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:

Line 67: DESTINATION = "destination"
Line 68: ACCEPT_VERSION = "accept-version"
Line 69: REPLY_TO = "reply-to"
Line 70: HEARTEBEAT = "heart-beat"
Line 71: CLIENT_VERSION = "client-version"
make sure stomp is happy with adding this header
Line 72: 
Line 73: 
Line 74: COMMANDS = tuple([command for command in dir(Command)
Line 75:   if not command.startswith('_')])


https://gerrit.ovirt.org/#/c/49442/1/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 127: default-version"
I suggest to call it "3.6" so it fits the versioning scheme better.


-- 
To view, visit https://gerrit.ovirt.org/49442
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c21a904b6dfa6c818ec7cd438f2520bf1f22fc8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: automation: support fc23

[automation]

gerrit-hooks has posted comments on this change.

Change subject: automation: support fc23
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/49503
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ee5f6af9e54367961326140aee95fa005e2296c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: automation: support fc23

[fromani]

Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/49503

to review the following change.

Change subject: automation: support fc23
..

automation: support fc23

Change-Id: I9ee5f6af9e54367961326140aee95fa005e2296c
Signed-off-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/48479
Continuous-Integration: Jenkins CI
---
A automation/build-artifacts.repos.fc23
A automation/check-patch.repos.fc23
2 files changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/49503/1

diff --git a/automation/build-artifacts.repos.fc23 
b/automation/build-artifacts.repos.fc23
new file mode 100644
index 000..f437bf1
--- /dev/null
+++ b/automation/build-artifacts.repos.fc23
@@ -0,0 +1,2 @@
+ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro
+ovirt-glusterfs-fedora,http://download.gluster.org/pub/gluster/glusterfs/LATEST/Fedora/fedora-23/x86_64
diff --git a/automation/check-patch.repos.fc23 
b/automation/check-patch.repos.fc23
new file mode 100644
index 000..c2b17a2
--- /dev/null
+++ b/automation/check-patch.repos.fc23
@@ -0,0 +1,3 @@
+ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro
+ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro
+ovirt-glusterfs-fedora,http://download.gluster.org/pub/gluster/glusterfs/LATEST/Fedora/fedora-23/x86_64


-- 
To view, visit https://gerrit.ovirt.org/49503
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ee5f6af9e54367961326140aee95fa005e2296c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix brick devices are created with incorrect data a...

[mpillai]

Manoj Pillai has posted comments on this change.

Change subject: gluster: fix brick devices are created with incorrect data 
alignment
..


Patch Set 2: -Code-Review

(3 comments)

https://gerrit.ovirt.org/#/c/47959/2/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 59: DEFAULT_METADATA_SIZE_KB = 16777216
Line 60: MIN_VG_SIZE = 1048576
Line 61: MIN_METADATA_PERCENT = 0.005
Line 62: DEFAULT_FS_TYPE = "xfs"
Line 63: DEFAULT_MOUNT_OPTIONS = "inode64,noatime"
> Does this params are really necessary during mount or can i just omit this?
inode64 is pretty important. I think it is the default in RHEL-7, but not in 
RHEL-6; but not sure, will have to check.
Line 64: 
Line 65: 
Line 66: def _getDeviceDict(device, createBrick=False):
Line 67: info = {'name': device.name,


Line 240: if inUseList:
Line 241: raise ge.GlusterHostStorageDeviceInUseException(inUseList)
Line 242: 
Line 243: pvDeviceList = _createPV(deviceList, alignment)
Line 244: vg = _createVG(vgName, pvDeviceList, peSize)
> In the older document its mentioned to use the peSize directly whereas in t
Yes, you can follow the latest docs.
Recent enhancements in LVM have enabled us to simplify the brick creation 
steps. Earlier we specified su_sz as peSize, but had to manually adjust 
metadata and data device sizes to align with RAID geometry. Now, we can specify 
peSize as su_sz*num_data_disks and volumes created will be aligned. For more 
info see:
https://bugzilla.redhat.com/show_bug.cgi?id=1230639
Line 245: # The following calculation is based on the redhat storage 
performance doc
Line 246: # http://docbuilder.usersys.redhat.com/22522
Line 247: # /#chap-Configuring_Red_Hat_Storage_for_Enhancing_Performance
Line 248: 


Line 261: # Create data LV (poolDataSize) that has a size which is
Line 262: # a multiple of stripe width
Line 263: # For JBOD, this adjustment is not necessary
Line 264: if raidType:
Line 265: metaDataSize = (metaDataSize - (metaDataSize % alignment))
> In the older doc mentioned to align both metadatasize and pooldatasize. whe
If peSize is correctly specified as su_sz*num_data_disks during vgcreate, this 
step is not necessary. neither is the adjustment for poolDataSize.
Line 266: poolDataSize = (poolDataSize - (poolDataSize % alignment))
Line 267: 
Line 268: # Creating a thin pool from the data LV and the metadata LV
Line 269: # lvconvert --chunksize alignment --thinpool VOLGROUP/thin_pool


-- 
To view, visit https://gerrit.ovirt.org/47959
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Require newer qemu version for el7

[fromani]

Francesco Romani has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49205
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: vm: Remove empty RNG devices left after 3.5->3.6 upgrade

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: Remove empty RNG devices left after 3.5->3.6 upgrade
..


Patch Set 2: Continuous-Integration+1

run CI checks manually

-- 
To view, visit https://gerrit.ovirt.org/49087
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2580dcb335970a4bb5c4c87fe6ea9fcd8e494df5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require ioprocess containing important fixes

[ykaplan]

Yeela Kaplan has posted comments on this change.

Change subject: spec: Require ioprocess containing important fixes
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/49175
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d2ef42de1135df0c6265fa3eaf69a2682b98ed5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: vm: Remove empty RNG devices left after 3.5->3.6 upgrade

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: Remove empty RNG devices left after 3.5->3.6 upgrade
..


Patch Set 2: Code-Review+1

temporary reducing score to avoid premature merges (before 3.6.1 released)

-- 
To view, visit https://gerrit.ovirt.org/49087
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2580dcb335970a4bb5c4c87fe6ea9fcd8e494df5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require ioprocess containing important fixes

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: spec: Require ioprocess containing important fixes
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49175
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d2ef42de1135df0c6265fa3eaf69a2682b98ed5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: externalVMList Xen+Kvm support
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches