Shahar Havivi has posted comments on this change.
Change subject: schema: introduce HostJobInfo type
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/49450/2/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 26: _lock = th
Dan Kenigsberg has posted comments on this change.
Change subject: net: support hot(un)plugNic for SRIOV network devices.
..
Patch Set 3: Continuous-Integration+1
07:42:47 ERROR: Tests mkimage.mkFloppyFs creating an image and c
Shahar Havivi has posted comments on this change.
Change subject: schema: introduce HostJobInfo type
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49450
To unsubscribe, visit https://gerrit.ovirt.org
Francesco Romani has posted comments on this change.
Change subject: schema: introduce HostJobInfo type
..
Patch Set 2:
(6 comments)
overall seems OK, suggested possible improvements, a few minor questions inside
https://gerr
Ido Barkan has posted comments on this change.
Change subject: net: support hot(un)plugNic for SRIOV network devices.
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/50372/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: net: support hot(un)plugNic for SRIOV network devices.
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
Ido Barkan has posted comments on this change.
Change subject: config: Resolve crash when IPv6 disabled in kernel
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50457
To unsubscribe, visit https://ger
gerrit-hooks has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: v2v: refactor get_external_vms
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
Ondřej Svoboda has posted comments on this change.
Change subject: config: Resolve crash when IPv6 disabled in kernel
..
Patch Set 1: Verified+1
Tested just like the patch from master:
Booted up with ipv6.disabled=1 and succee
gerrit-hooks has posted comments on this change.
Change subject: API: Add api for getting host jobs info
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: schema: introduce HostJobInfo type
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
gerrit-hooks has posted comments on this change.
Change subject: v2v: Add tests for get_ova_info
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://g
Nir Soffer has submitted this change and it was merged.
Change subject: v2v: Add tests for get_ova_info
..
v2v: Add tests for get_ova_info
Change-Id: Id73516164e81e609c70caeac20fb819eaf04a56b
Signed-off-by: Shahar Havivi
Revie
Francesco Romani has posted comments on this change.
Change subject: v2v: Add tests for get_ova_info
..
Patch Set 7: Code-Review+2
nice
--
To view, visit https://gerrit.ovirt.org/50158
To unsubscribe, visit https://gerrit.ovi
Nir Soffer has posted comments on this change.
Change subject: jobs: By default jobs do not support abort
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/49449
To unsubscribe, visit https://gerrit.ovirt.o
Nir Soffer has submitted this change and it was merged.
Change subject: jobs: By default jobs do not support abort
..
jobs: By default jobs do not support abort
Change-Id: I9084a32a99e8252b1526d86aae7994c2bebc7a96
Signed-off-by
gerrit-hooks has posted comments on this change.
Change subject: jobs: By default jobs do not support abort
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visi
Nir Soffer has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 2: Code-Review-1
I agree with Francesco, we just merged https://gerrit.ovirt.org/49974,
promising that:
Nir Soffer has posted comments on this change.
Change subject: v2v: Add tests for get_ova_info
..
Patch Set 7:
Waiting for Francesco.
--
To view, visit https://gerrit.ovirt.org/50158
To unsubscribe, visit https://gerrit.ovirt
Nir Soffer has posted comments on this change.
Change subject: v2v: Add tests for get_ova_info
..
Patch Set 7: Verified+1
New tests pass in the CI.
--
To view, visit https://gerrit.ovirt.org/50158
To unsubscribe, visit https:
Nir Soffer has posted comments on this change.
Change subject: v2v: Add tests for get_ova_info
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50158
To unsubscribe, visit https://gerrit.ovirt.org/setti
Daniel Erez has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 2:
@Allon - do we need the separation between RHEL and CentOS when bumping qemu
version?
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 3:
* #1287620::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1287620::OK, public bug
* Check P
Francesco Romani has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 2: Code-Review-1
in 3.5 we need to support RHEL/CentOS 6.x, so libvirt 0.10.2.x
virDomainSetTime was add
Francesco Romani has posted comments on this change.
Change subject: lib: executor: report worker status in __repr__
..
Patch Set 5: Code-Review-1
(1 comment)
near, but still not there.
https://gerrit.ovirt.org/#/c/49722/5/li
Nir Soffer has posted comments on this change.
Change subject: v2v: extract specific classes for libvirt and ova
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/49951/4/vdsm/v2v.py
File vdsm/v2v.py:
Line 309:
Nir Soffer has submitted this change and it was merged.
Change subject: VolumeMetadata: move getVolumeSize and getVolumeTrueSize
..
VolumeMetadata: move getVolumeSize and getVolumeTrueSize
Change-Id: Ie122d4c96ad81d31c0e783e865
Nir Soffer has submitted this change and it was merged.
Change subject: VolumeMetadata: Move getInfo and getVolumeParams
..
VolumeMetadata: Move getInfo and getVolumeParams
Change-Id: I80c1fa58d64efbb3cbc7eea84189fc8375b6fa3d
S
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move getInfo and getVolumeParams
..
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vie
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: move getVolumeSize and getVolumeTrueSize
..
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
Nir Soffer has posted comments on this change.
Change subject: lib: executor: report worker status in __repr__
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/49722/5/lib/vdsm/executor.py
File lib/vdsm/executor.py:
L
Francesco Romani has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 2:
Jenkins failures are bogus. Let's try again.
--
To view, visit https://gerrit.ovirt.org/50456
To un
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/50456/1//COMMIT_MSG
Commit Message:
Line 35: with libvirt de
gerrit-hooks has posted comments on this change.
Change subject: config: Resolve crash when IPv6 disabled in kernel
..
Patch Set 1:
* #1277204::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1277204::OK, public bug
Hello Ido Barkan, Ollie Armstrong, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50457
to review the following change.
Change subject: config: Resolve crash when IPv6 disabled in kernel
..
Alona Kaplan has posted comments on this change.
Change subject: net: support hot(un)plugNic for SRIOV network devices.
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/50372/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Li
Francesco Romani has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 1:
...and I added my comments BEFORE to read Milan's notes. :\
--
To view, visit https://gerrit.ovirt.
gerrit-hooks has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 2:
* #1287620::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1287620::OK, public bug
* Check P
Francesco Romani has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/50456/1//COMMIT_MSG
Commit Message:
Line 35: with libvirt
Alona Kaplan has posted comments on this change.
Change subject: net: support hot(un)plugNic for SRIOV network devices.
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/50372/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Li
gerrit-hooks has posted comments on this change.
Change subject: [WIP] vdsm standard CI arrangement
..
Patch Set 28:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 1:
Compared to 3.6:
- virdomain.NotConnectedError handling removed (not present in 3.5).
- Success test re
Milan Zamazal has uploaded a new change for review.
Change subject: virt: vm: Update time on VM after resume
..
virt: vm: Update time on VM after resume
When a VM is resumed from suspension and/or migrated, its clock
continues f
gerrit-hooks has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 1:
* #1287620::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1287620::OK, public bug
* Check P
Francesco Romani has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 2: Code-Review-1
+1 for the concept
-1 for the implementation because as Allon pointed out in
d60db7103
gerrit-hooks has posted comments on this change.
Change subject: fileVolume: refactor _putMetadata to support volume artifacts
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found
gerrit-hooks has posted comments on this change.
Change subject: storagefakelib: Add FakeResourceManager
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Francesco Romani has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.
gerrit-hooks has posted comments on this change.
Change subject: v2v: Add tests for get_ova_info
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
gerrit-hooks has posted comments on this change.
Change subject: XXX: Add _getDeletedImagePath until patch merged
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: jobs: Only report progress if set
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
gerrit-hooks has posted comments on this change.
Change subject: XXX: All outstanding VolumeMetadata changes squashed
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Daniel Erez has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.or
gerrit-hooks has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: sdm: Add create_volume job
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: sdm: add create_volume_container API stub
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: storage: add get_volume_artifacts_class to the domain manifest
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: fileVolume: define file extension for volume artifacts metadata
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found
Jenkins CI has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 2: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 1
--
To
Shahar Havivi has posted comments on this change.
Change subject: v2v: extract specific classes for libvirt and ova
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/49951/4/vdsm/v2v.py
File vdsm/v2v.py:
Line 303:
gerrit-hooks has posted comments on this change.
Change subject: image: Make progress report interval configurable
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vie
Dan Kenigsberg has submitted this change and it was merged.
Change subject: image: Make progress report interval configurable
..
image: Make progress report interval configurable
Previously we logged a progress report every 60
gerrit-hooks has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 2:
* #1279052::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279052::OK, public bug
* Check P
Shahar Havivi has posted comments on this change.
Change subject: v2v: extract specific classes for libvirt and ova
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/49951/4/tests/v2vTests.py
File tests/v2vTests.py:
L
gerrit-hooks has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 1:
* #1279052::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279052::OK, public bug
* Check P
Daniel Erez has uploaded a new change for review.
Change subject: spec: Require newer qemu version for el7
..
spec: Require newer qemu version for el7
Bumping qemu version to 2.3.0-31.el7_2.4 in order to avoid
a potential assert
David Caro has posted comments on this change.
Change subject: [WIP] vdsm standard CI arrangement
..
Patch Set 25:
(2 comments)
https://gerrit.ovirt.org/#/c/48268/25/automation/check-merged.sh
File automation/check-merged.sh:
Adam Litke has posted comments on this change.
Change subject: jobs: Add error property
..
Patch Set 2: Verified+1
(1 comment)
Verified with unit tests.
https://gerrit.ovirt.org/#/c/50354/2/lib/vdsm/jobs.py
File lib/vdsm/jobs
Adam Litke has posted comments on this change.
Change subject: schema: introduce HostJobs basic types
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/49450/1/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.js
Adam Litke has posted comments on this change.
Change subject: jobs: Only report progress if set
..
Patch Set 2:
(7 comments)
https://gerrit.ovirt.org/#/c/50355/2//COMMIT_MSG
Commit Message:
Line 9: Not all Jobs have determin
Adam Litke has posted comments on this change.
Change subject: schema: introduce HostJobs basic types
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/49450/1/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.jso
gerrit-hooks has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 2:
* #1156194::Update tracker: OK
* Set MODIFIED::bug 1156194#1156194IGNORE, not oVirt classificatio
Francesco Romani has submitted this change and it was merged.
Change subject: virt: vm: Update time on VM after resume
..
virt: vm: Update time on VM after resume
When a VM is resumed from suspension and/or migrated, its clock
Francesco Romani has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50426
To unsubscribe, visit https://gerrit.
Adam Litke has posted comments on this change.
Change subject: VolumeMetadata: Move getInfo and getVolumeParams
..
Patch Set 24: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41999
To unsubscribe, visit https://gerr
Michal Skrivanek has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 1: Code-Review+1
same us master
--
To view, visit https://gerrit.ovirt.org/50426
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: image: Make progress report interval configurable
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50405
To unsubscribe, visit https://gerr
Adam Litke has posted comments on this change.
Change subject: VolumeMetadata: move getVolumeSize and getVolumeTrueSize
..
Patch Set 24: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41998
To unsubscribe, visit http
Adam Litke has posted comments on this change.
Change subject: VolumeMetadata: move getVolumeSize and getVolumeTrueSize
..
Patch Set 24: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41998
To unsubscribe, visit http
gerrit-hooks has posted comments on this change.
Change subject: periodic: add __str__ methods
..
Patch Set 2:
* #1250839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, public bug
* Check Product::#12
gerrit-hooks has posted comments on this change.
Change subject: periodic: add __str__ methods
..
Patch Set 4:
* #1250839::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/49143
To unsubscribe, visit https://gerr
Francesco Romani has abandoned this change.
Change subject: periodic: add __str__ methods
..
Abandoned
figured out the "weird error", I just backported too early. Fixed now, we don't
need this anymore.
--
To view, visit http
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: run ovs _configure only if there are changes to do
..
Patch Set 3:
* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867OK
--
T
Francesco Romani has restored this change.
Change subject: periodic: add executor-compatible naming
..
Restored
--
To view, visit https://gerrit.ovirt.org/48416
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-M
Francesco Romani has submitted this change and it was merged.
Change subject: hooks: ovs: run ovs _configure only if there are changes to do
..
hooks: ovs: run ovs _configure only if there are changes to do
Change-Id: I01033314
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 1: Verified+1
Verified by suspending and resuming a VM with qemu-guest-agent running and not
running and c
gerrit-hooks has posted comments on this change.
Change subject: lib: executor: report worker status in __repr__
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 1:
* #1156194::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1156194::OK, public bug
* Check P
Francesco Romani has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 1:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/50426
To unsubscribe, visit https://ger
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: vm: Update time on VM after resume
..
virt: vm: Update time on VM after resume
When a VM is resumed from suspension and/or migrated, its clock
co
gerrit-hooks has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 11:
* #1156194::Update tracker: OK
* Set MODIFIED::bug 1156194#1156194IGNORE, not oVirt classificati
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: run ovs _configure only if there are changes to do
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK
Martin Polednik has posted comments on this change.
Change subject: caps/lib: move CPU architecture details to lib/cpuarch
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/49972/2/lib/vdsm/cpuarch.py
File lib/vdsm/cpu
Martin Polednik has posted comments on this change.
Change subject: caps/lib: move CPU architecture details to lib/cpuarch
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/49972/2/lib/vdsm/cpuarch.py
File lib/vdsm/cpu
Francesco Romani has submitted this change and it was merged.
Change subject: hooks: ovs: fix getVdsCaps and getVdsStats
..
hooks: ovs: fix getVdsCaps and getVdsStats
Testing with Engine revealed a few stats and caps hooks prob
Francesco Romani has submitted this change and it was merged.
Change subject: hooks: ovs: use six.iteritems and six.itervalues
..
hooks: ovs: use six.iteritems and six.itervalues
Change-Id: I3d098a3142f61e927e047058424d2bd6f695
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: use six.iteritems and six.itervalues
..
Patch Set 3:
* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867IGNORE, not all related
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: fix getVdsCaps and getVdsStats
..
Patch Set 3:
* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867IGNORE, not all related patch
1 - 100 of 242 matches
Mail list logo