Change in vdsm[master]: xmlrpc: retry when flushing socket

[automation]

gerrit-hooks has posted comments on this change.

Change subject: xmlrpc: retry when flushing socket
..


Patch Set 5:

* #1261255::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1261255::OK, public bug
* Check Product::#1261255::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47637
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52dd6ad304a82ff6c8d3dff12a38269684abf055
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: xmlrpc: retry when flushing socket

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: xmlrpc: retry when flushing socket
..


Patch Set 5: Verified+1

Rebase only

-- 
To view, visit https://gerrit.ovirt.org/47637
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52dd6ad304a82ff6c8d3dff12a38269684abf055
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Clean netinfo.__init__ and migrate to cache

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Clean netinfo.__init__ and migrate to cache
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/53007/3/lib/vdsm/netinfo/cache.py
File lib/vdsm/netinfo/cache.py:

Line 157: def ifaceUsed(iface):
Line 158: """Lightweight implementation of bool(Netinfo.ifaceUsers()) that 
does not
Line 159: require a NetInfo object."""
Line 160: if os.path.exists(os.path.join(netinfo.NET_PATH, iface, 
'brport')):
Line 161: return True
> please move the   # Is it a port
Done
Line 162: for linkDict in nl_link.iter_links():
Line 163: if linkDict['name'] == iface and 'master' in linkDict:  # Is 
it a slave
Line 164: return True
Line 165: if linkDict.get('device') == iface and linkDict.get('type') 
== 'vlan':


-- 
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I892bb86fe9a8580d9028ca7759d27967e55d85f7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP: DONTMERGE: better saveState

[automation]

gerrit-hooks has posted comments on this change.

Change subject: WIP: DONTMERGE: better saveState
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53042
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1c50b56ea322375236dc196a1beb6be6949abec
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP DONTMERGE: migrationLimit retry

[automation]

gerrit-hooks has posted comments on this change.

Change subject: WIP DONTMERGE: migrationLimit retry
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP: DONTMERGE: do not leave leftovers if migrationCreate fails

[automation]

gerrit-hooks has posted comments on this change.

Change subject: WIP: DONTMERGE: do not leave leftovers if migrationCreate fails
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57e12251662d2b8a7cffbaf9a28163742bb4cd4d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: IP DHCP detection

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: IP DHCP detection
..


Patch Set 2: Code-Review-1

(2 comments)

tiny comments. please have phoracek review his hook code

https://gerrit.ovirt.org/#/c/53076/2/lib/vdsm/netinfo/dhcp.py
File lib/vdsm/netinfo/dhcp.py:

Line 70: ipaddrs, dev
argument name and order: iface, ipaddr


Line 75: 'permanent' not in ipaddr['flags']
could be nicer to define

  netlink.addr.is_permanent()

(similar usage in netinfo/addresses.py to is_primary)


-- 
To view, visit https://gerrit.ovirt.org/53076
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d0396610822e3a41d44f37346ee1aad71d569d1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: move v2v module to /var/lib/

[fromani]

Francesco Romani has posted comments on this change.

Change subject: v2v: move v2v module to /var/lib/
..


Patch Set 1: Code-Review-1

(1 comment)

please correct the commit message summary!
Everything else seems OK
-1 for visibility only

https://gerrit.ovirt.org/#/c/53084/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-02-04 12:11:47 +0200
Line 4: Commit: Shahar Havivi 
Line 5: CommitDate: 2016-02-04 13:35:08 +0200
Line 6: 
Line 7: v2v: move v2v module to /var/lib/
/var/lib -> site-packages
Line 8: 
Line 9: Change-Id: I5becf47fb1f139bd246d8853f2c890aa90eb4c7a


-- 
To view, visit https://gerrit.ovirt.org/53084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5becf47fb1f139bd246d8853f2c890aa90eb4c7a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding vdsm functional tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adding vdsm functional tests
..


Patch Set 47:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c
Gerrit-PatchSet: 47
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding vdsm functional tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adding vdsm functional tests
..


Patch Set 46:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c
Gerrit-PatchSet: 46
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding vdsm functional tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adding vdsm functional tests
..


Patch Set 48:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c
Gerrit-PatchSet: 48
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: move v2v module to /var/lib/

[shavivi]

Shahar Havivi has uploaded a new change for review.

Change subject: v2v: move v2v module to /var/lib/
..

v2v: move v2v module to /var/lib/

Change-Id: I5becf47fb1f139bd246d8853f2c890aa90eb4c7a
Signed-off-by: Shahar Havivi 
---
M debian/vdsm-python.install
M lib/vdsm/Makefile.am
R lib/vdsm/v2v.py
M tests/v2vTests.py
M vdsm.spec.in
M vdsm/Makefile.am
6 files changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/53084/1

diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install
index 9650d9d..52276f4 100644
--- a/debian/vdsm-python.install
+++ b/debian/vdsm-python.install
@@ -70,5 +70,6 @@
 ./usr/lib/python2.7/dist-packages/vdsm/udevadm.py
 ./usr/lib/python2.7/dist-packages/vdsm/utils.py
 ./usr/lib/python2.7/dist-packages/vdsm/vdscli.py
+./usr/lib/python2.7/dist-packages/vdsm/v2v.py
 ./usr/lib/python2.7/dist-packages/vdsm/virtsparsify.py
 ./usr/lib/python2.7/dist-packages/vdsm/xmlrpc.py
diff --git a/lib/vdsm/Makefile.am b/lib/vdsm/Makefile.am
index a1628ab..29635ad 100644
--- a/lib/vdsm/Makefile.am
+++ b/lib/vdsm/Makefile.am
@@ -57,6 +57,7 @@
taskset.py \
udevadm.py \
utils.py \
+   v2v.py \
vdscli.py \
virtsparsify.py \
xmlrpc.py \
@@ -90,6 +91,7 @@
 
 install-data-local: \
install-data-sample-vdsm-conf
+   $(MKDIR_P) $(DESTDIR)$(vdsmrundir)/v2v
 
 uninstall-local: \
uninstall-data-sample-vdsm-conf
diff --git a/vdsm/v2v.py b/lib/vdsm/v2v.py
similarity index 100%
rename from vdsm/v2v.py
rename to lib/vdsm/v2v.py
diff --git a/tests/v2vTests.py b/tests/v2vTests.py
index b3988c9..101e31c 100644
--- a/tests/v2vTests.py
+++ b/tests/v2vTests.py
@@ -28,7 +28,7 @@
 import os
 
 from testlib import namedTemporaryDir, permutations, expandPermutations
-import v2v
+from vdsm import v2v
 from vdsm import libvirtconnection
 from vdsm.password import ProtectedPassword
 from vdsm.commands import execCmd
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 91cb235..b2d45f6 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -856,7 +856,6 @@
 %{_datadir}/%{vdsm_name}/protocoldetector.py*
 %{_datadir}/%{vdsm_name}/sitecustomize.py*
 %{_datadir}/%{vdsm_name}/supervdsmServer
-%{_datadir}/%{vdsm_name}/v2v.py*
 %{_datadir}/%{vdsm_name}/vdsm
 %{_datadir}/%{vdsm_name}/vdsm-restore-net-config
 %{_datadir}/%{vdsm_name}/vdsm-store-net-config
@@ -1158,6 +1157,7 @@
 %{python_sitelib}/%{vdsm_name}/taskset.py*
 %{python_sitelib}/%{vdsm_name}/udevadm.py*
 %{python_sitelib}/%{vdsm_name}/utils.py*
+%{python_sitelib}/%{vdsm_name}/v2v.py*
 %{python_sitelib}/%{vdsm_name}/vdscli.py*
 %{python_sitelib}/%{vdsm_name}/virtsparsify.py*
 %{python_sitelib}/%{vdsm_name}/xmlrpc.py*
diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index f9f8aac..47d21e9 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -38,7 +38,6 @@
parted_utils.py \
protocoldetector.py \
sitecustomize.py \
-   v2v.py \
$(NULL)
 
 dist_vdsmexec_SCRIPTS = \
@@ -143,7 +142,6 @@
$(MKDIR_P) $(DESTDIR)$(vdsmrundir)/sourceRoutes
$(MKDIR_P) $(DESTDIR)$(vdsmrundir)/trackedInterfaces
$(MKDIR_P) $(DESTDIR)$(vdsmrundir)/payload
-   $(MKDIR_P) $(DESTDIR)$(vdsmrundir)/v2v
$(MKDIR_P) $(DESTDIR)$(vdsmlibdir)/netconfback
$(MKDIR_P) $(DESTDIR)$(vdsmlibdir)/persistence
$(MKDIR_P) $(DESTDIR)$(vdsmlibdir)/upgrade


-- 
To view, visit https://gerrit.ovirt.org/53084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5becf47fb1f139bd246d8853f2c890aa90eb4c7a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: move v2v module to /var/lib/

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: move v2v module to /var/lib/
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5becf47fb1f139bd246d8853f2c890aa90eb4c7a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Clean netinfo.__init__ and migrate to cache

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Clean netinfo.__init__ and migrate to cache
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I892bb86fe9a8580d9028ca7759d27967e55d85f7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: added support for convergance schedule

[fromani]

Francesco Romani has posted comments on this change.

Change subject: migration: added support for convergance schedule
..


Patch Set 12: Code-Review+1

partial ack

-- 
To view, visit https://gerrit.ovirt.org/46940
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I989cff12d08ef1cab36bd10df7daaa999a8dac14
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: added support for convergance schedule

[fromani]

Francesco Romani has posted comments on this change.

Change subject: migration: added support for convergance schedule
..


Patch Set 12:

(1 comment)

Well it is a suggestion, so if you think it doesn't make sense this is fine as 
well :)
A possible meaningful split could be
- one (or few) patch(es) makes the room for the new convergenceSchedule stuff, 
moving code around, introducing helper functions and so forth (e.g. moving code 
into _perform_with_downtime_thread)
- one (or few) patch(es) adds the new convergenceSchedule stuff.

Not sure this is what you meant in the last comment (maybe yes!)

https://gerrit.ovirt.org/#/c/46940/12/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 342: self._startUnderlyingMigration(time.time())
Line 343: self._finishSuccessfully()
Line 344: except libvirt.libvirtError as e:
Line 345: if (e.get_error_code() ==
Line 346: libvirt.VIR_ERR_OPERATION_ABORTED):
not sure why I didn't noticed before, but this looks unnecessary.
Line 347: self.status = response.error(
Line 348: 'migCancelErr', message='Migration 
canceled')
Line 349: raise
Line 350: except MigrationDestinationSetupError as e:


-- 
To view, visit https://gerrit.ovirt.org/46940
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I989cff12d08ef1cab36bd10df7daaa999a8dac14
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding vdsm functional tests

[dcaro]

David Caro has posted comments on this change.

Change subject: Adding vdsm functional tests
..


Patch Set 48:

The issue when extracting the tests xml is fixed here:


https://github.com/lago-project/lago/commit/24f83bf87249fdcba0b9cb4ccd4b38525058d840

That will be released tomorrow

-- 
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c
Gerrit-PatchSet: 48
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Clean netinfo.__init__ and migrate to cache

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Clean netinfo.__init__ and migrate to cache
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I892bb86fe9a8580d9028ca7759d27967e55d85f7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: move v2v module to /var/lib/

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: v2v: move v2v module to /var/lib/
..


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/53084/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

Line 23: progress is a number which represent percentage of a single disk copy,
Line 24: status is a way to feedback information on the job (init, error etc)
Line 25: """
Line 26: 
Line 27: from collections import namedtuple
Missing absolute_import in lib/vdsm/v2v.py
Makefile:976: recipe for target 'abs_imports' failed
Line 28: from contextlib import closing, contextmanager
Line 29: import errno
Line 30: import logging
Line 31: import os


Line 139: return not (caps.getos() in (caps.OSName.RHEVH, caps.OSName.RHEL)
: and caps.osversion()['version'].startswith('6'))
this piece of code should be dropped, as el6 should not even be considered. 
then, "import caps" can be avoided.


-- 
To view, visit https://gerrit.ovirt.org/53084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5becf47fb1f139bd246d8853f2c890aa90eb4c7a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: fix tests (waitForState and vdsProxy)

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: ovs: fix tests (waitForState and vdsProxy)
..


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/52360/4//COMMIT_MSG
Commit Message:

Line 12: We have to change proxy handling to match new behavior using
   : getProxy() function.
I don't understand why. is it related to the waitForState change? if not, can 
you split the apart, and better explain which patch introduced the need for 
getProxy?


-- 
To view, visit https://gerrit.ovirt.org/52360
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50dc6cdf4312d194feeb2c8b7613a6adb61ccff9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: IP DHCP detection

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: IP DHCP detection
..


Patch Set 3: Code-Review-1

./lib/vdsm/netinfo/addresses.py:125:40: W292 no newline at end of file
Makefile:991: recipe for target 'pep8' failed
make: *** [pep8] Error 1

-- 
To view, visit https://gerrit.ovirt.org/53076
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d0396610822e3a41d44f37346ee1aad71d569d1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Hook: ide2sata: To switch IDE disks to SATA

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: Hook: ide2sata: To switch IDE disks to SATA
..


Patch Set 7: Code-Review-1

(2 comments)

a doc nit, and a question

https://gerrit.ovirt.org/#/c/48450/7/vdsm_hooks/ide2sata/README
File vdsm_hooks/ide2sata/README:

Line 19: diskunmap
copy+paste typo, I presume.


Line 41: IDE disks
so why don't you convert virtio disks to SATA?


-- 
To view, visit https://gerrit.ovirt.org/48450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0088dae191cf4560a00ee62023a54f5ab746a3c9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Javier Coscia 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Javier Coscia 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: fix bonded network change problem

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: ovs: fix bonded network change problem
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/52346
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecd3a064b4d4a428c61353b1533f8ed4be732c1b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: IP DHCP detection

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: IP DHCP detection
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53076
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d0396610822e3a41d44f37346ee1aad71d569d1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Fix of uninitialized variable access in Vm.setLinkAndN...

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: virt: Fix of uninitialized variable access in 
Vm.setLinkAndNetwork()
..


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/53061/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2149: vnicXML.appendChildWithArgs
Seems to have been introduced in http://gerrit.ovirt.org/29696 I'm afraid.


-- 
To view, visit https://gerrit.ovirt.org/53061
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04b44a1599593e825cc83f8df6edd4965ff43707
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: IP DHCP detection

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: IP DHCP detection
..


Patch Set 5: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/53076
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d0396610822e3a41d44f37346ee1aad71d569d1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6.1]: code coverage: change approach how to enable it

[automation]

gerrit-hooks has posted comments on this change.

Change subject: code coverage: change approach how to enable it
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/50795
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6.1
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Balogh 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6.1]: code coverage: change approach how to enable it

[danken]

Dan Kenigsberg has abandoned this change.

Change subject: code coverage: change approach how to enable it
..


Abandoned

3.6.1 is long gone

-- 
To view, visit https://gerrit.ovirt.org/50795
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6.1
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Balogh 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: IP DHCP detection

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: IP DHCP detection
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53076
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d0396610822e3a41d44f37346ee1aad71d569d1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: IP DHCP detection

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: IP DHCP detection
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53076
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d0396610822e3a41d44f37346ee1aad71d569d1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: numa: only use libvirt for memory info

[mpolednik]

Martin Polednik has uploaded a new change for review.

Change subject: numa: only use libvirt for memory info
..

numa: only use libvirt for memory info

Current code queries memory usage via libvirt or /proc/meminfo,
depending on the state of machine's numa support. For some time,
(guaranteed 7.0+) even machines without direct numa support do
expose a single node that we can query.

This patch removes the 'UMA' (unified memory architecture) code branch
and uses libvirt for all numa memory queries.

Change-Id: I0b5594a71047aae53374e4af5da95e3cd56f3835
Signed-off-by: Martin Polednik 
---
M tests/capsTests.py
M tests/samplingTests.py
M vdsm/caps.py
M vdsm/virt/sampling.py
4 files changed, 4 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/53091/1

diff --git a/tests/capsTests.py b/tests/capsTests.py
index 8f64332..d996ab2 100644
--- a/tests/capsTests.py
+++ b/tests/capsTests.py
@@ -131,13 +131,6 @@
   'totalMemory': '49141'}}
 self.assertEqual(t, expectedNumaInfo)
 
-@MonkeyPatch(utils, 'readMemInfo', lambda: {
-'MemTotal': 50321208, 'MemFree': 47906488})
-def testGetUMAMemStats(self):
-t = caps.getUMAHostMemoryStats()
-expectedInfo = {'total': '49141', 'free': '46783'}
-self.assertEqual(t, expectedInfo)
-
 @MonkeyPatch(commands, 'execCmd', lambda x: _getCapsNumaDistanceTestData(
 "caps_numactl_4_nodes.out"))
 def testNumaNodeDistance(self):
diff --git a/tests/samplingTests.py b/tests/samplingTests.py
index 99bc06a..62a3fc3 100644
--- a/tests/samplingTests.py
+++ b/tests/samplingTests.py
@@ -189,7 +189,7 @@
 def _monkeyPatchedMemorySample(self, freeMemory, totalMemory):
 node_id, cpu_id = 0, 0
 
-def fakeMemoryStats():
+def fakeMemoryStats(_):
 return {
 'free': freeMemory,
 'total': totalMemory
@@ -204,7 +204,7 @@
 
 return MonkeyPatchScope([(caps, 'getNumaTopology',
   fakeNumaTopology),
- (caps, 'getUMAHostMemoryStats',
+ (caps, 'getMemoryStatsByNumaCell',
   fakeMemoryStats)])
 
 def testMemoryStatsWithZeroMemoryAsString(self):
diff --git a/vdsm/caps.py b/vdsm/caps.py
index ae7d86f..4694368 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -229,10 +229,7 @@
 cpus.append(int(cpu.get('id')))
 cellInfo['cpus'] = cpus
 cellIndex = cell.get('id')
-if len(cellSets) < 2:
-memInfo = getUMAHostMemoryStats()
-else:
-memInfo = getMemoryStatsByNumaCell(int(cellIndex))
+memInfo = getMemoryStatsByNumaCell(int(cellIndex))
 cellInfo['totalMemory'] = memInfo['total']
 cellsInfo[cellIndex] = cellInfo
 return cellsInfo
@@ -250,19 +247,6 @@
 cellMemInfo['total'] = str(cellMemInfo['total'] / 1024)
 cellMemInfo['free'] = str(cellMemInfo['free'] / 1024)
 return cellMemInfo
-
-
-def getUMAHostMemoryStats():
-"""
-Get the memory stats of a UMA host, the unit is MiB.
-
-:return: dict like {'total': '49141', 'free': '46783'}
-"""
-memDict = {}
-memInfo = utils.readMemInfo()
-memDict['total'] = str(memInfo['MemTotal'] / 1024)
-memDict['free'] = str(memInfo['MemFree'] / 1024)
-return memDict
 
 
 @utils.memoized
diff --git a/vdsm/virt/sampling.py b/vdsm/virt/sampling.py
index a4c5ba7..91b10a0 100644
--- a/vdsm/virt/sampling.py
+++ b/vdsm/virt/sampling.py
@@ -168,10 +168,7 @@
 numaTopology = caps.getNumaTopology()
 for nodeIndex in numaTopology:
 nodeMemSample = {}
-if len(numaTopology) < 2:
-memInfo = caps.getUMAHostMemoryStats()
-else:
-memInfo = caps.getMemoryStatsByNumaCell(int(nodeIndex))
+memInfo = caps.getMemoryStatsByNumaCell(int(nodeIndex))
 nodeMemSample['memFree'] = memInfo['free']
 # in case the numa node has zero memory assigned, report the whole
 # memory as used


-- 
To view, visit https://gerrit.ovirt.org/53091
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b5594a71047aae53374e4af5da95e3cd56f3835
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: xmlrpc: retry when flushing socket

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: xmlrpc: retry when flushing socket
..


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/47637/5//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: m2crypto requires retry of write and we need to make sure that we do it
Line 10: once
Line 11: flushing data before closing a socket. In order to do so we need to 
move
Line 12: original implementation of IPXMLRPCRequestHandler#finish to our request
finish method comes from /usr/lib64/python2.7/SocketServer.py
Line 13: handler which inherits from IPXMLRPCRequestHandler.
Line 14: 
Line 15: 
Line 16: Bug-Url: https://bugzilla.redhat.com/1261255


https://gerrit.ovirt.org/#/c/47637/5/vdsm/rpc/bindingxmlrpc.py
File vdsm/rpc/bindingxmlrpc.py:

Line 298: # such as the local error ECONNABORTED.
Line 299: break
Line 300: except SSL.SSLError as e:
Line 301: if e.message == 'bad write retry':
Line 302: continue
if e.message != 'bad write retry':
   break


should be enough for that loop
Line 303: else:
Line 304: break
Line 305: 
Line 306: self.wfile.close()


-- 
To view, visit https://gerrit.ovirt.org/47637
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52dd6ad304a82ff6c8d3dff12a38269684abf055
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: xmlrpc: retry when flushing socket

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: xmlrpc: retry when flushing socket
..


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/47637/5//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: m2crypto requires retry of write and we need to make sure that we do it
Line 10: once
Line 11: flushing data before closing a socket. In order to do so we need to 
move
Line 12: original implementation of IPXMLRPCRequestHandler#finish to our request
> finish method comes from /usr/lib64/python2.7/SocketServer.py
but the implementation is from module as above
Line 13: handler which inherits from IPXMLRPCRequestHandler.
Line 14: 
Line 15: 
Line 16: Bug-Url: https://bugzilla.redhat.com/1261255


https://gerrit.ovirt.org/#/c/47637/5/vdsm/rpc/bindingxmlrpc.py
File vdsm/rpc/bindingxmlrpc.py:

Line 298: # such as the local error ECONNABORTED.
Line 299: break
Line 300: except SSL.SSLError as e:
Line 301: if e.message == 'bad write retry':
Line 302: continue
> if e.message != 'bad write retry':
Done
Line 303: else:
Line 304: break
Line 305: 
Line 306: self.wfile.close()


-- 
To view, visit https://gerrit.ovirt.org/47637
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52dd6ad304a82ff6c8d3dff12a38269684abf055
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: xmlrpc: retry when flushing socket

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: xmlrpc: retry when flushing socket
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/47637/5//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: m2crypto requires retry of write and we need to make sure that we do it
Line 10: once
Line 11: flushing data before closing a socket. In order to do so we need to 
move
Line 12: original implementation of IPXMLRPCRequestHandler#finish to our request
> but the implementation is from module as above
but if you want to find the code itself you need to dig in until getting to 
SocketServer.py , so better to specify that you override socketServer impl,  if 
someone want to check the origin code
Line 13: handler which inherits from IPXMLRPCRequestHandler.
Line 14: 
Line 15: 
Line 16: Bug-Url: https://bugzilla.redhat.com/1261255


-- 
To view, visit https://gerrit.ovirt.org/47637
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52dd6ad304a82ff6c8d3dff12a38269684abf055
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Apply storage QoS on running VM

[msivak]

Martin Sivák has posted comments on this change.

Change subject: Apply storage QoS on running VM
..


Patch Set 4:

(5 comments)

https://gerrit.ovirt.org/#/c/52746/4/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 2593:   'guaranteed': 'VmDiskDeviceIoTuneParams',
Line 2594:   'maximum': 'VmDiskDeviceIoTuneParams'}}
Line 2595: 
Line 2596: ##
Line 2597: # @VmIoTuneLimits:
Wouldn't this be better joined to the VmDiskDeviceTuneLimits structure? We 
could use inheritance there.. sadly we do not support it.
Line 2598: #
Line 2599: # Extra parameters for VM disk devices.
Line 2600: #
Line 2601: # @domainID:#optional DomainID


https://gerrit.ovirt.org/#/c/52746/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2454: metadata_modified = True
Line 2455: self._vcpuLimit = params.pop('vcpuLimit')
Line 2456: 
Line 2457: if 'ioTune' in params:
Line 2458: # convert [VmIoTuneLimits] to [VmDiskDeviceTuneLimits] 
structure
You do not need the separate structure definition for metadata. The jsonapi 
file describes the external api only.
Line 2459: ioTuneParams = params["ioTune"]
Line 2460: 
Line 2461: for ioTune in ioTuneParams:
Line 2462: self.log.debug("IoTuneParams: %s", str(ioTuneParams))


Line 2458: # convert [VmIoTuneLimits] to [VmDiskDeviceTuneLimits] 
structure
Line 2459: ioTuneParams = params["ioTune"]
Line 2460: 
Line 2461: for ioTune in ioTuneParams:
Line 2462: self.log.debug("IoTuneParams: %s", str(ioTuneParams))
You do not have to compute the path again when it is already provided (or the 
name).
Line 2463: domainId = ioTune["domainId"]
Line 2464: poolId = ioTune["poolId"]
Line 2465: imageId = ioTune["imageId"]
Line 2466: volumeId = ioTune["volumeId"]


Line 2469: domainId, poolId, imageId, volumeId)
Line 2470: 
Line 2471: self.log.debug("Returned path: %s", path)
Line 2472: 
Line 2473: del ioTune["domainId"]
It is not necessary to remove those from the metadata. Maybe they will come 
handy in future.
Line 2474: del ioTune["poolId"]
Line 2475: del ioTune["imageId"]
Line 2476: del ioTune["volumeId"]
Line 2477: 


Line 2565: def getIoTune(self):
Line 2566: resultList = []
Line 2567: 
Line 2568: for device in self._devices[hwclass.DISK]:
Line 2569: dom = device.getXML()
I think this will give you the currently configured value in vdsm, not the 
value libvirt sees. But vdsm considers itself to be the owner of libvirt so it 
might not matter.
Line 2570: io_dom_list = dom.getElementsByTagName("iotune")
Line 2571: 
Line 2572: if not io_dom_list:
Line 2573: continue


-- 
To view, visit https://gerrit.ovirt.org/52746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: don't log missing brif files

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: don't log missing brif files
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53095
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e9feb565b69f097aeb2d2725e2f668cf43fea8b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: don't log missing brif files

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: don't log missing brif files
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53095
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e9feb565b69f097aeb2d2725e2f668cf43fea8b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: numa: only use libvirt for memory info

[automation]

gerrit-hooks has posted comments on this change.

Change subject: numa: only use libvirt for memory info
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53091
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b5594a71047aae53374e4af5da95e3cd56f3835
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding vdsm functional tests

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding vdsm functional tests
..


Patch Set 48:

I want to remove the call from check-patch to check-merge and take this patch 
as is . please review and see the output in  
http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/2635/ . once 
its in, next patch will be to add additional tests to make it meaningful .. 
currently it doesn't run much, just create the basic setup- vm with vdsm 
installed and run supervdsm functional tests [which great for my current effort 
to make supervdsm plug-able :)]

-- 
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c
Gerrit-PatchSet: 48
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: xmlrpc: retry when flushing socket

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: xmlrpc: retry when flushing socket
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/47637/5//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: m2crypto requires retry of write and we need to make sure that we do it
Line 10: once
Line 11: flushing data before closing a socket. In order to do so we need to 
move
Line 12: original implementation of IPXMLRPCRequestHandler#finish to our request
> but if you want to find the code itself you need to dig in until getting to
Done
Line 13: handler which inherits from IPXMLRPCRequestHandler.
Line 14: 
Line 15: 
Line 16: Bug-Url: https://bugzilla.redhat.com/1261255


-- 
To view, visit https://gerrit.ovirt.org/47637
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52dd6ad304a82ff6c8d3dff12a38269684abf055
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: setupNetworks: moving nics between bonds

[automation]

gerrit-hooks has posted comments on this change.

Change subject: setupNetworks: moving nics between bonds
..


Patch Set 12:

* #1269175::Update tracker: OK
* Set MODIFIED::bug 1269175#1269175OK

-- 
To view, visit https://gerrit.ovirt.org/50596
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia43fbfe90d1335ed4a740a1bc4f09610da2ecdce
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: setupNetworks: moving nics between bonds

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: setupNetworks: moving nics between bonds
..


setupNetworks: moving nics between bonds

This patch fixes a problem where a slave removed from
one bond could sometimes not be assigned to another
bond in the same request.
This happened because removing, editing and adding of
slaves to a bond was done bond by bond, so if a nic
was added to a bond which was handled before the bond
from which the nic was removed the operation failed.
Example:
bond0: nic0, nic1   => nic2, nic3
bond1: nic2, nic3   => nic0, nic1
In this situation first bond0 is processed: nic0 and
nic1 will be removed, but nic2 and nic3 can not yet
be removed as they are part of bond1 (validation fails).
Processing of bond1 will introduce errors, as nic2 and
nic3 will be removed (already assigned to bond0),
which will in effect reset their ifcfg files, and cause
the previous attachement to bond0 to be undone.

The patch changes the validation to check if a slave
added to a bond is deleted from another bond.
Also the removing of slaves from all bonds is done
before any other bond operation.

Bug-Url: https://bugzilla.redhat.com/1269175
Change-Id: Ia43fbfe90d1335ed4a740a1bc4f09610da2ecdce
Signed-off-by: Marcin Mirecki 
Reviewed-on: https://gerrit.ovirt.org/50596
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas 
Reviewed-by: Francesco Romani 
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/network/api.py
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/configurators/iproute2.py
M lib/vdsm/network/models.py
M tests/functional/networkTests.py
5 files changed, 57 insertions(+), 8 deletions(-)

Approvals:
  Marcin Mirecki: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/50596
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia43fbfe90d1335ed4a740a1bc4f09610da2ecdce
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: IP DHCP detection

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: IP DHCP detection
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/53076/1/lib/vdsm/netinfo/dhcp.py
File lib/vdsm/netinfo/dhcp.py:

Line 71: def _parse_expiry_time(expiry_time):
> drop this dead code
Done


-- 
To view, visit https://gerrit.ovirt.org/53076
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d0396610822e3a41d44f37346ee1aad71d569d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: IP DHCP detection

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: IP DHCP detection
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/53076
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d0396610822e3a41d44f37346ee1aad71d569d1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: IP DHCP detection

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: IP DHCP detection
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53076
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d0396610822e3a41d44f37346ee1aad71d569d1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: exception: Make VdsmException reusable

[automation]

gerrit-hooks has posted comments on this change.

Change subject: exception: Make VdsmException reusable
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/52982
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd6643d9670cb9b067e372bf5a1a6c57ced41954
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: moving hook error to exception module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: moving hook error to exception module
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/52983
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I920a7ecff2f5e0b604f8c13dce2e59bdeef30056
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: make sure to handle vdsm exception in the bridge

[ybronhei]

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: hooks: make sure to handle vdsm exception in the bridge
..


hooks: make sure to handle vdsm exception in the bridge

We need to make sure to handle hook errors properly and pass them to
the client.


Change-Id: Ic9c0e953f96827737eede22ab39a1f7689c30944
Signed-off-by: pkliczewski 
Bug-Url: https://bugzilla.redhat.com/1295778
Reviewed-on: https://gerrit.ovirt.org/52984
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Yaniv Bronhaim 
---
M tests/bridgeTests.py
M vdsm/rpc/Bridge.py
2 files changed, 19 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/52984
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9c0e953f96827737eede22ab39a1f7689c30944
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: make sure to handle vdsm exception in the bridge

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: hooks: make sure to handle vdsm exception in the bridge
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/52984
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9c0e953f96827737eede22ab39a1f7689c30944
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: moving hook error to exception module

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: hooks: moving hook error to exception module
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/52983
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I920a7ecff2f5e0b604f8c13dce2e59bdeef30056
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: exception: Make VdsmException reusable

[ybronhei]

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: exception: Make VdsmException reusable
..


exception: Make VdsmException reusable

VdsmException was initializing code and message to default values if
called without arguments. This make is useless as as base class for
more specific exceptions, defining real code and message.

GlusterException, the only exception inheriting from VdsmException,
avoided this issue by overriding __init__.

Required-For: https://bugzilla.redhat.com/1295778
Change-Id: Icd6643d9670cb9b067e372bf5a1a6c57ced41954
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/48875
Reviewed-by: Francesco Romani 
Reviewed-by: Piotr Kliczewski 
Continuous-Integration: Jenkins CI
Reviewed-on: https://gerrit.ovirt.org/52982
Tested-by: Piotr Kliczewski 
Reviewed-by: Yaniv Bronhaim 
---
M lib/vdsm/exception.py
M tests/Makefile.am
A tests/exception_test.py
3 files changed, 35 insertions(+), 4 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/52982
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd6643d9670cb9b067e372bf5a1a6c57ced41954
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: moving hook error to exception module

[ybronhei]

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: hooks: moving hook error to exception module
..


hooks: moving hook error to exception module


Required-For: https://bugzilla.redhat.com/1295778
Change-Id: I920a7ecff2f5e0b604f8c13dce2e59bdeef30056
Signed-off-by: pkliczewski 
Reviewed-on: https://gerrit.ovirt.org/52983
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Yaniv Bronhaim 
---
M lib/vdsm/exception.py
M vdsm/hooks.py
2 files changed, 7 insertions(+), 5 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/52983
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I920a7ecff2f5e0b604f8c13dce2e59bdeef30056
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: exception: Make VdsmException reusable

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: exception: Make VdsmException reusable
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/52982
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd6643d9670cb9b067e372bf5a1a6c57ced41954
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Clean netinfo.__init__ and migrate to cache

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Clean netinfo.__init__ and migrate to cache
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/53007/3/lib/vdsm/netinfo/cache.py
File lib/vdsm/netinfo/cache.py:

Line 157: def ifaceUsed(iface):
Line 158: """Lightweight implementation of bool(Netinfo.ifaceUsers()) that 
does not
Line 159: require a NetInfo object."""
Line 160: if os.path.exists(os.path.join(netinfo.NET_PATH, iface, 
'brport')):
Line 161: return True
> please move the   # Is it a port
Comments are evil.
What about adding a func above it?:
def is_port(iface):
return os.path.exists(os.path.join(netinfo.NET_PATH, iface, 'brport'))

if is_port(iface):
return True
Line 162: for linkDict in nl_link.iter_links():
Line 163: if linkDict['name'] == iface and 'master' in linkDict:  # Is 
it a slave
Line 164: return True
Line 165: if linkDict.get('device') == iface and linkDict.get('type') 
== 'vlan':


-- 
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I892bb86fe9a8580d9028ca7759d27967e55d85f7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: make sure to handle vdsm exception in the bridge

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: make sure to handle vdsm exception in the bridge
..


Patch Set 2:

* #1295778::Update tracker: OK
* Set MODIFIED::bug 1295778#1295778IGNORE, not all related patches are 
closed, check 52544

-- 
To view, visit https://gerrit.ovirt.org/52984
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9c0e953f96827737eede22ab39a1f7689c30944
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Clean netinfo.__init__ and migrate to cache

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Clean netinfo.__init__ and migrate to cache
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I892bb86fe9a8580d9028ca7759d27967e55d85f7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Canonize dhcpv6 on API input

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Canonize dhcpv6 on API input
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/52989
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b551f28ba143ca88efdbaec7771b7eba0608318
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Fix of uninitialized variable access in Vm.setLinkAndN...

[edwardh]

Edward Haas has posted comments on this change.

Change subject: virt: Fix of uninitialized variable access in 
Vm.setLinkAndNetwork()
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/53061
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04b44a1599593e825cc83f8df6edd4965ff43707
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Advertise aggregator ID in bonding interfaces

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Advertise aggregator ID in bonding interfaces
..


Patch Set 2:

* #1281666::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1281666::OK, public bug
* Check Product::#1281666::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85267967c9cb1b0a626d91cb1953361ed4de727a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Advertise aggregator ID in bonding interfaces

[sshnaidm]

Sagi Shnaidman has posted comments on this change.

Change subject: Advertise aggregator ID in bonding interfaces
..


Patch Set 3:

Waiting for real bond setup to check this on.

-- 
To view, visit https://gerrit.ovirt.org/53100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85267967c9cb1b0a626d91cb1953361ed4de727a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Advertise aggregator ID in bonding interfaces

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Advertise aggregator ID in bonding interfaces
..


Patch Set 3:

* #1281666::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1281666::OK, public bug
* Check Product::#1281666::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85267967c9cb1b0a626d91cb1953361ed4de727a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Advertise aggregator ID in bonding interfaces

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Advertise aggregator ID in bonding interfaces
..


Patch Set 4:

* #1281666::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1281666::OK, public bug
* Check Product::#1281666::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85267967c9cb1b0a626d91cb1953361ed4de727a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Advertise aggregator ID in bonding interfaces

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Advertise aggregator ID in bonding interfaces
..


Patch Set 5:

* #1281666::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1281666::OK, public bug
* Check Product::#1281666::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85267967c9cb1b0a626d91cb1953361ed4de727a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding vdsm functional tests

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: Adding vdsm functional tests
..


Patch Set 48:

(1 comment)

https://gerrit.ovirt.org/#/c/48268/48/automation/check-patch.repos.fc22
File automation/check-patch.repos.fc22:

Line 3: 23
the file name suggests it is f22 and here we have f23. Is that intentional?


-- 
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c
Gerrit-PatchSet: 48
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding vdsm functional tests

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: Adding vdsm functional tests
..


Patch Set 49: Code-Review-1

(5 comments)

https://gerrit.ovirt.org/#/c/48268/49/automation/build-artifacts.sh
File automation/build-artifacts.sh:

Line 14: make all
this should better not be moved in this patch. maybe in a followup 
optinmization patch.


https://gerrit.ovirt.org/#/c/48268/49/automation/check-merged.packages
File automation/check-merged.packages:

Line 1
very confusing... maybe you can keep the softlink and update 
check-merged.repos.fc23 and friends.


https://gerrit.ovirt.org/#/c/48268/49/automation/check-patch.packages
File automation/check-patch.packages:

Line 1: autoconf
Line 2: automake
Line 3: git
Line 4: lago
no need to pull lago and its friends in every check-patch. they can sit only in 
check-merge.packages.
Line 5: lago-ovirt
Line 6: lago-ovirt-extras
Line 7: libguestfs-tools-c
Line 8: m2crypto


https://gerrit.ovirt.org/#/c/48268/49/automation/check-patch.repos.fc22
File automation/check-patch.repos.fc22:

Line 3: 3
typo?


https://gerrit.ovirt.org/#/c/48268/49/automation/check-patch.sh
File automation/check-patch.sh:

Line 17: 
Please do not drop this synchronous test - it has saved me multiple times from 
merging stuff that did not hit Fedora/Centos yet.


-- 
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c
Gerrit-PatchSet: 49
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: two networks cannot share one tag

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: ovs: two networks cannot share one tag
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/52361
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: two networks cannot share one tag

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: hooks: ovs: two networks cannot share one tag
..


hooks: ovs: two networks cannot share one tag

testSetupNetworksNetCompatibilityMultipleNetsSameNic
assigns the same tag to two networks. This is not possible
with OVS, two fake bridges under the same OVS bridge cannot
share a tag.

Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/52361
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M tests/functional/networkTestsOVS.py
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/52361
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP: lib: clientIF: move vmContainer away

[automation]

gerrit-hooks has posted comments on this change.

Change subject: WIP: lib: clientIF: move vmContainer away
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53101
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacd2ae6c5e9ca6a73c0fed978c78c9ebb001c46d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Advertise aggregator ID in bonding interfaces

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Advertise aggregator ID in bonding interfaces
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85267967c9cb1b0a626d91cb1953361ed4de727a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding vdsm functional tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adding vdsm functional tests
..


Patch Set 49:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c
Gerrit-PatchSet: 49
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: two networks cannot share one tag

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: two networks cannot share one tag
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/52361
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Advertise aggregator ID in bonding interfaces

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: Advertise aggregator ID in bonding interfaces
..


Patch Set 5:

(5 comments)

https://gerrit.ovirt.org/#/c/53100/5/lib/vdsm/netinfo/bonding.py
File lib/vdsm/netinfo/bonding.py:

Line 68: def info(link):
Line 69: return {'hwaddr': link.address, 'slaves': slaves(link.name),
Line 70: 'active_slave': _active_slave(link.name),
Line 71: 'opts': _getBondingOptions(link.name),
Line 72: 'aggregator_id': nics._get_aggregator_id(link.name) or ''}
does this work for the bonding device itself? is it listed under bonding_slaves?
Line 73: 
Line 74: 
Line 75: def _active_slave(bond_name):
Line 76: """


https://gerrit.ovirt.org/#/c/53100/5/lib/vdsm/netinfo/nics.py
File lib/vdsm/netinfo/nics.py:

Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: from __future__ import absolute_import
Line 20: import errno
Line 21: import io
Line 22: import os
put in alphabet order, please
Line 23: from functools import partial
Line 24: import logging
Line 25: 
Line 26: from ..ipwrapper import drv_name


Line 74: return 0
Line 75: 
Line 76: 
Line 77: def _get_aggregator_id(nic_name):
Line 78: agg_id_path = 
'/sys/class/net/{nic}/bonding_slave/ad_aggregator_id'.format(
this string begs to sit with the other BONDING_ constants in bonding.pu (maybe 
the whole function should go there)?
Line 79: nic=nic_name)
Line 80: if os.path.exists(agg_id_path):
Line 81: try:
Line 82: with open(agg_id_path, "r") as f:


Line 84: except IOError
when can this happen? it is unacceptable to trash the log with exceptions every 
15 seconds due to usage of bonding mode!=4.


Line 93: aggregator_id
naming: i'd keep the ad_ prefeix from kernel

also, please do not report an empty string; do not report it if its missing.


-- 
To view, visit https://gerrit.ovirt.org/53100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85267967c9cb1b0a626d91cb1953361ed4de727a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Advertise aggregator ID in bonding interfaces

[sshnaidm]

Sagi Shnaidman has posted comments on this change.

Change subject: Advertise aggregator ID in bonding interfaces
..


Patch Set 5: Verified-1

WIP

-- 
To view, visit https://gerrit.ovirt.org/53100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85267967c9cb1b0a626d91cb1953361ed4de727a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add load() method to the recovery.File class

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: virt: add load() method to the recovery.File class
..


Patch Set 13:

(2 comments)

https://gerrit.ovirt.org/#/c/51389/13/vdsm/virt/recovery.py
File vdsm/virt/recovery.py:

Line 95: self._log.debug("recovery: trying with VM %
better sit outside of try-block


Line 107: pickle.load
load is calling _restore that is calling load.

naming is not at it best here; and no, I don't have a better idea right now :-(


-- 
To view, visit https://gerrit.ovirt.org/51389
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea65e129c6016f5b75fc228eaf88492a0d10d39f
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Clean netinfo.__init__ and migrate to cache

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: Clean netinfo.__init__ and migrate to cache
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I892bb86fe9a8580d9028ca7759d27967e55d85f7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Clean netinfo.__init__ and migrate to cache

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: Clean netinfo.__init__ and migrate to cache
..


net: Clean netinfo.__init__ and migrate to cache

When stand alone modules under the netinfo package are being used by other
modules, __init__ is being processed and cause import loops.
This patch migrates most __init__ content to cache.

Change-Id: I892bb86fe9a8580d9028ca7759d27967e55d85f7
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/53007
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M debian/vdsm-python.install
M lib/vdsm/netinfo/Makefile.am
M lib/vdsm/netinfo/__init__.py
A lib/vdsm/netinfo/cache.py
M lib/vdsm/network/api.py
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/configurators/iproute2.py
M lib/vdsm/network/configurators/qos.py
M lib/vdsm/network/models.py
M lib/vdsm/tool/unified_persistence.py
M tests/configNetworkTests.py
M tests/functional/networkTests.py
M tests/functional/utils.py
M tests/netinfoTests.py
M tests/netmodelsTests.py
M vdsm.spec.in
M vdsm/caps.py
M vdsm/vdsm-restore-net-config
M vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
19 files changed, 370 insertions(+), 338 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I892bb86fe9a8580d9028ca7759d27967e55d85f7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Clean netinfo.__init__ and migrate to cache

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Clean netinfo.__init__ and migrate to cache
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I892bb86fe9a8580d9028ca7759d27967e55d85f7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Live Merge: Skip initial extension when base is raw

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: Live Merge: Skip initial extension when base is raw
..

Live Merge: Skip initial extension when base is raw

When starting a live merge we pre-extend the base volume in order to
accomodate the data that will be merged into the base volume.  This is
only necessary for thinly provisioned block volumes.  Check to make sure
that the base volume is eligible for extension before extending it.

Change-Id: If105854174e9fdbc9bad7aef511ff233de8991a3
Signed-off-by: Adam Litke 
---
M vdsm/virt/vm.py
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/53110/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index f6ba328..2c577e3 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -5966,6 +5966,7 @@
 self.log.error("merge: Refusing to merge into a shared volume")
 return errCode['mergeErr']
 baseSize = int(res['info']['apparentsize'])
+baseFormat = res['info']['format']
 
 # Indicate that we expect libvirt to maintain the relative paths of
 # backing files.  This is necessary to ensure that a volume chain is
@@ -6031,7 +6032,9 @@
 capacity, alloc, physical = self._dom.blockInfo(drive.path, 0)
 maxAlloc = min(capacity, maxAlloc)
 maxAlloc = maxAlloc * drive.VOLWM_COW_OVERHEAD
-self.extendDriveVolume(drive, baseVolUUID, maxAlloc)
+
+if drive.blockDev and baseFormat != 'RAW':
+self.extendDriveVolume(drive, baseVolUUID, maxAlloc)
 
 # Trigger the collection of stats before returning so that callers
 # of getVmStats after this returns will see the new job


-- 
To view, visit https://gerrit.ovirt.org/53110
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If105854174e9fdbc9bad7aef511ff233de8991a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Live Merge: Skip initial extension when base is raw

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Live Merge: Skip initial extension when base is raw
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still missing on branches master, ovirt-3.6

-- 
To view, visit https://gerrit.ovirt.org/53110
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If105854174e9fdbc9bad7aef511ff233de8991a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Fix of uninitialized variable access in Vm.setLinkAndN...

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Fix of uninitialized variable access in 
Vm.setLinkAndNetwork()
..


Patch Set 1: Code-Review+1

Fine, let's hear from the network folks. Partial ACK.

-- 
To view, visit https://gerrit.ovirt.org/53061
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04b44a1599593e825cc83f8df6edd4965ff43707
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: setupNetworks: moving nics between bonds

[mmirecki]

Marcin Mirecki has posted comments on this change.

Change subject: setupNetworks: moving nics between bonds
..


Patch Set 11: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50596
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia43fbfe90d1335ed4a740a1bc4f09610da2ecdce
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Clean netinfo.__init__ and migrate to cache

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Clean netinfo.__init__ and migrate to cache
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I892bb86fe9a8580d9028ca7759d27967e55d85f7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Fixing old netinfo access

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Fixing old netinfo access
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53011
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37b61668eb8bda5a67b60e0d6b8ea92b524e8b45
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Fixing old netinfo access

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: Fixing old netinfo access
..


net: Fixing old netinfo access

netinfo has been split into individual modules some time ago, this patch
fixes some leftovers that have been missed.

Change-Id: I37b61668eb8bda5a67b60e0d6b8ea92b524e8b45
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/53011
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M vdsm/virt/vmdevices/graphics.py
M vdsm_hooks/ethtool_options/ethtool_options.py
M vdsm_hooks/extra_ipv4_addrs/extra_ipv4_addrs.py
M vdsm_hooks/ovs/ovs_before_network_setup_mtu.py
4 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/53011
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I37b61668eb8bda5a67b60e0d6b8ea92b524e8b45
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Fixing old netinfo access

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Fixing old netinfo access
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/53011
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37b61668eb8bda5a67b60e0d6b8ea92b524e8b45
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Fixing old netinfo access

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: Fixing old netinfo access
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/53011
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37b61668eb8bda5a67b60e0d6b8ea92b524e8b45
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Clean netinfo.__init__ and migrate to cache

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Clean netinfo.__init__ and migrate to cache
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/53007/2/lib/vdsm/netinfo/__init__.py
File lib/vdsm/netinfo/__init__.py:

Line 21: 
> please keep this line - all new modules should have it, as it protects from
Done


Line 48: 
> this is not strictly related to cache - can it not stay here?
Done


-- 
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I892bb86fe9a8580d9028ca7759d27967e55d85f7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Fixing old netinfo access

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Fixing old netinfo access
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/53011/1/vdsm/virt/vmdevices/graphics.py
File vdsm/virt/vmdevices/graphics.py:

Line 205: def _getNetworkIp(network):
Line 206: try:
Line 207: nets = netinfo.networks()
Line 208: device = nets[network].get('iface', network)
Line 209: ip, _, _, _ = netinfo.addresses.getIpInfo(device)
> can you add a call to this function from one of our *functional tests*? Aft
Will treat it in a separated patch.
Adding to my TODO.
Line 210: except (libvirt.libvirtError, KeyError, IndexError):
Line 211: ip = config.get('addresses', 'guests_gateway_ip')
Line 212: if ip == '':
Line 213: ip = '0'


-- 
To view, visit https://gerrit.ovirt.org/53011
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37b61668eb8bda5a67b60e0d6b8ea92b524e8b45
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: IP DHCP detection

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: IP DHCP detection
..


Patch Set 1:

(1 comment)

partial review

https://gerrit.ovirt.org/#/c/53076/1/lib/vdsm/netinfo/dhcp.py
File lib/vdsm/netinfo/dhcp.py:

Line 71: def _parse_expiry_time(expiry_time):
drop this dead code


-- 
To view, visit https://gerrit.ovirt.org/53076
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d0396610822e3a41d44f37346ee1aad71d569d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Clean netinfo.__init__ and migrate to cache

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: Clean netinfo.__init__ and migrate to cache
..


Patch Set 3: Code-Review-1

-- 
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I892bb86fe9a8580d9028ca7759d27967e55d85f7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Clean netinfo.__init__ and migrate to cache

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: Clean netinfo.__init__ and migrate to cache
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/53007/3/lib/vdsm/netinfo/cache.py
File lib/vdsm/netinfo/cache.py:

Line 157: def ifaceUsed(iface):
Line 158: """Lightweight implementation of bool(Netinfo.ifaceUsers()) that 
does not
Line 159: require a NetInfo object."""
Line 160: if os.path.exists(os.path.join(netinfo.NET_PATH, iface, 
'brport')):
Line 161: return True
please move the   # Is it a port
comment to here, not drop it.
Line 162: for linkDict in nl_link.iter_links():
Line 163: if linkDict['name'] == iface and 'master' in linkDict:  # Is 
it a slave
Line 164: return True
Line 165: if linkDict.get('device') == iface and linkDict.get('type') 
== 'vlan':


-- 
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I892bb86fe9a8580d9028ca7759d27967e55d85f7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches