Change in vdsm[master]: gluster: Don't fail connect server when getting volume info

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Don't fail connect server when getting volume info
..


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/53785/10/tests/storageServerTests.py
File tests/storageServerTests.py:

Line 263: self.assertEquals(gluster.options, "")
Line 264: 
Line 265: 
Line 266: @expandPermutations
Line 267: class GlusterFSNotAccessibleConnectionTests(VdsmTestCase):
These tests not test anything, because you did not monkeypatch 
gluster.cli.exists - the code does not reach the self.info check.

Please add:

@MonkeyPatch(gluster.cli, 'exists', lambda: True)

For both tests.
Line 268: 
Line 269: def glusterVolumeInfo(self, volumeName=None, remoteServer=None):
Line 270: raise ge.GlusterCmdExecFailedException()
Line 271: 


-- 
To view, visit https://gerrit.ovirt.org/53785
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e1835b7de4c5c4c5c4616d3c36f15c1f91a01dc
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: restore-nets: disable IPv6 based on ifcfg files

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: restore-nets: disable IPv6 based on ifcfg files
..


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/54226/5/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:

Line 354: 
Line 355: 
Line 356: def _ipv6_ifcfg(link_name):
Line 357: def ipv6init(content):
Line 358: return any(line == 'IPV6INIT=yes' for line in 
content.splitlines())
If none of the lines has "IPV6INIT", this function must return True. This is 
what our 3.5 users have on their hosts.

if any of the lines is IPV6INIT=no, you should return False. Otherwise, return 
True.

It would be more pure to match the initscript regexp ([Nn0].*) but this can 
wait for a follow-up patch, as we do not do so elsewhere in Vdsm.
Line 359: return _ifcfg_predicate(link_name, ipv6init)
Line 360: 
Line 361: 
Line 362: def _restore_disable_ipv6():


-- 
To view, visit https://gerrit.ovirt.org/54226
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3010e4a163cb8b7622b3b7425fa8fca09d602c7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: numa: work around defaultdict marshalling for xmlrpc

[fromani]

Francesco Romani has posted comments on this change.

Change subject: numa: work around defaultdict marshalling for xmlrpc
..


Patch Set 1: Code-Review+1

oops! surely we need this conversion, not sure if it is best done here or in 
caps.py, just before to return the full response to be sent on wire. Martin, 
the choice is yours, I'm ok both ways.

-- 
To view, visit https://gerrit.ovirt.org/54283
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83c85fa396cebbc93b1eb625132b218aee1119a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hotplugDisk: Handle prepareVolumePath errors gracefully.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hotplugDisk: Handle prepareVolumePath errors gracefully.
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/54266/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2653: except VolumeError as e:
Line 2654: self.log.error(traceback.format_exc())
Line 2655: return response.error(
Line 2656: 'hotplugDisk',
Line 2657: "Preparing path during hotplug disk failed: %s" % e)
> Supplying a message to response.error will set the message that the user wi
The error type is detected by engine using the error code - set by using 
"hotplugDisk" - this info is not removed, and should be used by engine to 
report the error.

The error message is additional detail about why hotplug failed.
Line 2658: 
Line 2659: if isVdsmImage(diskParams):
Line 2660: self._normalizeVdsmImg(diskParams)
Line 2661: self._createTransientDisk(diskParams)


-- 
To view, visit https://gerrit.ovirt.org/54266
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic049f388eb25127864edf5931ddb3b21b67f2dff
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hotplugDisk: Handle prepareVolumePath errors gracefully.

[aaviram]

Amit Aviram has posted comments on this change.

Change subject: hotplugDisk: Handle prepareVolumePath errors gracefully.
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/54266/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2650: diskParams = params.get('drive', {})
Line 2651: try:
Line 2652: diskParams['path'] = 
self.cif.prepareVolumePath(diskParams)
Line 2653: except VolumeError as e:
Line 2654: self.log.error(traceback.format_exc())
> Use self.log.exception("description ...")
Done
Line 2655: return response.error(
Line 2656: 'hotplugDisk',
Line 2657: "Preparing path during hotplug disk failed: %s" % e)
Line 2658: 


Line 2653: except VolumeError as e:
Line 2654: self.log.error(traceback.format_exc())
Line 2655: return response.error(
Line 2656: 'hotplugDisk',
Line 2657: "Preparing path during hotplug disk failed: %s" % e)
> I think that "Cannot prepare path: %s" is better.
Supplying a message to response.error will set the message that the user will 
eventually see, and replace the 'hotplugDisk' default message, so I think it is 
better for ux
Line 2658: 
Line 2659: if isVdsmImage(diskParams):
Line 2660: self._normalizeVdsmImg(diskParams)
Line 2661: self._createTransientDisk(diskParams)


-- 
To view, visit https://gerrit.ovirt.org/54266
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic049f388eb25127864edf5931ddb3b21b67f2dff
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: restore-nets: disable IPv6 based on ifcfg files

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: restore-nets: disable IPv6 based on ifcfg files
..


Patch Set 5: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54226
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3010e4a163cb8b7622b3b7425fa8fca09d602c7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: restore-nets: disable IPv6 based on ifcfg files

[automation]

gerrit-hooks has posted comments on this change.

Change subject: restore-nets: disable IPv6 based on ifcfg files
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54226
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3010e4a163cb8b7622b3b7425fa8fca09d602c7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: relax a condition so DUID can be inherited again

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: network: relax a condition so DUID can be inherited again
..


Patch Set 2: Verified+1

testDhcpReplaceNicWithBridge passes thanks to this patch, and host deployment 
with NetworkManager not disabled should be more manageable.

-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: restore-nets: disable IPv6 based on ifcfg files

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: restore-nets: disable IPv6 based on ifcfg files
..


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/54226/4/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:

Line 358: line == 'IPV6INIT=yes'
> initscripts definition of NO IPv6 is [[ "$IPV6INIT" = [nN0]* ]]
We are dealing here with VDSM-written ifcfg files, do we want to be as 
rigorous? ifcfg configurator always outputs IPV6INIT with either "yes" or "no" 
so there is not implicit value.


Line 372: _basename_ifcfg
> _ifcfg_dev_name
Done


-- 
To view, visit https://gerrit.ovirt.org/54226
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3010e4a163cb8b7622b3b7425fa8fca09d602c7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: restore-nets: disable IPv6 based on ifcfg files

[edwardh]

Edward Haas has posted comments on this change.

Change subject: restore-nets: disable IPv6 based on ifcfg files
..


Patch Set 4: Code-Review-1

(2 comments)

We may also need a test here, we have no protection.

https://gerrit.ovirt.org/#/c/54226/4/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:

Line 358: line == 'IPV6INIT=yes'
initscripts definition of NO IPv6 is [[ "$IPV6INIT" = [nN0]* ]]

Therefore, by default it is ON, only when it has n/N/0 it will be an OFF.


Line 372: _basename_ifcfg
_ifcfg_dev_name


-- 
To view, visit https://gerrit.ovirt.org/54226
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3010e4a163cb8b7622b3b7425fa8fca09d602c7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Removing 'link' scoped addresses from the ip address list

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Removing 'link' scoped addresses from the ip address list
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/54211
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8bbee8deebdfc617bc82f811e8a20e4db11ebb5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: numa: work around defaultdict marshalling for xmlrpc

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: numa: work around defaultdict marshalling for xmlrpc
..


Patch Set 1: Verified+1

The exception is now fixed.

Traceback (most recent call last):
  File "/usr/share/vdsm/vdsClient.py", line 2995, in 
code, message = commands[command][0](commandArgs)
  File "/usr/share/vdsm/vdsClient.py", line 550, in do_getCap
return self.ExecAndExit(self.s.getVdsCapabilities())
  File "/usr/lib64/python2.7/xmlrpclib.py", line 1240, in __call__
return self.__send(self.__name, args)
  File "/usr/lib64/python2.7/xmlrpclib.py", line 1599, in __request
verbose=self.__verbose
  File "/usr/lib64/python2.7/xmlrpclib.py", line 1280, in request
return self.single_request(host, handler, request_body, verbose)
  File "/usr/lib64/python2.7/xmlrpclib.py", line 1313, in single_request
return self.parse_response(response)
  File "/usr/lib/python2.7/site-packages/vdsm/vdscli.py", line 43, in 
wrapped_parse_response
return old_parse_response(*args, **kwargs)
  File "/usr/lib64/python2.7/xmlrpclib.py", line 1490, in parse_response
return u.close()
  File "/usr/lib64/python2.7/xmlrpclib.py", line 799, in close
raise Fault(**self._stack[0])
Fault: :cannot marshal  objects">

-- 
To view, visit https://gerrit.ovirt.org/54283
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83c85fa396cebbc93b1eb625132b218aee1119a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: numa: work around defaultdict marshalling for xmlrpc

[automation]

gerrit-hooks has posted comments on this change.

Change subject: numa: work around defaultdict marshalling for xmlrpc
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54283
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83c85fa396cebbc93b1eb625132b218aee1119a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: numa: work around defaultdict marshalling for xmlrpc

[osvoboda]

Ondřej Svoboda has uploaded a new change for review.

Change subject: numa: work around defaultdict marshalling for xmlrpc
..

numa: work around defaultdict marshalling for xmlrpc

vdsClient -s 0 getVdsCaps would now fail with
cannot marshal  objects

Change-Id: I83c85fa396cebbc93b1eb625132b218aee1119a9
Signed-off-by: Ondřej Svoboda 
---
M lib/vdsm/numa.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/54283/1

diff --git a/lib/vdsm/numa.py b/lib/vdsm/numa.py
index c196e0b..6a215d0 100644
--- a/lib/vdsm/numa.py
+++ b/lib/vdsm/numa.py
@@ -98,7 +98,7 @@
 'onlineCpus': online_cpus,
 }
 
-return NumaTopology(topology, distances, cpu_topology)
+return NumaTopology(dict(topology), dict(distances), cpu_topology)
 
 
 def memory_by_cell(index):


-- 
To view, visit https://gerrit.ovirt.org/54283
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I83c85fa396cebbc93b1eb625132b218aee1119a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: relax a condition so DUID can be inherited again

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: relax a condition so DUID can be inherited again
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: relax a condition so DUID can be inherited again

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: network: relax a condition so DUID can be inherited again
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/54130/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 515: return
Line 516: 
Line 517: for devices in (_netinfo.nics, _netinfo.bondings, _netinfo.vlans):
Line 518: port = devices.get(bridge.port.name)
Line 519: if port:
> the condition would be clearer as
Done
Line 520: bridge.duid_source = bridge.port.name
Line 521: break
Line 522: 
Line 523: 


-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hotplugDisk: Handle prepareVolumePath errors gracefully.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hotplugDisk: Handle prepareVolumePath errors gracefully.
..


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/54266/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 28: import os
Line 29: import tempfile
Line 30: import threading
Line 31: import time
Line 32: import traceback
Not needed
Line 33: import uuid
Line 34: import xml.etree.ElementTree as ET
Line 35: 
Line 36: # 3rd party libs imports


Line 2650: diskParams = params.get('drive', {})
Line 2651: try:
Line 2652: diskParams['path'] = 
self.cif.prepareVolumePath(diskParams)
Line 2653: except VolumeError as e:
Line 2654: self.log.error(traceback.format_exc())
Use self.log.exception("description ...")
Line 2655: return response.error(
Line 2656: 'hotplugDisk',
Line 2657: "Preparing path during hotplug disk failed: %s" % e)
Line 2658: 


Line 2653: except VolumeError as e:
Line 2654: self.log.error(traceback.format_exc())
Line 2655: return response.error(
Line 2656: 'hotplugDisk',
Line 2657: "Preparing path during hotplug disk failed: %s" % e)
I think that "Cannot prepare path: %s" is better.

You get this error in hotplug flow, and you return hotplugDisk error, so there 
is need to repeat the info in the error message.
Line 2658: 
Line 2659: if isVdsmImage(diskParams):
Line 2660: self._normalizeVdsmImg(diskParams)
Line 2661: self._createTransientDisk(diskParams)


-- 
To view, visit https://gerrit.ovirt.org/54266
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic049f388eb25127864edf5931ddb3b21b67f2dff
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: periodic: disable on migration destination

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: periodic: disable on migration destination
..


Patch Set 11:

* #1299480::Update tracker: OK
* Set MODIFIED::bug 1299480#1299480IGNORE, not all related patches are 
closed, check 53056

-- 
To view, visit https://gerrit.ovirt.org/53539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id27d3524e1d183e9db4e6bfe55873900b41fd4c7
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: periodic: disable on migration destination

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: periodic: disable on migration destination
..


virt: periodic: disable on migration destination

While a VM is migration destination, the periodic
operations should not run - the VM is still on source side,
and the source side should handle the housekeeping.

We should start doing the operations on destination side
when and if the VM succesfully migrated.

Previously, we didn't made this explicit out of concern
of hiding real bugs.
This concern is more and more less grounded, while log
spam (all false positives) is becoming a problem, so
we have reached a tipping point. Hence this patch.

Change-Id: Id27d3524e1d183e9db4e6bfe55873900b41fd4c7
Bug-Url: https://bugzilla.redhat.com/1299480
Backport-To: 3.6
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/53539
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M vdsm/virt/periodic.py
1 file changed, 15 insertions(+), 6 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/53539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id27d3524e1d183e9db4e6bfe55873900b41fd4c7
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: periodic: disable on migration destination

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: virt: periodic: disable on migration destination
..


Patch Set 10: Code-Review+2

same non-idea here. copying.

-- 
To view, visit https://gerrit.ovirt.org/53539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id27d3524e1d183e9db4e6bfe55873900b41fd4c7
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: start moving under site-packages

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: start moving under site-packages
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/53958
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8628666a97a87e194c2f85d3be03934d0f7fa1c3
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: start moving under site-packages

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: start moving under site-packages
..


virt: start moving under site-packages

Let's start moving virt code under site-packages.
We start with the leaf node of the dependency tree,
the virt-specific utility modules.

As nice side effect, these modules are mostly
stable and seldom changes, so once we get the
import and build system right, we are done with the move.

Change-Id: I8628666a97a87e194c2f85d3be03934d0f7fa1c3
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/53958
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M configure.ac
M debian/vdsm-python.install
M debian/vdsm.install
M lib/vdsm/Makefile.am
C lib/vdsm/virt/Makefile.am
C lib/vdsm/virt/__init__.py
R lib/vdsm/virt/secret.py
R lib/vdsm/virt/utils.py
R lib/vdsm/virt/virdomain.py
R lib/vdsm/virt/vmexitreason.py
R lib/vdsm/virt/vmpowerdown.py
R lib/vdsm/virt/vmstatus.py
M tests/functional/storageTests.py
M tests/functional/virtTests.py
M tests/functional/vmRecoveryTests.py
M tests/periodicTests.py
M tests/vmApiTests.py
M tests/vmOperationsTests.py
M tests/vmSecretTests.py
M tests/vmTests.py
M tests/vmUtilsTests.py
M vdsm.spec.in
M vdsm/API.py
M vdsm/clientIF.py
M vdsm/virt/Makefile.am
M vdsm/virt/guestagent.py
M vdsm/virt/migration.py
M vdsm/virt/periodic.py
M vdsm/virt/recovery.py
M vdsm/virt/sampling.py
M vdsm/virt/vm.py
M vdsm/virt/vmdevices/core.py
M vdsm/virt/vmstats.py
33 files changed, 71 insertions(+), 81 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/53958
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8628666a97a87e194c2f85d3be03934d0f7fa1c3
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: start moving under site-packages

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: virt: start moving under site-packages
..


Patch Set 11: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/53958
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8628666a97a87e194c2f85d3be03934d0f7fa1c3
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netconfpersistence: bondings are not removed if there are no...

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: netconfpersistence: bondings are not removed if there are no 
nets
..


netconfpersistence: bondings are not removed if there are no nets

/var/run/vdsm/netconf/nets directory is created when the first network
is configured. The same for /var/run/vdsm/netconf/bonds.

In case when there is only bonds directory, network restoration fails
with ENOENT when it's trying to open nets dir.

Now we do removal of nets and bonds in two separate try/except blocks.

Change-Id: Ic189d19f5a1dbef4982391aefb9591a78cd1c891
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/54262
Reviewed-by: Edward Haas 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/netconfpersistence.py
1 file changed, 14 insertions(+), 12 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/54262
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic189d19f5a1dbef4982391aefb9591a78cd1c891
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netconfpersistence: bondings are not removed if there are no...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: netconfpersistence: bondings are not removed if there are no 
nets
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/54262
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic189d19f5a1dbef4982391aefb9591a78cd1c891
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netconfpersistence: bondings are not removed if there are no...

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: netconfpersistence: bondings are not removed if there are no 
nets
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54262
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic189d19f5a1dbef4982391aefb9591a78cd1c891
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Removing 'link' scoped addresses from the ip address list

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: Removing 'link' scoped addresses from the ip address list
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/54211
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8bbee8deebdfc617bc82f811e8a20e4db11ebb5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6.3]: net: Adjust the parsing of multiline tc error

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: Adjust the parsing of multiline tc error
..


Patch Set 1: Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/54237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I337aa1722ce72fef598565b00cd7a8935d64f171
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6.3
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6.3]: net: Adjust the parsing of multiline tc error

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: Adjust the parsing of multiline tc error
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I337aa1722ce72fef598565b00cd7a8935d64f171
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6.3
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: net: Adjust the parsing of multiline tc error

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: Adjust the parsing of multiline tc error
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54236
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I337aa1722ce72fef598565b00cd7a8935d64f171
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: restore-nets: disable IPv6 based on ifcfg files

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: restore-nets: disable IPv6 based on ifcfg files
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/54226
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3010e4a163cb8b7622b3b7425fa8fca09d602c7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: relax a condition so DUID can be inherited again

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: network: relax a condition so DUID can be inherited again
..


Patch Set 1: Code-Review-1

(1 comment)

nit

https://gerrit.ovirt.org/#/c/54130/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 515: return
Line 516: 
Line 517: for devices in (_netinfo.nics, _netinfo.bondings, _netinfo.vlans):
Line 518: port = devices.get(bridge.port.name)
Line 519: if port:
the condition would be clearer as

  if bridge.port.name in devices:

no need for the temporary variable any more.
Line 520: bridge.duid_source = bridge.port.name
Line 521: break
Line 522: 
Line 523: 


-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Removing 'link' scoped addresses from the ip address list

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Removing 'link' scoped addresses from the ip address list
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54211
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8bbee8deebdfc617bc82f811e8a20e4db11ebb5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Removing 'link' scoped addresses from the ip address list

[mmirecki]

Marcin Mirecki has posted comments on this change.

Change subject: net: Removing 'link' scoped addresses from the ip address list
..


Patch Set 2:

(3 comments)

https://gerrit.ovirt.org/#/c/54211/2/tests/network/netinfo_test.py
File tests/network/netinfo_test.py:

Line 319: """filter away ipv6 link local addresses that may or may 
not exist
Line 320: on the device depending on OS configuration"""
Line 321: ipv4addr, ipv4netmask, ipv4addrs, ipv6addrs = \
Line 322: addresses.getIpInfo(*a, **kw)
Line 323: ipv6addrs = [
> heh, without the dropped condition, this is a NO-OP.
Done
Line 324: addr for addr in ipv6addrs]
Line 325: return ipv4addr, ipv4netmask, ipv4addrs, ipv6addrs
Line 326: 
Line 327: IP_ADDR = '192.0.2.2'


Line 320: on the device depending on OS configuration"""
Line 321: ipv4addr, ipv4netmask, ipv4addrs, ipv6addrs = \
Line 322: addresses.getIpInfo(*a, **kw)
Line 323: ipv6addrs = [
Line 324: addr for addr in ipv6addrs]
> .. unless I'm mistaken, and this code is still needed to filter-out the ipv
Looking deeper into what is happening inside, we only check against:
linklocal_network = IPv4Network('169.254.0.0/16')
linklocal_network = IPv6Network('fe80::/10')
So it looks like we can remove this too.
Line 325: return ipv4addr, ipv4netmask, ipv4addrs, ipv6addrs
Line 326: 
Line 327: IP_ADDR = '192.0.2.2'
Line 328: IP_ADDR_SECOND = '192.0.2.3'


Line 368: test_drop_link_addr
> link addr is another name for a mac, better use some other name. 
Done


-- 
To view, visit https://gerrit.ovirt.org/54211
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8bbee8deebdfc617bc82f811e8a20e4db11ebb5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: restore-nets: disable IPv6 based on ifcfg files

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: restore-nets: disable IPv6 based on ifcfg files
..


Patch Set 4: Verified+1

I let _restore_disable_ipv6 add IPv6 addresses and lose them a few moments 
later.

import os
os.system('ip addr add 1234::5678 dev enp0s3')
os.system('ip addr add 2345::6789 dev ovirtmgmt')

restore-net::INFO::2016-03-02 
17:06:26,154::vdsm-restore-net-config::276::root::(_find_changed_or_missing) 
ovirtmgmt was not changed since last time it was persisted, skipping 
restoration.

-- 
To view, visit https://gerrit.ovirt.org/54226
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3010e4a163cb8b7622b3b7425fa8fca09d602c7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: restore-nets: disable IPv6 based on ifcfg files

[automation]

gerrit-hooks has posted comments on this change.

Change subject: restore-nets: disable IPv6 based on ifcfg files
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54226
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3010e4a163cb8b7622b3b7425fa8fca09d602c7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: imagetickets: add tests

[aaviram]

Amit Aviram has posted comments on this change.

Change subject: imagetickets: add tests
..


Patch Set 12: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2728851a91529ec35501f423d9a798af961fb82a
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vmstats: do not report bogus stats values.

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: vmstats: do not report bogus stats values.
..


Patch Set 2: Code-Review-1

this may hide an underlying bug

-- 
To view, visit https://gerrit.ovirt.org/53966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c402c954a732848b1a64f5d719c96778895ea2c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hotplugDisk: Handle prepareVolumePath errors gracefully.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hotplugDisk: Handle prepareVolumePath errors gracefully.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54266
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic049f388eb25127864edf5931ddb3b21b67f2dff
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hotplugDisk: Handle prepareVolumePath errors gracefully.

[aaviram]

Amit Aviram has uploaded a new change for review.

Change subject: hotplugDisk: Handle prepareVolumePath errors gracefully.
..

hotplugDisk: Handle prepareVolumePath errors gracefully.

While hotplugging a disk, a call is being made to prepareVolumePath
which prepares the image and builds a path to the volume.

Naturally, this flow can raise errors in some scenarios, e.g when the
storage is unreachable.

This patch makes hotplugDisk to handle errors thrown from prepareVolumePath
so that the user will recieve a hotplug related error, and logs the relevant
information from that error.

Related Bug-Url: https://bugzilla.redhat.com/1311465
Change-Id: Ic049f388eb25127864edf5931ddb3b21b67f2dff
Signed-off-by: Amit Aviram 
---
M vdsm/virt/vm.py
1 file changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/54266/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index c12d50d..d126a9a 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -29,6 +29,7 @@
 import tempfile
 import threading
 import time
+import traceback
 import uuid
 import xml.etree.ElementTree as ET
 
@@ -2647,7 +2648,13 @@
 return response.error('migInProgress')
 
 diskParams = params.get('drive', {})
-diskParams['path'] = self.cif.prepareVolumePath(diskParams)
+try:
+diskParams['path'] = self.cif.prepareVolumePath(diskParams)
+except VolumeError as e:
+self.log.error(traceback.format_exc())
+return response.error(
+'hotplugDisk',
+"Preparing path during hotplug disk failed: %s" % e)
 
 if isVdsmImage(diskParams):
 self._normalizeVdsmImg(diskParams)


-- 
To view, visit https://gerrit.ovirt.org/54266
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic049f388eb25127864edf5931ddb3b21b67f2dff
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netconfpersistence: bondings are not removed if there are no...

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: netconfpersistence: bondings are not removed if there are no 
nets
..


Patch Set 3: Verified+1

Passed network tests OK.

Right after VDSM installation i ran 
testSetupNetworksConnectivityCheckOverExistingBond() which used to fail on a 
clean installation. Passed OK

-- 
To view, visit https://gerrit.ovirt.org/54262
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic189d19f5a1dbef4982391aefb9591a78cd1c891
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: ifcfg: use unified rollback

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: ifcfg: use unified rollback
..


Patch Set 4:

It works pretty well. The only problem is, that when i skip ifcfg files and 
libvirt configuration backuping, testSelectiveRestoreDuringUpgrade() fails.

I don't know whether it is needed for network restoration, but i think it 
should not.

-- 
To view, visit https://gerrit.ovirt.org/54217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b0f8891eaf97648ea7fbde4e7d5cc855ce157e6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: ifcfg: use unified rollback

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: ifcfg: use unified rollback
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b0f8891eaf97648ea7fbde4e7d5cc855ce157e6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netconfpersistence: bondings are not removed if there are no...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: netconfpersistence: bondings are not removed if there are no 
nets
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54262
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic189d19f5a1dbef4982391aefb9591a78cd1c891
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: api: move legacy network handling to a separate module

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: api: move legacy network handling to a separate module
..


net: api: move legacy network handling to a separate module

It makes sense to legacy network setup logic and native
linux networking related code in two separate modules.

Change-Id: I318df0fcf061322d8337465d9248b90dcec3db59
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/54097
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas 
Reviewed-by: Dan Kenigsberg 
---
M debian/vdsm.install
M lib/vdsm/network/Makefile.am
M lib/vdsm/network/api.py
A lib/vdsm/network/legacy_switch.py
M tests/functional/networkTests.py
M tests/network/config_network_test.py
M vdsm.spec.in
7 files changed, 693 insertions(+), 651 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/54097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I318df0fcf061322d8337465d9248b90dcec3db59
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: api: move legacy network handling to a separate module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: api: move legacy network handling to a separate module
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/54097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I318df0fcf061322d8337465d9248b90dcec3db59
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: api: move legacy network handling to a separate module

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: api: move legacy network handling to a separate module
..


Patch Set 14: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/54097/14/lib/vdsm/network/legacy_switch.py
File lib/vdsm/network/legacy_switch.py:

Line 63: s
not even funny


-- 
To view, visit https://gerrit.ovirt.org/54097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I318df0fcf061322d8337465d9248b90dcec3db59
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netconfpersistence: bondings are not removed if there are no...

[edwardh]

Edward Haas has posted comments on this change.

Change subject: netconfpersistence: bondings are not removed if there are no 
nets
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/54262
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic189d19f5a1dbef4982391aefb9591a78cd1c891
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Removing cfg entry from get capabilities

[mmirecki]

Marcin Mirecki has posted comments on this change.

Change subject: net: Removing cfg entry from get capabilities
..


Patch Set 3:

ovirt-hosted-engine-setup will be adapting to our changes:
https://bugzilla.redhat.com/show_bug.cgi?id=1313881

-- 
To view, visit https://gerrit.ovirt.org/53746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71742512e82f6009c4d1a50e7122c18a6961a908
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: caps/numa: move autonuma status to sitelib

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: caps/numa: move autonuma status to sitelib
..


caps/numa: move autonuma status to sitelib

Since autonuma is heavily related to numa and the code doesn't have any
external dependencies, let's add it to our numa library. Constants
indicating autonuma status are exposed publicly should future code depend
on them.

Change-Id: I42e7eae743d319b0afd9653a9d6f1f2701856ca9
Signed-off-by: Martin Polednik 
Reviewed-on: https://gerrit.ovirt.org/54166
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
---
M lib/vdsm/numa.py
M tests/capsTests.py
M vdsm/caps.py
3 files changed, 39 insertions(+), 22 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Martin Polednik: Verified



-- 
To view, visit https://gerrit.ovirt.org/54166
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I42e7eae743d319b0afd9653a9d6f1f2701856ca9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: caps/numa: move autonuma status to sitelib

[automation]

gerrit-hooks has posted comments on this change.

Change subject: caps/numa: move autonuma status to sitelib
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/54166
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42e7eae743d319b0afd9653a9d6f1f2701856ca9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vmstats: reformat function to make pep8 friendly

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vmstats: reformat function to make pep8 friendly
..


vmstats: reformat function to make pep8 friendly

Only cosmetic changes.

Change-Id: Ib87d429d2449eec04528958a842cdb6d8e00e51f
Signed-off-by: Francesco Romani 
Backport-To: 3.6
Reviewed-on: https://gerrit.ovirt.org/54246
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M vdsm/virt/vmstats.py
1 file changed, 25 insertions(+), 23 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/54246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib87d429d2449eec04528958a842cdb6d8e00e51f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vmstats: reformat function to make pep8 friendly

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: vmstats: reformat function to make pep8 friendly
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib87d429d2449eec04528958a842cdb6d8e00e51f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: extract destroyVm helper

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: extract destroyVm helper
..


Patch Set 3:

* #1309884::Update tracker: OK
* Set MODIFIED::bug 1309884#1309884IGNORE, not oVirt classification but 
Red Hat

-- 
To view, visit https://gerrit.ovirt.org/53932
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id152a7aae3d4f644f34703f7f0b5f98035e4e295
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: extract destroyVm helper

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: extract destroyVm helper
..


virt: extract destroyVm helper

It is generally not safe to force the destruction
(really: shutdown) of a VM. There are few known cases
on which we believe it is safe despite a previous
failure of destroyVmGraceful().

This patch adds an utility method to encapsulate
force-shutdown-afeter-known-safe-error logic,
previously found in destroyVmGraceful().

No changes in external behaviour.

Change-Id: Id152a7aae3d4f644f34703f7f0b5f98035e4e295
Bug-Url: https://bugzilla.redhat.com/1309884
Backport-To: 3.6
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/53932
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Jenkins CI
---
M vdsm/virt/vm.py
1 file changed, 11 insertions(+), 4 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/53932
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id152a7aae3d4f644f34703f7f0b5f98035e4e295
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP: lib: clientIF: move vmContainer away

[automation]

gerrit-hooks has posted comments on this change.

Change subject: WIP: lib: clientIF: move vmContainer away
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53101
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacd2ae6c5e9ca6a73c0fed978c78c9ebb001c46d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP: lib: clientIF: move vmContainer away

[fromani]

Francesco Romani has posted comments on this change.

Change subject: WIP: lib: clientIF: move vmContainer away
..


Patch Set 3:

(3 comments)

https://gerrit.ovirt.org/#/c/53101/3/lib/vdsm/vmdict.py
File lib/vdsm/vmdict.py:

Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  
02110-1301 USA
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: 
> please move to the new lib.vdsm.virt  package
Sure, as soon as https://gerrit.ovirt.org/#/c/53958/ is merged :)
Line 21: from __future__ import absolute_import
Line 22: 
Line 23: import logging
Line 24: import threading


Line 88: if sdUUID in vm_obj.sdIds:
Line 89: _log.info("Cont vm %s in EIO", vm_id)
Line 90: vm_obj.cont()
Line 91: 
Line 92: 
> consider @traceback
Done
Line 93: def on_libvirt_event(conn, dom, *args):
Line 94: vmid = dom.UUIDString()
Line 95: with _lock:
Line 96: if vmid in _vms:


Line 89: _log.info("Cont vm %s in EIO", vm_id)
Line 90: vm_obj.cont()
Line 91: 
Line 92: 
Line 93: def on_libvirt_event(conn, dom, *args):
> please add tests for this function (and module)
still pending
Line 94: vmid = dom.UUIDString()
Line 95: with _lock:
Line 96: if vmid in _vms:
Line 97: v = _vms[vmid]


-- 
To view, visit https://gerrit.ovirt.org/53101
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacd2ae6c5e9ca6a73c0fed978c78c9ebb001c46d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netconfpersistence: bondings are not removed if there are no...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: netconfpersistence: bondings are not removed if there are no 
nets
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54262
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic189d19f5a1dbef4982391aefb9591a78cd1c891
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netconfpersistence: bondings are not removed if there are no...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: netconfpersistence: bondings are not removed if there are no 
nets
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54262
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic189d19f5a1dbef4982391aefb9591a78cd1c891
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netconfpersistence: bondings are not removed if there are no...

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: netconfpersistence: bondings are not removed if there are no 
nets
..

netconfpersistence: bondings are not removed if there are no nets

/var/run/vdsm/netconf/nets directory is created when the first network
is configured. The same for /var/run/vdsm/netconf/bonds.

In case when there is only bonds directory, network restoration fails
with ENOENT when it's trying to open nets dir.

Now we do removal of nets and bonds in two separate try/except blocks.

Change-Id: Ic189d19f5a1dbef4982391aefb9591a78cd1c891
Signed-off-by: Petr Horáček 
---
M lib/vdsm/netconfpersistence.py
1 file changed, 14 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/54262/1

diff --git a/lib/vdsm/netconfpersistence.py b/lib/vdsm/netconfpersistence.py
index 9099699..8aaa0ba 100644
--- a/lib/vdsm/netconfpersistence.py
+++ b/lib/vdsm/netconfpersistence.py
@@ -179,19 +179,21 @@
 utils.rmFile(path)
 
 def _clearDisk(self):
-try:
-logging.info('Clearing %s and %s', self.networksPath,
- self.bondingsPath)
-for filePath in os.listdir(self.networksPath):
-self._removeConfig(self.networksPath + filePath)
+def _clear_dir(path_to_dir):
+try:
+for filePath in os.listdir(path_to_dir):
+self._removeConfig(path_to_dir + filePath)
+except OSError as ose:
+if ose.errno == errno.ENOENT:
+logging.debug('No existing config to clear on %s' %
+  path_to_dir)
+else:
+raise
 
-for filePath in os.listdir(self.bondingsPath):
-self._removeConfig(self.bondingsPath + filePath)
-except OSError as ose:
-if ose.errno == errno.ENOENT:
-logging.debug('No existent config to clear.')
-else:
-raise
+logging.info('Clearing %s and %s', self.networksPath,
+ self.bondingsPath)
+_clear_dir(self.networksPath)
+_clear_dir(self.bondingsPath)
 
 
 class RunningConfig(Config):


-- 
To view, visit https://gerrit.ovirt.org/54262
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic189d19f5a1dbef4982391aefb9591a78cd1c891
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: extract destroyVm helper

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: extract destroyVm helper
..


Patch Set 2:

re-verified as before.

-- 
To view, visit https://gerrit.ovirt.org/53932
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id152a7aae3d4f644f34703f7f0b5f98035e4e295
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: ifcfg: use unified rollback

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: ifcfg: use unified rollback
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b0f8891eaf97648ea7fbde4e7d5cc855ce157e6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vmstats: reformat function to make pep8 friendly

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmstats: reformat function to make pep8 friendly
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib87d429d2449eec04528958a842cdb6d8e00e51f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vmstats: avoid NameError

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmstats: avoid NameError
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35d6db82941f1a8f4c59b23df96b00be73814579
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vmstats: reorder the calculations

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmstats: reorder the calculations
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54248
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6875ca2e55ac107498ee130062c665749f7f5b60
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vmstats: do not report bogus stats values.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: vmstats: do not report bogus stats values.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c402c954a732848b1a64f5d719c96778895ea2c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: testlib: use arch from lib

[fromani]

Francesco Romani has posted comments on this change.

Change subject: testlib: use arch from lib
..


Patch Set 11:

please don't forget about the comments about the new code

-- 
To view, visit https://gerrit.ovirt.org/49973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I929b9258867377900fe161889465987ab44a6bc6
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: restore-nets: disable IPv6 based on ifcfg files

[automation]

gerrit-hooks has posted comments on this change.

Change subject: restore-nets: disable IPv6 based on ifcfg files
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54226
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3010e4a163cb8b7622b3b7425fa8fca09d602c7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: restore-nets: disable IPv6 based on ifcfg files

[automation]

gerrit-hooks has posted comments on this change.

Change subject: restore-nets: disable IPv6 based on ifcfg files
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54226
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3010e4a163cb8b7622b3b7425fa8fca09d602c7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: faqemu: refactor and update

[automation]

gerrit-hooks has posted comments on this change.

Change subject: faqemu: refactor and update
..


Patch Set 24:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/46961
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb82b492e33d507e198901f7ecc77531b0680711
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: ifcfg: use unified rollback

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: ifcfg: use unified rollback
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b0f8891eaf97648ea7fbde4e7d5cc855ce157e6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vmstats: reformat function to make pep8 friendly

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vmstats: reformat function to make pep8 friendly
..


Patch Set 2: Verified+1

format-only patch. verified by tests, including the one added in 54247

-- 
To view, visit https://gerrit.ovirt.org/54246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib87d429d2449eec04528958a842cdb6d8e00e51f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: api: move legacy network handling to a separate module

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: api: move legacy network handling to a separate module
..


Patch Set 13:

(2 comments)

https://gerrit.ovirt.org/#/c/54097/13/lib/vdsm/network/legacy_switch.py
File lib/vdsm/network/legacy_switch.py:

> aha, i was thinking about NetSwitch as a format for switches (OVS_switch, l
handle, tool, util, process verbs are big, heavy and say nothing informative... 
so I try to avoid them.

Dan mentioned that netswitch calling *_switch is ok.
Future netswitch should do switching between switch types and the switch type 
should do switching between its configurators.
Line 1: # Copyright 2011-2015 Red Hat, Inc.
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by


https://gerrit.ovirt.org/#/c/54097/13/tests/functional/networkTests.py
File tests/functional/networkTests.py:

> And OVS specific.
Not sure I understand how separated files can increase the chance someone will 
break something..
To reduce the risk of breaking things, we should try to convert tests to switch 
agnostic, such that the assert will be done per the switch type, not the high 
level logic.

BTW: I dislike the Skip test thing in general :) We run the test and we control 
the env, all switches should be available.
Line 1: #
Line 2: # Copyright 2013-2016 Red Hat, Inc.
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by


-- 
To view, visit https://gerrit.ovirt.org/54097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I318df0fcf061322d8337465d9248b90dcec3db59
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: api: move legacy network handling to a separate module

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: api: move legacy network handling to a separate module
..


Patch Set 14: Verified+1

Passed network tests OK

-- 
To view, visit https://gerrit.ovirt.org/54097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I318df0fcf061322d8337465d9248b90dcec3db59
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: periodic: disable on migration destination

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: periodic: disable on migration destination
..


Patch Set 10: Verified+1

just rebased, not sure why score was lost. Copying mine.

-- 
To view, visit https://gerrit.ovirt.org/53539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id27d3524e1d183e9db4e6bfe55873900b41fd4c7
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED

[automation]

gerrit-hooks has posted comments on this change.

Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
..


Patch Set 13:

* #1299480::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1299480::OK, public bug
* Check Product::#1299480::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53056
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: periodic: disable on migration destination

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: periodic: disable on migration destination
..


Patch Set 10:

* #1299480::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1299480::OK, public bug
* Check Product::#1299480::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id27d3524e1d183e9db4e6bfe55873900b41fd4c7
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: periodic: disable on migration destination

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: periodic: disable on migration destination
..


Patch Set 9:

Verified
- took a couple of hosts, make sampling crazy frequent (numa, high water mark 
and bulk sampling every second)
- migrating VM back and forth a few times
everything seems OK

-- 
To view, visit https://gerrit.ovirt.org/53539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id27d3524e1d183e9db4e6bfe55873900b41fd4c7
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: periodic: disable on migration destination

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: periodic: disable on migration destination
..


Patch Set 9: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/53539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id27d3524e1d183e9db4e6bfe55873900b41fd4c7
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: canonicalize defaultRoute as a boolean

[edwardh]

Edward Haas has posted comments on this change.

Change subject: network: canonicalize defaultRoute as a boolean
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/54235/2/lib/vdsm/network/canonize.py
File lib/vdsm/network/canonize.py:

Line 47: canonicalize
> Yes, "canonicalize" bears the intended meaning (normalize), as in "trailing
Cool, please follow up on this.
Also the file name needs to change.

I would prefer to see the change before this patch... to keep consistency.


Line 91: if 'dhcpv6' not in data:
Line 92: data['dhcpv6'] = False
Line 93: 
Line 94: 
Line 95: def _canonicalize_default_route(data):
> This broke testInit in conf_persistence_test because it added 'defaultRoute
But the whole point of this canonicalize step is to avoid 'defaults' later on.
We did the same with all the others.
We should fix the tests in a way that makes sense, adding to NETWORK_ATTRIBUTES 
seems ok to me.

We just need to be careful with backward compatability (when the value is not 
set in the persistent files, we should still have a default placed for 
compatibility: It should appear on one place usually)
Line 96: default_route = data.get('defaultRoute')
Line 97: if default_route is not None:


-- 
To view, visit https://gerrit.ovirt.org/54235
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9315c7facc874e8e6f82502ee83ef0f858f1fa1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vmstats: avoid NameError

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: vmstats: avoid NameError
..


Patch Set 3:

I like the addition of a test. One question is still in the open for me: 
couldn't we return from the function earlier? e.g.

1) try to work with the keys
2) if keys are present, process and return; else 3
3) return empty stats (or whatever is currently returned)

I know it may get a bit tricky with a decorator, but I'm still interested in 
your opinion. +1 when I get my answer. :)

-- 
To view, visit https://gerrit.ovirt.org/54247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35d6db82941f1a8f4c59b23df96b00be73814579
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Removing cfg entry from get capabilities

[mmirecki]

Marcin Mirecki has posted comments on this change.

Change subject: net: Removing cfg entry from get capabilities
..


Patch Set 3: Code-Review-1

-- 
To view, visit https://gerrit.ovirt.org/53746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71742512e82f6009c4d1a50e7122c18a6961a908
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: canonicalize defaultRoute as a boolean

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: network: canonicalize defaultRoute as a boolean
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/54235/2/lib/vdsm/network/canonize.py
File lib/vdsm/network/canonize.py:

Line 47: canonicalize
> Any special reason you used a different prefix?
Yes, "canonicalize" bears the intended meaning (normalize), as in "trailing 
slash also allows you to canonicalize your URLs" [enTenTen12 corpus] while 
"canonize" is often found in contexts such as "Pope John Paul II canonized the 
recently deceased" [the same source].

Wiktionary says about canonize: "Not to be confused with canonize, to add 
(e.g.) a person or rule to the canon."

I could follow up by renaming the rest.


Line 91: if 'dhcpv6' not in data:
Line 92: data['dhcpv6'] = False
Line 93: 
Line 94: 
Line 95: def _canonicalize_default_route(data):
> We better set the default here:
This broke testInit in conf_persistence_test because it added 'defaultRoute' 
where it was not expected (persistence.networks[NETWORK]).

We don't want to add it to the dictionary but we are perfectly okay with None 
later in the API.
Line 96: default_route = data.get('defaultRoute')
Line 97: if default_route is not None:


-- 
To view, visit https://gerrit.ovirt.org/54235
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9315c7facc874e8e6f82502ee83ef0f858f1fa1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Removing cfg entry from get capabilities

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Removing cfg entry from get capabilities
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71742512e82f6009c4d1a50e7122c18a6961a908
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: start moving under site-packages

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: start moving under site-packages
..


Patch Set 11: Verified+1

copied score

-- 
To view, visit https://gerrit.ovirt.org/53958
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8628666a97a87e194c2f85d3be03934d0f7fa1c3
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: start moving under site-packages

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: start moving under site-packages
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53958
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8628666a97a87e194c2f85d3be03934d0f7fa1c3
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: restore-nets: move disable_ipv6 before setupNetworks, suppor...

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: restore-nets: move disable_ipv6 before setupNetworks, support 
bridgeless
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/54226/1/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:

Line 130: 
Line 131: _wait_for_for_all_devices_up(
Line 132: available_config.networks.keys() + 
available_config.bonds.keys())
Line 133: if ipv6_supported():
Line 134: _restore_disable_ipv6(available_config.networks)
I know that I suggested the config-based approach in the first place, but I am 
convinced that Edy's idea is simpler:

if ipv6_supported():
  for filename in owned_ifcfg_files:
dev = basename_etc(filename)
if not _ipv6_ifcfg(dev):
  disable_ipv6(dev)

However, I'd like to limit it to the unified restoration flow, since I'd like 
to keep the ifcfg flow untouched, as a quiet backup. So please keep it in this 
location.
Line 135: changed_config = _filter_changed_nets_bonds(available_config)
Line 136: nets = changed_config.networks
Line 137: bonds = changed_config.bonds
Line 138: if nets or bonds:


-- 
To view, visit https://gerrit.ovirt.org/54226
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3010e4a163cb8b7622b3b7425fa8fca09d602c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: caps/machinetype: move machine-type related code to new module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: caps/machinetype: move machine-type related code to new module
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7bf79c66a38329672e1fbd3fd41a94058803b58
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vmstats: avoid NameError

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmstats: avoid NameError
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35d6db82941f1a8f4c59b23df96b00be73814579
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vmstats: reorder the calculations

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmstats: reorder the calculations
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54248
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6875ca2e55ac107498ee130062c665749f7f5b60
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: vmstats: make _nic_traffic() more robust

[fromani]

Francesco Romani has abandoned this change.

Change subject: tests: vmstats: make _nic_traffic() more robust
..


Abandoned

squashed into 54247

-- 
To view, visit https://gerrit.ovirt.org/54255
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iaebda97530a642b55e7e17e2a7b5725a7f05453e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: vmstats: make _nic_traffic() more robust

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: vmstats: make _nic_traffic() more robust
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/54255
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaebda97530a642b55e7e17e2a7b5725a7f05453e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vmstats: reorder the calculations

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vmstats: reorder the calculations
..


Patch Set 2: Verified+1

trivial code move, jenkins verification is sufficient

-- 
To view, visit https://gerrit.ovirt.org/54248
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6875ca2e55ac107498ee130062c665749f7f5b60
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: api: move legacy network handling to a separate module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: api: move legacy network handling to a separate module
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I318df0fcf061322d8337465d9248b90dcec3db59
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: api: move native linux network handling to a separate m...

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: api: move native linux network handling to a separate 
module
..


Patch Set 13:

(11 comments)

https://gerrit.ovirt.org/#/c/54097/13//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-02-26 18:18:59 +0100
Line 4: Commit: Petr Horáček 
Line 5: CommitDate: 2016-03-01 14:41:24 +0100
Line 6: 
Line 7: net: api: move native linux network handling to a separate module
> nit: legacy
Done
Line 8: 
Line 9: It makes sense to divide general network setup logic and native
Line 10: linux networking related code in two separate modules.
Line 11: 


Line 5: CommitDate: 2016-03-01 14:41:24 +0100
Line 6: 
Line 7: net: api: move native linux network handling to a separate module
Line 8: 
Line 9: It makes sense to divide general network setup logic and native
> legacy
Done
Line 10: linux networking related code in two separate modules.
Line 11: 
Line 12: Change-Id: I318df0fcf061322d8337465d9248b90dcec3db59


https://gerrit.ovirt.org/#/c/54097/13/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 1: # Copyright 2011-2015 Red Hat, Inc.
> 6
Done
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by
Line 5: # the Free Software Foundation; either version 2 of the License, or


Line 29: from vdsm import commands
Line 30: from vdsm import constants
Line 31: from vdsm import hooks
Line 32: from vdsm import netconfpersistence
Line 33: from vdsm.netinfo import networks as netinfo_networks
> Below the next line.
Done
Line 34: from vdsm.netinfo.cache import (libvirtNets2vdsm, get as netinfo_get,
Line 35: CachingNetInfo)
Line 36: from vdsm import udevadm
Line 37: from vdsm import utils


Line 39: 
Line 40: from . canonize import canonize_networks
Line 41: from . import legacy_switch
Line 42: from .errors import ConfigNetworkError
Line 43: from . import errors as ne
> Above the previous line.
Done
Line 44: 
Line 45: CONNECTIVITY_TIMEOUT_DEFAULT = 4
Line 46: _SYSFS_SRIOV_NUMVFS = '/sys/bus/pci/devices/{}/sriov_numvfs'
Line 47: 


https://gerrit.ovirt.org/#/c/54097/13/lib/vdsm/network/legacy_switch.py
File lib/vdsm/network/legacy_switch.py:

> General nit question: We called the switch common layer 'netswitch', isn't 
aha, i was thinking about NetSwitch as a format for switches (OVS_switch, 
legacy_switch,...). but it does switching between network configurators.

any suggestion? switch and configurator are taken. maybe handler? (it's so 
vague)
Line 1: # Copyright 2011-2015 Red Hat, Inc.
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by


Line 1: # Copyright 2011-2015 Red Hat, Inc.
> 6
Done
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by
Line 5: # the Free Software Foundation; either version 2 of the License, or


Line 27: 
Line 28: from vdsm.config import config
Line 29: from vdsm import kernelconfig
Line 30: from vdsm import netconfpersistence
Line 31: from vdsm.netinfo import (addresses, bridges, mtus, nics as 
netinfo_nics,
> Modules should be imported separately.
Done
Line 32:   NET_PATH)
Line 33: from vdsm.netinfo.cache import CachingNetInfo
Line 34: from vdsm import utils
Line 35: from vdsm import ipwrapper


Line 31: from vdsm.netinfo import (addresses, bridges, mtus, nics as 
netinfo_nics,
Line 32:   NET_PATH)
Line 33: from vdsm.netinfo.cache import CachingNetInfo
Line 34: from vdsm import utils
Line 35: from vdsm import ipwrapper
> This belongs above netinfo.
Done
Line 36: 
Line 37: from .configurators import libvirt, dhclient
Line 38: from .models import Bond, Bridge, IPv4, IPv6, Nic, Vlan
Line 39: from .models import hierarchy_backing_device


Line 37: from .configurators import libvirt, dhclient
Line 38: from .models import Bond, Bridge, IPv4, IPv6, Nic, Vlan
Line 39: from .models import hierarchy_backing_device
Line 40: from .errors import ConfigNetworkError
Line 41: from . import errors as ne
> You can move these upwards :-)
Done
Line 42: 
Line 43: 
Line 44: def _getPersistenceModule():
Line 45: persistence = config.get('vars', 'net_persistence')


https://gerrit.ovirt.org/#/c/54097/13/tests/functional/networkTests.py
File tests/functional/networkTests.py:

> Looks like we have to separate tests here between legacy switch specific an
And OVS specific.

I think we should keep all of them in one file, if the netswitch is not 
available, skip the test. If it is a general test, run it twice with both 
netswitches.

The reason is, that if we move them to multiple files, someone can easily brake 
another netswitch without 

Change in vdsm[master]: tests: vmstats: make _nic_traffic() more robust

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: vmstats: make _nic_traffic() more robust
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54255
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaebda97530a642b55e7e17e2a7b5725a7f05453e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: vmstats: make _nic_traffic() more robust

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: tests: vmstats: make _nic_traffic() more robust
..

tests: vmstats: make _nic_traffic() more robust

vmstats._nic_traffic() should not blown up if one
bulk stats is missing, but, as usual with bulk stats,
should go ahead and gather as much data as possible.

This patch adds the tests to check this.

Change-Id: Iaebda97530a642b55e7e17e2a7b5725a7f05453e
Signed-off-by: Francesco Romani 
---
M tests/vmStatsTests.py
1 file changed, 28 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/54255/1

diff --git a/tests/vmStatsTests.py b/tests/vmStatsTests.py
index fcedeca..f718c52 100644
--- a/tests/vmStatsTests.py
+++ b/tests/vmStatsTests.py
@@ -370,6 +370,30 @@
  0) is None
 )
 
+@permutations([
+['net.0.rx.bytes'], ['net.0.rx.pkts'],
+['net.0.rx.errs'], ['net.0.rx.drop'], ['net.0.tx.bytes'],
+['net.0.tx.pkts'], ['net.0.tx.errs'], ['net.0.tx.drop'],
+])
+def test_networks_missing_key(self, key):
+nics = (
+FakeNic(name='vnet0', model='virtio',
+mac_addr='00:1a:4a:16:01:51'),
+)
+vm = FakeVM(nics=nics)
+vm.migrationPending = True
+
+faulty_bulk_stats = {}
+faulty_bulk_stats.update(self.bulk_stats)
+del faulty_bulk_stats[key]
+
+stats = {}
+self.assertTrue(
+vmstats.networks(vm, stats,
+ self.bulk_stats, faulty_bulk_stats,
+ 1)
+)
+
 
 class DiskStatsTests(VmStatsTestCase):
 
@@ -556,6 +580,10 @@
 self.id = str(uuid.uuid4())
 self.nics = nics if nics is not None else []
 self.drives = drives if drives is not None else []
+self.migrationPending = False
+
+def incomingMigrationPending(self):
+return self.migrationPending
 
 def getNicDevices(self):
 return self.nics


-- 
To view, visit https://gerrit.ovirt.org/54255
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaebda97530a642b55e7e17e2a7b5725a7f05453e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vmstats: avoid NameError

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmstats: avoid NameError
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35d6db82941f1a8f4c59b23df96b00be73814579
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vmstats: reformat function to make pep8 friendly

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmstats: reformat function to make pep8 friendly
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib87d429d2449eec04528958a842cdb6d8e00e51f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: periodic: ignore known-benign libvirt errors

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: periodic: ignore known-benign libvirt errors
..


periodic: ignore known-benign libvirt errors

periodic sampling threads and migration thread are
(and need to be) asynchronous with each other.
This leaves the door open for errors like

libvirtError: Domain not found: no domain with matching uuid
'7ebb5925-e76f-4d2f-a148-7671c313fe84' (v2)

Which are harmless but spam the logs.
We don't want to hide real errors, but we want to
avoid this noise, so this patch makes periodic Operation
ignore some of these errors, the ones which are easier
to detect.

Change-Id: Ifb5618f44870bdca97fa479734514a3c8d81c7d7
Bug-Url: https://bugzilla.redhat.com/1299480
Backport-To: 3.6
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/52884
Reviewed-by: Milan Zamazal 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/53999
---
M tests/periodicTests.py
M vdsm/virt/periodic.py
2 files changed, 60 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified; Looks good to me, approved
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/53999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb5618f44870bdca97fa479734514a3c8d81c7d7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches