Nir Soffer has posted comments on this change.
Change subject: tests: Add test for testing the timeout mechanism
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/58423
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Terminate watcher when tests fail
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/60239
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Enable tests watcher only if TIMEOUT set
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/60240
To unsubscribe, visit
Nir Soffer has uploaded a new change for review.
Change subject: tests: Enable tests watcher only if TIMEOUT set
..
tests: Enable tests watcher only if TIMEOUT set
When running tests locally we don't need the watcher; if tests
gerrit-hooks has posted comments on this change.
Change subject: tests: Terminate watcher when tests fail
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has submitted this change and it was merged.
Change subject: spbackends: Remove StoragePoolDiskBackend
..
spbackends: Remove StoragePoolDiskBackend
As VDSM no longer supports 3.4 clusters (see commit 23650fb),
Nir Soffer has posted comments on this change.
Change subject: spbackends: Remove StoragePoolDiskBackend
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55859
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: spbackends: Remove StoragePoolDiskBackend
..
Patch Set 9: Verified+1
Addressed Nir's comments on vdsm-api.yml
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: spbackends: Remove StoragePoolDiskBackend
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Allon Mureinik has posted comments on this change.
Change subject: spbackends: Remove StoragePoolDiskBackend
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/55859/8/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
gerrit-hooks has posted comments on this change.
Change subject: sp.py: Assume a hostId when reconstructing master
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Nir Soffer has submitted this change and it was merged.
Change subject: sp.py: Assume a hostId when reconstructing master
..
sp.py: Assume a hostId when reconstructing master
As we no longer support V1/V2 data domains, we can
Nir Soffer has posted comments on this change.
Change subject: tox: fail make process if required tox version isn't installed.
..
Patch Set 20:
(7 comments)
https://gerrit.ovirt.org/#/c/59306/20/Makefile.am
File Makefile.am:
Adam Litke has posted comments on this change.
Change subject: spbackends: Remove StoragePoolDiskBackend
..
Patch Set 8: Code-Review+1
Looks good after you address Nir's comment.
--
To view, visit
Adam Litke has posted comments on this change.
Change subject: sp.py: Assume a hostId when reconstructing master
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55857
To unsubscribe, visit
Nir Soffer has submitted this change and it was merged.
Change subject: infra: moved infra package from lib/vdsm/infra to
lib/vdsm/common
..
infra: moved infra package from lib/vdsm/infra to lib/vdsm/common
infra package was
Nir Soffer has posted comments on this change.
Change subject: spbackends: Remove StoragePoolDiskBackend
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/55859/8/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Line
Nir Soffer has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 10:
(4 comments)
Looks mostly good
https://gerrit.ovirt.org/#/c/52354/10//COMMIT_MSG
Commit Message:
Line
Nir Soffer has posted comments on this change.
Change subject: Using startCmd func for running async execution
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/60237/1/lib/vdsm/commands.py
File lib/vdsm/commands.py:
gerrit-hooks has posted comments on this change.
Change subject: Using startCmd func for running async execution
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Using startCmd func for running async execution
..
Using startCmd func for running async execution
Splitting execCmd and startCmd. execCmd still uses
Sandro Bonazzola has posted comments on this change.
Change subject: readme: Simplify installation instructions
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/48713/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7:
gerrit-hooks has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 17:
* #1344289::Update tracker: OK
* Set MODIFIED::bug 1344289#1344289IGNORE, not all
Nir Soffer has submitted this change and it was merged.
Change subject: verify_untrusted_volume: Check compatibility version
..
verify_untrusted_volume: Check compatibility version
When importing a volume using imaged, QCOW2
Nir Soffer has posted comments on this change.
Change subject: verify_untrusted_volume: Only allow compat designated by config
..
Patch Set 4: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/60113
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: verify_untrusted_volume: Only allow compat designated by config
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60113/1/vdsm/storage/hsm.py
File
gerrit-hooks has posted comments on this change.
Change subject: verify_untrusted_volume: Only allow compat designated by config
..
Patch Set 4:
* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Adam Litke has posted comments on this change.
Change subject: verify_untrusted_volume: Only allow compat designated by config
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60113/1/vdsm/storage/hsm.py
File
Nir Soffer has posted comments on this change.
Change subject: image: Add timing for copy volume operations
..
Patch Set 3:
Waiting for qa ack (they ask for this log)
--
To view, visit https://gerrit.ovirt.org/60164
To
Nir Soffer has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 16: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59411
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 16:
* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public
gerrit-hooks has posted comments on this change.
Change subject: verify_untrusted_volume: Only allow compat designated by config
..
Patch Set 3:
* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Adam Litke has posted comments on this change.
Change subject: Avoid creating unneeded images
..
Patch Set 1: Code-Review-2
We'll handle in the previous patch
--
To view, visit https://gerrit.ovirt.org/60231
To unsubscribe,
Adam Litke has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 15:
(2 comments)
https://gerrit.ovirt.org/#/c/59411/15/tests/storage_hsm_test.py
File
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Introduce supports_compat helper
..
Patch Set 14:
* #1344289::Update tracker: OK
* Set MODIFIED::bug 1344289#1344289IGNORE, not all related
Nir Soffer has submitted this change and it was merged.
Change subject: qemuimg: Introduce supports_compat helper
..
qemuimg: Introduce supports_compat helper
To enable checking if a qcow2 image has a supported compatibility
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Unbreak qmemuimg.check
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: Simple jsonrpc client
..
Patch Set 14: Verified+1
verified by running jsonrpc Host.getVMList
--
To view, visit https://gerrit.ovirt.org/35181
To
Nir Soffer has submitted this change and it was merged.
Change subject: qemuimg: Unbreak qmemuimg.check
..
qemuimg: Unbreak qmemuimg.check
Since commit 3e7a11954582 (qemuimg: Use --output json for 'check' and
'info')
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: simplified client
..
Patch Set 7: Verified+1
verified by running jsonrpc Host.getVMList
--
To view, visit https://gerrit.ovirt.org/59151
To
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 10: Verified+1
Verified by updating vdsm and starting new vm.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: verify_untrusted_volume: Only allow compat designated by config
..
Patch Set 2: Code-Review-1
See my comment on version 1:
Nir Soffer has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 15:
(2 comments)
https://gerrit.ovirt.org/#/c/59411/15/tests/storage_hsm_test.py
File
Adam Litke has posted comments on this change.
Change subject: image: Add timing for copy volume operations
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60164
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: qemuimg: Unbreak qmemuimg.check
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60168
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: contrib: Simple jsonrpc client
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 15:
* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public
Adam Litke has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 15: Verified+1
--
To view, visit https://gerrit.ovirt.org/59411
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: api: fixing default value for GlusterHost.createBrick
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60206
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: stomp: simplified client
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: contrib: Simple jsonrpc client
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: Simple jsonrpc client
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/35181/12//COMMIT_MSG
Commit Message:
Line 23:
Line 24: For
gerrit-hooks has posted comments on this change.
Change subject: contrib: Simple jsonrpc client
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: stomp: simplified client
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: wip: tests: change testing framework to pytest
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: Simple jsonrpc client
..
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/35181/11/contrib/jsonrpc
File contrib/jsonrpc:
Line 38:
Line 39:
Dan Kenigsberg has posted comments on this change.
Change subject: ovs hook: fix dhclient imports
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60154
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: wip: tests: change testing framework to pytest
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Irit Goihman has uploaded a new change for review.
Change subject: wip: tests: change testing framework to pytest
..
wip: tests: change testing framework to pytest
Change-Id: Ife527b9274c31a72b57da9b958a1dd2f9f1e5ea0
Irit Goihman has posted comments on this change.
Change subject: infra: moved infra package from lib/vdsm/infra to
lib/vdsm/common
..
Patch Set 10:
verified infra removal on fedora 23 and centos 7
--
To view, visit
Ramesh N has posted comments on this change.
Change subject: api: fixing default value for GlusterHost.createBrick
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/60206
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/constants.py.in
File
gerrit-hooks has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: draft patch - removing all deathsignal usages where calls are
async only to verify work with subprocess32
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url
Yaniv Bronhaim has uploaded a new change for review.
Change subject: draft patch - removing all deathsignal usages where calls are
async only to verify work with subprocess32
..
draft patch - removing all deathsignal usages
Dan Kenigsberg has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 7:
(2 comments)
(very partial review)
https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/constants.py.in
File
Dan Kenigsberg has posted comments on this change.
Change subject: contrib: Simple jsonrpc client
..
Patch Set 11: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/35181/11/contrib/jsonrpc
File contrib/jsonrpc:
Line
gerrit-hooks has posted comments on this change.
Change subject: api: fixing default value for GlusterHost.createBrick
..
Patch Set 2:
* #1352656::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1352656::OK, public
gerrit-hooks has posted comments on this change.
Change subject: api: fixing default value for GlusterHost.createBrick
..
Patch Set 1:
* #1352656::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1352656::OK, public
Ramesh N has uploaded a new change for review.
Change subject: api: fixing default value for GlusterHost.createBrick
..
api: fixing default value for GlusterHost.createBrick
Change default value for raidParamas to an empty dict
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/4//COMMIT_MSG
Commit Message:
Line 13: It would be
gerrit-hooks has posted comments on this change.
Change subject: tox: fail make process if required tox version isn't installed.
..
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
gerrit-hooks has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Amit Aviram has posted comments on this change.
Change subject: qemuimg: Introduce supports_compat helper
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59410
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: qemuimg: Unbreak qmemuimg.check
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60168
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: image: Add timing for copy volume operations
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60164
To unsubscribe, visit
79 matches
Mail list logo
