Nir Soffer has posted comments on this change.
Change subject: spec: Clean up fedora >= 23 conditions
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/61060/1/vdsm.spec.in
File vdsm.spec.in:
Line 192: #
Nir Soffer has submitted this change and it was merged.
Change subject: spec: Remove Fedora 22 libvirt requirement
..
spec: Remove Fedora 22 libvirt requirement
As Fedora 22 is End of Life [1], there no longer a need to
Nir Soffer has posted comments on this change.
Change subject: spec: Remove Fedora 22 libvirt requirement
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61059
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: spec: Remove Fedora 22 libvirt requirement
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Allon Mureinik has posted comments on this change.
Change subject: spec: Remove Fedora 22 libvirt requirement
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/61059
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: spec: Remove Fedora 22 libvirt requirement
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Allon Mureinik has uploaded a new change for review.
Change subject: spec: Remove Fedora 22 libvirt requirement
..
spec: Remove Fedora 22 libvirt requirement
As Fedora 22 is End of Life [1], there no longer a need to explicitly
gerrit-hooks has posted comments on this change.
Change subject: spec: Clean up fedora >= 23 conditions
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Allon Mureinik has uploaded a new change for review.
Change subject: spec: Clean up fedora >= 23 conditions
..
spec: Clean up fedora >= 23 conditions
As Fedora 22 is End of Life [1], any Fedora we support would be 23 or
newer,
Nir Soffer has posted comments on this change.
Change subject: network/sr-iov: use device teardown to reattach device
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/60667/6/vdsm/virt/vmdevices/network.py
File
Edward Haas has posted comments on this change.
Change subject: ovs: copy NIC hwaddr to NB
..
Patch Set 1: Code-Review-1
(2 comments)
Nice solution.
https://gerrit.ovirt.org/#/c/61049/1/lib/vdsm/network/netswitch.py
File
Nir Soffer has posted comments on this change.
Change subject: blockSD: Storage domain life cycle management
..
Patch Set 6: Code-Review-1
This version added infrastructure for domain life cycle tests, the tests are
still
gerrit-hooks has posted comments on this change.
Change subject: blockSD: Storage domain life cycle management
..
Patch Set 6:
* #1331978::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1331978::OK, public bug
*
Nir Soffer has posted comments on this change.
Change subject: blockSD: Storage domain life cycle management
..
Patch Set 5: Code-Review-1
Need to fix monitor tests
- FakeDomain must implement setup() and teardown()
- Add
gerrit-hooks has posted comments on this change.
Change subject: build: Proving that error_code job is useless
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: build: Proving that error_code job is useless
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: build: Proving that error_code job is useless
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has uploaded a new change for review.
Change subject: build: Proving that error_code job is useless
..
build: Proving that error_code job is useless
Adding new error to vdsm must pass the build. If this patch will
gerrit-hooks has posted comments on this change.
Change subject: blockSD: Storage domain life cycle management
..
Patch Set 5:
* #1331978::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1331978::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for file domain lookup
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: fileSD: Consider only mounted file domains
..
Patch Set 4:
* #1339245::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1339245::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: volume: Use StorageDomainManitest when possible
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: oop: Fix and simplify oop lifetime
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Move fake_mounts to storagefakelib
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has abandoned this change.
Change subject: oop: Fix ioprocess lifetime management
..
Abandoned
Replaced by
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:oop-per-mount
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: oop: Fix ioprocess lifetime management
..
Patch Set 9:
* #1334274::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/58607
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vdsm: Fix logging about threads during shutdown
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/61055
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vdsm: Fix logging about threads during shutdown
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: vdsm: Fix logging about threads during shutdown
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/61055
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vdsm: Fix logging about threads during shutdown
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/61055
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vdsm: Fix logging about threads during shutdown
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has uploaded a new change for review.
Change subject: vdsm: Fix logging about threads during shutdown
..
vdsm: Fix logging about threads during shutdown
We used to lie about waiting for threads during shutdown:
Adam Litke has posted comments on this change.
Change subject: sampling: Retrieve backing chain stats
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60888
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: Live Merge: Restore watermark tracking
..
Patch Set 3:
(6 comments)
https://gerrit.ovirt.org/#/c/60889/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS3, Line 928:
Nir Soffer has posted comments on this change.
Change subject: Adding report_stats to virt.stats
..
Patch Set 8: Code-Review-1
Keys format should be unified.
--
To view, visit https://gerrit.ovirt.org/59066
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: Adding report_stats to virt.stats
..
Patch Set 8:
(5 comments)
https://gerrit.ovirt.org/#/c/59066/8/lib/vdsm/virt/vmstats.py
File lib/vdsm/virt/vmstats.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: doc: Typo fixes and other doc improvements in periodic.py
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
Nir Soffer has submitted this change and it was merged.
Change subject: doc: Typo fixes and other doc improvements in periodic.py
..
doc: Typo fixes and other doc improvements in periodic.py
This is a documentation only change
Nir Soffer has posted comments on this change.
Change subject: oop: Explicitly close running ioprocesses
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/61050
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Use deathSignal param only if exists
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/61053
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: sampling: Retrieve backing chain stats
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60888/1/lib/vdsm/virt/vmstats.py
File lib/vdsm/virt/vmstats.py:
Nir Soffer has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 12:
Please check my comment in version 11
--
To view, visit https://gerrit.ovirt.org/60420
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: storagetestlib: qemu chain verification
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/60999/3/tests/storagetestlib.py
File
gerrit-hooks has posted comments on this change.
Change subject: Use deathSignal param only if exists
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has posted comments on this change.
Change subject: storagetestlib: qemu chain verification
..
Patch Set 3: Verified+1
(5 comments)
https://gerrit.ovirt.org/#/c/60999/2/tests/storagetestlib.py
File
gerrit-hooks has posted comments on this change.
Change subject: storagetestlib: qemu chain verification
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Nir Soffer has posted comments on this change.
Change subject: sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 7:
(5 comments)
https://gerrit.ovirt.org/#/c/60605/7/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Nir Soffer has posted comments on this change.
Change subject: sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/60605/6/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Line
Nir Soffer has posted comments on this change.
Change subject: storagetestlib: qemu chain verification
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/60999/2/tests/storagetestlib.py
File
Nir Soffer has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 11: Code-Review+1
(2 comments)
Nice!
https://gerrit.ovirt.org/#/c/60420/11/tests/storage_sdm_copy_data_test.py
File
Adam Litke has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 11: Verified+1
--
To view, visit https://gerrit.ovirt.org/60420
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has posted comments on this change.
Change subject: storagetestlib: qemu chain verification
..
Patch Set 2:
(5 comments)
https://gerrit.ovirt.org/#/c/60999/2/tests/storagetestlib.py
File tests/storagetestlib.py:
Nir Soffer has posted comments on this change.
Change subject: Use deathSignal param only if exists
..
Patch Set 1:
CI fails with this:
18:01:52 ./tests/deviceTests.py:458: undefined name 'graphics'
This should be fixed on
Nir Soffer has posted comments on this change.
Change subject: Use deathSignal param only if exists
..
Patch Set 1: Code-Review+2
Nice!
--
To view, visit https://gerrit.ovirt.org/61053
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: storagetestlib: qemu chain verification
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Adam Litke has posted comments on this change.
Change subject: storagetestlib: qemu chain verification
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60999/1/tests/storagetestlib.py
File tests/storagetestlib.py:
gerrit-hooks has posted comments on this change.
Change subject: Use deathSignal param only if exists
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Use deathSignal param only if exists
..
Use deathSignal param only if exists
This allows to run py3 code that doesn't use deathSinal. otherwise each
call to
Yaniv Bronhaim has posted comments on this change.
Change subject: Move gluster.exception to lib/vdsm/gluster
..
Patch Set 1: Code-Review-1
(2 comments)
1. please arrange imports in sort order and move vdsm. imports to vdsm.
Irit Goihman has posted comments on this change.
Change subject: sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/60605/6/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Adam Litke has posted comments on this change.
Change subject: qemuimg: Fix tests with non-default qcow2_compat
..
Patch Set 2: Verified+1
Verified with unit tests
--
To view, visit https://gerrit.ovirt.org/60977
To
Adam Litke has posted comments on this change.
Change subject: qemuimg: Keep supported qcow2 versions as a tuple
..
Patch Set 2: Verified+1
Verified with unit tests
--
To view, visit https://gerrit.ovirt.org/60978
To
Adam Litke has posted comments on this change.
Change subject: qemuimg: Use --output json for 'check' and 'info'
..
Patch Set 2: Verified+1
Verified with unit tests
--
To view, visit https://gerrit.ovirt.org/60979
To
Adam Litke has posted comments on this change.
Change subject: qemuimg: Unbreak qmemuimg.check
..
Patch Set 3: Verified+1
Verified with unit tests
--
To view, visit https://gerrit.ovirt.org/60987
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: hsm: Use manifest in verify_untrusted_volume
..
Patch Set 3: Verified+1
Verified with unit tests
--
To view, visit https://gerrit.ovirt.org/60981
To unsubscribe,
Adam Litke has posted comments on this change.
Change subject: qemuimg: Report qcow2 compat version
..
Patch Set 3: Verified+1
Verified with unit tests
--
To view, visit https://gerrit.ovirt.org/60980
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: verify_untrusted_volume: Only allow compat designated by config
..
Patch Set 3: Verified+1
Verified with unit tests
--
To view, visit
Adam Litke has posted comments on this change.
Change subject: qemuimg: Introduce supports_compat helper
..
Patch Set 3: Verified+1
Verified with unit tests
--
To view, visit https://gerrit.ovirt.org/60984
To unsubscribe,
Adam Litke has posted comments on this change.
Change subject: tests: Use FakeStorageDomainCache in fake env
..
Patch Set 3: Verified+1
Verified with unit tests
--
To view, visit https://gerrit.ovirt.org/60982
To
Adam Litke has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 3: Verified+1
Verified with unit tests
--
To view, visit https://gerrit.ovirt.org/60985
To
Adam Litke has posted comments on this change.
Change subject: tests: Add tests for verify_untrusted_volume
..
Patch Set 3: Verified+1
Verified with unit tests
--
To view, visit https://gerrit.ovirt.org/60983
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: storage: add getDeviceList discard related fields
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60628
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: storage: add getDeviceList discard related fields
..
Patch Set 3:
Idan, can you verify these patches?
--
To view, visit https://gerrit.ovirt.org/60628
To
Nir Soffer has posted comments on this change.
Change subject: multipath: add the read_int helper function
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60856
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: oop: Explicitly close running ioprocesses
..
Patch Set 1: Code-Review+1
temporary lowering score to not hide Adam's
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: oop: Explicitly close running ioprocesses
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61050
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: oop: Explicitly close running ioprocesses
..
Patch Set 1:
* #1334274::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1334274::OK, public bug
* Check
Hello Adam Litke, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/61050
to review the following change.
Change subject: oop: Explicitly close running ioprocesses
..
oop:
gerrit-hooks has posted comments on this change.
Change subject: storagetestlib: Allow creating multiple block volumes in an
image
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url
Nir Soffer has submitted this change and it was merged.
Change subject: storagetestlib: Allow creating multiple block volumes in an
image
..
storagetestlib: Allow creating multiple block volumes in an image
Due to an
gerrit-hooks has posted comments on this change.
Change subject: storagetestlib: Add fake_env() helper
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: storagetestlib: Add fake_env() helper
..
storagetestlib: Add fake_env() helper
Permutated tests would like to test 'file' and 'block' environments. Add a
gerrit-hooks has posted comments on this change.
Change subject: oop: Explicitly close running ioprocesses
..
Patch Set 4:
* #1334274::Update tracker: OK
* Set MODIFIED::bug 1334274#1334274OK
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: oop: Explicitly close running ioprocesses
..
oop: Explicitly close running ioprocesses
IOProcess client is using __del__ for automatic closing when the
Adam Litke has posted comments on this change.
Change subject: oop: Explicitly close running ioprocesses
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60830
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: graphics: drop legacy graphics config support
..
Patch Set 9:
strange failure but unrelated to this patch :)
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: vm: graphics: drop legacy graphics config support
..
Patch Set 9:
strange failure on FC24:
00:08:16.067 ../tests/run_tests_local.sh: line 35: 28362
Francesco Romani has posted comments on this change.
Change subject: vm: graphics: drop legacy graphics config support
..
Patch Set 9: Verified+1
re-verified after rebase running a VM with patched Vdsm.
--
To view, visit
Adam Litke has posted comments on this change.
Change subject: oop: Explicitly close running ioprocesses
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60830
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: rpc: Log also error codes of RPC calls
..
Patch Set 2:
* #1351247::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1351247::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: logging: Introduce throttledlog
..
Patch Set 2:
* #1351247::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1351247::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: storagetestlib: Simplify qemu_pattern helpers
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Adam Litke has submitted this change and it was merged.
Change subject: storagetestlib: Simplify qemu_pattern helpers
..
storagetestlib: Simplify qemu_pattern helpers
We don't need to pass a string but a number in the range
gerrit-hooks has posted comments on this change.
Change subject: ovs: copy NIC hwaddr to NB
..
Patch Set 1:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 4:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: ovs: use Setup class directly
..
Patch Set 6:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: ovs: acquire external ifaces
..
Patch Set 23:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Petr Horáček has uploaded a new change for review.
Change subject: ovs: copy NIC hwaddr to NB
..
ovs: copy NIC hwaddr to NB
In order to receive the same IP for network as acquired NIC used to
have, we must copy NIC's hwaddr to
1 - 100 of 322 matches
Mail list logo