Change in vdsm[master]: volume: Add qcow2_compat on create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: volume: Add qcow2_compat on create
..


Patch Set 8:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64375
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8655be6da0b4cbd1c286b0c40288681a991aff19
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: image: Pass compat version.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: image: Pass compat version.
..


Patch Set 12:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64293
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56e01923aba982e20bda72af61db83df50373127
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: volume_artifacts: Add qcow2_compat on create.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: volume_artifacts: Add qcow2_compat on create.
..


Patch Set 8:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dd2d53fba0dd69cdb4f60e152cf6d254cfb863a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: file_volume: Add qcow2_compat on create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
..


Patch Set 8:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81fd3a6e263980c1eabeea7f619c9a6b48991938
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: copy_data: Add qcow2_compat on convert.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: copy_data: Add qcow2_compat on convert.
..


Patch Set 8:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26e5dcba6fc493b32ea7764889df2918c4dfdd3
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Add qcow_compat optional parameter.
..


Patch Set 20:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: blockVolume: Add qcow2_compat on create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: blockVolume: Add qcow2_compat on create
..


Patch Set 8:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64376
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9fe6bf59b76b68ed8f0e60f66057c07b56d2d942
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sd: Select qcow2_compat by storage domain version

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sd: Select qcow2_compat by storage domain version
..


Patch Set 13:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I946d8a0d142187bef4e50d583003e2f5b848d678
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Add qcow2_compat on create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: Add qcow2_compat on create
..


Patch Set 8:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64377
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I331eee6a12853c2fa65e62f42c51504f88723538
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: volume_artifacts: Add qcow2_compat on create.

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: volume_artifacts: Add qcow2_compat on create.
..


Patch Set 6:

I will add the desired tests in the next patchset

-- 
To view, visit https://gerrit.ovirt.org/64372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dd2d53fba0dd69cdb4f60e152cf6d254cfb863a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: copy_data: Add qcow2_compat on convert.

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: copy_data: Add qcow2_compat on convert.
..


Patch Set 6:

I will add the desired tests in the next patchset

-- 
To view, visit https://gerrit.ovirt.org/64373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26e5dcba6fc493b32ea7764889df2918c4dfdd3
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: image: Pass compat version.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: image: Pass compat version.
..


Patch Set 11:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64293
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56e01923aba982e20bda72af61db83df50373127
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: volume: Add qcow2_compat on create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: volume: Add qcow2_compat on create
..


Patch Set 7:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64375
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8655be6da0b4cbd1c286b0c40288681a991aff19
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: copy_data: Add qcow2_compat on convert.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: copy_data: Add qcow2_compat on convert.
..


Patch Set 7:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26e5dcba6fc493b32ea7764889df2918c4dfdd3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: volume_artifacts: Add qcow2_compat on create.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: volume_artifacts: Add qcow2_compat on create.
..


Patch Set 7:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dd2d53fba0dd69cdb4f60e152cf6d254cfb863a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Add qcow_compat optional parameter.
..


Patch Set 19:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: file_volume: Add qcow2_compat on create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
..


Patch Set 7:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81fd3a6e263980c1eabeea7f619c9a6b48991938
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: blockVolume: Add qcow2_compat on create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: blockVolume: Add qcow2_compat on create
..


Patch Set 7:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64376
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9fe6bf59b76b68ed8f0e60f66057c07b56d2d942
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Add qcow2_compat on create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: Add qcow2_compat on create
..


Patch Set 7:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64377
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I331eee6a12853c2fa65e62f42c51504f88723538
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sd: Select qcow2_compat by storage domain version

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sd: Select qcow2_compat by storage domain version
..


Patch Set 12:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I946d8a0d142187bef4e50d583003e2f5b848d678
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sd: Select qcow2_compat by storage domain version

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: sd: Select qcow2_compat by storage domain version
..


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/64244/11/tests/sdm_indirection_tests.py
File tests/sdm_indirection_tests.py:

Line 51: pass
Line 52: 
Line 53: @recorded
Line 54: def qcow2_compat(self, key):
Line 55: pass
> This adds only the "fake" implementation, we need to add a test that will f
Done
Line 56: 
Line 57: @recorded
Line 58: def getVersion(self):
Line 59: pass


-- 
To view, visit https://gerrit.ovirt.org/64244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I946d8a0d142187bef4e50d583003e2f5b848d678
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Support generation id in sdm.copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Support generation id in sdm.copy_data
..


Patch Set 1:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I701e220f5c275dccaa3767768e2d1433fe033839
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: SDM.copy_data test for abort while copying

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: SDM.copy_data test for abort while copying
..


Patch Set 2:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I740d9ba42e3bd70865eadcb024ce6d9d8da0af95
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Add support for generation id to VolumeMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Add support for generation id to VolumeMetadata
..


Patch Set 1:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64484
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb71e1fc78f6c1e411e725b26c48411ffd04d0b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Increment generation id when completing operation

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Increment generation id when completing operation
..


Patch Set 1:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64487
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9a62289378b11c3b2f2f520c894336fc89c1fdc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Validate generation id in volume.operation context

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Validate generation id in volume.operation context
..


Patch Set 1:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64486
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77d9c6cb46053ab32c59c77599b7c1366e1c8196
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Report generation id in volume.getInfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Report generation id in volume.getInfo
..


Patch Set 1:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64485
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62a6bb44c5f789acf3c63953f4b87c72585becc1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Remove TODO for SDM.copy_data abort before copy test

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Remove TODO for SDM.copy_data abort before copy test
..


Patch Set 2:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64480
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26e724560e9cb485fd4766ebcc04f644ad6431e4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Increment generation id when completing operation

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: storage: Increment generation id when completing operation
..

storage: Increment generation id when completing operation

Before successful exit of a volume.operation context we want to
increment the generation id in the same write that we set the volume
to legal state.  This enables engine to differentiate between all
possible end states of a volume operation:

* Operation was never run
  - Lease free, legal, generation id unchanged
* Operation is running
  - Lease held, illegal
* Operation completed successfully
  - Lease free, legal, generation id incremented
* Operation failed or aborted
 - Lease free, illegal, generation id unchanged

Change-Id: Ic9a62289378b11c3b2f2f520c894336fc89c1fdc
Signed-off-by: Adam Litke 
---
M tests/storage_volume_test.py
M vdsm/storage/volume.py
2 files changed, 13 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/64487/1

diff --git a/tests/storage_volume_test.py b/tests/storage_volume_test.py
index 23451c9..1b88185 100644
--- a/tests/storage_volume_test.py
+++ b/tests/storage_volume_test.py
@@ -140,6 +140,7 @@
 vol.setMetaParam(sc.GENERATION, 100)
 with vol.operation(generation):
 pass
+self.assertEqual(generation + 1, vol.getMetaParam(sc.GENERATION))
 
 def test_operation_invalid_generation_raises(self):
 img_id = str(uuid.uuid4())
@@ -153,6 +154,7 @@
 with self.assertRaises(se.InvalidGeneration):
 with vol.operation(generation + 1):
 pass
+self.assertEqual(generation, vol.getMetaParam(sc.GENERATION))
 
 def test_get_info_generation_id(self):
 img_id = str(uuid.uuid4())
diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py
index 2c8991c..43e2f90 100644
--- a/vdsm/storage/volume.py
+++ b/vdsm/storage/volume.py
@@ -506,7 +506,12 @@
 In order to detect interrupted datapath operations a volume should be
 marked ILLEGAL prior to the first modification of data and subsequently
 marked LEGAL again once the operation has completed.  Thus, if an
-interruption occurs the volume will remain in an ILLEGAL state.
+interruption occurs the volume will remain in an ILLEGAL state.  When
+the volume is legal we want to call volume.getInfo to determine if this
+operation has not been started or has finished successfully.  We enable
+this by incrementing the generation id after the operation completes.
+Note that legality and generation id must be updated in the same write
+operation.
 
 If generation is provided we check that the volume's generation matches
 """
@@ -515,8 +520,12 @@
 raise se.InvalidGeneration(requested_gen_id, real_gen_id)
 self.setLegality(sc.ILLEGAL_VOL)
 yield
-self.setLegality(sc.LEGAL_VOL)
 
+# Update the generation id and legality in one write
+metadata = self.getMetadata()
+metadata[sc.LEGALITY] = sc.LEGAL_VOL
+metadata[sc.GENERATION] = real_gen_id + 1
+self.setMetadata(metadata)
 
 
 class Volume(object):


-- 
To view, visit https://gerrit.ovirt.org/64487
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9a62289378b11c3b2f2f520c894336fc89c1fdc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Report generation id in volume.getInfo

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: storage: Report generation id in volume.getInfo
..

storage: Report generation id in volume.getInfo

Change-Id: I62a6bb44c5f789acf3c63953f4b87c72585becc1
Signed-off-by: Adam Litke 
---
M lib/api/vdsm-api.yml
M tests/storage_volume_test.py
M vdsm/storage/volume.py
3 files changed, 17 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/64485/1

diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index c7ab7f5..5e95d56 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -6962,6 +6962,10 @@
 -   description: The status of the Volume lease
 name: lease
 type: *VolumeLeaseStatus
+
+-   description: A monotonically increasing generation id
+name: generation
+type: uint
 type: object
 
 VolumeSizeInfo: 
diff --git a/tests/storage_volume_test.py b/tests/storage_volume_test.py
index 6a0611a..f7c9c50 100644
--- a/tests/storage_volume_test.py
+++ b/tests/storage_volume_test.py
@@ -128,6 +128,18 @@
 raise ValueError()
 self.assertEqual(sc.ILLEGAL_VOL, vol.getLegality())
 
+def test_get_info_generation_id(self):
+img_id = str(uuid.uuid4())
+vol_id = str(uuid.uuid4())
+generation = 100
+
+with fake_env('file') as env:
+env.make_volume(MB, img_id, vol_id)
+vol = env.sd_manifest.produceVolume(img_id, vol_id)
+vol.getLeaseStatus = lambda: 'unused'
+vol.setMetaParam(sc.GENERATION, generation)
+self.assertEqual(generation, vol.getInfo()['generation'])
+
 
 class CountedInstanceMethod(object):
 def __init__(self, method):
diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py
index 601391b..6057e18 100644
--- a/vdsm/storage/volume.py
+++ b/vdsm/storage/volume.py
@@ -206,6 +206,7 @@
 "ctime": meta.get(sc.CTIME, ""),
 "mtime": "0",
 "legality": meta.get(sc.LEGALITY, ""),
+"generation": meta.get(sc.GENERATION, 0)
 }
 
 def getInfo(self):


-- 
To view, visit https://gerrit.ovirt.org/64485
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I62a6bb44c5f789acf3c63953f4b87c72585becc1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Support generation id in sdm.copy_data

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: storage: Support generation id in sdm.copy_data
..

storage: Support generation id in sdm.copy_data

Change-Id: I701e220f5c275dccaa3767768e2d1433fe033839
Signed-off-by: Adam Litke 
---
M lib/api/vdsm-api.yml
M tests/storage_sdm_copy_data_test.py
M vdsm/storage/sdm/api/copy_data.py
3 files changed, 52 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/64488/1

diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index 5e95d56..eb737bd 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -7090,6 +7090,11 @@
 -   description: The UUID of the Volume
 name: vol_id
 type: *UUID
+
+-   description: The expected generation ID of the Volume
+name: generation_id
+type: uint
+defaultvalue: null
 type: object
 
 CopyDataEndpoint: 
diff --git a/tests/storage_sdm_copy_data_test.py 
b/tests/storage_sdm_copy_data_test.py
index f830d98..e806e04 100644
--- a/tests/storage_sdm_copy_data_test.py
+++ b/tests/storage_sdm_copy_data_test.py
@@ -36,6 +36,7 @@
 from vdsm import jobs
 from vdsm import qemuimg
 from vdsm.storage import constants as sc
+from vdsm.storage import exception as se
 from vdsm.storage import guarded
 from vdsm.storage import workarounds
 
@@ -230,22 +231,28 @@
 ('block', jobs.STATUS.FAILED),
 ))
 def test_volume_operation(self, env_type, final_status):
-if final_status == jobs.STATUS.DONE:
-cmd = ['/bin/true']
-final_legality = sc.LEGAL_VOL
-else:
-cmd = ['/bin/false']
-final_legality = sc.ILLEGAL_VOL
 job_id = str(uuid.uuid4())
 fmt = sc.RAW_FORMAT
 with self.get_vols(env_type, fmt, fmt) as (src_chain, dst_chain):
 src_vol = src_chain[0]
 dst_vol = dst_chain[0]
+gen_id = dst_vol.getMetaParam(sc.GENERATION)
+if final_status == jobs.STATUS.DONE:
+cmd = ['/bin/true']
+final_legality = sc.LEGAL_VOL
+final_gen = gen_id + 1
+else:
+cmd = ['/bin/false']
+final_legality = sc.ILLEGAL_VOL
+final_gen = gen_id
+
 self.assertEqual(sc.LEGAL_VOL, dst_vol.getLegality())
 source = dict(endpoint_type='div', sd_id=src_vol.sdUUID,
-  img_id=src_vol.imgUUID, vol_id=src_vol.volUUID)
+  img_id=src_vol.imgUUID, vol_id=src_vol.volUUID,
+  generation_id=0)
 dest = dict(endpoint_type='div', sd_id=dst_vol.sdUUID,
-img_id=dst_vol.imgUUID, vol_id=dst_vol.volUUID)
+img_id=dst_vol.imgUUID, vol_id=dst_vol.volUUID,
+generation_id=gen_id)
 fake_convert = FakeQemuConvertChecker(src_vol, dst_vol, cmd)
 with MonkeyPatchScope([(qemuimg, 'convert', fake_convert)]):
 job = storage.sdm.api.copy_data.Job(job_id, 0, source, dest)
@@ -253,6 +260,7 @@
 wait_for_job(job)
 self.assertEqual(final_status, job.status)
 self.assertEqual(final_legality, dst_vol.getLegality())
+self.assertEqual(final_gen, dst_vol.getMetaParam(sc.GENERATION))
 
 @permutations((('file',), ('block',)))
 def test_abort_during_copy(self, env_type):
@@ -260,10 +268,13 @@
 with self.get_vols(env_type, fmt, fmt) as (src_chain, dst_chain):
 src_vol = src_chain[0]
 dst_vol = dst_chain[0]
+gen_id = dst_vol.getMetaParam(sc.GENERATION)
 source = dict(endpoint_type='div', sd_id=src_vol.sdUUID,
-  img_id=src_vol.imgUUID, vol_id=src_vol.volUUID)
+  img_id=src_vol.imgUUID, vol_id=src_vol.volUUID,
+  generation_id=0)
 dest = dict(endpoint_type='div', sd_id=dst_vol.sdUUID,
-img_id=dst_vol.imgUUID, vol_id=dst_vol.volUUID)
+img_id=dst_vol.imgUUID, vol_id=dst_vol.volUUID,
+generation_id=gen_id)
 fake_convert = FakeQemuConvertChecker(src_vol, dst_vol,
   ['/bin/read'])
 with MonkeyPatchScope([(qemuimg, 'convert', fake_convert)]):
@@ -274,6 +285,28 @@
 job.abort()
 self.assertEqual(jobs.STATUS.ABORTED, job.status)
 self.assertEqual(sc.ILLEGAL_VOL, dst_vol.getLegality())
+self.assertEqual(gen_id, dst_vol.getMetaParam(sc.GENERATION))
+
+def test_wrong_generation_id(self):
+fmt = sc.RAW_FORMAT
+with self.get_vols('block', fmt, fmt) as (src_chain, dst_chain):
+src_vol = src_chain[0]
+dst_vol = 

Change in vdsm[master]: storage: Add support for generation id to VolumeMetadata

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: storage: Add support for generation id to VolumeMetadata
..

storage: Add support for generation id to VolumeMetadata

We would like to add support for a new generation id key in the volume
metadata.  GENID is a monotonically increasing integer that can be used
to determine whether certain operations have been completed on a volume
and to prevent two hosts from sequentially performing the same operation
in the event of double scheduling.

The new GENID key is optional.  If we read metadata without this key, a
default value of 0 will be reported.

This patch supports only the manipulation of the generation ID within
the VolumeMetadata class.  The value will be made available via
Volume.getInfo in a follow-up patch and will be changed by verbs in
subsequent patches.

Change-Id: Icb71e1fc78f6c1e411e725b26c48411ffd04d0b6
Signed-off-by: Adam Litke 
---
M lib/vdsm/storage/constants.py
M lib/vdsm/storage/volumemetadata.py
M tests/storage_volume_metadata_test.py
3 files changed, 26 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/64484/1

diff --git a/lib/vdsm/storage/constants.py b/lib/vdsm/storage/constants.py
index 4c00a5b..e2f6cea 100644
--- a/lib/vdsm/storage/constants.py
+++ b/lib/vdsm/storage/constants.py
@@ -125,6 +125,7 @@
 DESCRIPTION = "DESCRIPTION"
 LEGALITY = "LEGALITY"
 MTIME = "MTIME"
+GENERATION = "GENID"
 POOL = MDK_POOLS  # Deprecated
 
 # In block storage, metadata size is limited to BLOCK_SIZE (512), to
diff --git a/lib/vdsm/storage/volumemetadata.py 
b/lib/vdsm/storage/volumemetadata.py
index a8d9641..7dc3bc9 100644
--- a/lib/vdsm/storage/volumemetadata.py
+++ b/lib/vdsm/storage/volumemetadata.py
@@ -33,10 +33,12 @@
 
 def __init__(self, domain, image, puuid, size, format,
  type, voltype, disktype, description="",
- legality=constants.ILLEGAL_VOL, ctime=None, mtime=None):
+ legality=constants.ILLEGAL_VOL, ctime=None, mtime=None,
+ generation=None):
 assert(isinstance(size, int))
 assert(ctime is None or isinstance(ctime, int))
 assert(mtime is None or isinstance(mtime, int))
+assert(generation is None or isinstance(generation, int))
 
 # Storage domain UUID
 self.domain = domain
@@ -62,6 +64,8 @@
 self.ctime = int(time.time()) if ctime is None else ctime
 # Volume modification time (unused and should be zero)
 self.mtime = 0 if mtime is None else mtime
+# Generation ID increments each time certain operations complete
+self.generation = 0 if generation is None else generation
 
 @classmethod
 def from_lines(cls, lines):
@@ -86,7 +90,8 @@
description=md[constants.DESCRIPTION],
legality=md[constants.LEGALITY],
ctime=int(md[constants.CTIME]),
-   mtime=int(md[constants.MTIME]))
+   mtime=int(md[constants.MTIME]),
+   generation=int(md.get(constants.GENERATION, 0)))
 except KeyError as e:
 raise exception.MetaDataKeyNotFoundError(
 "Missing metadata key: %s: found: %s" % (e, md))
@@ -144,4 +149,5 @@
 constants.PUUID: self.puuid,
 constants.MTIME: str(self.mtime),
 constants.LEGALITY: self.legality,
+constants.GENERATION: self.generation,
 }
diff --git a/tests/storage_volume_metadata_test.py 
b/tests/storage_volume_metadata_test.py
index b8f5873..efd64a6 100644
--- a/tests/storage_volume_metadata_test.py
+++ b/tests/storage_volume_metadata_test.py
@@ -44,7 +44,8 @@
 voltype=sc.type2name(sc.LEAF_VOL),
 disktype=image.SYSTEM_DISK_TYPE,
 description="",
-legality=sc.LEGAL_VOL)
+legality=sc.LEGAL_VOL,
+generation=0)
 res.update(kwargs)
 return res
 
@@ -64,6 +65,7 @@
 sc.MTIME: '0',
 sc.CTIME: '0',
 sc.POOL: '',
+sc.GENERATION: '1',
 }
 res.update(kwargs)
 return res
@@ -96,7 +98,8 @@
 PUUID=params['puuid'],
 SIZE=str(params['size']),
 TYPE=params['type'],
-VOLTYPE=params['voltype'])
+VOLTYPE=params['voltype'],
+GENID=params['generation'])
 
 with MonkeyPatchScope([[time, 'time', lambda: FAKE_TIME]]):
 info = volume.VolumeMetadata(**params).legacy_info()
@@ -110,6 +113,7 @@
 DISKTYPE=%(disktype)s
 DOMAIN=%(domain)s
 FORMAT=%(format)s
+GENID=%(generation)s
 IMAGE=%(image)s
 LEGALITY=%(legality)s
 MTIME=0
@@ -137,9 +141,10 @@
 params = make_init_params(**{param: 'not_an_int'})
 self.assertRaises(AssertionError, volume.VolumeMetadata, **params)

Change in vdsm[master]: storage: Validate generation id in volume.operation context

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: storage: Validate generation id in volume.operation context
..

storage: Validate generation id in volume.operation context

When the optional requested_gen_id parameter is supplied to the
volume.operation context manager, validate the requested generation
against the volume's current generation and raise a new
InvalidGeneration exception when they do not match.

Change-Id: I77d9c6cb46053ab32c59c77599b7c1366e1c8196
Signed-off-by: Adam Litke 
---
M lib/vdsm/storage/exception.py
M tests/storage_volume_test.py
M vdsm/storage/volume.py
3 files changed, 42 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/64486/1

diff --git a/lib/vdsm/storage/exception.py b/lib/vdsm/storage/exception.py
index dcd2922..ed2efb3 100644
--- a/lib/vdsm/storage/exception.py
+++ b/lib/vdsm/storage/exception.py
@@ -1777,7 +1777,7 @@
 
 #
 #  SDM Errors
-#  Range: 909-910
+#  Range: 910-919
 #
 
 class DomainHasGarbage(StorageException):
@@ -1786,3 +1786,11 @@
 
 def __init__(self, reason):
 self.value = reason
+
+
+class InvalidGeneration(StorageException):
+code = 911
+message = "The provided Generation ID is not valid for this Volume"
+
+def __init__(self, requested_id, real_id):
+self.value = "requested id:%i, actual_id:%i" % (requested_id, real_id)
diff --git a/tests/storage_volume_test.py b/tests/storage_volume_test.py
index f7c9c50..23451c9 100644
--- a/tests/storage_volume_test.py
+++ b/tests/storage_volume_test.py
@@ -30,6 +30,7 @@
 from testlib import VdsmTestCase
 
 from vdsm.storage import constants as sc
+from vdsm.storage import exception as se
 
 from storage import resourceManager as rm
 from storage import sd
@@ -128,6 +129,31 @@
 raise ValueError()
 self.assertEqual(sc.ILLEGAL_VOL, vol.getLegality())
 
+def test_operation_valid_generation(self):
+img_id = str(uuid.uuid4())
+vol_id = str(uuid.uuid4())
+generation = 100
+
+with fake_env('file') as env:
+env.make_volume(MB, img_id, vol_id)
+vol = env.sd_manifest.produceVolume(img_id, vol_id)
+vol.setMetaParam(sc.GENERATION, 100)
+with vol.operation(generation):
+pass
+
+def test_operation_invalid_generation_raises(self):
+img_id = str(uuid.uuid4())
+vol_id = str(uuid.uuid4())
+generation = 100
+
+with fake_env('file') as env:
+env.make_volume(MB, img_id, vol_id)
+vol = env.sd_manifest.produceVolume(img_id, vol_id)
+vol.setMetaParam(sc.GENERATION, generation)
+with self.assertRaises(se.InvalidGeneration):
+with vol.operation(generation + 1):
+pass
+
 def test_get_info_generation_id(self):
 img_id = str(uuid.uuid4())
 vol_id = str(uuid.uuid4())
diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py
index 6057e18..2c8991c 100644
--- a/vdsm/storage/volume.py
+++ b/vdsm/storage/volume.py
@@ -499,7 +499,7 @@
 pass
 
 @contextmanager
-def operation(self):
+def operation(self, requested_gen_id=None):
 """
 Must be called with the Volume Lease held.
 
@@ -507,12 +507,18 @@
 marked ILLEGAL prior to the first modification of data and subsequently
 marked LEGAL again once the operation has completed.  Thus, if an
 interruption occurs the volume will remain in an ILLEGAL state.
+
+If generation is provided we check that the volume's generation matches
 """
+real_gen_id = self.getMetaParam(sc.GENERATION)
+if requested_gen_id is not None and real_gen_id != requested_gen_id:
+raise se.InvalidGeneration(requested_gen_id, real_gen_id)
 self.setLegality(sc.ILLEGAL_VOL)
 yield
 self.setLegality(sc.LEGAL_VOL)
 
 
+
 class Volume(object):
 log = logging.getLogger('storage.Volume')
 manifestClass = VolumeManifest


-- 
To view, visit https://gerrit.ovirt.org/64486
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I77d9c6cb46053ab32c59c77599b7c1366e1c8196
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: SDM.copy_data test for abort while copying

[alitke]

Adam Litke has posted comments on this change.

Change subject: tests: SDM.copy_data test for abort while copying
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64479/1/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 232
Line 233
Line 234
Line 235
Line 236
> We can convert this logic to permutations:
I did that originally but it makes the test output lines too long.  The only 
permutations are storage type and whether the operation fails or succeeds.  
Better to compute the other values in the function than to use the permutations 
infrastructure to proxy the other values to the function.


-- 
To view, visit https://gerrit.ovirt.org/64479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I740d9ba42e3bd70865eadcb024ce6d9d8da0af95
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: remove capsTests from blacklist

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: py3: remove capsTests from blacklist
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49264d5eaa19bb957c69461dfb1cdfe641294037
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message

[mzamazal]

Milan Zamazal has uploaded a new change for review.

Change subject: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message
..

virt: Typo fix in Vm._acquireCpuLockWithTimeout error message

Change-Id: Id93bec2881040566261cc6ffaeb8df97eef477a7
Signed-off-by: Milan Zamazal 
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/63622/6

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 38f663b..461d5fa 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -946,7 +946,7 @@
 while not self._guestCpuLock.acquire(False):
 time.sleep(0.1)
 if time.time() > end:
-raise RuntimeError('waiting more that %ss for _guestCpuLock' %
+raise RuntimeError('waiting more than %ss for _guestCpuLock' %
timeout)
 
 def cont(self, afterState=vmstatus.UP, guestCpuLocked=False,


-- 
To view, visit https://gerrit.ovirt.org/63622
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id93bec2881040566261cc6ffaeb8df97eef477a7
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: SDM.copy_data test for abort while copying

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: SDM.copy_data test for abort while copying
..


Patch Set 1:

(1 comment)

Partial review

https://gerrit.ovirt.org/#/c/64479/1/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 232
Line 233
Line 234
Line 235
Line 236
We can convert this logic to permutations:

# storage, cmd, job_status, legallity
("file", ["/bin/true"], jobs.STATUS.DONE, sc.LEGAL_VOL),
("file", ["/bin/false"], jobs.STATUS.FAILED, sc.ILLEGAL_VOL),


-- 
To view, visit https://gerrit.ovirt.org/64479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I740d9ba42e3bd70865eadcb024ce6d9d8da0af95
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Remove TODO for SDM.copy_data abort before copy test

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Remove TODO for SDM.copy_data abort before copy test
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64480
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26e724560e9cb485fd4766ebcc04f644ad6431e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Initial support for post-copy migration

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Initial support for post-copy migration
..


Patch Set 10:

(4 comments)

https://gerrit.ovirt.org/#/c/62873/8/vdsm.spec.in
File vdsm.spec.in:

Line 187: Requires: libvirt-daemon-kvm >= 1.3.5
Line 188: %else # rhel
Line 189: Requires: libvirt-daemon-kvm >= 1.3.3
Line 190: Requires: libvirt-python >= 1.3.4
Line 191: %endif
> ok, this may need to be split in a separate change, depending on the time o
We'll see. The problem is that once we removed the backward compatibility code 
from this patch, we must require corresponding libvirt versions, otherwise we 
crash on libvirt.VIR_MIGRATE_POSTCOPY (we can make a workaround if it's still a 
problem at the time of merge).
Line 192: 
Line 193: # iscsi-intiator versions
Line 194: %if 0%{?rhel}
Line 195: Requires: iscsi-initiator-utils


https://gerrit.ovirt.org/#/c/62873/6/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 480:  (libvirt.VIR_MIGRATE_COMPRESSED if
Line 481:  self._compressed else 0) |
Line 482:  (libvirt.VIR_MIGRATE_AUTO_CONVERGE if
Line 483:  self._autoConverge else 0))
Line 484: 
> Vdsm *should* be run in F24, or, to word it differently, I'm not aware of a
OK, thanks for confirming we should be fine in this regard.
Line 485: self._vm._dom.migrateToURI3(duri, params, flags)
Line 486: else:
Line 487: self._raiseAbortError()
Line 488: 


https://gerrit.ovirt.org/#/c/62873/8/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 478
Line 479
Line 480
Line 481
Line 482
> unrelated, please drop this change if you resubmit
Done


PS8, Line 778: self._vm.log.info('Switching to post-copy mig
> ugh, this reads so C-ish :)
Well, I don't know how to identify the C-ishness of the condition. Thinking 
about it I tend to use Lisp style and to avoid Prolog style (to make clear we 
are in the procedural and not declarative programming area). I admit I do some 
C++ programming, but I may be blamed for excessive use of virtual methods 
there, so I'd say I'm more influenced by Python than C/C++. Dancing among those 
subtle and delicate issues, I may indeed overlook that I use C-ish constructs 
in completely inappropriate places.

So I changed it as you suggest, to be consistent with the places where we use a 
similar construct.


-- 
To view, visit https://gerrit.ovirt.org/62873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Use Volume.operation in SDM.copy_data

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Use Volume.operation in SDM.copy_data
..


Patch Set 1:

Code cannot be simpler and more elegant, need time to review the tests.

-- 
To view, visit https://gerrit.ovirt.org/64478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I574cea3387ab5b99368e0317aed73683d398a596
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Introduce VolumeManifest.operation context

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Introduce VolumeManifest.operation context
..


Patch Set 2:

(1 comment)

Nice, needs more time to review the tests.

https://gerrit.ovirt.org/#/c/64362/2/tests/storage_volume_test.py
File tests/storage_volume_test.py:

Line 116: self.assertEqual(2, vol.setMetadata.nr_calls)
Line 117: 
Line 118: def test_operation_fail_inside_context(self):
Line 119: img_id = str(uuid.uuid4())
Line 120: vol_id = str(uuid.uuid4())
I think its time to introduce a helper to create uuid string without repeating 
this boilerplate everywhere.
Line 121: 
Line 122: with fake_env('file') as env:
Line 123: env.make_volume(MB, img_id, vol_id)
Line 124: vol = env.sd_manifest.produceVolume(img_id, vol_id)


-- 
To view, visit https://gerrit.ovirt.org/64362
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30a3ac2971411778d24e007aac9fcb3009edb4c4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Don't crash in migration progress on compression bytes

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: Don't crash in migration progress on compression bytes
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64468/2/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 789: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_PROCESSED],
Line 790: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_REMAINING],
Line 791: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_BPS],
Line 792: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_CONSTANT],
Line 793: stats.get(libvirt.VIR_DOMAIN_JOB_COMPRESSION_BYTES, 0),
I this our standard, adding default values for missing keys, or we omit missing 
keys?
Line 794: # available since libvirt 1.3
Line 795: stats.get('memory_dirty_rate', -1),
Line 796: # available since libvirt 1.3
Line 797: stats.get('memory_iteration', -1),


-- 
To view, visit https://gerrit.ovirt.org/64468
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1885940843d705ead161c13258f1979025a03873
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: More standard logging format

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: logging: More standard logging format
..


Patch Set 4:

ping

-- 
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Peter Portante 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Minor typo fixes in Vm.getStats docstring

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: Minor typo fixes in Vm.getStats docstring
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63550
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e07c9b237cf0af22ec8d0f7618ab655839839f2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sdm: Introduce new SDM.merge verb

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sdm: Introduce new SDM.merge verb
..


Patch Set 8:

Lets add the implementation of this first, and update the api only after we 
have a working (maybe merged) implementation.

-- 
To view, visit https://gerrit.ovirt.org/64196
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96d57a5b9f21153ce1de2cd5619c7f9f78bbe75b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: core: Expose API for qemuimg commit

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: core: Expose API for qemuimg commit
..


Patch Set 6:

(3 comments)

https://gerrit.ovirt.org/#/c/64222/6/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 186: 
Line 187: 
Line 188: def commit(top, topFormat, base=None):
Line 189: cmd = [_qemuimg.cmd, "commit", "-p", "-t", "none"]
Line 190: # For simplicity, we always run commit in the working directory.
in the image directory
Line 191: workdir = os.path.dirname(top)
Line 192: 
Line 193: if base:
Line 194: cmd.extend(("-b", base))


Line 196: # If base volume is not provided, qemuimg commit will empty 
the top
Line 197: # volume after the operation has succeeded. Providing '-d' 
option
Line 198: # will cause qemuimg commit not to empty the top volume. Note 
that
Line 199: # if a backing chain is provided, i.e. a base volume is 
provided,
Line 200: # '-d' is always implied.
See my comment about this comment in previous version.
Line 201: cmd.append("-d")
Line 202: 
Line 203: cmd.extend(("-f", topFormat))
Line 204: 


Line 202: 
Line 203: cmd.extend(("-f", topFormat))
Line 204: 
Line 205: cmd.append(top)
Line 206: 
We use workdir only here, so better create it just before we use it. Smaller 
scope leave no place for bugs.
Line 207: return QemuImgOperation(cmd, cwd=workdir)
Line 208: 
Line 209: 
Line 210: class QemuImgOperation(object):


-- 
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Initial support for post-copy migration

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Initial support for post-copy migration
..


Patch Set 10:

* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1354343::OK, public bug
* Check Product::#1354343::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: core: Expose API for qemuimg commit

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: core: Expose API for qemuimg commit
..


Patch Set 6:

(5 comments)

Partial review.

https://gerrit.ovirt.org/#/c/64222/6/tests/qemuimg_test.py
File tests/qemuimg_test.py:

Line 335: @expandPermutations
Line 336: class TestCommit(TestCaseBase):
Line 337: 
Line 338: @MonkeyPatch(qemuimg, 'config', CONFIG)
Line 339: @permutations([
We need a comment here for the argument

# name1, name2, ...
Line 340: (1, qemuimg.FORMAT.RAW, False),
Line 341: (1, qemuimg.FORMAT.RAW),
Line 342: (1, qemuimg.FORMAT.QCOW2, False),
Line 343: (1, qemuimg.FORMAT.QCOW2),


Line 337: 
Line 338: @MonkeyPatch(qemuimg, 'config', CONFIG)
Line 339: @permutations([
Line 340: (1, qemuimg.FORMAT.RAW, False),
Line 341: (1, qemuimg.FORMAT.RAW),
Please keep the same number of arguments to make the format consistent and 
simple.
Line 342: (1, qemuimg.FORMAT.QCOW2, False),
Line 343: (1, qemuimg.FORMAT.QCOW2),
Line 344: (3, qemuimg.FORMAT.RAW),
Line 345: (3, qemuimg.FORMAT.QCOW2)


Line 343: (1, qemuimg.FORMAT.QCOW2),
Line 344: (3, qemuimg.FORMAT.RAW),
Line 345: (3, qemuimg.FORMAT.QCOW2)
Line 346: ])
Line 347: def test_commit(self, chainLen, baseFormat, useBacking=True):
This looks like use_base, or with_base. backing is another term not related to 
commit.
Line 348: size = 1048576
Line 349: with namedTemporaryDir() as tmpdir:
Line 350: # create base
Line 351: base = os.path.join(tmpdir, "base.img")


Line 361: chain.append(vol)
Line 362: parent = vol
Line 363: 
Line 364: if useBacking:
Line 365: op = qemuimg.commit(chain[chainLen-1],
You can use:

chain[-1]

The last item.
Line 366: topFormat=topFormat, base=base)
Line 367: else:
Line 368: op = qemuimg.commit(chain[chainLen-1], topFormat)
Line 369: op.wait_for_completion()


Line 364: if useBacking:
Line 365: op = qemuimg.commit(chain[chainLen-1],
Line 366: topFormat=topFormat, base=base)
Line 367: else:
Line 368: op = qemuimg.commit(chain[chainLen-1], topFormat)
This is little ugly, can we have the same call, taking None as default value 
when we don't have a backing?

For example, always use:

op = qemuimg.commit(chain[-1], format, base=base)

This call is equivalent to:

op = qemuimg.commit(chain[-1], format)

When base is None.
Line 369: op.wait_for_completion()
Line 370: 
Line 371: # verify base data at offset 0 after commit
Line 372: qemu_pattern_verify(base, baseFormat, offset='0', 
len='1k',


-- 
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Minor typo fixes in Vm.getStats docstring

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Minor typo fixes in Vm.getStats docstring
..


Patch Set 3: Verified+1

Just a documentation change, I checked build works. Jenkins test failures on 
Fedora are unrelated.

-- 
To view, visit https://gerrit.ovirt.org/63550
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e07c9b237cf0af22ec8d0f7618ab655839839f2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: core: Introduce new Volume.getWatermarks verb

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: core: Introduce new Volume.getWatermarks verb
..


Patch Set 1:

Lets wait with the apis, we don't know yet if we can implement them.

-- 
To view, visit https://gerrit.ovirt.org/64451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1feeb1540b2cb887b431b8075c26da09b62ea8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Initial support for post-copy migration

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Initial support for post-copy migration
..


Patch Set 9:

* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1354343::OK, public bug
* Check Product::#1354343::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Don't crash in migration progress on compression bytes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Don't crash in migration progress on compression bytes
..


Patch Set 2:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64468
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1885940843d705ead161c13258f1979025a03873
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Minor typo fixes in Vm.getStats docstring

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Minor typo fixes in Vm.getStats docstring
..


Patch Set 3:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63550
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e07c9b237cf0af22ec8d0f7618ab655839839f2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Don't crash in migration progress on compression bytes

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Don't crash in migration progress on compression bytes
..


Patch Set 2: Verified+1

(1 comment)

I verified that migration still works and that the KeyError's are no longer 
present in Vdsm log.

https://gerrit.ovirt.org/#/c/64468/1//COMMIT_MSG
Commit Message:

Line 9: If compression is not enabled for a migration then compression stats are
Line 10: not provided by libvirt.  So when we try to retrieve them in migration
Line 11: Progress, we must not expect their presence, otherwise we crash there.
Line 12: 
Line 13: Backport-To: 4.0
> Backport-To: 4.0
Yes, added.
Line 14: Change-Id: I1885940843d705ead161c13258f1979025a03873


-- 
To view, visit https://gerrit.ovirt.org/64468
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1885940843d705ead161c13258f1979025a03873
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Remove TODO for SDM.copy_data abort before copy test

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Remove TODO for SDM.copy_data abort before copy test
..


Patch Set 1:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64480
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26e724560e9cb485fd4766ebcc04f644ad6431e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Introduce VolumeManifest.operation context

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Introduce VolumeManifest.operation context
..


Patch Set 2:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64362
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30a3ac2971411778d24e007aac9fcb3009edb4c4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: SDM.copy_data test for abort while copying

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: SDM.copy_data test for abort while copying
..


Patch Set 1:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I740d9ba42e3bd70865eadcb024ce6d9d8da0af95
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Use Volume.operation in SDM.copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Use Volume.operation in SDM.copy_data
..


Patch Set 1:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I574cea3387ab5b99368e0317aed73683d398a596
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Use Volume.operation in SDM.copy_data

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: Use Volume.operation in SDM.copy_data
..

Use Volume.operation in SDM.copy_data

Change-Id: I574cea3387ab5b99368e0317aed73683d398a596
Signed-off-by: Adam Litke 
---
M tests/storage_sdm_copy_data_test.py
M vdsm/storage/sdm/api/copy_data.py
2 files changed, 56 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/64478/1

diff --git a/tests/storage_sdm_copy_data_test.py 
b/tests/storage_sdm_copy_data_test.py
index c0ec533..fef85cc 100644
--- a/tests/storage_sdm_copy_data_test.py
+++ b/tests/storage_sdm_copy_data_test.py
@@ -221,7 +221,50 @@
 # Qemu pads the file to a 1k boundary with null bytes
 self.assertTrue(f.read().startswith(vm_conf_data))
 
+@permutations((
+('file', jobs.STATUS.DONE),
+('file', jobs.STATUS.FAILED),
+('block', jobs.STATUS.DONE),
+('block', jobs.STATUS.FAILED),
+))
+def test_volume_operation(self, env_type, final_status):
+if final_status == jobs.STATUS.DONE:
+cmd = ['/bin/true']
+final_legality = sc.LEGAL_VOL
+else:
+cmd = ['/bin/false']
+final_legality = sc.ILLEGAL_VOL
+job_id = str(uuid.uuid4())
+fmt = sc.RAW_FORMAT
+with self.get_vols(env_type, fmt, fmt) as (src_chain, dst_chain):
+src_vol = src_chain[0]
+dst_vol = dst_chain[0]
+self.assertEqual(sc.LEGAL_VOL, dst_vol.getLegality())
+source = dict(endpoint_type='div', sd_id=src_vol.sdUUID,
+  img_id=src_vol.imgUUID, vol_id=src_vol.volUUID)
+dest = dict(endpoint_type='div', sd_id=dst_vol.sdUUID,
+img_id=dst_vol.imgUUID, vol_id=dst_vol.volUUID)
+fake_convert = FakeQemuConvertChecker(src_vol, dst_vol, cmd)
+with MonkeyPatchScope([(qemuimg, 'convert', fake_convert)]):
+job = storage.sdm.api.copy_data.Job(job_id, 0, source, dest)
+job.run()
+wait_for_job(job)
+self.assertEqual(final_status, job.status)
+self.assertEqual(final_legality, dst_vol.getLegality())
+
 # TODO: Missing tests:
 # Copy between 2 different domains
 # Abort before copy
 # Abort during copy
+
+
+class FakeQemuConvertChecker(object):
+def __init__(self, src_vol, dst_vol, command):
+self.src_vol = src_vol
+self.dst_vol = dst_vol
+self.command = command
+
+def __call__(self, *args, **kwargs):
+assert sc.LEGAL_VOL == self.src_vol.getLegality()
+assert sc.ILLEGAL_VOL == self.dst_vol.getLegality()
+return qemuimg.QemuImgOperation(self.command)
diff --git a/vdsm/storage/sdm/api/copy_data.py 
b/vdsm/storage/sdm/api/copy_data.py
index d55e651..dc97248 100644
--- a/vdsm/storage/sdm/api/copy_data.py
+++ b/vdsm/storage/sdm/api/copy_data.py
@@ -73,14 +73,15 @@
 src_format = self._source.qemu_format
 dst_format = self._dest.qemu_format
 
-self._operation = qemuimg.convert(
-self._source.path,
-self._dest.path,
-srcFormat=src_format,
-dstFormat=dst_format,
-backing=self._dest.backing_path,
-backingFormat=self._dest.backing_qemu_format)
-self._operation.wait_for_completion()
+with self._dest.volume_operation():
+self._operation = qemuimg.convert(
+self._source.path,
+self._dest.path,
+srcFormat=src_format,
+dstFormat=dst_format,
+backing=self._dest.backing_path,
+backingFormat=self._dest.backing_qemu_format)
+self._operation.wait_for_completion()
 
 
 def _create_endpoint(params, host_id, writable):
@@ -141,6 +142,10 @@
 return None
 return sc.fmt2str(parent_vol.getFormat())
 
+@property
+def volume_operation(self):
+return self._vol.operation
+
 @contextmanager
 def prepare(self):
 dom = sdCache.produce_manifest(self.sd_id)


-- 
To view, visit https://gerrit.ovirt.org/64478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I574cea3387ab5b99368e0317aed73683d398a596
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Remove TODO for SDM.copy_data abort before copy test

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: Remove TODO for SDM.copy_data abort before copy test
..

tests: Remove TODO for SDM.copy_data abort before copy test

The abort before copy test is meant to exercise the code which exits the
job early (and without marking the destination volume illegal) if the
job has been aborted in an extremely narrow race window.  It's a
difficult test to write correctly and would not be testing anything
particularly interesting.  Drop the TODO.

Change-Id: I26e724560e9cb485fd4766ebcc04f644ad6431e4
Signed-off-by: Adam Litke 
---
M tests/storage_sdm_copy_data_test.py
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/64480/1

diff --git a/tests/storage_sdm_copy_data_test.py 
b/tests/storage_sdm_copy_data_test.py
index 5080aa8..9ec104d 100644
--- a/tests/storage_sdm_copy_data_test.py
+++ b/tests/storage_sdm_copy_data_test.py
@@ -277,7 +277,6 @@
 
 # TODO: Missing tests:
 # Copy between 2 different domains
-# Abort before copy
 
 
 class FakeQemuConvertChecker(object):


-- 
To view, visit https://gerrit.ovirt.org/64480
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I26e724560e9cb485fd4766ebcc04f644ad6431e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: SDM.copy_data test for abort while copying

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: SDM.copy_data test for abort while copying
..

tests: SDM.copy_data test for abort while copying

When a copy operation is aborted the final job status should be aborted
and the destination volume should be illegal.

Change-Id: I740d9ba42e3bd70865eadcb024ce6d9d8da0af95
Signed-off-by: Adam Litke 
---
M tests/storage_sdm_copy_data_test.py
1 file changed, 28 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/64479/1

diff --git a/tests/storage_sdm_copy_data_test.py 
b/tests/storage_sdm_copy_data_test.py
index fef85cc..5080aa8 100644
--- a/tests/storage_sdm_copy_data_test.py
+++ b/tests/storage_sdm_copy_data_test.py
@@ -19,6 +19,7 @@
 #
 from __future__ import absolute_import
 
+import threading
 import uuid
 from contextlib import contextmanager
 
@@ -29,6 +30,7 @@
 from storagetestlib import make_qemu_chain, write_qemu_chain, verify_qemu_chain
 from storagetestlib import ChainVerificationError
 from testlib import VdsmTestCase, expandPermutations, permutations
+from testlib import start_thread
 from testlib import wait_for_job
 
 from vdsm import jobs
@@ -252,10 +254,30 @@
 self.assertEqual(final_status, job.status)
 self.assertEqual(final_legality, dst_vol.getLegality())
 
+@permutations((('file',), ('block',)))
+def test_abort_during_copy(self, env_type):
+fmt = sc.RAW_FORMAT
+with self.get_vols(env_type, fmt, fmt) as (src_chain, dst_chain):
+src_vol = src_chain[0]
+dst_vol = dst_chain[0]
+source = dict(endpoint_type='div', sd_id=src_vol.sdUUID,
+  img_id=src_vol.imgUUID, vol_id=src_vol.volUUID)
+dest = dict(endpoint_type='div', sd_id=dst_vol.sdUUID,
+img_id=dst_vol.imgUUID, vol_id=dst_vol.volUUID)
+fake_convert = FakeQemuConvertChecker(src_vol, dst_vol,
+  ['/bin/read'])
+with MonkeyPatchScope([(qemuimg, 'convert', fake_convert)]):
+job_id = str(uuid.uuid4())
+job = storage.sdm.api.copy_data.Job(job_id, 0, source, dest)
+t = start_thread(job.run)
+fake_convert.started.wait()
+job.abort()
+self.assertEqual(jobs.STATUS.ABORTED, job.status)
+self.assertEqual(sc.ILLEGAL_VOL, dst_vol.getLegality())
+
 # TODO: Missing tests:
 # Copy between 2 different domains
 # Abort before copy
-# Abort during copy
 
 
 class FakeQemuConvertChecker(object):
@@ -263,8 +285,12 @@
 self.src_vol = src_vol
 self.dst_vol = dst_vol
 self.command = command
+self.started = threading.Event()
 
 def __call__(self, *args, **kwargs):
 assert sc.LEGAL_VOL == self.src_vol.getLegality()
 assert sc.ILLEGAL_VOL == self.dst_vol.getLegality()
-return qemuimg.QemuImgOperation(self.command)
+try:
+return qemuimg.QemuImgOperation(self.command)
+finally:
+self.started.set()


-- 
To view, visit https://gerrit.ovirt.org/64479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I740d9ba42e3bd70865eadcb024ce6d9d8da0af95
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Fix API schema to align with runtime schema

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Fix API schema to align with runtime schema
..


Patch Set 3:

* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1348255::OK, public bug
* Check Product::#1348255::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64477
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b5e90831fd0e4d9e897baaae4afb68f22e3877
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Fix API schema to align with runtime schema

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Fix API schema to align with runtime schema
..


Patch Set 2:

* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1348255::OK, public bug
* Check Product::#1348255::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64477
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b5e90831fd0e4d9e897baaae4afb68f22e3877
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Correct API schema to align with runtime schema

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Correct API schema to align with runtime schema
..


Patch Set 1:

* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1348255::OK, public bug
* Check Product::#1348255::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64477
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b5e90831fd0e4d9e897baaae4afb68f22e3877
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Correct API schema to align with runtime schema

[akrejcir]

Andrej Krejcir has uploaded a new change for review.

Change subject: Correct API schema to align with runtime schema
..

Correct API schema to align with runtime schema

Change-Id: Ia1b5e90831fd0e4d9e897baaae4afb68f22e3877
Bug-Url: https://bugzilla.redhat.com/1348255
Signed-off-by: Andrej Krejcir 
---
M lib/api/vdsm-api.yml
M lib/vdsm/jsonrpcvdscli.py
M lib/vdsm/rpc/Bridge.py
3 files changed, 33 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/64477/1

diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index c7ab7f5..1f1d569 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -2120,35 +2120,35 @@
 description: I/O tune parameters for the VM disk device.
 name: VmDiskDeviceIoTuneParams
 properties:
--   defaultvalue: needs updating
-description: Write throughput limit in bytes per
-second.
-name: write_bytes_sec
-type: uint
-
--   defaultvalue: needs updating
-description: Read I/O operations limit per second.
-name: read_iops_sec
-type: uint
-
--   defaultvalue: needs updating
-description: Read throughput limit in bytes per
-second.
-name: read_bytes_sec
-type: uint
-
--   defaultvalue: needs updating
+-   defaultvalue: 0 - means unlimited
 description: Total throughput limit in bytes per
 second.
 name: total_bytes_sec
 type: uint
 
--   defaultvalue: needs updating
+-   defaultvalue: 0 - means unlimited
+description: Read throughput limit in bytes per
+second.
+name: read_bytes_sec
+type: uint
+
+-   defaultvalue: 0 - means unlimited
+description: Write throughput limit in bytes per
+second.
+name: write_bytes_sec
+type: uint
+
+-   defaultvalue: 0 - means unlimited
 description: Total I/O operations limit per second.
 name: total_iops_sec
 type: uint
 
--   defaultvalue: needs updating
+-   defaultvalue: 0 - means unlimited
+description: Read I/O operations limit per second.
+name: read_iops_sec
+type: uint
+
+-   defaultvalue: 0 - means unlimited
 description: Write I/O operations limit per second.
 name: write_iops_sec
 type: uint
@@ -2577,20 +2577,6 @@
 type: *VmDeviceAddress
 type: object
 
-HotplugMemoryParams: 
-added: '3.6'
-description: Parameters for VM.hotplugMemory.
-name: HotplugMemoryParams
-properties:
--   description: The UUID of the VM to modify
-name: vmId
-type: *UUID
-
--   description: The memory device specification
-name: memory
-type: *VmMemoryDevice
-type: object
-
 VmInterfaceDeviceSpecParams: 
 added: '3.1'
 description: Additional VM interface device parameters.
@@ -2841,6 +2827,10 @@
 
 -   description: The amount of pages to scan during one cycle.
 name: pages_to_scan
+type: int
+
+-   description:
+name: merge_across_nodes
 type: int
 type: object
 
@@ -9771,9 +9761,10 @@
 name: vmID
 type: *UUID
 
--   description: The VM UUID and memory device information
-name: params
-type: *HotplugMemoryParams
+-   description: The memory device specification
+name: memory
+type: *VmMemoryDevice
+
 return:
 description: The VM definition, as updated
 type: *VmDefinition
diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index e276f86..c228e77 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -89,6 +89,7 @@
 'hotplugNic': 'VM.hotplugNic',
 'hotunplugDisk': 'VM.hotunplugDisk',
 'hotunplugNic': 'VM.hotunplugNic',
+'hotplugMemory': 'VM.hotplugMemory',
 'list': 'Host.getVMList',
 'migrate': 'VM.migrate',
 'migrateStatus': 'VM.getMigrationStatus',
@@ -99,7 +100,9 @@
 'setBalloonTarget': 'VM.setBalloonTarget',
 'setCpuTunePeriod': 'VM.setCpuTunePeriod',
 'setCpuTuneQuota': 'VM.setCpuTuneQuota',
+'setNumberOfCpus': 'VM.setNumberOfCpus',
 'setKsmTune': 'Host.setKsmTune',
+'setHaMaintenanceMode': 'Host.setHaMaintenanceMode',
 'setMOMPolicy': 'Host.setMOMPolicy',
 'setSafeNetworkConfig': 'Host.setSafeNetworkConfig',
 'setupNetworks': 'Host.setupNetworks',
diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py
index 5dedcc0..ceed1f9 100644
--- a/lib/vdsm/rpc/Bridge.py
+++ b/lib/vdsm/rpc/Bridge.py
@@ -356,6 +356,7 @@
 

Change in vdsm[master]: implementing SDM.move_domain_device

[automation]

gerrit-hooks has posted comments on this change.

Change subject: implementing SDM.move_domain_device
..


Patch Set 6:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63270
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74183d13061d114a59da23874c86186457046e94
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Define the SDM.move_domain_device API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Define the SDM.move_domain_device API
..


Patch Set 3:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64434
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6dce392d4cf157c42a47f70e972fa5d1d9dbdc2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: StorageDomain.getInfo - report lvm metadata device for block sd

[automation]

gerrit-hooks has posted comments on this change.

Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..


Patch Set 3:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64433
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a7763d2ab7d796be633ecd69f661cba96e29dde
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: StorageDomain.getInfo - report lvm metadata device for block sd

[automation]

gerrit-hooks has posted comments on this change.

Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..


Patch Set 3:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64433
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a7763d2ab7d796be633ecd69f661cba96e29dde
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: StorageDomain.getInfo - report lvm metadata device for block sd

[automation]

gerrit-hooks has posted comments on this change.

Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..


Patch Set 3:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64433
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a7763d2ab7d796be633ecd69f661cba96e29dde
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: StorageDomain.getInfo - report lvm metadata device for block sd

[laravot]

Liron Aravot has restored this change.

Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/64433
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I4a7763d2ab7d796be633ecd69f661cba96e29dde
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: StorageDomain.getInfo - report lvm metadata device for block sd

[automation]

gerrit-hooks has posted comments on this change.

Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..


Patch Set 2:

* update_tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/64433
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a7763d2ab7d796be633ecd69f661cba96e29dde
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: StorageDomain.getInfo - report lvm metadata device for block sd

[laravot]

Liron Aravot has abandoned this change.

Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/64433
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I4a7763d2ab7d796be633ecd69f661cba96e29dde
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: StorageDomain.getInfo - report lvm metadata device for block sd

[automation]

gerrit-hooks has posted comments on this change.

Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..


Patch Set 3:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64433
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a7763d2ab7d796be633ecd69f661cba96e29dde
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Introduce VolumeManifest.datapath_session

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Introduce VolumeManifest.datapath_session
..


Patch Set 1:

(8 comments)

https://gerrit.ovirt.org/#/c/64362/1//COMMIT_MSG
Commit Message:

Line 17: incrementation when exiting successfully which will also allow engine 
to
Line 18: determine if an operation was completed successfully.
Line 19: 
Line 20: All metadata updates must be performed to a single block with one write
Line 21: in order to ensure atomicity.
> Maybe separate the new context manger and its tests from the usage of this 
Sure.  Will do.
Line 22: 
Line 23: Change-Id: I30a3ac2971411778d24e007aac9fcb3009edb4c4


https://gerrit.ovirt.org/#/c/64362/1/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 231: source = dict(endpoint_type='div', sd_id=src_vol.sdUUID,
Line 232:   img_id=src_vol.imgUUID, 
vol_id=src_vol.volUUID)
Line 233: dest = dict(endpoint_type='div', sd_id=dst_vol.sdUUID,
Line 234: img_id=dst_vol.imgUUID, 
vol_id=dst_vol.volUUID)
Line 235: self.assertEqual(sc.LEGAL_VOL, src_vol.getLegality())
> We don't need this assert, since we don't except any change in the source v
Done
Line 236: self.assertEqual(sc.LEGAL_VOL, dst_vol.getLegality())
Line 237: fake_convert = FakeQemuConvertChecker(src_vol, dst_vol)
Line 238: with MonkeyPatchScope([(qemuimg, 'convert', 
fake_convert)]):
Line 239: job = storage.sdm.api.copy_data.Job(job_id, 0, 
source, dest)


Line 239: job = storage.sdm.api.copy_data.Job(job_id, 0, 
source, dest)
Line 240: job.run()
Line 241: wait_for_job(job)
Line 242: self.assertEqual(jobs.STATUS.DONE, job.status)
Line 243: self.assertEqual(sc.LEGAL_VOL, src_vol.getLegality())
> Same.
Done
Line 244: self.assertEqual(sc.LEGAL_VOL, dst_vol.getLegality())
Line 245: 
Line 246: # TODO: Missing tests:
Line 247: # Copy between 2 different domains


Line 240: job.run()
Line 241: wait_for_job(job)
Line 242: self.assertEqual(jobs.STATUS.DONE, job.status)
Line 243: self.assertEqual(sc.LEGAL_VOL, src_vol.getLegality())
Line 244: self.assertEqual(sc.LEGAL_VOL, dst_vol.getLegality())
> It would be nice to test that volume remain illegal when the operation fail
Done
Line 245: 
Line 246: # TODO: Missing tests:
Line 247: # Copy between 2 different domains
Line 248: # Abort before copy


Line 249: # Abort during copy
Line 250: 
Line 251: 
Line 252: class FakeQemuConvertChecker(object):
Line 253: def __init__(self, src_vol, dst_vol):
> We can make this more useful by accepting the command to run. To simulate s
Done
Line 254: self.src_vol = src_vol
Line 255: self.dst_vol = dst_vol
Line 256: 
Line 257: def __call__(self, *args, **kwargs):


https://gerrit.ovirt.org/#/c/64362/1/tests/storage_volume_test.py
File tests/storage_volume_test.py:

Line 110: vol.setMetadata = CountedInstanceMethod(vol.setMetadata)
Line 111: self.assertEqual(sc.LEGAL_VOL, vol.getLegality())
Line 112: with vol.datapath_session():
Line 113: self.assertEqual(sc.ILLEGAL_VOL, vol.getLegality())
Line 114: self.assertEqual(1, vol.setMetadata.nr_calls)
> I don't think this verification is needed, documenting how the method shoul
Actually, I am trying to validate that all metadata changes must be completed 
with a single write to storage so that we have atomic transitions.
Line 115: self.assertEqual(sc.LEGAL_VOL, vol.getLegality())
Line 116: self.assertEqual(2, vol.setMetadata.nr_calls)
Line 117: 
Line 118: def test_datapath_session_fail_inside_context(self):


https://gerrit.ovirt.org/#/c/64362/1/vdsm/storage/sdm/api/copy_data.py
File vdsm/storage/sdm/api/copy_data.py:

Line 139
Line 140
Line 141
Line 142
Line 143
> I think a property would make this much simpler:
Done


https://gerrit.ovirt.org/#/c/64362/1/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 497: """
Line 498: pass
Line 499: 
Line 500: @contextmanager
Line 501: def datapath_session(self):
> I'm not sure about the name.
Renamed to operation
Line 502: """
Line 503: Must be called with the Volume Lease held.
Line 504: 
Line 505: In order to detect interrupted datapath operations a volume 
should be


-- 
To view, visit https://gerrit.ovirt.org/64362
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30a3ac2971411778d24e007aac9fcb3009edb4c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins 

Change in vdsm[master]: virt: Initial support for post-copy migration

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Initial support for post-copy migration
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/62873/6/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 480:  self._compressed else 0) |
Line 481:  (libvirt.VIR_MIGRATE_AUTO_CONVERGE if
Line 482:  self._autoConverge else 0))
Line 483: if self._use_convergence_schedule:
Line 484: # TODO: Replace this whole block with simple flag 
setting once
> I'm not sure Vdsm is already capable of running on Fedora 24, but OK, this 
Vdsm *should* be run in F24, or, to word it differently, I'm not aware of any 
bug in this regard.
Line 485: # Vdsm depends on proper versions of QEMU and libvirt.
Line 486: try:
Line 487: flags |= libvirt.VIR_MIGRATE_POSTCOPY
Line 488: except AttributeError:


-- 
To view, visit https://gerrit.ovirt.org/62873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Initial support for post-copy migration

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Initial support for post-copy migration
..


Patch Set 8:

(3 comments)

partial review

https://gerrit.ovirt.org/#/c/62873/8/vdsm.spec.in
File vdsm.spec.in:

Line 187: Requires: libvirt-daemon-kvm >= 1.3.5
Line 188: %else # rhel
Line 189: Requires: libvirt-daemon-kvm >= 1.3.3
Line 190: Requires: libvirt-python >= 1.3.4
Line 191: %endif
ok, this may need to be split in a separate change, depending on the time of 
availability of the packages
Line 192: 
Line 193: # iscsi-intiator versions
Line 194: %if 0%{?rhel}
Line 195: Requires: iscsi-initiator-utils


https://gerrit.ovirt.org/#/c/62873/8/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 478
Line 479
Line 480
Line 481
Line 482
unrelated, please drop this change if you resubmit


PS8, Line 778: if self._vm._dom.migrateStartPostCopy(0) < 0:
ugh, this reads so C-ish :)
I'd prefer to use this idiom:

  ret = self._vm.dom.migrateStartPostCopy(0)
  if ret < 0:
#...

but this is mostly taste and personal preference, so I'll not press much for 
this.


-- 
To view, visit https://gerrit.ovirt.org/62873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Add qcow2_compat on create

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: Add qcow2_compat on create
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/64377/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2701: try:
Line 2702: qemuimg.create(transientPath, 
format=qemuimg.FORMAT.QCOW2,
Line 2703:backing=diskParams['path'],
Line 2704:backingFormat=driveFormat,
Line 2705:qcow2_compat=self._dom.qcow2_compat())
self._dom is not a storage domain, this is a libvirt.virDomain object.

Hopefully diskParams contains a domain id, so we can produce a domain manifest 
object.
Line 2706: os.fchmod(transientHandle, 0o660)
Line 2707: except Exception:
Line 2708: os.unlink(transientPath)  # Closing after deletion is 
correct
Line 2709: self.log.exception("Failed to create the transient disk 
for "


-- 
To view, visit https://gerrit.ovirt.org/64377
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I331eee6a12853c2fa65e62f42c51504f88723538
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: copy_data: Add qcow2_compat on convert.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: copy_data: Add qcow2_compat on convert.
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/64373/6/vdsm/storage/sdm/api/copy_data.py
File vdsm/storage/sdm/api/copy_data.py:

Line 137: 
Line 138: @property
Line 139: def qcow2_compat(self):
Line 140: dom = sdCache.produce_manifest(self.sd_id)
Line 141: return dom.qcow2_compat()
Nice!

But we need a tests for this:
- old volume copied with default compat to old domain
- old volume copied with new compat to new domain
- new volume copied with old compat to old domain
Line 142: 
Line 143: @property
Line 144: def backing_qemu_format(self):
Line 145: parent_vol = self._vol.getParentVolume()


-- 
To view, visit https://gerrit.ovirt.org/64373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26e5dcba6fc493b32ea7764889df2918c4dfdd3
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Minor typo fixes in Vm.getStats docstring

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Minor typo fixes in Vm.getStats docstring
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63550
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e07c9b237cf0af22ec8d0f7618ab655839839f2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Don't crash in migration progress on compression bytes

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Don't crash in migration progress on compression bytes
..


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/64468/1//COMMIT_MSG
Commit Message:

Line 9: If compression is not enabled for a migration then compression stats are
Line 10: not provided by libvirt.  So when we try to retrieve them in migration
Line 11: Progress, we must not expect their presence, otherwise we crash there.
Line 12: 
Line 13: Change-Id: I1885940843d705ead161c13258f1979025a03873
Backport-To: 4.0

?


-- 
To view, visit https://gerrit.ovirt.org/64468
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1885940843d705ead161c13258f1979025a03873
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: utils: build cert paths in single place

[fromani]

Francesco Romani has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 13:

(1 comment)

https://gerrit.ovirt.org/#/c/52354/13/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:

Line 154: EXT_KVM_2_OVIRT = '@LIBEXECDIR@/kvm2ovirt'
Line 155: EXT_SYSTEMD_RUN = '@SYSTEMD_RUN_PATH@'
Line 156: 
Line 157: # location of the certificates
Line 158: PKI_DIR = os.path.join(SYSCONF_PATH, 'pki', 'vdsm')
> Puting all constants in single module is not junkyard, this is a good way t
One module of constants per vertical looks like a good compromise, let's do 
that in a new topic branch
Line 159: KEY_FILE = os.path.join(PKI_DIR, 'keys', 'vdsmkey.pem')
Line 160: CERT_FILE = os.path.join(PKI_DIR, 'certs', 'vdsmcert.pem')


-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: contrib: Simple jsonrpc client

[automation]

gerrit-hooks has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 22:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: stomp: simplified client

[automation]

gerrit-hooks has posted comments on this change.

Change subject: stomp: simplified client
..


Patch Set 13:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Don't crash in migration progress on compression bytes

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: virt: Don't crash in migration progress on compression bytes
..


Patch Set 1:

backport to 4.0 as well, i suppose

-- 
To view, visit https://gerrit.ovirt.org/64468
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1885940843d705ead161c13258f1979025a03873
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Don't crash in migration progress on compression bytes

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: virt: Don't crash in migration progress on compression bytes
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64468
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1885940843d705ead161c13258f1979025a03873
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Initial support for post-copy migration

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: virt: Initial support for post-copy migration
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/62873/6/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 827: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_PROCESSED],
Line 828: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_REMAINING],
Line 829: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_BPS],
Line 830: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_CONSTANT],
Line 831: stats.get(libvirt.VIR_DOMAIN_JOB_COMPRESSION_BYTES, 0),
> Documentation doesn't say under what circumstances the attribute is present
thanks, then that patch has quite a priority since for legacy profiles we do 
not use compression, and since https://gerrit.ovirt.org/#/c/64178/ we do not 
enable it either for the default profile
Line 832: # available since libvirt 1.3
Line 833: stats.get('memory_dirty_rate', -1),
Line 834: # available since libvirt 1.3
Line 835: stats.get('memory_iteration', -1),


-- 
To view, visit https://gerrit.ovirt.org/62873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: stomp: simplified client

[automation]

gerrit-hooks has posted comments on this change.

Change subject: stomp: simplified client
..


Patch Set 12:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: contrib: Simple jsonrpc client

[automation]

gerrit-hooks has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 21:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Don't crash in migration progress on compression bytes

[mzamazal]

Milan Zamazal has uploaded a new change for review.

Change subject: virt: Don't crash in migration progress on compression bytes
..

virt: Don't crash in migration progress on compression bytes

If compression is not enabled for a migration then compression stats are
not provided by libvirt.  So when we try to retrieve them in migration
Progress, we must not expect their presence, otherwise we crash there.

Change-Id: I1885940843d705ead161c13258f1979025a03873
Signed-off-by: Milan Zamazal 
---
M vdsm/virt/migration.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/64468/1

diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index ef1f8a4..bed481e 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -790,7 +790,7 @@
 stats[libvirt.VIR_DOMAIN_JOB_MEMORY_REMAINING],
 stats[libvirt.VIR_DOMAIN_JOB_MEMORY_BPS],
 stats[libvirt.VIR_DOMAIN_JOB_MEMORY_CONSTANT],
-stats[libvirt.VIR_DOMAIN_JOB_COMPRESSION_BYTES],
+stats.get(libvirt.VIR_DOMAIN_JOB_COMPRESSION_BYTES, 0),
 # available since libvirt 1.3
 stats.get('memory_dirty_rate', -1),
 # available since libvirt 1.3


-- 
To view, visit https://gerrit.ovirt.org/64468
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1885940843d705ead161c13258f1979025a03873
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Initial support for post-copy migration

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Initial support for post-copy migration
..


Patch Set 6:

(4 comments)

https://gerrit.ovirt.org/#/c/62873/6/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 480:  self._compressed else 0) |
Line 481:  (libvirt.VIR_MIGRATE_AUTO_CONVERGE if
Line 482:  self._autoConverge else 0))
Line 483: if self._use_convergence_schedule:
Line 484: # TODO: Replace this whole block with simple flag 
setting once
> sure we do, but those are using upstream qemu-kvm which has it already
I'm not sure Vdsm is already capable of running on Fedora 24, but OK, this is 
for the future, let's bump the version requirements and remove this piece of 
code.
Line 485: # Vdsm depends on proper versions of QEMU and libvirt.
Line 486: try:
Line 487: flags |= libvirt.VIR_MIGRATE_POSTCOPY
Line 488: except AttributeError:


Line 490: pass
Line 491: # There is a QEMU bug causing post-copy migration 
fail when
Line 492: # (XBZRLE) compression is enabled.  So let's disable 
the
Line 493: # compression until we depend on a fixed QEMU version.
Line 494: # See https://bugzilla.redhat.com/1368422.
> for now, correct. So we won't include it in any profile.
OK, done.
Line 495: if flags & libvirt.VIR_MIGRATE_POSTCOPY:
Line 496: flags &= ~libvirt.VIR_MIGRATE_COMPRESSED
Line 497: self._vm._dom.migrateToURI3(duri, params, flags)
Line 498: else:


Line 787:downtime)
Line 788: self._vm._dom.migrateSetMaxDowntime(downtime, 0)
Line 789: elif action == CONVERGENCE_SCHEDULE_POST_COPY:
Line 790: self._vm.log.info('Switching to post-copy migration')
Line 791: if not hasattr(self._vm._dom, 'migrateStartPostCopy'):
> again, no need for that soon, so please do not handle it in the patch
Done
Line 792: self._vm.log.warn('Failed to switch to post-copy 
migration: '
Line 793:   'not supported')
Line 794: elif self._vm._dom.migrateStartPostCopy(0) < 0:
Line 795: # Do nothing for now; the next action will be invoked 
after a


Line 827: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_PROCESSED],
Line 828: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_REMAINING],
Line 829: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_BPS],
Line 830: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_CONSTANT],
Line 831: stats.get(libvirt.VIR_DOMAIN_JOB_COMPRESSION_BYTES, 0),
> hm, isn't it a bug then? can you please onfirm, i would expect it's 0 when 
Documentation doesn't say under what circumstances the attribute is present or 
not, I can confirm the problem exists (with pre-copy too), and looking into the 
libvirt source code the non-presence of any compression stats when compression 
is not enabled is clearly intentional.

Moved to a separate patch.
Line 832: # available since libvirt 1.3
Line 833: stats.get('memory_dirty_rate', -1),
Line 834: # available since libvirt 1.3
Line 835: stats.get('memory_iteration', -1),


-- 
To view, visit https://gerrit.ovirt.org/62873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: qemuimg: Add qcow_compat optional parameter.
..


Patch Set 18:

(2 comments)

https://gerrit.ovirt.org/#/c/64169/18/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 101: return info
Line 102: 
Line 103: 
Line 104: def create(image, size=None, format=None, backing=None,
Line 105:backingFormat=None, qcow2_compat=None):
This option is very clear here - format and qcow2_compat refer to the image 
being created. I also like the qcow2_compat style, but the old code is already 
using mixedCase, and we should match this style in the arguments.

Also the new argument refer to the format argument, not to the backing, so the 
argument should come after format=None.

Adding a parameter in the middle may break code calling this function 
incorrectly with positional arguments - this is good, we should fix such code.

Another option is to switch this all arguments to lower_case style before 
adding this option - this will be a very nice cleanup if you can spend the time 
on this rename. If not, please match the arguments to the existing ugly and 
error prone style.
Line 106: cmd = [_qemuimg.cmd, "create"]
Line 107: cwdPath = None
Line 108: 
Line 109: if format:


Line 168: if dstFormat:
Line 169: cmd.extend(("-O", dstFormat))
Line 170: if dstFormat == FORMAT.QCOW2:
Line 171: qcow2_compat = validate_qcow2_compat(qcow2_compat)
Line 172: options.append('compat=' + qcow2_compat)
But here he compat refer to the destination format (dstFormat), so it should be 
named dst_qcow2_compat, and the parameter should appear after dstFormat, and 
not after backingFormat.
Line 173: 
Line 174: if backing:
Line 175: if not os.path.isabs(backing):
Line 176: cwdPath = os.path.dirname(srcImage)


-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Initial support for post-copy migration

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Initial support for post-copy migration
..


Patch Set 8:

* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1354343::OK, public bug
* Check Product::#1354343::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Minor typo fixes in Vm.getStats docstring

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Minor typo fixes in Vm.getStats docstring
..


Patch Set 2:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63550
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e07c9b237cf0af22ec8d0f7618ab655839839f2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: utils: build cert paths in single place

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 13:

(1 comment)

https://gerrit.ovirt.org/#/c/52354/13/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:

Line 154: EXT_KVM_2_OVIRT = '@LIBEXECDIR@/kvm2ovirt'
Line 155: EXT_SYSTEMD_RUN = '@SYSTEMD_RUN_PATH@'
Line 156: 
Line 157: # location of the certificates
Line 158: PKI_DIR = os.path.join(SYSCONF_PATH, 'pki', 'vdsm')
> I'm sorry to tell you guys that this is not possible, it's causing circular
Puting all constants in single module is not junkyard, this is a good way to 
share constants in multiple modules without creating circular dependencies.

If you want to limit the junk, create constants module for each package 
(common, network, virt, storage).
Line 159: KEY_FILE = os.path.join(PKI_DIR, 'keys', 'vdsmkey.pem')
Line 160: CERT_FILE = os.path.join(PKI_DIR, 'certs', 'vdsmcert.pem')


-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: utils: build cert paths in single place

[automation]

gerrit-hooks has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 14:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: stomp: simplified client

[automation]

gerrit-hooks has posted comments on this change.

Change subject: stomp: simplified client
..


Patch Set 11:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: Log a setup networks transaction failure when using ovs...

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Log a setup networks transaction failure when using ovs 
switch
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64415
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: qemuimg: Add qcow_compat optional parameter.
..


Patch Set 18:

(3 comments)

https://gerrit.ovirt.org/#/c/64169/18/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 187: 
Line 188: return QemuImgOperation(cmd, cwd=cwdPath)
Line 189: 
Line 190: 
Line 191: def validate_qcow2_compat(qcow2_compat):
> I think this should be private helper (_validate_qcow2_compat), and it shou
done
Line 192: if qcow2_compat is None:
Line 193: qcow2_compat = default_qcow2_compat()
Line 194: if qcow2_compat in _QCOW2_COMPAT_SUPPORTED:
Line 195: return qcow2_compat


Line 189: 
Line 190: 
Line 191: def validate_qcow2_compat(qcow2_compat):
Line 192: if qcow2_compat is None:
Line 193: qcow2_compat = default_qcow2_compat()
> We can and should return here, we don't need to validate the return value o
Done
Line 194: if qcow2_compat in _QCOW2_COMPAT_SUPPORTED:
Line 195: return qcow2_compat
Line 196: else:
Line 197: raise ValueError("Invalid compat version '%r'" % qcow2_compat)


Line 193: qcow2_compat = default_qcow2_compat()
Line 194: if qcow2_compat in _QCOW2_COMPAT_SUPPORTED:
Line 195: return qcow2_compat
Line 196: else:
Line 197: raise ValueError("Invalid compat version '%r'" % qcow2_compat)
> This code works but it does not follow the vdsm style, using the happy path
Done
Line 198: 
Line 199: 
Line 200: class QemuImgOperation(object):
Line 201: REGEXPR = re.compile(r'\s*\(([\d.]+)/100%\)\s*')


-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: Setup validation for OVS - Check nics usage

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Setup validation for OVS - Check nics usage
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64414
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1ed8805f7e1b84e784feef14c5378b41af1cbf1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org