Dan Kenigsberg has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 26: Code-Review-1
Would you rebase on top of the master branch? I like to merge it regardless of
t
Dan Kenigsberg has posted comments on this change.
Change subject: virt: migration: replace magic number
..
Patch Set 9: Code-Review-1
Please rebase directly on master.
--
To view, visit http://gerrit.ovirt.org/28356
To unsub
Dan Kenigsberg has posted comments on this change.
Change subject: virt: migration: replace magic number
..
Patch Set 9: Code-Review+2
Let's see if git is smart enough.
--
To view, visit http://gerrit.ovirt.org/28356
To unsub
Dan Kenigsberg has posted comments on this change.
Change subject: test: fixing cif getinstance issue
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29882
To unsubscribe, visit http://gerrit.ovirt.org/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: migration: simplify the remote port handling
..
virt: migration: simplify the remote port handling
When the destination port for migrations is no
Dan Kenigsberg has posted comments on this change.
Change subject: virt: migration: simplify the remote port handling
..
Patch Set 5: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/29048/5//COMMIT_MSG
Commit Message:
L
Dan Kenigsberg has posted comments on this change.
Change subject: virt: migration: replace magic number
..
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28356
To unsubscribe, visit http://gerrit.ovirt.
Dan Kenigsberg has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 27: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25978
To unsubscribe, visit http://ger
Dan Kenigsberg has posted comments on this change.
Change subject: Add IO tunables support to updateVmPolicy
..
Patch Set 24:
(1 comment)
http://gerrit.ovirt.org/#/c/28715/24/vdsm/virt/vmtune.py
File vdsm/virt/vmtune.py:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: mailbox: Remove fatal, uneeded, and racy check
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29854
To unsubscribe, visit http://gerri
Dan Kenigsberg has posted comments on this change.
Change subject: net: skip network restoration if its physical devs are missing
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29832
To unsubscribe, vi
Dan Kenigsberg has posted comments on this change.
Change subject: netmodelsTests: Test IPv6.validateAddress and
IPv6.validatePrefixlen
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29906
To unsubscr
Dan Kenigsberg has posted comments on this change.
Change subject: libvirt_configure.sh: Unpersist logrotate libvirt
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/29731/1//COMMIT_MSG
Commit Message:
Li
Dan Kenigsberg has posted comments on this change.
Change subject: iface_sampling: Fix debug logging samples
..
Patch Set 1:
Now that we have the logs - can you tell why do we report a rate above 100%?
That DEBUG line intended
Dan Kenigsberg has submitted this change and it was merged.
Change subject: mailbox: Remove fatal, uneeded, and racy check
..
mailbox: Remove fatal, uneeded, and racy check
After errors in _checkForMail, the error handling code
Dan Kenigsberg has posted comments on this change.
Change subject: Add IO tunables support to updateVmPolicy
..
Patch Set 24:
(2 comments)
http://gerrit.ovirt.org/#/c/28715/24/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi
Dan Kenigsberg has posted comments on this change.
Change subject: vm: fix getVmPolicy return type.
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29930
To unsubscribe, visit http://gerrit.ovirt.org/se
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: fix getVmPolicy return type.
..
vm: fix getVmPolicy return type.
in case of error, getVmPolicy will return a VDSM API return
value, which may confu
Dan Kenigsberg has posted comments on this change.
Change subject: iface_sampling: Fix debug logging samples
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29916
To unsubscribe, visit http://gerrit.ovi
Dan Kenigsberg has posted comments on this change.
Change subject: netmodelsTests: Test IPv6.validateAddress and
IPv6.validatePrefixlen
..
Patch Set 1: Verified+1
TestNetmodels
testBondReorderOptions
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netmodelsTests: Test IPv6.validateAddress and
IPv6.validatePrefixlen
..
netmodelsTests: Test IPv6.validateAddress and IPv6.validatePrefixlen
Use addre
Dan Kenigsberg has posted comments on this change.
Change subject: Add IO tunables support to updateVmPolicy
..
Patch Set 25: Code-Review+2
Same as version acked by Francesco
--
To view, visit http://gerrit.ovirt.org/28715
To
Dan Kenigsberg has posted comments on this change.
Change subject: Add IO tunables support to updateVmPolicy
..
Patch Set 25: Code-Review-1
sorry... manual rebase and and rerun of vmTests.py
needed.
--
To view, visit http://
Dan Kenigsberg has posted comments on this change.
Change subject: tests: fix pep8 errors
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29960
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: fix pep8 errors
..
tests: fix pep8 errors
Commit: a2890d5d614e856a44102d61576a8591a8d2e52f
introduced pep8 and pyflakes errors in tests.
This pa
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add IO tunables support to updateVmPolicy
..
Add IO tunables support to updateVmPolicy
This allows the engine to set the hard and soft limits for IO.
M
Dan Kenigsberg has posted comments on this change.
Change subject: Add IO tunables support to updateVmPolicy
..
Patch Set 26: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28715
To unsubscribe, visit http://gerrit.ov
Dan Kenigsberg has posted comments on this change.
Change subject: Fix the return value definition of updateVmPolicy
..
Patch Set 14: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29498
To unsubscribe, visit http://g
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: migration: replace magic number
..
virt: migration: replace magic number
replace a magic constant with the symbolic name to clarify
the intent of
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: migration: use contextmanager for monitor
..
virt: migration: use contextmanager for monitor
This patch factors the monitor thread
control in a c
Dan Kenigsberg has posted comments on this change.
Change subject: virt: migration: decouple monitoring from thread
..
Patch Set 15: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26279/15/vdsm/virt/migration.py
File vd
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add setIoTune and getIoTunePolicy to the xml-rpc API
..
Add setIoTune and getIoTunePolicy to the xml-rpc API
Change-Id: I1cac66eb93b3702b6274b3dfd08161
Dan Kenigsberg has posted comments on this change.
Change subject: Add setIoTune and getIoTunePolicy to the xml-rpc API
..
Patch Set 20: Code-Review+2
Raising score.
--
To view, visit http://gerrit.ovirt.org/29115
To unsubscr
Dan Kenigsberg has posted comments on this change.
Change subject: Change method names in vmtune.py to the PEP8 style
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29929
To unsubscribe, visit http://g
Dan Kenigsberg has submitted this change and it was merged.
Change subject: mailbox: Fix unsafe locking
..
mailbox: Fix unsafe locking
In setMaxHostID, both _inLock and _outLock are acquired and released in
an unsafe way, not e
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: Shuting down protocol detector fails
..
vdsm: Shuting down protocol detector fails
When protocol detector is stopped during shutdown, an exceptio
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: disable virtio-rng on rhel < 6.6
..
Patch Set 12:
(1 comment)
http://gerrit.ovirt.org/#/c/28838/12//COMMIT_MSG
Commit Message:
Line 9: Virtio-rng suppor
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: disable virtio-rng on rhel < 6.6
..
Patch Set 14: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28838
To unsubscribe, visit http://gerrit.ovirt
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: disable virtio-rng on rhel < 6.6
..
vdsm: disable virtio-rng on rhel < 6.6
Virtio-rng support was added in libvirt 1.0.3, and is missing in
EL 6.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add API.VM.setIoTune
..
Add API.VM.setIoTune
This allows MoM (and the engine if necessary) to set the iotune
limits for disk devices.
Change-Id: I0bd4
Dan Kenigsberg has posted comments on this change.
Change subject: Add API.VM.getIoTunePolicy
..
Patch Set 25: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28896
To unsubscribe, visit http://gerrit.ovirt.org/setting
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add API.VM.getIoTunePolicy
..
Add API.VM.getIoTunePolicy
This method can be used by MoM to retrieve the current ioTune
boundaries from the domain xml m
Dan Kenigsberg has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 27: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28714
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Change method names in vmtune.py to the PEP8 style
..
Change method names in vmtune.py to the PEP8 style
Change-Id: Ib5e9dcaf393ebafe56f6bc78cc9cb02d37
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove noisy log message from CPU metadata collector
..
Remove noisy log message from CPU metadata collector
Change-Id: Ic186c68bf378e9e6016a568fc2a5e5
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Add symlink mount test
..
tests: Add symlink mount test
Some filesystems like gfs2 resolves symlink (as /dev/mapper/name or
/dev/vg/lv), and the
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Add symlink mount test
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/27514
To unsubscribe, visit http://gerrit.ovirt.org/setti
Dan Kenigsberg has posted comments on this change.
Change subject: Remove noisy log message from CPU metadata collector
..
Patch Set 1: Code-Review+2
I suppose whatever log message emitted by _sampleCpuTune() is enough.
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: sourceroutethread: fix logging string formatting
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/30010
To unsubscribe, visit http://ger
Dan Kenigsberg has posted comments on this change.
Change subject: tests: add simple balloon functional testcase
..
Patch Set 11: Code-Review-1
(1 comment)
Marking -1 until the mom issue is understood.
http://gerrit.ovirt.org
Dan Kenigsberg has posted comments on this change.
Change subject: virt: introduce a XML processing module
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26855
To unsubscribe, visit http://gerrit.ovirt
Dan Kenigsberg has posted comments on this change.
Change subject: virt: move __hacked_writexml in the vmxml module
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29694
To unsubscribe, visit http://ger
Dan Kenigsberg has posted comments on this change.
Change subject: vm: replace minidom.Element for memory snapshots
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29695
To unsubscribe, visit http://ger
Dan Kenigsberg has posted comments on this change.
Change subject: Configure modules without --force flag when isconfigure returns
false
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29992
To unsubsc
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Configure modules without --force flag when isconfigure returns
false
..
Configure modules without --force flag when isconfigure returns false
In http
Dan Kenigsberg has posted comments on this change.
Change subject: misc: Cleaner readspeed
..
Patch Set 1: Code-Review+2
Ib6145d018a691321976d684a9f355e3eb5252f83 is actually in ovirt-3.5 already, by
means of rebase.
--
To v
Dan Kenigsberg has posted comments on this change.
Change subject: misc: remove readfile function.
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29758
To unsubscribe, visit http://gerrit.ovirt.org/set
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Separate test runner from test library
..
tests: Separate test runner from test library
The test runner was used both as a script and as a libra
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Separate test runner from test library
..
Patch Set 3: Code-Review+2
raising so many acks!
--
To view, visit http://gerrit.ovirt.org/30022
To unsubscri
Dan Kenigsberg has posted comments on this change.
Change subject: virt: introduce a XML processing module
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26855
To unsubscribe, visit http://gerrit.ovirt
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: introduce a XML processing module
..
virt: introduce a XML processing module
this patch bootstrap a XML processing module for the
virt package, b
Dan Kenigsberg has submitted this change and it was merged.
Change subject: fix error handling in isdir and islink
..
fix error handling in isdir and islink
isdir and islink implemented using ioprocess will
throw an exception i
Dan Kenigsberg has posted comments on this change.
Change subject: virt: move __hacked_writexml in the vmxml module
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29694
To unsubscribe, visit http://ger
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: move __hacked_writexml in the vmxml module
..
virt: move __hacked_writexml in the vmxml module
No reason to keep this hack under the spotlight,
a
Dan Kenigsberg has posted comments on this change.
Change subject: vm: use vmxml.Element in setLinkAndNetwork
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29696
To unsubscribe, visit http://gerrit.ov
Dan Kenigsberg has uploaded a new change for review.
Change subject: Do not update timestamp on API.getVMList
..
Do not update timestamp on API.getVMList
Commit 95302a moved the call to _updateTimestamp from the XMLRPC binding
t
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: replace minidom.Element for memory snapshots
..
vm: replace minidom.Element for memory snapshots
The _memorySnapshot method used to manipulate dire
Dan Kenigsberg has posted comments on this change.
Change subject: vm: use vmxml.Element in snapshot method
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29697
To unsubscribe, visit http://gerrit.ovir
Dan Kenigsberg has posted comments on this change.
Change subject: virt: xml: add function to iterate over devices
..
Patch Set 3: Code-Review-1
Naming nit.
--
To view, visit http://gerrit.ovirt.org/29698
To unsubscribe, visi
Dan Kenigsberg has posted comments on this change.
Change subject: virt: xml: add function to iterate over devices
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/29698/3/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Li
Dan Kenigsberg has posted comments on this change.
Change subject: virt: move _DomXML into the xml module
..
Patch Set 3: Code-Review-1
(1 comment)
please re-check for similar glitches.
http://gerrit.ovirt.org/#/c/29699/3/vds
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: disable virtio-rng on rhel < 6.6
..
Patch Set 1:
For eedri sake, please add a Bug-Url, or state why none is needed.
--
To view, visit http://gerrit.ovir
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Degrading epoll errors in vmchannels to log level INFO
..
Degrading epoll errors in vmchannels to log level INFO
Error events from epoll are quite comm
Dan Kenigsberg has posted comments on this change.
Change subject: Degrading epoll errors in vmchannels to log level INFO
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/30141
To unsubscribe, visit http
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: use vmxml.Element in snapshot method
..
vm: use vmxml.Element in snapshot method
Use vmxml.Element instead of xml.dom.minidom.Element
in vm.snapsho
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: use vmxml.Element in setLinkAndNetwork
..
vm: use vmxml.Element in setLinkAndNetwork
Use vmxml.Element instead of xml.dom.minidom.Element
in vm.set
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: make _isDomainRunning more robust
..
vm: make _isDomainRunning more robust
The Vm._dom atrribute may be set to None
asynchronously by the _onQemuDe
Dan Kenigsberg has posted comments on this change.
Change subject: vm: make _isDomainRunning more robust
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/30139
To unsubscribe, visit http://gerrit.ovirt.o
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: disable virtio-rng on rhel < 6.6
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/30196
To unsubscribe, visit http://gerrit.ovirt.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: volumeTests: add BlockDomainMetadataSlotTest
..
volumeTests: add BlockDomainMetadataSlotTest
A new test has been added to check the metadata slot selec
Dan Kenigsberg has posted comments on this change.
Change subject: volumeTests: add BlockDomainMetadataSlotTest
..
Patch Set 4: Code-Review+2
raising score
--
To view, visit http://gerrit.ovirt.org/26266
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsm: remove unused md_utils module
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29823
To unsubscribe, visit http://gerrit.ovir
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsm: remove unused md_utils module
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29823
To unsubscribe, visit http://gerrit.ovir
Dan Kenigsberg has submitted this change and it was merged.
Change subject: supervdsm: remove unused md_utils module
..
supervdsm: remove unused md_utils module
The method getMdDeviceUuidMap was added in commit b9b6ca2 without
Dan Kenigsberg has uploaded a new change for review.
Change subject: connectivity log: report dropped devices
..
connectivity log: report dropped devices
When a networking device is removed from the host it (and its most
recentl
Dan Kenigsberg has uploaded a new change for review.
Change subject: connectivity log: report if Engine has been seen recently
..
connectivity log: report if Engine has been seen recently
Vdsm monitors when it has been accessed
Dan Kenigsberg has uploaded a new change for review.
Change subject: connectivty log: log duplex state
..
connectivty log: log duplex state
Add detected changes of full/half duplex to connectivity.log
Bug-Url: https://bugzilla.
Dan Kenigsberg has posted comments on this change.
Change subject: Do not update timestamp on API.getVMList
..
Patch Set 2: Verified+1
With this patch, connectivity check works again, reverting failed network
configuration.
-
Dan Kenigsberg has uploaded a new change for review.
Change subject: API.updateTimestamp: use touchFile
..
API.updateTimestamp: use touchFile
Opening a file for writing with the file() constructor is frowned upon.
Particularly w
Dan Kenigsberg has posted comments on this change.
Change subject: Support ioTune values >2^31 in getStats over xml-rpc
..
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/30215/2/vdsm/virt/vm.py
File vdsm/vi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Support ioTune values >2^31 in getStats over xml-rpc
..
Support ioTune values >2^31 in getStats over xml-rpc
This fixes issue with getStats over xml-rp
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsm: remove unused lsblk module
..
Patch Set 2: Code-Review+2
nothing left in `git grep lsblk`
--
To view, visit http://gerrit.ovirt.org/30212
To unsubs
Dan Kenigsberg has submitted this change and it was merged.
Change subject: supervdsm: remove unused lsblk module
..
supervdsm: remove unused lsblk module
The method getLsBlk was added in commit 6ee565b without any explanation
Dan Kenigsberg has posted comments on this change.
Change subject: connectivty log: log duplex state
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/30225/1/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 671:
Dan Kenigsberg has posted comments on this change.
Change subject: connectivty log: log duplex state
..
Patch Set 2: Verified+1
Just fixed whitespace.
Verified that duplex is reported if available. I did not verify a change of
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Restore BC for block type live snapshots
..
virt: Restore BC for block type live snapshots
Commit 02741ce introduced a regression in older hosts
Dan Kenigsberg has posted comments on this change.
Change subject: virt: Restore BC for block type live snapshots
..
Patch Set 1: Code-Review+2
Yaniv is away this weekend, taking over.
--
To view, visit http://gerrit.ovirt.or
Dan Kenigsberg has posted comments on this change.
Change subject: vm: graphdev: fix parameter passing
..
Patch Set 7: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/28036/7//COMMIT_MSG
Commit Message:
Line 5: CommitDa
Dan Kenigsberg has posted comments on this change.
Change subject: virt: move _DomXML into the xml module
..
Patch Set 4: Code-Review+2
verified that the added code is identical to the dropped code, up to
vmxml.Element->EleEle
Dan Kenigsberg has posted comments on this change.
Change subject: virt: xml: add utility functions
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/29698/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 5867:
701 - 800 of 21419 matches
Mail list logo
