Nir Soffer has posted comments on this change.
Change subject: tool: change enumeration naming.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34046/1/lib/vdsm/tool/configurators/__init__.py
File
Nir Soffer has posted comments on this change.
Change subject: tool: extend ModuleConfigurer documentation.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34045/1/lib/vdsm/tool/configurators/__init__.py
File
Nir Soffer has posted comments on this change.
Change subject: vdsm-infra: zombie-reaper refactor
..
Patch Set 3:
This patch seems to delete zombiereaper code instead of moving it to
infra/zombiereaper.py.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: assert: Replace assetion with AssertionError
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/29307/3//COMMIT_MSG
Commit Message:
Line 5: CommitDate:
Nir Soffer has posted comments on this change.
Change subject: assert: Replace assetion with AssertionError
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/29307/3//COMMIT_MSG
Commit Message:
Line 5: CommitDate:
Nir Soffer has posted comments on this change.
Change subject: tool: extend ModuleConfigurer documentation.
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/34045/1/lib/vdsm/tool/configurators/__init__.py
File
Nir Soffer has posted comments on this change.
Change subject: multipath: use a backup file instead of rotateFiles
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/34077/1/vdsm/storage/multipath.py
File
Nir Soffer has posted comments on this change.
Change subject: core: Add python warnings boilerplate
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34034
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: ioprocess: Move and reword rename() warning
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32194
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tool: change enumeration naming.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34046/1//COMMIT_MSG
Commit Message:
Line 7: tool: change enumeration
Nir Soffer has posted comments on this change.
Change subject: tool: change enumeration naming.
..
Patch Set 2: Code-Review-1
This does not improve anything.
See my comment here why:
Nir Soffer has posted comments on this change.
Change subject: tool: extend ModuleConfigurer documentation.
..
Patch Set 2: Code-Review-1
This does two unrelated changes:
1. Change the indentation of existing docstrings from:
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: Bridge.py reducing logging level
..
Patch Set 1: Code-Review-1
(2 comments)
This fix is not good enough, leaving unneeded and unhelpful messages in the
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: Bridge.py reducing logging level
..
Patch Set 1:
The example log is just one instnace - we have many of these blocks in real log.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: tool: change configure verb logic.
..
Patch Set 1:
(1 comment)
Does this problem exist in current code?
Please base this patch on current code, not on other
Nir Soffer has posted comments on this change.
Change subject: tool: change configure verb logic.
..
Patch Set 1: Code-Review-1
And even more important - never mix refactoring and fix.
Moving the selection of modules to
/tool/configurators/__init__.py:
Line 51: - Check configuration status and validity during init.
Line 52:
Line 53: @property
Line 54: def name(self):
Line 55: Return module name to be used with the --module option.
nsoffer, if it passes pep8 it's OK.
Saggi, as you say
Nir Soffer has posted comments on this change.
Change subject: supervdsm: Add wait for SIGKILLed processes
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34142/1/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line
Nir Soffer has posted comments on this change.
Change subject: supervdsm: Add wait for SIGKILLed processes
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34142/1/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line
Nir Soffer has posted comments on this change.
Change subject: supervdsm: Add wait for SIGKILLed processes
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34142/1/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line
Nir Soffer has posted comments on this change.
Change subject: supervdsm: Add wait for SIGKILLed processes
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/34142/2/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line
Nir Soffer has uploaded a new change for review.
Change subject: tests: Fix patchDecorators so decorated function will actually
run
..
tests: Fix patchDecorators so decorated function will actually run
Commit 5c5a0d9c5
Nir Soffer has posted comments on this change.
Change subject: supervdsm: Add wait for SIGKILLed processes
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/34142/2/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line
Nir Soffer has posted comments on this change.
Change subject: tests: Fix patchDecorators so decorated function will actually
run
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/34153
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: supervdsm: Add zombiereaper to supervdsm
..
Patch Set 13:
(1 comment)
http://gerrit.ovirt.org/#/c/28915/13/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line
Nir Soffer has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 12:
(2 comments)
Partial review
http://gerrit.ovirt.org/#/c/29392/12/vdsm/supervdsmServer
File
Hello Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/34162
to review the following change.
Change subject: supervdsmServer: Do not use udev to set permissions on external
luns
Nir Soffer has posted comments on this change.
Change subject: tests: Fix patchDecorators so decorated function will actually
run
..
Patch Set 1:
We need this for 3.5, otherwise we may miss test failures.
--
To view, visit
Nir Soffer has uploaded a new change for review.
Change subject: multiapth: Disable hba rescanning by default
..
multiapth: Disable hba rescanning by default
Since commit 85d46e4572 we are scanning both iscsi bus and hbas when
Nir Soffer has posted comments on this change.
Change subject: multiapth: Disable hba rescanning by default
..
Patch Set 1: Verified+1
Verified that hba rescanning is disabled by default and can be enabled in
vdsm.conf.
--
Nir Soffer has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 14:
Dima, would you reply to my comments on version 12?
-
Nir Soffer has posted comments on this change.
Change subject: tool: extend ModuleConfigurer documentation.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34045/1/lib/vdsm/tool/configurators/__init__.py
File
Nir Soffer has posted comments on this change.
Change subject: supervdsm: Add zombiereaper to supervdsm
..
Patch Set 16: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/28915/16/vdsm/supervdsmServer
File
Nir Soffer has posted comments on this change.
Change subject: multiapth: Disable hba rescanning by default
..
Patch Set 1:
(3 comments)
http://gerrit.ovirt.org/#/c/34176/1//COMMIT_MSG
Commit Message:
Line 8:
Line 9: Since
Nir Soffer has posted comments on this change.
Change subject: multiapth: Disable hba rescanning by default
..
Patch Set 2:
Version 2 fixes typos in the commit message and explain why we need a evil
configuration option.
--
Nir Soffer has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 14:
I would not spent time on adding unregister() api, since this is kind of
library that you use once in
Nir Soffer has uploaded a new change for review.
Change subject: multiapth: Disable hba rescanning by default
..
multiapth: Disable hba rescanning by default
Since commit 85d46e4572 we are scanning both iscsi bus and hbas when
Nir Soffer has posted comments on this change.
Change subject: multiapth: Disable hba rescanning by default
..
Patch Set 1:
Patch for GSS - not for review.
--
To view, visit http://gerrit.ovirt.org/34196
To unsubscribe,
Hello Federico Simoncelli,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/34215
to review the following change.
Change subject: multiapth: Disable hba rescanning by default
..
multiapth: Disable
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 6:
Version 6 is rebase on master and update the commit message.
manhole-1.0.0 supports now the required
Nir Soffer has posted comments on this change.
Change subject: tool: change configurators from classes to modules.
..
Patch Set 2: Code-Review-1
(22 comments)
I don't we need this change, as it does not help anyone, and does
Nir Soffer has posted comments on this change.
Change subject: tool: extend ModuleConfigurer documentation.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34045/1/lib/vdsm/tool/configurators/__init__.py
File
Nir Soffer has posted comments on this change.
Change subject: tool: extend ModuleConfigurer documentation.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34045/1/lib/vdsm/tool/configurators/__init__.py
File
Nir Soffer has posted comments on this change.
Change subject: tool: extend ModuleConfigurer documentation.
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/34045/3/lib/vdsm/tool/configurators/__init__.py
File
Nir Soffer has posted comments on this change.
Change subject: tool: change configurators from classes to modules.
..
Patch Set 2:
(3 comments)
http://gerrit.ovirt.org/#/c/34047/2/lib/vdsm/tool/configurators/__init__.py
File
Nir Soffer has posted comments on this change.
Change subject: tool: change configurators from classes to modules.
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/34047/2/lib/vdsm/tool/configurators/__init__.py
File
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 6: Verified+1
Tested on rhel 6.6 and 7.
--
To view, visit http://gerrit.ovirt.org/32147
To unsubscribe,
Nir Soffer has uploaded a new change for review.
Change subject: hba: Rescan using SCSI layer
..
hba: Rescan using SCSI layer
Commit 66c24c1996 (iscsi: Iscsi rescan cleanup) was little too deep,
disabling rescanning of HBAs.
Nir Soffer has posted comments on this change.
Change subject: hba: Rescan using SCSI layer
..
Patch Set 1:
I did not test it yet with FC server where I can add devices, so I don't know
if this will actually work, or we will
Nir Soffer has posted comments on this change.
Change subject: hba: Rescan using SCSI layer
..
Patch Set 2:
Version 2 adds scsi_minimal_timeout delay after scanning, so multipath can
discover new devices.
This is horrible
Nir Soffer has posted comments on this change.
Change subject: multiapth: Disable hba rescanning by default
..
Patch Set 1:
If http://gerrit.ovirt.org/34245 works, it can replace this one.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: hba: Rescan using SCSI layer
..
Patch Set 2:
Saggi, how writing to sysfs can block? The driver suspend the caller until the
scan is complete?
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: hba: Rescan using SCSI layer
..
Patch Set 2:
I'll check how isciadm is implementing this - from the trace it seems that it
is using O_NOBLOCK for writing to the
Nir Soffer has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 15:
(4 comments)
Need to remove the return value of register.
Other than that, it can be simpler. This
Nir Soffer has posted comments on this change.
Change subject: hba: Rescan using SCSI layer
..
Patch Set 2:
I found bug 844180, that was the trigger for adding scsi timeouts and writing
to sysfs using multiple dd proceses.
Nir Soffer has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 15:
(2 comments)
http://gerrit.ovirt.org/#/c/29392/15/lib/vdsm/sigutils.py
File lib/vdsm/sigutils.py:
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: Bridge.py reducing logging level
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34097/1/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 208:
Nir Soffer has posted comments on this change.
Change subject: multiapth: Disable hba rescanning by default
..
Patch Set 1: Verified+1
Tested again on rhel 6.6 and 7.
http://gerrit.ovirt.org/34245 will take some time to
Nir Soffer has posted comments on this change.
Change subject: multiapth: Disable hba rescanning by default
..
Patch Set 2:
Version 2 fixes the commit hash that enabled issue_lip. The master version
contains unrelated commit
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: Bridge.py reducing logging level
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/34097/2/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 209:
Nir Soffer has posted comments on this change.
Change subject: virt: migration: use running() for downtime thread
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33032
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: virt: migration: avoid implicit thread start
..
Patch Set 1: Code-Review+1
I shared your dislike of starting stuff in init.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: virt: migration: rename cancel-stop method
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/33030/1/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Nir Soffer has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 15:
(1 comment)
http://gerrit.ovirt.org/#/c/29392/15/lib/vdsm/sigutils.py
File lib/vdsm/sigutils.py:
Nir Soffer has posted comments on this change.
Change subject: protocoldetector: Remove connection after handshake error
..
Patch Set 5:
Version 5 fixes trivial merge conflict after another patch was merged.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: protocoldetector: Introduce _close_connection
..
Patch Set 2:
Version 2 rebased, no code change.
--
To view, visit http://gerrit.ovirt.org/33988
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: Bridge.py reducing logging level
..
Patch Set 3: Code-Review+1
Thanks for keeping vdsm log clean!
--
To view, visit http://gerrit.ovirt.org/34097
To
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 6:
Saggi, it looks that manhole integration and improving gdb python support are
different things, and I
Nir Soffer has uploaded a new change for review.
Change subject: protocoldetector: Use values() instead of items()
..
protocoldetector: Use values() instead of items()
Iterating on items is useful when we need the keys, but we
Nir Soffer has uploaded a new change for review.
Change subject: protocoldetector: Avoid unneeded syscalls
..
protocoldetector: Avoid unneeded syscalls
When cleaning up non-responsive connections, it is enough to get the
Nir Soffer has uploaded a new change for review.
Change subject: protocoldetector: Unify log messages
..
protocoldetector: Unify log messages
We stare at vdsm logs for hours, lets make it little nicer.
Change-Id:
Nir Soffer has posted comments on this change.
Change subject: protocoldetector: Avoid unneeded syscalls
..
Patch Set 2: Verified+1
Rebase
--
To view, visit http://gerrit.ovirt.org/34331
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: protocoldetector: Use values() instead of items()
..
Patch Set 2: Verified+1
Version 2 refines the commit message
--
To view, visit http://gerrit.ovirt.org/34330
Nir Soffer has posted comments on this change.
Change subject: multiapth: Disable hba rescanning by default
..
Patch Set 1:
Do we need this for ovirt-3.4? I have another downstream patch.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: protocoldetector: Unify log messages
..
Patch Set 1: Verified+1
Verified that logs are nicer now
--
To view, visit http://gerrit.ovirt.org/34334
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: assert: Replace assetion with AssertionError
..
Patch Set 3:
(9 comments)
I think that most of the original asserts are correct. Since assert are not
reliable
Nir Soffer has posted comments on this change.
Change subject: assert: Replace assetion with AssertionError
..
Patch Set 3:
Replacing these asserts was requested by Federico, so lets wait for him.
If you think we control vdsm
Nir Soffer has posted comments on this change.
Change subject: assert: Replace assetion with AssertionError
..
Patch Set 3:
(4 comments)
http://gerrit.ovirt.org/#/c/29307/3/lib/vdsm/libvirtconnection.py
File
Nir Soffer has posted comments on this change.
Change subject: assert: Replace assetion with AssertionError
..
Patch Set 3:
I will split the patches as you suggest.
--
To view, visit http://gerrit.ovirt.org/29307
To
Nir Soffer has posted comments on this change.
Change subject: rpc: Replace misuse of assert with TypeError
..
Patch Set 4:
Version 4 split the original patch so each use case and project area can be
handled separately.
--
Nir Soffer has uploaded a new change for review.
Change subject: netinfo: Replace misused asserts with InvalidConfiguration
..
netinfo: Replace misused asserts with InvalidConfiguration
The code was assuming that asserts are
Nir Soffer has uploaded a new change for review.
Change subject: schema: Fix asserts that had side effect
..
schema: Fix asserts that had side effect
Asserts should never have side effects, so optimizing them out will not
Nir Soffer has uploaded a new change for review.
Change subject: libvirtconnection: Replace assert with AssertionError
..
libvirtconnection: Replace assert with AssertionError
The code wrongly assumed that assert always exists.
Nir Soffer has posted comments on this change.
Change subject: context manager for dhclient in functional tests
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/34366/2/tests/functional/dhcp.py
File
Nir Soffer has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/33783/2//COMMIT_MSG
Commit Message:
Line 7: sampling: extract
Nir Soffer has posted comments on this change.
Change subject: sampling: update module docstring
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/33785/2/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 18: #
Nir Soffer has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 2:
(6 comments)
Nice refactoring, added some naming suggestions.
Nir Soffer has posted comments on this change.
Change subject: libvirtconnection: add credentials other then defalut
..
Patch Set 6: Code-Review-1
(2 comments)
The added docstring is not clear.
Nir Soffer has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 12: Code-Review-1
(1 comment)
Partial review - incorrect use of try-finally in v2v.
Nir Soffer has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 12:
(12 comments)
Added few suggestions for making the code nicer.
Nir Soffer has posted comments on this change.
Change subject: BZ#844656 Release the _syncroot lock during _findDomain
..
Patch Set 7:
(2 comments)
http://gerrit.ovirt.org/#/c/6822/7/vdsm/storage/sdc.py
File
Nir Soffer has posted comments on this change.
Change subject: virt: migration: rename cancel-stop method
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33030
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: clean dhclient processes that are left after functional tests
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34366
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: rpc: Replace misuse of assert with TypeError
..
Patch Set 4:
I don't know if the assert is really needed, maybe it is just a leftover that
we can remove - I did
Nir Soffer has uploaded a new change for review.
Change subject: hba: Parallel hba scanning
..
hba: Parallel hba scanning
When scanning multiple HBAs, it canning one HBA blocks for long time,
the scan may timeout before we
Nir Soffer has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 14:
(12 comments)
I think this version is a regression.
http://gerrit.ovirt.org/#/c/33309/14/vdsm/v2v.py
File
Nir Soffer has posted comments on this change.
Change subject: image: use qemu-img convert to copy internal volumes
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/33355/2/vdsm/storage/image.py
File
Nir Soffer has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 4:
(4 comments)
New docstrings can be refined.
Also some comment that probably can be handled later, to keep
Nir Soffer has posted comments on this change.
Change subject: clean dhclient processes that are left after functional tests
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/34366/3/tests/functional/dhcp.py
File
Nir Soffer has posted comments on this change.
Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same
subnet
..
Patch Set 17: Code-Review-1
(9 comments)
Setting loose rpfilter seems too loose, even
1301 - 1400 of 11706 matches
Mail list logo
