Nir Soffer has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: configurator.py: fix _removeFile to do as described in it's doc
string.
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31778
To
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 6:
I think the rebase should be easy - just move the new class to its own module.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: tool: Remove pointless __init__ methods
..
Patch Set 1:
Why do we need this in 3.5?
--
To view, visit http://gerrit.ovirt.org/32060
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/31741/5/lib/vdsm/tool/configurators/__init__.py
File
Nir Soffer has posted comments on this change.
Change subject: configurator: Too many constants to import separately
..
Patch Set 3:
Why do we need this in 3.5?
--
To view, visit http://gerrit.ovirt.org/32046
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: tool: Remove pointless __init__ methods
..
Patch Set 2: Code-Review-1
I don't think we need this in 3.5 - it does not fix any bug and is no other
patch depends on
Nir Soffer has posted comments on this change.
Change subject: el6_tests: fix toolTests to use VdsmTestCase so that assertIn
is available
..
Patch Set 1:
Do we need this in 3.5?
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 7: Verified+1
Rebase after significant changes in master and address Antoni comment.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: tool: Remove duplicate names
..
Patch Set 6: Verified+1
Rebase after significant changes in master.
--
To view, visit http://gerrit.ovirt.org/31775
To
Nir Soffer has posted comments on this change.
Change subject: el6_tests: fix toolTests to use VdsmTestCase so that assertIn
is available
..
Patch Set 1: Code-Review+1
Correct.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: configfile: sort dict items inserted to config files for
consistency.
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32062
To
Nir Soffer has posted comments on this change.
Change subject: tests: Fix Python 2.6 compatibility
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32102
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tool: Fix TypeError when configuration check fails
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32061
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tool: Fix help message when is-configured fails
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32059
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tool: Use space after comma when formatting lists
..
Patch Set 2: Code-Review+1
I think we could skip this, but you already spent time on it.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: tool: Fix another Python 2.6 compatibility issue
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32057
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tool: Fix compatibility with Python 2.6
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32056
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tool: Raise UsageError when used incorrectly
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32053
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tool: Fix error message for non-existing module
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32055
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tool: Remove pointless __init__ methods
..
Patch Set 2: -Code-Review
--
To view, visit http://gerrit.ovirt.org/32060
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: el6_tests: testlib not available at el6.5
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/32124/2//COMMIT_MSG
Commit Message:
Line 5:
Nir Soffer has posted comments on this change.
Change subject: el6_tests: fix toolTests to use VdsmTestCase so that assertIn
is available
..
Patch Set 1:
On 3.5, VdsmTestCase is imported from testrunner, not testlib.
On
Nir Soffer has posted comments on this change.
Change subject: el6_tests: fix toolTests to use VdsmTestCase so that assertIn
is available
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32103/1/tests/toolTests.py
Nir Soffer has posted comments on this change.
Change subject: oop: Use Storage.oop logger
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/31908/2//COMMIT_MSG
Commit Message:
Line 9: Use storage logger to avoid oop
Nir Soffer has posted comments on this change.
Change subject: oop: Use Storage.oop logger
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/31908/2//COMMIT_MSG
Commit Message:
Line 9: Use storage logger to avoid oop
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Simplify pivot flow
..
Patch Set 2:
(2 comments)
Much better, but not clear why do we need the pivot and cleanup modes, which
can be simplified to
Nir Soffer has posted comments on this change.
Change subject: el6_tests: testlib not available at el6.5
..
Patch Set 2:
The backport is already 3.5 only :-)
--
To view, visit http://gerrit.ovirt.org/32124
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: lvm: Exclude faulty devices from lvm long filter
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/31875/2/vdsm/storage/multipath.py
File
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Mark active layer ILLEGAL before pivoting
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31787/3/vdsm/storage/hsm.py
File
Nir Soffer has posted comments on this change.
Change subject: el6_tests: fix toolTests to use VdsmTestCase so that assertIn
is available
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32103
To
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Suspend disk stats collection during pivot
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/31367/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Nir Soffer has posted comments on this change.
Change subject: sampling: do not produce stats for missing disks
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/30029/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 540:
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Simplify pivot flow
..
Patch Set 3:
(1 comment)
Much clear now, thanks!
http://gerrit.ovirt.org/#/c/31849/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Nir Soffer has posted comments on this change.
Change subject: utils: Use ovirt node for persist and unpersist files
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/31584/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Nir Soffer has uploaded a new change for review.
Change subject: debug: Integrate manhole debugging service
..
debug: Integrate manhole debugging service
Manhole is in-process service that will accept unix domain socket
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 1:
Untested - posted so people can try this awesome thing.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32147/1//COMMIT_MSG
Commit Message:
Line 22:
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Mark active layer ILLEGAL before pivoting
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31787
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32147/1//COMMIT_MSG
Commit Message:
Line 22:
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 2:
Use safer and more convenient /var/run/vdsm/vdsmd.manhole
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: ioprocess: Move and reword rename() warning log line
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32194/1/vdsm/storage/outOfProcess.py
File
Nir Soffer has posted comments on this change.
Change subject: oop: Use Storage.oop logger
..
Patch Set 2: Code-Review+1
We have a new patch for dealing with the unneeded warning.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: ioprocess: Move and reword rename() warning log line
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32194/1/vdsm/storage/outOfProcess.py
File
Nir Soffer has uploaded a new change for review.
Change subject: ipwrapper: Use zombiereaper to wait for process
..
ipwrapper: Use zombiereaper to wait for process
Commit aea8aab95f eliminated ip process zombies by waiting for
Nir Soffer has uploaded a new change for review.
Change subject: multipath: Disable queuing on all multipath devices
..
multipath: Disable queuing on all multipath devices
We specify no_path_retry fail in multipath
Nir Soffer has posted comments on this change.
Change subject: lvm: Exclude faulty devices from lvm long filter
..
Patch Set 2:
Should be replaced by http://gerrit.ovirt.org/32277.
Keeping this in case the new approach fails.
Nir Soffer has posted comments on this change.
Change subject: hsm: check volume existence in prepareImage
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/31937/2/vdsm/storage/hsm.py
File
Nir Soffer has posted comments on this change.
Change subject: multipath: Disable queuing on all multipath devices
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/32277/1/vdsm/storage/vdsm-multipath.rules.in
File
Nir Soffer has posted comments on this change.
Change subject: tests: Use frozenset instead of set
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31786/3/tests/toolTests.py
File tests/toolTests.py:
Line 73
Line 74
Nir Soffer has posted comments on this change.
Change subject: tests: Use frozenset instead of set
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31786/3//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2014-08-26
Nir Soffer has posted comments on this change.
Change subject: profiling: Add support for memory profiling
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/32019/2/lib/vdsm/profile_mem.py
File lib/vdsm/profile_mem.py:
Nir Soffer has posted comments on this change.
Change subject: profiling: Add support for memory profiling
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/32019/2/lib/vdsm/profile_mem.py
File lib/vdsm/profile_mem.py:
Nir Soffer has posted comments on this change.
Change subject: multipath: Disable queuing on all multipath devices
..
Patch Set 2:
Changes:
- Link to RHEL 6 docuemnts
- Link to the relevant section in the manual
- More correct
Nir Soffer has posted comments on this change.
Change subject: multipath: Disable queuing on all multipath devices
..
Patch Set 3:
Move the rule earlier, just after /dev/mapper/guid is created, to limit the
time the device is
Nir Soffer has uploaded a new change for review.
Change subject: lvm: Decrease number of retries before failing
..
lvm: Decrease number of retries before failing
Previously we configured lvm to stop accessing a device during an
Nir Soffer has uploaded a new change for review.
Change subject: iscsi: Set node.session.timeo.replacement_timeout when creating
a node
..
iscsi: Set node.session.timeo.replacement_timeout when creating a node
ISCSI multipath
Nir Soffer has posted comments on this change.
Change subject: tests: Use frozenset instead of set
..
Patch Set 4: Verified+1
Rebase and address Mooli comments.
--
To view, visit http://gerrit.ovirt.org/31786
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: vm: enable disk stats collection on recovery
..
Patch Set 1:
(1 comment)
Nice catch! I think this is my fault - I added the code adding the domain ids
to sdIds,
Nir Soffer has posted comments on this change.
Change subject: vm: enable disk stats collection on recovery
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32406/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2895:
Nir Soffer has posted comments on this change.
Change subject: vm: enable disk stats collection on recovery
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32406/1//COMMIT_MSG
Commit Message:
Line 7: vm: enable disk
Nir Soffer has posted comments on this change.
Change subject: vm: enable disk stats collection on recovery
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32406/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2895:
Nir Soffer has posted comments on this change.
Change subject: multipath: Disable queuing on all multipath devices
..
Patch Set 3:
According to Ben Marzinski, multipath developer, the udev rule is fine, and we
have no other
Nir Soffer has posted comments on this change.
Change subject: iscsi: Set node.session.timeo.replacement_timeout when creating
a node
..
Patch Set 1:
The fixed multipath version should be at 7.0, although it is not on our qe
Nir Soffer has posted comments on this change.
Change subject: lvm: Decrease number of retries before failing
..
Patch Set 1:
Ben Marzinski (mulipath developer) suggest that we move the retries to
multipath, since we have
Nir Soffer has posted comments on this change.
Change subject: iscsi: Set node.session.timeo.replacement_timeout when creating
a node
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32363/1/vdsm/storage/multipath.py
Nir Soffer has posted comments on this change.
Change subject: iscsi: Set node.session.timeo.replacement_timeout when creating
a node
..
Patch Set 2:
Fixed iscisd configuration file name.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: mount: fix _loopFsSpecsTimestamp global definition
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32472
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: new functional tests for vdsm storage
..
Patch Set 2:
(29 comments)
Partial review, but this is enough for now. I will continue after these
comments are
Nir Soffer has posted comments on this change.
Change subject: tests: new functional tests for vdsm storage
..
Patch Set 2:
(7 comments)
Some more comments.
Nir Soffer has posted comments on this change.
Change subject: hsm: validate storage pool in prepareImage
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32502/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line
Nir Soffer has posted comments on this change.
Change subject: vm: enable disk stats collection on recovery
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32406/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2895:
Nir Soffer has posted comments on this change.
Change subject: iscsi: Set node.session.timeo.replacement_timeout when creating
a node
..
Patch Set 2: Code-Review-1
After discussing with Allon, I think this is not the right
Nir Soffer has posted comments on this change.
Change subject: sampling: do not produce stats for missing disks
..
Patch Set 3: Code-Review+1
(2 comments)
http://gerrit.ovirt.org/#/c/30029/3/vdsm/virt/vm.py
File
Nir Soffer has posted comments on this change.
Change subject: lvm: Exclude faulty devices from lvm long filter
..
Patch Set 2:
This can still be useful even after bug 880738 is fixed, to avoid the much
shorter dealy (5-10
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 2:
No, but why make it more complex? If we had to restart vdsm to enable it, I
would like to use it
Nir Soffer has uploaded a new change for review.
Change subject: log: Use INFO log level as default
..
log: Use INFO log level as default
The current logs are much too verbose which cause trouble for users, and
make us look
Nir Soffer has uploaded a new change for review.
Change subject: domainMonitor: Cleanup logging
..
domainMonitor: Cleanup logging
- Use INFO for level for the important state change log, and use
uppercase VALID and INVALID
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Cleanup logging
..
Patch Set 3:
This version fixes few typos in the commit message and shorten another too
wordy error message.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: tests: new functional tests for vdsm storage
..
Patch Set 2:
(6 comments)
http://gerrit.ovirt.org/#/c/32496/2/tests/functional/testlib/testcontexts/base.py
File
Nir Soffer has uploaded a new change for review.
Change subject: storage.monitor: Streamline names
..
storage.monitor: Streamline names
Rename internal classes using shorter names, considering the package
namespace. For
Nir Soffer has uploaded a new change for review.
Change subject: storage.monitor: Use lowercase module name
..
storage.monitor: Use lowercase module name
storage.domainMonitor was using pep8 incompatible and too specific
module
Nir Soffer has posted comments on this change.
Change subject: vm: enable disk stats collection on recovery
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32406/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2895:
Nir Soffer has posted comments on this change.
Change subject: vm: enable disk stats collection on recovery
..
Patch Set 1:
Ok, thanks for your research.
Lets replace this change with a comment explaining why at this point we
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 2:
What you suggest is convenient, but it gives someone out of the machine too
much control.
We can use
Nir Soffer has uploaded a new change for review.
Change subject: tests: Disable slow and stress tests by default
..
tests: Disable slow and stress tests by default
Currnetntly developers must use this crazy command line when
Nir Soffer has posted comments on this change.
Change subject: tests: Disable slow and stress tests by default
..
Patch Set 2: Verified+1
Run the tests normally and with slow and stress tests.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: vm: document disk stats collection on recovery
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/32406/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2914:
Nir Soffer has uploaded a new change for review.
Change subject: make: Run fast checks before slow ones
..
make: Run fast checks before slow ones
Previously the slow tests where run before the fast pyflakes and pep8
checks, so
Nir Soffer has posted comments on this change.
Change subject: vm: document disk stats collection on recovery
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/32406/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2914:
Nir Soffer has posted comments on this change.
Change subject: make: Run fast checks before slow ones
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32532
To unsubscribe, visit
Nir Soffer has uploaded a new change for review.
Change subject: Configure iscsi_session recovery_tmo for multipath devices
..
Configure iscsi_session recovery_tmo for multipath devices
This configuration is done by
Nir Soffer has posted comments on this change.
Change subject: multipath: Configure iscsi_session recovery_tmo
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/32582/3/vdsm/storage/multipath-configure-device.in
File
Nir Soffer has posted comments on this change.
Change subject: multipath: Configure iscsi_session recovery_tmo
..
Patch Set 3:
(6 comments)
http://gerrit.ovirt.org/#/c/32582/3/vdsm/storage/Makefile.am
File
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 7: Code-Review-1
(6 comments)
Need to update for new Configurator interface
Nir Soffer has posted comments on this change.
Change subject: utils: Use ovirt node for persist and unpersist files
..
Patch Set 2:
Please address my comments from patchset 1.
--
To view, visit http://gerrit.ovirt.org/31584
Nir Soffer has posted comments on this change.
Change subject: multipath: Configure iscsi_session recovery_tmo
..
Patch Set 3: Verified-1
The root cause of this issue is the 120 seconds timeout in
/etc/iscsi/iscsid.conf.
Nir Soffer has posted comments on this change.
Change subject: tests: new functional tests for vdsm storage
..
Patch Set 4:
(12 comments)
http://gerrit.ovirt.org/#/c/32496/4/tests/functional/testlib/controlvdsm.py
File
Nir Soffer has posted comments on this change.
Change subject: vm: document disk stats collection on recovery
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32406
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: make: Run fast checks before slow ones
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32532/1/Makefile.am
File Makefile.am:
Line 109: done ; \
901 - 1000 of 11706 matches
Mail list logo
