Fabian Deutsch has posted comments on this change.
Change subject: service: Add vdsm-tool-configure service
..
Patch Set 3:
(1 comment)
Fabian Deutsch has posted comments on this change.
Change subject: service: Add vdsm-tool-update service
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/64904/1/static/usr/lib/systemd/system/vdsm-tool-update.service
Fabian Deutsch has posted comments on this change.
Change subject: spec: bridge-utils are required for tests
..
Patch Set 1:
Mh - Wasn't there some magiv to make it an automatic requirement if it was
needed during builds?
Or
Fabian Deutsch has uploaded a new change for review.
Change subject: spec: bridge-utils are required for tests
..
spec: bridge-utils are required for tests
Change-Id: I115f7e9d01fa74c36ef535f85474ffb16177f429
Signed-off-by:
Fabian Deutsch has posted comments on this change.
Change subject: modprobe: set bonding max_bonds to 0
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61593
To unsubscribe, visit
Fabian Deutsch has posted comments on this change.
Change subject: modules-load.d: drop bonding UNTESTED
..
Patch Set 1: Code-Review-1
I don't think this patch is needed anymore, considering the progress on
Fabian Deutsch has posted comments on this change.
Change subject: modprobe: set bonding max_bonds to 0
..
Patch Set 4:
… I tried it on NGN based on centos7
--
To view, visit https://gerrit.ovirt.org/61396
To unsubscribe,
Fabian Deutsch has posted comments on this change.
Change subject: modprobe: set bonding max_bonds to 0
..
Patch Set 4: Verified+1
I just tested this on NGN using:
1. Boot NGN regularly
2. bond0 exists
3. Create
Fabian Deutsch has posted comments on this change.
Change subject: modprobe: set bonding max_bonds to 0
..
Patch Set 4: Code-Review+1
I think there is a good chance that this will work (at least on node).
On node we are
Fabian Deutsch has posted comments on this change.
Change subject: Revert "NetworkManager: configure to monitor ifcfg/connection
files"
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59260
To
Fabian Deutsch has posted comments on this change.
Change subject: Revert "NetworkManager: configure to monitor ifcfg/connection
files"
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59260
To
Fabian Deutsch has posted comments on this change.
Change subject: Revert "NetworkManager: configure to monitor ifcfg/connection
files"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59260
To
Fabian Deutsch has posted comments on this change.
Change subject: vdsm: adding handling for NGN in osinfo.py
..
Patch Set 5: -Code-Review
(1 comment)
https://gerrit.ovirt.org/#/c/57620/5/lib/vdsm/osinfo.py
File
Fabian Deutsch has posted comments on this change.
Change subject: vdsm: adding handling for NGN in osinfo.py
..
Patch Set 5: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/57620/5/lib/vdsm/osinfo.py
File
Fabian Deutsch has posted comments on this change.
Change subject: vdsm: adding handling for NGN in osinfo.py
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/57620/3/lib/vdsm/osinfo.py
File lib/vdsm/osinfo.py:
Line
Fabian Deutsch has posted comments on this change.
Change subject: require NetworkManager-config-server
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/56622
To unsubscribe, visit
Fabian Deutsch has posted comments on this change.
Change subject: require NetworkManager-config-server
..
Patch Set 2: Code-Review+1
Good point. Looks good to me.
--
To view, visit https://gerrit.ovirt.org/56622
To
Fabian Deutsch has posted comments on this change.
Change subject: require NetworkManager-config-server
..
Patch Set 1: Code-Review-1
Yes, we do need to run systemctl reload NetworkManager to apply these changes.
--
To view,
Fabian Deutsch has posted comments on this change.
Change subject: require NetworkManager-config-server
..
Patch Set 1: Code-Review+1
NM probably needs to be reloaded to pickup the new configuration.
Otherwise: Great!
--
To
Fabian Deutsch has posted comments on this change.
Change subject: NetworkManager: configure to monitor ifcfg files
..
Patch Set 2:
If the configurator is just about writing the configuration files, then we
probably do not
Fabian Deutsch has posted comments on this change.
Change subject: NetworkManager: configure to monitor ifcfg files
..
Patch Set 1: Code-Review+1
In the scope of https://bugzilla.redhat.com/show_bug.cgi?id=1326798 it was
Fabian Deutsch has abandoned this change.
Change subject: register: Pull some vars into the class
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/46977
To unsubscribe, visit https://gerrit.ovirt.org/settings
Fabian Deutsch has posted comments on this change.
Change subject: bonding: move pre-generated data to /usr/share/vdsm
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54850
To unsubscribe, visit
Fabian Deutsch has abandoned this change.
Change subject: spec: Add a dependency to vdsm on vdsm-cli
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/54006
To unsubscribe, visit https://gerrit.ovirt.org/settings
Fabian Deutsch has posted comments on this change.
Change subject: spec: vdsm requires vdsm-cli
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/54354
To unsubscribe, visit
Fabian Deutsch has abandoned this change.
Change subject: register: Drop CA path redundancies
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/46980
To unsubscribe, visit https://gerrit.ovirt.org/settings
Fabian Deutsch has abandoned this change.
Change subject: register: Fix certificate validation
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/46981
To unsubscribe, visit https://gerrit.ovirt.org/settings
Fabian Deutsch has abandoned this change.
Change subject: register: Simplify setting defaults
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/46979
To unsubscribe, visit https://gerrit.ovirt.org/settings
Fabian Deutsch has uploaded a new change for review.
Change subject: spec: vdsm requires vdsm-cli
..
spec: vdsm requires vdsm-cli
vdsm is packaging the sos plugin, which in turn relies on vdsm-cli.
Thus vdsm-cli should be a
Fabian Deutsch has uploaded a new change for review.
Change subject: spec: Add a dependency to vdsm on vdsm-cli
..
spec: Add a dependency to vdsm on vdsm-cli
The sos plugin contained in the vdsm package requires the
vdsm-cli,
Fabian Deutsch has posted comments on this change.
Change subject: hooks: Add vdsm-hook-emulator
..
Patch Set 3:
ping?
--
To view, visit https://gerrit.ovirt.org/45334
To unsubscribe, visit https://gerrit.ovirt.org/settings
Fabian Deutsch has posted comments on this change.
Change subject: change downloaded ca pem filename
..
Patch Set 1:
Please abandon or get it merged
--
To view, visit https://gerrit.ovirt.org/42837
To unsubscribe, visit
Fabian Deutsch has posted comments on this change.
Change subject: register: Add --ca-file
..
Patch Set 2:
ping?
--
To view, visit https://gerrit.ovirt.org/44576
To unsubscribe, visit https://gerrit.ovirt.org/settings
Fabian Deutsch has abandoned this change.
Change subject: register: Leave the logging to the vdsm-tool
..
Abandoned
Let's keep the rgeistration log in a different place.
--
To view, visit https://gerrit.ovirt.org/46978
To
Fabian Deutsch has posted comments on this change.
Change subject: register: Leave the logging to the vdsm-tool
..
Patch Set 2:
Okay, fine for me to drop this patch.
--
To view, visit https://gerrit.ovirt.org/46978
To
Fabian Deutsch has posted comments on this change.
Change subject: tests: Fix loop device leak in mount tests
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51614
To unsubscribe, visit
Fabian Deutsch has abandoned this change.
Change subject: register: Pull some vars into the class
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/46977
To unsubscribe, visit https://gerrit.ovirt.org/settings
Fabian Deutsch has posted comments on this change.
Change subject: tests: Fix loop device leak in mount tests
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/51614/1/tests/mountTests.py
File tests/mountTests.py:
Fabian Deutsch has restored this change.
Change subject: register: Pull some vars into the class
..
Restored
--
To view, visit https://gerrit.ovirt.org/46977
To unsubscribe, visit https://gerrit.ovirt.org/settings
Fabian Deutsch has posted comments on this change.
Change subject: register: Fix certificate validation
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/46981/1/lib/vdsm/tool/register.py
File
Fabian Deutsch has posted comments on this change.
Change subject: tests: Fix loop device leak in mount tests
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/51614/1/tests/mountTests.py
File tests/mountTests.py:
Fabian Deutsch has posted comments on this change.
Change subject: tests: Fix loop device leak in mount tests
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/51614/1/tests/mountTests.py
File tests/mountTests.py:
Fabian Deutsch has posted comments on this change.
Change subject: service: change vdsm KillMode to mixed
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit
Fabian Deutsch has posted comments on this change.
Change subject: register: handle non uuid machines
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/47385/2/lib/vdsm/tool/register.py
File
Fabian Deutsch has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 6:
(8 comments)
https://gerrit.ovirt.org/#/c/48317/6/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 21: from
Fabian Deutsch has abandoned this change.
Change subject: vdsm-tool: Ensure that the vdsm uuid is a string
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/46970
To unsubscribe, visit https://gerrit.ovirt.org/settings
Fabian Deutsch has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 4:
Ping?
--
To view, visit https://gerrit.ovirt.org/48317
To unsubscribe, visit https://gerrit.ovirt.org/settings
Fabian Deutsch has posted comments on this change.
Change subject: build: contrib script to build for rhev with the required flags
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/49001/5/contrib/rhev_build.sh
File
Fabian Deutsch has posted comments on this change.
Change subject: build: contrib script to build for rhev with the required flags
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/49001/5/contrib/rhev_build.sh
File
Fabian Deutsch has posted comments on this change.
Change subject: ifcfg: remove files properly on the node
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48841
To unsubscribe, visit
Fabian Deutsch has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 2:
(1 comment)
Right, I'm also fine with that. Let me push aa patch with a more generic
function which illustrates
Fabian Deutsch has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/48317/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 454:
Line
Fabian Deutsch has posted comments on this change.
Change subject: register: handle non uuid machines
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/47385/1/lib/vdsm/tool/register.py
File
Fabian Deutsch has posted comments on this change.
Change subject: register: handle non uuid machines
..
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/47385
To unsubscribe, visit
Fabian Deutsch has abandoned this change.
Change subject: presets: Disable firewalld.service by default
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/48491
To unsubscribe, visit https://gerrit.ovirt.org/settings
Fabian Deutsch has posted comments on this change.
Change subject: presets: Disable firewalld.service by default
..
Patch Set 1:
Right, I'm fine that host-deploy takes care of it.
However, I don't understand the split of
Fabian Deutsch has uploaded a new change for review.
Change subject: presets: Disable firewalld.service by default
..
presets: Disable firewalld.service by default
firewalld is installed and enabled by default on CentOS 7, but
Fabian Deutsch has posted comments on this change.
Change subject: presets: Disable firewalld.service by default
..
Patch Set 1:
In the end vdsm already cares about services. firewalld is in this case just
yet another service
Fabian Deutsch has posted comments on this change.
Change subject: presets: Disable firewalld.service by default
..
Patch Set 1:
There is actually some code which handles the firewall.
However, I'm fine if some other
Fabian Deutsch has uploaded a new change for review.
Change subject: vdsm.conf: Add drop-in dir
..
vdsm.conf: Add drop-in dir
A drop-in dir allows the user to put partial configurations
into a drop-in directory for the vdsm
Fabian Deutsch has abandoned this change.
Change subject: vdsm.conf: Add drop-in dir
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/48316
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType:
Fabian Deutsch has posted comments on this change.
Change subject: utils: replace import for persist/unpersist
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47829
To unsubscribe, visit
Fabian Deutsch has posted comments on this change.
Change subject: multipath: Fix multipath.conf selinux labels
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46398
To unsubscribe, visit
Fabian Deutsch has uploaded a new change for review.
Change subject: vdsm-tool: Ensure that the vdsm uuid is a string
..
vdsm-tool: Ensure that the vdsm uuid is a string
Change-Id: I3c1f341dd66a468cf704158789e158f6d61f1d98
Fabian Deutsch has uploaded a new change for review.
Change subject: register: Pull some vars into the class
..
register: Pull some vars into the class
Change-Id: I1601ec61a30971f175630013023e8be2de77da17
Signed-off-by: Fabian
Fabian Deutsch has uploaded a new change for review.
Change subject: register: Fix certificate validation
..
register: Fix certificate validation
Change-Id: Idcd1eab617ea21655ec89419c0f3532eefeec4f9
Signed-off-by: Fabian
Fabian Deutsch has uploaded a new change for review.
Change subject: register: Drop CA path redundancies
..
register: Drop CA path redundancies
Change-Id: I0a386f9b3f398ea5e5537e146448954ec3b057cb
Signed-off-by: Fabian Deutsch
Fabian Deutsch has uploaded a new change for review.
Change subject: register: Leave the logging to the vdsm-tool
..
register: Leave the logging to the vdsm-tool
Change-Id: I6795077ce62d254c1ca5497eb6291291b2d03033
Fabian Deutsch has uploaded a new change for review.
Change subject: register: Simplify setting defaults
..
register: Simplify setting defaults
Change-Id: Id02327439fcc5a88a6489635ea9bd293bbe350cd
Signed-off-by: Fabian Deutsch
Fabian Deutsch has posted comments on this change.
Change subject: Makes the vdsmd load after iscsi
..
Patch Set 2:
I agree with Nir. If iscsid is already checking if it's needed, then vdsmd
should not depend on it. But vdsmd
Fabian Deutsch has posted comments on this change.
Change subject: muiltipath: Unbreak configure on ovirt node
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46397
To unsubscribe, visit
Fabian Deutsch has posted comments on this change.
Change subject: multipath: Write multipath.conf atomically
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/44869/5/lib/vdsm/tool/configurators/multipath.py
File
Fabian Deutsch has posted comments on this change.
Change subject: oop: close ioprocesses on vdsmd stop
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/45038/1/vdsm/storage/outOfProcess.py
File
Fabian Deutsch has posted comments on this change.
Change subject: multipath: Write multipath.conf atomically
..
Patch Set 3: Code-Review+1
(1 comment)
Fabian Deutsch has posted comments on this change.
Change subject: multipath: Backup old configuration using hard link
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/44866/3/lib/vdsm/tool/configurators/multipath.py
Fabian Deutsch has posted comments on this change.
Change subject: multipath: Write multipath.conf atomically
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/44869/3/lib/vdsm/tool/configurators/multipath.py
File
Fabian Deutsch has posted comments on this change.
Change subject: net: always persist ifcfg files.
..
Patch Set 2: Code-Review+1
The chaneg itself looks good, but I can not tell if it will be called in all
relevant flows.
Fabian Deutsch has posted comments on this change.
Change subject: register: Add --vdsm-uuid
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44431
To unsubscribe, visit
Fabian Deutsch has posted comments on this change.
Change subject: vdsm-reg: remove the sub-project
..
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/43254
To unsubscribe, visit
Fabian Deutsch has posted comments on this change.
Change subject: vdsm-tool: remove register verb
..
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/43921
To unsubscribe, visit
Fabian Deutsch has posted comments on this change.
Change subject: vdsm-reg: remove the sub-project
..
Patch Set 1:
Please update the commit msg to poin tot the vdsm verb. And are you sure that
we don't need any of the vdsm-*
Fabian Deutsch has posted comments on this change.
Change subject: using rpm in rhevh and ovirt as well
..
Patch Set 1:
I'm not sure what this patch will enable. The change itself just changes some
conditions, but the
Fabian Deutsch has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/42927/5/lib/vdsm/concurrent.py
File lib/vdsm/concurrent.py:
Line 62:
Fabian Deutsch has posted comments on this change.
Change subject: Revert node hack to avoid searching for libvirt upstart script
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42973
To unsubscribe,
Fabian Deutsch has posted comments on this change.
Change subject: Revert node hack to avoid searching for libvirt upstart script
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/42973
To unsubscribe,
Fabian Deutsch has posted comments on this change.
Change subject: hook: diskunmap: To include UNMAP support for disk and lun
devices
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/29770
To
Fabian Deutsch has posted comments on this change.
Change subject: network: Recognize macvlans as fake devices
..
Patch Set 1:
(1 comment)
The motivation is to let vdsm use macvlan nics inside a container, where real
nics
Fabian Deutsch has posted comments on this change.
Change subject: change libvirtd to use upstart except in ovirt node
..
Patch Set 6: Code-Review+1 Verified+1
--
To view, visit https://gerrit.ovirt.org/41574
To unsubscribe,
Fabian Deutsch has posted comments on this change.
Change subject: patch to avoid using upstarts when libvirtd.upstart not exist
..
Patch Set 3: Verified+1
After registration vdsmd also comes up with this patch
--
To view,
Fabian Deutsch has posted comments on this change.
Change subject: change libvirtd to use upstart except in over node
..
Patch Set 3: Code-Review+1 Verified+1
In my testing this patch worked.
--
To view, visit
Fabian Deutsch has posted comments on this change.
Change subject: avoid changing running libvirtd with upstart when running over
node
..
Patch Set 1: Code-Review+1
I favor this one, because it is less invasive than
Fabian Deutsch has posted comments on this change.
Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/39823/8/lib/vdsm/tool/configurators/passwd.py
Fabian Deutsch has uploaded a new change for review.
Change subject: network: Recognize macvlans as fake devices
..
network: Recognize macvlans as fake devices
macvlans are yet another type of virtual NICs.
This patch allows
Fabian Deutsch has posted comments on this change.
Change subject: network: Recognize macvlans as fake devices
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40608
To unsubscribe, visit
Fabian Deutsch has abandoned this change.
Change subject: spec: Require tar
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/37393
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Fabian Deutsch has posted comments on this change.
Change subject: spec: Require tar
..
Patch Set 1: Code-Review-1
Yes, you are right, adding this patch to vdsm, because it is as Alon says.
--
To view, visit
Fabian Deutsch has posted comments on this change.
Change subject: spec: Require tar
..
Patch Set 1:
It is not required for Node. I noticed this in the following situatoin:
Fedora 20 instalation with core packages only and
Fabian Deutsch has uploaded a new change for review.
Change subject: spec: Require tar
..
spec: Require tar
tar is required by host-deploy when a host is added to Engine.
tar is not part of the @core group in Fedora, and thus
Fabian Deutsch has posted comments on this change.
Change subject: store-net-config: persist ifcfg mgmt on node
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/36985/1/vdsm/vdsm-store-net-config.in
File
Fabian Deutsch has posted comments on this change.
Change subject: store-net-config: persist ifcfg mgmt on node
..
Patch Set 1: -Code-Review
(2 comments)
http://gerrit.ovirt.org/#/c/36985/1/vdsm/vdsm-store-net-config.in
File
1 - 100 of 107 matches
Mail list logo
