Arik Hadas has uploaded a new change for review.
Change subject: do not rely on default values on restoreFlags invocation
..
do not rely on default values on restoreFlags invocation
The signature of libvirt's verb
oVirt Jenkins CI Server has posted comments on this change.
Change subject: do not rely on default values on restoreFlags invocation
..
Patch Set 1:
Build Successful
Eduardo has posted comments on this change.
Change subject: do not rely on default values on restoreFlags invocation
..
Patch Set 1:
Is a minimal libvirt version required for this feature?
--
To view, visit
Arik Hadas has posted comments on this change.
Change subject: do not rely on default values on restoreFlags invocation
..
Patch Set 1:
yes but the current dependencies configuration is ok since we require libvirt
=
Michal Skrivanek has posted comments on this change.
Change subject: do not rely on default values on restoreFlags invocation
..
Patch Set 1:
why don't we just bump up the requirement on RHEL?
--
To view, visit
Michal Skrivanek has posted comments on this change.
Change subject: do not rely on default values on restoreFlags invocation
..
Patch Set 1:
libvirt version i meant...
--
To view, visit http://gerrit.ovirt.org/17298
To
Yeela Kaplan has posted comments on this change.
Change subject: do not rely on default values on restoreFlags invocation
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Michal Skrivanek has posted comments on this change.
Change subject: do not rely on default values on restoreFlags invocation
..
Patch Set 1:
I'd prefer bump up libvirt(or just rely on it's there) since pre-alpha 6.5 and
Dan Kenigsberg has posted comments on this change.
Change subject: do not rely on default values on restoreFlags invocation
..
Patch Set 1: Looks good to me, approved
Since passing the argument explicitly has not been
Dan Kenigsberg has submitted this change and it was merged.
Change subject: do not rely on default values on restoreFlags invocation
..
do not rely on default values on restoreFlags invocation
The signature of libvirt's verb
10 matches
Mail list logo