Change in vdsm[master]: net: remove mac address from ifcfg

2015-11-15 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: remove mac address from ifcfg .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48579 To unsubscribe, visit https://gerrit.ovirt.org/s

Change in vdsm[master]: Network API: Remove "force" option

2015-11-22 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: Network API: Remove "force" option .. Network API: Remove "force" option The "force" option has an akward semantic that was never used by the Engine. It is theref

Change in vdsm[master]: Network API: Remove "force" option

2015-11-23 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Network API: Remove "force" option .. Patch Set 1: Verified+1 Run Unit Tests & Functional Tests -- To view, visit https://gerrit.ovirt.org/48960 To unsubscribe,

Change in vdsm[master]: net: remove delNetwork old API

2015-11-24 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: remove delNetwork old API .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48911 To unsubscribe, visit https://gerrit.ovirt.org/setti

Change in vdsm[master]: net: remove editNetwork old API

2015-11-24 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: remove editNetwork old API .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48910 To unsubscribe, visit https://gerrit.ovirt.org/sett

Change in vdsm[master]: tests: Adding coverage check for unit tests

2015-11-24 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: tests: Adding coverage check for unit tests .. tests: Adding coverage check for unit tests It is helpfull to examine the test coverage when modifying source code,

Change in vdsm[master]: net: remove addNetwork old API

2015-11-25 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: remove addNetwork old API .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48909 To unsubscribe, visit https://gerrit.ovirt.org/setti

Change in vdsm[master]: net: remove editNetwork old API

2015-11-25 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: remove editNetwork old API .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48910 To unsubscribe, visit https://gerrit.ovirt.org/sett

Change in vdsm[master]: net: remove addNetwork old API

2015-11-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: remove addNetwork old API .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48909 To unsubscribe, visit https://gerrit.ovirt.org/setti

Change in vdsm[master]: tests: Adding coverage check for unit tests

2015-11-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: tests: Adding coverage check for unit tests .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/49130 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: net: remove delNetwork old API

2015-11-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: remove delNetwork old API .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/48911 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: code coverage: change approach how to enable it

2015-11-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: code coverage: change approach how to enable it .. Patch Set 3: Nice, so now we will have it for functional tests as well. Coverage is being run now on the unit t

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-11-29 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net: Mapping bonding option value names to numerics .. net: Mapping bonding option value names to numerics Several bonding options have values that may be inputte

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-01 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 5: (16 comments) https://gerrit.ovirt.org/#/c/49390/5/lib/vdsm/netinfo.py File lib/vdsm/netinfo.p

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-01 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 6: (5 comments) https://gerrit.ovirt.org/#/c/49390/6/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py

Change in vdsm[master]: tests: modprobe validation handle failure

2015-12-01 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: tests: modprobe validation handle failure .. tests: modprobe validation handle failure On validation failure, add a skip action with a proper message. Change-Id:

Change in vdsm[master]: net func tests: ip config drop on bond slaves

2015-12-01 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net func tests: ip config drop on bond slaves .. net func tests: ip config drop on bond slaves Moving an interface to a bond should flush/drop its ip configuratio

Change in vdsm[master]: net func tests: ip config drop on bond slaves

2015-12-01 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net func tests: ip config drop on bond slaves .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49539 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-02 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 10: Verified+1 -- To view, visit https://gerrit.ovirt.org/49390 To unsubscribe, visit https://ger

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-02 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 10: (5 comments) https://gerrit.ovirt.org/#/c/49390/10/lib/vdsm/netinfo.py File lib/vdsm/netinfo.

Change in vdsm[master]: net: Compare kernel vs running bond config opt vals

2015-12-02 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net: Compare kernel vs running bond config opt vals .. net: Compare kernel vs running bond config opt vals Comparing between the bond running config and the bond

Change in vdsm[master]: tests: modprobe validation handle failure

2015-12-03 Thread edwardh
Edward Haas has posted comments on this change. Change subject: tests: modprobe validation handle failure .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/49538/1/tests/modprobe.py File tests/modprobe.py: Line 38:

Change in vdsm[master]: net: Compare kernel vs running bond config opt vals

2015-12-03 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Compare kernel vs running bond config opt vals .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49579 To unsubscribe, visit https://gerr

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-03 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 12: Verified+1 -- To view, visit https://gerrit.ovirt.org/49390 To unsubscribe, visit https://ger

Change in vdsm[master]: tests: modprobe validation handle failure

2015-12-04 Thread edwardh
Edward Haas has posted comments on this change. Change subject: tests: modprobe validation handle failure .. Patch Set 2: Verified+1 (1 comment) https://gerrit.ovirt.org/#/c/49538/2/tests/modprobe.py File tests/modprobe.py: L

Change in vdsm[master]: tests: modprobe validation handle failure

2015-12-04 Thread edwardh
Edward Haas has posted comments on this change. Change subject: tests: modprobe validation handle failure .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/49538 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: hooks: ovs: drop initial bonds' slaves IP config

2015-12-08 Thread edwardh
Edward Haas has posted comments on this change. Change subject: hooks: ovs: drop initial bonds' slaves IP config .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/50100/2/vdsm_hooks/ovs/ovs_before_network_setup_ip.py Fi

Change in vdsm[master]: Add vmfex-dev hook to default RPMs for install

2015-12-08 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Add vmfex-dev hook to default RPMs for install .. Patch Set 1: Sorry for the ignorance, but why do we add it to the default installation? And please fix the spell

Change in vdsm[master]: tests: modprobe validation handle failure

2015-12-08 Thread edwardh
Edward Haas has posted comments on this change. Change subject: tests: modprobe validation handle failure .. Patch Set 3: -Verified (1 comment) https://gerrit.ovirt.org/#/c/49538/3/tests/modprobe.py File tests/modprobe.py: Li

Change in vdsm[master]: tests: modprobe validation handle failure

2015-12-08 Thread edwardh
Edward Haas has posted comments on this change. Change subject: tests: modprobe validation handle failure .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/49538 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-08 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 12: (10 comments) https://gerrit.ovirt.org/#/c/49390/12/init/vdsmd_init_common.sh.in File init/vd

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-08 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 13: Verified+1 -- To view, visit https://gerrit.ovirt.org/49390 To unsubscribe, visit https://ger

Change in vdsm[master]: Add vmfex-dev hook to default RPMs for install

2015-12-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Add vmfex-dev hook to default RPMs for install .. Patch Set 2: Code-Review+1 Verified+1 -- To view, visit https://gerrit.ovirt.org/50024 To unsubscribe, visit htt

Change in vdsm[ovirt-3.6]: Add vmfex-dev hook to default RPMs for install

2015-12-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Add vmfex-dev hook to default RPMs for install .. Patch Set 1: Verified+1 vdsm_install passes. -- To view, visit https://gerrit.ovirt.org/50270 To unsubscribe, v

Change in vdsm[ovirt-3.6]: Add vmfex-dev hook to default RPMs for install

2015-12-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Add vmfex-dev hook to default RPMs for install .. Patch Set 1: Please add the bug number in the commit. -- To view, visit https://gerrit.ovirt.org/50270 To unsub

Change in vdsm[master]: net: remove business logic out of CachingNetInfo

2015-12-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: remove business logic out of CachingNetInfo .. Patch Set 4: (4 comments) https://gerrit.ovirt.org/#/c/5/4/lib/vdsm/netinfo/__init__.py File lib/vdsm/neti

Change in vdsm[master]: net: remove business logic out of CachingNetInfo

2015-12-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: remove business logic out of CachingNetInfo .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/5 To unsubscribe, visit https://gerr

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50372 To unsubscribe, visit https:

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-13 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net: Correctly apply MTU values on networks .. net: Correctly apply MTU values on networks Two issues have been resolved by this change: - New networks with no M

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/50397 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[ovirt-3.6]: Add vmfex-dev hook to default RPMs for install

2015-12-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Add vmfex-dev hook to default RPMs for install .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50270 To unsubscribe, visit https://gerrit

Change in vdsm[master]: hooks: ovs: drop initial bonds' slaves IP config

2015-12-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: hooks: ovs: drop initial bonds' slaves IP config .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50100 To unsubscribe, visit https://gerr

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-14 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 1: Eliminating the default MTU from engine: https://gerrit.ovirt.org/#/c/28097/ Therefore setupNetwork wi

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-14 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 1: IMO, having independent guards on both Engine and VDSM is preferred. Either handle defaults at the VDSM

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-15 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 1: (10 comments) https://gerrit.ovirt.org/#/c/50397/1/lib/vdsm/network/api.py File lib/vdsm/network/api.p

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-15 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/50397/1//COMMIT_MSG Commit Message: Line 8: > IMO you shou

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-15 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/50397 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-16 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/50397/3/lib/vdsm/network/api.py File lib/vdsm/network/api.py

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-16 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/50397 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-16 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 4: -Verified -- To view, visit https://gerrit.ovirt.org/50397 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-16 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/50397 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[ovirt-3.5]: net tests: Marking testFakeNics as broken

2015-12-16 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net tests: Marking testFakeNics as broken .. net tests: Marking testFakeNics as broken The test testFakeNics fails when hidden nics appear in netinfo nics report.

Change in vdsm[master]: net: Compare kernel vs running bond config opt vals

2015-12-16 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Compare kernel vs running bond config opt vals .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/49579 To unsubscribe, visit https://gerr

Change in vdsm[master]: Always propagate bonding mode to engine

2015-12-16 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Always propagate bonding mode to engine .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/49580/4/lib/vdsm/network/models.py File lib/vdsm/network/models.p

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-16 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 25: Verified+1 -- To view, visit https://gerrit.ovirt.org/49390 To unsubscribe, visit https://ger

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-17 Thread edwardh
Edward Haas has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 1: Code-Review-1 (7 comments) https://gerrit.ovirt.org/#/c/50596/1/lib/vdsm/network/api.py File lib/vdsm/network

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-17 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50372 To unsubscribe, visit https:

Change in vdsm[ovirt-3.5]: net tests: Marking testFakeNics as broken

2015-12-18 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net tests: Marking testFakeNics as broken .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/50580 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-19 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 25: (3 comments) https://gerrit.ovirt.org/#/c/49390/25/lib/vdsm/netinfo/bonding.py File lib/vdsm/

Change in vdsm[master]: network: tests: mirror drop inital ip tests

2015-12-20 Thread edwardh
Edward Haas has posted comments on this change. Change subject: network: tests: mirror drop inital ip tests .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50713 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: Always propagate bonding mode to engine

2015-12-20 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Always propagate bonding mode to engine .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49580 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-20 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 26: Verified+1 -- To view, visit https://gerrit.ovirt.org/49390 To unsubscribe, visit https://ger

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-20 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 25: (2 comments) https://gerrit.ovirt.org/#/c/49390/25/lib/vdsm/netinfo/bonding.py File lib/vdsm/

Change in vdsm[master]: Always propagate bonding mode to engine

2015-12-20 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Always propagate bonding mode to engine .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/49580 To unsubscribe, visit https://gerrit.ovirt.org

Change in vdsm[master]: net: MTU should be an integer all over VDSM.

2015-12-20 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: MTU should be an integer all over VDSM. .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/50657/2/lib/vdsm/network/api.py File lib/vdsm/

Change in vdsm[master]: net: Update mtu under the bridge only when needed

2015-12-21 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net: Update mtu under the bridge only when needed .. net: Update mtu under the bridge only when needed Updating the mtu of an existing bridge and its ports, only

Change in vdsm[master]: net: MTU should be an integer all over VDSM.

2015-12-21 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: MTU should be an integer all over VDSM. .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50657 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: net tests: tcTests should run as root

2015-12-21 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net tests: tcTests should run as root .. net tests: tcTests should run as root Mark that tcTests.TestConfigureOutbound tests should run as root (otherwise, skip).

Change in vdsm[master]: net tests: tcTests should run as root

2015-12-21 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net tests: tcTests should run as root .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/50794 To unsubscribe, visit https://gerrit.ovirt.org/s

Change in vdsm[ovirt-3.6]: Always propagate bonding mode to engine

2015-12-21 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Always propagate bonding mode to engine .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50793 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: net: tests: test network's iface

2015-12-21 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: tests: test network's iface .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48366 To unsubscribe, visit https://gerrit.ovirt.org/set

Change in vdsm[master]: test: Unit Test target with NOSE attribute/marker

2016-03-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: test: Unit Test target with NOSE attribute/marker .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54388/1/tests/network/qos_test.py File tests/network/qo

Change in vdsm[master]: test: Unit Test target with NOSE attribute/marker

2016-03-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: test: Unit Test target with NOSE attribute/marker .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54388/1/tests/network/qos_test.py File tests/network/qo

Change in vdsm[master]: test: Unit Test target with NOSE attribute/marker

2016-03-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: test: Unit Test target with NOSE attribute/marker .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54388 To unsubscribe, visit https://gerrit

Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...

2016-03-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards .. Patch Set 5: Code-Review-1 (10 comments) https://gerrit.ovirt.org/#/c/54555/5/lib/vds

Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...

2016-03-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/54555/5/lib/vdsm/network/config

Change in vdsm[master]: net: legacy: split bonds handling to removal and setup

2016-03-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: legacy: split bonds handling to removal and setup .. Patch Set 2: Why bond editing is not a valid verb for a (generic) switch? -- To view, visit https://ger

Change in vdsm[master]: netinfo: dns: more robust parsing of resolv.conf

2016-03-11 Thread edwardh
Edward Haas has posted comments on this change. Change subject: netinfo: dns: more robust parsing of resolv.conf .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54558 To unsubscribe, visit https://gerr

Change in vdsm[master]: tests: Provide dnsmasq_run as a context manager

2016-03-11 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: tests: Provide dnsmasq_run as a context manager .. tests: Provide dnsmasq_run as a context manager The functional tests are using dnsmasqDhcp as the dnsmasq conte

Change in vdsm[master]: net tests: Introduce Router Advertisement with dnsmasq

2016-03-11 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net tests: Introduce Router Advertisement with dnsmasq .. net tests: Introduce Router Advertisement with dnsmasq dnsmasq has been used as a dhcp server for the ne

Change in vdsm[master]: net tests: Move dhcp and firewall service modules

2016-03-11 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net tests: Move dhcp and firewall service modules .. net tests: Move dhcp and firewall service modules dhcp and firewall modules have served only network function

Change in vdsm[master]: net: Network caps now reports IPv6 autoconf state

2016-03-11 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Network caps now reports IPv6 autoconf state .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/54475/5/tests/network/netinfo_test.py File tests/networ

Change in vdsm[master]: net: Network caps now reports IPv6 autoconf state

2016-03-11 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Network caps now reports IPv6 autoconf state .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/54475 To unsubscribe, visit https://gerrit

Change in vdsm[master]: net: legacy: split bonds handling to removal and setup

2016-03-11 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: legacy: split bonds handling to removal and setup .. Patch Set 2: I'm just not sure if this is needed without seeing a concrete usage. Can we delay it until y

Change in vdsm[master]: net tests: Introduce Router Advertisement with dnsmasq

2016-03-11 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net tests: Introduce Router Advertisement with dnsmasq .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54630/1/tests/functional/dhcp.py File tests/functi

Change in vdsm[master]: net: Network caps now reports IPv6 autoconf state

2016-03-11 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Network caps now reports IPv6 autoconf state .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/54475 To unsubscribe, visit https://gerrit

Change in vdsm[master]: net tests: Move dhcp and firewall service modules

2016-03-11 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net tests: Move dhcp and firewall service modules .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54631 To unsubscribe, visit https://gerrit

Change in vdsm[master]: net tests: Introduce Router Advertisement with dnsmasq

2016-03-11 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net tests: Introduce Router Advertisement with dnsmasq .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54630 To unsubscribe, visit https://g

Change in vdsm[master]: tests: Provide dnsmasq_run as a context manager

2016-03-11 Thread edwardh
Edward Haas has posted comments on this change. Change subject: tests: Provide dnsmasq_run as a context manager .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54632 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: net tests: IPv6 autoconf with RA server

2016-03-11 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net tests: IPv6 autoconf with RA server .. net tests: IPv6 autoconf with RA server Adding an integration test that checks IPv6 address allocation through slaac (a

Change in vdsm[master]: net tests: IPv6 autoconf with RA server

2016-03-11 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net tests: IPv6 autoconf with RA server .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/54668 To unsubscribe, visit https://gerrit.ovirt.org

Change in vdsm[master]: net: Network caps now reports IPv6 autoconf state

2016-03-11 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Network caps now reports IPv6 autoconf state .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/54475 To unsubscribe, visit https://gerrit

Change in vdsm[master]: tests: Classify network tests type

2016-03-11 Thread edwardh
Edward Haas has posted comments on this change. Change subject: tests: Classify network tests type .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54391 To unsubscribe, visit https://gerrit.ovirt.org/sett

Change in vdsm[master]: net tests: Move dhcp and firewall service modules

2016-03-11 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net tests: Move dhcp and firewall service modules .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54631/1/tests/network/Makefile.am File tests/network/Ma

Change in vdsm[master]: net tests: Move dhcp and firewall service modules

2016-03-11 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net tests: Move dhcp and firewall service modules .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/54631 To unsubscribe, visit https://gerrit

Change in vdsm[master]: contrib/shell_helper: allow installing form tag

2016-03-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: contrib/shell_helper: allow installing form tag .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54682 To unsubscribe, visit https://gerri

Change in vdsm[ovirt-3.6]: net: Ignore IPv6 addresses

2016-03-13 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net: Ignore IPv6 addresses .. net: Ignore IPv6 addresses IPv6 support in 3.6 is partial, causing unexpected results when a host is ipv6 enabled. This patch ignor

Change in vdsm[ovirt-3.6]: net: Ignore IPv6 addresses

2016-03-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Ignore IPv6 addresses .. Patch Set 1: This patch is intentionally not published on master. The master branch should handle correctly IPv6. -- To view, visit

Change in vdsm[ovirt-3.6]: net: Ignore IPv6 addresses

2016-03-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Ignore IPv6 addresses .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54687/1/lib/vdsm/netconfpersistence.py File lib/vdsm/netconfpersistence.py: L

Change in vdsm[ovirt-3.6]: net: Ignore IPv6 addresses

2016-03-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Ignore IPv6 addresses .. Patch Set 2: Verified+1 Unit and Functional tests passed. Confirmed that KernelConfig does not include ipv6 address & gateway. -- T

  1   2   3   4   5   6   7   8   9   10   >