Change in vdsm[master]: net: remove mac address from ifcfg

2015-11-15 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: remove mac address from ifcfg .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48579 To unsubscribe, visit

Change in vdsm[master]: Add vmfex-dev hook to default RPMs for install

2015-12-08 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Add vmfex-dev hook to default RPMs for install .. Patch Set 1: Sorry for the ignorance, but why do we add it to the default installation? And please fix the

Change in vdsm[master]: hooks: ovs: drop initial bonds' slaves IP config

2015-12-08 Thread edwardh
Edward Haas has posted comments on this change. Change subject: hooks: ovs: drop initial bonds' slaves IP config .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/50100/2/vdsm_hooks/ovs/ovs_before_network_setup_ip.py

Change in vdsm[master]: net: Compare kernel vs running bond config opt vals

2015-12-02 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net: Compare kernel vs running bond config opt vals .. net: Compare kernel vs running bond config opt vals Comparing between the bond running config and the bond

Change in vdsm[master]: tests: modprobe validation handle failure

2015-12-01 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: tests: modprobe validation handle failure .. tests: modprobe validation handle failure On validation failure, add a skip action with a proper message.

Change in vdsm[master]: net func tests: ip config drop on bond slaves

2015-12-01 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net func tests: ip config drop on bond slaves .. net func tests: ip config drop on bond slaves Moving an interface to a bond should flush/drop its ip

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-02 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 10: Verified+1 -- To view, visit https://gerrit.ovirt.org/49390 To unsubscribe, visit

Change in vdsm[master]: tests: modprobe validation handle failure

2015-12-04 Thread edwardh
Edward Haas has posted comments on this change. Change subject: tests: modprobe validation handle failure .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/49538 To unsubscribe, visit

Change in vdsm[master]: tests: modprobe validation handle failure

2015-12-04 Thread edwardh
Edward Haas has posted comments on this change. Change subject: tests: modprobe validation handle failure .. Patch Set 2: Verified+1 (1 comment) https://gerrit.ovirt.org/#/c/49538/2/tests/modprobe.py File tests/modprobe.py:

Change in vdsm[master]: tests: modprobe validation handle failure

2015-12-03 Thread edwardh
Edward Haas has posted comments on this change. Change subject: tests: modprobe validation handle failure .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/49538/1/tests/modprobe.py File tests/modprobe.py: Line 38:

Change in vdsm[master]: net: Compare kernel vs running bond config opt vals

2015-12-03 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Compare kernel vs running bond config opt vals .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49579 To unsubscribe, visit

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-03 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 12: Verified+1 -- To view, visit https://gerrit.ovirt.org/49390 To unsubscribe, visit

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-08 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 12: (10 comments) https://gerrit.ovirt.org/#/c/49390/12/init/vdsmd_init_common.sh.in File

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-08 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 13: Verified+1 -- To view, visit https://gerrit.ovirt.org/49390 To unsubscribe, visit

Change in vdsm[master]: tests: modprobe validation handle failure

2015-12-08 Thread edwardh
Edward Haas has posted comments on this change. Change subject: tests: modprobe validation handle failure .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/49538 To unsubscribe, visit

Change in vdsm[master]: tests: modprobe validation handle failure

2015-12-08 Thread edwardh
Edward Haas has posted comments on this change. Change subject: tests: modprobe validation handle failure .. Patch Set 3: -Verified (1 comment) https://gerrit.ovirt.org/#/c/49538/3/tests/modprobe.py File tests/modprobe.py:

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-02 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 10: (5 comments) https://gerrit.ovirt.org/#/c/49390/10/lib/vdsm/netinfo.py File

Change in vdsm[master]: net func tests: ip config drop on bond slaves

2015-12-01 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net func tests: ip config drop on bond slaves .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49539 To unsubscribe, visit

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-17 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50372 To unsubscribe, visit

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-17 Thread edwardh
Edward Haas has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 1: Code-Review-1 (7 comments) https://gerrit.ovirt.org/#/c/50596/1/lib/vdsm/network/api.py File

Change in vdsm[master]: net: remove business logic out of CachingNetInfo

2015-12-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: remove business logic out of CachingNetInfo .. Patch Set 4: (4 comments) https://gerrit.ovirt.org/#/c/5/4/lib/vdsm/netinfo/__init__.py File

Change in vdsm[master]: net: remove business logic out of CachingNetInfo

2015-12-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: remove business logic out of CachingNetInfo .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/5 To unsubscribe, visit

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50372 To unsubscribe, visit

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-14 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 1: Eliminating the default MTU from engine: https://gerrit.ovirt.org/#/c/28097/ Therefore setupNetwork

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-14 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 1: IMO, having independent guards on both Engine and VDSM is preferred. Either handle defaults at the

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-15 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/50397/1//COMMIT_MSG Commit Message: Line 8: > IMO you

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-15 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 1: (10 comments) https://gerrit.ovirt.org/#/c/50397/1/lib/vdsm/network/api.py File

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-15 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/50397 To unsubscribe, visit

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-13 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net: Correctly apply MTU values on networks .. net: Correctly apply MTU values on networks Two issues have been resolved by this change: - New networks with no

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/50397 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: Add vmfex-dev hook to default RPMs for install

2015-12-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Add vmfex-dev hook to default RPMs for install .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50270 To unsubscribe, visit

Change in vdsm[master]: hooks: ovs: drop initial bonds' slaves IP config

2015-12-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: hooks: ovs: drop initial bonds' slaves IP config .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50100 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: net tests: Marking testFakeNics as broken

2015-12-18 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net tests: Marking testFakeNics as broken .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/50580 To unsubscribe, visit

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-16 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 25: Verified+1 -- To view, visit https://gerrit.ovirt.org/49390 To unsubscribe, visit

Change in vdsm[master]: net: Compare kernel vs running bond config opt vals

2015-12-16 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Compare kernel vs running bond config opt vals .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/49579 To unsubscribe, visit

Change in vdsm[master]: Always propagate bonding mode to engine

2015-12-16 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Always propagate bonding mode to engine .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/49580/4/lib/vdsm/network/models.py File

Change in vdsm[ovirt-3.6]: Add vmfex-dev hook to default RPMs for install

2015-12-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Add vmfex-dev hook to default RPMs for install .. Patch Set 1: Please add the bug number in the commit. -- To view, visit https://gerrit.ovirt.org/50270 To

Change in vdsm[ovirt-3.6]: Add vmfex-dev hook to default RPMs for install

2015-12-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Add vmfex-dev hook to default RPMs for install .. Patch Set 1: Verified+1 vdsm_install passes. -- To view, visit https://gerrit.ovirt.org/50270 To unsubscribe,

Change in vdsm[master]: Add vmfex-dev hook to default RPMs for install

2015-12-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Add vmfex-dev hook to default RPMs for install .. Patch Set 2: Code-Review+1 Verified+1 -- To view, visit https://gerrit.ovirt.org/50024 To unsubscribe, visit

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-16 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 4: -Verified -- To view, visit https://gerrit.ovirt.org/50397 To unsubscribe, visit

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-16 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/50397 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: net tests: Marking testFakeNics as broken

2015-12-16 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net tests: Marking testFakeNics as broken .. net tests: Marking testFakeNics as broken The test testFakeNics fails when hidden nics appear in netinfo nics

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-16 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/50397/3/lib/vdsm/network/api.py File

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-16 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/50397 To unsubscribe, visit

Change in vdsm[master]: net: mtu should be reported as a string through caps

2016-01-03 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/51164/5/lib/vdsm/netinfo/__init__.py File

Change in vdsm[master]: net: Enable VDSM to listen on IPv6 addresses

2016-01-04 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Enable VDSM to listen on IPv6 addresses .. Patch Set 1: Verified by running the unit tests and functional tests. The unit tests include an IPv6 connection

Change in vdsm[master]: net: Enable VDSM to listen on IPv6 addresses

2016-01-04 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Enable VDSM to listen on IPv6 addresses .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51319 To unsubscribe, visit

Change in vdsm[master]: net: Enable VDSM to listen on IPv6 addresses

2016-01-04 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net: Enable VDSM to listen on IPv6 addresses .. net: Enable VDSM to listen on IPv6 addresses VDSM should be able to listen on both IPv6 and IPv4 addresses.

Change in vdsm[master]: net: Enable VDSM to listen on IPv6 addresses

2016-01-04 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Enable VDSM to listen on IPv6 addresses .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/51319/1/lib/vdsm/config.py.in File lib/vdsm/config.py.in:

Change in vdsm[master]: net: Enable VDSM to listen on IPv6 addresses

2016-01-04 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Enable VDSM to listen on IPv6 addresses .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/51319 To unsubscribe, visit

Change in vdsm[master]: net: drop isolatedCommand handling

2016-01-04 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: drop isolatedCommand handling .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51281 To unsubscribe, visit

Change in vdsm[master]: PoC: enforcement of contract for rpc

2016-01-05 Thread edwardh
Edward Haas has posted comments on this change. Change subject: PoC: enforcement of contract for rpc .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/50032/2//COMMIT_MSG Commit Message: Line 7: PoC: enforcement of

Change in vdsm[master]: net: mtu should be reported as a string through caps

2016-01-02 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51164/3/vdsm/caps.py File vdsm/caps.py: Line 634:

Change in vdsm[master]: net: mtu should be reported as a string through caps

2016-01-02 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: Verified by running all networking functional tests. They cover these points: - setupNetwork

Change in vdsm[master]: net: mtu should be reported as a string through caps

2016-01-02 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/51164/3/lib/vdsm/netinfo/__init__.py File

Change in vdsm[master]: net: mtu should be reported as a string through caps

2016-01-02 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/51164/3/lib/vdsm/netinfo/__init__.py File

Change in vdsm[ovirt-3.6]: net: netconf owner change should ignore gid

2015-12-29 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: netconf owner change should ignore gid .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51149 To unsubscribe, visit

Change in vdsm[master]: net: netconf owner change should ignore gid

2015-12-29 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net: netconf owner change should ignore gid .. net: netconf owner change should ignore gid When changing ownership of the directories/files the group id does not

Change in vdsm[master]: net: mtu should be reported as a string through caps

2016-01-01 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51164/1/lib/vdsm/netinfo/__init__.py File

Change in vdsm[master]: net: mtu should be reported as a string through caps

2016-01-01 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/51164/2/lib/vdsm/netinfo/__init__.py File

Change in vdsm[master]: net: mtu should be reported as a string through caps

2016-01-01 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit

Change in vdsm[master]: net: mtu should be reported as a string through caps

2016-01-02 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51164/3/vdsm/caps.py File vdsm/caps.py: Line 634:

Change in vdsm[master]: net: mtu should be reported as a string through caps

2016-01-03 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit

Change in vdsm[master]: net: mtu should be reported as a string through caps

2016-01-03 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/51164/4/lib/vdsm/netinfo/__init__.py File

Change in vdsm[master]: net: mtu should be reported as a string through caps

2016-01-03 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/51164/4/lib/vdsm/netinfo/__init__.py File

Change in vdsm[master]: net: mtu should be reported as a string through caps

2016-01-03 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/51164/5/lib/vdsm/netinfo/__init__.py File

Change in vdsm[master]: net: mtu should be reported as a string through caps

2016-01-03 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit

Change in vdsm[master]: net tests: Skip dump_bonding_name2numeric on EBUSY

2016-01-06 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net tests: Skip dump_bonding_name2numeric on EBUSY .. net tests: Skip dump_bonding_name2numeric on EBUSY The test fails rarely when scanning the bond options, on

Change in vdsm[master]: net: Enable VDSM to listen on IPv6 addresses

2016-01-05 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Enable VDSM to listen on IPv6 addresses .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/51319 To unsubscribe, visit

Change in vdsm[master]: Move dsaversion under vdsm-python package

2016-01-05 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Move dsaversion under vdsm-python package .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51381 To unsubscribe, visit

Change in vdsm[master]: net tests: Skip dump_bonding_name2numeric on EBUSY

2016-01-06 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net tests: Skip dump_bonding_name2numeric on EBUSY .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51412 To unsubscribe, visit

Change in vdsm[master]: testEnablePromisc: wait for promisc event

2016-01-06 Thread edwardh
Edward Haas has posted comments on this change. Change subject: testEnablePromisc: wait for promisc event .. Patch Set 1: Code-Review+1 TODO: We should move this logic to the set_promisc() in the next patch. -- To view,

Change in vdsm[master]: net: Enable VDSM to listen on IPv6 addresses

2016-01-05 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Enable VDSM to listen on IPv6 addresses .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/51319/2/lib/vdsm/config.py.in File lib/vdsm/config.py.in:

Change in vdsm[master]: Move dsaversion under vdsm-python package

2016-01-05 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Move dsaversion under vdsm-python package .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51381 To unsubscribe, visit

Change in vdsm[master]: net: Enable VDSM to listen on IPv6 addresses

2016-01-07 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Enable VDSM to listen on IPv6 addresses .. Patch Set 5: Note: This patch does not include support for migration over IPv6. A separated patch will target the

Change in vdsm[master]: net: Enable VDSM to listen on IPv6 addresses

2016-01-07 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Enable VDSM to listen on IPv6 addresses .. Patch Set 5: Verified+1 CI failures does not seem to be related, the fail is not in the tests. -- To view, visit

Change in vdsm[master]: Introduce commands module to separate execCmd and AsyncProc ...

2016-01-09 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Introduce commands module to separate execCmd and AsyncProc from utils .. Patch Set 10: Verified+1 Net Functional tests are passing -- To view, visit

Change in vdsm[master]: nettestlib: add ppc64le TUNSETIFF value

2016-01-09 Thread edwardh
Edward Haas has posted comments on this change. Change subject: nettestlib: add ppc64le TUNSETIFF value .. Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/46955 To unsubscribe, visit

Change in vdsm[master]: net: Enable VDSM to listen on IPv6 addresses

2016-01-07 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Enable VDSM to listen on IPv6 addresses .. Patch Set 4: (4 comments) https://gerrit.ovirt.org/#/c/51319/4/lib/vdsm/config.py.in File lib/vdsm/config.py.in:

Change in vdsm[master]: net: privatize CachingNetInfo attributes

2015-12-22 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: privatize CachingNetInfo attributes .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50893 To unsubscribe, visit

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-22 Thread edwardh
Edward Haas has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 6: (3 comments) https://gerrit.ovirt.org/#/c/50596/6/lib/vdsm/network/api.py File lib/vdsm/network/api.py:

Change in vdsm[master]: net: set netconf/* owner to 'vdsm'

2015-12-23 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net: set netconf/* owner to 'vdsm' .. net: set netconf/* owner to 'vdsm' On rhev-h netconf/* has umask of 660 with root as owner. Accessing the folders and files

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-19 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 25: (3 comments) https://gerrit.ovirt.org/#/c/49390/25/lib/vdsm/netinfo/bonding.py File

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-20 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 26: Verified+1 -- To view, visit https://gerrit.ovirt.org/49390 To unsubscribe, visit

Change in vdsm[master]: Always propagate bonding mode to engine

2015-12-20 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Always propagate bonding mode to engine .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49580 To unsubscribe, visit

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-20 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 25: (2 comments) https://gerrit.ovirt.org/#/c/49390/25/lib/vdsm/netinfo/bonding.py File

Change in vdsm[master]: network: tests: mirror drop inital ip tests

2015-12-20 Thread edwardh
Edward Haas has posted comments on this change. Change subject: network: tests: mirror drop inital ip tests .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50713 To unsubscribe, visit

Change in vdsm[master]: Always propagate bonding mode to engine

2015-12-20 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Always propagate bonding mode to engine .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/49580 To unsubscribe, visit

Change in vdsm[master]: netinfo: survive even when a expected iface is not connected...

2015-12-27 Thread edwardh
Edward Haas has posted comments on this change. Change subject: netinfo: survive even when a expected iface is not connected to bridge .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51063 To

Change in vdsm[master]: netinfo: survive even when a expected iface is not connected...

2015-12-27 Thread edwardh
Edward Haas has posted comments on this change. Change subject: netinfo: survive even when a expected iface is not connected to bridge .. Patch Set 1: (1 comment)

Change in vdsm[ovirt-3.6]: Always propagate bonding mode to engine

2015-12-21 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Always propagate bonding mode to engine .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50793 To unsubscribe, visit

Change in vdsm[master]: net: Update mtu under the bridge only when needed

2015-12-21 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net: Update mtu under the bridge only when needed .. net: Update mtu under the bridge only when needed Updating the mtu of an existing bridge and its ports, only

Change in vdsm[master]: net: tests: test network's iface

2015-12-21 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: tests: test network's iface .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48366 To unsubscribe, visit

Change in vdsm[master]: net: MTU should be an integer all over VDSM.

2015-12-21 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: MTU should be an integer all over VDSM. .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50657 To unsubscribe, visit

Change in vdsm[master]: net tests: tcTests should run as root

2015-12-21 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net tests: tcTests should run as root .. net tests: tcTests should run as root Mark that tcTests.TestConfigureOutbound tests should run as root (otherwise,

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-21 Thread edwardh
Edward Haas has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 1: Ido and myself have reread your solution, and we would like to propose a different direction. A cleaner way

Change in vdsm[master]: net: remove business logic out of CachingNetInfo

2015-12-22 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: remove business logic out of CachingNetInfo .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/5 To unsubscribe, visit

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-22 Thread edwardh
Edward Haas has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/50596/2/lib/vdsm/network/configurators/ifcfg.py File

Change in vdsm[master]: net tests: tcTests should run as root

2015-12-21 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net tests: tcTests should run as root .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/50794 To unsubscribe, visit

Change in vdsm[master]: net: tests: test network's iface

2015-12-22 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: tests: test network's iface .. Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48366 To unsubscribe, visit

  1   2   3   4   5   6   7   8   9   10   >