gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: exception: Add exceptions for vdsm.define errors
..
exception: Add exceptions for vdsm.define errors
Add an exception class for each error in
Piotr Kliczewski has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 24: Code-Review+2
Looks good to me, we need a patch which would make errors code part of api
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 23:
v23 (fully) restores the lost comments. Copied V+1 score.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 23:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 20:
(1 comment)
https://gerrit.ovirt.org/#/c/48871/20/lib/vdsm/exception.py
File
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 20: Verified+1
v20 avoids to duplicate the define.py comments in exception.py
Verified running
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 21: Code-Review-1
I liked the comments about removed errors - why they were removed in the latest
Nir Soffer has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 20:
(1 comment)
https://gerrit.ovirt.org/#/c/48871/20/lib/vdsm/exception.py
File
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 15:
(2 comments)
https://gerrit.ovirt.org/#/c/48871/15/lib/vdsm/exception.py
File
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 15:
(4 comments)
Lets try to merge this and leave additional work to later - this patch should
not
Nir Soffer has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 17:
(1 comment)
Looks good expect the unneeded comments.
Dan Kenigsberg has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 17:
(1 comment)
https://gerrit.ovirt.org/#/c/48871/17/lib/vdsm/define.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 15:
(3 comments)
https://gerrit.ovirt.org/#/c/48871/15/lib/vdsm/exception.py
File
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 15:
(5 comments)
https://gerrit.ovirt.org/#/c/48871/15/lib/vdsm/exception.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 16: Code-Review-1
Please see my comments from patch set #15.
--
To view, visit
Martin Polednik has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 16: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48871
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 16: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48871
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 15: Code-Review-1
(8 comments)
It seems that we need to align the codes between engine and
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 13: -Code-Review
Let's have it finished
--
To view, visit https://gerrit.ovirt.org/48871
To
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/48871
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 10: Code-Review-1 -Verified
--
To view, visit https://gerrit.ovirt.org/48871
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48871
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 9: Verified-1
Unfinished, do not merge.
--
To view, visit https://gerrit.ovirt.org/48871
To
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 8:
This version updates the copyright year on modified modules.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 6:
No code changes, just rebase
--
To view, visit https://gerrit.ovirt.org/48871
To
Piotr Kliczewski has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 5: Code-Review-1
(1 comment)
The codes are part of the contract between the engine and vdsm.
Martin Polednik has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 5: Code-Review+1
I'm not fan of adding translation layers. That being said, I don't like the
Nir Soffer has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 5:
Francesco?
--
To view, visit https://gerrit.ovirt.org/48871
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 5:
I like the concept. Will give the score once it is done.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 5: Code-Review-1
-1 because of a question
this comment is not necessarily related to this
Nir Soffer has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 5:
Francesco, once we have exceptions for any response, we don't need the response
module.
Virt
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
51 matches
Mail list logo
