Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-21 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: lib: response: helper to detect valid responses .. lib: response: helper to detect valid responses We should build responses in the API layer, and the resp

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-21 Thread fromani
Francesco Romani has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 14: Verified+1 this change is covered by tests. -- To view, visit https://gerrit.ovirt.org/6376

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-21 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 14: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63760 To unsubscribe, visit https:/

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/63760/11/lib/vdsm/common/response.py File lib/vdsm/

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-16 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 12: I am missing information how do we plan to use this utility -- To view, visit https://gerri

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 12: Code-Review-1 (1 comment) -1 so we dont forget the missing docstring https://gerrit.ovirt.org/#/c

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-14 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/63760/11/lib/vdsm/common/response.py File lib/vdsm/common

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 9: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/63760/9/lib/vdsm/response.py File lib/

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-14 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63760 To unsubscribe, visit https://gerrit

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 7: (3 comments) https://gerrit.ovirt.org/#/c/63760/7/lib/vdsm/response.py File lib/vdsm/response

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-14 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 7: (3 comments) https://gerrit.ovirt.org/#/c/63760/7/lib/vdsm/response.py File lib/vdsm/response.py:

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-14 Thread Jenkins CI
Jenkins CI has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 3: Continuous-Integration-1 Propagate review hook: Continuous Integration value inherited from patch 2

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-14 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: lib: response: helper to detect valid responses .. lib: response: helper to detect valid responses Ideally, we should build responses in the API layer, from