Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-17 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/50372 To unsubscribe, visit

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-17 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50372 To unsubscribe, visit

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 3: Code-Review+1 Partial ACK. do we need to wait for Engine to support this feature, or

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-17 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 3: a. IMO we can insert this w/o waiting for engine. it breaks nothing since engine currently

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-17 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. net: support hot(un)plugNic for SRIOV network devices. The missing behavior was to

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. --

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 3: Code-Review+2 looks OK to me. -- To view, visit https://gerrit.ovirt.org/50372 To

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-16 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 3: -Verified -- To view, visit https://gerrit.ovirt.org/50372 To unsubscribe, visit

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-15 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/50372 To unsubscribe, visit

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-15 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/50372 To unsubscribe, visit

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-15 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 3: Verified-1 -- To view, visit https://gerrit.ovirt.org/50372 To unsubscribe, visit

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-14 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/50372/1/vdsm/virt/vm.py File vdsm/virt/vm.py:

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-14 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/50372/2/vdsm/virt/vm.py File vdsm/virt/vm.py:

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-14 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 3: Continuous-Integration+1 07:42:47 ERROR: Tests mkimage.mkFloppyFs creating an image and

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-14 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 2: Code-Review+1 Seems fine for normal SR-IOV usage. -- To view, visit

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-14 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/50372/2/vdsm/virt/vm.py File vdsm/virt/vm.py:

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-14 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/50372/2/vdsm/virt/vm.py File vdsm/virt/vm.py:

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-13 Thread ibarkan
Ido Barkan has uploaded a new change for review. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. net: support hot(un)plugNic for SRIOV network devices. The missing behavior was to automatically

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50372 To unsubscribe, visit

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 1: Needs rebase? -- To view, visit https://gerrit.ovirt.org/50372 To unsubscribe, visit

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-13 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/50372/1/vdsm/virt/vm.py File