Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[fromani]

Francesco Romani has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 3: Code-Review+1

Partial ACK.

do we need to wait for Engine to support this feature, or is the other way 
around (Engine is waiting for us to support this).

Furthermore, how this will play with backward compatibility? any concern?

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 3:

a. IMO we can insert this w/o waiting for engine. it breaks nothing since 
engine currently calls hot(un)plugNic with only regular nics. since the current 
changes only take place if nic.is_hostdevice: we are safe.
b. SRIOV code (including is_hostdevice attribute) is in 3.6 already- so no 
problem in master).

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


net: support hot(un)plugNic for SRIOV network devices.

The missing behavior was to automatically attach/detach the
moving devices to/from the host.
For this feature to be supported, a corresponding engine side patch
is needed: I9bdf0d4cf9713691246015cf0297364a0dc40e95

Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Signed-off-by: Ido Barkan 
Reviewed-on: https://gerrit.ovirt.org/50372
Continuous-Integration: Dan Kenigsberg 
Tested-by: Alona Kaplan 
Reviewed-by: Edward Haas 
Reviewed-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Ido Barkan: Verified
  Alona Kaplan: Verified
  Dan Kenigsberg: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[fromani]

Francesco Romani has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 3: Code-Review+2

looks OK to me.

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 3: -Verified

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[alkaplan]

Alona Kaplan has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 3: Verified-1

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/50372/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2011: self.log.info("Hotplug NIC xml: %s", nicXml)
Line 2012: 
Line 2013: try:
Line 2014: if nic.is_hostdevice:
Line 2015: 
hostdev.detach_detachable(params.get(hwclass.HOSTDEV))
> Why get()? If hostdev is missing from a hostdev device, we should explode h
Done
Line 2016: self._dom.attachDevice(nicXml)
Line 2017: except libvirt.libvirtError as e:
Line 2018: self.log.exception("Hotplug failed")
Line 2019: nicXml = hooks.after_nic_hotplug_fail(


Line 2273: 
Line 2274: try:
Line 2275: self._dom.detachDevice(nicXml)
Line 2276: self._waitForDeviceRemoval(nic)
Line 2277: if nic and nic.is_hostdevice:
> Same issue: can nic ever be None here?
Done
Line 2278: hostdev.reattach_detachable(nic.hostdev)
Line 2279: except HotunplugTimeout as e:
Line 2280: self.log.error("%s", e)
Line 2281: return response.error('hotunplugNic', "%s" % e)


-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/50372/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2011: self.log.info("Hotplug NIC xml: %s", nicXml)
Line 2012: 
Line 2013: try:
Line 2014: if nic.is_hostdevice:
Line 2015: hostdev.detach_detachable(params[hwclass.HOSTDEV])
> jsonrpc.Executor/7::DEBUG::2015-12-14 17:57:49,571::__init__::509::jsonrpc.
silly me.
Line 2016: self._dom.attachDevice(nicXml)
Line 2017: except libvirt.libvirtError as e:
Line 2018: self.log.exception("Hotplug failed")
Line 2019: nicXml = hooks.after_nic_hotplug_fail(


-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 3: Continuous-Integration+1

07:42:47 ERROR: Tests mkimage.mkFloppyFs creating an image and checking its 
content.
07:42:47 --
07:42:47 Traceback (most recent call last):
07:42:47   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/testlib.py",
 line 73, in wrapper
07:42:47 return f(self, *args)
07:42:47   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/testValidation.py",
 line 97, in wrapper
07:42:47 return f(*args, **kwargs)
07:42:47   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/mkimageTests.py",
 line 172, in test_mkFloppyFs
07:42:47 m.mount(mntOpts='loop')
07:42:47   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/vdsm/storage/mount.py",
 line 225, in mount
07:42:47 return self._runcmd(cmd, timeout)
07:42:47   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/vdsm/storage/mount.py",
 line 241, in _runcmd
07:42:47 raise MountError(rc, ";".join((out, err)))
07:42:47 MountError: (32, ';mount: 
/tmp/vdsm-mkimage-testswqsKjg/images/vmId_floppy.0478bd99cc3b39a408d863d4babd70bd.img:
 failed to setup loop device: No such file or directory\n')

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 2: Code-Review+1

Seems fine for normal SR-IOV usage.

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[alkaplan]

Alona Kaplan has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/50372/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2011: self.log.info("Hotplug NIC xml: %s", nicXml)
Line 2012: 
Line 2013: try:
Line 2014: if nic.is_hostdevice:
Line 2015: hostdev.detach_detachable(params[hwclass.HOSTDEV])
> Traceback (most recent call last):
jsonrpc.Executor/7::DEBUG::2015-12-14 
17:57:49,571::__init__::509::jsonrpc.JsonRpcServer::(_serveRequest) Calling 
'VM.hotplugNic' in bridge with {'params': {'nic': {'macAddr': 
'00:1a:4a:16:01:52', 'specParams': 
{}, 'hostdev': 'pci__02_10_2', 'deviceId': 
'926beebb-2389-42f5-b9ae-a1ab1ff56257', 'device': 'hostdev', 'type': 
'interface'}, 'vmId': '5265b214-52b9-4bfe-b661-c81c19e77df8'}, 'vmID': 
'5265b214-52b9-4bfe-b661
-c81c19e77df8'}
jsonrpc.Executor/7::DEBUG::2015-12-14 17:57:49,584::utils::645::root::(execCmd) 
/usr/bin/taskset --cpu-list 0-7 
/usr/libexec/vdsm/hooks/before_nic_hotplug/50_vmfex (cwd None)
jsonrpc.Executor/7::DEBUG::2015-12-14 17:57:49,703::utils::663::root::(execCmd) 
SUCCESS:  = '';  = 0
jsonrpc.Executor/7::INFO::2015-12-14 
17:57:49,704::hooks::101::root::(_runHooksDir) 
jsonrpc.Executor/7::INFO::2015-12-14 
17:57:49,704::vm::2011::virt.vm::(hotplugNic) 
vmId=`5265b214-52b9-4bfe-b661-c81c19e77df8`::Hotplug NIC xml: 






Line 2016: self._dom.attachDevice(nicXml)
Line 2017: except libvirt.libvirtError as e:
Line 2018: self.log.exception("Hotplug failed")
Line 2019: nicXml = hooks.after_nic_hotplug_fail(


-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[alkaplan]

Alona Kaplan has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/50372/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2011: self.log.info("Hotplug NIC xml: %s", nicXml)
Line 2012: 
Line 2013: try:
Line 2014: if nic.is_hostdevice:
Line 2015: hostdev.detach_detachable(params[hwclass.HOSTDEV])
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/yajsonrpc/__init__.py", line 527, in 
_serveRequest
res = method(**params)
  File "/usr/share/vdsm/rpc/Bridge.py", line 279, in _dynamicMethod
result = fn(*methodArgs)
  File "/usr/share/vdsm/API.py", line 431, in hotplugNic
return curVm.hotplugNic(params)
  File "/usr/share/vdsm/virt/vm.py", line 2015, in hotplugNic
hostdev.detach_detachable(params[hwclass.HOSTDEV])
KeyError: 'hostdev'
Line 2016: self._dom.attachDevice(nicXml)
Line 2017: except libvirt.libvirtError as e:
Line 2018: self.log.exception("Hotplug failed")
Line 2019: nicXml = hooks.after_nic_hotplug_fail(


-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[ibarkan]

Ido Barkan has uploaded a new change for review.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..

net: support hot(un)plugNic for SRIOV network devices.

The missing behavior was to automatically attach/detach the
moving devices to/from the host.
For this feature to be supported, a corresponding engine side patch
is needed: I9bdf0d4cf9713691246015cf0297364a0dc40e95

Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Signed-off-by: Ido Barkan 
---
M vdsm/virt/vm.py
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/50372/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 71126b3..0229509 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2011,6 +2011,8 @@
 self.log.info("Hotplug NIC xml: %s", nicXml)
 
 try:
+if nic.is_hostdevice:
+hostdev.detach_detachable(params.get(hwclass.HOSTDEV))
 self._dom.attachDevice(nicXml)
 except libvirt.libvirtError as e:
 self.log.exception("Hotplug failed")
@@ -2272,6 +2274,8 @@
 try:
 self._dom.detachDevice(nicXml)
 self._waitForDeviceRemoval(nic)
+if nic and nic.is_hostdevice:
+hostdev.reattach_detachable(nic.hostdev)
 except HotunplugTimeout as e:
 self.log.error("%s", e)
 return response.error('hotunplugNic', "%s" % e)


-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 1:

Needs rebase?

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/50372/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2011: self.log.info("Hotplug NIC xml: %s", nicXml)
Line 2012: 
Line 2013: try:
Line 2014: if nic.is_hostdevice:
Line 2015: 
hostdev.detach_detachable(params.get(hwclass.HOSTDEV))
Why get()? If hostdev is missing from a hostdev device, we should explode here 
and now.
Line 2016: self._dom.attachDevice(nicXml)
Line 2017: except libvirt.libvirtError as e:
Line 2018: self.log.exception("Hotplug failed")
Line 2019: nicXml = hooks.after_nic_hotplug_fail(


Line 2273: 
Line 2274: try:
Line 2275: self._dom.detachDevice(nicXml)
Line 2276: self._waitForDeviceRemoval(nic)
Line 2277: if nic and nic.is_hostdevice:
Same issue: can nic ever be None here?
Line 2278: hostdev.reattach_detachable(nic.hostdev)
Line 2279: except HotunplugTimeout as e:
Line 2280: self.log.error("%s", e)
Line 2281: return response.error('hotunplugNic', "%s" % e)


-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches