Re: [PATCH] configure: $x_includes used even if not set

2009-04-13 Fir de Conversatie Rainer Müller
Tony Mechelynck wrote: On 11/04/09 04:16, Matt Wozniski wrote: On Fri, Apr 10, 2009 at 6:43 PM, Tony Mechelynck wrote: Couldn't you run test just once? Maybe something more or less like if test -n $x_includes -a $x_includes != NONE Just my sense of aesthetics, I'm not on a Mac.

[PATCH] configure: $x_includes used even if not set

2009-04-10 Fir de Conversatie Rainer Müller
Hi, I am the maintainer for vim in MacPorts. The configure script triggered a linking error for _Xsetlocale for us on Mac OS X. Here is a patch which adds a conditional to make sure this test is not run if the x_includes variable is actually not set. Regards, Rainer

Re: [PATCH] configure: $x_includes used even if not set

2009-04-10 Fir de Conversatie Tony Mechelynck
On 11/04/09 00:14, Rainer Müller wrote: Hi, I am the maintainer for vim in MacPorts. The configure script triggered a linking error for _Xsetlocale for us on Mac OS X. Here is a patch which adds a conditional to make sure this test is not run if the x_includes variable is actually not set.

Re: [PATCH] configure: $x_includes used even if not set

2009-04-10 Fir de Conversatie Matt Wozniski
On Fri, Apr 10, 2009 at 6:43 PM, Tony Mechelynck wrote: Couldn't you run test just once? Maybe something more or less like        if test -n $x_includes -a $x_includes != NONE Just my sense of aesthetics, I'm not on a Mac. Usually, yes - but lore tells of shells where test isn't POSIX

Re: [PATCH] configure: $x_includes used even if not set

2009-04-10 Fir de Conversatie Tony Mechelynck
On 11/04/09 04:16, Matt Wozniski wrote: On Fri, Apr 10, 2009 at 6:43 PM, Tony Mechelynck wrote: Couldn't you run test just once? Maybe something more or less like if test -n $x_includes -a $x_includes != NONE Just my sense of aesthetics, I'm not on a Mac. Usually, yes - but lore

Re: [PATCH] configure: $x_includes used even if not set

2009-04-10 Fir de Conversatie Matt Wozniski
On Fri, Apr 10, 2009 at 10:53 PM, Tony Mechelynck wrote: On 11/04/09 04:16, Matt Wozniski wrote: On Fri, Apr 10, 2009 at 6:43 PM, Tony Mechelynck wrote: Couldn't you run test just once? Maybe something more or less like         if test -n $x_includes -a $x_includes != NONE Just my sense

Re: [PATCH] configure: $x_includes used even if not set

2009-04-10 Fir de Conversatie Tony Mechelynck
On 11/04/09 05:02, Matt Wozniski wrote: On Fri, Apr 10, 2009 at 10:53 PM, Tony Mechelynck wrote: On 11/04/09 04:16, Matt Wozniski wrote: On Fri, Apr 10, 2009 at 6:43 PM, Tony Mechelynck wrote: Couldn't you run test just once? Maybe something more or less like if test -n