Re: callback is not called when job exit immediately.

2016-09-04 Fir de Conversatie mattn
On Monday, September 5, 2016 at 11:30:42 AM UTC+9, mattn wrote: > > Isn't the best solution then to have channel_wait() not return an error? > > Or is there some way to detect the situation, perhaps by using > > LastError(). At least it should only affect Windows, since on Unix we > > don't want

Re: Bug: make cannot run testdir/Make_ming.mak using a unix shell under Windows 10

2016-09-04 Fir de Conversatie Ken Takata
Hi mike, 2016/9/5 Mon 10:07:00 UTC+9 Michael Soyka wrote: > The makefile testdir/Make_ming.mak contains statements of the form: > >if exist test.ok $(DEL) test.ok > > which can only be executed by one of the DOS/Windows command shells such > as command.com or cmd.exe > > My version of

Re: callback is not called when job exit immediately.

2016-09-04 Fir de Conversatie mattn
> Isn't the best solution then to have channel_wait() not return an error? > Or is there some way to detect the situation, perhaps by using > LastError(). At least it should only affect Windows, since on Unix we > don't want to make this exception. I say again, This is posssible to be reproduced

Bug: make cannot run testdir/Make_ming.mak using a unix shell under Windows 10

2016-09-04 Fir de Conversatie Michael Soyka
The makefile testdir/Make_ming.mak contains statements of the form: if exist test.ok $(DEL) test.ok which can only be executed by one of the DOS/Windows command shells such as command.com or cmd.exe My version of make, gnu 3.82.90, sets the SHELL make variable to the value

Re: Patch 7.4.2304

2016-09-04 Fir de Conversatie Ozaki Kiichi
Calling timer_stop in timer-callback causes SEGV. [repro steps] test.vim: function! StopTimer1(timer) let g:timer2 = timer_start(50, 'StopTimer2') " avoid bothersome maxfuncdepth error call timer_pause(g:timer1, 1) sleep 100m endfunction function! StopTimer2(timer) let g:timer3 =

Test test_getcwd needs to have noswapfile option set

2016-09-04 Fir de Conversatie Michael Soyka
The Vim test "test_getcwd" creates a temporary directory "Xtopdir" that should be deleted at test conclusion but is not. This directory is not deleted because the test has created swap files that apparently are open when the test attempts to cleanup before terminating. Setting the noswapfile

Patch 7.4.2330

2016-09-04 Fir de Conversatie Bram Moolenaar
Patch 7.4.2330 Problem:Coverity complains about not checking curwin to be NULL. Solution: Use firstwin to avoid the warning. Files: src/buffer.c *** ../vim-7.4.2329/src/buffer.c2016-09-04 21:33:05.30683 +0200 --- src/buffer.c2016-09-04 21:51:43.153307277 +0200

Patch 7.4.2329

2016-09-04 Fir de Conversatie Bram Moolenaar
Patch 7.4.2329 Problem:Error for min() and max() contains %s. (Nikolay Pavlov) Solution: Pass the function name. (closes #1040) Files: src/evalfunc.c, src/testdir/test_expr.vim *** ../vim-7.4.2328/src/evalfunc.c 2016-09-01 15:11:13.540265471 +0200 --- src/evalfunc.c

Re: [patch] SEGV when autocmd BufUnload with bwipe

2016-09-04 Fir de Conversatie Bram Moolenaar
Hirohito Higashi wrote: > 2016-9-4(Sun) 21:33:17 UTC+9 h_east: > > Hi Bram and developers, > > > > I checked in 7.4.2321 > > > > Case 1 > > How to reproduce: > > - Create the following file: > > $ cat sample1.vim > > edit a.txt > > augroup sample > > autocmd! > > autocmd

Patch 7.4.2328

2016-09-04 Fir de Conversatie Bram Moolenaar
Patch 7.4.2328 Problem:Crash when BufWinLeave autocmd goes to another tab page. (Hirohito Higashi) Solution: Make close_buffer() go back to the right window. Files: src/buffer.c, src/testdir/test_autocmd.vim *** ../vim-7.4.2327/src/buffer.c2016-09-04

Patch 7.4.2327

2016-09-04 Fir de Conversatie Bram Moolenaar
Patch 7.4.2327 Problem:Freeing a variable that is on the stack. Solution: Don't free res_tv or err_tv. (Ozaki Kiichi) Files: src/channel.c *** ../vim-7.4.2326/src/channel.c 2016-09-01 15:11:13.544265437 +0200 --- src/channel.c 2016-09-04 20:40:17.984927934 +0200

Re: [bug][patch] invalid free() in channel_exe_cmd()

2016-09-04 Fir de Conversatie Bram Moolenaar
Ozaki Kiichi wrote: > There is a bug to try to release a variable on stack area. > > [repro steps] > > test.vim: > > let s:handle = ch_open('localhost:8765') > call ch_sendexpr(s:handle, 'hello!') > > > 1. run server "python runtime/tools/demoserver.py" > > 2. vim -Nu NONE -S

Re: [bug] heap read overflow in vim-7.4.2323

2016-09-04 Fir de Conversatie Bram Moolenaar
Dominique Pellé wrote: > The attached (nonsensical) vim script found by afl-fuzz > causes a read heap overflow in Vim-7.4.2323 and older: > > $ valgrind --num-callers=40 ./vim -u NONE -S overflow2.vim 2> log > > ==8161== Memcheck, a memory error detector > ==8161== Copyright (C) 2002-2015,

Patch 7.4.2326

2016-09-04 Fir de Conversatie Bram Moolenaar
Patch 7.4.2326 Problem:Illegal memory access when Visual selection starts in invalid position. (Dominique Pelle) Solution: Correct position when needed. Files: src/normal.c, src/misc2.c, src/proto/misc2.pro *** ../vim-7.4.2325/src/normal.c2016-09-03

Patch 7.4.2325

2016-09-04 Fir de Conversatie Bram Moolenaar
Patch 7.4.2325 (after 7.4.2324) Problem:Tiny build fails. Solution: Add #ifdef. Files: src/buffer.c *** ../vim-7.4.2324/src/buffer.c2016-09-04 19:50:50.512985798 +0200 --- src/buffer.c2016-09-04 19:56:47.498072555 +0200 *** *** 476,481 --- 476,482

Re: callback is not called when job exit immediately.

2016-09-04 Fir de Conversatie Bram Moolenaar
Yasuhiro Matsumoto wrote: > On Sunday, September 4, 2016 at 11:19:35 PM UTC+9, Bram Moolenaar wrote: > > Yasuhiro Matsumoto wrote: > > > > > When the job exit immediately, channel->ch_to_be_closed will be TRUE > > > before channel_read even though the output buffer is filled enough to > > >

Patch 7.4.2324

2016-09-04 Fir de Conversatie Bram Moolenaar
Patch 7.4.2324 Problem:Crash when editing a new buffer and BufUnload autocommand wipes out the new buffer. (Norio Takagi) Solution: Don't allow wiping out this buffer. (partly by Hirohito Higashi) Move old style test13 into test_autocmd. Avoid ml_get error when

Re: [patch] SEGV when autocmd BufUnload with bwipe

2016-09-04 Fir de Conversatie Bram Moolenaar
Hirohito Higashi wrote: > Hi Bram and developers, > > I checked in 7.4.2321 > > Case 1 > How to reproduce: > - Create the following file: > $ cat sample1.vim > edit a.txt > augroup sample > autocmd! > autocmd BufUnload tabfirst | 2bwipeout! > augroup END > edit b.txt > > -

Re: [patch] SEGV when autocmd BufUnload with bwipe

2016-09-04 Fir de Conversatie h_east
Hi Bram, 2016-9-4(Sun) 21:33:17 UTC+9 h_east: > Hi Bram and developers, > > I checked in 7.4.2321 > > Case 1 > How to reproduce: > - Create the following file: > $ cat sample1.vim > edit a.txt > augroup sample > autocmd! > autocmd BufUnload tabfirst | 2bwipeout! > augroup END >

[bug] heap read overflow in vim-7.4.2323

2016-09-04 Fir de Conversatie Dominique Pellé
Hi The attached (nonsensical) vim script found by afl-fuzz causes a read heap overflow in Vim-7.4.2323 and older: $ valgrind --num-callers=40 ./vim -u NONE -S overflow2.vim 2> log ==8161== Memcheck, a memory error detector ==8161== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et

[bug][patch] invalid free() in channel_exe_cmd()

2016-09-04 Fir de Conversatie Ozaki Kiichi
Hi. There is a bug to try to release a variable on stack area. [repro steps] test.vim: let s:handle = ch_open('localhost:8765') call ch_sendexpr(s:handle, 'hello!') 1. run server "python runtime/tools/demoserver.py" 2. vim -Nu NONE -S test.vim 3. input '["call", "function", ["tr"],

Re: callback is not called when job exit immediately.

2016-09-04 Fir de Conversatie mattn
Additional, I could reproduce this on Linux. http://go-gyazo.appspot.com/d1ac2f988bba9549.png -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You

Re: callback is not called when job exit immediately.

2016-09-04 Fir de Conversatie mattn
On Sunday, September 4, 2016 at 11:19:35 PM UTC+9, Bram Moolenaar wrote: > Yasuhiro Matsumoto wrote: > > > When the job exit immediately, channel->ch_to_be_closed will be TRUE > > before channel_read even though the output buffer is filled enough to > > read. For example, following command

Re: callback is not called when job exit immediately.

2016-09-04 Fir de Conversatie Bram Moolenaar
Yasuhiro Matsumoto wrote: > When the job exit immediately, channel->ch_to_be_closed will be TRUE > before channel_read even though the output buffer is filled enough to > read. For example, following command doesn't output result of the job. > > - > function! Disp(ch, msg) > echom

Re: [bug?][patch] Vim command completion is not performed, when expression register inserted

2016-09-04 Fir de Conversatie h_east
Hi Bram and developers, 2016-9-3(Sat) 21:52:42 UTC+9 Bram Moolenaar: > Hirohito Higashi wrote: > > > How to reproduce: > > - Prepare the following vim script file. > > $ cat sample1.vim > > function! Sample() > > return 'autocmd ' > > endfunction > > call feedkeys("i\=Sample()\\\") > > >

callback is not called when job exit immediately.

2016-09-04 Fir de Conversatie mattn
Hi. When the job exit immediately, channel->ch_to_be_closed will be TRUE before channel_read even though the output buffer is filled enough to read. For example, following command doesn't output result of the job. - function! Disp(ch, msg) echom a:msg endfunction function!

Patch 7.4.2322

2016-09-04 Fir de Conversatie Bram Moolenaar
Patch 7.4.2323 Problem:Using freed memory when using 'formatexpr'. (Dominique Pelle) Solution: Make a copy of 'formatexpr' before evaluating it. Files: src/ops.c, src/testdir/test_normal.vim *** ../vim-7.4.2322/src/ops.c 2016-08-29 22:48:12.157106115 +0200 --- src/ops.c

Re: [bug] use of free memory with 'formatexpr'

2016-09-04 Fir de Conversatie Bram Moolenaar
Dominique Pellé wrote: > afl-fuzz found a use of free memory in Vim-7.4.2321 > and older. The script contains errors, but it should not > cause vim to access freed memory: > > $ cat bug.vim > func Foo() > let l = getli|e() > endfunc > set formatexpr=Foo() > norm gqG > > $ valgrind

Patch 7.4.2322

2016-09-04 Fir de Conversatie Bram Moolenaar
Patch 7.4.2322 Problem:Access memory beyond the end of the line. (Dominique Pelle) Solution: Adjust the cursor column. Files: src/move.c, src/testdir/test_normal.vim *** ../vim-7.4.2321/src/move.c 2016-08-29 22:48:12.153106148 +0200 --- src/move.c 2016-09-04 14:29:37.940164391

Re: [bug] heap buffer overflow with CTRL-F and CTRL-B scrolling normal commands

2016-09-04 Fir de Conversatie Bram Moolenaar
Dominique Pellé wrote: > afl-fuzz found a heap buffer overflow in vim-7.4.2321 > and older. At least vim-7.4.52 in xubuntu-14.04 is > also affected so it's an old bug. > > Steps to reproduce: > > $ cat overflow.vim > norm oxx > exe "norm 2\" > exe "norm 2\" > > $ valgrind vim -u NONE -S

[patch] SEGV when autocmd BufUnload with bwipe

2016-09-04 Fir de Conversatie h_east
Hi Bram and developers, I checked in 7.4.2321 Case 1 How to reproduce: - Create the following file: $ cat sample1.vim edit a.txt augroup sample autocmd! autocmd BufUnload tabfirst | 2bwipeout! augroup END edit b.txt - Run vanilla Vim with above script file $ vim -Nu NONE -S

Re: Patch 7.4.2299

2016-09-04 Fir de Conversatie LCD 47
On 3 September 2016, Bram Moolenaar wrote: > > Lcd wrote: > > > > > On 1 September 2016, Bram Moolenaar wrote: > > > > > > > > > > Patch 7.4.2299 Problem: QuickFixCmdPre and QuickFixCmdPost > > > > > autocommands are not always triggered. Solution: Also

[bug] heap buffer overflow with CTRL-F and CTRL-B scrolling normal commands

2016-09-04 Fir de Conversatie Dominique Pellé
Hi afl-fuzz found a heap buffer overflow in vim-7.4.2321 and older. At least vim-7.4.52 in xubuntu-14.04 is also affected so it's an old bug. Steps to reproduce: $ cat overflow.vim norm oxx exe "norm 2\" exe "norm 2\" $ valgrind vim -u NONE -S overflow.vim -c 'q!' 2> log log file contains:

Re: [vim/vim] gvim exits with "BadWindow (invalid window parameter)" when highlighting large regions (#1023)

2016-09-04 Fir de Conversatie John Little
I can reproduce this with 7.4.1689, 7.4.2161, and 7.4.2321, all with GTK2 on KDE with plasma 5. I'll have a go later with debug, valgrind and asan. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more

[bug] use of free memory with 'formatexpr'

2016-09-04 Fir de Conversatie Dominique Pellé
Hi afl-fuzz found a use of free memory in Vim-7.4.2321 and older. The script contains errors, but it should not cause vim to access freed memory: $ cat bug.vim func Foo() let l = getli|e() endfunc set formatexpr=Foo() norm gqG $ valgrind --num-callers=50 vim -u NONE -S bug.vim -c q 2>log And