Re: Patch 8.0.0224

2017-01-24 Fir de Conversatie Dominique Pellé
Christian Brabandt wrote: > On Di, 24 Jan 2017, Christian Brabandt wrote: > >> On Di, 24 Jan 2017, Dominique Pellé wrote: >> > How about an address sanitizer build in Travis to catch >> > this kind of bugs earlier in CI? > > Here is a patch. > > Sample logfiles here: >

Re: Patch 8.0.0224

2017-01-24 Fir de Conversatie Christian Brabandt
On Di, 24 Jan 2017, Christian Brabandt wrote: > On Di, 24 Jan 2017, Dominique Pellé wrote: > > How about an address sanitizer build in Travis to catch > > this kind of bugs earlier in CI? Here is a patch. Sample logfiles here: https://travis-ci.org/chrisbra/vim/builds/194982196 This was with

[patch] mch_memmove has parameters in wrong order

2017-01-24 Fir de Conversatie Dominique Pellé
Hi mch_memmove is typically a #define which directly calls memmove(dest, src, len). But I noticed that in misc2.c, there is an implementation for systems that don't have memmove(). That implementation is wrong! It has its parameters in the wrong order. Vim would crash if it was used. We could

Re: Patch 8.0.0230

2017-01-24 Fir de Conversatie Ken Takata
Hi Bram, 2017/1/25 Wed 1:51:28 UTC+9 Bram Moolenaar wrote: > Patch 8.0.0230 (after 8.0.0210) > Problem:When using bracketed paste line breaks are not respected. > Solution: Turn CR characters into a line break if the text is being > inserted. (closes #1404) > Files:

Re: setpos() doesn't use the buffer argument for lowercase marks

2017-01-24 Fir de Conversatie Bram Moolenaar
Matthew Malcomson wrote: > I think it would be nice if setpos() uses the bufnum part of the > position it's given when asked to set a lowercase mark. > > Also, when it's given an invalid buffer number exist for uppercase and > numbered marks I think it should fail and return -1. > > I have a

Re: [vim/vim] :set wildoptions+=tagfile and completion (#1399)

2017-01-24 Fir de Conversatie Bram Moolenaar
Christian Brabandt wrote: > On Fr, 20 Jan 2017, desjardinsm wrote: > > > When "set wildoptions=tagfile" it actually changes the way the ":h > > tag-regexp" for completion works. With the default wildoptions of course a > > ":tag /" will work as the help describes. But with wildoptions set,

Patch 8.0.0237

2017-01-24 Fir de Conversatie Bram Moolenaar
Patch 8.0.0237 Problem:When setting wildoptions=tagfile the completion context is not set correctly. (desjardins) Solution: Check for EXPAND_TAGS_LISTFILES. (Christian Brabandt, closes #1399) Files: src/ex_getln.c, src/testdir/test_cmdline.vim ***

setpos() doesn't use the buffer argument for lowercase marks

2017-01-24 Fir de Conversatie Matthew Malcomson
I think it would be nice if setpos() uses the bufnum part of the position it's given when asked to set a lowercase mark. Also, when it's given an invalid buffer number exist for uppercase and numbered marks I think it should fail and return -1. I have a suggested patch and test below. diff

Patch 8.0.0236

2017-01-24 Fir de Conversatie Bram Moolenaar
Patch 8.0.0236 (after 8.0.0234) Problem:Gcc complains that a variable may be used uninitialized. Confusion between variable and label name. (John Marriott) Solution: Initialize it. Rename end to end_lnum. Files: src/ops.c *** ../vim-8.0.0235/src/ops.c 2017-01-24

Re: Patch 8.0.0234

2017-01-24 Fir de Conversatie Bram Moolenaar
John Marriott wrote: > On 25-Jan-2017 05:56, Bram Moolenaar wrote: > > Patch 8.0.0234 (after 8.0.0225) > > Problem:When several lines are visually selected and one of them is > > short, > > using put may cause a crash. (Axel Bender) > > Solution: Check for a short line.

Re: Patch 8.0.0234

2017-01-24 Fir de Conversatie John Marriott
On 25-Jan-2017 05:56, Bram Moolenaar wrote: Patch 8.0.0234 (after 8.0.0225) Problem:When several lines are visually selected and one of them is short, using put may cause a crash. (Axel Bender) Solution: Check for a short line. (Christian Brabandt) Files: src/ops.c,

Patch 8.0.0235

2017-01-24 Fir de Conversatie Bram Moolenaar
Patch 8.0.0235 Problem:Memory leak detected when running tests for diff mode. Solution: Free p_extra_free. Files: src/screen.c *** ../vim-8.0.0234/src/screen.c2017-01-08 20:00:00.228408247 +0100 --- src/screen.c2017-01-24 20:12:24.520395169 +0100 *** ***

Re: netrw blocks TermResponse autocommand event

2017-01-24 Fir de Conversatie Gary Johnson
On 2017-01-24, Bram Moolenaar wrote: > Gary Johnson wrote: > > > On 2017-01-24, Christian Brabandt wrote: > > > Hi Bram! > > > > > > On Di, 24 Jan 2017, Bram Moolenaar wrote: > > > > > > > Hmm, so when using "eventignore=all" perhaps the TermResponse should not > > > > be ignored? Or should we

Patch 8.0.0234

2017-01-24 Fir de Conversatie Bram Moolenaar
Patch 8.0.0234 (after 8.0.0225) Problem:When several lines are visually selected and one of them is short, using put may cause a crash. (Axel Bender) Solution: Check for a short line. (Christian Brabandt) Files: src/ops.c, src/testdir/test_put.vim ***

Re: Gvim crashes after visual paste and undo

2017-01-24 Fir de Conversatie Bram Moolenaar
Christian Brabandt wrote: > On Di, 24 Jan 2017, Christian Brabandt wrote: > > > I'll work more on it later, if I have some more time and will add a > > test. > > Here is a patch with a test. However the test does not trigger the > segfault. But I figure, it should still work and probably

Re: netrw blocks TermResponse autocommand event

2017-01-24 Fir de Conversatie Bram Moolenaar
Gary Johnson wrote: > On 2017-01-24, Christian Brabandt wrote: > > Hi Bram! > > > > On Di, 24 Jan 2017, Bram Moolenaar wrote: > > > > > Hmm, so when using "eventignore=all" perhaps the TermResponse should not > > > be ignored? Or should we support the value "all,-TermResponse"? > > > It's

Patch 8.0.0233

2017-01-24 Fir de Conversatie Bram Moolenaar
Patch 8.0.0233 (after 8.0.0231) Problem:The paste test fails if the GUI is being used. Solution: Skip the test in the GUI. Files: src/testdir/test_paste.vim *** ../vim-8.0.0232/src/testdir/test_paste.vim 2017-01-24 18:58:14.910505196 +0100 --- src/testdir/test_paste.vim 2017-01-24

Patch 8.0.0232

2017-01-24 Fir de Conversatie Bram Moolenaar
Patch 8.0.0232 Problem:Pasting in Insert mode does not work when bracketed paste is used and 'esckeys' is off. Solution: When 'esckeys' is off disable bracketed paste in Insert mode. Files: src/edit.c *** ../vim-8.0.0231/src/edit.c 2017-01-24 18:58:14.910505196 +0100 ---

Re: netrw blocks TermResponse autocommand event

2017-01-24 Fir de Conversatie Gary Johnson
On 2017-01-24, Christian Brabandt wrote: > Hi Bram! > > On Di, 24 Jan 2017, Bram Moolenaar wrote: > > > Hmm, so when using "eventignore=all" perhaps the TermResponse should not > > be ignored? Or should we support the value "all,-TermResponse"? > > It's going to be tricky either way. > > I

Patch 8.0.0231

2017-01-24 Fir de Conversatie Bram Moolenaar
Patch 8.0.0231 Problem:There are no tests for bracketed paste mode. Solution: Add a test. Fix repeating with "normal .". Files: src/edit.c, src/testdir/test_paste.vim, src/Makefile, src/testdir/Make_all.mak *** ../vim-8.0.0230/src/edit.c 2017-01-24 17:50:48.753765383

Re: netrw blocks TermResponse autocommand event

2017-01-24 Fir de Conversatie Christian Brabandt
Hi Bram! On Di, 24 Jan 2017, Bram Moolenaar wrote: > Hmm, so when using "eventignore=all" perhaps the TermResponse should not > be ignored? Or should we support the value "all,-TermResponse"? > It's going to be tricky either way. I think it should not be ignored. If one really wants to ignore

Re: Gvim crashes after visual paste and undo

2017-01-24 Fir de Conversatie Christian Brabandt
On Di, 24 Jan 2017, Christian Brabandt wrote: > I'll work more on it later, if I have some more time and will add a > test. Here is a patch with a test. However the test does not trigger the segfault. But I figure, it should still work and probably asan would caught it. Best Christian -- Je

Patch 8.0.0230

2017-01-24 Fir de Conversatie Bram Moolenaar
Patch 8.0.0230 (after 8.0.0210) Problem:When using bracketed paste line breaks are not respected. Solution: Turn CR characters into a line break if the text is being inserted. (closes #1404) Files: src/edit.c *** ../vim-8.0.0229/src/edit.c 2017-01-21 20:04:17.562757816

Re: pythonx patch - :pyx command

2017-01-24 Fir de Conversatie Bram Moolenaar
Ken Takata wrote: > > > > > 2016/9/19 Mon 23:57:20 UTC+9 Kazunobu Kuriyama wrote: > > > > > > > 2016-09-19 23:21 GMT+09:00 Ken Takata : > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > 2013/6/1 Sat 3:49:45 UTC+9 Bram Moolenaar wrote: > > > > > > > > Marc Weber

Patch 8.0.0229

2017-01-24 Fir de Conversatie Bram Moolenaar
Patch 8.0.0229 (after 8.0.0179) Problem:When freeing a buffer the local value of the 'formatprg' option is not cleared. Solution: Add missing change. Files: src/buffer.c *** ../vim-8.0.0228/src/buffer.c2017-01-13 21:59:59.319172149 +0100 --- src/buffer.c

Re: [vim/vim] Feature Request: mode() returns Insert sub-mode (#1397)

2017-01-24 Fir de Conversatie h_east
Hi All, 2017-1-24(Tue) 2:03:05 UTC+9 Zhen-Huan (Kenny) Hu: > else if (ins_compl_active()) > > > > buf[1] = pum_visible() ? 'C' : 'c'; > > > > > > Does this 'C' vs. 'c' mean whether a completion was successful? I don't think > pum_visible() alone is able to determine this accurately since

Patch 8.0.0228

2017-01-24 Fir de Conversatie Bram Moolenaar
Patch 8.0.0228 (after 8.0.0210) Problem:When pasting test in an xterm on the command line it is surrounded by and . (Johannes Kaltenbach) Solution: Add missing changes. Files: src/ex_getln.c, src/term.c *** ../vim-8.0.0227/src/ex_getln.c 2017-01-11

Patch 8.0.0227

2017-01-24 Fir de Conversatie Bram Moolenaar
Patch 8.0.0227 Problem:Crash when 'fileformat' is forced to "dos" and the first line in the file is empty and does not have a CR character. Solution: Don't check for CR before the start of the buffer. Files: src/fileio.c, src/testdir/test_fileformat.vim ***

Re: Patch 8.0.0224

2017-01-24 Fir de Conversatie Bram Moolenaar
I wrote: > Dominique Pellé wrote: > > > Bram Moolenaar wrote: > > > > > Patch 8.0.0224 > > > Problem:When 'fileformats' is changed in a BufReadPre auto command, it > > > does not take effect in readfile(). (Gary Johnson) > > > Solution: Check the value of

Re: Patch 8.0.0224

2017-01-24 Fir de Conversatie Bram Moolenaar
Dominique Pellé wrote: > Bram Moolenaar wrote: > > > Patch 8.0.0224 > > Problem:When 'fileformats' is changed in a BufReadPre auto command, it > > does not take effect in readfile(). (Gary Johnson) > > Solution: Check the value of 'fileformats' after

Re: Patch 8.0.0224

2017-01-24 Fir de Conversatie Bram Moolenaar
Christian Brabandt wrote: > > Hi Bram! > > > > On Mo, 23 Jan 2017, Bram Moolenaar wrote: > > > > > + func Test_fileformat_autocommand() > > > + let filecnt=['', 'foobar', 'eins', '', 'zwei', 'drei', 'vier', > > > 'fünf', ''] > > > > That looks wrong. The first five items should have

Patch 8.0.0226

2017-01-24 Fir de Conversatie Bram Moolenaar
Patch 8.0.0226 Problem:The test for patch 8.0.0224 misses the CR characters and passes even without the fix. (Christian Brabandt) Solution: Use double quotes and \. Files: src/testidr/test_fileformat.vim *** ../vim-8.0.0225/src/testdir/test_fileformat.vim 2017-01-23

Re: Patch 8.0.0223

2017-01-24 Fir de Conversatie Bram Moolenaar
Tony Mechelynck wrote: > On Mon, Jan 23, 2017 at 8:47 PM, Bram Moolenaar wrote: > > > > Patch 8.0.0223 > > Problem:Coverity gets confused by the flags passed to find_tags() and > > warnts for an uninitialized variable. > > Solution: Disallow using cscope

Re: netrw blocks TermResponse autocommand event

2017-01-24 Fir de Conversatie Bram Moolenaar
Gary Johnson wrote: > When I open a directory from the command line, e.g., > > $ vim . > > TermResponse autocommand events are ignored. I think this is due to > one or more of the places in netrw where > > setl ei=all > > is executed. > > This can be demonstrated with the following

Re: Gvim crashes after visual paste and undo

2017-01-24 Fir de Conversatie Christian Brabandt
On Di, 24 Jan 2017, Christian Brabandt wrote: > Hi Axel! > > On Di, 24 Jan 2017, Axel Bender wrote: > > > Using the attached TXT file, and the keystrokes given below, gvim > > (8.0.1-225, compiled with GNU 6.2.0 64-bit on Windows 7) crashes. > > > > > gvim.exe -i NONE -u NONE --noplugin -U

Re: Gvim crashes after visual paste and undo

2017-01-24 Fir de Conversatie Christian Brabandt
Hi Axel! On Di, 24 Jan 2017, Axel Bender wrote: > Using the attached TXT file, and the keystrokes given below, gvim (8.0.1-225, > compiled with GNU 6.2.0 64-bit on Windows 7) crashes. > > > gvim.exe -i NONE -u NONE --noplugin -U NONE x.txt > > 2whvtuy2j9j2wpuu > > Can anyone else confirm

Gvim crashes after visual paste and undo

2017-01-24 Fir de Conversatie Axel Bender
Using the attached TXT file, and the keystrokes given below, gvim (8.0.1-225, compiled with GNU 6.2.0 64-bit on Windows 7) crashes. > gvim.exe -i NONE -u NONE --noplugin -U NONE x.txt 2whvtuy2j9j2wpuu Can anyone else confirm this? -- -- You received this message from the "vim_dev" maillist.