Re: Patch 8.0.0224

Christian Brabandt wrote: > On Do, 26 Jan 2017, Christian Brabandt wrote: > > > Hi Bram! > > > > On Do, 26 Jan 2017, Bram Moolenaar wrote: > > > > > > > > Christian Brabandt wrote: > > > > > > [...] > > > > > > > > So is this ready to include now? > > > > > > > > I would say so. > > > >

Re: Patch 8.0.0224

Hi vim_dev! On Do, 26 Jan 2017, Christian Brabandt wrote: > Hi Bram! > > On Do, 26 Jan 2017, Bram Moolenaar wrote: > > > > > Christian Brabandt wrote: > > > > [...] > > > > > > So is this ready to include now? > > > > > > I would say so. > > > > I included your change, but I see this

Re: Patch 8.0.0224

Hi Bram! On Do, 26 Jan 2017, Bram Moolenaar wrote: > > Christian Brabandt wrote: > > [...] > > > > So is this ready to include now? > > > > I would say so. > > I included your change, but I see this error: > > ImportError: >

Re: Patch 8.0.0224

Christian Brabandt wrote: [...] > > So is this ready to include now? > > I would say so. I included your change, but I see this error: ImportError: /home/travis/.local/lib/python2.7/site-packages/_cffi_backend.so: undefined symbol: llvm_gcda_end_file Not sure if it is related, it comes

Re: Patch 8.0.0224

Hi Bram! On Do, 26 Jan 2017, Bram Moolenaar wrote: > > Christian Brabandt wrote: > > > On Mi, 25 Jan 2017, Dominique Pellé wrote: > > > > > Christian Brabandt wrote: > > > > > > > Hi Dominique! > > > > > > > > On Mi, 25 Jan 2017, Dominique Pellé wrote: > > > > > > > >>

Re: Patch 8.0.0224

Christian Brabandt wrote: > On Mi, 25 Jan 2017, Dominique Pellé wrote: > > > Christian Brabandt wrote: > > > > > Hi Dominique! > > > > > > On Mi, 25 Jan 2017, Dominique Pellé wrote: > > > > > >> Christian Brabandt wrote: > > >> > > >> > On Di, 24 Jan 2017, Christian

Re: Patch 8.0.0224

Hi Dominique! On Mi, 25 Jan 2017, Dominique Pellé wrote: > Christian Brabandt wrote: > > > Hi Dominique! > > > > On Mi, 25 Jan 2017, Dominique Pellé wrote: > > > >> Christian Brabandt wrote: > >> > >> > On Di, 24 Jan 2017, Christian Brabandt wrote: > >> > > >> >> On Di, 24

Re: Patch 8.0.0224

Christian Brabandt wrote: > Hi Dominique! > > On Mi, 25 Jan 2017, Dominique Pellé wrote: > >> Christian Brabandt wrote: >> >> > On Di, 24 Jan 2017, Christian Brabandt wrote: >> > >> >> On Di, 24 Jan 2017, Dominique Pellé wrote: >> >> > How about an address sanitizer build in

Re: Patch 8.0.0224

Hi Dominique! On Mi, 25 Jan 2017, Dominique Pellé wrote: > Christian Brabandt wrote: > > > On Di, 24 Jan 2017, Christian Brabandt wrote: > > > >> On Di, 24 Jan 2017, Dominique Pellé wrote: > >> > How about an address sanitizer build in Travis to catch > >> > this kind of bugs earlier in CI? > >

Re: Patch 8.0.0224

Christian Brabandt wrote: > On Di, 24 Jan 2017, Christian Brabandt wrote: > >> On Di, 24 Jan 2017, Dominique Pellé wrote: >> > How about an address sanitizer build in Travis to catch >> > this kind of bugs earlier in CI? > > Here is a patch. > > Sample logfiles here: >

Re: Patch 8.0.0224

On Di, 24 Jan 2017, Christian Brabandt wrote: > On Di, 24 Jan 2017, Dominique Pellé wrote: > > How about an address sanitizer build in Travis to catch > > this kind of bugs earlier in CI? Here is a patch. Sample logfiles here: https://travis-ci.org/chrisbra/vim/builds/194982196 This was with

Re: Patch 8.0.0224

I wrote: > Dominique Pellé wrote: > > > Bram Moolenaar <b...@moolenaar.net> wrote: > > > > > Patch 8.0.0224 > > > Problem:When 'fileformats' is changed in a BufReadPre auto command, it > > > does not take effect in readfile(

Re: Patch 8.0.0224

Dominique Pellé wrote: > Bram Moolenaar <b...@moolenaar.net> wrote: > > > Patch 8.0.0224 > > Problem:When 'fileformats' is changed in a BufReadPre auto command, it > > does not take effect in readfile(). (Gary Johnson) > > Solution: Ch

Re: Patch 8.0.0224

Christian Brabandt wrote: > > Hi Bram! > > > > On Mo, 23 Jan 2017, Bram Moolenaar wrote: > > > > > + func Test_fileformat_autocommand() > > > + let filecnt=['', 'foobar', 'eins', '', 'zwei', 'drei', 'vier', > > > 'fünf', ''] > > > > That looks wrong. The first five items should have

Re: Patch 8.0.0224

> Hi Bram! > > On Mo, 23 Jan 2017, Bram Moolenaar wrote: > > > + func Test_fileformat_autocommand() > > + let filecnt=['', 'foobar', 'eins', '', 'zwei', 'drei', 'vier', 'fünf', > > ''] > > That looks wrong. The first five items should have an explicit CR '^M' > inside it. Did this test

Re: Patch 8.0.0224

Hi Dominique! On Di, 24 Jan 2017, Dominique Pellé wrote: > > Running tests with vim-8.0.225 built with asan, I see the > > following crash (head-buffer-overflow). Since I see fileio.c > > in the stack, I assume that the bug is caused by patch 8.0.224: Could it be, that this happens because of

Re: Patch 8.0.0224

Hi Bram! On Mo, 23 Jan 2017, Bram Moolenaar wrote: > + func Test_fileformat_autocommand() > + let filecnt=['', 'foobar', 'eins', '', 'zwei', 'drei', 'vier', 'fünf', > ''] That looks wrong. The first five items should have an explicit CR '^M' inside it. Did this test actually fail before

Re: Patch 8.0.0224

Dominique Pellé <dominique.pe...@gmail.com> wrote: > Bram Moolenaar <b...@moolenaar.net> wrote: > >> Patch 8.0.0224 >> Problem:When 'fileformats' is changed in a BufReadPre auto command, it >> does not take effect in readfile(). (Gary Joh

Re: Patch 8.0.0224

Bram Moolenaar <b...@moolenaar.net> wrote: > Patch 8.0.0224 > Problem:When 'fileformats' is changed in a BufReadPre auto command, it > does not take effect in readfile(). (Gary Johnson) > Solution: Check the value of 'fileformats' after execu

Patch 8.0.0224

Patch 8.0.0224 Problem:When 'fileformats' is changed in a BufReadPre auto command, it does not take effect in readfile(). (Gary Johnson) Solution: Check the value of 'fileformats' after executing auto commands. (Christian Brabandt) Files: src/fileio.c, src