Re: [virt-tools-list] Virt-Manager writing IPv6 configuration to xml

On 10/18/2017 10:42 AM, Marc Haber wrote: > Hi, > > when I use debian sid's virt-manager 1.4.2 to connect to debian sid's > libvir 3.8.0, create a VLAN interface there, explicitly saying "no > configuration" in the IPv6 tab of the configuration, I end up with the > following XML: > > > >

Re: [virt-tools-list] [virt-manager PATCH 2/2] diskbackend: get a proper size of existing block device while cloning

On 10/03/2017 11:09 AM, Pavel Hrdina wrote: > We cannot use os.statvfs() if the clone disk is a block device because > it gets stats about filesystem which in this case is "devtmpfs" mounted > as "/dev". > > As a workaround we can seek to the end of the block device to get > the actual size. > >

Re: [virt-tools-list] [PATCH] virtinst: ignore comments in keymap conf files

On 10/11/2017 05:13 PM, Jim Fehlig wrote: > On a host system with keyboard configured to en-US, it was noticed > that virt-install created install XML with keymap='de'. The host > system did not have /etc/vconsole.conf, so /etc/sysconfig/keyboard > was the next file to check, which contained the

Re: [virt-tools-list] scsi controller issue in 'customize before install'

On 10/12/2017 04:58 AM, Lin Ma wrote: > Hi list, >   > I have a question about scsi controller while I create vm. >   > For a existed vm, When user changed a virtual disk's bus type to scsi In > VM details page, > Then click 'apply' button, If this vm's configuration doesn't have any > scsi

Re: [virt-tools-list] [virt-manager PATCH 1/2] diskbackend: convert to long the calculated size

On 10/03/2017 11:09 AM, Pavel Hrdina wrote: > If we convert to long the disk size, it may end up "0". The size is > in GiB so it can be "0.1". > > Introduced by commit . > > Signed-off-by: Pavel Hrdina > --- > virtinst/diskbackend.py | 7 +++ > 1 file changed, 3

Re: [virt-tools-list] [virt-manager PATCH] pycodestyle: fix all E125 warnings

On 09/20/2017 04:06 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > >Fix all E125: > Continuation line with same indent as next logical line > >Also remove ignore options of E125 > > Signed-off-by: Chen Hanxiao ACK Thanks, Cole

Re: [virt-tools-list] [PATCH 2/2] virtinst: Use isoinfo to extract files from ISOs

On 11/08/2017 01:23 AM, Andrew Wong wrote: > --- > virtinst/urlfetcher.py | 38 -- > 1 file changed, 32 insertions(+), 6 deletions(-) > Nice work! Seems to work in my minimal testing. Some comments below. > diff --git a/virtinst/urlfetcher.py

Re: [virt-tools-list] [PATCH 1/2] virtinst: Fix _URLFetcher for reading files

On 11/08/2017 01:23 AM, Andrew Wong wrote: > _grabber() is used for both binary and text files. > --- > virtinst/urlfetcher.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virtinst/urlfetcher.py b/virtinst/urlfetcher.py > index 5dae424c..1288668a 100644 > ---

Re: [virt-tools-list] [virt-manager PATCH 7/7] scsi: Add controller index option and virtio-scsi bus option

On 11/06/2017 07:52 AM, Lin Ma wrote: > When we change disk bus to 'scsi' or add scsi disks, virt-manager relies > on libvirt's rules to create addresses. Sometimes it works, sometimes not, > Espectially in multiple scsi controllers case, we can not exactly control > which virtual disks attach to

Re: [virt-tools-list] 答复： Re: [PATCH] addhardware: Hide IDE while adding controller for q35-based machinetypes

On 11/21/2017 10:44 PM, Lin Ma wrote: > > >>>> Cole Robinson <crobi...@redhat.com> 2017/11/22 星期三 上午 6:16 >>> >>On 11/07/2017 05:34 AM, Lin Ma wrote: >>> Signed-off-by: Lin Ma <l...@suse.com> >>> --- >>>  virtManager/addhar

Re: [virt-tools-list] 答复： Re: [virt-manager PATCH 3/7] details: Show attached disk information in scsi controller page

On 11/22/2017 07:40 AM, Lin Ma wrote: > > >>>> Cole Robinson <crobi...@redhat.com> 2017/11/22 星期三 上午 6:28 >>> >>On 11/06/2017 07:52 AM, Lin Ma wrote: >>> It helps users to recognize controllers <-> disks mapping relationship. >>

Re: [virt-tools-list] [virt-manager PATCH 4/7] addhardware: Correctly handle 7 devices per narrow virtio-scsi controller

ive devices when calculating disk controller usage so this fix isn't correct. But I've pushed a patch now that fixes the calculating logic to handle duplicate targets commit ddcf22bad2e679e076d10e8745d022bb726fa013 (HEAD -> master) Author: Cole Robinson <crobi...@redhat.com> Date: Wed Nov 22

Re: [virt-tools-list] [virt-manager PATCH 5/7] addhardware: Correctly calculate virtio-scsi controller index

On 11/06/2017 07:52 AM, Lin Ma wrote: > Because sata, usb and scsi use same device prefix: sd*, They will be > included into occupied list while we add virtio-scsi disks, This is > wrong and may cause adding additional virtio-scsi controller. > > How to reproduce: > 1. fresh install a qemu guest.

Re: [virt-tools-list] [virt-bootstrap] [PATCH 1/3] utils: Add is_installed function

On 11/21/2017 05:37 AM, Cedric Bosdonnat wrote: > On Wed, 2017-11-01 at 00:19 +, Radostin Stoyanov wrote: >> Add utility function to check whether an executable is available in >> the PATH env variable. >> --- >> src/virtBootstrap/utils.py | 10 ++ >> 1 file changed, 10 insertions(+)

Re: [virt-tools-list] [virt-manager PATCH 2/7] details: Show controller description + index

On 11/06/2017 07:52 AM, Lin Ma wrote: > This patch and future patches can help users to better recognize which > disks connect to which scsi controllers. > > Signed-off-by: Lin Ma > --- > virtManager/details.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [virt-tools-list] [virt-manager PATCH 6/7] testdriver: add missing addrStr for scsi disk

On 11/06/2017 07:52 AM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > tests/testdriver.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/testdriver.xml b/tests/testdriver.xml > index 9ac074ed..d81dfcfc 100644 > --- a/tests/testdriver.xml > +++

Re: [virt-tools-list] [virt-manager PATCH 1/7] details: Disallow removing the scsi controller if disks attached to it

On 11/06/2017 07:52 AM, Lin Ma wrote: > Through virt-manager, After we removed a virtio-scsi controller which > virtual disks still attach to it, Libvirt will add a LSI scsi controller > for this guest automatically and trigger a lifecycle event, virt-manager > updates and shows this new scsi

Re: [virt-tools-list] [PATCH] addhardware: Hide IDE while adding controller for q35-based machinetypes

On 11/07/2017 05:34 AM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > virtManager/addhardware.py | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/virtManager/addhardware.py b/virtManager/addhardware.py > index cd82cd3e..fb111344 100644 > ---

Re: [virt-tools-list] [virt-manager PATCH 3/7] details: Show attached disk information in scsi controller page

On 11/06/2017 07:52 AM, Lin Ma wrote: > It helps users to recognize controllers <-> disks mapping relationship. > > Signed-off-by: Lin Ma > --- > ui/details.ui | 48 > virtManager/details.py | 25 -

Re: [virt-tools-list] Typo in Manpage

On 10/23/2017 08:40 PM, David Rabel wrote: > Hi, > > there was a typo in the virt-convert man page. Please find attached a patch. > Thank you, I've pushed your patch now - Cole ___ virt-tools-list mailing list virt-tools-list@redhat.com

Re: [virt-tools-list] [virt-manager PATCH 1/3] testdriver: Add vhostuser example

On 10/20/2017 11:08 AM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > tests/testdriver.xml | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/tests/testdriver.xml b/tests/testdriver.xml > index 5b0a277..9ac074e 100644 > --- a/tests/testdriver.xml > +++

Re: [virt-tools-list] [virt-manager PATCH 2/3] tests: Add test for vhostuser

On 10/20/2017 11:08 AM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > tests/xmlparse-xml/add-devices-out.xml | 5 + > tests/xmlparse.py | 12 > 2 files changed, 17 insertions(+) > > diff --git a/tests/xmlparse-xml/add-devices-out.xml >

Re: [virt-tools-list] [virt-manager PATCH 3/3] virt-manager: Add UI support to add/configure vhostuser interface

On 10/20/2017 11:08 AM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > ui/netlist.ui | 97 > ++ > virtManager/details.py | 9 - > virtManager/domain.py | 8 - > virtManager/netlist.py | 67

Re: [virt-tools-list] [virt-manager PATCH] pycodestyle: fix all E125 warnings

On 10/21/2017 02:30 AM, Chen Hanxiao wrote: > At 2017-10-02 17:58:58, "Pavel Hrdina" wrote: > >> On Wed, Sep 20, 2017 at 04:06:49PM +0800, Chen Hanxiao wrote: >>> From: Chen Hanxiao >>> > >>> # Define the change >> >> This change will fix the

Re: [virt-tools-list] [virt-manager PATCH 0/2] Fix some pylint

On 10/21/2017 02:49 AM, Chen Hanxiao wrote: > > Chen Hanxiao (2): > pylint: Replace deprecated assertEquals with assertEqual ACK, curious that my pylint version is showing it though. pylint is inconsistent across versions though... > pylint: change import order This one confuses me, since

Re: [virt-tools-list] [PATCH] addhardware: Fix typo in _set_disk_controller

On 11/24/2017 07:16 AM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > virtManager/addhardware.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virtManager/addhardware.py b/virtManager/addhardware.py > index e563fe6..8f39ee5 100644 > ---

Re: [virt-tools-list] [PATCH] addhardware: Remove IDE from list while adding controllers

On 11/22/2017 09:58 PM, Lin Ma wrote: > Libvirt only supports built-in IDE controller so far, There is no > any case that needs us manually add an IDE controller, So remove > it from the controller list. > > Signed-off-by: Lin Ma > --- > virtManager/addhardware.py | 3 ++- > 1

Re: [virt-tools-list] [PATCH virt-install] virtio-scsi by default on power

On 11/29/2017 04:41 PM, Scott Garfinkle wrote: > Power architecture guests should default to virtio-scsi rather than > spapr-scsi > > Signed-off-by: Scott Garfinkle > --- > virtinst/guest.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [virt-tools-list] Eideticom NVMe devices not showing in virt-manager

On 05/15/2018 08:53 AM, Stephen Bates wrote: > Hi All > > We are testing our NVMe devices in virtualized environments and noticed that > the vendor name and device id (as decoded by pci-ids) is not showing up in > virt-manager in the add hardware list. We are running Bionic Beaver on the >

Re: [virt-tools-list] Eideticom NVMe devices not showing in virt-manager

On 05/16/2018 12:42 PM, Stephen Bates wrote: > Hi Cole > > Thanks for the response! > >>virt-manager/libvirt asks libpciaccess for this info, > > Do you have a pointer to the code for this? > libvirt.git src/node_device/node_device_udev.c, search for pci_get_strings, but you'll probably

Re: [virt-tools-list] [PATCH 0/4] virtinst: Update SUSE media detection

On 05/07/2018 05:39 PM, Charles Arnold wrote: > Fixes and adjustments for detecting SUSE media. > > Charles Arnold (4): > Create shared function _split_version from _split_rhel_version > Use split_version method to get version and update > Use wildcard to detect 'openSUSE Leap'. > Make

Re: [virt-tools-list] [PATCH virt-manager] cli: Add --network mtu.size=X option

On 06/05/2018 04:56 PM, Anya Harter wrote: > This maps to interface XML like: > > > > > > Signed-off-by: Anya Harter Thanks for the patch! One comment in line below > --- > tests/cli-test-xml/compare/virt-install-many-devices.xml | 1 + > tests/clitest.py

Re: [virt-tools-list] [PATCH] tpm: allow hotplug operation so error is reported by libvirt

On 06/12/2018 08:52 AM, Stefan Berger wrote: > Perform a hotplug operation so that we get the error notification > about unsupported TPM hotplug operation and we can alert the user > that the change will only take effect upon domain shutdown. > > Signed-off-by: Stefan Berger > --- >

Re: [virt-tools-list] [PATCH virt-manager] cli: Add --disk geometry attribute options

On 06/07/2018 11:29 AM, Anya Harter wrote: > Attribute options are: > - geometry.cyls=W > - geometry.heads=X > - geometry.secs=Y > - geometry.trans=Z > > This maps to disk XML like: > > > > > > Signed-off-by: Anya Harter Thanks, pushed now - Cole

Re: [virt-tools-list] [PATCH virt-manager] cli: add codec support

Thanks, I pushed with the following changes: - Add --sound to the title to make it more clear On 06/11/2018 11:48 AM, Anya Harter wrote: > Add codec support to virt-install so that it can accommodate > multiple instances of codec configuration. > > The commandline argument: > > --sound

Re: [virt-tools-list] [PATCH v2 6/6] details: show TPM device model and allow updating it

On 06/11/2018 12:00 PM, Stefan Berger wrote: > On 06/11/2018 11:54 AM, Cole Robinson wrote: >> On 06/08/2018 05:42 PM, Stefan Berger wrote: >>> Show the TPM device model and allow updating it. If a TPM 1.2 has been >>> chosen, we only allow the TIS interface to be sel

Re: [virt-tools-list] [PATCH 1/3] virtinst: allow adding host network devices to LXC containers

On 06/15/2018 05:29 AM, Lubomir Rintel wrote: > Signed-off-by: Lubomir Rintel > --- > man/virt-install.pod | 4 > tests/xmlparse-xml/change-hostdevs-in.xml | 5 + > tests/xmlparse-xml/change-hostdevs-out.xml | 5 + > tests/xmlparse.py

Re: [virt-tools-list] [Patch] Missing translation in de.po for the "Kernel Options:" string

On 05/31/2018 01:39 PM, Charles Arnold wrote: >>From 56a94827f4f82b35646063dd68ec74cce3266e80 Mon Sep 17 00:00:00 2001 > From: Charles Arnold > Date: Thu, 31 May 2018 11:25:46 -0600 > Subject: [PATCH 1/1] Missing translation for the "Kernel Options:" string > > --- > po/de.po | 2 +- > 1 file

Re: [virt-tools-list] [virt-manager PATCH] numatune: fix validate_cpuset regexp

On 05/22/2018 01:07 PM, Pavel Hrdina wrote: > Character '-' needs to be escaped in a set of characters. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1566818 > > Signed-off-by: Pavel Hrdina > --- > > Pushed under trivial rule. > > virtinst/domain/numatune.py | 2 +- > 1 file

Re: [virt-tools-list] [virt-manager] [PATCH 0/2] Integrate codespell_dict

On 05/21/2018 03:42 PM, Radostin Stoyanov wrote: > This patch series extends the pull request from Stefan [1] by fixing > a few more spelling mistakes in the comments, and integrate codespell > to setup.py > > [1] https://github.com/virt-manager/virt-manager/pull/31 > > Radostin Stoyanov (1): >

Re: [virt-tools-list] [PATCH v2 virt-manager] cli: Add --network mtu.size=X option

One minor bit: when adding a v2, typical format is [PATCH virt-manager v2] ... Doesn't impact the patch content though. On 06/06/2018 10:07 AM, Anya Harter wrote: > This maps to interface XML like: > > > > > > Signed-off-by: Anya Harter > --- >

Re: [virt-tools-list] [virt-manager] [PATCH 1/4] libvirtenummap: Map state vals of agent event to libvirt enum names

On 06/24/2018 11:46 PM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > virtManager/libvirtenummap.py | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/virtManager/libvirtenummap.py b/virtManager/libvirtenummap.py > index eaad0374..71e4a5eb 100644 > ---

Re: [virt-tools-list] [virt-manager] [PATCH 3/4] ui: details: Add ui for showing the state of channel in next patch

On 06/24/2018 11:46 PM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > ui/details.ui | 25 + > virtManager/details.py | 1 + > 2 files changed, 26 insertions(+) > > diff --git a/ui/details.ui b/ui/details.ui > index 3018354b..13b71aeb 100644 > ---

Re: [virt-tools-list] [virt-manager] [PATCH 2/4] Output the qemu guest agent lifecycle events in debug mode

On 06/24/2018 11:46 PM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > virtManager/connection.py | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/virtManager/connection.py b/virtManager/connection.py > index 76e78c49..0b83bccf 100644 > --- a/virtManager/connection.py > +++

Re: [virt-tools-list] [virt-manager PATCH 2/2] cli: stop forking into the background

On 05/01/2018 04:01 AM, Daniel P. Berrangé wrote: > On Mon, Apr 30, 2018 at 12:47:38PM -0400, Cole Robinson wrote: >> On 04/30/2018 12:19 PM, Daniel P. Berrangé wrote: >>> On Mon, Apr 30, 2018 at 12:12:08PM -0400, Cole Robinson wrote: >>>> On 04/30/2018 08:3

Re: [virt-tools-list] [virt-manager PATCH 2/2] cli: stop forking into the background

On 05/01/2018 09:23 AM, Daniel P. Berrangé wrote: > On Tue, May 01, 2018 at 09:05:49AM -0400, Cole Robinson wrote: >> On 05/01/2018 04:01 AM, Daniel P. Berrangé wrote: >>> On Mon, Apr 30, 2018 at 12:47:38PM -0400, Cole Robinson wrote: >>>> On 04/30/2018 12:1

Re: [virt-tools-list] [virt-manager PATCH v4] Redesign OS distro selection UI to be faster to use

On 05/01/2018 07:51 AM, Daniel P. Berrangé wrote: > The current OS distro selection UI is fairly cumbersome to use. First > you need to decide on a variant, then decide a distro and then look for > the version you want. The list is filtered by default so only a subset > of OS are displayed. So for

[virt-tools-list] dropping some uncommon features from virt-manager/virt-install

Hi all, I'd like to drop some uncommonly used features from virt-manager/virt-install. Comments welcome * non-virDomainOpenConsole serial console in virtManager/serialcon.py. qemu, libxl, bhyve, lxc all support this API, qemu since libvirt 0.8.6 in Nov 2010. Directly connecting to /dev/ptsX only

Re: [virt-tools-list] [PATCH] Chagne most URIs to use https:// instead of http://

On 04/30/2018 08:56 AM, Daniel P. Berrangé wrote: > All URLs were checked to see if they supported https://, those which did > were converted. > > Signed-off-by: Daniel P. Berrangé > --- > HACKING.md | 4 +- > README.md| 6

Re: [virt-tools-list] [virt-manager PATCH] git: add a git publish configuration file

On 04/24/2018 02:11 PM, Daniel P. Berrangé wrote: > Provide a config file for git-publish that sets the right mailing list > and patch subject prefix. > > Signed-off-by: Daniel P. Berrangé > --- > .gitpublish | 4 > 1 file changed, 4 insertions(+) > create mode 100644

Re: [virt-tools-list] [virt-manager PATCH 2/2] cli: stop forking into the background

On 04/30/2018 08:33 AM, Daniel P. Berrangé wrote: > The behaviour whereby virt-manager forks into the background was added > way back in: > > commit 99c92b9471a6a55859307071aa4a0e712991f158 > Author: Daniel P. Berrange > Date: Mon Sep 10 20:10:20 2007 -0400 > >

Re: [virt-tools-list] [virt-manager PATCH 1/2] cli: remove unused --spice-disable-auto-usbredir arg

On 04/30/2018 08:33 AM, Daniel P. Berrangé wrote: > This functionality was removed in: > > commit c9b2ec163f15f41fe5010b7b1c215f6c204d93a6 > Author: Cole Robinson <crobi...@redhat.com> > Date: Fri Mar 16 14:38:22 2018 -0400 > > preferences: Add UI for di

Re: [virt-tools-list] [virt-manager PATCH 2/2] cli: stop forking into the background

On 04/30/2018 12:19 PM, Daniel P. Berrangé wrote: > On Mon, Apr 30, 2018 at 12:12:08PM -0400, Cole Robinson wrote: >> On 04/30/2018 08:33 AM, Daniel P. Berrangé wrote: >>> The behaviour whereby virt-manager forks into the background was added >>> wa

Re: [virt-tools-list] [virt-manager PATCH] network: Set bridge name to None instead of blank

On 10/19/2017 04:56 AM, Lin Ma wrote: > Trigger libvirt error if user leaves 'net-bridge-name' GtkEntry > blank when specifying shared device name. > > Signed-off-by: Lin Ma > --- > virtManager/netlist.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [virt-tools-list] [virt-manager] [PATCH 0/2] Fix typo and redundant assignment

On 10/26/2017 01:00 PM, Radostin Stoyanov wrote: > Radostin Stoyanov (2): > systray: Remove redundant variable assignment > news: Fix typo > > NEWS.md| 2 +- > virtManager/systray.py | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > Thanks, pushed now - Cole

Re: [virt-tools-list] [PATCH 1/1] virtinst: Use isoinfo to extract files from ISOs and block devices

On 01/01/2018 07:41 AM, Andrew Wong wrote: > Happy new year, everyone! > > Any update in getting this patch in? > > Thanks! > Andrew Finally finished setting up a local iso test suite and gave this patch a spin with no issues, so I've pushed it now. Thanks Andrew! Sorry for the delay - Cole

Re: [virt-tools-list] [virt-manager PATCH] cli: append "--attach" to virt-viewer if graphics has listen type none

On 01/05/2018 03:26 AM, Pavel Hrdina wrote: > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1527834 > > Signed-off-by: Pavel Hrdina ACK - Cole ___ virt-tools-list mailing list virt-tools-list@redhat.com

Re: [virt-tools-list] [virt-manager][PATCH v2 0/3] OS container wizard improvements

On 12/19/2017 11:32 AM, Cédric Bosdonnat wrote: > Hey there! > > Diff to v1: > > * removed alignment commit > * changed the URL placeholder into a tooltip > > Cédric Bosdonnat (3): > Improve container image url examples > oscontainer: ask root password in the wizard > Unify

Re: [virt-tools-list] [PATCH v2 0/6] some scsi improvement and bugfixes

Thanks, I've pushed these patches now with only a minor label spacing fix in patch 4. Sorry for the massive review delay :/ - Cole On 11/23/2017 04:32 AM, Lin Ma wrote: > v1 -> v2: > * Remove some patches from the original patches: > Remove #2, #5, #6 due to they were merged. > Remove #4

Re: [virt-tools-list] [PATCH] virtinst: Add NUMA distance support

On 01/22/2018 07:36 AM, menno.lage...@oracle.com wrote: > From: Menno Lageman > Nice patch! > Now that libvirt has support for administration of distances between NUMA > cells > it would be nice to be able to set those with virt-install directly instead of > having

Re: [virt-tools-list] virt-install should copy libvirt storage pool auth element and all source hosts to domain xml

On 01/26/2018 05:29 AM, Rauno Väli wrote: > virt-install should copy libvirt storage pool auth element and all > source hosts to domain xml > Thanks for the patch! Can you give me an example pool config and matching disk config it generates? So I can add a test case for this patch. Changing the

Re: [virt-tools-list] [PATCH] virtinst: Add NUMA distance support

e following XML: Signed-off-by: Menno Lageman <menno.lage...@oracle.com> (crobinso: rework cli format, drop some validation, drop man changes) Signed-off-by: Cole Robinson <crobi...@redhat.com> --- .../compare/virt-install-sin

Re: [virt-tools-list] virt-install should copy libvirt storage pool auth element and all source hosts to domain xml

On 01/29/2018 01:37 AM, Rauno Väli wrote: > libvirt pool dumpxml: > >   rbd.test >   57e55e10-63c9-4166-861c-f330d868260c >   36792725520384 >   760411510361 >   34510461812736 >   >     >     >     >     rbd.test >     >       >     >   > > > with this patch i get correct disk

Re: [virt-tools-list] [PATCH] virtinst: Add NUMA distance support

On 01/29/2018 06:23 AM, Menno Lageman wrote: > On 26-01-18 20:50, Cole Robinson wrote: >> I've attached an updated patch that applies to master. Has the updated >> cli format, drops the validation stuff, and the man page bits too since >> I intended that to just be an example

Re: [virt-tools-list] startup_policy not documented

On 02/05/2018 06:43 PM, Digimer wrote: > Hi all, > > The 'virt-install' man page says; > > > STORAGE OPTIONS > > ... > > startup_policy >It defines what to do with the disk if the source file >is not accessible. See possible values in >

[virt-tools-list] ANNOUNCE: virt-manager 1.5.0 released

I'm happy to announce the release of virt-manager 1.5.0! virt-manager is a desktop application for managing KVM, Xen, and LXC virtualization via libvirt. The release can be downloaded from: http://virt-manager.org/download/ This release includes: - python3 prep work (Radostin Stoyanov, Cole

[virt-tools-list] virt-manager py3 port now in master

Hi all, I've merged the python3 port into virt-manager git master now. The next major release will be 2.0 and contain this work. python2 compat is not maintained, it's strictly python3. I haven't figured out a minimum supported python3 version yet The url, ui, initrd inject, and standard test

Re: [virt-tools-list] [virt-manager] [PATCH] Italian translation update

ME DESCRIPTIVE TITLE. > # Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER > # This file is distributed under the same license as the PACKAGE package. > # > # Translators: > -# Cole Robinson <crobi...@redhat.com>, 2011 > -# gscrivano <gscriv...@gmail.com>, 2013-2014 >

Re: [virt-tools-list] [PATCH] virtinst: add feature support

On 02/20/2018 02:30 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The feature allows a guest to provide debug details when > producing dump. It's useful in particular for Linux guests with KASLR > enabled, as otherwise the dump are difficult

Re: [virt-tools-list] [PATCH] virtinst: add feature support

On 02/21/2018 11:31 AM, Marc-André Lureau wrote: > Hi > > On Wed, Feb 21, 2018 at 4:08 PM, Cole Robinson <crobi...@redhat.com> wrote: >> On 02/20/2018 02:30 PM, marcandre.lur...@redhat.com wrote: >>> From: Marc-André Lureau <marcandre.lur...@redhat.com>

Re: [virt-tools-list] [PATCH v2 0/6] virtinst: add feature support

On 02/22/2018 06:34 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > The feature allows a guest to provide debug details when > producing dump. It's useful in particular for Linux guests with KASLR > enabled, as otherwise the dump are

Re: [virt-tools-list] Crash in libxml python callback running tests

On 02/23/2018 08:48 AM, Daniel P. Berrangé wrote: > I built libvirt using --prefix=/usr/local, and then did *not* run > 'make install'. > > I then tried to run virt-manager tests > > ../libvirt/run python3 setup.py test > > It crashed & burned. Initially the problem is that the >

Re: [virt-tools-list] [PATCH 1/1] virtinst: Use isoinfo to extract files from ISOs and block devices

On 01/01/2018 07:41 AM, Andrew Wong wrote: > Happy new year, everyone! > > Any update in getting this patch in? > Sorry, I'm behind on reviews. I'll catch up by the end of the week. Thanks, Cole ___ virt-tools-list mailing list

Re: [virt-tools-list] [virt-manager][PATCH] py3: store exception variables for use outside except

On 12/20/2017 12:14 PM, Cédric Bosdonnat wrote: > In python3 exceptions aren't defined outside the except block. Leading > to 'UnboundLocalError: local variable 'e' referenced before assignment' > errors. > > To work around this, store the local variable into one that will have a > longer life. >

Re: [virt-tools-list] patch to fix small typo

On 12/13/2017 10:24 AM, Michal Privoznik wrote: > On 12/11/2017 07:00 PM, Anthony Serna wrote: >> Patch attached. >> >> Just a small thing I noticed when spinning up an LXC container. > > Hey, > > welcome to the list. Just a couple of hints for your patch: > >> >> >> 0001-strings-fix-typo.patch

Re: [virt-tools-list] virt-manager running on python3

On 12/07/2017 03:24 PM, Daniel P. Berrange wrote: > On Thu, Dec 07, 2017 at 09:00:30AM -0700, Charles Arnold wrote: >> There has been some recent work done for python3 support in virt-manager. >> Are there plans to move virt-manager entirely to python3? >> There is more work that could be done for

Re: [virt-tools-list] [PATCH] python3: fix bytes/string mess in serial console

On 12/13/2017 06:08 AM, Cédric Bosdonnat wrote: > Add a few encode() and decode() to convert between libvirt stream > functions expecting bytes arrays and Vte callbacks providing strings. > --- > virtManager/serialcon.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff

Re: [virt-tools-list] [virt-manager PATCH 1/5] details: Show attached disk info in sata, ide and floppy controller page

On 07/18/2018 06:00 AM, Lin Ma wrote: Reflect controllers <-> disks mapping relationship for not only scsi, But other storage controllers. As a bonus, These controllers are not allowed to be removed if there are disks attached to them. Signed-off-by: Lin Ma --- virtManager/details.py | 2 +-

Re: [virt-tools-list] [virt-manager PATCH 3/5] details: Disallow removing virtio-serial controller if devices attach to it

On 07/18/2018 06:00 AM, Lin Ma wrote: Signed-off-by: Lin Ma --- virtManager/details.py | 13 + 1 file changed, 13 insertions(+) diff --git a/virtManager/details.py b/virtManager/details.py index e3edbe86..00e18949 100644 --- a/virtManager/details.py +++ b/virtManager/details.py

[virt-tools-list] [PATCH virt-viewer] spec: Remove outdated bits

Group, buildroot cleanup, and defattr are not needed on RHEL6 and later Signed-off-by: Cole Robinson --- mingw-virt-viewer.spec.in | 10 -- virt-viewer.spec.in | 2 -- 2 files changed, 12 deletions(-) diff --git a/mingw-virt-viewer.spec.in b/mingw-virt-viewer.spec.in index

Re: [virt-tools-list] [virt-manager PATCH 5/5] details: Set tooltip on config-remove while it's not available

break +if can_remove is False: +tooltip = _("Channels or Consoles are attaching to it") Same as above self.widget("config-remove").set_sensitive(can_remove) self.widget("config-remove").set_tooltip_text(tooltip) T

Re: [virt-tools-list] [virt-manager PATCH 4/5] details: Fix the tooltip error on config-remove

; Thanks for the bug report, but anytime you are duplicating the same line of code in 17 different places should be a hint that it can likely be centralized. I'm pushing this instead. Thanks, Cole commit 5212ab992e49faa4f8e9cdce0062d918f27e91e9 (HEAD -> master) Author: Cole Robinson Date:

Re: [virt-tools-list] Virt-manager cuts off bottom of vm console

On 08/01/2018 01:48 AM, Eric Fort wrote: I ssh into a physical machine running Ubuntu 18.04 to manage vm’s running under kvm. To access the console on these machines or to build new machines from an install iso I use the console of whichever vm I’m working with. Myself and my team find this

Re: [virt-tools-list] [virt-manager] [RFC] About showing domain interfaces's ip address in details page

On 08/06/2018 08:10 AM, Lin Ma wrote: Hi all, I want to write patches to show ip addresses in virt-manager, I post the idea here to get some suggestions and ideas. The below are my thoughts. I'd like to define a function in class vmmDomain in virtManager/domain.py. The function name is

Re: [virt-tools-list] how did you guys calculate cpu and memory consumtion in virt-mangaer

On 08/27/2018 08:14 AM, Bahram Aghaei wrote: Hello I was wonder how did you calculate cpu and memory consumption in virt-manager? is it by using virsh ? since it just gives actual memory and RSS. That would be nice you send me any documentation or any other typo of guide. It's basically a

Re: [virt-tools-list] [PATCH] details: ADD checkbox to plug/unplug network interface

On 08/17/2018 04:53 AM, Pavel Hrdina wrote: On Thu, Aug 16, 2018 at 05:30:31PM +0200, Simon Kobyda wrote: Hardware Details -> NIC of every VM should now contain checkbox for interface's link state. This checkbox edits domain's XML by changing . If XML doesn't contain this tag, virt manager

Re: [virt-tools-list] [PATCH 00/10] Improve and fix UI tests

On 09/01/2018 06:15 PM, Povilas Kanapickas wrote: The following patch series fixes a bunch of small issues in UI tests that made them a little more brittle than needed or possibly outright broken. I'm a new contributor, likely missed something and my environment is probably different than what

Re: [virt-tools-list] [PATCH 01/10] uitests: Improve error message caused by another virt-manager being open

our patches commit 40461c58efbdd3435102d299da025ecf46089c6a (HEAD -> master) Author: Cole Robinson Date: Tue Sep 4 12:36:50 2018 -0400 tests: uitests: Fail if virt-manager is already running Thanks, Cole ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [PATCH 03/10] uitests: Don't fail when running on older libvirt versions

83a9e613e9fa7d7c7d9ac9b227a8a535618cadb3 Author: Cole Robinson Date: Fri Aug 31 16:47:10 2018 -0400 tests: uitests: Fix breakage Signed-off-by: Povilas Kanapickas --- tests/uitests/addhardware.py | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tests/uitests/addhardware.py b/tests/uitests

Re: [virt-tools-list] [PATCH 03/10] uitests: Don't fail when running on older libvirt versions

On 09/04/2018 07:26 PM, Povilas Kanapickas wrote: On 04/09/2018 20:21, Cole Robinson wrote: On 09/01/2018 06:21 PM, Povilas Kanapickas wrote: Instead of completely failing test when older libvirt is used, we can verify the error message instead. Actually this is fixed in git already, I

Re: [virt-tools-list] [virt-manager PATCH 0/2] Add support for disk discard option disk detect zeroes option while adding disk

On 09/05/2018 04:15 AM, Lin Ma wrote: Lin Ma (2): addhardware: Add support for disk discard option addhardware: Add support for disk detect zeroes option virtManager/addhardware.py | 10 ++ 1 file changed, 10 insertions(+) Pushed with some minor whitespace changes, thanks

Re: [virt-tools-list] [virt-manager PATCH 0/2] show ip in details page of domain interface

a few things: tweak the UI, handle errors, cache results better, and open it up to work on more hypervisor drivers. Please give it a try and make sure it still meets your usecases: commit b4b7c7b5203dac9c5583b130bb8808d7a0b528fd (HEAD -> ip) Author: Cole Robinson Date: Tue Sep 4 19:02:40 2

Re: [virt-tools-list] [PATCH 0/2] Add support for disk discard and detect zeroes options

On 08/23/2018 07:35 PM, Povilas Kanapickas wrote: This patch series exposes the disk/driver/@discard and disk/driver/@detect_zeroes attributes which were previously missing. Povilas Kanapickas (2): details: Add support for disk discard option details: Add support for disk detect zeroes

Re: [virt-tools-list] [virt-manager PATCH 0/2] Add support for disk io mode option while adding disks

On 09/06/2018 03:49 AM, Lin Ma wrote: Lin Ma (2): addhardware: Use consistent combo init for disk io mode option addhardware: Add support for disk io mode option ui/addhardware.ui | 32 virtManager/addhardware.py | 12

Re: [virt-tools-list] [virt-manager PATCH 3/3] Try to get ip of vm's nic only when the vm is active

On 09/06/2018 03:46 AM, Lin Ma wrote: Signed-off-by: Lin Ma --- virtManager/details.py | 15 +-- virtManager/domain.py | 4 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/virtManager/details.py b/virtManager/details.py index 0d02805f..64bed185 100644 ---

Re: [virt-tools-list] [virt-manager] [PATCH v2 0/4] Track the state of virtio channels

On 07/04/2018 04:10 AM, Lin Ma wrote: > v1->v2: > * new patch 1/4 for adding callback parameter to _add_domain_xml_event. > * combine original patch 3/4 and patch 4/4 to new patch 4/4. > * avoid pylint warn. > * Register agent events through _add_domain_xml_event. > > Lin Ma (4): > connection:

Re: [virt-tools-list] [virt-manager] [PATCH 2/4] Output the qemu guest agent lifecycle events in debug mode

On 06/30/2018 01:41 AM, Lin Ma wrote: > > > On 06/27/2018 05:39 AM, Cole Robinson wrote: >> On 06/24/2018 11:46 PM, Lin Ma wrote: >>> Signed-off-by: Lin Ma >>> --- >>>   virtManager/connection.py | 10 ++ >>>   1 file changed

Re: [virt-tools-list] libvirt profiles (a.k.a. virtuned) design ideas draft

Nice work on the document! I'll duplicate the docs here and comment in-line, might help to get more eyeballs. On 06/20/2018 09:15 AM, Martin Kletzander wrote: > After some discussion with people from various management apps we > decided to try and create something that would help with common, >

Re: [virt-tools-list] [PATCH 3/3] Redesign OS distro selection UI to be faster to use

I pushed patch #1 and #2, thanks On 04/04/2018 09:35 AM, Daniel P. Berrangé wrote: > The current OS distro selection UI is fairly cumbersome to use. First > you need to decide on a variant, then decide a distro and then look for > the version you want. The list is filtered by default so only a

Re: [virt-tools-list] [PATCH] virtinst: Trivial spelling fix

On 04/03/2018 04:56 PM, Charles Arnold wrote: > Trivial spelling fix. > > Signed-off-by: Charles Arnold > > diff --git a/virtinst/guest.py b/virtinst/guest.py > index 563203b4..db354896 100644 > --- a/virtinst/guest.py > +++ b/virtinst/guest.py > @@ -870,7 +870,7 @@ class

<    10   11   12   13   14   15   16   17   18   19   >