Re: [virt-tools-list] libvirt ssh

On 04/04/2018 04:53 PM, Alberto Sosa wrote: > Hi! > My name is Alberto and I'm computer science student. I'm doing my final > degree project that consist on a web interface for vm management using > libvirt, python and flask. > I'm stuck on making connections via SSH: I tried to get username and

Re: [virt-tools-list] [virt-manager][PATCH] setup.py: Distribute virtinst/ subdirectories

On 04/11/2018 07:09 AM, Michal Privoznik wrote: > On 04/11/2018 12:43 PM, Radostin Stoyanov wrote: >> Hi Michal, >> >> This commit was also created as a pull request by @z3ntu on github >> https://github.com/virt-manager/virt-manager/pull/29 > > Ah, haven't noticed because we don't use github

Re: [virt-tools-list] [virt-manager] [PATCH] tests: uriparse: Test for @ symbol in username

On 04/18/2018 02:31 AM, Radostin Stoyanov wrote: > Add test case for URI that contains the @ symbol in username. > > Signed-off-by: Radostin Stoyanov > --- > tests/uriparse.py | 4 > 1 file changed, 4 insertions(+) > > diff --git a/tests/uriparse.py

Re: [virt-tools-list] [virt-manager] [PATCHv2] urlfetcher: Add support for FTP authentication

On 04/18/2018 09:23 AM, Radostin Stoyanov wrote: > From: Mark Hamzy > > If --location is an ftp url with a username and password > then virt-install fails to install with an error: > ERROR Error validating install location: Opening URL u failed: 530 Login > incorrect.. > --- >

Re: [virt-tools-list] [PATCH v2] CPU model capabilities vs domcapabilities

On 03/26/2018 05:08 PM, Charles Arnold wrote: > The issue is when the host has been updated with microcode for Spectre > but qemu has _not_ been updated. In this scenario (as an example), > 'virsh capabilities' shows the host cpu model as IvyBridge-IBRS, which is > correct. However, 'virsh

Re: [virt-tools-list] [PATCH] [RFC] CPU model capabilities vs domcapabilities

On 03/23/2018 04:35 PM, Charles Arnold wrote: > The issue is when the host has been updated with microcode for Spectre > but qemu has _not_ been updated. In this scenario (as an example), > 'virsh capabilities' shows the host cpu model as IvyBridge-IBRS, which is > correct. However, 'virsh

Re: [virt-tools-list] [PATCH v3 2/2] virtinst: compare host and domain cpu models

On 03/28/2018 03:45 PM, Charles Arnold wrote: > Lookup the domain capabilities CPU model and compare with > the host capabilities CPU model and if they are not equal > set the guest's CPU model to None. > > --- > virtinst/guest.py | 9 + > 1 file changed, 9 insertions(+) > > diff --git

Re: [virt-tools-list] [PATCH v3 1/2] virtinst: read CPU model from domain capabilities

On 03/28/2018 03:45 PM, Charles Arnold wrote: > Add functionality to acquire the CPU model from the > libvirt domain capabilities. This is used to compare > with the host CPU model. > > --- > virtinst/domcapabilities.py | 30 ++ > 1 file changed, 30 insertions(+) > >

Re: [virt-tools-list] Fw: [PATCH] support username and password in prepareLocation

On 04/01/2018 09:36 AM, Mark Hamzy wrote: > If --location is an ftp url with a username and password > then virt-install fails to install with an error: > ERROR Error validating install location: Opening URL u failed: 530 Login > incorrect.. > --- > virtinst/urlfetcher.py | 8 +++- > 1 file

Re: [virt-tools-list] Change UUID

On 03/19/2018 12:05 PM, Toan Pham wrote: > > > > > > Which management tool in particular, and which UUID ? > > The UUIDs present in pretty much all the libvirt XML schemas are > autofilled > with a random value when libvirt parsers it, if the mgmt tool hasn't > already >

Re: [virt-tools-list] [virt-manager PATCH] Allow installation of i686 guests on x86_64 machines

On 03/01/2018 03:52 AM, Martin Kletzander wrote: > Do that by changing the code that was disabling it into code that just warns > in > such case. > > Signed-off-by: Martin Kletzander > --- > virtManager/create.py | 10 -- > 1 file changed, 4 insertions(+), 6

Re: [virt-tools-list] [virt-manager] [PATCH 0/5] Use pylint/pycodestyle modules

On 03/02/2018 03:01 AM, Radostin Stoyanov wrote: > Radostin Stoyanov (5): > pylint: Use pylint.lint module > pylint: Silence inconsistent-return-statements > pylint: Resolve logging-not-lazy > pylint: Resolve consider-using-enumerate > pycodestyle: Use module instead of executable > >

Re: [virt-tools-list] [virt-manager] [PATCH] virtinst: progress: Simplify if-statement

On 03/02/2018 03:12 AM, Radostin Stoyanov wrote: > Signed-off-by: Radostin Stoyanov > --- > virtinst/progress.py | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/virtinst/progress.py b/virtinst/progress.py > index 29bff358..4284f854

Re: [virt-tools-list] [PATCH 0/2] Show IP address in virt-manager

On 03/02/2018 01:27 AM, Dylan Stephano-Shachter wrote: > I have added a feature to show a VM's first IP address next to the VM state > (Running, etc.). This feature can be toggled in the preferences menu and is > disabled by default. It uses the qemu-guest agent to query the IP address. > >

Re: [virt-tools-list] [virt-manager PATCH] Allow installation of i686 guests on x86_64 machines

On 03/03/2018 04:03 PM, Martin Kletzander wrote: > On Sat, Mar 03, 2018 at 03:53:59PM -0500, Cole Robinson wrote: >> On 03/01/2018 03:52 AM, Martin Kletzander wrote: >>> Do that by changing the code that was disabling it into code that >>> just warns in >>> such

Re: [virt-tools-list] PATCH: Allow using sysctl for some systems, starting with OpenBSD

CCing rjones since this is a virt-what patch but it's not obvious from the subject - Cole On 04/25/2018 10:45 AM, j...@jasper.la wrote: > Hi, > > OpenBSD lacks /proc, so some of the detection mechanisms in virt-what > don't work there. However sysctl is available and could be used instead > in

Re: [virt-tools-list] [virt-manager PATCH] virtinst: Remove only auto-generated channel source path

On 06/28/2018 10:58 AM, Pavel Hrdina wrote: > In attempt to fix https://bugzilla.redhat.com/show_bug.cgi?id=1270696 > this code was introduced but it removes the path for all channel > devices. We need to limit it only to the devices that have > auto-generated source path. > > Resolves:

Re: [virt-tools-list] Recommendation for improvement/feature request of virt-manager

On 10/03/2018 07:03 PM, sc...@mailbox.org wrote: Hello together, in first - thanks to all of you for your great work! I have just a small feature request for virt-manager: Unfortunately it is not possible yet to block guests public internet access in the guest machine settings (= NIC

Re: [virt-tools-list] virt-install: Add warn if 'single-use' options are defined multiple times?

On 10/04/2018 04:41 PM, Mark Kanda wrote: On 10/4/2018 11:55 AM, Cole Robinson wrote: On 10/04/2018 12:29 PM, Mark Kanda wrote: On 10/1/2018 12:16 PM, Cole Robinson wrote: On 09/14/2018 04:28 PM, Mark Kanda wrote: Hi all, I recently discovered, for 'single-use' command line options, virt

Re: [virt-tools-list] [libvirt] question about syntax of storage volume element

On 10/05/2018 05:41 PM, Jim Fehlig wrote: On 10/5/18 3:27 PM, Cole Robinson wrote: On 10/02/2018 01:09 PM, Jim Fehlig wrote: On 10/2/18 9:27 AM, Cole Robinson wrote: On 10/02/2018 10:53 AM, Jim Fehlig wrote: On 10/2/18 5:13 AM, Pavel Hrdina wrote: On Mon, Oct 01, 2018 at 02:28:09PM -0400

Re: [virt-tools-list] RFC: virt-manager: removing interface object UI

On 10/05/2018 11:13 AM, Laine Stump wrote: On 10/03/2018 04:23 PM, Cole Robinson wrote: Hi all, I'd like to remove the object UI from virt-manager. This is Edit->Connection Details->Interfaces, the bits that allow starting/stopping/deleting/creating host network interface configuration

Re: [virt-tools-list] [libvirt] question about syntax of storage volume element

On 10/02/2018 01:09 PM, Jim Fehlig wrote: On 10/2/18 9:27 AM, Cole Robinson wrote: On 10/02/2018 10:53 AM, Jim Fehlig wrote: On 10/2/18 5:13 AM, Pavel Hrdina wrote: On Mon, Oct 01, 2018 at 02:28:09PM -0400, Cole Robinson wrote: On 09/28/2018 12:54 AM, Jim Fehlig wrote: I've attempted to use

Re: [virt-tools-list] Recommendation for improvement/feature request of virt-manager

On 10/06/2018 03:44 PM, sc...@mailbox.org wrote: Hello Cole, thanks a lot for your kind reply! Let me try to answer your questions: Do you have in mind a specific libvirt/qemu feature that you want exposed, or are you asking for this kind of on/off switch to implemented lower in the stack?

Re: [virt-tools-list] [virt-manager PATCH] pylint: fix simplifiable-if-statement issue

On 10/10/2018 02:44 AM, Chen Hanxiao wrote: From: Chen Hanxiao pylint complain: The if statement can be replaced with 'var = bool(test)' Signed-off-by: Chen Hanxiao --- virtinst/guest.py | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/virtinst/guest.py

Re: [virt-tools-list] [virt-manager PATCH v2 0/3] Add SCSI persistent reservation support for LUN Passthrough

On 10/10/2018 05:50 AM, Lin Ma wrote: v2: * Only support pr managed mode in virt-manager, drop the unmanaged mode support. * Drop the help info in manpage. * make the name style match libvirt XML naming. Thank Michal and Cole for review and suggestions. Lin Ma (3): cli: disk: Add options to

Re: [virt-tools-list] [PATCH] Fix selection of network volumes

On 10/09/2018 04:30 PM, Jim Fehlig wrote: When creating a new VM and selecting a volume from a network-based storage pool such as rbd, the volume is not recognized as network-based and is treated as a volume from a directory storage pool. This patch adds a method to check if the volume's path

Re: [virt-tools-list] [PATCH] Fix selection of network volumes

On 10/12/2018 01:15 PM, Jim Fehlig wrote: On 10/12/18 9:57 AM, Cole Robinson wrote: On 10/09/2018 04:30 PM, Jim Fehlig wrote: When creating a new VM and selecting a volume from a network-based storage pool such as rbd, the volume is not recognized as network-based and is treated as a volume

Re: [virt-tools-list] RFC: virt-manager: removing interface object UI

On 10/03/2018 04:23 PM, Cole Robinson wrote: Hi all, I'd like to remove the object UI from virt-manager. This is Edit->Connection Details->Interfaces, the bits that allow starting/stopping/deleting/creating host network interface configurations like bridges, bonds, vlans, and etherne

Re: [virt-tools-list] [virt-manager PATCH 1/3] osdict: expand the "unknown" check for any distro

On 10/18/2018 07:43 AM, Fabiano Fidêncio wrote: Currently osinfo-db has "unknown" entries for fedora, opensuse and asianux. Considering this list may grow even more at some point, let's just make the check more generic and use it for all of them instead of keeping it for fedora only.

Re: [virt-tools-list] [virt-manager PATCH] util: Fix typo vpcu -> vcpu

On 10/22/2018 02:46 PM, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- man/virt-install.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/virt-install.pod b/man/virt-install.pod index 8cd56fe016b7..062c78523e4d 100644 --- a/man/virt-install.pod +++

Re: [virt-tools-list] How to: Unattended Windows installs in virt-install

-install, see: https://serverfault.com/questions/644437/unattended-installation-of-windows-server-2012-on-kvm FYI I fixed this issue upstream now: commit 41d0f8fdf1905612ef389cb7b58c5377394f855b (HEAD -> master, origin/master, origin/HEAD) Author: Cole Robinson Date: Sat Oct 13 10:23

Re: [virt-tools-list] [virt-manager] Improving snapshot support

On 10/24/2018 12:55 PM, Povilas Kanapickas wrote: Hey, I've been looking into supporting revert and delete operations for external snapshots [1] in libvirt and plan to do whatever it takes to land the feature. After these are done, there's nothing that prevents external snapshot support in

Re: [virt-tools-list] [PATCH 00/17] Make progressbar.py PEP8 compliant

On 10/25/2018 08:37 AM, Radostin Stoyanov wrote: Radostin Stoyanov (17): pylint: Don't exclude progress.py progress: Resolve W0201 progress: Resolve E302 progress: Resolve E221 progress: Resolve E701 progress: Resolve E261 progress: Resolve E722 progress: Resolve E265

Re: [virt-tools-list] virt-install: Add warn if 'single-use' options are defined multiple times?

On 10/04/2018 12:29 PM, Mark Kanda wrote: On 10/1/2018 12:16 PM, Cole Robinson wrote: On 09/14/2018 04:28 PM, Mark Kanda wrote: Hi all, I recently discovered, for 'single-use' command line options, virt-install silently ignores all but the last definition. For example, if the command line

[virt-tools-list] RFC: virt-manager: removing interface object UI

Hi all, I'd like to remove the object UI from virt-manager. This is Edit->Connection Details->Interfaces, the bits that allow starting/stopping/deleting/creating host network interface configurations like bridges, bonds, vlans, and ethernet/wifi configs https://imgur.com/a/iyYXawV

Re: [virt-tools-list] [ [PATCH 1/3] cli: disk: add pr.managed=, pr.type=, pr.path= and pr.mode= support

On 10/08/2018 10:46 PM, Lin Ma wrote: On 10/2/18 11:00 PM, Cole Robinson wrote: On 09/25/2018 05:12 AM, Lin Ma wrote: Enable the managed or unmanaged PR configuration to enable SCSI persistent reservation for LUN Passthrough. Signed-off-by: Lin Ma ---   man/virt-install.pod

Re: [virt-tools-list] [ [PATCH 1/3] cli: disk: add pr.managed=, pr.type=, pr.path= and pr.mode= support

On 09/25/2018 05:12 AM, Lin Ma wrote: Enable the managed or unmanaged PR configuration to enable SCSI persistent reservation for LUN Passthrough. Signed-off-by: Lin Ma --- man/virt-install.pod| 13 + .../compare/virt-install-many-devices.xml

Re: [virt-tools-list] Virt-manager: Restricted networks

On 10/02/2018 08:50 AM, Olivier Léobal wrote: Hello, 'Isolated' networks created in VMM (I’m running 1.4.3) still connect to the host (as gateway). Is it possible to avoid this? It is my understanding that QEMU provides a 'restrict' option for that, but I don't understand it well, and can’t

Re: [virt-tools-list] [ [PATCH 0/3] Add SCSI persistent reservation support for LUN Passthrough

On 09/26/2018 08:36 AM, Michal Privoznik wrote: On 09/25/2018 11:12 AM, Lin Ma wrote: Lin Ma (3): cli: disk: add pr.managed=, pr.type=, pr.path= and pr.mode= support details: Add disk pr.managed and pr.path options to support SCSI PR addhardware: Add disk pr.managed and pr.path options

Re: [virt-tools-list] [PATCH] cli: add memory backing access_mode & source_type

On 10/01/2018 02:53 PM, Marc-André Lureau wrote: Hi On Mon, Oct 1, 2018 at 9:20 PM Cole Robinson wrote: On 09/17/2018 06:59 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Allow to set some memory backing options, ex: --memorybacking access_mode=shared,source_type=anonymous

Re: [virt-tools-list] [virt-manager gui feature request] check box for "locked" memory backing

On 09/19/2018 05:57 AM, Joachim Wagner wrote: While various cli options for memory backing have been introduced in 2014, the virt-manager GUI doesn't offer any memory options other than current and maximum allocation under open -> view -> details -> memory. The "locked" memory backing option is

Re: [virt-tools-list] [libvirt] question about syntax of storage volume element

On 10/02/2018 10:53 AM, Jim Fehlig wrote: On 10/2/18 5:13 AM, Pavel Hrdina wrote: On Mon, Oct 01, 2018 at 02:28:09PM -0400, Cole Robinson wrote: On 09/28/2018 12:54 AM, Jim Fehlig wrote: I've attempted to use virt-manager to create a new VM that uses a volume from an rbd-based network pool

Re: [virt-tools-list] [virt-manager PATCH] osinfo: warn when using deprecated osinfo IDs

On 10/02/2018 07:53 AM, Pino Toscano wrote: At some point in the future it could be a good idea to drop the _aliases mapping altogether; it will be hard to do so, in case the users are not informed that they are using a deprecated ID. I had a similar thought just a few days ago!

Re: [virt-tools-list] [PATCH 0/2] Introduce new Stats class

On 10/05/2018 10:54 AM, Simon Kobyda wrote: New Stats Class reduces number of libvirt API calls we do. However each stats polling has legacy possibility which will be used when virConnectGetAllDomainStats is not supported by libvirt. https://bugzilla.redhat.com/show_bug.cgi?id=1264684 Simon

Re: [virt-tools-list] virt-install: Add warn if 'single-use' options are defined multiple times?

rom: Cole Robinson Date: Mon, 1 Oct 2018 13:14:43 -0400 Subject: [PATCH virt-manager] cli: Merge multiple instances of single use opts So --memory 123,maxmem=456 --memory 555 is equivalent to --memory 555,maxmem=45 Signed-off-by: Cole Robinson --- virt-install| 17 + virtin

Re: [virt-tools-list] [PATCH] cli: add memory backing access_mode & source_type

On 09/17/2018 06:59 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Allow to set some memory backing options, ex: --memorybacking access_mode=shared,source_type=anonymous Signed-off-by: Marc-André Lureau --- .../cli-test-xml/compare/virt-install-singleton-config-2.xml | 4

Re: [virt-tools-list] Nested virtualization

On 09/28/2018 12:34 PM, na...@secmail.pro wrote: Hello. Nested virtualization lags and it have many errors for me. I have a Host (L0) with libvirt(virt-manager) I have there a VM (L1) and I want to run in L1 a Virtual Box machine (L2). But I get errors while installing Windows in L2. Windows

Re: [virt-tools-list] [virt-bootstrap][PATCH] Don't allow overwriting of the root partition

gger.error("Unpack to root directory is not allowed") +sys.exit(1) elif not os.path.isdir(dest): # Show error if not directory logger.error("Destination path '%s' is not directory.", dest) sys.exit(1) Makes sense to me, rm has similar sa

Re: [virt-tools-list] [virt-manager] [PATCH 2/2] cli: Register parser for ParseCLICheck

On 12/24/2018 03:35 AM, Lin Ma wrote: The completion of --check subprops needs it work. Signed-off-by: Lin Ma --- virtinst/cli.py | 1 + 1 file changed, 1 insertion(+) diff --git a/virtinst/cli.py b/virtinst/cli.py index 3ba81861..2996dbc3 100644 --- a/virtinst/cli.py +++ b/virtinst/cli.py

Re: [virt-tools-list] [PATCH] .gitignore: Remove the outdated path info of bashcompletion files

On 12/21/2018 01:23 AM, Lin Ma wrote: Commit 73f07c5 generates the bashcompletion files in build folder, The '/data/bash-completion' no longer exists, So remove it in .gitignore. Signed-off-by: Lin Ma --- .gitignore | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitignore b/.gitignore

Re: [virt-tools-list] [PATCH v3 0/4] virt-manager: Add support for vsock sockets

On 12/14/2018 09:34 AM, Slavomir Kaslev wrote: This patchset adds support for vsock sockets to Virtual Machine Manager. Changes in v3: - make UI preserve last used CID when switching Auto CID assignment on/off Changes in v2: - added clitest - addressed code review feedback - split

Re: [virt-tools-list] [virt-manager] [PATCH 1/2] cli: Replace '_' from cli_arg_name with '-' before saving to parsernames

On 12/24/2018 03:35 AM, Lin Ma wrote: The patch makes --qemu-commandline subprops completion works. Signed-off-by: Lin Ma --- virtinst/cli.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/virtinst/cli.py b/virtinst/cli.py index 21586b19..3ba81861 100644 ---

Re: [virt-tools-list] [virt-manager] [PATCH v2 0/2] Bash completion bug fixes

On 01/14/2019 04:21 AM, Lin Ma wrote: v1 -> v2: * Drop original 2/2 due to a better fix exists in git master. * Add a new patch to introduce function cli_flag_name. * Use this function to convert underscore to minus in cli_arg_name. Lin Ma (2): cli: Add function cli_flag_name to replace '_'

Re: [virt-tools-list] [PATCH] Remove Author lines from files

On 01/15/2019 04:05 AM, Slavomir Kaslev wrote: Signed-off-by: Slavomir Kaslev --- virtManager/vsockdetails.py | 3 --- virtinst/devices/vsock.py | 3 --- 2 files changed, 6 deletions(-) Thanks, pushed now - Cole ___ virt-tools-list mailing

Re: [virt-tools-list] virt-install: fix SLES11 installation on s390x

On 01/18/2019 06:58 AM, Christian Borntraeger wrote: > self._os_variant returns sles11sp4 sles11sp3 and so on. > Lets match those as well to pickup the right kernels. > > Signed-off-by: Christian Borntraeger > Reviewed-by: Boris Fiuczynski > --- > virtinst/urldetect.py | 2 +- > 1 file

Re: [virt-tools-list] Virt-Manager Networking Error

On 12/09/2018 01:17 AM, Josh Stevens wrote: Hello, Have been using virt-manager for a very long time and love it. I installed virt-manager on Debian Buster, and am having trouble with networking. My laptop is connected to the wifi, and when I start a VM, my computer, thus my VM too, loses

Re: [virt-tools-list] virt-xml/start: Temporarily use another boot configuration

On 12/11/2018 08:18 AM, Marc Hartmayer wrote: Hi all, I’m planning to implement a functionality that allows the user to temporarily use another boot configuration than defined in the persistent XML. For example it should be possible to boot from another kernel/initrd/cmdline (via direct boot)

Re: [virt-tools-list] [virt-manager] [RFC PATCH 0/9] Tab completion in bash shell via the argcomplete

On 11/14/2018 03:12 AM, Lin Ma wrote: Hi all, These draft patches add the tab completion in bash for virt-* utilities. We've been using the argparse to help parse handling, So I think that the argcomplete is a good option to deal with argument/sub-options completion in bash shell for

Re: [virt-tools-list] [virt-manager] [RFC PATCH 3/9] virt-install: Add auto complete support for the general options

On 11/14/2018 03:12 AM, Lin Ma wrote: With this patchset, the general options completion is available. ex: $ virt-install - ... --arch --check --cpu --dry-run -h --autostart --clock --cputune --events--help ... $ virt-install --a --arch --autostart

Re: [virt-tools-list] [virt-manager] [RFC PATCH 9/9] setup.py: Install and link the bash completion scripts

On 11/14/2018 03:12 AM, Lin Ma wrote: Signed-off-by: Lin Ma --- setup.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/setup.py b/setup.py index 658e6503..1c4b4340 100755 --- a/setup.py +++ b/setup.py @@ -273,6 +273,15 @@ class

Re: [virt-tools-list] [virt-manager] [RFC PATCH 8/9] Bash completion file

On 11/14/2018 03:12 AM, Lin Ma wrote: The most of content of this file comes from the output of the command ' register-python-argcomplete $MY-SCRIPT', plus some changes. For the details about argcomplete, Please refer to https://pypi.org/project/argcomplete/ or

Re: [virt-tools-list] virt-xml/start: Temporarily use another boot configuration

On 01/09/2019 06:41 AM, Marc Hartmayer wrote: On Wed, Dec 12, 2018 at 10:16 AM +0100, Marc Hartmayer wrote: On Tue, Dec 11, 2018 at 08:22 PM +0100, Cole Robinson wrote: On 12/11/2018 08:18 AM, Marc Hartmayer wrote: Hi all, I’m planning to implement a functionality that allows the user

Re: [virt-tools-list] [virt-manager][PATCH 0/4] Allow hiding window decorations and menu bar

On 01/08/2019 06:16 PM, Povilas Kanapickas wrote: On 08/01/2019 01:15, Cole Robinson wrote: On 01/01/2019 07:28 PM, Povilas Kanapickas wrote: <...> Thanks for the patches. It's an interesting idea but the use case seems very niche to have explicit support in virt-manager IMO. Even th

Re: [virt-tools-list] [virt-manager] Any interest in the element?

On 01/10/2019 04:43 AM, Pavel Hrdina wrote: On Wed, Jan 09, 2019 at 11:31:51PM +0200, Povilas Kanapickas wrote: Hey, Does it make sense to wrap the data in the element [1] within the virt-manager GUI? I would be interested in implementing support for that. Hi, I'm not so sure about this

Re: [virt-tools-list] [PATCH virt-manager 00/14] Various changes

On 12/18/2018 08:44 AM, Marc Hartmayer wrote: Marc Hartmayer (14): xmlapi: refactor node_is_text function test_urls: simplify the sorting cli: register a parser class only once cli: add register classmethod to each parser cli: rename ParseMemdev to ParserMemdev cli: use Python3

Re: [virt-tools-list] [virt-manager][PATCH 0/4] Allow hiding window decorations and menu bar

On 01/01/2019 07:28 PM, Povilas Kanapickas wrote: The screen estate used by the virt-manager itself in the console mode reduces the amount of screen estate available to the VM. virt-manager currently supports the fullscreen option to make maximum use of the available screen. Unfortunately, this

Re: [virt-tools-list] [PATCH virt-manager 00/14] Various changes

On 01/07/2019 03:44 PM, Cole Robinson wrote: On 12/18/2018 08:44 AM, Marc Hartmayer wrote: Marc Hartmayer (14):    xmlapi: refactor node_is_text function    test_urls: simplify the sorting    cli: register a parser class only once    cli: add register classmethod to each parser    cli: rename

Re: [virt-tools-list] [PATCH virt-manager 00/14] Various changes

On 01/08/2019 10:37 AM, Marc Hartmayer wrote: On Tue, Jan 08, 2019 at 12:17 AM +0100, Cole Robinson wrote: On 01/07/2019 03:44 PM, Cole Robinson wrote: On 12/18/2018 08:44 AM, Marc Hartmayer wrote: Marc Hartmayer (14):    xmlapi: refactor node_is_text function    test_urls: simplify

Re: [virt-tools-list] [virt-manager] Any interest in the element?

On 01/11/2019 11:47 AM, Povilas Kanapickas wrote: On 10/01/2019 19:00, Cole Robinson wrote: On 01/10/2019 04:43 AM, Pavel Hrdina wrote: On Wed, Jan 09, 2019 at 11:31:51PM +0200, Povilas Kanapickas wrote: Hey, Does it make sense to wrap the data in the element [1] within the virt-manager GUI

Re: [virt-tools-list] [virt-manager] Any interest in the element?

On 01/12/2019 04:47 PM, Povilas Kanapickas wrote: On 11/01/2019 20:56, Cole Robinson wrote: On 01/11/2019 11:47 AM, Povilas Kanapickas wrote: On 10/01/2019 19:00, Cole Robinson wrote: On 01/10/2019 04:43 AM, Pavel Hrdina wrote: On Wed, Jan 09, 2019 at 11:31:51PM +0200, Povilas Kanapickas

Re: [virt-tools-list] [PATCH virt-manager] cli: Fix __init_class__

On 01/09/2019 04:47 AM, Marc Hartmayer wrote: On Wed, Jan 09, 2019 at 10:24 AM +0100, Marc Hartmayer wrote: For Python versions < 3.6 it's not possible for the metaclass to call a method in the defined class that uses super() before it is done with its __new__ and __init__. Therefore let's

Re: [virt-tools-list] [PATCH v3 1/4] virtinst: Add vsock device type

On 12/19/2018 04:31 AM, Marc Hartmayer wrote: On Tue, Dec 18, 2018 at 04:18 PM +0100, Slavomir Kaslev wrote: On 12/18/18 3:59 PM, Marc Hartmayer wrote: On Fri, Dec 14, 2018 at 03:34 PM +0100, Slavomir Kaslev wrote: VSOCK sockets allow communication between virtual machines and the host

Re: [virt-tools-list] [virt-manager][PATCH 0/4] Allow hiding window decorations and menu bar

. And given that in my limited testing the decorations issue didn't work on wayland I assume this feature would be similar Maybe this is something to bring up WRT to virt-viewer? Like a command line option or something. Just a thought - Cole On Mon, 7 Jan 2019, 23:15 Cole Robinson

Re: [virt-tools-list] [virt-manager] [PATCH v2 00/10] Tab completion in bash shell via the argcomplete

On 12/07/2018 03:28 AM, Lin Ma wrote: v1 -> v2: * Wrapper autocomplete function into cli.py to avoid to import argcomplete everywhere * Move bash completion template file 'virtmanager' into data/bash-completion/ folder. * Modify 'virtmanager', remove the complete lines. instead, The virt-*

Re: [virt-tools-list] virt-install: boot from the 2nd hard disk via UEFI if the first one is "empty"

On 01/22/2019 07:40 AM, Attila Vangel wrote: > Hi, > > I am new to virt-install and just a regular user of UEFI, so forgive me > if I ask something stupid. > > I am trying to create and start a VM with virt-install so that > - it needs to boot with UEFI, > - if the first disk is "empty" (just

Re: [virt-tools-list] [virt-manager PATCH 0/5] CPU security features improvements

ccing danpb On 4/3/19 9:52 AM, Pavel Hrdina wrote: > Pavel Hrdina (5): > domcapabilities: remove recommended CPU features from security > features > domcapabilities: fix typo in function name > cli: introduce CPU secure parameter > domcapabilities: add caching of CPU security features

Re: [virt-tools-list] [virt-manager PATCH 0/9] Add RISC-V support

sts > guest: Enable USB input devices for RISC-V virt guests > Reviewed-by: Cole Robinson And pushed Thanks, Cole ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [virt-install PATCH v2 4/7] urldetect: return osdict.py:OsMedia instead of Libosinfo.Media

On 3/22/19 11:23 AM, Fabiano Fidêncio wrote: > Consequently, let's: > - rename urldetect::get_osinfo_media() to get_os_media() > - rename the installertreemedia::_LocationData::osinfo_media to os_media > - rename unattended::prepare_install_script's media argument to os_media > - and also rename

Re: [virt-tools-list] [virt-manager] [PATCH 1/4] cli: Add --genid option to support VM generation ID

On 3/26/19 5:42 AM, Lin Ma wrote: > Libvirt supports VM generation ID since 4.4.0, This patchset adds it > for virt-manager. > > The value either is specified through cli or is generated by libvirt. > ex: > virt-install --genid e90ff655-47a5-4484-9f9c-79a683c2a2e2 --memory ... > OR > virt-install

Re: [virt-tools-list] [virt-manager] [PATCH 3/4] testdriver: Add genid example

On 3/26/19 5:42 AM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > tests/testdriver.xml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/testdriver.xml b/tests/testdriver.xml > index f6d09123..2bedb5e4 100644 > --- a/tests/testdriver.xml > +++ b/tests/testdriver.xml > @@ -61,6

Re: [virt-tools-list] [virt-manager] [PATCH 2/4] details: Add VM genid support

On 3/26/19 5:42 AM, Lin Ma wrote: > Currently, It doesn't support manually specify the genid value in the > details window, Only supports auto value. > > Signed-off-by: Lin Ma > --- > ui/details.ui | 38 -- > virtManager/details.py | 17

Re: [virt-tools-list] [virt-install PATCH] osdict: Fix OsMedia::requires_internet() logic

On 3/29/19 10:05 AM, Fabiano Fidêncio wrote: > In case there's no self.osinfo_media, it means the installation won't > happen from the media itself, so it should return "True" (as in, it > requires internet). > > Returning "False", though, should be done when no "netinst" variant was > found (but

Re: [virt-tools-list] [virt-manager PATCH] graphics: move all listen code into one place

++--- > 5 files changed, 19 insertions(+), 33 deletions(-) > Reviewed-by: Cole Robinson - Cole ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [virt-manager PATCH] virtManager: clone: check which storage pools supports volume cloning

know this is what the python world is pushing these days but I personally find that format to be ugly and far less readable. Please use the traditional format for this patch. If you feel strongly about using that format in the code base let's have a top level thread about it. Otherwise: Reviewed-by:

Re: [virt-tools-list] Docs on getting VirGL working with virt-manager?

On 2/18/19 7:39 AM, Daniel Kasak wrote: > On Tue, Feb 19, 2019 at 12:38 AM Cole Robinson <mailto:crobi...@redhat.com>> wrote: > > On 2/17/19 10:57 AM, Daniel Kasak wrote: > > On Sat, Feb 9, 2019 at 2:05 AM Cole Robinson <mailto:crobi...@redhat

Re: [virt-tools-list] [virt-install PATCH v2 00/14] Add support for unattended installations

On 3/6/19 1:55 AM, Fabiano Fidêncio wrote: > On Tue, Mar 5, 2019 at 10:50 PM Cole Robinson wrote: >> >> On 2/22/19 3:40 AM, Fabiano Fidêncio wrote: >>> This series add support for *network* (--location) unattended >>> installations of a few OSes that lib

Re: [virt-tools-list] [PATCH virt-manager 04/14] support: Add SUPPORT_CONN_DEVICE_BOOT_ORDER

On 2/26/19 5:10 AM, Marc Hartmayer wrote: > On Tue, Feb 26, 2019 at 10:56 AM +0100, Marc Hartmayer > wrote: >> ...and use it in domain.py. >> >> Signed-off-by: Marc Hartmayer >> Reviewed-by: Boris Fiuczynski >> --- >> virtManager/domain.py | 3 ++- >> virtinst/support.py | 3 +++ >> 2 files

Re: [virt-tools-list] Fwd: [s3-bug-review] Remote-viewer will disconnect after migration back in seamless SPICE migration when there already has another guest client opened by virt-manager

On 3/6/19 4:41 AM, Xiaodai Wang wrote: > Hi, could you help to check whether it's a bug or not? > It's a problem that virt-manager and virt-viewer race for console > connection. > I don't think this is a bug really, since both clients are separate processes attempting to connect to the single

Re: [virt-tools-list] [virt-manager PATCH 4/6] devices: disk: Use virtio-scsi for CDROMs where supported

On 3/4/19 11:11 AM, Andrea Bolognani wrote: > We already use virtio-blk for regular disks whenever possible, > and there's no good reason not to do the same with virtio-scsi > when dealing with CDROMs instead of artificially limiting its > use to s390x and ppc64/pseries guests. > > Signed-off-by:

Re: [virt-tools-list] [PATCH virt-install 2/4] osdict: add get_location()

On 2/8/19 10:23 AM, Fabiano Fidêncio wrote: > get_location() is a new method that returns the osinfo-db tree URL of an > OS, according to the passed architecture. > > This method will need some improvement later on once we start having a > specific set of definitions on osinfo-db about what's the

Re: [virt-tools-list] Docs on getting VirGL working with virt-manager?

On 2/19/19 4:04 AM, Daniel Kasak wrote: > On Wed, Feb 20, 2019 at 1:29 AM Cole Robinson <mailto:crobi...@redhat.com>> wrote: > > On 2/18/19 7:39 AM, Daniel Kasak wrote: > > On Tue, Feb 19, 2019 at 12:38 AM Cole Robinson > mailto:crobi...@redhat

Re: [virt-tools-list] [virt-install PATCH v2 00/14] Add support for unattended installations

On 2/22/19 3:40 AM, Fabiano Fidêncio wrote: > This series add support for *network* (--location) unattended > installations of a few OSes that libosinfo/osinfo-db provides support > for: > - Fedora; > - CentOS; > - RHEL; > - Debian; > - openSUSE; > - Ubuntu*; > > *: Ubuntu needs some pending

Re: [virt-tools-list] [virt-manager PATCH] virtManager: clone: build default clone path if we know how

py | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) Reviewed-by: Cole Robinson - Cole ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [virt-manager] [PATCH] Use changed instead of value-changed signal in spinbutton in vsockdetails ui

On 3/5/19 1:34 AM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > ui/vsockdetails.ui | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ui/vsockdetails.ui b/ui/vsockdetails.ui > index 7f607b2b..2a8ee73a 100644 > --- a/ui/vsockdetails.ui > +++ b/ui/vsockdetails.ui > @@ -67,7

Re: [virt-tools-list] virt-install: Add ability to specify queues for controller

On 3/13/19 12:41 AM, Vasudev Kamath wrote: On Tue, 12 Mar 2019 at 20:03, Cole Robinson wrote: Patch looks good to me, I squashed in a test case and pushed. Thank you! Awesome thanks!. Is it already pushed to github?. I did not see it in list of new commits.[1] [1] https://github.com/virt

Re: [virt-tools-list] [virt-manager PATCH v3 0/9] Unattended installation support (part III)

On 3/7/19 7:52 AM, Fabiano Fidêncio wrote: > This series provides the 3rd part of unattended installation support and > consists in: > > - "installertreemdia: Set user specified --location as the installer > URL": > - Fix unattended installations when the user explicitly pass >

Re: [virt-tools-list] [PATCH] Fix a few issues reported by codespell

On 3/18/19 12:48 PM, Erik Skultety wrote: There were a few minor typos across the codebase which codespell pointed out. Signed-off-by: Erik Skultety --- virtManager/createpool.py | 2 +- virtManager/createvol.py | 2 +- virtManager/details.py| 2 +- virtinst/osdict.py| 2 +-

Re: [virt-tools-list] virt-install: Add ability to specify queues for controller

On 3/12/19 6:05 AM, Vasudev Kamath wrote: > Hi, > > I've use case where I need to specify option > to virtio-scsi controller[1].Currently it is not possible to tell > virt-install about the number of queues. > I've created a patch looking at --network code. I'm attaching my patch > with this

Re: [virt-tools-list] [virt-manager PATCH 6/8] domcapabilities: introduce get_cpu_security_features

On 3/15/19 12:41 PM, Pavel Hrdina wrote: Get all CPU security features that we should enable for guests. In order to do that we need to get CPU definition from domain capabilities and modify the XML so it is in required format for libvirt CPU baseline APIs. We will prefer the

Re: [virt-tools-list] [virt-manager PATCH 6/8] domcapabilities: introduce get_cpu_security_features

On 3/15/19 2:24 PM, Cole Robinson wrote: On 3/15/19 12:41 PM, Pavel Hrdina wrote: Get all CPU security features that we should enable for guests. In order to do that we need to get CPU definition from domain capabilities and modify the XML so it is in required format for libvirt CPU baseline

<    11   12   13   14   15   16   17   18   19   >