[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 10:45:18PM CET, pa...@nvidia.com wrote: > >> From: Jiri Pirko >> Sent: Wednesday, March 8, 2023 5:05 AM > >> >For example a common feature is to program a vlan and have device put a >> >given VF inside this vlan. >> >> I don't follow entirely. The way how the VF is connected

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 10:25:32PM CET, pa...@nvidia.com wrote: > >> From: virtio-comm...@lists.oasis-open.org > open.org> On Behalf Of David Edmondson > >> In support of live migration, might we end up moving large amounts of device >> state through the admin queue? >> >Correct. > >> If so, that wou

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 10:09:22PM CET, m...@redhat.com wrote: >On Wed, Mar 08, 2023 at 10:58:59PM +0200, Max Gurtovoy wrote: >> We have a non-spec prototypes for LM so please use our experience in this >> area. > >Don't see what the fuss is about. Nothing will prevent your device from >using a singl

[virtio-dev] Re: [virtio-comment] Re: [PATCH v10 03/10] admin: introduce group administration commands

2023-03-08 Thread Michael S. Tsirkin
On Thu, Mar 09, 2023 at 02:29:31AM +0200, Max Gurtovoy wrote: > please use "Co-developed-by:" for this patch Sure. -- MST - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: v

Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH v9] virtio-net: support inner header hash

2023-03-08 Thread Heng Qi
在 2023/3/8 下午10:39, Michael S. Tsirkin 写道: On Wed, Mar 01, 2023 at 10:56:31AM +0800, Heng Qi wrote: 在 2023/2/28 下午7:16, Michael S. Tsirkin 写道: On Sat, Feb 18, 2023 at 10:37:15PM +0800, Heng Qi wrote: If the tunnel is used to encapsulate the packets, the hash calculated using the outer head

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] RE: [PATCH v10] virtio-net: support the virtqueue coalescing moderation

2023-03-08 Thread Heng Qi
在 2023/3/9 上午6:30, Parav Pandit 写道: From: virtio-dev@lists.oasis-open.org On Behalf Of Heng Qi Sent: Thursday, March 2, 2023 10:27 PM I remember we discussed that instead of mentioning each individual field, better to describe the whole structure being read-only or write-only. Consider th

RE: [virtio-dev] RE: [PATCH v10] virtio-net: support the virtqueue coalescing moderation

2023-03-08 Thread Parav Pandit
> From: virtio-dev@lists.oasis-open.org On > Behalf Of Heng Qi > Sent: Thursday, March 2, 2023 10:27 PM > > > I remember we discussed that instead of mentioning each individual field, > better to describe the whole structure being read-only or write-only. > > Consider the following scenarios: >

[virtio-dev] RE: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Parav Pandit
> From: Jiri Pirko > Sent: Wednesday, March 8, 2023 5:05 AM > >For example a common feature is to program a vlan and have device put a > >given VF inside this vlan. > > I don't follow entirely. The way how the VF is connected to network should be > ouf of the scope of this interface. The eswit

[virtio-dev] RE: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Parav Pandit
> From: virtio-comm...@lists.oasis-open.org open.org> On Behalf Of David Edmondson > In support of live migration, might we end up moving large amounts of device > state through the admin queue? > Correct. > If so, that would seem to have some performance requirements, though I don't > know i

[virtio-dev] RE: [virtio-comment] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, March 8, 2023 4:09 PM > > On Wed, Mar 08, 2023 at 10:58:59PM +0200, Max Gurtovoy wrote: > > We have a non-spec prototypes for LM so please use our experience in > > this area. > > Don't see what the fuss is about. Nothing will prevent your device

[virtio-dev] Re: [virtio-comment] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Michael S. Tsirkin
On Wed, Mar 08, 2023 at 10:58:59PM +0200, Max Gurtovoy wrote: > We have a non-spec prototypes for LM so please use our experience in this > area. Don't see what the fuss is about. Nothing will prevent your device from using a single queue if that is what you want. -- MST -

[virtio-dev] Re: [virtio] Re: [PATCH v10 06/10] mmio: document ADMIN_VQ as reserved

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 05:30:21PM CET, m...@redhat.com wrote: >On Tue, Mar 07, 2023 at 06:52:03PM +, Parav Pandit wrote: >> > And I wonder whether it's worth it - it definitely makes contributing to >> > Linux >> > harder, and even within Linux it pushes contributors away. >> The number of virt

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 07:01:02PM CET, david.edmond...@oracle.com wrote: >Max Gurtovoy writes: > >> On 08/03/2023 14:08, Jiri Pirko wrote: >>> Wed, Mar 08, 2023 at 12:50:48PM CET, m...@redhat.com wrote: On Wed, Mar 08, 2023 at 11:05:00AM +0100, Jiri Pirko wrote: > Tue, Mar 07, 2023 at 05:30

[virtio-dev] Re: [virtio-comment] [PATCH v10 00/10] Introduce device group and device management

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 05:30:48PM CET, coh...@redhat.com wrote: >On Mon, Mar 06 2023, "Michael S. Tsirkin" wrote: > >> On Mon, Mar 06, 2023 at 01:29:30PM +0100, Jiri Pirko wrote: >>> Thu, Mar 02, 2023 at 02:04:48PM CET, m...@redhat.com wrote: >>> >>> [...] >>> >>> > >>> >TODO (maybe?) - probably o

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread David Edmondson
Max Gurtovoy writes: > On 08/03/2023 14:08, Jiri Pirko wrote: >> Wed, Mar 08, 2023 at 12:50:48PM CET, m...@redhat.com wrote: >>> On Wed, Mar 08, 2023 at 11:05:00AM +0100, Jiri Pirko wrote: Tue, Mar 07, 2023 at 05:30:18PM CET, m...@redhat.com wrote: > On Tue, Mar 07, 2023 at 08:36:41AM +0

[virtio-dev] Re: [virtio-comment] [PATCH v10] virtio-net: support the virtqueue coalescing moderation

2023-03-08 Thread Michael S. Tsirkin
On Wed, Mar 08, 2023 at 04:42:25PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Monday, March 6, 2023 5:57 PM > > > > On Thu, Mar 02, 2023 at 11:36:18AM +, David Edmondson wrote: > > > > +for an enabled > > > > transmit/receive

[virtio-dev] Re: [virtio-comment] [PATCH v10 00/10] Introduce device group and device management

2023-03-08 Thread Michael S. Tsirkin
On Wed, Mar 08, 2023 at 05:30:48PM +0100, Cornelia Huck wrote: > On Mon, Mar 06 2023, "Michael S. Tsirkin" wrote: > > > On Mon, Mar 06, 2023 at 01:29:30PM +0100, Jiri Pirko wrote: > >> Thu, Mar 02, 2023 at 02:04:48PM CET, m...@redhat.com wrote: > >> > >> [...] > >> > >> > > >> >TODO (maybe?) -

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Michael S. Tsirkin
On Wed, Mar 08, 2023 at 12:15:23PM -0500, Stefan Hajnoczi wrote: > > > > > Or we could say that admin commands must complete within bounded time, > > > > > but I'm not sure that is implementable for some device types like > > > > > virtio-blk, virtio-scsi, and virtiofs. > > > > > > > > No we can't

[virtio-dev] Re: [virtio] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Stefan Hajnoczi
On Wed, Mar 08, 2023 at 01:57:43PM +0100, Jiri Pirko wrote: > Wed, Mar 08, 2023 at 01:44:18PM CET, stefa...@redhat.com wrote: > >On Wed, Mar 08, 2023 at 11:17:35AM +0100, Jiri Pirko wrote: > >> Tue, Mar 07, 2023 at 08:03:47PM CET, stefa...@redhat.com wrote: > >> >On Tue, Mar 07, 2023 at 04:07:54PM

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Stefan Hajnoczi
On Wed, Mar 08, 2023 at 06:19:41PM +0200, Max Gurtovoy wrote: > > > On 08/03/2023 16:13, Stefan Hajnoczi wrote: > > On Wed, Mar 08, 2023 at 01:17:33PM +0200, Max Gurtovoy wrote: > > > > > > > > > On 06/03/2023 18:25, Stefan Hajnoczi wrote: > > > > On Mon, Mar 06, 2023 at 05:28:03PM +0200, Max G

[virtio-dev] RE: [virtio-comment] [PATCH v10] virtio-net: support the virtqueue coalescing moderation

2023-03-08 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, March 6, 2023 5:57 PM > > On Thu, Mar 02, 2023 at 11:36:18AM +, David Edmondson wrote: > > > +for an enabled transmit/receive > > > virtqueue whose > number is \field{vqn}. > > > > Should this now be "whose

[virtio-dev] RE: [virtio-comment] RE: [PATCH v10 06/10] mmio: document ADMIN_VQ as reserved

2023-03-08 Thread Parav Pandit
> From: Cornelia Huck > Sent: Wednesday, March 8, 2023 11:24 AM > >> And I wonder whether it's worth it - it definitely makes contributing > >> to Linux harder, and even within Linux it pushes contributors away. > > The number of virtio spec contributors are in order of magnitude less than > L

[virtio-dev] Re: [virtio-comment] [PATCH v10 00/10] Introduce device group and device management

2023-03-08 Thread Cornelia Huck
On Mon, Mar 06 2023, "Michael S. Tsirkin" wrote: > On Mon, Mar 06, 2023 at 01:29:30PM +0100, Jiri Pirko wrote: >> Thu, Mar 02, 2023 at 02:04:48PM CET, m...@redhat.com wrote: >> >> [...] >> >> > >> >TODO (maybe?) - probably ok to defer until this part is upstream: >> > >> >Add "all members"

[virtio-dev] Re: [PATCH v10 06/10] mmio: document ADMIN_VQ as reserved

2023-03-08 Thread Michael S. Tsirkin
On Tue, Mar 07, 2023 at 06:52:03PM +, Parav Pandit wrote: > > And I wonder whether it's worth it - it definitely makes contributing to > > Linux > > harder, and even within Linux it pushes contributors away. > The number of virtio spec contributors are in order of magnitude less > than Linux

[virtio-dev] Re: [virtio-comment] RE: [PATCH v10 06/10] mmio: document ADMIN_VQ as reserved

2023-03-08 Thread Cornelia Huck
On Tue, Mar 07 2023, Parav Pandit wrote: >> From: Michael S. Tsirkin >> Sent: Friday, March 3, 2023 3:34 AM >> >> On Thu, Mar 02, 2023 at 06:40:55PM +, Parav Pandit wrote: >> > Did you miss reviewed-by from [1] or this is an old series reposted? >> > [1] >> > https://lists.oasis-open.org/ar

[virtio-dev] RE: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Parav Pandit
> From: Stefan Hajnoczi > Sent: Wednesday, March 8, 2023 9:13 AM > Therefore I think the admin queue must be designed under the assumption that > some commands take a very long time. +1

[virtio-dev] Re: [PATCH v10 03/10] admin: introduce group administration commands

2023-03-08 Thread Michael S. Tsirkin
On Wed, Mar 08, 2023 at 03:05:50PM +0200, Max Gurtovoy wrote: > All drivers in SW world ? All drivers in Linux ? or Virtio drivers ? Most of the above. -- MST - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.o

[virtio-dev] Re: [virtio] [PATCH v10 01/10] virtio: document forward compatibility guarantees

2023-03-08 Thread Michael S. Tsirkin
On Wed, Mar 08, 2023 at 03:16:41PM +0100, Cornelia Huck wrote: > On Tue, Mar 07 2023, David Edmondson wrote: > > > "Michael S. Tsirkin" writes: > > > >> On Mon, Mar 06, 2023 at 01:53:50PM +, David Edmondson wrote: > >>> "Michael S. Tsirkin" writes: > >>> > >>> > Feature negotiation forms t

[virtio-dev] Re: [PATCH v10 03/10] admin: introduce group administration commands

2023-03-08 Thread Michael S. Tsirkin
On Wed, Mar 08, 2023 at 03:43:14PM +0100, Cornelia Huck wrote: > On Wed, Mar 08 2023, Max Gurtovoy wrote: > > > On 08/03/2023 14:07, Michael S. Tsirkin wrote: > >> On Wed, Mar 08, 2023 at 12:55:37PM +0200, Max Gurtovoy wrote: > > 5. VIRTIO_ADMIN_STATUS_COMMAND_SPECIFIC_ERR (for more info read

[virtio-dev] Re: [PATCH v10 03/10] admin: introduce group administration commands

2023-03-08 Thread Cornelia Huck
On Wed, Mar 08 2023, Max Gurtovoy wrote: > On 08/03/2023 14:07, Michael S. Tsirkin wrote: >> On Wed, Mar 08, 2023 at 12:55:37PM +0200, Max Gurtovoy wrote: > 5. VIRTIO_ADMIN_STATUS_COMMAND_SPECIFIC_ERR (for more info read the > command_specific_error field). I don't think it's a

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH v9] virtio-net: support inner header hash

2023-03-08 Thread Michael S. Tsirkin
On Wed, Mar 01, 2023 at 10:56:31AM +0800, Heng Qi wrote: > > > 在 2023/2/28 下午7:16, Michael S. Tsirkin 写道: > > On Sat, Feb 18, 2023 at 10:37:15PM +0800, Heng Qi wrote: > > > If the tunnel is used to encapsulate the packets, the hash calculated > > > using the outer header of the receive packets is

Re: [virtio-dev] [PATCH v10] virtio-net: support inner header hash

2023-03-08 Thread Michael S. Tsirkin
On Wed, Mar 08, 2023 at 10:27:13PM +0800, Heng Qi wrote: > Do you have any comments, please? > > Thanks. :) > > 在 2023/3/6 下午11:48, Heng Qi 写道: It's been just 2 partial days. Sit tight pls. -- MST - To unsubscribe, e-mail: v

[virtio-dev] Re: [virtio-comment] [PATCH v10] virtio-net: support the virtqueue coalescing moderation

2023-03-08 Thread Heng Qi
在 2023/3/7 上午6:57, Michael S. Tsirkin 写道: On Thu, Mar 02, 2023 at 11:36:18AM +, David Edmondson wrote: +for an enabled transmit/receive virtqueue whose number is \field{vqn}. Should this now be "whose index is \field{vqn}"? Ugh. I guess we'll ha

[virtio-dev] Re: [virtio] [PATCH v10 01/10] virtio: document forward compatibility guarantees

2023-03-08 Thread Cornelia Huck
On Tue, Mar 07 2023, David Edmondson wrote: > "Michael S. Tsirkin" writes: > >> On Mon, Mar 06, 2023 at 01:53:50PM +, David Edmondson wrote: >>> "Michael S. Tsirkin" writes: >>> >>> > Feature negotiation forms the basis of forward compatibility >>> > guarantees of virtio but has never been

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Stefan Hajnoczi
On Wed, Mar 08, 2023 at 01:17:33PM +0200, Max Gurtovoy wrote: > > > On 06/03/2023 18:25, Stefan Hajnoczi wrote: > > On Mon, Mar 06, 2023 at 05:28:03PM +0200, Max Gurtovoy wrote: > > > > > > > > > On 06/03/2023 13:20, Stefan Hajnoczi wrote: > > > > On Mon, Mar 06, 2023 at 04:00:50PM +0800, Jason

[virtio-dev] Re: [virtio] Re: [virtio-comment] [PATCH v10 09/10] admin: conformance clauses

2023-03-08 Thread Michael S. Tsirkin
On Wed, Mar 08, 2023 at 03:02:05PM +0100, Jiri Pirko wrote: > Wed, Mar 08, 2023 at 02:44:08PM CET, david.edmond...@oracle.com wrote: > >Jiri Pirko writes: > > > >> Wed, Mar 08, 2023 at 01:59:10PM CET, david.edmond...@oracle.com wrote: > >>>"Michael S. Tsirkin" writes: > >>> > On Tue, Mar 07,

[virtio-dev] Re: [virtio] Re: [virtio-comment] [PATCH v10 09/10] admin: conformance clauses

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 02:44:08PM CET, david.edmond...@oracle.com wrote: >Jiri Pirko writes: > >> Wed, Mar 08, 2023 at 01:59:10PM CET, david.edmond...@oracle.com wrote: >>>"Michael S. Tsirkin" writes: >>> On Tue, Mar 07, 2023 at 11:04:33AM +, David Edmondson wrote: > "Michael S. Tsirki

[virtio-dev] Re: [virtio] Re: [virtio-comment] [PATCH v10 09/10] admin: conformance clauses

2023-03-08 Thread David Edmondson
Jiri Pirko writes: > Wed, Mar 08, 2023 at 01:59:10PM CET, david.edmond...@oracle.com wrote: >>"Michael S. Tsirkin" writes: >> >>> On Tue, Mar 07, 2023 at 11:04:33AM +, David Edmondson wrote: "Michael S. Tsirkin" writes: > +The driver MAY block use of VIRTIO_ADMIN_CMD_LIST_QUERY an

[virtio-dev] Re: [virtio] Re: [virtio-comment] [PATCH v10 09/10] admin: conformance clauses

2023-03-08 Thread Michael S. Tsirkin
On Wed, Mar 08, 2023 at 02:05:01PM +0100, Jiri Pirko wrote: > Wed, Mar 08, 2023 at 01:59:10PM CET, david.edmond...@oracle.com wrote: > >"Michael S. Tsirkin" writes: > > > >> On Tue, Mar 07, 2023 at 11:04:33AM +, David Edmondson wrote: > >>> "Michael S. Tsirkin" writes: > >>> > +The driver MAY

[virtio-dev] Re: [virtio] Re: [virtio-comment] [PATCH v10 09/10] admin: conformance clauses

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 01:59:10PM CET, david.edmond...@oracle.com wrote: >"Michael S. Tsirkin" writes: > >> On Tue, Mar 07, 2023 at 11:04:33AM +, David Edmondson wrote: >>> "Michael S. Tsirkin" writes: >>> > +The driver MAY block use of VIRTIO_ADMIN_CMD_LIST_QUERY and >>> > +VIRTIO_ADMIN_CMD_LI

[virtio-dev] Re: [virtio-comment] [PATCH v10 09/10] admin: conformance clauses

2023-03-08 Thread David Edmondson
"Michael S. Tsirkin" writes: > On Tue, Mar 07, 2023 at 11:04:33AM +, David Edmondson wrote: >> "Michael S. Tsirkin" writes: >> > +The driver MAY block use of VIRTIO_ADMIN_CMD_LIST_QUERY and >> > +VIRTIO_ADMIN_CMD_LIST_USE by issuing VIRTIO_ADMIN_CMD_LIST_USE >> > +with respective bits cleare

[virtio-dev] Re: [virtio] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 01:44:18PM CET, stefa...@redhat.com wrote: >On Wed, Mar 08, 2023 at 11:17:35AM +0100, Jiri Pirko wrote: >> Tue, Mar 07, 2023 at 08:03:47PM CET, stefa...@redhat.com wrote: >> >On Tue, Mar 07, 2023 at 04:07:54PM +0100, Jiri Pirko wrote: >> >> Tue, Mar 07, 2023 at 03:39:11PM CET,

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Stefan Hajnoczi
On Wed, Mar 08, 2023 at 11:17:35AM +0100, Jiri Pirko wrote: > Tue, Mar 07, 2023 at 08:03:47PM CET, stefa...@redhat.com wrote: > >On Tue, Mar 07, 2023 at 04:07:54PM +0100, Jiri Pirko wrote: > >> Tue, Mar 07, 2023 at 03:39:11PM CET, stefa...@redhat.com wrote: > >> >On Tue, Mar 07, 2023 at 09:03:18AM

Re: [virtio-dev] [PATCH v10 08/10] admin: command list discovery

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 12:54:52PM CET, m...@redhat.com wrote: >On Mon, Mar 06, 2023 at 01:22:30PM +0100, Jiri Pirko wrote: >> Thu, Mar 02, 2023 at 02:05:22PM CET, m...@redhat.com wrote: >> >Add commands to find out which commands does each group support, >> >as well as enable their use by driver. >>

Re: [virtio-dev] [PATCH v10 08/10] admin: command list discovery

2023-03-08 Thread Jiri Pirko
Thu, Mar 02, 2023 at 02:05:22PM CET, m...@redhat.com wrote: >Add commands to find out which commands does each group support, >as well as enable their use by driver. >This will be especially useful once we have multiple group types. > >An alternative is per-type VQs. This is possible but will >requ

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 12:50:48PM CET, m...@redhat.com wrote: >On Wed, Mar 08, 2023 at 11:05:00AM +0100, Jiri Pirko wrote: >> Tue, Mar 07, 2023 at 05:30:18PM CET, m...@redhat.com wrote: >> >On Tue, Mar 07, 2023 at 08:36:41AM +0100, Jiri Pirko wrote: >> >> Hmm, if not for now, the future exension woul

[virtio-dev] Re: [PATCH v10 03/10] admin: introduce group administration commands

2023-03-08 Thread Michael S. Tsirkin
On Wed, Mar 08, 2023 at 12:55:37PM +0200, Max Gurtovoy wrote: > > > 5. VIRTIO_ADMIN_STATUS_COMMAND_SPECIFIC_ERR (for more info read the > > > command_specific_error field). > > > > I don't think it's a good idea, we'll have to agree to disagree. > > Ok. > can you explain why isn't this a good ide

Re: [virtio-dev] Re: [PATCH v10 03/10] admin: introduce group administration commands

2023-03-08 Thread Michael S. Tsirkin
On Tue, Mar 07, 2023 at 12:31:51PM +0100, Jiri Pirko wrote: > Fri, Mar 03, 2023 at 09:23:14PM CET, stefa...@redhat.com wrote: > >On Fri, Mar 03, 2023 at 08:18:43AM -0500, Michael S. Tsirkin wrote: > >> On Fri, Mar 03, 2023 at 08:13:37AM -0500, Stefan Hajnoczi wrote: > >> > On Thu, Mar 02, 2023 at 0

[virtio-dev] RE: [virtio-comment] [PATCH v10 00/10] Introduce device group and device management

2023-03-08 Thread Parav Pandit
> From: Jason Wang > Sent: Wednesday, March 8, 2023 12:12 AM > > In other words, can AQ command be useful tomorrow for doing SIOV device > add/remove, and provisioning from non-owning PF? > > The way AQ is crafted today is not there yet, but in the future, it can be > extended. > > There's al

[virtio-dev] Re: [virtio] RE: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Michael S. Tsirkin
On Wed, Mar 08, 2023 at 01:17:44PM +0800, Jason Wang wrote: > On Wed, Mar 8, 2023 at 3:09 AM Parav Pandit wrote: > > > > > > > > > From: Stefan Hajnoczi > > > Sent: Tuesday, March 7, 2023 2:04 PM > > > > > An alternative is unconditional out-of-order completion, where there are > > > no > > > pe

[virtio-dev] Re: [virtio] RE: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Stefan Hajnoczi
On Wed, Mar 08, 2023 at 01:17:44PM +0800, Jason Wang wrote: > On Wed, Mar 8, 2023 at 3:09 AM Parav Pandit wrote: > > > > > > > > > From: Stefan Hajnoczi > > > Sent: Tuesday, March 7, 2023 2:04 PM > > > > > An alternative is unconditional out-of-order completion, where there are > > > no > > > pe

[virtio-dev] Re: [virtio-comment] [PATCH v10 09/10] admin: conformance clauses

2023-03-08 Thread Michael S. Tsirkin
On Tue, Mar 07, 2023 at 11:04:33AM +, David Edmondson wrote: > "Michael S. Tsirkin" writes: > > > Add conformance clauses for admin commands and admin virtqueues. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > admin.tex | 216 +- > >

Re: [virtio-dev] [PATCH v10 08/10] admin: command list discovery

2023-03-08 Thread Michael S. Tsirkin
On Mon, Mar 06, 2023 at 01:22:30PM +0100, Jiri Pirko wrote: > Thu, Mar 02, 2023 at 02:05:22PM CET, m...@redhat.com wrote: > >Add commands to find out which commands does each group support, > >as well as enable their use by driver. > >This will be especially useful once we have multiple group types

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Michael S. Tsirkin
On Wed, Mar 08, 2023 at 11:05:00AM +0100, Jiri Pirko wrote: > Tue, Mar 07, 2023 at 05:30:18PM CET, m...@redhat.com wrote: > >On Tue, Mar 07, 2023 at 08:36:41AM +0100, Jiri Pirko wrote: > >> Hmm, if not for now, the future exension would not be so simple, I fear. > > > >Without knowing what it is I

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Michael S. Tsirkin
On Wed, Mar 08, 2023 at 11:08:56AM +0100, Jiri Pirko wrote: > Tue, Mar 07, 2023 at 05:13:01PM CET, m...@redhat.com wrote: > >On Tue, Mar 07, 2023 at 09:03:18AM +0100, Jiri Pirko wrote: > >> I sense there is no concete idea about what the "admin virtqueue" should > >> serve for exactly. > > > >Becau

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Jiri Pirko
Tue, Mar 07, 2023 at 08:03:47PM CET, stefa...@redhat.com wrote: >On Tue, Mar 07, 2023 at 04:07:54PM +0100, Jiri Pirko wrote: >> Tue, Mar 07, 2023 at 03:39:11PM CET, stefa...@redhat.com wrote: >> >On Tue, Mar 07, 2023 at 09:03:18AM +0100, Jiri Pirko wrote: >> >> Mon, Mar 06, 2023 at 07:37:31PM CET,

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Jiri Pirko
Tue, Mar 07, 2023 at 05:13:01PM CET, m...@redhat.com wrote: >On Tue, Mar 07, 2023 at 09:03:18AM +0100, Jiri Pirko wrote: >> I sense there is no concete idea about what the "admin virtqueue" should >> serve for exactly. > >Because the virtqueue is just a virtqueue - a way to pass around >commands.

[virtio-dev] Re: [virtio-comment] RE: [PATCH v3 0/2] virtio-net: Improve dev config layout

2023-03-08 Thread Cornelia Huck
On Tue, Mar 07 2023, Parav Pandit wrote: > Hi Cornelia, > >> -Original Message- >> From: Cornelia Huck >> Sent: Monday, March 6, 2023 9:32 AM >> To: Parav Pandit ; m...@redhat.com; virtio-dev@lists.oasis- >> open.org >> Cc: virtio-comm...@lists.oasis-open.org; Shahaf Shuler >> Subject:

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Jiri Pirko
Tue, Mar 07, 2023 at 05:30:18PM CET, m...@redhat.com wrote: >On Tue, Mar 07, 2023 at 08:36:41AM +0100, Jiri Pirko wrote: >> Hmm, if not for now, the future exension would not be so simple, I fear. > >Without knowing what it is I can't say. Yep, so basically you say, for other things if they appear

[virtio-dev] Re: [virtio] Re: [virtio-comment] [PATCH v10 00/10] Introduce device group and device management

2023-03-08 Thread Jiri Pirko
Tue, Mar 07, 2023 at 06:20:03PM CET, m...@redhat.com wrote: >On Tue, Mar 07, 2023 at 08:21:54AM +0100, Jiri Pirko wrote: >> Mon, Mar 06, 2023 at 11:54:45PM CET, m...@redhat.com wrote: >> >On Mon, Mar 06, 2023 at 01:29:30PM +0100, Jiri Pirko wrote: >> >> Thu, Mar 02, 2023 at 02:04:48PM CET, m...@red