Re: [virtio-dev][RFC 1/2] content: reserve virtio device ID

2016-06-24 Thread Cornelia Huck
On Fri, 24 Jun 2016 14:45:29 +0200 Christian Pinto wrote: > On Thu, Jun 23, 2016 at 8:57 PM, Stefan Hajnoczi > wrote: > > > On Fri, Jun 17, 2016 at 06:03:13PM +0200, Christian Pinto wrote: > > > @@ -2990,6 +2990,8 @@ Device ID & Virtio

[virtio-dev] Re: question on title page in oasis standards (was Re: [virtio] [PATCH] virtio-ring.h -> virtio-queue.h)

2016-02-16 Thread Cornelia Huck
On Tue, 16 Feb 2016 12:20:03 +0200 "Michael S. Tsirkin" wrote: > Chet, I have a question. > CS03 is the latest standard version. > > We released CSPRD05 for public review (concluded already), > so I'm assuming we will release CS04 afterwards. > > Should previous version link

[virtio-dev] [PATCH 0/2] virtio-ccw: new status accessor in device

2016-04-11 Thread Cornelia Huck
These patches implement the new read status command in qemu and bump the revision to 2 (as this ccw is currently the only thing new with that revision); see "[PATCH v2 1/1] ccw: add CCW_CMD_READ_STATUS" for details. Note that we'll need to add some compat machine handling when this is added (not

[virtio-dev] [PATCH 0/1] virtio_ccw: new status accessor in driver

2016-04-11 Thread Cornelia Huck
This patch implements the new status accessor in the ccw device, as laid out in "[PATCH v2 1/1] ccw: add CCW_CMD_READ_STATUS". Changes from the RFC (back in September): - rebased Pierre Morel (1): virtio/s390: support READ_STATUS command for virtio-ccw drivers/s390/virtio/virtio_ccw.c | 25

Re: [virtio-dev] [PATCH] vsock: reserve device ID

2016-03-23 Thread Cornelia Huck
/trunk/content.tex > +++ b/trunk/content.tex > @@ -2990,6 +2990,8 @@ Device ID & Virtio Device\\ > \hline > 18 & Input device \\ > \hline > +19 & Socket device \\ > +\hline > \end{tabular} > > Some of the

[virtio-dev] Re: [virtio] [PATCH v2 1/1] ccw: add CCW_CMD_READ_STATUS

2016-04-04 Thread Cornelia Huck
On Mon, 19 Oct 2015 10:31:53 +0200 Cornelia Huck <cornelia.h...@de.ibm.com> wrote: > ccw currently allows the driver to update the status via the > CCW_CMD_WRITE_STATUS command; however, it does not allow the driver to > retrieve the current status at the device, which is nee

[virtio-dev] [PATCH 1/4] vsock: reserve device ID

2016-08-03 Thread Cornelia Huck
; Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> Message-Id: <1458729661-7514-1-git-send-email-stefa...@redhat.com> Signed-off-by: Cornelia Huck <cornelia.h...@de.ibm.com> --- content.tex | 2 ++ 1 file changed, 2 insertions(+) diff --git a/content.tex b/content.tex

[virtio-dev] [PATCH 2/4] virtio: reserve device id for virtio crypto

2016-08-03 Thread Cornelia Huck
From: Gonglei <arei.gong...@huawei.com> Reserve a device ID for virtio crypto device to avoid collisions with other new virtio devices. Because 19 had been reserved for virtio socket device, I'd like to reserve 20 for crypto device. VIRTIO-148 Suggested-by: Cornelia Huck <c

[virtio-dev] [PATCH 4/4] content: Reserve virtio device ID for pstore

2016-08-03 Thread Cornelia Huck
hy...@gmail.com> Signed-off-by: Cornelia Huck <cornelia.h...@de.ibm.com> --- content.tex | 2 ++ 1 file changed, 2 insertions(+) diff --git a/content.tex b/content.tex index c426ed2..5afa68d 100644 --- a/content.tex +++ b/content.tex @@ -3004,6 +3004,8 @@ Device ID & Vir

[virtio-dev] Re: [PATCH v6 0/2] virtio-crypto: virtio crypto device specification

2016-08-03 Thread Cornelia Huck
On Wed, 3 Aug 2016 16:53:36 +0200 Cornelia Huck <cornelia.h...@de.ibm.com> wrote: > On Wed, 3 Aug 2016 17:40:07 +0300 > "Michael S. Tsirkin" <m...@redhat.com> wrote: > > > On Wed, Aug 03, 2016 at 04:33:28PM +0200, Cornelia Huck wrote: > > > On W

[virtio-dev] Re: [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

2016-08-09 Thread Cornelia Huck
On Mon, 8 Aug 2016 06:27:15 + "Zeng, Xin" wrote: > On Thu, Friday, August 05, 2016 3:56 AM, Michael S. Tsirkin wrote: > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Friday, August 05, 2016 3:56 AM > > To: Gonglei (Arei) > >

Re: [virtio-dev] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-07 Thread Cornelia Huck
On Tue, 7 Feb 2017 12:39:44 +0100 Halil Pasic wrote: > On 01/18/2017 09:22 AM, Gonglei wrote: > > +\section{Crypto Device}\label{sec:Device Types / Crypto Device} > > + > > +The virtio crypto device is a virtual cryptography device as well as a > > kind of > >

[virtio-dev] [PATCH 3/3] ccw: clarify indicator requirements

2017-02-13 Thread Cornelia Huck
ic <pa...@linux.vnet.ibm.com> Signed-off-by: Cornelia Huck <cornelia.h...@de.ibm.com> --- conformance.tex | 1 + content.tex | 6 ++ 2 files changed, 7 insertions(+) diff --git a/conformance.tex b/conformance.tex index ca08486..fe80201 100644 --- a/conformance.tex +++ b/conformance.

[virtio-dev] [PATCH 0/3] ccw: indicator handling

2017-02-13 Thread Cornelia Huck
A couple of fixes/enhancements for indicator handling in the ccw transport. Cornelia Huck (3): ccw: classic indicator device conformance ccw: no classic indicators for > 64 virtqueues ccw: clarify indicator requirements conformance.tex | 2 ++ content.tex | 12 2 fi

[virtio-dev] [PATCH 2/3] ccw: no classic indicators for > 64 virtqueues

2017-02-13 Thread Cornelia Huck
ic <pa...@linux.vnet.ibm.com> Signed-off-by: Cornelia Huck <cornelia.h...@de.ibm.com> --- content.tex | 5 + 1 file changed, 5 insertions(+) diff --git a/content.tex b/content.tex index 657b9cd..4abd4eb 100644 --- a/content.tex +++ b/content.tex @@ -2792,6 +2792,11 @@ If the driver has

[virtio-dev] [PATCH 1/3] ccw: classic indicator device conformance

2017-02-13 Thread Cornelia Huck
Morel <pmo...@linux.vnet.ibm.com> Signed-off-by: Cornelia Huck <cornelia.h...@de.ibm.com> --- conformance.tex | 1 + content.tex | 1 + 2 files changed, 2 insertions(+) diff --git a/conformance.tex b/conformance.tex index f59e360..ca08486 100644 --- a/conformance.tex +++ b/conform

Re: [virtio-dev] packed ring layout proposal v2

2017-02-09 Thread Cornelia Huck
On Thu, 9 Feb 2017 16:48:53 +0100 Paolo Bonzini wrote: > On 08/02/2017 20:59, Michael S. Tsirkin wrote: > > We couldn't decide what's better for everyone in 1.0 days and I doubt > > we'll be able to now, but yes, benchmarking is needed to make > > sire it's required. Very

Re: [virtio-dev] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-09 Thread Cornelia Huck
On Wed, 8 Feb 2017 03:46:53 + "Gonglei (Arei)" wrote: > Hi Cornelia, > > > > > On Tue, 7 Feb 2017 12:39:44 +0100 > > Halil Pasic wrote: > > > > > On 01/18/2017 09:22 AM, Gonglei wrote: > > > > > +The following services are defined: > > >

[virtio-dev] Re: [virtio] [PATCH 0/3] ccw: indicator handling

2017-02-16 Thread Cornelia Huck
On Mon, 13 Feb 2017 10:28:26 +0100 Cornelia Huck <cornelia.h...@de.ibm.com> wrote: > A couple of fixes/enhancements for indicator handling in the ccw > transport. > > Cornelia Huck (3): > ccw: classic indicator device conformance > ccw: no classic indicators for

Re: [virtio-dev] [PATCH v9] virtio-net: add Max MTU configuration field

2016-09-07 Thread Cornelia Huck
On Tue, 6 Sep 2016 10:31:01 -0400 Aaron Conole wrote: > diff --git a/content.tex b/content.tex > index 4b45678..b90cbad 100644 > --- a/content.tex > +++ b/content.tex > @@ -3049,6 +3049,14 @@ features. > \item[VIRTIO_NET_F_CTRL_GUEST_OFFLOADS (2)] Control channel offloads

Re: [virtio-dev] Re: [PATCH v10] virtio-net: add Max MTU configuration field

2016-09-14 Thread Cornelia Huck
On Wed, 14 Sep 2016 00:17:28 +0300 "Michael S. Tsirkin" wrote: > On Tue, Sep 13, 2016 at 11:18:12AM -0400, Aaron Conole wrote: (...) > > If negotiated, the driver uses \field{mtu} as > > +the maximum MTU value supplied to the driver. > > Drop "supplied to the driver"

[virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Cornelia Huck
On Mon, 28 Nov 2016 20:08:23 +0800 Gonglei wrote: > +static int virtcrypto_update_status(struct virtio_crypto *vcrypto) > +{ > + u32 status; > + int err; > + > + virtio_cread(vcrypto->vdev, > + struct virtio_crypto_config, status, ); > + > + /*

[virtio-dev] Re: [Qemu-devel] [PATCH v14 1/2] virtio-crypto: Add virtio crypto device specification

2016-11-21 Thread Cornelia Huck
On Sun, 20 Nov 2016 08:45:57 + gong lei wrote: > On 2016/11/17 2:11, Halil Pasic wrote: > > On 11/11/2016 10:23 AM, Gonglei wrote: > >> +The value of the \field{status} field is VIRTIO_CRYPTO_S_HW_READY or > >> VIRTIO_CRYPTO_S_STARTED. > >> + > >>

[virtio-dev] Re: [Qemu-devel] [PATCH v9 00/12] virtio-crypto: introduce framework and device emulation

2016-10-31 Thread Cornelia Huck
On Mon, 31 Oct 2016 02:52:32 + "Gonglei (Arei)" wrote: > > From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] > > Sent: Monday, October 31, 2016 4:00 AM > > Subject: Re: [Qemu-devel] [PATCH v9 00/12] virtio-crypto: introduce > > framework > > and device emulation >

[virtio-dev] Re: [virtio] [PATCH RFC] Clarify FAILED status handling

2016-11-30 Thread Cornelia Huck
On Wed, 30 Nov 2016 16:57:16 +0100 Jan Kiszka <jan.kis...@siemens.com> wrote: > On 2016-11-30 16:34, Cornelia Huck wrote: > > We did not give any guidance before what the device is supposed to > > do if the driver set the FAILED status bit. Instruct the device to >

[virtio-dev] virtio-blk: What's up with VIRTIO_BLK_T_GET_ID (8)?

2017-04-21 Thread Cornelia Huck
I see the request type in $SUBJECT implemented in both Linux and QEMU, but I can't find it in the standard. If we believe that getting a s/n is useful, we should spec it; otherwise, if we consider it just a legacy request type, it wouldn't hurt to mention it in the legacy section.

Re: [virtio-dev] packed ring layout proposal v2

2017-03-07 Thread Cornelia Huck
On Wed, 22 Feb 2017 18:43:05 +0200 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Thu, Feb 09, 2017 at 05:11:05PM +0100, Cornelia Huck wrote: > > > >>> * Non power-of-2 ring sizes > > > >>> > > > >>> As the ring simply w

Re: [virtio-dev] [PATCH] virtio-net: fix virtqueue numbering error

2017-07-12 Thread Cornelia Huck
On Wed, 12 Jul 2017 10:35:20 +0100 Stefan Hajnoczi <stefa...@redhat.com> wrote: > On Tue, Jul 11, 2017 at 01:51:29PM +0200, Cornelia Huck wrote: > > receiveq(n) is at position 2(n-1)+1. Same error for transmitq(n) > > and controlq. > > > > VIRTIO-161 > >

[virtio-dev] [PATCH v2] virtio-net: fix virtqueue numbering error

2017-07-12 Thread Cornelia Huck
receiveq(n) is at position 2(n-1), not 2n. Same error for transmitq(n) and controlq. VIRTIO-161 Signed-off-by: Cornelia Huck <coh...@redhat.com> --- v1->v2: fix description use 2N for controlq [Stefan] --- content.tex | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[virtio-dev] [PATCH] virtio-net: fix virtqueue numbering error

2017-07-11 Thread Cornelia Huck
receiveq(n) is at position 2(n-1)+1. Same error for transmitq(n) and controlq. VIRTIO-161 Signed-off-by: Cornelia Huck <coh...@redhat.com> --- content.tex | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/content.tex b/content.tex index d8bde3a..2319729

Re: [virtio-dev] Re: virtio crypto device implemenation

2017-05-24 Thread Cornelia Huck
On Wed, 24 May 2017 04:13:47 +0300 "Michael S. Tsirkin" wrote: > On Tue, May 23, 2017 at 04:08:25PM +, Zeng, Xin wrote: > > Hi, Michael, > >As you know, Lei Gong from Huawei and I are co-working on virtio crypto > > device spec, he is focusing on symmetric algorithm

[virtio-dev] Re: [Qemu-devel] [virtio-dev] [PATCH v3 2/7] vhost-pci-net: add vhost-pci-net

2017-12-05 Thread Cornelia Huck
On Tue, 5 Dec 2017 18:53:29 +0200 "Michael S. Tsirkin" wrote: > On Tue, Dec 05, 2017 at 04:41:54PM +, Stefan Hajnoczi wrote: > > On Tue, Dec 05, 2017 at 05:55:45PM +0200, Michael S. Tsirkin wrote: > > > On Tue, Dec 05, 2017 at 02:59:50PM +, Stefan Hajnoczi wrote: > >

[virtio-dev] Re: [PATCH v1] content: reserve virtio device ID for memory devices

2018-04-27 Thread Cornelia Huck
; +\hline > \end{tabular} > > Some of the devices above are unspecified by this document, Acked-by: Cornelia Huck <coh...@redhat.com> - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org

Re: [virtio-dev] [RFC] content: support SR-IOV

2018-05-18 Thread Cornelia Huck
On Fri, 18 May 2018 15:38:55 +0800 Tiwei Bie wrote: > Reserve a feature bit for virtio devices which support SR-IOV. Reserving a feature bit for this makes sense, but... > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Tiwei Bie

[virtio-dev] Re: [PATCH v3] content: support SR-IOV

2018-05-22 Thread Cornelia Huck
/github.com/oasis-tcs/virtio-spec/issues/11 Reviewed-by: Cornelia Huck <coh...@redhat.com> - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org

[virtio-dev] Re: [PATCH v2] content: support SR-IOV

2018-05-22 Thread Cornelia Huck
On Tue, 22 May 2018 12:56:23 +0800 Tiwei Bie wrote: > Allocate a feature bit for virtio devices which support SR-IOV. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Tiwei Bie > Fixes:

[virtio-dev] Re: [PATCH] content: enhance device requirements for feature bits

2018-06-11 Thread Cornelia Huck
On Fri, 8 Jun 2018 19:05:30 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jun 08, 2018 at 09:36:17AM +0200, Cornelia Huck wrote: > > On Fri, 8 Jun 2018 14:59:28 +0800 > > Tiwei Bie wrote: > > > > > Suggested-by: Michael S. Tsirkin > >

[virtio-dev] Re: [PATCH v3] content: enhance device requirements for feature bits

2018-06-11 Thread Cornelia Huck
s}\label{sec:Basic Facilities of a Virtio Device / Feature > Bits / Legacy Interface: A Note on Feature Bits} Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org

[virtio-dev] Re: [PATCH v3] content: enhance device requirements for feature bits

2018-06-11 Thread Cornelia Huck
On Mon, 11 Jun 2018 16:24:51 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jun 11, 2018 at 03:56:40PM +0800, Tiwei Bie wrote: > > Suggested-by: Michael S. Tsirkin > > Signed-off-by: Tiwei Bie > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14 > > --- > > v2: > > - Refine the wording

[virtio-dev] Re: [PATCH v3] content: document SR-IOV driver requirements

2018-06-12 Thread Cornelia Huck
d Feature Bits}{Reserved Feature Bits} > > A device MUST offer VIRTIO_F_VERSION_1. A device MAY fail to operate further I still think we should mention somewhere that this "enable just once" mechanism is useful for e.g. resuming; but this is fine as-is. Reviewed-by: Corne

[virtio-dev] Re: [PATCH v2] content: enhance device requirements for feature bits

2018-06-08 Thread Cornelia Huck
t SHOULD NOT fail re-negotiation of the same set of features > +after a device or system reset. Failure to do so would > +interfere with resuming from suspend and error recovery. > + > \subsection{Legacy Interface: A Note on Feature > Bits}\label{sec:Basic Facilities of a Virtio Device

[virtio-dev] Re: [PATCH v2] content: document SR-IOV driver requirements

2018-06-08 Thread Cornelia Huck
On Fri, 8 Jun 2018 19:14:49 +0800 Tiwei Bie wrote: > On Fri, Jun 08, 2018 at 11:12:31AM +0200, Cornelia Huck wrote: > > On Fri, 8 Jun 2018 10:07:01 +0800 > > Tiwei Bie wrote: > > > > > Document the driver requirements for the VIRTIO_F_SR_IOV > > &

[virtio-dev] Re: [PATCH v2] content: document SR-IOV driver requirements

2018-06-08 Thread Cornelia Huck
On Fri, 8 Jun 2018 15:13:11 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jun 08, 2018 at 11:12:31AM +0200, Cornelia Huck wrote: > > On Fri, 8 Jun 2018 10:07:01 +0800 > > Tiwei Bie wrote: > > > > > Document the driver requirements f

[virtio-dev] Re: [PATCH v2] content: document SR-IOV driver requirements

2018-06-08 Thread Cornelia Huck
On Fri, 8 Jun 2018 10:07:01 +0800 Tiwei Bie wrote: > Document the driver requirements for the VIRTIO_F_SR_IOV > feature bit. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Tiwei Bie > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/13 > --- > v2: > - Fix the commit message

[virtio-dev] Re: [PATCH] content: enhance device requirements for feature bits

2018-06-08 Thread Cornelia Huck
On Fri, 8 Jun 2018 14:59:28 +0800 Tiwei Bie wrote: > Suggested-by: Michael S. Tsirkin > Signed-off-by: Tiwei Bie > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14 > --- > content.tex | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/content.tex b/content.tex > index

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-14 Thread Cornelia Huck
I've been pointed to this discussion (which I had missed previously) and I'm getting a headache. Let me first summarize how I understand how this feature is supposed to work, then I'll respond to some individual points. The basic idea is to enable guests to migrate seamlessly, while still making

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-18 Thread Cornelia Huck
On Fri, 15 Jun 2018 15:31:43 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jun 15, 2018 at 11:32:42AM +0200, Cornelia Huck wrote: > > On Fri, 15 Jun 2018 05:34:24 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Jun

[virtio-dev] Re: [PATCH v2 4/6] pci: map common notifications terminology to PCI

2018-06-13 Thread Cornelia Huck
. > > Let's make the relationship between the PCI terms and the common > terms more obvious. > > Signed-off-by: Halil Pasic > --- > conformance.tex |2 +- > content.tex | 13 +++-- > 2 files changed, 8 insertions(+), 7 d

[virtio-dev] Re: [PATCH v2 5/6] mmio: map common notifications terminology to MMIO

2018-06-13 Thread Cornelia Huck
On Mon, 11 Jun 2018 18:11:57 +0200 Halil Pasic wrote: > The various notifications are introduced and specified in the common > (i.e. transport agnostic) portion of this specification. How > notifications are realised for a given transport is something each > transport has to specify. > > Let's

[virtio-dev] Re: [PATCH v2 6/6] notifications: update notifications terminology for devices

2018-06-13 Thread Cornelia Huck
d-off-by: Halil Pasic > --- > content.tex | 22 +++--- > 1 files changed, 11 insertions(+), 11 deletions(-) Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-15 Thread Cornelia Huck
On Thu, 14 Jun 2018 18:57:11 -0700 Siwei Liu wrote: > Thank you for sharing your thoughts, Cornelia. With questions below, I > think you raised really good points, some of which I don't have answer > yet and would also like to explore here. > > First off, I don't want to push the discussion to

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-15 Thread Cornelia Huck
On Fri, 15 Jun 2018 05:34:24 +0300 "Michael S. Tsirkin" wrote: > On Thu, Jun 14, 2018 at 12:02:31PM +0200, Cornelia Huck wrote: > > > > I am not all that familiar with how Qemu manages network devices. If we > > > > can > > > > do all the &

[virtio-dev] Re: [PATCH v4] content: support SR-IOV

2018-05-29 Thread Cornelia Huck
ixes tag (MST); > - Be more explicit in driver requirement (MST); > - Remove the "device MAY fail" description (MST); > - Rebase on IO_BARRIER patch; > > RFC -> v1: > - Mention PCI in the description (Cornelia); > > content.tex | 2

Re: [virtio-dev] [PATCH] virtio: update the comments for transport features

2018-06-01 Thread Cornelia Huck
On Fri, 1 Jun 2018 18:22:17 +0800 Tiwei Bie wrote: > Suggested-by: Michael S. Tsirkin > Signed-off-by: Tiwei Bie > --- > This patch is generated on top of below patch: > https://lists.oasis-open.org/archives/virtio-dev/201805/msg00212.html > > include/uapi/linux/virtio_config.h | 9

[virtio-dev] Re: [PATCH v2] virtio: update the comments for transport features

2018-06-01 Thread Cornelia Huck
/* > + * Virtio feature bits VIRTIO_TRANSPORT_F_START through > + * VIRTIO_TRANSPORT_F_END are reserved for the transport > + * being used (e.g. virtio_ring, virtio_pci etc.), the > + * rest are per-device feature bits. > + */ > #define VIRTIO

[virtio-dev] Re: [PATCH v3 1/6] notifications: unify notifications wording in core

2018-06-25 Thread Cornelia Huck
ed. Device can then trigger > -a device event - i.e. send an interrupt to the driver. > +a device event - i.e. send a used buffer notification to the driver. > > Device reports the number of bytes it has written to memory for > each buffer it uses. This is referred to as ``used len

[virtio-dev] Re: [PATCH v3 2/6] notifications: notifications as basic virtio facility

2018-06-25 Thread Cornelia Huck
+++ > 1 files changed, 36 insertions(+), 0 deletions(-) Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org

[virtio-dev] Re: [PATCH v3 5/6] mmio: map common notifications terminology to MMIO

2018-06-25 Thread Cornelia Huck
hanged, 13 insertions(+), 12 deletions(-) Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Cornelia Huck
On Tue, 26 Jun 2018 04:50:25 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jun 25, 2018 at 10:54:09AM -0700, Samudrala, Sridhar wrote: > > > > > > Might not neccessarily be something wrong, but it's very limited to > > > > > > prohibit the MAC of VF from changing when enslaved by failover. > > >

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Cornelia Huck
On Tue, 26 Jun 2018 18:38:51 +0300 "Michael S. Tsirkin" wrote: > On Tue, Jun 26, 2018 at 05:17:32PM +0200, Cornelia Huck wrote: > > On Tue, 26 Jun 2018 04:50:25 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Jun 25,

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Cornelia Huck
On Fri, 22 Jun 2018 17:05:04 -0700 Siwei Liu wrote: > On Fri, Jun 22, 2018 at 3:33 PM, Michael S. Tsirkin wrote: > > I suspect the diveregence will be lost on most users though > > simply because they don't even care about vfio. They just > > want things to go fast. > > Like Jason said, VF

Re: [virtio-dev] Re: [RFC] content: tweak VIRTIO_F_IO_BARRIER

2018-06-27 Thread Cornelia Huck
On Tue, 26 Jun 2018 21:39:22 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jun 27, 2018 at 02:19:22AM +0800, Tiwei Bie wrote: > > On Tue, Jun 26, 2018 at 03:47:28PM +0200, Halil Pasic wrote: > > > On 06/25/2018 09:19 PM, Michael S. Tsirkin wrote: > > > > On Mon, Jun 25, 2018 at 08:24:42PM

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-25 Thread Cornelia Huck
On Fri, 22 Jun 2018 22:05:50 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jun 22, 2018 at 05:09:55PM +0200, Cornelia Huck wrote: > > On Thu, 21 Jun 2018 21:20:13 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Jun 21, 2018 at 04:59

Re: [virtio-dev] [PATCH v3] content: enhance device requirements for feature bits

2018-06-20 Thread Cornelia Huck
On Wed, 20 Jun 2018 00:30:59 +0800 Tiwei Bie wrote: > On Tue, Jun 19, 2018 at 12:46:45PM +0200, Halil Pasic wrote: > > On 06/19/2018 11:14 AM, Tiwei Bie wrote: > > > On Mon, Jun 18, 2018 at 07:28:33PM +0300, Michael S. Tsirkin wrote: > [...] > > > > > > If it would be better to drop this

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-27 Thread Cornelia Huck
On Sat, 23 Jun 2018 00:43:24 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jun 22, 2018 at 05:09:55PM +0200, Cornelia Huck wrote: > > Would it be more helpful to focus on generic > > migration support for vfio instead of going about it device by device? >

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-27 Thread Cornelia Huck
On Tue, 26 Jun 2018 20:50:20 +0300 "Michael S. Tsirkin" wrote: > On Tue, Jun 26, 2018 at 05:08:13PM +0200, Cornelia Huck wrote: > > On Fri, 22 Jun 2018 17:05:04 -0700 > > Siwei Liu wrote: > > > > > On Fri, Jun 22, 2018 at 3:33 PM, Michael S. Ts

Re: [virtio-dev] Re: [PATCH v2 0/4] Use of unique identifier for pairing virtio and passthrough devices...

2018-06-27 Thread Cornelia Huck
On Wed, 27 Jun 2018 07:06:42 +0300 "Michael S. Tsirkin" wrote: > On Tue, Jun 26, 2018 at 10:49:30PM -0500, Venu Busireddy wrote: > > The patch set "Enable virtio_net to act as a standby for a passthru > > device" [1] deals with live migration of guests that use passthrough > > devices. However,

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Cornelia Huck
On Tue, 26 Jun 2018 04:46:03 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jun 25, 2018 at 11:55:12AM +0200, Cornelia Huck wrote: > > On Fri, 22 Jun 2018 22:05:50 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Fri, Jun 22, 2018 at 05:09:55P

[virtio-dev] Re: [virtio] [PATCH v6 4/5] packed virtqueues: more efficient virtqueue layout

2018-01-10 Thread Cornelia Huck
On Wed, 10 Jan 2018 11:47:58 +0200 "Michael S. Tsirkin" wrote: > Performance analysis of this is in my kvm forum 2016 presentation. The > idea is to have a r/w descriptor in a ring structure, replacing the used > and available ring, index and descriptor buffer. > > This is

[virtio-dev] Re: [virtio] [PATCH RFC] content: generalize transport ring part naming

2018-01-10 Thread Cornelia Huck
On Wed, 10 Jan 2018 17:05:40 +0200 "Michael S. Tsirkin" wrote: > Replace descriptor table/available ring/used ring > with descriptor area/driver area/device area > in all transports. > > Document what's in which area for each format. > > Signed-off-by: Michael S. Tsirkin

[virtio-dev] Re: [virtio] [PATCH v6 0/5] packed ring layout spec

2018-01-10 Thread Cornelia Huck
On Wed, 10 Jan 2018 11:47:53 +0200 "Michael S. Tsirkin" wrote: > OK, this is in a shape where we could include it in the spec. > Changes from v5: > - scope reductions (see below). We can add more > features down the road, hopefully reduced scope will be enough > to finalize

[virtio-dev] Re: [virtio] [PATCH v6 0/5] packed ring layout spec

2018-01-10 Thread Cornelia Huck
On Wed, 10 Jan 2018 13:10:49 +0200 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Wed, Jan 10, 2018 at 11:33:15AM +0100, Cornelia Huck wrote: > > On Wed, 10 Jan 2018 11:47:53 +0200 > > "Michael S. Tsirkin" <m...@redhat.com> wrote: > >

[virtio-dev] Re: [virtio] [PATCH v6 2/5] content: move ring text out to a separate file

2018-01-10 Thread Cornelia Huck
> split-ring.tex | 498 > 2 files changed, 499 insertions(+), 498 deletions(-) > create mode 100644 split-ring.tex Makes sense. Acked-by: Cornelia Huck <coh...@redhat.com> -

[virtio-dev] Re: [virtio] [PATCH v6 3/5] content: move virtqueue operation description

2018-01-10 Thread Cornelia Huck
dhat.com> > --- > conformance.tex | 4 +- > content.tex | 171 > +++- > split-ring.tex | 168 +++ > 3 files changed, 178 insertions(+), 165 d

[virtio-dev] Re: [virtio] [PATCH v6 1/5] content: move 1.0 queue format out to a separate section

2018-01-10 Thread Cornelia Huck
On Wed, 10 Jan 2018 11:47:55 +0200 "Michael S. Tsirkin" wrote: > Signed-off-by: Michael S. Tsirkin > --- > content.tex | 25 - > 1 file changed, 24 insertions(+), 1 deletion(-) > > diff --git a/content.tex b/content.tex > index

[virtio-dev] Re: [virtio] [PATCH v6 4/5] packed virtqueues: more efficient virtqueue layout

2018-01-10 Thread Cornelia Huck
On Wed, 10 Jan 2018 11:47:58 +0200 "Michael S. Tsirkin" wrote: > Performance analysis of this is in my kvm forum 2016 presentation. The > idea is to have a r/w descriptor in a ring structure, replacing the used > and available ring, index and descriptor buffer. Do we have a

[virtio-dev] Re: [virtio] [PATCH v7 08/11] packed virtqueues: more efficient virtqueue layout

2018-01-30 Thread Cornelia Huck
On Tue, 23 Jan 2018 02:01:07 +0200 "Michael S. Tsirkin" wrote: > Performance analysis of this is in my kvm forum 2016 presentation. The > idea is to have a r/w descriptor in a ring structure, replacing the used > and available ring, index and descriptor buffer. > > This is

[virtio-dev] Re: [virtio] [PATCH v7 09/11] content: in-order buffer use

2018-02-01 Thread Cornelia Huck
patches. > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > --- > content.tex | 15 +++ > 1 file changed, 15 insertions(+) Reviewed-by: Cornelia Huck <coh...@redhat.com> - To unsubscribe,

[virtio-dev] Re: [virtio] [PATCH v7 10/11] packed-ring: add in order support

2018-02-02 Thread Cornelia Huck
> > --- > packed-ring.tex | 24 > 1 file changed, 24 insertions(+) Reviewed-by: Cornelia Huck <coh...@redhat.com> - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org

[virtio-dev] Re: [virtio] [PATCH v7 11/11] split-ring: in order feature

2018-02-02 Thread Cornelia Huck
+ > \subsubsection{Indirect Descriptors}\label{sec:Basic Facilities of a Virtio > Device / Virtqueues / The Virtqueue Descriptor Table / Indirect Descriptors} > > Some devices benefit by concurrently dispatching a large number Otherwise, Reviewed-by: Cornelia Huck <coh...@redhat.com&

Re: [virtio-dev] Re: [virtio] [PATCH v7 08/11] packed virtqueues: more efficient virtqueue layout

2018-02-01 Thread Cornelia Huck
On Thu, 1 Feb 2018 11:05:35 +0800 Tiwei Bie <tiwei@intel.com> wrote: > On Tue, Jan 30, 2018 at 09:40:35PM +0200, Michael S. Tsirkin wrote: > > On Tue, Jan 30, 2018 at 02:50:44PM +0100, Cornelia Huck wrote: > > > On Tue, 23 Jan 2018 02:01:07 +0200 > > > &quo

[virtio-dev] Re: [virtio] [PATCH v7 05/11] content: generalize transport ring part naming

2018-01-30 Thread Cornelia Huck
: Michael S. Tsirkin <m...@redhat.com> > --- > content.tex| 61 > ++ > split-ring.tex | 6 +++--- > 2 files changed, 43 insertions(+), 24 d

[virtio-dev] Re: [virtio] [PATCH v7 04/11] content: replace mentions of len with used length

2018-01-30 Thread Cornelia Huck
On Tue, 23 Jan 2018 02:01:03 +0200 "Michael S. Tsirkin" wrote: > Document buffer used len and use that terminology everywhere in the > generic section. > > Signed-off-by: Michael S. Tsirkin > --- > content.tex | 39 --- > 1

[virtio-dev] Re: [virtio] [PATCH v7 07/11] split-ring: generalize text

2018-01-30 Thread Cornelia Huck
On Tue, 23 Jan 2018 02:01:06 +0200 "Michael S. Tsirkin" wrote: > Update generic text to talk about available/used buffers, not rings. > Move some split-ring specific text to the correct section. > > Signed-off-by: Michael S. Tsirkin > --- > content.tex|

[virtio-dev] Re: [virtio] [PATCH v7 02/11] content: move ring text out to a separate file

2018-01-30 Thread Cornelia Huck
> split-ring.tex | 498 > 2 files changed, 499 insertions(+), 498 deletions(-) > create mode 100644 split-ring.tex Reviewed-by: Cornelia Huck <coh...@redhat.com> -

[virtio-dev] Re: [virtio] [PATCH v7 03/11] content: move virtqueue operation description

2018-01-30 Thread Cornelia Huck
d when making a buffer available > and when marking it as used. > > - Dito here (should probably go to a prior patch). > Each queue has a 16-bit queue size > parameter, which sets the number of entries and implies the total size > of the queue. Else: Reviewed-by: Cornelia Huck

Re: [virtio-dev] Re: [virtio] [PATCH v7 08/11] packed virtqueues: more efficient virtqueue layout

2018-02-05 Thread Cornelia Huck
On Mon, 5 Feb 2018 18:00:07 +0100 Paolo Bonzini wrote: > On 05/02/2018 17:57, Halil Pasic wrote: > >> This is certainly not how we did it for v1.0, and not how > >> oasis process works generally. Implementations are required > >> to move to an oasis standard change. We are

[virtio-dev] Re: [virtio] Re: [virtio-dev] Re: [virtio] [PATCH v7 01/11] content: move 1.0 queue format out to a separate section

2018-02-06 Thread Cornelia Huck
On Tue, 6 Feb 2018 12:10:20 +0100 Halil Pasic wrote: > On 02/06/2018 01:05 AM, Michael S. Tsirkin wrote: > > On Mon, Feb 05, 2018 at 11:54:52PM +0100, Halil Pasic wrote: > >> > >> > >> On 01/23/2018 01:01 AM, Michael S. Tsirkin wrote: > >>> Signed-off-by: Michael S.

[virtio-dev] Re: [PATCH 1/2] ccw: be more precise the semantic of revision 1

2018-02-12 Thread Cornelia Huck
&& legacy interface; transitional devices only > \\ > \hline > -1& 0 && Virtio 1.0 \\ > +1& 0 & & Virtio 1 \\ > \hline > 2& 0 && CCW_CMD_READ_STATUS support \\ > \hline

[virtio-dev] Re: [PATCH 2/2] introduction: simplify the designation of legacy

2018-02-12 Thread Cornelia Huck
eceding version 1.0 of this specification > +(e.g. see \hyperref[intro:Virtio PCI Draft]{[Virtio PCI Draft]}) > defined a similar, but different > interface between the driver and the device. > Since these are widely deployed, this specification Reviewed-by: Cornelia Huck <coh...@red

[virtio-dev] Re: [PATCH 0/2] two versioning related changes

2018-02-12 Thread Cornelia Huck
On Fri, 9 Feb 2018 22:43:23 +0200 "Michael S. Tsirkin" wrote: > On Fri, Feb 09, 2018 at 08:59:12PM +0100, Halil Pasic wrote: > > Regarding patch #1 please see also: > > https://lists.oasis-open.org/archives/virtio/201802/msg00018.html > > Fine by me. Can you please open an

[virtio-dev] Re: [PATCH v2 0/2] two versioning related changes

2018-02-13 Thread Cornelia Huck
On Tue, 13 Feb 2018 13:44:06 +0100 Halil Pasic wrote: > v1->v2: > * fixed ungrammatical commit title for #1 > * added r-b's > * added bug tracker references > > Halil Pasic (2): > ccw: be more precise about the semantic of revision 1 > introduction: simplify the

[virtio-dev] Re: [virtio] [PATCH v7 01/11] content: move 1.0 queue format out to a separate section

2018-02-06 Thread Cornelia Huck
On Tue, 6 Feb 2018 02:05:11 +0200 "Michael S. Tsirkin" wrote: > On Mon, Feb 05, 2018 at 11:54:52PM +0100, Halil Pasic wrote: > > > > > > On 01/23/2018 01:01 AM, Michael S. Tsirkin wrote: > > > +\section{Split Virtqueues}\label{sec:Basic Facilities of a Virtio Device > > >

Re: [virtio-dev] Re: [virtio] [PATCH v7 08/11] packed virtqueues: more efficient virtqueue layout

2018-02-05 Thread Cornelia Huck
On Mon, 5 Feb 2018 20:21:12 +0200 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Mon, Feb 05, 2018 at 07:16:54PM +0100, Cornelia Huck wrote: > > > I agree that this doesn't seem optimal. This is a much bigger change > > > than anything between virtio 0.9

[virtio-dev] Re: [PATCH v8 12/16] makediff: update to show diff from master

2018-02-16 Thread Cornelia Huck
On Fri, 16 Feb 2018 09:25:40 +0200 "Michael S. Tsirkin" wrote: > Signed-off-by: Michael S. Tsirkin > --- > makediff.sh | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/makediff.sh b/makediff.sh > index 1dd75d4..2ef92fc 100755 > ---

[virtio-dev] Re: [PATCH v8 14/16] VIRTIO_F_NOTIFICATION_DATA: extra data to devices

2018-02-16 Thread Cornelia Huck
On Fri, 16 Feb 2018 09:26:22 +0200 "Michael S. Tsirkin" wrote: > Motivation for the new feature is included in the text. > > Signed-off-by: Michael S. Tsirkin > --- > content.tex | 136 > +--- > 1 file

[virtio-dev] Re: [PATCH v8 04/16] content: replace mentions of len with used length

2018-02-16 Thread Cornelia Huck
gt; Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > --- > content.tex | 39 --- > 1 file changed, 20 insertions(+), 19 deletions(-) Reviewed-by: Cornelia Huck <coh...@redhat.com> ---

[virtio-dev] Re: [PATCH v8 00/16] packed ring layout spec

2018-02-16 Thread Cornelia Huck
On Fri, 16 Feb 2018 09:20:50 +0200 "Michael S. Tsirkin" wrote: > This addresses comments on v7. A compiled version can > be found under https://github.com/oasis-tcs/virtio-docs.git > > virtio-v1.1-packed-wd08-diff.pdf virtio-v1.1-packed-wd08.pdf > > for redline and clean

[virtio-dev] Re: [PATCH v8 15/16] conformance: link the new conformance clause

2018-02-16 Thread Cornelia Huck
On Fri, 16 Feb 2018 09:26:43 +0200 "Michael S. Tsirkin" wrote: > Signed-off-by: Michael S. Tsirkin > --- > conformance.tex | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/conformance.tex b/conformance.tex > index 55d17b4..e4efe33 100644 > ---

[virtio-dev] Re: [PATCH v8 16/16] REVISION: set for packed-wd07.pdf

2018-02-16 Thread Cornelia Huck
On Fri, 16 Feb 2018 09:27:04 +0200 "Michael S. Tsirkin" wrote: > Signed-off-by: Michael S. Tsirkin > --- > REVISION | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/REVISION b/REVISION > index cff9c21..c1f9103 100644 > --- a/REVISION >

  1   2   3   4   5   6   7   >