[RFC v2 5/5] virtio/vsock: add sysfs for rx buf len for dgram

2021-09-13 Thread Jiang Wang
Make rx buf len configurable via sysfs Signed-off-by: Jiang Wang --- net/vmw_vsock/virtio_transport.c | 46 ++-- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c index 8d5bfcd79555

[RFC v2 4/5] vsock_test: add tests for vsock dgram

2021-09-13 Thread Jiang Wang
Added test cases for vsock dgram types. Signed-off-by: Jiang Wang --- tools/testing/vsock/util.c | 105 + tools/testing/vsock/util.h | 4 + tools/testing/vsock/vsock_test.c | 195 +++ 3 files changed, 304 insertions(+) diff --git

[RFC v2 3/5] vhost/vsock: add support for vhost dgram.

2021-09-13 Thread Jiang Wang
This patch supports dgram on vhost side, including tx and rx. The vhost send packets asynchronously. Also, ignore vq errors when vq number is larger than 2, so it will be comptaible with old versions. Signed-off-by: Jiang Wang --- drivers/vhost/vsock.c | 217

[RFC v2 2/5] virtio/vsock: add support for virtio datagram

2021-09-13 Thread Jiang Wang
for it. Support for the host/device side is in another patch. Signed-off-by: Jiang Wang --- include/net/af_vsock.h| 1 + .../events/vsock_virtio_transport_common.h| 2 + include/uapi/linux/virtio_vsock.h | 1 + net/vmw_vsock/af_vsock.c | 12

[RFC v2 1/5] virtio/vsock: add VIRTIO_VSOCK_F_DGRAM feature bit

2021-09-13 Thread Jiang Wang
When this feature is enabled, allocate 5 queues, otherwise, allocate 3 queues to be compatible with old QEMU versions. Signed-off-by: Jiang Wang --- drivers/vhost/vsock.c | 3 +- include/linux/virtio_vsock.h | 9 include/uapi/linux/virtio_vsock.h | 2 + net/vmw_vsock

[RFC v2 0/5] virtio/vsock: introduce SOCK_DGRAM support

2021-09-13 Thread Jiang Wang
ode in virtio-vsock - use le_to_cpu16 in virtio-vsock Jiang Wang (5): virtio/vsock: add VIRTIO_VSOCK_F_DGRAM feature bit virtio/vsock: add support for virtio datagram vhost/vsock: add support for vhost dgram. vsock_test: add tests for vsock dgram virtio/vsock: add sysfs for rx buf len for dg

Re: [virtio-comment] Re: [PATCH v5] virtio-vsock: add description for datagram type

2021-09-02 Thread Jiang Wang .
On Thu, Sep 2, 2021 at 7:07 AM Stefan Hajnoczi wrote: > > On Thu, Jun 10, 2021 at 06:12:03PM +, Jiang Wang wrote: > > Add supports for datagram type for virtio-vsock. Datagram > > sockets are connectionless and unreliable. To avoid contention > > with stream and oth

Re: [External] Re: [virtio-comment] [PATCH v5] virtio-vsock: add description for datagram type

2021-08-31 Thread Jiang Wang .
On Tue, Aug 31, 2021 at 6:13 PM Michael S. Tsirkin wrote: > > On Thu, Jun 10, 2021 at 06:12:03PM +, Jiang Wang wrote: > > Add supports for datagram type for virtio-vsock. Datagram > > sockets are connectionless and unreliable. To avoid contention > > with stream an

Re: [External] Re: [RFC v1 3/6] vhost/vsock: add support for vhost dgram.

2021-06-21 Thread Jiang Wang .
On Fri, Jun 18, 2021 at 3:14 AM Stefano Garzarella wrote: > > We should use le16_to_cpu when accessing pkt->hdr fields. OK. Will do. > On Wed, Jun 09, 2021 at 11:24:55PM +, Jiang Wang wrote: > >This patch supports dgram on vhost side, including > >tx and rx

Re: [External] Re: [RFC v1 6/6] virtio/vsock: add sysfs for rx buf len for dgram

2021-06-21 Thread Jiang Wang .
On Fri, Jun 18, 2021 at 3:04 AM Stefano Garzarella wrote: > > On Wed, Jun 09, 2021 at 11:24:58PM +, Jiang Wang wrote: > >Make rx buf len configurable via sysfs > > > >Signed-off-by: Jiang Wang > >--- > > net/vmw_vsock/virtio_transport.c | 37

Re: [External] Re: [RFC v1 5/6] vhost/vsock: add kconfig for vhost dgram support

2021-06-21 Thread Jiang Wang .
On Fri, Jun 18, 2021 at 2:54 AM Stefano Garzarella wrote: > > On Wed, Jun 09, 2021 at 11:24:57PM +, Jiang Wang wrote: > >Also change number of vqs according to the config > > > >Signed-off-by: Jiang Wang > >--- > > drivers/vhost/Kconfig | 8 +++

Re: [External] Re: [RFC v1 1/6] virtio/vsock: add VIRTIO_VSOCK_F_DGRAM feature bit

2021-06-21 Thread Jiang Wang .
On Fri, Jun 18, 2021 at 2:40 AM Stefano Garzarella wrote: > > On Wed, Jun 09, 2021 at 11:24:53PM +, Jiang Wang wrote: > >When this feature is enabled, allocate 5 queues, > >otherwise, allocate 3 queues to be compatible with > >old QEMU versions. > >

Re: [External] Re: [RFC v1 0/6] virtio/vsock: introduce SOCK_DGRAM support

2021-06-21 Thread Jiang Wang .
On Fri, Jun 18, 2021 at 2:35 AM Stefano Garzarella wrote: > > On Wed, Jun 09, 2021 at 11:24:52PM +, Jiang Wang wrote: > >This patchset implements support of SOCK_DGRAM for virtio > >transport. > > > >Datagram sockets are connectionless and unreliable.

Re: [External] Re: [RFC PATCH v1] vsock: add mergeable rx buffer description

2021-06-21 Thread Jiang Wang .
On Thu, Jun 10, 2021 at 11:17 PM Jason Wang wrote: > > > 在 2021/6/11 上午2:39, Jiang Wang 写道: > > Mergeable rx buffer is already supported by virtio-net, and > > it can save memory for big packets. It will also be beneficial > > for the vsock devices, so add

[RFC PATCH v1] vsock: add mergeable rx buffer description

2021-06-10 Thread Jiang Wang
Mergeable rx buffer is already supported by virtio-net, and it can save memory for big packets. It will also be beneficial for the vsock devices, so add it to the spec. --- V0 -> V1: I send similar patch with vsock dgram before and already got some comments. This version fixed those,such as use

[PATCH v5] virtio-vsock: add description for datagram type

2021-06-10 Thread Jiang Wang
of datagram, which does not use the existing credit update mechanism associated with stream sockets. Signed-off-by: Jiang Wang --- V2: addressed the comments for the previous version. V3: add description for the mergeable receive buffer. V4: add a feature bit for stream and reserver a bit

Re: Re: [RFC v1 0/6] virtio/vsock: introduce SOCK_DGRAM support

2021-06-10 Thread Jiang Wang .
On Thu, Jun 10, 2021 at 2:52 AM Stefano Garzarella wrote: > > On Thu, Jun 10, 2021 at 03:46:55PM +0800, Jason Wang wrote: > > > >在 2021/6/10 下午3:23, Stefano Garzarella 写道: > >>On Thu, Jun 10, 2021 at 12:02:35PM +0800, Jason Wang wrote: > >>> > >>>

Re: Re: [RFC v1 0/6] virtio/vsock: introduce SOCK_DGRAM support

2021-06-09 Thread Jiang Wang .
On Wed, Jun 9, 2021 at 6:51 PM Jason Wang wrote: > > > 在 2021/6/10 上午7:24, Jiang Wang 写道: > > This patchset implements support of SOCK_DGRAM for virtio > > transport. > > > > Datagram sockets are connectionless and unreliable. To avoid unfair > > contention

Re: [External] Re: [RFC v4] virtio-vsock: add description for datagram type

2021-06-09 Thread Jiang Wang .
On Wed, Jun 9, 2021 at 12:17 AM Stefano Garzarella wrote: > > On Tue, Jun 08, 2021 at 09:22:26PM -0700, Jiang Wang . wrote: > >On Tue, Jun 8, 2021 at 6:46 AM Stefano Garzarella > >wrote: > >> > >> On Fri, May 28, 2021 at 04:01:18AM +, Jiang

[RFC v1 6/6] virtio/vsock: add sysfs for rx buf len for dgram

2021-06-09 Thread Jiang Wang
Make rx buf len configurable via sysfs Signed-off-by: Jiang Wang --- net/vmw_vsock/virtio_transport.c | 37 +++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c index cf47aadb0c34

[RFC v1 5/6] vhost/vsock: add kconfig for vhost dgram support

2021-06-09 Thread Jiang Wang
Also change number of vqs according to the config Signed-off-by: Jiang Wang --- drivers/vhost/Kconfig | 8 drivers/vhost/vsock.c | 11 --- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig index 587fbae06182

[RFC v1 4/6] vsock_test: add tests for vsock dgram

2021-06-09 Thread Jiang Wang
Added test cases for vsock dgram types. Signed-off-by: Jiang Wang --- tools/testing/vsock/util.c | 105 + tools/testing/vsock/util.h | 4 + tools/testing/vsock/vsock_test.c | 195 +++ 3 files changed, 304 insertions(+) diff

[RFC v1 3/6] vhost/vsock: add support for vhost dgram.

2021-06-09 Thread Jiang Wang
This patch supports dgram on vhost side, including tx and rx. The vhost send packets asynchronously. Signed-off-by: Jiang Wang --- drivers/vhost/vsock.c | 199 +++--- 1 file changed, 173 insertions(+), 26 deletions(-) diff --git a/drivers/vhost

[RFC v1 2/6] virtio/vsock: add support for virtio datagram

2021-06-09 Thread Jiang Wang
for it. Support for the host/device side is in another patch. Signed-off-by: Jiang Wang --- include/net/af_vsock.h | 1 + .../trace/events/vsock_virtio_transport_common.h | 5 +- include/uapi/linux/virtio_vsock.h | 1 + net/vmw_vsock/af_vsock.c

[RFC v1 1/6] virtio/vsock: add VIRTIO_VSOCK_F_DGRAM feature bit

2021-06-09 Thread Jiang Wang
When this feature is enabled, allocate 5 queues, otherwise, allocate 3 queues to be compatible with old QEMU versions. Signed-off-by: Jiang Wang --- drivers/vhost/vsock.c | 3 +- include/linux/virtio_vsock.h | 9 + include/uapi/linux/virtio_vsock.h | 3 ++ net/vmw_vsock

[RFC v1 0/6] virtio/vsock: introduce SOCK_DGRAM support

2021-06-09 Thread Jiang Wang
/vsock-dgram-v1 To do: 1. use skb when receiving packets 2. support multiple transport 3. support mergeable rx buffer Jiang Wang (6): virtio/vsock: add VIRTIO_VSOCK_F_DGRAM feature bit virtio/vsock: add support for virtio datagram vhost/vsock: add support for vhost dgram. vsock_test: add

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-06-08 Thread Jiang Wang .
On Tue, May 18, 2021 at 9:59 PM Jiang Wang . wrote: > > On Tue, May 18, 2021 at 6:02 AM Stefano Garzarella > wrote: > > > > On Mon, May 17, 2021 at 11:33:06PM -0700, Jiang Wang . wrote: > > >On Mon, May 17, 2021 at 4:02 AM Stefano Garzarella > > >wr

Re: [External] Re: [RFC v4] virtio-vsock: add description for datagram type

2021-06-08 Thread Jiang Wang .
On Tue, Jun 8, 2021 at 6:46 AM Stefano Garzarella wrote: > > On Fri, May 28, 2021 at 04:01:18AM +, Jiang Wang wrote: > >From: "jiang.wang" > > > >Add supports for datagram type for virtio-vsock. Datagram > >sockets are connectionless and unreli

Re: [RFC v4] virtio-vsock: add description for datagram type

2021-06-07 Thread Jiang Wang .
Any comments? Thanks. On Thu, May 27, 2021 at 9:01 PM Jiang Wang wrote: > > From: "jiang.wang" > > Add supports for datagram type for virtio-vsock. Datagram > sockets are connectionless and unreliable. To avoid contention > with stream and other sockets, add two

[RFC v4] virtio-vsock: add description for datagram type

2021-05-27 Thread Jiang Wang
scriptions for resource management of datagram, which does not use the existing credit update mechanism associated with stream sockets. Signed-off-by: Jiang Wang --- V2: addressed the comments for the previous version. V3: add description for the mergeable receive buffer. V4: add a feature bit

Re: Re: [virtio-comment] [RFC v3] virtio-vsock: add description for datagram type

2021-05-27 Thread Jiang Wang .
On Thu, May 27, 2021 at 6:21 AM Stefano Garzarella wrote: > > Re-send my thoughts on this new series... > > On Wed, May 26, 2021 at 05:50:35PM +, Jiang Wang wrote: > >From: "jiang.wang" > > > >Add supports for datagram type for virtio-vsock

[RFC v3] virtio-vsock: add description for datagram type

2021-05-26 Thread Jiang Wang
scriptions for resource management of datagram, which does not use the existing credit update mechanism associated with stream sockets. Signed-off-by: Jiang Wang --- V2: addressed the comments for the previous version. V3: add description for the mergeable receive buffer. btw: send the same patch again

[RFC v3] virtio-vsock: add description for datagram type

2021-05-22 Thread Jiang Wang
scriptions for resource management of datagram, which does not use the existing credit update mechanism associated with stream sockets. Signed-off-by: Jiang Wang --- V2: addressed the comments for the previous version. V3: add description for the mergeable receive buffer. virtio-vsock

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-18 Thread Jiang Wang .
On Tue, May 18, 2021 at 6:02 AM Stefano Garzarella wrote: > > On Mon, May 17, 2021 at 11:33:06PM -0700, Jiang Wang . wrote: > >On Mon, May 17, 2021 at 4:02 AM Stefano Garzarella > >wrote: > >> > >> On Fri, May 14, 2021 at 11:55:29AM -0700, Jiang Wang . wrote

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-18 Thread Jiang Wang .
On Mon, May 17, 2021 at 4:02 AM Stefano Garzarella wrote: > > On Fri, May 14, 2021 at 11:55:29AM -0700, Jiang Wang . wrote: > >On Fri, May 14, 2021 at 8:17 AM Stefano Garzarella > >wrote: > >> On Thu, May 13, 2021 at 04:26:03PM -0700, Jiang Wang . wrote: > > [..

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-14 Thread Jiang Wang .
On Fri, May 14, 2021 at 8:17 AM Stefano Garzarella wrote: > > On Thu, May 13, 2021 at 04:26:03PM -0700, Jiang Wang . wrote: > >On Mon, May 10, 2021 at 7:52 AM Stefano Garzarella > >wrote: > >> On Fri, May 07, 2021 at 09:53:19AM -0700, Jiang Wang . wrote: > >

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-13 Thread Jiang Wang .
On Mon, May 10, 2021 at 7:52 AM Stefano Garzarella wrote: > > On Fri, May 07, 2021 at 09:53:19AM -0700, Jiang Wang . wrote: > >Hi guys, > > > >I have one question about adding two new virtqueues for dgram. One new > >thought is that we don't add two new virt

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-07 Thread Jiang Wang .
? I remember Stefano mentioned that we should add two new virtqueues for dgram. Stefano, do you have some specific reasons for that? Could we just keep using existing virtqueues? Thanks. Regards, Jiang On Wed, May 5, 2021 at 9:58 AM Jiang Wang . wrote: > > On Wed, May 5, 2021 at 3:49 AM S

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-05 Thread Jiang Wang .
On Wed, May 5, 2021 at 3:49 AM Stefano Garzarella wrote: > > On Tue, May 04, 2021 at 10:06:02AM -0700, Jiang Wang . wrote: > >On Tue, May 4, 2021 at 9:16 AM Stefano Garzarella > >wrote: > >> > >> Hi Jiang, > >> > >> On Mon, May 03, 2021 at

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-04 Thread Jiang Wang .
On Tue, May 4, 2021 at 9:16 AM Stefano Garzarella wrote: > > Hi Jiang, > > On Mon, May 03, 2021 at 08:40:46PM -0700, Jiang Wang . wrote: > >Hi Stefano, > > > >I checked the VIRTIO_NET_F_MRG_RXBUF feature bit and I think vsock > >dgram can use that feature too

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-14 Thread Jiang Wang .
> > > > On Tue, Apr 13, 2021 at 09:16:50AM -0400, Michael S. Tsirkin wrote: > >> > > > > > On Tue, Apr 13, 2021 at 02:58:53PM +0200, Stefano Garzarella > >> > > > > > wrote: > >> > > > > > &

Re: Re: [RFC] vsock: add multiple transports support for dgram

2021-04-13 Thread Jiang Wang .
Hi Jorgen, Thanks for the detailed explanation and I agree with you. For the bind list, my prototype is doing something similar to that. I will double check it. Hi Stefano, I don't have other questions for now. Thanks. Regards, Jiang On Tue, Apr 13, 2021 at 5:52 AM Stefano Garzarella wrote

Re: [RFC] vsock: add multiple transports support for dgram

2021-04-13 Thread Jiang Wang .
On Tue, Apr 13, 2021 at 2:02 AM Jorgen Hansen wrote: > > > > > On 7 Apr 2021, at 20:25, Jiang Wang . wrote: > > > > On Wed, Apr 7, 2021 at 2:51 AM Jorgen Hansen wrote: > >> > >> > >>> On 6 Apr 2021, at 20:31, Jiang Wang wrote: > &g

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-13 Thread Jiang Wang .
: > > > > On Tue, Apr 13, 2021 at 09:16:50AM -0400, Michael S. Tsirkin wrote: > > > > > On Tue, Apr 13, 2021 at 02:58:53PM +0200, Stefano Garzarella wrote: > > > > > > On Mon, Apr 12, 2021 at 03:42:23PM -0700, Jiang Wang . wrote: > > > >

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-12 Thread Jiang Wang .
gram, which > >> does not use the existing credit update mechanism associated with > >> stream sockets. > >> > >> Signed-off-by: Jiang Wang > >> --- > >> V2 addressed the comments for the previous version. > >> > >> virtio-vsock.tex

Re: [External] Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-12 Thread Jiang Wang .
er sockets, add two more virtqueues and > > a new feature bit to identify if those two new queues exist or not. > > > > Also add descriptions for resource management of datagram, which > > does not use the existing credit update mechanism associated with > > stream sock

Re: Re: [RFC] vsock: add multiple transports support for dgram

2021-04-12 Thread Jiang Wang .
On Mon, Apr 12, 2021 at 7:04 AM Stefano Garzarella wrote: > > Hi Jiang, > thanks for re-starting the multi-transport support for dgram! No problem. > On Wed, Apr 07, 2021 at 11:25:36AM -0700, Jiang Wang . wrote: > >On Wed, Apr 7, 2021 at 2:51 AM Jorgen Hansen wrote: > &g

Re: [External] Re: [RFC] vsock: add multiple transports support for dgram

2021-04-07 Thread Jiang Wang .
On Wed, Apr 7, 2021 at 2:51 AM Jorgen Hansen wrote: > > > > On 6 Apr 2021, at 20:31, Jiang Wang wrote: > > > > From: "jiang.wang" > > > > Currently, only VMCI supports dgram sockets. To supported > > nested VM use case, this patc

[RFC] vsock: add multiple transports support for dgram

2021-04-06 Thread Jiang Wang
s. Signed-off-by: Jiang Wang --- This patch is not tested. I don't have a VMWare testing environment. Could someone help me to test it? include/net/af_vsock.h | 2 -- net/vmw_vsock/af_vsock.c | 63 +- net/vmw_vsock/vmci_transp

Re: [External] Re: [RFC PATCH] virtio-vsock: add description for datagram type

2021-03-30 Thread Jiang Wang .
vsock. Also, I don't think we need to put anything related to this multiple- transport support in the spec. Let me know if otherwise. Regards, Jiang On Tue, Mar 30, 2021 at 11:34 AM Jiang Wang . wrote: > > On Tue, Mar 30, 2021 at 8:32 AM Stefano Garzarella > wrote: > &g

Re: [External] Re: [RFC PATCH] virtio-vsock: add description for datagram type

2021-03-30 Thread Jiang Wang .
On Tue, Mar 30, 2021 at 8:32 AM Stefano Garzarella wrote: > > Hi Jiang, > > On Fri, Mar 26, 2021 at 04:40:09PM -0700, Jiang Wang . wrote: > >Hi Michael and Stefan, > > > >I thought about this and discussed it with my colleague Cong Wang. > >One idea is to mak

Re: [External] Re: [RFC PATCH] virtio-vsock: add description for datagram type

2021-03-30 Thread Jiang Wang .
On Tue, Mar 30, 2021 at 3:42 AM Stefan Hajnoczi wrote: > > On Mon, Mar 29, 2021 at 04:22:28PM -0700, Jiang Wang . wrote: > > On Mon, Mar 29, 2021 at 2:26 AM Stefan Hajnoczi wrote: > > > > > > On Fri, Mar 26, 2021 at 04:40:09PM -0700, Jiang Wang . wrote: > > &g

Re: [External] Re: [RFC PATCH] virtio-vsock: add description for datagram type

2021-03-29 Thread Jiang Wang .
On Mon, Mar 29, 2021 at 2:26 AM Stefan Hajnoczi wrote: > > On Fri, Mar 26, 2021 at 04:40:09PM -0700, Jiang Wang . wrote: > > I thought about this and discussed it with my colleague Cong Wang. > > One idea is to make current asynchronous send_pkt flow to be synchronous, > &g

Re: [External] Re: [RFC PATCH] virtio-vsock: add description for datagram type

2021-03-26 Thread Jiang Wang .
cycles than the RCU, so there is a small price to pay. Another option is to use Sleepable RCU and remove the work queue. What do you guys think? btw, I will also add some SENDBUF restrictions for the dgram sockets, but I don't think it needs to be in the spec. Regards, Jiang On Tue, Mar 23, 2021

Re: [External] Re: [RFC PATCH] virtio-vsock: add description for datagram type

2021-03-22 Thread Jiang Wang .
Got it. Will do. On Mon, Mar 22, 2021 at 4:10 PM Michael S. Tsirkin wrote: > > On Mon, Mar 22, 2021 at 04:02:14PM -0700, Jiang Wang . wrote: > > After dropping my additional accounting. I think there is still a question > > about if we want to protect the shared dgram virtque

Re: [External] Re: [RFC PATCH] virtio-vsock: add description for datagram type

2021-03-22 Thread Jiang Wang .
On Mon, Mar 22, 2021 at 9:51 AM Stefan Hajnoczi wrote: > > On Thu, Mar 18, 2021 at 10:59:20AM -0700, Jiang Wang . wrote: > > On Wed, Mar 17, 2021 at 8:45 AM Stefan Hajnoczi wrote: > > > > > > On Tue, Mar 16, 2021 at 09:56:44PM +, jiang.wang wrote: > >

Re: [External] Re: [RFC PATCH] virtio-vsock: add description for datagram type

2021-03-18 Thread Jiang Wang .
er sockets, add two more virtqueues and > > a new feature bit to identify if those two new queues exist or not. > > > > Also add descriptions for resouce management of datagram, which > > does not use the existing credit update mechanism associated with >

Re: [External] Re: vsock virtio: questions about supporting DGRAM type

2021-03-11 Thread Jiang Wang .
to the other end (host or guest VM). For the application of dgram, we will use it for some remote logging application. The application running in the VM will write some logs to a server running on the host. This is one way communication and the log is not critical. Regards, Jiang On Tue, Feb 23

Re: [External] Re: vsock virtio: questions about supporting DGRAM type

2021-02-16 Thread Jiang Wang .
On Tue, Feb 16, 2021 at 12:50 AM Stefano Garzarella wrote: > > On Tue, Feb 16, 2021 at 12:23:19AM -0800, Jiang Wang . wrote: > >On Tue, Feb 16, 2021 at 12:09 AM Stefano Garzarella > >wrote: > >> > >> On Mon, Feb 15, 2021 at 08:50:36PM -0800, Jiang Wang . wro

Re: [External] Re: vsock virtio: questions about supporting DGRAM type

2021-02-16 Thread Jiang Wang .
On Tue, Feb 16, 2021 at 12:09 AM Stefano Garzarella wrote: > > On Mon, Feb 15, 2021 at 08:50:36PM -0800, Jiang Wang . wrote: > >On Mon, Feb 15, 2021 at 12:31 AM Stefano Garzarella > >wrote: > >> > >> On Sat, Feb 13, 2021 at 03:26:18PM -0800, Jiang Wang . wr

Re: [External] Re: vsock virtio: questions about supporting DGRAM type

2021-02-15 Thread Jiang Wang .
On Mon, Feb 15, 2021 at 12:53 AM Arseny Krasnov wrote: > > > On 14.02.2021 02:46, Jiang Wang . wrote: > > On Fri, Feb 12, 2021 at 7:19 AM Arseny Krasnov > > wrote: > >> > >> On 12.02.2021 12:02, Stefano Garzarella wrote: > >>> Hi Jiang, > &

Re: [External] Re: vsock virtio: questions about supporting DGRAM type

2021-02-15 Thread Jiang Wang .
On Mon, Feb 15, 2021 at 12:31 AM Stefano Garzarella wrote: > > On Sat, Feb 13, 2021 at 03:26:18PM -0800, Jiang Wang . wrote: > >On Fri, Feb 12, 2021 at 1:02 AM Stefano Garzarella > >wrote: > >> > >> Hi Jiang, > >> > >> CCing Arseny who

Re: [External] Re: vsock virtio: questions about supporting DGRAM type

2021-02-13 Thread Jiang Wang .
On Fri, Feb 12, 2021 at 7:19 AM Arseny Krasnov wrote: > > > On 12.02.2021 12:02, Stefano Garzarella wrote: > > Hi Jiang, > > > > CCing Arseny who is working on SOCK_SEQPACKET support for virtio-vsock > > [1]. > > > > On Thu, Feb 11, 2021 at 10:04

Re: [External] Re: vsock virtio: questions about supporting DGRAM type

2021-02-13 Thread Jiang Wang .
On Fri, Feb 12, 2021 at 1:02 AM Stefano Garzarella wrote: > > Hi Jiang, > > CCing Arseny who is working on SOCK_SEQPACKET support for virtio-vsock > [1]. > > On Thu, Feb 11, 2021 at 10:04:34PM -0800, Jiang Wang . wrote: > >Hi guys, > > > >I am working on

vsock virtio: questions about supporting DGRAM type

2021-02-11 Thread Jiang Wang .
still want to support dgram in upstream linux, which way do you guys recommend? If necessary, I can try to base on Asias' old code and continue working on it. If there is anything unclear, just let me know. Thanks. Regards, Jiang ___ Virtualization

[PATCH V3 2/2] block: remove unnecessary argument from blk_execute_rq

2021-01-24 Thread Guoqing Jiang
: linux-...@vger.kernel.org Cc: linux-...@vger.kernel.org Cc: linux-n...@lists.infradead.org Cc: linux-...@vger.kernel.org Acked-by: Ulf Hansson # for mmc Signed-off-by: Guoqing Jiang --- block/blk-exec.c | 3 +-- block/bsg.c | 2 +- block/scsi_ioctl.c

[PATCH V3 0/2] remove unused argument from blk_execute_rq_nowait and blk_execute_rq

2021-01-24 Thread Guoqing Jiang
Guoqing Jiang (2): block: remove unnecessary argument from blk_execute_rq_nowait block: remove unnecessary argument from blk_execute_rq block/blk-exec.c | 13 + block/bsg.c| 2 +- block/scsi_ioctl.c | 6 +++--- drivers/block

[PATCH V3 1/2] block: remove unnecessary argument from blk_execute_rq_nowait

2021-01-24 Thread Guoqing Jiang
c: linux-s...@vger.kernel.org Cc: virtualization@lists.linux-foundation.org Cc: linux-...@vger.kernel.org Cc: linux-...@vger.kernel.org Cc: linux-n...@lists.infradead.org Cc: linux-...@vger.kernel.org Signed-off-by: Guoqing Jiang --- block/blk-exec.c | 10 -- drivers/b

Re: [PATCH V2 2/2] block: remove unnecessary argument from blk_execute_rq

2021-01-24 Thread Guoqing Jiang
On 1/22/21 10:50, Ulf Hansson wrote: On Fri, 22 Jan 2021 at 10:28, Guoqing Jiang wrote: We can remove 'q' from blk_execute_rq as well after the previous change in blk_execute_rq_nowait. And more importantly it never really was needed to start with given that we can trivial derive it from

Re: [PATCH V2 0/2] remove unused argument from blk_execute_rq_nowait and blk_execute_rq

2021-01-24 Thread Guoqing Jiang
On 1/25/21 02:24, Jens Axboe wrote: On 1/22/21 2:28 AM, Guoqing Jiang wrote: V2 changes: 1. update commit header per Christoph's comment. Hi Jens, This series remove unused 'q' from blk_execute_rq_nowait and blk_execute_rq. Also update the comment for blk_execute_rq_nowait. What's

[PATCH V2 0/2] remove unused argument from blk_execute_rq_nowait and blk_execute_rq

2021-01-22 Thread Guoqing Jiang
V2 changes: 1. update commit header per Christoph's comment. Hi Jens, This series remove unused 'q' from blk_execute_rq_nowait and blk_execute_rq. Also update the comment for blk_execute_rq_nowait. Thanks, Guoqing Guoqing Jiang (2): block: remove unnecessary argument from

[PATCH V2 2/2] block: remove unnecessary argument from blk_execute_rq

2021-01-22 Thread Guoqing Jiang
: linux-...@vger.kernel.org Cc: linux-...@vger.kernel.org Cc: linux-n...@lists.infradead.org Cc: linux-...@vger.kernel.org Signed-off-by: Guoqing Jiang --- block/blk-exec.c | 3 +-- block/bsg.c | 2 +- block/scsi_ioctl.c| 6 +++--- drivers

[PATCH V2 1/2] block: remove unnecessary argument from blk_execute_rq_nowait

2021-01-22 Thread Guoqing Jiang
c: linux-s...@vger.kernel.org Cc: virtualization@lists.linux-foundation.org Cc: linux-...@vger.kernel.org Cc: linux-...@vger.kernel.org Cc: linux-n...@lists.infradead.org Cc: linux-...@vger.kernel.org Signed-off-by: Guoqing Jiang --- block/blk-exec.c | 10 -- drivers/b

Re: [PATCH 1/2] block: remove unnecessary argument from blk_execute_rq_nowait

2021-01-21 Thread Guoqing Jiang
On 1/21/21 18:02, Christoph Hellwig wrote: On Thu, Jan 21, 2021 at 03:29:04PM +0100, Guoqing Jiang wrote: The 'q' is not used since commit a1ce35fa4985 ("block: remove dead elevator code"), also update the comment of the function. And more importantly it never really was neede

[PATCH 2/2] block: remove unnecessary argument from blk_execute_rq

2021-01-21 Thread Guoqing Jiang
-...@vger.kernel.org Signed-off-by: Guoqing Jiang --- block/blk-exec.c | 3 +-- block/bsg.c | 2 +- block/scsi_ioctl.c| 6 +++--- drivers/block/mtip32xx/mtip32xx.c | 2 +- drivers/block/paride/pd.c | 2 +- drivers/block/pktcdvd.c | 2

[PATCH 1/2] block: remove unnecessary argument from blk_execute_rq_nowait

2021-01-21 Thread Guoqing Jiang
nel.org Cc: linux-n...@lists.infradead.org Cc: linux-...@vger.kernel.org Signed-off-by: Guoqing Jiang --- block/blk-exec.c | 10 -- drivers/block/sx8.c| 4 ++-- drivers/nvme/host/core.c | 4 ++-- drivers/nvme/host/lightnvm.c | 2 +- dr

[PATCH 0/2] remove unused argument from blk_execute_rq_nowait and blk_execute_rq

2021-01-21 Thread Guoqing Jiang
Hi Jens, This series remove unused 'q' from blk_execute_rq_nowait and blk_execute_rq. Also update the comment for blk_execute_rq_nowait. Thanks, Guoqing Guoqing Jiang (2): block: remove unnecessary argument from blk_execute_rq_nowait block: remove unnecessary argument from blk_execute_rq

[PATCH v3] virtio-net: lower min ring num_free for efficiency

2019-08-19 Thread ? jiang
This change lowers ring buffer reclaim threshold from 1/2*queue to budget for better performance. According to our test with qemu + dpdk, packet dropping happens when the guest is not able to provide free buffer in avail ring timely with default 1/2*queue. The value in the patch has been tested

Re: [PATCH] virtio-net: lower min ring num_free for efficiency

2019-08-15 Thread jiang
On 2019/8/15 17:25, Jason Wang wrote: > > On 2019/8/15 下午4:36, 冉 jiang wrote: >> On 2019/8/15 11:17, Jason Wang wrote: >>> On 2019/8/15 上午11:11, 冉 jiang wrote: >>>> On 2019/8/15 11:01, Jason Wang wrote: >>>>> On 2019/8/14 上午10:06, ? jiang wrot

[PATCH v2] virtio-net: lower min ring num_free for efficiency

2019-08-15 Thread ? jiang
This change lowers ring buffer reclaim threshold from 1/2*queue to budget for better performance. According to our test with qemu + dpdk, packet dropping happens when the guest is not able to provide free buffer in avail ring timely with default 1/2*queue. The value in the patch has been tested

Re: [PATCH] virtio-net: lower min ring num_free for efficiency

2019-08-15 Thread jiang
On 2019/8/15 11:17, Jason Wang wrote: > > On 2019/8/15 上午11:11, 冉 jiang wrote: >> On 2019/8/15 11:01, Jason Wang wrote: >>> On 2019/8/14 上午10:06, ? jiang wrote: >>>> This change lowers ring buffer reclaim threshold from 1/2*queue to >>>> budget >&

Re: [PATCH] virtio-net: lower min ring num_free for efficiency

2019-08-14 Thread jiang
On 2019/8/15 11:01, Jason Wang wrote: > > On 2019/8/14 上午10:06, ? jiang wrote: >> This change lowers ring buffer reclaim threshold from 1/2*queue to >> budget >> for better performance. According to our test with qemu + dpdk, packet >> dropping happens when the gue

Re: [PATCH] virtio-net: parameterize min ring num_free for virtio receive

2019-08-13 Thread jiang
On 2019/8/13 18:55, Michael S. Tsirkin wrote: On Tue, Jul 23, 2019 at 12:05:03PM +, 冉 jiang wrote: On 2019/7/20 0:13, Michael S. Tsirkin wrote: On Fri, Jul 19, 2019 at 03:31:29PM +, 冉 jiang wrote: On 2019/7/19 22:29, Jiang wrote: On 2019/7/19 10:36, Jason Wang wrote: On 2019/7

[PATCH] virtio-net: lower min ring num_free for efficiency

2019-08-13 Thread ? jiang
This change lowers ring buffer reclaim threshold from 1/2*queue to budget for better performance. According to our test with qemu + dpdk, packet dropping happens when the guest is not able to provide free buffer in avail ring timely with default 1/2*queue. The value in the patch has been tested

Re: [PATCH] virtio-net: parameterize min ring num_free for virtio receive

2019-07-24 Thread jiang
On 2019/7/20 0:13, Michael S. Tsirkin wrote: > On Fri, Jul 19, 2019 at 03:31:29PM +, 冉 jiang wrote: >> On 2019/7/19 22:29, Jiang wrote: >>> On 2019/7/19 10:36, Jason Wang wrote: >>>> On 2019/7/18 下午10:43, Michael S. Tsirkin wrote: >>>>> On Thu

Re: [PATCH] virtio-net: parameterize min ring num_free for virtio receive

2019-07-24 Thread jiang
On 2019/7/19 22:29, Jiang wrote: > > On 2019/7/19 10:36, Jason Wang wrote: >> >> On 2019/7/18 下午10:43, Michael S. Tsirkin wrote: >>> On Thu, Jul 18, 2019 at 10:42:47AM -0400, Michael S. Tsirkin wrote: >>>> On Thu, Jul 18, 2019 at 10:01:05PM +0800, Jaso

Re: [PATCH] virtio-net: parameterize min ring num_free for virtio receive

2019-07-24 Thread jiang
irkin wrote: >>>>> On Thu, Jul 18, 2019 at 12:55:50PM +, ? jiang wrote: >>>>>> This change makes ring buffer reclaim threshold num_free >>>>>> configurable >>>>>> for better performance, while it's hard coded as 1/2 * q

[PATCH] virtio-net: parameterize min ring num_free for virtio receive

2019-07-24 Thread ? jiang
This change makes ring buffer reclaim threshold num_free configurable for better performance, while it's hard coded as 1/2 * queue now. According to our test with qemu + dpdk, packet dropping happens when the guest is not able to provide free buffer in avail ring timely. Smaller value of

[PATCH] virtio/virtio_ring: do some comment fixes

2019-05-19 Thread Jiang Biao
There are lots of mismatches between comments and codes, this patch do these comment fixes. Signed-off-by: Jiang Biao --- drivers/virtio/virtio_ring.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio

[PATCH] virtio_pci: Clear stale cpumask when setting irq affinity

2015-06-04 Thread Jiang Liu
The cpumask vp_dev-msix_affinity_masks[info-msix_vector] may contain staled information when vp_set_vq_affinity() gets called, so clear it before setting the new cpu bit mask. Signed-off-by: Jiang Liu jiang@linux.intel.com --- drivers/virtio/virtio_pci_common.c |1 + 1 file changed, 1

[Resend Patch v4 11/16] smp, x86, xen: Kill SMP single function call interrupt

2015-01-22 Thread Jiang Liu
kill the redundant single function call interrupt. Signed-off-by: Jiang Liu liu...@gmail.com Acked-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: x...@kernel.org Cc: xen-de...@lists.xensource.com Cc: virtualization@lists.linux-foundation.org Signed-off-by: Jiang Liu jiang@linux.intel.com

Re: [RFC PATCH 00/11] Refactor MSI to support Non-PCI device

2014-07-30 Thread Jiang Liu
On 2014/7/30 10:45, Yijing Wang wrote: On 2014/7/29 22:08, Arnd Bergmann wrote: On Saturday 26 July 2014 11:08:37 Yijing Wang wrote: The series is a draft of generic MSI driver that supports PCI and Non-PCI device which have MSI capability. If you're not interested it, sorry for the

Re: [RFC PATCH v3 19/19] smp, x86: kill SMP single function call interrupt

2013-12-15 Thread Jiang Liu
to: http://www.kernelhub.org/?msg=373208p=2 Should I merge the patch for xen with the patch for native x86? Is there any dependency between them? Thanks! Gerry On 12/12/2013 06:10 AM, Sebastian Andrzej Siewior wrote: On 05.12.13, Jiang Liu wrote: I like this in general however

[PATCH v3 [resend] 14/18] smp, x86, xen: kill SMP single function call interrupt

2013-12-15 Thread Jiang Liu
-by: Jiang Liu liu...@gmail.com --- arch/x86/include/asm/xen/events.h | 1 - arch/x86/xen/smp.c| 38 ++ 2 files changed, 2 insertions(+), 37 deletions(-) diff --git a/arch/x86/include/asm/xen/events.h b/arch/x86/include/asm/xen/events.h index

[PATCH v3 [resend] 15/18] smp, x86: kill SMP single function call interrupt

2013-12-15 Thread Jiang Liu
-by: Jiang Liu liu...@gmail.com --- arch/x86/include/asm/entry_arch.h| 1 - arch/x86/include/asm/hw_irq.h| 3 --- arch/x86/include/asm/irq_vectors.h | 7 +++ arch/x86/include/asm/trace/irq_vectors.h | 6 -- arch/x86/kernel/entry_64.S | 2 -- arch

[RFC PATCH v3 18/19] smp, tile: kill SMP single function call interrupt

2013-12-04 Thread Jiang Liu
...@linutronix.de Cc: H. Peter Anvin h...@zytor.com Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: Jeremy Fitzhardinge jer...@goop.org Cc: x...@kernel.org Cc: xen-de...@lists.xensource.com Cc: virtualization@lists.linux-foundation.org Signed-off-by: Jiang Liu liu...@gmail.com --- arch/x86/include

[RFC PATCH v3 19/19] smp, x86: kill SMP single function call interrupt

2013-12-04 Thread Jiang Liu
...@linutronix.de Cc: H. Peter Anvin h...@zytor.com Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: Jeremy Fitzhardinge jer...@goop.org Cc: x...@kernel.org Cc: xen-de...@lists.xensource.com Cc: virtualization@lists.linux-foundation.org Signed-off-by: Jiang Liu liu...@gmail.com --- arch/x86/include

[RFC PATCH v2 21/25] smp, tile: kill SMP single function call interrupt

2013-09-11 Thread Jiang Liu
From: Jiang Liu jiang@huawei.com Commit 9a46ad6d6df3b54 smp: make smp_call_function_many() use logic similar to smp_call_function_single() has unified the way to handle single and multiple cross-CPU function calls. Now only one interrupt is needed for architecture specific code to support

[RFC PATCH v2 22/25] smp, x86: kill SMP single function call interrupt

2013-09-11 Thread Jiang Liu
From: Jiang Liu jiang@huawei.com Commit 9a46ad6d6df3b54 smp: make smp_call_function_many() use logic similar to smp_call_function_single() has unified the way to handle single and multiple cross-CPU function calls. Now only one interrupt is needed for architecture specific code to support

[PATCH v2 3/3] PCI: kill pci_scan_bus_parented()

2013-06-21 Thread Jiang Liu
From: Jiang Liu jiang@huawei.com Now there's no caller of pci_scan_bus_parented(), so kill it. Signed-off-by: Jiang Liu jiang@huawei.com Cc: Chris Metcalf cmetc...@tilera.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Thierry Reding thierry.red...@avionic-design.de Cc: linux

  1   2   >