Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 19:12, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 06:31:35PM +0200, Liran Alon wrote: >> >> >>> On 21 Mar 2019, at 17:50, Michael S. Tsirkin wrote: >>> >>> On Thu, Mar 21, 2019 at 08:45:17AM -0700, Stephen Hemminger wrote: On Thu, 21 Mar 2019 15:04:37

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 15:51, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 03:24:39PM +0200, Liran Alon wrote: >> >> >>> On 21 Mar 2019, at 15:12, Michael S. Tsirkin wrote: >>> >>> On Thu, Mar 21, 2019 at 03:04:37PM +0200, Liran Alon wrote: > On 21 Mar 2019, at

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 17:50, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 08:45:17AM -0700, Stephen Hemminger wrote: >> On Thu, 21 Mar 2019 15:04:37 +0200 >> Liran Alon wrote: >> OK. Now what happens if master is moved to another namespace? Do we need to move the

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 15:12, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 03:04:37PM +0200, Liran Alon wrote: >> >> >>> On 21 Mar 2019, at 14:57, Michael S. Tsirkin wrote: >>> >>> On Thu, Mar 21, 2019 at 02:47:50PM +0200, Liran Alon wrote: > On 21 Mar 2019, at

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 14:57, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 02:47:50PM +0200, Liran Alon wrote: >> >> >>> On 21 Mar 2019, at 14:37, Michael S. Tsirkin wrote: >>> >>> On Thu, Mar 21, 2019 at 12:07:57PM +0200, Liran Alon wrote: 2) It brings non-intuitive

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 14:37, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 12:07:57PM +0200, Liran Alon wrote: >> 2) It brings non-intuitive customer experience. For example, a customer >> may attempt to analyse connectivity issue by checking the connectivity >> on a

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 0:10, Michael S. Tsirkin wrote: > > On Wed, Mar 20, 2019 at 11:43:41PM +0200, Liran Alon wrote: >> >> >>> On 20 Mar 2019, at 16:09, Michael S. Tsirkin wrote: >>> >>> On Wed, Mar 20, 2019 at 02:23:36PM +0200, Liran Alon wrote: > On 20 Mar 2019, at 12:25,

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 10:58, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 12:19:22AM +0200, Liran Alon wrote: >> >> >>> On 21 Mar 2019, at 0:10, Michael S. Tsirkin wrote: >>> >>> On Wed, Mar 20, 2019 at 11:43:41PM +0200, Liran Alon wrote: > On 20 Mar 2019, at 16:09,

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 20 Mar 2019, at 12:25, Michael S. Tsirkin wrote: > > On Wed, Mar 20, 2019 at 01:25:58AM +0200, Liran Alon wrote: >> >> >>> On 19 Mar 2019, at 23:19, Michael S. Tsirkin wrote: >>> >>> On Tue, Mar 19, 2019 at 08:46:47AM -0700, Stephen Hemminger wrote: On Tue, 19 Mar 2019 14:38:06

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 19 Mar 2019, at 23:19, Michael S. Tsirkin wrote: > > On Tue, Mar 19, 2019 at 08:46:47AM -0700, Stephen Hemminger wrote: >> On Tue, 19 Mar 2019 14:38:06 +0200 >> Liran Alon wrote: >> >>> b.3) cloud-init: If configured to perform network-configuration, it >>> attempts to configure all

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 20 Mar 2019, at 16:09, Michael S. Tsirkin wrote: > > On Wed, Mar 20, 2019 at 02:23:36PM +0200, Liran Alon wrote: >> >> >>> On 20 Mar 2019, at 12:25, Michael S. Tsirkin wrote: >>> >>> On Wed, Mar 20, 2019 at 01:25:58AM +0200, Liran Alon wrote: > On 19 Mar 2019, at

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
Hi Michael, Great blog-post which summarise everything very well! Some comments I have: 1) I think that when we are using the term “1-netdev model” on community discussion, we tend to refer to what you have defined in blog-post as "3-device model with hidden slaves”. Therefore, I would

Re: [summary] virtio network device failover writeup

2019-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2019 at 06:31:35PM +0200, Liran Alon wrote: > > > > On 21 Mar 2019, at 17:50, Michael S. Tsirkin wrote: > > > > On Thu, Mar 21, 2019 at 08:45:17AM -0700, Stephen Hemminger wrote: > >> On Thu, 21 Mar 2019 15:04:37 +0200 > >> Liran Alon wrote: > >> > > OK. Now what

Re: [summary] virtio network device failover writeup

2019-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2019 at 08:45:17AM -0700, Stephen Hemminger wrote: > On Thu, 21 Mar 2019 15:04:37 +0200 > Liran Alon wrote: > > > > > > > OK. Now what happens if master is moved to another namespace? Do we need > > > to move the slaves too? > > > > No. Why would we move the slaves? The whole

Re: [summary] virtio network device failover writeup

2019-03-21 Thread Stephen Hemminger
On Thu, 21 Mar 2019 15:04:37 +0200 Liran Alon wrote: > > > > OK. Now what happens if master is moved to another namespace? Do we need > > to move the slaves too? > > No. Why would we move the slaves? The whole point is to make most customer > ignore the net-failover slaves and remain them

Re: [summary] virtio network device failover writeup

2019-03-21 Thread Stephen Hemminger
On Thu, 21 Mar 2019 08:57:03 -0400 "Michael S. Tsirkin" wrote: > On Thu, Mar 21, 2019 at 02:47:50PM +0200, Liran Alon wrote: > > > > > > > On 21 Mar 2019, at 14:37, Michael S. Tsirkin wrote: > > > > > > On Thu, Mar 21, 2019 at 12:07:57PM +0200, Liran Alon wrote: > > >> 2) It brings

Re: [summary] virtio network device failover writeup

2019-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2019 at 04:16:14PM +0200, Liran Alon wrote: > > > > On 21 Mar 2019, at 15:51, Michael S. Tsirkin wrote: > > > > On Thu, Mar 21, 2019 at 03:24:39PM +0200, Liran Alon wrote: > >> > >> > >>> On 21 Mar 2019, at 15:12, Michael S. Tsirkin wrote: > >>> > >>> On Thu, Mar 21, 2019

Re: [summary] virtio network device failover writeup

2019-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2019 at 03:24:39PM +0200, Liran Alon wrote: > > > > On 21 Mar 2019, at 15:12, Michael S. Tsirkin wrote: > > > > On Thu, Mar 21, 2019 at 03:04:37PM +0200, Liran Alon wrote: > >> > >> > >>> On 21 Mar 2019, at 14:57, Michael S. Tsirkin wrote: > >>> > >>> On Thu, Mar 21, 2019

Re: [summary] virtio network device failover writeup

2019-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2019 at 03:04:37PM +0200, Liran Alon wrote: > > > > On 21 Mar 2019, at 14:57, Michael S. Tsirkin wrote: > > > > On Thu, Mar 21, 2019 at 02:47:50PM +0200, Liran Alon wrote: > >> > >> > >>> On 21 Mar 2019, at 14:37, Michael S. Tsirkin wrote: > >>> > >>> On Thu, Mar 21, 2019

Re: [summary] virtio network device failover writeup

2019-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2019 at 02:47:50PM +0200, Liran Alon wrote: > > > > On 21 Mar 2019, at 14:37, Michael S. Tsirkin wrote: > > > > On Thu, Mar 21, 2019 at 12:07:57PM +0200, Liran Alon wrote: > >> 2) It brings non-intuitive customer experience. For example, a > >> customer may attempt to

Re: [summary] virtio network device failover writeup

2019-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2019 at 12:07:57PM +0200, Liran Alon wrote: > 2) It brings non-intuitive customer experience. For example, a customer > may attempt to analyse connectivity issue by checking the connectivity > on a net-failover slave (e.g. the VF) but will see no connectivity when

Re: [summary] virtio network device failover writeup

2019-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2019 at 12:19:22AM +0200, Liran Alon wrote: > > > > On 21 Mar 2019, at 0:10, Michael S. Tsirkin wrote: > > > > On Wed, Mar 20, 2019 at 11:43:41PM +0200, Liran Alon wrote: > >> > >> > >>> On 20 Mar 2019, at 16:09, Michael S. Tsirkin wrote: > >>> > >>> On Wed, Mar 20, 2019 at

Re: [summary] virtio network device failover writeup

2019-03-20 Thread Michael S. Tsirkin
On Wed, Mar 20, 2019 at 11:43:41PM +0200, Liran Alon wrote: > > > > On 20 Mar 2019, at 16:09, Michael S. Tsirkin wrote: > > > > On Wed, Mar 20, 2019 at 02:23:36PM +0200, Liran Alon wrote: > >> > >> > >>> On 20 Mar 2019, at 12:25, Michael S. Tsirkin wrote: > >>> > >>> On Wed, Mar 20, 2019

Re: [summary] virtio network device failover writeup

2019-03-20 Thread Michael S. Tsirkin
On Wed, Mar 20, 2019 at 02:23:36PM +0200, Liran Alon wrote: > > > > On 20 Mar 2019, at 12:25, Michael S. Tsirkin wrote: > > > > On Wed, Mar 20, 2019 at 01:25:58AM +0200, Liran Alon wrote: > >> > >> > >>> On 19 Mar 2019, at 23:19, Michael S. Tsirkin wrote: > >>> > >>> On Tue, Mar 19, 2019

Re: [summary] virtio network device failover writeup

2019-03-20 Thread Michael S. Tsirkin
On Wed, Mar 20, 2019 at 01:25:58AM +0200, Liran Alon wrote: > > > > On 19 Mar 2019, at 23:19, Michael S. Tsirkin wrote: > > > > On Tue, Mar 19, 2019 at 08:46:47AM -0700, Stephen Hemminger wrote: > >> On Tue, 19 Mar 2019 14:38:06 +0200 > >> Liran Alon wrote: > >> > >>> b.3) cloud-init: If

Re: [summary] virtio network device failover writeup

2019-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2019 at 08:46:47AM -0700, Stephen Hemminger wrote: > On Tue, 19 Mar 2019 14:38:06 +0200 > Liran Alon wrote: > > > b.3) cloud-init: If configured to perform network-configuration, it > > attempts to configure all available netdevs. It should avoid however doing > > so on

Re: [summary] virtio network device failover writeup

2019-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2019 at 02:38:06PM +0200, Liran Alon wrote: > Hi Michael, > > Great blog-post which summarise everything very well! > > Some comments I have: Thanks! I'll try to update everything in the post when I'm not so jet-lagged. > 1) I think that when we are using the term “1-netdev

Re: [summary] virtio network device failover writeup

2019-03-19 Thread Stephen Hemminger
On Tue, 19 Mar 2019 14:38:06 +0200 Liran Alon wrote: > b.3) cloud-init: If configured to perform network-configuration, it attempts > to configure all available netdevs. It should avoid however doing so on > net-failover slaves. > (Microsoft has handled this by adding a mechanism in cloud-init