RE: [PATCH 097/117] Staging: hv: storvsc: Add code to handle IDE devices using the storvsc driver

2011-07-16 Thread Sasha Levin
On Sat, 2011-07-16 at 12:57 +, KY Srinivasan wrote: > > > -Original Message- > > From: Christoph Hellwig [mailto:h...@infradead.org] > > Sent: Friday, July 15, 2011 10:05 PM > > To: KY Srinivasan > > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; > > de...@linuxdriverproject.org; vi

Re: [PATCH 097/117] Staging: hv: storvsc: Add code to handle IDE devices using the storvsc driver

2011-07-16 Thread Christoph Hellwig
On Sat, Jul 16, 2011 at 04:01:39PM +0300, Sasha Levin wrote: > Is think that what Christoph meant was simplifying it to: > > if (dev_is_ide) > storvsc_get_ide_info(device, &target, &path); > > host_dev->path = device_info.path_id; > host_dev->target = device_

Re: [PATCH 020/117] Staging: hv: vmbus: Support the notion of id tables in vmbus_match()

2011-07-16 Thread Christoph Hellwig
On Sat, Jul 16, 2011 at 12:54:46PM +, KY Srinivasan wrote: > > would be nice to add uuid_{le,be}_is_nil helpers to uuid.h. I also > > think simply using a memcpy might be more efficient than the hand-rolled > > loop. > Having a helper function would be great. With regards to the efficiency of

RE: [PATCH 097/117] Staging: hv: storvsc: Add code to handle IDE devices using the storvsc driver

2011-07-16 Thread KY Srinivasan
> -Original Message- > From: Sasha Levin [mailto:levinsasha...@gmail.com] > Sent: Saturday, July 16, 2011 9:02 AM > To: KY Srinivasan > Cc: Christoph Hellwig; gre...@suse.de; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang > Subje

RE: [PATCH 088/117] Staging: hv: netvsc: Inline the code for free_net_device()

2011-07-16 Thread KY Srinivasan
> -Original Message- > From: Dan Carpenter [mailto:erro...@gmail.com] > Sent: Saturday, July 16, 2011 6:34 AM > To: KY Srinivasan > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang > Subject: Re: [PATCH 088/117]

RE: [PATCH 097/117] Staging: hv: storvsc: Add code to handle IDE devices using the storvsc driver

2011-07-16 Thread KY Srinivasan
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Friday, July 15, 2011 10:05 PM > To: KY Srinivasan > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang > Subject: Re: [PATCH 097/

RE: [PATCH 020/117] Staging: hv: vmbus: Support the notion of id tables in vmbus_match()

2011-07-16 Thread KY Srinivasan
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Friday, July 15, 2011 10:03 PM > To: KY Srinivasan > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang > Subject: Re: [PATCH 020/

Re: [PATCH 088/117] Staging: hv: netvsc: Inline the code for free_net_device()

2011-07-16 Thread Dan Carpenter
On Fri, Jul 15, 2011 at 10:47:16AM -0700, K. Y. Srinivasan wrote: > -static void free_net_device(struct netvsc_device *device) > -{ > - WARN_ON(atomic_read(&device->refcnt) != 0); > - device->dev->ext = NULL; device->dev->ext points to device. We set it NULL here to prevent a use after fr