Re: [net-next RFC V5 5/5] virtio_net: support negotiating the number of queues through ctrl vq

2012-07-05 Thread Stephen Hemminger
On Fri, 06 Jul 2012 11:20:06 +0800 Jason Wang wrote: > On 07/05/2012 08:51 PM, Sasha Levin wrote: > > On Thu, 2012-07-05 at 18:29 +0800, Jason Wang wrote: > >> @@ -1387,6 +1404,10 @@ static int virtnet_probe(struct virtio_device *vdev) > >> if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Paolo Bonzini
Il 06/07/2012 05:38, Nicholas A. Bellinger ha scritto: > So I imagine that setting inquiry/vpd/mode via configfs attribs to match > whatever the guest wants to see (or expects to see) can be enabled > via /sys/kernel/config/target/core/$HBA/$DEV/[wwn,attrib]/ easily to > whatever is required. > >

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Nicholas A. Bellinger
On Thu, 2012-07-05 at 16:53 +0300, Michael S. Tsirkin wrote: > On Thu, Jul 05, 2012 at 12:22:33PM +0200, Paolo Bonzini wrote: > > Il 05/07/2012 03:52, Nicholas A. Bellinger ha scritto: > > > > > > fio randrw workload | virtio-scsi-raw | virtio-scsi+tcm_vhost | > > > bare-metal raw block > > > ---

Re: [net-next RFC V5 5/5] virtio_net: support negotiating the number of queues through ctrl vq

2012-07-05 Thread Jason Wang
On 07/05/2012 08:51 PM, Sasha Levin wrote: On Thu, 2012-07-05 at 18:29 +0800, Jason Wang wrote: @@ -1387,6 +1404,10 @@ static int virtnet_probe(struct virtio_device *vdev) if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) vi->has_cvq = true; + /* Use single tx/

Re: [net-next RFC V5 2/5] virtio_ring: move queue_index to vring_virtqueue

2012-07-05 Thread Jason Wang
On 07/05/2012 07:40 PM, Sasha Levin wrote: On Thu, 2012-07-05 at 18:29 +0800, Jason Wang wrote: Instead of storing the queue index in virtio infos, this patch moves them to vring_virtqueue and introduces helpers to set and get the value. This would simplify the management and tracing. Signed-of

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Nicholas A. Bellinger
On Thu, 2012-07-05 at 12:31 +0300, Michael S. Tsirkin wrote: > On Wed, Jul 04, 2012 at 07:01:05PM -0700, Nicholas A. Bellinger wrote: > > On Wed, 2012-07-04 at 18:05 +0300, Michael S. Tsirkin wrote: > > > I was talking about 4/6 first of all. > > > > So yeah, this code is still considered RFC a

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Nicholas A. Bellinger
On Thu, 2012-07-05 at 09:06 -0500, Anthony Liguori wrote: > On 07/05/2012 08:53 AM, Michael S. Tsirkin wrote: > > On Thu, Jul 05, 2012 at 12:22:33PM +0200, Paolo Bonzini wrote: > >> Il 05/07/2012 03:52, Nicholas A. Bellinger ha scritto: > >>> > >>> fio randrw workload | virtio-scsi-raw | virtio-scs

Re: [PATCH 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-05 Thread Asias He
On 07/04/2012 10:40 AM, Rusty Russell wrote: On Tue, 03 Jul 2012 08:39:39 +0800, Asias He wrote: On 07/02/2012 02:41 PM, Rusty Russell wrote: Sure, our guest merging might save us 100x as many exits as no merging. But since we're not doing many requests, does it matter? We can still have man

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 04:32:31PM +0200, Paolo Bonzini wrote: > Il 05/07/2012 15:53, Michael S. Tsirkin ha scritto: > > On Thu, Jul 05, 2012 at 12:22:33PM +0200, Paolo Bonzini wrote: > >> Il 05/07/2012 03:52, Nicholas A. Bellinger ha scritto: > >>> > >>> fio randrw workload | virtio-scsi-raw | vir

Re: [net-next RFC V5 5/5] virtio_net: support negotiating the number of queues through ctrl vq

2012-07-05 Thread Amos Kong
On 07/05/2012 08:51 PM, Sasha Levin wrote: > On Thu, 2012-07-05 at 18:29 +0800, Jason Wang wrote: >> @@ -1387,6 +1404,10 @@ static int virtnet_probe(struct virtio_device *vdev) >> if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) >> vi->has_cvq = true; >> >> + /*

Re: [net-next RFC V5 4/5] virtio_net: multiqueue support

2012-07-05 Thread Amos Kong
On 07/05/2012 06:29 PM, Jason Wang wrote: > This patch converts virtio_net to a multi queue device. After negotiated > VIRTIO_NET_F_MULTIQUEUE feature, the virtio device has many tx/rx queue pairs, > and driver could read the number from config space. > > The driver expects the number of rx/tx que

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Bart Van Assche
On 07/05/12 17:53, Bart Van Assche wrote: > On 07/05/12 01:52, Nicholas A. Bellinger wrote: >> fio randrw workload | virtio-scsi-raw | virtio-scsi+tcm_vhost | bare-metal >> raw block >> >> 25 Write / 75 Read |

Re: [PATCH 4/6] tcm_vhost: Initial merge for vhost level target fabric driver

2012-07-05 Thread Bart Van Assche
On 07/05/12 17:47, Bart Van Assche wrote: > On 07/04/12 04:24, Nicholas A. Bellinger wrote: >> +/* Fill in status and signal that we are done processing this command >> + * >> + * This is scheduled in the vhost work queue so we are called with the owner >> + * process mm and can access the vring.

Re: [PATCH 4/6] tcm_vhost: Initial merge for vhost level target fabric driver

2012-07-05 Thread Bart Van Assche
On 07/04/12 04:24, Nicholas A. Bellinger wrote: > +/* Fill in status and signal that we are done processing this command > + * > + * This is scheduled in the vhost work queue so we are called with the owner > + * process mm and can access the vring. > + */ > +static void vhost_scsi_complete_cmd_wo

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Bart Van Assche
On 07/05/12 01:52, Nicholas A. Bellinger wrote: > fio randrw workload | virtio-scsi-raw | virtio-scsi+tcm_vhost | bare-metal > raw block > > 25 Write / 75 Read | ~15K | ~45K |

Re: [net-next RFC V5 0/5] Multiqueue virtio-net

2012-07-05 Thread Rick Jones
On 07/05/2012 03:29 AM, Jason Wang wrote: Test result: 1) 1 vm 2 vcpu 1q vs 2q, 1 - 1q, 2 - 2q, no pinning - Guest to External Host TCP STREAM sessions size throughput1 throughput2 norm1 norm2 1 64 650.55 655.61 100% 24.88 24.86 99% 2 64 1446.81 1309.44 90% 30.49 27.16 89% 4 64 1430.52 1305

[PATCH] xen: populate correct number of pages when across mem boundary

2012-07-05 Thread zhenzhong.duan
When populate pages across a mem boundary at bootup, the page count populated isn't correct. This is due to mem populated to non-mem region and ignored. Pfn range is also wrongly aligned when mem boundary isn't page aligned. Also need consider the rare case when xen_do_chunk fail(populate). For

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 04:47:43PM +0200, Paolo Bonzini wrote: > Il 05/07/2012 16:40, Michael S. Tsirkin ha scritto: > >> virtio-scsi is brand new. It's not as if we've had any significant > >> time to make virtio-scsi-qemu faster. In fact, tcm_vhost existed > >> before virtio-scsi-qemu did if I

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Paolo Bonzini
Il 05/07/2012 16:40, Michael S. Tsirkin ha scritto: >> virtio-scsi is brand new. It's not as if we've had any significant >> time to make virtio-scsi-qemu faster. In fact, tcm_vhost existed >> before virtio-scsi-qemu did if I understand correctly. Yes. > Can't same can be said about virtio scsi

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 09:06:35AM -0500, Anthony Liguori wrote: > On 07/05/2012 08:53 AM, Michael S. Tsirkin wrote: > >On Thu, Jul 05, 2012 at 12:22:33PM +0200, Paolo Bonzini wrote: > >>Il 05/07/2012 03:52, Nicholas A. Bellinger ha scritto: > >>> > >>>fio randrw workload | virtio-scsi-raw | virtio

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Paolo Bonzini
Il 05/07/2012 15:53, Michael S. Tsirkin ha scritto: > On Thu, Jul 05, 2012 at 12:22:33PM +0200, Paolo Bonzini wrote: >> Il 05/07/2012 03:52, Nicholas A. Bellinger ha scritto: >>> >>> fio randrw workload | virtio-scsi-raw | virtio-scsi+tcm_vhost | bare-metal >>> raw block >>> --

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Anthony Liguori
On 07/05/2012 08:53 AM, Michael S. Tsirkin wrote: On Thu, Jul 05, 2012 at 12:22:33PM +0200, Paolo Bonzini wrote: Il 05/07/2012 03:52, Nicholas A. Bellinger ha scritto: fio randrw workload | virtio-scsi-raw | virtio-scsi+tcm_vhost | bare-metal raw block

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 12:22:33PM +0200, Paolo Bonzini wrote: > Il 05/07/2012 03:52, Nicholas A. Bellinger ha scritto: > > > > fio randrw workload | virtio-scsi-raw | virtio-scsi+tcm_vhost | bare-metal > > raw block > >

Re: [net-next RFC V5 5/5] virtio_net: support negotiating the number of queues through ctrl vq

2012-07-05 Thread Sasha Levin
On Thu, 2012-07-05 at 18:29 +0800, Jason Wang wrote: > @@ -1387,6 +1404,10 @@ static int virtnet_probe(struct virtio_device *vdev) > if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) > vi->has_cvq = true; > > + /* Use single tx/rx queue pair as default */ > +

Re: [PATCH] MAINTAINERS: add kvm list for virtio components

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 12:07:07PM +0200, Paolo Bonzini wrote: > The KVM list is followed by more people than the generic > virtualization@lists.linux-foundation.org mailing list, and is > already "de facto" the place where virtio patches are posted. I have no data on the first statement (do you?)

Re: [net-next RFC V5 2/5] virtio_ring: move queue_index to vring_virtqueue

2012-07-05 Thread Sasha Levin
On Thu, 2012-07-05 at 18:29 +0800, Jason Wang wrote: > Instead of storing the queue index in virtio infos, this patch moves them to > vring_virtqueue and introduces helpers to set and get the value. This would > simplify the management and tracing. > > Signed-off-by: Jason Wang This patch actual

[net-next RFC V5 5/5] virtio_net: support negotiating the number of queues through ctrl vq

2012-07-05 Thread Jason Wang
This patch let the virtio_net driver can negotiate the number of queues it wishes to use through control virtqueue and export an ethtool interface to let use tweak it. As current multiqueue virtio-net implementation has optimizations on per-cpu virtuqueues, so only two modes were support: - singl

[net-next RFC V5 4/5] virtio_net: multiqueue support

2012-07-05 Thread Jason Wang
This patch converts virtio_net to a multi queue device. After negotiated VIRTIO_NET_F_MULTIQUEUE feature, the virtio device has many tx/rx queue pairs, and driver could read the number from config space. The driver expects the number of rx/tx queue paris is equal to the number of vcpus. To maximiz

[net-next RFC V5 3/5] virtio: intorduce an API to set affinity for a virtqueue

2012-07-05 Thread Jason Wang
Sometimes, virtio device need to configure irq affiniry hint to maximize the performance. Instead of just exposing the irq of a virtqueue, this patch introduce an API to set the affinity for a virtqueue. The api is best-effort, the affinity hint may not be set as expected due to platform support,

[net-next RFC V5 2/5] virtio_ring: move queue_index to vring_virtqueue

2012-07-05 Thread Jason Wang
Instead of storing the queue index in virtio infos, this patch moves them to vring_virtqueue and introduces helpers to set and get the value. This would simplify the management and tracing. Signed-off-by: Jason Wang --- drivers/virtio/virtio_mmio.c |5 + drivers/virtio/virtio_pci.c |

[net-next RFC V5 1/5] virtio_net: Introduce VIRTIO_NET_F_MULTIQUEUE

2012-07-05 Thread Jason Wang
From: Krishna Kumar Introduce VIRTIO_NET_F_MULTIQUEUE. Signed-off-by: Krishna Kumar Signed-off-by: Jason Wang --- include/linux/virtio_net.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h index 2470f54..1bc7e30

[net-next RFC V5 0/5] Multiqueue virtio-net

2012-07-05 Thread Jason Wang
Hello All: This series is an update version of multiqueue virtio-net driver based on Krishna Kumar's work to let virtio-net use multiple rx/tx queues to do the packets reception and transmission. Please review and comments. Test Environment: - Intel(R) Xeon(R) CPU E5620 @ 2.40GHz, 8 cores 2 numa

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Paolo Bonzini
Il 05/07/2012 03:52, Nicholas A. Bellinger ha scritto: > > fio randrw workload | virtio-scsi-raw | virtio-scsi+tcm_vhost | bare-metal > raw block > > 25 Write / 75 Read | ~15K | ~45K

[PATCH] virtio-blk: add back VIRTIO_BLK_F_FLUSH

2012-07-05 Thread Paolo Bonzini
The old name is part of the userspace API, add it back for compatibility. Reported-by: Sasha Levin Signed-off-by: Paolo Bonzini --- include/linux/virtio_blk.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/include/linux/virtio_blk.h b/include/linux/virtio_blk.h index

[PATCH] MAINTAINERS: add kvm list for virtio components

2012-07-05 Thread Paolo Bonzini
The KVM list is followed by more people than the generic virtualization@lists.linux-foundation.org mailing list, and is already "de facto" the place where virtio patches are posted. pv-ops still has no other lists than virtualization@lists.linux-foundation.org. However, pv-ops patches will likely

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Michael S. Tsirkin
On Wed, Jul 04, 2012 at 07:01:05PM -0700, Nicholas A. Bellinger wrote: > On Wed, 2012-07-04 at 18:05 +0300, Michael S. Tsirkin wrote: > > On Wed, Jul 04, 2012 at 04:52:00PM +0200, Paolo Bonzini wrote: > > > Il 04/07/2012 16:02, Michael S. Tsirkin ha scritto: > > > > On Wed, Jul 04, 2012 at 04:24:00

Re: [PATCH v4] virtio-scsi: hotplug support for virtio-scsi

2012-07-05 Thread Paolo Bonzini
Il 05/07/2012 11:06, Cong Meng ha scritto: > This patch implements the hotplug support for virtio-scsi. > When there is a device attached/detached, the virtio-scsi driver will be > signaled via event virtual queue and it will add/remove the scsi device > in question automatically. > > v2: handle

[PATCH v4] virtio-scsi: hotplug support for virtio-scsi

2012-07-05 Thread Cong Meng
This patch implements the hotplug support for virtio-scsi. When there is a device attached/detached, the virtio-scsi driver will be signaled via event virtual queue and it will add/remove the scsi device in question automatically. v2: handle no_event event v3: add handle event dropped, and typo f

Re: [PATCH v3] virtio-scsi: hotplug support for virtio-scsi

2012-07-05 Thread Paolo Bonzini
Il 05/07/2012 09:09, Cong Meng ha scritto: > This patch implements the hotplug support for virtio-scsi. > When there is a device attached/detached, the virtio-scsi driver will be > signaled via event virtual queue and it will add/remove the scsi device > in question automatically. > > v2: handle

[PATCH v3] virtio-scsi: hotplug support for virtio-scsi

2012-07-05 Thread Cong Meng
This patch implements the hotplug support for virtio-scsi. When there is a device attached/detached, the virtio-scsi driver will be signaled via event virtual queue and it will add/remove the scsi device in question automatically. v2: handle no_event event v3: add handle event dropped, and typo f