RE: virtcrypto_dataq_callback calls crypto_finalize_request() from irq context

2023-11-02 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Thursday, November 2, 2023 9:17 PM > To: Gonglei (Arei) > Cc: Halil Pasic ; Herbert Xu > ; Jason Wang ; > virtualization@lists.linux-foundation.org; linux-ker...@vger.ke

RE: virtcrypto_dataq_callback calls crypto_finalize_request() from irq context

2023-11-02 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Wednesday, November 1, 2023 9:26 PM > To: Halil Pasic > Cc: Gonglei (Arei) ; Herbert Xu > ; Jason Wang ; > virtualization@lists.linux-foundation.org; linux-ker...@vger.ke

RE: [PATCH] crypto: virtio-crypto: call finalize with bh disabled

2023-11-02 Thread Gonglei (Arei) via Virtualization
Ping Herbert. Thanks. > -Original Message- > From: Gonglei (Arei) > Sent: Wednesday, September 27, 2023 5:18 PM > To: 'Halil Pasic' > Cc: Herbert Xu ; linux-cry...@vger.kernel.org; > Marc Hartmayer ; Michael S. Tsirkin > ; Jason Wang ; > virtualization@li

RE: Re: [PATCH] crypto: virtio-crypto: call finalize with bh disabled

2023-09-27 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, September 28, 2023 9:24 AM > To: Michael S. Tsirkin ; Gonglei (Arei) > > Cc: Halil Pasic ; Herbert Xu > ; linux-cry...@vger.kernel.org; Marc > Hartmayer ; Jason

RE: [PATCH] crypto: virtio-crypto: call finalize with bh disabled

2023-09-27 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Wednesday, September 27, 2023 1:14 AM > To: Halil Pasic > Cc: Gonglei (Arei) ; Herbert Xu > ; linux-cry...@vger.kernel.org; Marc > Hartmayer ; Jason Wang > ; virtualization@li

RE: [PATCH] crypto: virtio-crypto: call finalize with bh disabled

2023-09-27 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: Halil Pasic [mailto:pa...@linux.ibm.com] > Sent: Wednesday, September 27, 2023 12:42 AM > To: Gonglei (Arei) > Cc: Herbert Xu ; linux-cry...@vger.kernel.org; > Marc Hartmayer ; Michael S. Tsirkin > ; Jason Wang ; > virtualization@li

[PATCH] crypto: virtio-crypto: call finalize with bh disabled

2023-09-25 Thread Gonglei (Arei) via Virtualization
Doing ipsec produces a spinlock recursion warning. This is due to not disabling BH during crypto completion function. Fixes: 59ca6c93387d3 ("virtio-crypto: implement RSA algorithm") Reported-by: Halil Pasic Signed-off-by: Gonglei --- drivers/crypto/virtio/virtio_crypto_akcipher_

RE: virtcrypto_dataq_callback calls crypto_finalize_request() from irq context

2023-09-24 Thread Gonglei (Arei) via Virtualization
, -Gonglei > -Original Message- > From: Halil Pasic [mailto:pa...@linux.ibm.com] > Sent: Friday, September 22, 2023 9:46 PM > To: Gonglei (Arei) > Cc: Halil Pasic ; Herbert Xu > ; Michael S. Tsirkin ; > Jason Wang ; > virtualization@lists.linux-foundation.org; linu

RE: [PATCH] crypto: virtio - Use helper to set reqsize

2022-11-22 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: Herbert Xu [mailto:herb...@gondor.apana.org.au] > Sent: Tuesday, November 22, 2022 5:42 PM > To: Gonglei (Arei) ; > virtualization@lists.linux-foundation.org; Linux Crypto Mailing List > > Subject: [PATCH] crypto: virtio - Use

RE: [PATCH] virtio-crypto: fix memory leak in virtio_crypto_alg_skcipher_close_session()

2022-11-14 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: Wei Yongjun [mailto:weiyong...@huaweicloud.com] > Sent: Monday, November 14, 2022 7:08 PM > To: Michael S. Tsirkin ; Jason Wang > ; Gonglei (Arei) ; > Herbert Xu ; David S. Miller > ; zhenwei pi > Cc: weiyongjun (A) ; >

RE: [PATCH] crypto-virtio: fix memory-leak

2022-08-16 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, August 16, 2022 4:43 PM > To: Lei He > Cc: Gonglei (Arei) ; > herb...@gondor.apana.org.au; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-k

RE: RE: [PATCH v8 1/1] crypto: Introduce RSA algorithm

2022-05-31 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Tuesday, May 31, 2022 9:48 AM > To: Gonglei (Arei) > Cc: qemu-de...@nongnu.org; m...@redhat.com; > virtualization@lists.linux-foundation.org; helei.si...@bytedance.com; > berra...@red

RE: [PATCH v8 1/1] crypto: Introduce RSA algorithm

2022-05-30 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Friday, May 27, 2022 4:48 PM > To: m...@redhat.com; Gonglei (Arei) > Cc: qemu-de...@nongnu.org; virtualization@lists.linux-foundation.org; > helei.si...@bytedance.com; berra...@redh

RE: [PATCH 9/9] crypto: Introduce RSA algorithm

2022-05-26 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: Lei He [mailto:helei.si...@bytedance.com] > Sent: Wednesday, May 25, 2022 5:01 PM > To: m...@redhat.com; Gonglei (Arei) ; > berra...@redhat.com > Cc: qemu-de...@nongnu.org; virtualization@lists.linux-foundation.org; > linux-cry...@v

RE: [PATCH v7 0/9] Introduce akcipher service for virtio-crypto

2022-05-26 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: Daniel P. Berrangé [mailto:berra...@redhat.com] > Sent: Thursday, May 26, 2022 6:48 PM > To: Lei He > Cc: m...@redhat.com; Gonglei (Arei) ; > qemu-de...@nongnu.org; virtualization@lists.linux-foundation.org; > linux-cry...@v

RE: [PATCH] virtio-crypto: Fix an error handling path in virtio_crypto_alg_skcipher_close_session()

2022-05-22 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: Christophe JAILLET [mailto:christophe.jail...@wanadoo.fr] > Sent: Sunday, May 22, 2022 9:07 PM > To: dan.carpen...@oracle.com; Gonglei (Arei) ; > Michael S. Tsirkin ; Jason Wang ; > Herbert Xu ; David S. Miller > ; zhenwe

RE: [PATCH v5 5/5] virtio-crypto: enable retry for virtio-crypto-dev

2022-05-06 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, May 5, 2022 5:24 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; herb...@gondor.apana.org.au; > linux-ker...@vger.kernel.org; virtualization@lists.li

RE: [PATCH v5 4/5] virtio-crypto: adjust dst_len at ops callback

2022-05-06 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, May 5, 2022 5:24 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; herb...@gondor.apana.org.au; > linux-ker...@vger.kernel.org; virtualization@lists.li

RE: [PATCH v5 3/5] virtio-crypto: wait ctrl queue instead of busy polling

2022-05-06 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, May 5, 2022 5:24 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; herb...@gondor.apana.org.au; > linux-ker...@vger.kernel.org; virtualization@lists.li

RE: [PATCH v5 2/5] virtio-crypto: use private buffer for control request

2022-05-06 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, May 5, 2022 5:24 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; herb...@gondor.apana.org.au; > linux-ker...@vger.kernel.org; virtualization@lists.li

RE: [PATCH v5 1/5] virtio-crypto: change code style

2022-05-06 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, May 5, 2022 5:24 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; herb...@gondor.apana.org.au; > linux-ker...@vger.kernel.org; virtualization@lists.li

RE: PING: [PATCH v4 0/5] virtio-crypto: Improve performance

2022-05-04 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, May 5, 2022 10:35 AM > To: Gonglei (Arei) ; m...@redhat.com; > jasow...@redhat.com > Cc: herb...@gondor.apana.org.au; linux-ker...@vger.kernel.org; > virtualization@lists

RE: [PATCH v3 4/5] virtio-crypto: adjust dst_len at ops callback

2022-04-21 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, April 21, 2022 6:40 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; herb...@gondor.apana.org.au; > linux-ker...@vger.kernel.org; virtualization@lists.li

RE: [PATCH v3 4/4] virtio-crypto: rename skcipher algs

2022-03-04 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Wednesday, March 2, 2022 11:39 AM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker.

RE: [PATCH v3 3/4] virtio-crypto: implement RSA algorithm

2022-03-04 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Wednesday, March 2, 2022 11:39 AM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker.

RE: [PATCH v3 2/4] virtio-crypto: introduce akcipher service

2022-03-04 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Wednesday, March 2, 2022 11:39 AM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker.

RE: PING: [PATCH v2 3/3] virtio-crypto: implement RSA algorithm

2022-03-01 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Tuesday, March 1, 2022 6:26 PM > To: Gonglei (Arei) > Cc: jasow...@redhat.com; m...@redhat.com; > virtualization@lists.linux-foundation.org; linux-cry...@vger.kernel.org; > linux-k

RE: [PATCH v2 1/3] virtio-crypto: header update

2022-02-17 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Friday, February 11, 2022 4:44 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; qem

RE: [PATCH v2 2/3] virtio-crypto: introduce akcipher service

2022-02-17 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Friday, February 11, 2022 4:41 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker.

RE: [PATCH v2 3/3] virtio-crypto: implement RSA algorithm

2022-02-17 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Friday, February 11, 2022 4:41 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker.

RE: RE: [PATCH 2/3] virtio-crypto: introduce akcipher service

2022-02-10 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, February 10, 2022 4:18 PM > To: Gonglei (Arei) > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker...@vger.kern

RE: [PATCH 2/3] virtio-crypto: introduce akcipher service

2022-02-09 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Friday, January 21, 2022 10:25 AM > To: m...@redhat.com; Gonglei (Arei) > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker.

RE: [PATCH 1/3] virtio_crypto: Introduce VIRTIO_CRYPTO_NOSPC

2022-02-09 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Friday, January 21, 2022 10:25 AM > To: m...@redhat.com; Gonglei (Arei) > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker.

RE: [PATCH v2 2/2] crypto: virtio: Fix use-after-free in virtio_crypto_skcipher_finalize_req()

2020-05-26 Thread Gonglei (Arei)
> -Original Message- > From: Longpeng (Mike, Cloud Infrastructure Service Product Dept.) > Sent: Tuesday, May 26, 2020 11:20 AM > To: linux-cry...@vger.kernel.org > Cc: Longpeng (Mike, Cloud Infrastructure Service Product Dept.) > ; LABBE Corentin ; Gonglei >

RE: [CRASH] crypto: virtio: crash when modprobing tcrypt on 5.5-rc7 / next-20200122

2020-02-23 Thread Gonglei (Arei)
> -Original Message- > From: LABBE Corentin [mailto:cla...@baylibre.com] > Sent: Friday, February 21, 2020 3:16 AM > To: Gonglei (Arei) > Cc: jasow...@redhat.com; herb...@gondor.apana.org.au; > da...@davemloft.net; virtualization@lists.linux-foundatio

RE: [PATCH 1/6] virtio: wrap find_vqs

2017-03-29 Thread Gonglei (Arei)
| 3 +-- > drivers/virtio/virtio_input.c | 3 +-- > include/linux/virtio_config.h | 9 + > net/vmw_vsock/virtio_transport.c | 6 +++--- > 12 files changed, 24 insertions(+), 23 deletions(-) > Acked-by: Gonglei <arei.gong...@hua

[PATCH v2] virtio-crypto: adjust priority of algorithm

2017-01-13 Thread Gonglei
than the hardware ones. Suggested-by: Christian Borntraeger <borntrae...@de.ibm.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> --- v2: fix three typos. [Christian] --- drivers/crypto/virtio/virtio_crypto_alg

RE: [PATCH] virtio-crypto: adjust priority of algorithm

2017-01-13 Thread Gonglei (Arei)
> > From: Christian Borntraeger [mailto:borntrae...@de.ibm.com] > Sent: Friday, January 13, 2017 4:28 PM > To: Gonglei (Arei); virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker...@vger.kernel.org > Cc: m...@redhat.com; herb...@gondor.apana.or

[PATCH] virtio-crypto: adjust priority of algorithm

2017-01-12 Thread Gonglei
than the hardware ones. Suggested-by: Christian Borntraeger <borntrae...@de.ibm.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> --- drivers/crypto/virtio/virtio_crypto_algs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/virtio/virtio_cryp

RE: [PATCH v8 1/1] crypto: add virtio-crypto driver

2017-01-12 Thread Gonglei (Arei)
> > On Thu, Jan 12, 2017 at 03:10:25PM +0100, Christian Borntraeger wrote: > > On 01/10/2017 01:56 PM, Christian Borntraeger wrote: > > > On 01/10/2017 01:36 PM, Gonglei (Arei) wrote: > > >> Hi, > > >> > >

RE: [PATCH v8 1/1] crypto: add virtio-crypto driver

2017-01-10 Thread Gonglei (Arei)
Hi, > > On 12/15/2016 03:03 AM, Gonglei wrote: > [...] > > + > > +static struct crypto_alg virtio_crypto_algs[] = { { > > + .cra_name = "cbc(aes)", > > + .cra_driver_name = "virtio_crypto_aes_cbc", > > + .cra_priority = 501, >

[PATCH] virtio-crypto: support crypto engine framework

2016-12-26 Thread Gonglei
rtqueue so that we can use the capability of multiple data queues in future. Cc: Baolin Wang <baolin.w...@linaro.org> Cc: Herbert Xu <herb...@gondor.apana.org.au> Cc: Michael S. Tsirkin <m...@redhat.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> --- drivers/crypto/

RE: [virtio-dev] Re: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver

2016-12-15 Thread Gonglei (Arei)
Hi Michael, > > > > > > > > Subject: RE: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver > > > > > > On Thursday, December 15, 2016 8:45 AM, Gonglei (Arei) Wrote: > > > < > > diff --git a/drivers/crypto/v

[PATCH v8 1/1] crypto: add virtio-crypto driver

2016-12-14 Thread Gonglei
a...@linux.vnet.ibm.com> CC: David S. Miller <da...@davemloft.net> CC: Zeng Xin <xin.z...@intel.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> --- MAINTAINERS | 9 + drivers/crypto/Kconfig | 2 + drivers/crypt

[PATCH v8 0/1] virtio-crypto: add Linux driver

2016-12-14 Thread Gonglei
evices in patch 1. Gonglei (1): crypto: add virtio-crypto driver MAINTAINERS | 9 + drivers/crypto/Kconfig | 2 + drivers/crypto/Makefile | 1 + drivers/crypto/virtio/Kconfig| 10 + drivers/crypt

RE: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver

2016-12-14 Thread Gonglei (Arei)
Regards, -Gonglei > -Original Message- > From: Zeng, Xin [mailto:xin.z...@intel.com] > Sent: Thursday, December 15, 2016 8:59 AM > To: Gonglei (Arei); Halil Pasic; linux-ker...@vger.kernel.org; > qemu-de...@nongnu.org; virtio-...@lists.oasis-open.org; > virtuali

RE: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver

2016-12-14 Thread Gonglei (Arei)
> > > On 12/14/2016 12:50 PM, Gonglei wrote: > > diff --git a/drivers/crypto/virtio/virtio_crypto_core.c > b/drivers/crypto/virtio/virtio_crypto_core.c > > new file mode 100644 > > index 000..c0854a1 > > --- /dev/null > > +++ b/drivers/crypto/virt

[PATCH v7 1/1] crypto: add virtio-crypto driver

2016-12-14 Thread Gonglei
a...@linux.vnet.ibm.com> CC: David S. Miller <da...@davemloft.net> CC: Zeng Xin <xin.z...@intel.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> --- MAINTAINERS | 9 + drivers/crypto/Kconfig | 2 + drivers/crypt

[PATCH v7 0/1] virtio-crypto: add Linux driver

2016-12-14 Thread Gonglei
=y [Salvatore] - convert __virtio32/64 to __le32/64 in virtio_crypto.h - remove VIRTIO_CRYPTO_S_STARTED based on the lastest virtio crypto spec. - introduces the little edian functions for VIRTIO_1 devices in patch 1. Gonglei (1): crypto: add virtio-crypto driver

RE: [PATCH v6 2/2] crypto: add virtio-crypto driver

2016-12-14 Thread Gonglei (Arei)
Hi, > > Subject: Re: [PATCH v6 2/2] crypto: add virtio-crypto driver > > > > On 12/12/2016 11:05 PM, Michael S. Tsirkin wrote: > > On Mon, Dec 12, 2016 at 06:54:07PM +0800, Herbert Xu wrote: > >> On Mon, Dec 12, 2016 at 06:25:12AM +, Gonglei (Arei) w

RE: [PATCH v6 2/2] crypto: add virtio-crypto driver

2016-12-12 Thread Gonglei (Arei)
> > Subject: Re: [PATCH v6 2/2] crypto: add virtio-crypto driver > > On Mon, Dec 12, 2016 at 06:54:07PM +0800, Herbert Xu wrote: > > On Mon, Dec 12, 2016 at 06:25:12AM +, Gonglei (Arei) wrote: > > > Hi, Michael & Herbert > > > > > > Because th

RE: [PATCH v6 2/2] crypto: add virtio-crypto driver

2016-12-11 Thread Gonglei (Arei)
4.10 merge window timing from Linus https://lkml.org/lkml/2016/12/7/506 Dec 23rd is the deadline for 4.10 merge window. Regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, December 08, 2016 12:37 PM > Subject: [PATCH v6 2/2] crypto: add virt

RE: [PATCH v6 1/2] sparc: fix a building error reported by kbuild

2016-12-10 Thread Gonglei (Arei)
Regards, -Gonglei > -Original Message- > From: linux-crypto-ow...@vger.kernel.org > [mailto:linux-crypto-ow...@vger.kernel.org] On Behalf Of Sam Ravnborg > Sent: Saturday, December 10, 2016 5:59 AM > To: Gonglei (Arei) > Cc: linux-ker...@vger.kernel.org; qem

[PATCH v6 2/2] crypto: add virtio-crypto driver

2016-12-07 Thread Gonglei
a...@linux.vnet.ibm.com> CC: David S. Miller <da...@davemloft.net> CC: Zeng Xin <xin.z...@intel.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> --- MAINTAINERS | 9 + drivers/crypto/Kconfig | 2 + drivers/crypt

[PATCH v6 1/2] sparc: fix a building error reported by kbuild

2016-12-07 Thread Gonglei
y_64.h. Cc: Sam Ravnborg <s...@ravnborg.org> Cc: David S. Miller <da...@davemloft.net> Cc: sparcli...@vger.kernel.org Suggested-by: Sam Ravnborg <s...@ravnborg.org> Signed-off-by: Gonglei <arei.gong...@huawei.com> --- arch/sparc/include/asm/topology_64.h | 1 + 1 file chang

[PATCH v6 0/2] virtio-crypto: add Linux driver

2016-12-07 Thread Gonglei
/64 in virtio_crypto.h - remove VIRTIO_CRYPTO_S_STARTED based on the lastest virtio crypto spec. - introduces the little edian functions for VIRTIO_1 devices in patch 1. Gonglei (2): sparc: fix a building error reported by kbuild crypto: add virtio-crypto driver MAINTAIN

RE: [PATCH v5 1/1] crypto: add virtio-crypto driver

2016-12-07 Thread Gonglei (Arei)
Hi Sam, > > Subject: Re: [PATCH v5 1/1] crypto: add virtio-crypto driver > > On Mon, Dec 05, 2016 at 03:12:52AM +0000, Gonglei (Arei) wrote: > > I don't think the root cause of those warnings are introduced by > > virtio-crypto > driver. > > > > What's

RE: [PATCH v5 1/1] crypto: add virtio-crypto driver

2016-12-07 Thread Gonglei (Arei)
> > Subject: Re: [PATCH v5 1/1] crypto: add virtio-crypto driver > > On Tue, Dec 06, 2016 at 09:01:49AM +0000, Gonglei (Arei) wrote: > > > > Would you please review and/or ack the virtio_crypto_algs.c? > > It is the realization of specified algs based on Linux

RE: [PATCH v5 1/1] crypto: add virtio-crypto driver

2016-12-06 Thread Gonglei (Arei)
Hi Herbert, Would you please review and/or ack the virtio_crypto_algs.c? It is the realization of specified algs based on Linux Crypto Framework. Thanks! Regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, December 01, 2016 8:39 PM > T

RE: [PATCH v5 1/1] crypto: add virtio-crypto driver

2016-12-04 Thread Gonglei (Arei)
I don't think the root cause of those warnings are introduced by virtio-crypto driver. What's your opinion? Sam and David? Thanks, -Gonglei > -Original Message- > From: kbuild test robot [mailto:l...@intel.com] > Sent: Sunday, December 04, 2016 10:40 AM > Subject: Re: [

[PATCH v5 1/1] crypto: add virtio-crypto driver

2016-12-01 Thread Gonglei
a...@linux.vnet.ibm.com> CC: David S. Miller <da...@davemloft.net> CC: Zeng Xin <xin.z...@intel.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> --- MAINTAINERS | 9 + drivers/crypto/Kconfig | 2 + drivers/crypt

[PATCH v5 0/1] virtio-crypto: add Linux driver

2016-12-01 Thread Gonglei
top doing DMA from the stack, CONFIG_VMAP_STACK=y [Salvatore] - convert __virtio32/64 to __le32/64 in virtio_crypto.h - remove VIRTIO_CRYPTO_S_STARTED based on the lastest virtio crypto spec. - introduces the little edian functions for VIRTIO_1 devices in patch 1. Gonglei (1): crypto: add vir

RE: [PATCH v4 1/1] crypto: add virtio-crypto driver

2016-12-01 Thread Gonglei (Arei)
> > On Thu, Dec 01, 2016 at 02:27:19AM +, Gonglei (Arei) wrote: > > > On Tue, Nov 29, 2016 at 08:48:14PM +0800, Gonglei wrote: > > > > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c > > > b/drivers/crypto/virtio/virtio_crypto_algs.c > > >

RE: [PATCH v4 1/1] crypto: add virtio-crypto driver

2016-12-01 Thread Gonglei (Arei)
> > Subject: Re: [PATCH v4 1/1] crypto: add virtio-crypto driver > > On Thu, Dec 01, 2016 at 02:27:19AM +0000, Gonglei (Arei) wrote: > > > On Tue, Nov 29, 2016 at 08:48:14PM +0800, Gonglei wrote: > > > > +static int virtio_crypto_alg_ablkcipher_init_sessio

RE: [PATCH v4 1/1] crypto: add virtio-crypto driver

2016-11-30 Thread Gonglei (Arei)
Hi Stefan, > > On Tue, Nov 29, 2016 at 08:48:14PM +0800, Gonglei wrote: > > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c > b/drivers/crypto/virtio/virtio_crypto_algs.c > > new file mode 100644 > > index 000..08b077f > > --- /dev/nul

[PATCH v4 0/1] virtio-crypto: add Linux driver

2016-11-29 Thread Gonglei
est virtio crypto spec. - introduces the little edian functions for VIRTIO_1 devices in patch 1. Gonglei (1): crypto: add virtio-crypto driver MAINTAINERS | 9 + drivers/crypto/Kconfig | 2 + drivers/crypto/Makef

[PATCH v4 1/1] crypto: add virtio-crypto driver

2016-11-29 Thread Gonglei
a...@linux.vnet.ibm.com> CC: David S. Miller <da...@davemloft.net> CC: Zeng Xin <xin.z...@intel.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> --- MAINTAINERS | 9 + drivers/crypto/Kconfig | 2 + drivers/crypt

RE: [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-29 Thread Gonglei (Arei)
> > Subject: Re: [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver > > On Tue, 29 Nov 2016 01:37:44 +0000 > "Gonglei (Arei)" <arei.gong...@huawei.com> wrote: > > > > On Mon, 28 Nov 2016 20:08:23 +0800 > > > Gonglei <ar

RE: [PATCH v3] crypto: add virtio-crypto driver

2016-11-29 Thread Gonglei (Arei)
> > > On Tue, Nov 29, 2016 at 08:22:58AM +, Gonglei (Arei) wrote: > > > Hi, > > > > > > > > > > +source "drivers/crypto/virtio/Kconfig" > > > > > > > + > > > > > > > endif # CRYPTO_HW >

RE: [PATCH v3] crypto: add virtio-crypto driver

2016-11-29 Thread Gonglei (Arei)
> > On Tue, Nov 29, 2016 at 08:22:58AM +, Gonglei (Arei) wrote: > > Hi, > > > > > > > > +source "drivers/crypto/virtio/Kconfig" > > > > > > + > > > > > > endif # CRYPTO_HW > > > > > > diff

RE: [PATCH v3] crypto: add virtio-crypto driver

2016-11-29 Thread Gonglei (Arei)
isn't compiled. # insmod virtio_crypto.ko insmod: ERROR: could not insert module virtio_crypto.ko: Unknown symbol in module # dmesg [74339.311801] virtio_crypto: Unknown symbol virtqueue_is_broken (err 0) [74339.311816] virtio_crypto: Unknown symbol crypto_register_algs (err 0) [

RE: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Gonglei (Arei)
; > multiple crypto devices (e.g. with different capabilities)? > > > Actually there is a simple schedule algorithms in virtcrypto_get_dev_node(), > which return the device used fewest on the node. > > If we don't find a device in

RE: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Gonglei (Arei)
if (virtqueue_kick_prepare(vq)) return virtqueue_notify(vq); return true; } If virtqueue_kick_prepare return ture, then notify which causes an ioport write. Let me remove the comments avoid confusions. > I know we have the same message in virt

RE: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Gonglei (Arei)
Hi Michael and Stefan, > > Subject: Re: [PATCH v3] crypto: add virtio-crypto driver > > On Mon, Nov 28, 2016 at 04:20:55PM +, Stefan Hajnoczi wrote: > > On Mon, Nov 28, 2016 at 08:08:23PM +0800, Gonglei wrote: > > > This patch introduces virtio-cry

RE: [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Gonglei (Arei)
> > Subject: [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver > > On Mon, 28 Nov 2016 20:08:23 +0800 > Gonglei <arei.gong...@huawei.com> wrote: > > > +static int virtcrypto_update_status(struct virtio_crypto *vcrypto) > > +{

[PATCH v3] virtio-crypto: add Linux driver

2016-11-28 Thread Gonglei
v2: - stop doing DMA from the stack, CONFIG_VMAP_STACK=y [Salvatore] - convert __virtio32/64 to __le32/64 in virtio_crypto.h - remove VIRTIO_CRYPTO_S_STARTED based on the lastest virtio crypto spec. - introduces the little edian functions for VIRTIO_1 devices in patch 1. Gonglei (1): crypto:

RE: [virtio-dev] Re: [PATCH v2 2/2] crypto: add virtio-crypto driver

2016-11-27 Thread Gonglei (Arei)
> > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Monday, November 28, 2016 1:09 PM > To: Gonglei (Arei) > Subject: Re: [virtio-dev] Re: [PATCH v2 2/2] crypto: add virtio-crypto driver > > On Mon, Nov 28, 2016 at 04:47:21AM +, Gonglei (Arei) wrote: > &g

RE: [virtio-dev] Re: [PATCH v2 2/2] crypto: add virtio-crypto driver

2016-11-27 Thread Gonglei (Arei)
Hi Michael, > > Subject: [virtio-dev] Re: [PATCH v2 2/2] crypto: add virtio-crypto driver > > On Tue, Nov 22, 2016 at 04:10:23PM +0800, Gonglei wrote: > > This patch introduces virtio-crypto driver for Linux Kernel. > > > > The virtio crypto device is a virtual c

RE: [virtio-dev] Re: [PATCH v2 1/2] virtio: introduce little edian functions for virtio_cread/write# family

2016-11-27 Thread Gonglei (Arei)
> > Subject: Re: [virtio-dev] Re: [PATCH v2 1/2] virtio: introduce little edian > functions for virtio_cread/write# family > > On Mon, Nov 28, 2016 at 04:34:56AM +0200, Michael S. Tsirkin wrote: > > On Mon, Nov 28, 2016 at 01:56:04AM +, Gonglei (Arei) wr

RE: [virtio-dev] Re: [PATCH v2 1/2] virtio: introduce little edian functions for virtio_cread/write# family

2016-11-27 Thread Gonglei (Arei)
> > Subject: Re: [virtio-dev] Re: [PATCH v2 1/2] virtio: introduce little edian > functions for virtio_cread/write# family > > On Mon, Nov 28, 2016 at 01:56:04AM +, Gonglei (Arei) wrote: > > Hi Michael, > > > > Thanks for your feedback firstly! > > >

RE: [virtio-dev] Re: [PATCH v2 1/2] virtio: introduce little edian functions for virtio_cread/write# family

2016-11-27 Thread Gonglei (Arei)
Hi Michael, Thanks for your feedback firstly! > -Original Message- > From: virtio-...@lists.oasis-open.org [mailto:virtio-...@lists.oasis-open.org] > On Behalf Of Michael S. Tsirkin > Sent: Sunday, November 27, 2016 11:33 AM > To: Gonglei (Arei) > Subject: [virtio-dev]

RE: [PATCH v2 0/2] virtio-crypto: add Linux driver

2016-11-26 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Gonglei (Arei) > Sent: Tuesday, November 22, 2016 4:10 PM > To: linux-ker...@vger.kernel.org; qemu-de...@nongnu.org; > virtio-...@lists.oasis-open.org; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org > S

RE: [PATCH 0/2] virtio: fix complaint by sparse

2016-11-26 Thread Gonglei (Arei)
Ping...? > -Original Message- > From: Gonglei (Arei) > Sent: Tuesday, November 22, 2016 1:52 PM > To: virtualization@lists.linux-foundation.org; linux-ker...@vger.kernel.org > Cc: m...@redhat.com; jasow...@redhat.com; Gonglei (Arei) > Subject: [PATCH 0/2] virtio: fix c

[PATCH v2 0/2] virtio-crypto: add Linux driver

2016-11-22 Thread Gonglei
in patch 1. Gonglei (2): virtio: introduce little edian functions for virtio_cread/write# family crypto: add virtio-crypto driver MAINTAINERS | 8 + drivers/crypto/Kconfig | 2 + drivers/crypto/Makefile | 1

[PATCH v2 2/2] crypto: add virtio-crypto driver

2016-11-22 Thread Gonglei
a...@linux.vnet.ibm.com> CC: David S. Miller <da...@davemloft.net> CC: Zeng Xin <xin.z...@intel.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> --- MAINTAINERS | 8 + drivers/crypto/Kconfig | 2 + drivers/crypt

[PATCH v2 1/2] virtio: introduce little edian functions for virtio_cread/write# family

2016-11-22 Thread Gonglei
Virtio modern devices are always little edian, let's introduce the LE functions for read/write configuration space for virtio modern devices, which avoid complaint by Sparse when we use the virtio_creaed/virtio_cwrite in VIRTIO_1 devices. Signed-off-by: Gonglei <arei.gong...@huawei.

[PATCH 1/2] virtio_pci_modern: fix complaint by sparse

2016-11-21 Thread Gonglei
: incorrect type in argument 2 (different base types) drivers/virtio/virtio_pci_modern.c:152:32:expected unsigned int [noderef] [usertype] *addr Signed-off-by: Gonglei <arei.gong...@huawei.com> --- drivers/virtio/virtio_pci_modern.c | 8 1 file changed, 4 insertions(+), 4 del

[PATCH 0/2] virtio: fix complaint by sparse

2016-11-21 Thread Gonglei
I found some warnings reported by sparse in the virtio code when I checked virtio-crypto's driver stuff. Let's fix them. Gonglei (2): virtio_pci_modern: fix complaint by sparse virtio_ring: fix complaint by sparse drivers/virtio/virtio_pci_modern.c | 8 drivers/virtio/virtio_ring.c

[PATCH 2/2] virtio_ring: fix complaint by sparse

2016-11-21 Thread Gonglei
__virtio16 degrades to integer Signed-off-by: Gonglei <arei.gong...@huawei.com> --- drivers/virtio/virtio_ring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 489bfc6..d2863c3 100644 --- a/drivers/virt

RE: [PATCH] crypto: add virtio-crypto driver

2016-11-21 Thread Gonglei (Arei)
Hi Michael, May I should convert all __virtio32/64 to le32/64 in virtio_crypto.h ? > +#define VIRTIO_CRYPTO_OPCODE(service, op) (((service) << 8) | (op)) > + > +struct virtio_crypto_ctrl_header { > +#define VIRTIO_CRYPTO_CIPHER_CREATE_SESSION \ > +

[PATCH] crypto: add virtio-crypto driver

2016-11-21 Thread Gonglei
a...@linux.vnet.ibm.com> CC: David S. Miller <da...@davemloft.net> CC: Zeng Xin <xin.z...@intel.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> --- MAINTAINERS | 8 + drivers/crypto/Kconfig | 2 + drivers/crypt

Re: [PATCH] vhost-scsi: introduce an ioctl to get the minimum tpgt

2015-01-30 Thread Gonglei
On 2015/1/26 21:13, Gonglei (Arei) wrote: From: Gonglei arei.gong...@huawei.com In order to support to assign a boot order for vhost-scsi device, we should get the tpgt for user level (such as Qemu). and at present, we only support the minimum tpgt can boot. Ping... Signed-off