[vpp-dev] Congrats to Marco Varlese on his election as a vpp project committer

2018-02-08 Thread Dave Barach (dbarach)
It gives me great pleasure to announce Marco's election as a vpp project committer, confirmed a few minutes ago by the fd.io vpp TSC. Vanessa V. will take care of [+2 button] mechanics shortly. Thanks much to Marco for his interest in the vpp project! Dave

Re: [vpp-dev] SCTP coverity-scan warnings addressed

2018-02-08 Thread Dave Barach (dbarach)
+1, thanks Marco...! -Original Message- From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Luke, Chris Sent: Thursday, February 8, 2018 7:06 AM To: Marco Varlese Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] SCTP coverity-scan warnings

[vpp-dev] FW: New Committer Nomination: Marco Varlese

2018-02-06 Thread Dave Barach (dbarach)
Copying the list... From: Luke, Chris [mailto:chris_l...@comcast.com] Sent: Tuesday, February 6, 2018 11:40 AM To: Dave Barach (dbarach) <dbar...@cisco.com>; Keith Burns (krb) <k...@cisco.com>; Florin Coras (fcoras) <fco...@cisco.com>; John Lo (loj) <l...@cisco.com>;

[vpp-dev] FW: New Committer Nomination: Marco Varlese

2018-02-06 Thread Dave Barach (dbarach)
To record Damjan’s vote… From: Damjan Marion (damarion) Sent: Tuesday, February 6, 2018 9:07 AM To: Dave Barach (dbarach) <dbar...@cisco.com> Cc: Keith Burns (krb) <k...@cisco.com>; Florin Coras (fcoras) <fco...@cisco.com>; John Lo (loj) <l...@cisco.com>; Luke, Chris

[vpp-dev] New fd.io vpp project committer vote: Marco Varlese

2018-02-06 Thread Dave Barach (dbarach)
Copying vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> to formally open the vote described below. Voting is limited to current committers, and will remain open for 1 week, or until folks have voted. Thanks. Dave From: Dave Barach (dbarach) Sent: Tuesday, February 6, 2018 8

Re: [vpp-dev] Calling a C function in one plugin from another plugin?

2018-02-05 Thread Dave Barach (dbarach)
You can ask vlib_get_plugin_symbol ("plugin_name", "function_name") for the address of a function... Returns NULL if e.g. the plugin in question isn't loaded or the symbol is missing. HTH... D. -Original Message- From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io]

Re: [vpp-dev] unformat %s eats newlines

2018-02-02 Thread Dave Barach (dbarach)
should not go unnoticed: the next function up the parse stack will complain. IIWY I’d leave unformat(…) alone. HTH… D. From: Andreas Schultz [mailto:andreas.schu...@travelping.com] Sent: Friday, February 2, 2018 3:26 PM To: Dave Barach (dbarach) <dbar...@cisco.com> Cc: vpp-dev@lists.fd.io S

Re: [vpp-dev] unformat %s eats newlines

2018-02-02 Thread Dave Barach (dbarach)
Why not simply: while (…) { if (unformat(input, “name %s”, )) ; else if (…) ; else break; } if () return clib_error_return (0, "parse error: '%U'", format_unformat_error, input); D. From: vpp-dev-boun...@lists.fd.io

Re: [vpp-dev] How to get dns server of dhcp client interface

2018-01-31 Thread Dave Barach (dbarach)
Option 6 (dhcp server) parsing is not implemented. See …/src/vnet/dhcp/client.c, switch statement near line 112… Should be a simple coding task. Feel free to submit a patch. Worst-case, file a Jira ticket so we don’t forget about it. Thanks… Dave From: vpp-dev-boun...@lists.fd.io

Re: [vpp-dev] VPP Graph Optimization

2018-01-26 Thread Dave Barach (dbarach)
Dear David, A bit of history. We worked on vpp for a decade before making any serious effort to multi-thread it. The first scheme that I tried was to break up the graph into reconfigurable pipeline stages. Effective partitioning of the graph is highly workload-dependent, and it can change

Re: [vpp-dev] openSUSE build fails

2018-01-26 Thread Dave Barach (dbarach)
s.org> Cc: Dave Barach (dbarach) <dbar...@cisco.com>; Gabriel Ganne <gabriel.ga...@enea.com>; Billy McFall <bmcf...@redhat.com>; Damjan Marion (damarion) <damar...@cisco.com>; vpp-dev <vpp-dev@lists.fd.io> Subject: RE: [vpp-dev] openSUSE build fails Hi Marco, Than

Re: [vpp-dev] VPP 18.01 Release artifacts are now available on nexus.fd.io

2018-01-25 Thread Dave Barach (dbarach)
Congrats to DaveW and the rest of the fd.io vpp team on the 18.01 release! From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Dave Wallace Sent: Thursday, January 25, 2018 12:23 AM To: vpp-dev@lists.fd.io; csit-...@lists.fd.io Subject: [vpp-dev] VPP 18.01 Release

Re: [vpp-dev] Missing PLY ?

2018-01-24 Thread Dave Barach (dbarach)
“$ make install-dep” fixed it for me… D. From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Jon Loeliger Sent: Wednesday, January 24, 2018 1:58 PM To: vpp-dev Subject: [vpp-dev] Missing PLY ? Hey Kids, The new API Gen seems to want

Re: [vpp-dev] Question and bug found on GTP performance testing

2018-01-24 Thread Dave Barach (dbarach)
We're not going to turn vnet_register_interface(...) into an epic catalog of special-purpose strcmp's. Any patch which looks the least bit like the diffs shown below is guaranteed to be scored -2, and never merged. Please let John propose a mechanism to address this issue. Thanks... Dave

Re: [vpp-dev] heap per thread

2018-01-24 Thread Dave Barach (dbarach)
Yes, it’s possible. This is not the obvious way to do it. Before I answer any questions: what are you trying to accomplish? Idiomatic vpp coding techniques typically don’t result in enough memory allocator traffic to make it worth using per-thread heaps. D. From: vpp-dev-boun...@lists.fd.io

Re: [vpp-dev] RFC: Error Codes

2018-01-23 Thread Dave Barach (dbarach)
Right. The error number base needs to be managed just like the message ID base… D. From: Jon Loeliger [mailto:j...@netgate.com] Sent: Tuesday, January 23, 2018 9:39 AM To: Ole Troan <otr...@employees.org> Cc: Dave Barach (dbarach) <dbar...@cisco.com>; vpp-dev <vpp-dev@lists.fd.

Re: [vpp-dev] How to link zmq library to new plugin in vpp

2018-01-23 Thread Dave Barach (dbarach)
This report leaves a bit to be desired. As in: "configure file" means what? Where is the build output? Laying that aside, if your plugin is called xxx, try adding: xxx_plugin_la_LIBADD += -lzmq to src/plugins/xxx.am... HTH... Dave From: vpp-dev-boun...@lists.fd.io

Re: [vpp-dev] RFC: Error Codes

2018-01-23 Thread Dave Barach (dbarach)
-- From: Ole Troan [mailto:otr...@employees.org] Sent: Tuesday, January 23, 2018 5:41 AM To: Dave Barach (dbarach) <dbar...@cisco.com>; Jon Loeliger <j...@netgate.com> Cc: vpp-dev <vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] RFC: Error Codes Dave, Jon, > On 22 Jan 2018, at 19:

Re: [vpp-dev] RFC: Error Codes

2018-01-22 Thread Dave Barach (dbarach)
Dear Jon, That makes sense to me. Hopefully Ole will comment with respect to adding statements of the form error { FOO_NOT_AVAILABLE, “Resource ‘foo’ is not available } ; to the new Python PLY-based API generator. The simple technique used to allocate plugin message-ID’s seems to work OK to

Re: [vpp-dev] Create an arc

2018-01-17 Thread Dave Barach (dbarach)
Dear Korian, Steering traffic from ip4_lookup to is easily accomplished by setting the fib result [dpo->dpoi_next_node] to send matching traffic where you want it to go. Add an arc from ip4/6_lookup to by calling vlib_node_add_next(...) to create the arc, then create fib entries with

Re: [vpp-dev] Proposal to remove ssvm_eth

2018-01-13 Thread Dave Barach (dbarach)
Dear Florin, Quite to the contrary: removing the ssvm_ethernet driver would be a Good Thing. I built it as a prototype a long time ago. It has not been widely adopted. Memif solves the same general problem [much better], so please go ahead... Thanks... Dave -Original Message- From:

Re: [vpp-dev] Memory Leakage Test By Valgrind

2018-01-08 Thread Dave Barach (dbarach)
Mheap.c has its own highly accurate memory leak checker. I haven’t tried the valgrind integration in many years. Valgrind makes vpp run slowly enough to make it unusable. To use the built-in leakfinder: build TAG=vpp_debug, set #define MHEAP_HAVE_SMALL_OBJECT_CACHE to 0 in

Re: [vpp-dev] VPP 18.01 RC1 milestone is complete!

2018-01-05 Thread Dave Barach (dbarach)
Hey Dave, thanks for all your work to make this happen! From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Dave Wallace Sent: Thursday, January 4, 2018 12:25 PM To: vpp-dev@lists.fd.io Subject: [vpp-dev] VPP 18.01 RC1 milestone is complete! Folks, The VPP 18.01

Re: [vpp-dev] 'pool_elt_at_index' Relative Addressing Cause a Mistake

2018-01-04 Thread Dave Barach (dbarach)
All of the pool_get(mypool, new_elt) variants are capable of expanding - and hence moving - mypool, leading to dangling references to free memory if you’re not careful. Here’s the usual coding pattern: old_elt = pool_elt_at_index (mypool, index); /* use old-elt */ pool_get (mypool, new_elt);

Re: [vpp-dev] VPP does not detect NIC automatically

2018-01-03 Thread Dave Barach (dbarach)
Dear Charlie, Vpp won't touch an interface if it has an associated Linux kernel interface which is up, and/or has an address configured on it. Manually unbinding the interface - as you did - makes the Linux kernel interface disappear. Accidentally whitelisting a host's management ethernet

[vpp-dev] No vpp project meeting 12/26/2017

2017-12-15 Thread Dave Barach (dbarach)
Have a great holiday season! Thanks... Dave P.S. Are folks interested in meeting on 1/2/2018, or should we reconvene on 1/9/2018? ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] openSUSE build fails

2017-12-15 Thread Dave Barach (dbarach)
Dear Marco, Thanks very much... Dave From: Marco Varlese [mailto:mvarl...@suse.de] Sent: Friday, December 15, 2017 9:06 AM To: Dave Barach (dbarach) <dbar...@cisco.com>; Gabriel Ganne <gabriel.ga...@enea.com>; Billy McFall <bmcf...@redhat.com> Cc: Damjan Marion (damarion) &

Re: [vpp-dev] openSUSE build fails

2017-12-15 Thread Dave Barach (dbarach)
With a bit of fiddling, I was able to fix gerrit 9440 so that indent 2.2.10 and 2.2.11 appear to produce identical results... HTH... Dave From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Gabriel Ganne Sent: Friday, December 15, 2017 8:42 AM To: Billy McFall

Re: [vpp-dev] openSUSE build fails

2017-12-15 Thread Dave Barach (dbarach)
Guys, I’ll take a look at e.g. gerrit 9440, ip_frag.c and see if I can fix it. Under the circumstances, it seems perfectly OK to s/ON/OFF/ as needed in the per-file patch verification on/off switch: /* * fd.io coding-style-patch-verification: ON * * Local Variables: * eval: (c-set-style "gnu")

Re: [vpp-dev] [discuss] New Option for fd.io mailing lists: groups.io

2017-12-14 Thread Dave Barach (dbarach)
Minor quibble with the assertion that we don’t “moderate” our discussions. I spend a bit of time every day dealing with messages sent e.g. to vpp-dev from (a) folks who aren’t members of the list, and (b) spam / phish emails. You’d be surprised how much category (b) email needs to be disposed

Re: [vpp-dev] undefined refrence to

2017-12-11 Thread Dave Barach (dbarach)
Gld doesn’t know that e.g. vpp_api.o needs e.g. format until after it’s already processed -lvppinfra. Reorder the command line. From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Samuel S Sent: Monday, December 11, 2017 2:05 AM To: vpp-dev@lists.fd.io Subject:

Re: [vpp-dev] Build error when trying to cross-compile vpp

2017-12-11 Thread Dave Barach (dbarach)
Look in config.log and work out the name of the compiler. Fix in .../build-data/platforms/x86_64.mk or override from the command line. From: nikhil ap [mailto:niks3...@gmail.com] Sent: Sunday, December 10, 2017 8:43 AM To: Dave Barach (dbarach) <dbar...@cisco.com> Cc: vpp-dev@lists.fd.io S

Re: [vpp-dev] MACIP ACL replace causes ip4_table_index change?

2017-12-11 Thread Dave Barach (dbarach)
(dbarach) <dbar...@cisco.com> Cc: Jon Loeliger <j...@netgate.com>; vpp-dev <vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] MACIP ACL replace causes ip4_table_index change? Dear Dave, On 12/9/17, Dave Barach (dbarach) <dbar...@cisco.com> wrote: > This looks wrong... vnet_set_i

Re: [vpp-dev] how to find vlib_buffer_t.data size(capacity) @ runtime?

2017-12-07 Thread Dave Barach (dbarach)
Interpret b->current_data, b->current_length, the buffer freelist index, and the related vlib_buffer_free_list_t structure. In most cases, b->packet_data is actually VLIB_BUFFER_DATA_SIZE (2048) bytes long. Look at the related vlib_buffer_free_list_t to know for sure. Current_data is a

Re: [vpp-dev] memory issues

2017-12-06 Thread Dave Barach (dbarach)
Before we crank up the vppinfra memory leakfinder, etc. etc.: cat /proc/`pidof vpp`/maps and have a hard stare at the output. Configure one step at a time, looking for significant changes in the address space layout. HTH… Dave From: vpp-dev-boun...@lists.fd.io

Re: [vpp-dev] some files are never compiled

2017-12-05 Thread Dave Barach (dbarach)
Merged... I’ll clean out some more junk and push another patch... Thanks… Dave From: Gabriel Ganne [mailto:gabriel.ga...@enea.com] Sent: Tuesday, December 5, 2017 10:14 AM To: Dave Barach (dbarach) <dbar...@cisco.com>; vpp-dev@lists.fd.io Subject: Re: some files are never compiled Thank

Re: [vpp-dev] Build error when trying to cross-compile vpp

2017-12-05 Thread Dave Barach (dbarach)
See also “bootstrap.sh...” $ make V=0 is_build_tool=yes tools-install Thanks… Dave From: nikhil ap [mailto:niks3...@gmail.com] Sent: Tuesday, December 5, 2017 9:11 AM To: Dave Barach (dbarach) <dbar...@cisco.com> Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] Build error when trying to

Re: [vpp-dev] some files are never compiled

2017-12-05 Thread Dave Barach (dbarach)
Dear Gabriel, The files mentioned below fall into several buckets: * Code samples which might reasonably move to .../extras * Things we’re not using at the moment, but which would take someone a good long time to build from scratch. * The simulated annealing driver in

Re: [vpp-dev] Build error when trying to cross-compile vpp

2017-12-05 Thread Dave Barach (dbarach)
Dear Nikhil, The first step in adding a new platform: construct .../build-data/plaforms/xxx.mk. There are several examples. Note the rule: xxx_native_tools = vppapigen This rule builds the missing build-host tool. Then: “make PLATFORM=xxx TAG=xxx_debug vpp-install” or similar. Caveat: the

Re: [vpp-dev] Question on node type "VLIB_NODE_TYPE_PROCESS"

2017-11-30 Thread Dave Barach (dbarach)
At least for now, process nodes run on the main thread. See line 1587 of .../src/vlib/main.c. The lldp-process is not super-complicated. Set a gdb breakpoint on line 157 [switch(event_type)], cause it to do something, and you can walk through it, etc. HTH... Dave From:

Re: [vpp-dev] problem in elog format

2017-11-30 Thread Dave Barach (dbarach)
: Thursday, November 30, 2017 12:50 AM To: Dave Barach (dbarach) <dbar...@cisco.com> Cc: Florin Coras <fcoras.li...@gmail.com>; vpp-dev@lists.fd.io Subject: Re: [vpp-dev] problem in elog format Thanks a lot, Now I want to convert elog file to text file. I compiled perftools in te

[vpp-dev] Frequently-asked questions wiki page

2017-11-29 Thread Dave Barach (dbarach)
Folks, Please see https://wiki.fd.io/view/VPP/FAQ. Additions welcome. I decided to start with a personal favorite... Thanks... Dave ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] problem in elog format

2017-11-29 Thread Dave Barach (dbarach)
PMFJI, but we have organized schemes for capturing, serializing, and eventually displaying string data. Please note: a single "format" call will probably cost more than the entire clock-cycle budget available to process a packet. Really. Seriously. Printfs (aka format calls) in the

Re: [vpp-dev] How to enable RSS in VPP

2017-11-28 Thread Dave Barach (dbarach)
You are sending traffic with more than one flow, correct? From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Saxena, Nitin Sent: Tuesday, November 28, 2017 11:45 AM To: vpp-dev@lists.fd.io Cc: Athreya, Narayana Prasad Subject:

Re: [vpp-dev] VPP crash observed with 4k sub-interfaces and 4k FIBs

2017-11-27 Thread Dave Barach (dbarach)
Laying aside the out-of-memory issue for a minute: can you explain the vpp deployment you have in mind? Given where vpp would fit in a normal network design, I’m not seeing why you’d want to go with a full vlan / VRF’s mesh. Thanks… Dave From: vpp-dev-boun...@lists.fd.io

Re: [vpp-dev] Import/includes in .api files

2017-11-20 Thread Dave Barach (dbarach)
Would some variant of the usual C / C++ guitar lick work? #ifndef __defined_my_types #define __defined_my_types #include #endif /* __defined_my_types */ -Original Message- From: Ole Troan [mailto:otr...@employees.org] Sent: Monday, November 20, 2017 10:32 AM To: Dave Barach (dbarach

Re: [vpp-dev] Import/includes in .api files

2017-11-20 Thread Dave Barach (dbarach)
Dear Neale, Since the beginning of time, we've been running .api files through the C preprocessor. Put all of your "typeonly..." definitions in a file, and #include it. Should work immediately. Thanks to Damjan, there's only one copy of the suffix rule, in .../src/suffix-rules.mk. Here's the

Re: [vpp-dev] Please Call DigSafe...

2017-11-17 Thread Dave Barach (dbarach)
Dear Chris, As you probably worked out, the forcing function for my email was a patch that both Florin and I -2'ed yesterday; a real stinker. I want to facilitate discussions of the form: "I'd like to implement X or fix Y. What's the right way to do it? Who should I talk to about that?"

Re: [vpp-dev] Discussion Topic: creating demo branches in git.fd.io/vpp

2017-11-15 Thread Dave Barach (dbarach)
+1... -Original Message- From: Ole Troan [mailto:otr...@employees.org] Sent: Wednesday, November 15, 2017 5:49 PM To: Dave Wallace <dwallac...@gmail.com> Cc: Ed Warnicke <hagb...@gmail.com>; Dave Barach (dbarach) <dbar...@cisco.com>; Keith Burns (krb) <k...@cis

Re: [vpp-dev] Discussion Topic: creating demo branches in git.fd.io/vpp

2017-11-15 Thread Dave Barach (dbarach)
? Thanks... Dave From: Dave Wallace [mailto:dwallac...@gmail.com] Sent: Wednesday, November 15, 2017 5:17 PM To: Ed Warnicke <hagb...@gmail.com>; Dave Barach (dbarach) <dbar...@cisco.com>; Keith Burns (krb) <k...@cisco.com>; Florin Coras (fcoras) <fco...@cisco.com>; John

Re: [vpp-dev] TCP Options: tcp_header_t and tcp_options_t

2017-11-14 Thread Dave Barach (dbarach)
Dear Justin, Brief commercial: hopefully you added your node to the ip4 unicast feature arc, configured to grab pkts, pre-ip4/6-lookup. In feature-arc land, the following one-liner sets next0 so pkts will visit the next enabled feature. The last node in the ip4-unicast feature arc is

Re: [vpp-dev] vlib_validate_buffer_enqueue

2017-11-13 Thread Dave Barach (dbarach)
Dear Justin, Quad-loops are generally not effective for table-lookup-intensive tasks. At a certain point, gcc runs out of registers and starts putting hot variables onto the stack. I've converted a number of dual loops into quad loops, only to discover that they're no faster than the dual loop

Re: [vpp-dev] make test-all

2017-11-13 Thread Dave Barach (dbarach)
Try increasing the size of the shared-memory API segment. An allocation of 25mb is failing. You might ask yourself how sane it is to generate that much output. Thanks… Dave -Original Message- From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Klement

Re: [vpp-dev] multi-core multi-threading performance

2017-11-08 Thread Dave Barach (dbarach)
Please write up what you’ve done, and provide a pointer to your code. Thanks… Dave From: Pragash Vijayaragavan [mailto:pxv3...@rit.edu] Sent: Wednesday, November 8, 2017 1:19 AM To: Dave Barach (dbarach) <dbar...@cisco.com> Cc: vpp-dev@lists.fd.io; John Marshall (jwm) <j...@cisco.co

Re: [vpp-dev] Simple setup, that does not work.

2017-11-07 Thread Dave Barach (dbarach)
Check host interface IP address, basic connectivity [cable on floor?], and so on. Check “show hardware.” If the MIB stats indicate that packets are reaching the NIC MAC layer - but not VPP - see if /proc/cmdline contains “intel_iommu=on”. If it does, try removing that stanza and reboot. You

Re: [vpp-dev] multi-core multi-threading performance

2017-11-06 Thread Dave Barach (dbarach)
How many RX queues did you provision? One per worker, or no supper... Thanks… Dave From: Pragash Vijayaragavan [mailto:pxv3...@rit.edu] Sent: Monday, November 6, 2017 7:36 AM To: Dave Barach (dbarach) <dbar...@cisco.com> Cc: vpp-dev@lists.fd.io; John Marshall (jwm) <j...@cisco.com>;

Re: [vpp-dev] multi-core multi-threading performance

2017-11-06 Thread Dave Barach (dbarach)
To: vpp-dev@lists.fd.io Cc: John Marshall (jwm) <j...@cisco.com>; Neale Ranns (nranns) <nra...@cisco.com>; Dave Barach (dbarach) <dbar...@cisco.com>; Minseok Kwon <mxk...@rit.edu> Subject: multi-core multi-threading performance Hi , We are measuring performance of ip6 lo

Re: [vpp-dev] VPP default graph

2017-10-31 Thread Dave Barach (dbarach)
Dear Mostafa, First, “show vlib graph” describes the entire graph in detail. Vpp uses ingress flow-hashing (e.g. hardware RSS hashing) across a set of threads running identical graph replicas to achieve multi-core scaling. Historical experiments with pipelining in vpp dissuaded me from

Re: [vpp-dev] gerrit 8872 centos validation failure (stable/1710)

2017-10-18 Thread Dave Barach (dbarach)
policer.lo' failed 14:09:30 make[5]: *** [vnet/policer/policer.lo] Error 1 14:09:30 Build step 'Execute shell' marked build as failure 14:09:30 $ ssh-agent -k 14:09:30 FATAL: Cannot run program "ssh-agent": error=12, Cannot allocate memory Thanks... Dave From: Dave Barach (dbarach) Sent: W

Re: [vpp-dev] VPP routing API dump

2017-10-18 Thread Dave Barach (dbarach)
Confirmed. Patch on the way... Thanks... Dave From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Dave Barach (dbarach) Sent: Wednesday, October 18, 2017 10:36 AM To: Samuel Elias -X (samelias - PANTHEON TECHNOLOGIES at Cisco) <samel...@cisco.com>; Neale

Re: [vpp-dev] VPP routing API dump

2017-10-18 Thread Dave Barach (dbarach)
Please don't assume that people scrub through jira tickets. If you'd sent email to vpp-dev, this would have been fixed ages ago. Without even looking at the code, I'll bet it's a single missing ntohl(...): (gdb) p/x 33554432 $1 = 0x200 Thanks... Dave From: vpp-dev-boun...@lists.fd.io

Re: [vpp-dev] vnet_buffer(b)-> sw_if_index[VLIB_TX] => fib index in ip[46]_lookup

2017-10-18 Thread Dave Barach (dbarach)
Dear John, I must've done a seriously defective [read: typo-ridden] search. Scratch that idea... Thanks for your help... Dave From: John Lo (loj) Sent: Wednesday, October 18, 2017 10:15 AM To: Dave Barach (dbarach) <dbar...@cisco.com>; vpp-dev@lists.fd.io Subject: RE: vnet_bu

[vpp-dev] gerrit 8872 centos validation failure (stable/1710)

2017-10-18 Thread Dave Barach (dbarach)
Please see https://gerrit.fd.io/r/#/c/8872 and https://jenkins.fd.io/job/vpp-verify-1710-centos7/53. I've already pressed the "recheck" button. The validation failure appears unrelated to the patch. Thanks... Dave 12:50:49 Wrote:

[vpp-dev] vnet_buffer(b)-> sw_if_index[VLIB_TX] => fib index in ip[46]_lookup

2017-10-18 Thread Dave Barach (dbarach)
Folks, Is anyone is actually using the "vnet_buffer(b)->sw_if_index[VLIB_TX] => [fib_index | ~0]" method to select the lookup fib index in ip[46]_lookup? If not, I would like to remove the corresponding code... Thanks... Dave ___ vpp-dev mailing

Re: [vpp-dev] not_last parameter of ip_add_del_route from ip.api

2017-10-18 Thread Dave Barach (dbarach)
Adding Neale for further comment, but I believe it's a FIB 1.0 historical artifact which has no obvious reason to exist at this point. Thanks... Dave From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Marek Gradzki -X (mgradzki - PANTHEON TECHNOLOGIES at Cisco)

Re: [vpp-dev] [FD.io Helpdesk #47101] No joy: ping6 gerrit.fd.io

2017-10-17 Thread Dave Barach (dbarach)
Ack... Thanks… Dave -Original Message- From: Anton Baranov via RT [mailto:fdio-helpd...@rt.linuxfoundation.org] Sent: Tuesday, October 17, 2017 11:57 AM To: Dave Barach (dbarach) <dbar...@cisco.com> Cc: vpp-dev@lists.fd.io Subject: [FD.io Helpdesk #47101] No joy: ping6 gerrit

Re: [vpp-dev] vpp deadlock - syslog in signal handler

2017-10-17 Thread Dave Barach (dbarach)
In almost all cases, the glibc malloc heap will not be pickled since it's not used on a regular basis. For some effort, one could replace the syslog library code, I guess. Thanks... Dave From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Gabriel Ganne Sent:

[vpp-dev] No joy: ping6 gerrit.fd.io

2017-10-16 Thread Dave Barach (dbarach)
It looks like gerrit.fd.io has dropped off the ipv6 radar screen. Appears not to be a DNS problem or other problem on my end: $ ping6 gerrit.fd.io PING gerrit.fd.io(2604:e100:1:0:f816:3eff:fe7e:8731) 56 data bytes ^C --- gerrit.fd.io ping statistics --- 4 packets transmitted, 0 received, 100%

Re: [vpp-dev] jvpp core future test failure (gerrit 8743)

2017-10-13 Thread Dave Barach (dbarach)
clib_warning ("Trying to register a NULL msg with a NULL msg id!"); clib_warning ("Did you forget to call setup_message_id_table?"); return; } Thanks… Dave From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Dave Barach (dbara

Re: [vpp-dev] jvpp core future test failure (gerrit 8743)

2017-10-13 Thread Dave Barach (dbarach)
Yes, I did. I just worked it out myself... Thanks… Dave From: Ole Troan (otroan) Sent: Friday, October 13, 2017 1:48 PM To: Ole Troan (otroan) <otr...@cisco.com> Cc: Dave Barach (dbarach) <dbar...@cisco.com>; Ole Troan <otr...@employees.org>; vpp-dev@lists.fd.io Subject: Re

[vpp-dev] jvpp core future test failure (gerrit 8743)

2017-10-13 Thread Dave Barach (dbarach)
Dear Ole, See https://gerrit.fd.io/r/#/c/8743. It turns out that the java core future "make test" test fails as shown below. The patch adds three xxx_reply_t binary api messages. See .../src/vnet/dns/dns.api. It sure looks like the Java code knows about them, but isn't doing a very good job

Re: [vpp-dev] [v17.07.01]: vec_add2() causing crash on ARMv8

2017-09-29 Thread Dave Barach (dbarach)
As a quick hack: try moving "u32 interrupt_pending;" to the start of the structure... Thanks… Dave -Original Message- From: Brian Brooks [mailto:brian.bro...@arm.com] Sent: Friday, September 22, 2017 12:33 PM To: Dave Barach (dbarach) <dbar...@cisco.com> Cc: Saxena,

Re: [vpp-dev] Compile error with linux/memfd.h

2017-09-28 Thread Dave Barach (dbarach)
Dear Eddie, As discussed in private email: I think that the version of CentOS on your build system is too old. If memory serves, CentOS 7.3 is required. Google tells me that the earliest Linux kernel with memfd support is 3.17; it looks like your system is running a 3.10 derivative:

Re: [vpp-dev] vlan sub interfaces

2017-09-28 Thread Dave Barach (dbarach)
See https://gerrit.fd.io/r/#/c/8590. The patch cherry-picked easily to stable/1707. Assuming that the cherry-pick patch validates - and that it solves your problem - it will be up to Neale [as the 17.07 release manager] whether to merge it or not. Please let us know whether the cherry-pick

Re: [vpp-dev] [v17.07.01]: vec_add2() causing crash on ARMv8

2017-09-28 Thread Dave Barach (dbarach)
Dear Nitin, First off: exactly which LDXR / STXR instruction variant pairs is generated? I begin to wonder if __sync_lock_test_and_set(...) might not be doing you any favors. Given that dq->interrupt_pending is a u32, I would have expected a 4-byte instruction with (at worst) a 4-byte

Re: [vpp-dev] Stable branch for 17.10 pulled

2017-09-28 Thread Dave Barach (dbarach)
+1... Thanks… Dave From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Luke, Chris Sent: Wednesday, September 27, 2017 11:15 PM To: Florin Coras ; vpp-dev Subject: Re: [vpp-dev] Stable branch for 17.10 pulled Great

Re: [vpp-dev] deadlock issue in VPP during DHCP packet processing

2017-09-26 Thread Dave Barach (dbarach)
Does this happen w/ master/latest? My guess: yes... Florin and I are working on a patch to fix an obvious issue in this path right now, look for results shortly... HTH... Dave From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Balaji Kn Sent: Tuesday,

Re: [vpp-dev] Poor L3/L4 Performance

2017-09-25 Thread Dave Barach (dbarach)
As discussed off-list: please stick to best-practice coding patterns. Single-packet frames simply cannot perform, etc. Thanks… Dave From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Alessio Silvestro Sent: Monday, September 25, 2017 10:13 AM To:

Re: [vpp-dev] Practical use of the include-what-you-use tool for individual developers

2017-09-23 Thread Dave Barach (dbarach)
Dear Burt, This is of interest, but I have concerns about boiling the ocean at this point in the release cycle. Please hold any patches on this topic until well after the 17.10 RC1 throttle branch pull. Although we haven’t caused ourselves massive pain with similar work - coding standards

Re: [vpp-dev] some issue about using unformat %u 

2017-09-20 Thread Dave Barach (dbarach)
Varargs functions effectively bypass strong type-checking. It can’t be helped. From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of wang.hu...@zte.com.cn Sent: Tuesday, September 19, 2017 11:34 PM To: vpp-dev@lists.fd.io Cc: gu.ji...@zte.com.cn;

Re: [vpp-dev] Multiple vppctl Considered Harmful

2017-09-19 Thread Dave Barach (dbarach)
Give me a minute, I'll try it right away... Thanks... Dave -Original Message- From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Jon Loeliger Sent: Tuesday, September 19, 2017 2:01 PM To: vpp-dev Subject: [vpp-dev] Multiple vppctl

Re: [vpp-dev] Coverity runs

2017-09-19 Thread Dave Barach (dbarach)
Very cool! Thanks for working on it... Dave From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Luke, Chris Sent: Tuesday, September 19, 2017 11:50 AM To: vpp-dev Subject: [vpp-dev] Coverity runs All, Coverity have increased the limits for

Re: [vpp-dev] VPP API Message Multi-Registration Question

2017-09-15 Thread Dave Barach (dbarach)
How about: only complain if the new registration is actually different from the old one? Thanks... Dave -Original Message- From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Jon Loeliger Sent: Friday, September 15, 2017 3:35 PM To: vpp-dev

Re: [vpp-dev] net/mlx5: install libmlx5 & libibverbs if no OFED

2017-09-13 Thread Dave Barach (dbarach)
I typically use "git commit --amend" followed by "git review [--draft]". HTH... Dave From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Shachar Beiser Sent: Wednesday, September 13, 2017 11:29 AM To: vpp-dev@lists.fd.io Cc: Shahaf Shuler ;

[vpp-dev] Spurious patch verification failure (gerrit 8400)

2017-09-13 Thread Dave Barach (dbarach)
See gerrit https://gerrit.fd.io/r/#/c/8400, https://jenkins.fd.io/job/vpp-verify-master-centos7/7070/console 12:29:12 make[1]: Leaving directory `/w/workspace/vpp-verify-master-centos7/test' 12:29:12 [vpp-verify-master-centos7] $ /bin/bash /tmp/hudson3100921859131279854.sh 12:29:12 Loaded

Re: [vpp-dev] vpp performance numbers with 10Gbps interface.

2017-09-12 Thread Dave Barach (dbarach)
+1. If you want to rx-and-drop packets, install a drop adjacency... Sending to an unrouteable address results in 100% icmp error replies... Thanks... Dave From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Florin Coras Sent: Tuesday, September 12, 2017 1:05 PM

Re: [vpp-dev] VPP 1704 and router plugin

2017-09-12 Thread Dave Barach (dbarach)
Set a breakpoint in format_fib_table_name, and see if e.g. fib_table->ft_desc is NULL. Thanks... Dave From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Bhanu Chander Gaddoju Sent: Tuesday, September 12, 2017 11:45 AM To: vpp-dev@lists.fd.io; Ni, Hongjun

Re: [vpp-dev] u32 vs uint32_t

2017-09-11 Thread Dave Barach (dbarach)
+1, let’s stick with u32... Thanks… Dave From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Dave Wallace Sent: Monday, September 11, 2017 12:36 PM To: Florin Coras ; Luke, Chris Cc: vpp-dev

Re: [vpp-dev] VPP contribute

2017-09-11 Thread Dave Barach (dbarach)
That’s right, no need to send patches to a mailing list. In fact, please don’t send patches to this list. ()... Thanks… Dave From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Shachar Beiser Sent: Monday, September 11, 2017 7:48 AM To: vpp-dev@lists.fd.io Cc:

Re: [vpp-dev] mheap performance

2017-09-08 Thread Dave Barach (dbarach)
om] Sent: Friday, September 8, 2017 10:39 AM To: Dave Barach (dbarach) <dbar...@cisco.com> Cc: vpp-dev@lists.fd.io; Michał Dubiel <m...@semihalf.com> Subject: Re: [vpp-dev] mheap performance Hi Dave, The perf backtrace (taken from "control-only" lcore 0) is as follows: - 91.8

Re: [vpp-dev] Rearrangement of graph nodes

2017-09-08 Thread Dave Barach (dbarach)
One could do that, but what problem are you trying to solve? The data structures involved are not super-complicated, but what you’ve described is neither a beginner project nor a worthwhile project IMO. If you want to spoof MAC addresses in the L2 path, add an L2 feature node which does that.

Re: [vpp-dev] mheap performance

2017-09-05 Thread Dave Barach (dbarach)
Dear Jacek, Use of the clib memory allocator is mainly historical. It’s elegant in a couple of ways - including built-in leak-finding - but it has been known to backfire in terms of performance. Individual mheaps are limited to 4gb in a [typical] 32-bit vector length image. Note that the

Re: [vpp-dev] Packet loss on use of API & cmdline

2017-09-01 Thread Dave Barach (dbarach)
at... Thanks… Dave -Original Message- From: Colin Tregenza Dancer [mailto:c...@metaswitch.com] Sent: Friday, September 1, 2017 11:01 AM To: Dave Barach (dbarach) <dbar...@cisco.com>; Ole Troan <otr...@employees.org>; Neale Ranns (nranns) <nra...@cisco.com> Cc: vpp-dev@lis

Re: [vpp-dev] Packet loss on use of API & cmdline

2017-09-01 Thread Dave Barach (dbarach)
Tregenza Dancer [mailto:c...@metaswitch.com] Sent: Friday, September 1, 2017 8:51 AM To: Dave Barach (dbarach) <dbar...@cisco.com>; Ole Troan <otr...@employees.org> Cc: vpp-dev@lists.fd.io Subject: RE: [vpp-dev] Packet loss on use of API & cmdline Hi Dave, Thanks for looking

Re: [vpp-dev] Packet loss on use of API & cmdline

2017-09-01 Thread Dave Barach (dbarach)
Dear Colin, Please describe the scenario which leads to vlib_node_runtime_update(). I wouldn't mind having a good long stare at the situation. I do like the parallel data structure update approach that you've described, tempered with the realization that it amounts to "collective brain

Re: [vpp-dev] About the order of  VLIB_INIT_FUNCTION called between different plugins

2017-08-31 Thread Dave Barach (dbarach)
: vpp-dev@lists.fd.io; zhao.qingl...@zte.com.cn; wu.bi...@zte.com.cn; gu.ji...@zte.com.cn; dong.ju...@zte.com.cn; Dave Barach (dbarach) <dbar...@cisco.com> Subject: 答复: Re: [vpp-dev] About the order of VLIB_INIT_FUNCTION called between different plugins Thanks you two for the he

Re: [vpp-dev] Issue forwarding TCP packets

2017-08-30 Thread Dave Barach (dbarach)
This is a system problem; vpp can’t solve it all by itself. When forwarding packets at L2, vpp doesn’t look past the ethernet header. It’s simply delivering packets generated by the Linux kernel on one interface to another Linux kernel interface. The kernel cheats by not generating L4

Re: [vpp-dev] About the order of  VLIB_INIT_FUNCTION called between different plugins

2017-08-30 Thread Dave Barach (dbarach)
Explicit dependencies between plugins is probably not a good idea. There is little to guarantee that both A and B will be loaded. Please describe the use-case in more detail. Thanks… Dave From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of wang.hu...@zte.com.cn

Re: [vpp-dev] [EXT] Re: compiling error natively on an am64 box for fd.io_vpp

2017-08-28 Thread Dave Barach (dbarach)
+1 From: Damjan Marion [mailto:dmarion.li...@gmail.com] Sent: Saturday, August 26, 2017 3:11 PM To: Eric Chen <eri...@marvell.com> Cc: Dave Barach (dbarach) <dbar...@cisco.com>; Sergio Gonzalez Monroy <sergio.gonzalez.mon...@intel.com>; vpp-dev <vpp-dev@lists.fd.io> Sub

Re: [vpp-dev] [EXT] Re: compiling error natively on an am64 box for fd.io_vpp

2017-08-26 Thread Dave Barach (dbarach)
Just so everyone knows, the function in question is almost too simple for its own good: always_inline uword vlib_process_suspend_time_is_zero (f64 dt) { return dt < 10e-6; } What happens if you try this variation? always_inline int vlib_process_suspend_time_is_zero (f64 dt) { if (dt <

  1   2   3   >