Re: [vpp-dev] GNU indent pain

> Yes, but using a "standard" style then has the same issues as using GNU > indent, the definition is left up to the tool of what that means, and can > change from version to version. > > What I was getting at is that clang-format allows defining more precisely the > formatting you want. For

Re: [vpp-dev] GNU indent pain

> On 22 Oct 2019, at 20:56, Damjan Marion wrote: > > > >> On 22 Oct 2019, at 20:06, Andrew Yourtchenko wrote: >> >>> On 22 Oct 2019, at 19:42, Damjan Marion wrote: >>> >>> >>> On 22 Oct 2019, at 19:26, Andrew  Yourtchenko wrote:  Damjan, What impact

Re: [vpp-dev] GNU indent pain

> On Oct 22, 2019, at 2:53 PM, Damjan Marion via Lists.Fd.Io > wrote: > > > Just tried to run clang-format-{6,7,8,9} on output generated by gcc with "-E > -P" on the one file from VPP src tree. > > Result is not great: 6 and 7 are producing same result. 8 and 9 are producing > different

Re: [vpp-dev] GNU indent pain

> On 22 Oct 2019, at 20:06, Andrew Yourtchenko wrote: > > On 22 Oct 2019, at 19:42, Damjan Marion > wrote: > >> >> >>> On 22 Oct 2019, at 19:26, Andrew  Yourtchenko >> > wrote: >>> >>>  >>> Damjan, >>> >>> What impact will this have on

Re: [vpp-dev] GNU indent pain

Just tried to run clang-format-{6,7,8,9} on output generated by gcc with "-E -P" on the one file from VPP src tree. Result is not great: 6 and 7 are producing same result. 8 and 9 are producing different results each. I specially like this difference between 8 and 9: -

Re: [vpp-dev] GNU indent pain

+1 I think we should do this independent of the “indent wars” Thanks, Florin > On Oct 22, 2019, at 10:09 AM, Damjan Marion via Lists.Fd.Io > wrote: > > > Folks, > > Now we have 2nd release of ubuntu out which comes with new GNU indent which > introduces lot of bug fixes. > Unfortunately

Re: [vpp-dev] GNU indent pain

What about switching to clang-format which one can perhaps better configure (and thus keep stable)? Locally, in my plugin source, I've been using this: " /* * fd.io coding-style-patch-verification: CLANG " (i.e., CLANG instead of ON) and then I have a directory local .clang-format file which

Re: [vpp-dev] GNU indent pain

> On 22 Oct 2019, at 19:42, Damjan Marion wrote: > > > >> On 22 Oct 2019, at 19:26, Andrew  Yourtchenko wrote: >> >>  >> Damjan, >> >> What impact will this have on attempts at automatic cherrypicks into >> stable/1908 ? > > No idea, never did automatic cherry-pick in my life. It

Re: [vpp-dev] GNU indent pain

> On 22 Oct 2019, at 19:26, Andrew  Yourtchenko wrote: > >  > Damjan, > > What impact will this have on attempts at automatic cherrypicks into > stable/1908 ? No idea, never did automatic cherry-pick in my life. It sounds scary... > (And likewise, if it gets cherry-picked now into

Re: [vpp-dev] GNU indent pain

Damjan, What impact will this have on attempts at automatic cherrypicks into stable/1908 ? (And likewise, if it gets cherry-picked now into stable/1908, then will it block a notable fraction of the past commits ?) If this is the only change, given the role the indent plays - maybe we could

[vpp-dev] GNU indent pain

Folks, Now we have 2nd release of ubuntu out which comes with new GNU indent which introduces lot of bug fixes. Unfortunately our repo is full of products of bugs which are fixed, so it results in big mess when new indent is used. Most of the time, it is about space after __attribute__ where