Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-02-09 Thread Ole Troan
> Auto-abandon is not auto-delete. > > Abandoned patches remain accessible in gerrit and the 600+ patches which > would be auto-abandoned would continue to exist in virtually the same state > as they do today. Viewable by all and available to anyone interested in > utilizing them (i.e.

Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-02-04 Thread Damjan Marion via lists.fd.io
Guys, let’s use part of the next Tuesday community call ta talk about this and decide. I will put it on the agenda…. — Damjan > On 01.02.2021., at 16:17, Dave Wallace wrote: > > Ole, > > Auto-abandon is not auto-delete. > > Abandoned patches remain accessible in gerrit and the 600+

Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-02-01 Thread Dave Wallace
Ole, Auto-abandon is not auto-delete. Abandoned patches remain accessible in gerrit and the 600+ patches which would be auto-abandoned would continue to exist in virtually the same state as they do today.  Viewable by all and available to anyone interested in utilizing them (i.e. restoring,

Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-02-01 Thread Peter Mikus via lists.fd.io
io on behalf of Ole Troan Sent: Monday, February 1, 2021 15:38 To: Dave Wallace Cc: Paul Vinciguerra; Andrew Yourtchenko; vpp-dev Subject: Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master Dave, > To be perfectly honest, other than Andrew's proposal to tweak the > auto-ab

Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-02-01 Thread Ole Troan
Dave, > To be perfectly honest, other than Andrew's proposal to tweak the > auto-abandon parameters, I have not heard another solution that solves the > problem of cleaning up the current queue and limiting the size of the queue > in the future. Is anyone going to volunteer to manually

Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-01-29 Thread Dave Wallace
io <mailto:vpp-dev@lists.fd.io> <mailto:vpp-dev@lists.fd.io> On Behalf Of Dave Wallace Sent: mercredi 27 janvier 2021 22:50 To:vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> Subject: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master Fo

Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-01-29 Thread Paul Vinciguerra
Ben, It was not intended toward you at all. In fact, in my experience, you are very helpful. I was only looking to highlight cases that did not specifically benefit me. Would you like a different change for me to highlight? How about https://gerrit.fd.io/r/c/vpp/+/27349? That is mine, though.

Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-01-29 Thread Benoit Ganne (bganne) via lists.fd.io
Hi Paul, as you refer to this specific story which is close to my heart (as I am the one who triggered the whole drama by -2'ed), let me clarify: > The Netgate folks had a changeset they were waiting a month or so for a > review, then they were told that it was too close to the release to merge

Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-01-29 Thread Paul Vinciguerra
utoabandon plugin triggers if no activity on the patch > > > —a > > > > So a tentative -1. > > Cheers > Ole > > > > > On 28 Jan 2021, at 09:19, Benoit Ganne (bganne) via lists.fd.io > wrote: > > +1 > > ben > > > -Original

Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-01-28 Thread Andrew Yourtchenko
> T+30: autoabandon plugin triggers if no activity on the patch >> >> >> —a >> >> >>> So a tentative -1. >>> >>> Cheers >>> Ole >>> >>> >>> >>>>> On 28 Jan 2021, at 09:19, Benoit

Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-01-28 Thread Ole Troan
> On 28 Jan 2021, at 16:59, Dave Wallace wrote: > > Lastly, I have not heard a counter-proposal from either you or Ole on how to > clean up the current state of the queue. Write a tool that assigns reviews to maintainers. Generate reports and send nag-o-grams. Then if that doesn’t work.

Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-01-28 Thread Dave Wallace
a tentative -1. Cheers Ole On 28 Jan 2021, at 09:19, Benoit Ganne (bganne) via lists.fd.io wrote: +1 ben -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Dave Wallace Sent: mercredi 27 janvier 2021 22:50 To: vpp-dev@lists.fd.io Subject: [vpp-dev] RFC: Enabling Gerrit Auto

Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-01-28 Thread Andrew Yourtchenko
; >> On 28 Jan 2021, at 09:19, Benoit Ganne (bganne) via lists.fd.io >> wrote: >> >> +1 >> >> ben >> >>> -Original Message- >>> From: vpp-dev@lists.fd.io On Behalf Of Dave Wallace >>> Sent: mercredi 27 janvier 20

Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-01-28 Thread Ole Troan
+1 > > ben > >> -Original Message- >> From: vpp-dev@lists.fd.io On Behalf Of Dave Wallace >> Sent: mercredi 27 janvier 2021 22:50 >> To: vpp-dev@lists.fd.io >> Subject: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master >> >> Folks, >

Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-01-28 Thread Benoit Ganne (bganne) via lists.fd.io
+1 ben > -Original Message- > From: vpp-dev@lists.fd.io On Behalf Of Dave Wallace > Sent: mercredi 27 janvier 2021 22:50 > To: vpp-dev@lists.fd.io > Subject: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master > > Folks, > > There are currently 636

Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-01-27 Thread Damjan Marion via lists.fd.io
+1 — Damjan > > On 27.01.2021., at 22:49, Dave Wallace wrote: > >  Folks, > > There are currently 636 open Gerrit Reviews on VPP master [0], the oldest > being submitted on Jun 13, 2016 [1]! > > I would like to propose that the Gerrit Review Auto-Abandon job [2] to reduce > the size of

Re: [EXTERNAL] [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-01-27 Thread Chris Luke via lists.fd.io
@lists.fd.io Subject: [EXTERNAL] [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master Folks, There are currently 636 open Gerrit Reviews on VPP master [0], the oldest being submitted on Jun 13, 2016 [1]! I would like to propose that the Gerrit Review Auto-Abandon job [2] to reduce the size

[vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-01-27 Thread Dave Wallace
Folks, There are currently 636 open Gerrit Reviews on VPP master [0], the oldest being submitted on Jun 13, 2016 [1]! I would like to propose that the Gerrit Review Auto-Abandon job [2] to reduce the size of the queue to a more reasonable length. Benefits include (from [3]): - %<