Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

2017-10-10 Thread Marco Varlese
Well, as I said, it worked on SUSE distro... I'm modifying the patch to have a OS check so to remove this dependency for SUSE since the "check" version we ship does not have that dependency (and we don't have subunit at all as previously mentioned). - Marco On Wed, 2017-10-11 at 06:35 +, Kle

Re: [vpp-dev] Are VAPI ERROR messages normal during build?

2017-10-10 Thread Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco)
Hi Burt, these are existing issues in API files. E.g. >ERROR:VAPI C GEN:While parsing message `pot_profile_add': variable length >array `list_name' doesn't have reference to member containing the actual >length means the python script generating new C/C++ API bindings (vapi) was unab

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

2017-10-10 Thread Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco)
Hi Marco, as you can see in your review build failure, removing -lsubunit breaks existing stuff... Thanks, Klement Quoting Marco Varlese (2017-10-10 16:46:13) > Hi Klement, > > Yes, once check-devel is in place, then we can remove -lsubunit from > test/ext/Makefile. Things would still work (at

Re: [vpp-dev] Router plugin with VPP 1707 - incoming OSPF Hello packets are dropped by VPP

2017-10-10 Thread Michael Borokhovich
Hi Neale, Below is the trace. Thanks! Michael. 00:05:18:275995: dpdk-input GigabitEthernet0/4/0 rx queue 0 buffer 0x446a: current data 14, length 68, free-list 0, clone-count 0, totlen-nifb 0, trace 0x1 PKT MBUF: port 0, nb_segs 1, pkt_len 82 buf_len 2176, data_len 82, ol_flags 0x0

Re: [vpp-dev] Process for submitting patches to stable/1710

2017-10-10 Thread Thomas F Herbert
OK, Thanks! I added Damjan to review. --Tom On 10/10/2017 05:17 PM, Florin Coras wrote: Hi Tom, As long as the patches have a jira ticket, procedurally all is fine with me. However, since we’re so close to release, I’d like Damjan, since he’s the build infra manager, to vet the changes.

Re: [vpp-dev] Process for submitting patches to stable/1710

2017-10-10 Thread Florin Coras
Hi Tom, As long as the patches have a jira ticket, procedurally all is fine with me. However, since we’re so close to release, I’d like Damjan, since he’s the build infra manager, to vet the changes. Regards, Florin > On Oct 10, 2017, at 12:24 PM, Thomas F Herbert wrote: > > Dave, Florin,

Re: [vpp-dev] Mac Address Api Changes

2017-10-10 Thread Jon Loeliger
On Tue, Oct 10, 2017 at 2:41 PM, John Lo (loj) wrote: > The two APIs affected are the older ones in L2FIB which use “u64 mac” > instead of “u8 mac[6]” to pass MAC addresses: > > ·L2fib_add_del > > ·L2_fib_table_details > > > > I believe it is a good change to reduce confusion wrt

Re: [vpp-dev] Mac Address Api Changes

2017-10-10 Thread Luke, Chris
+1 Sounds good to me From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of John Lo (loj) Sent: Tuesday, October 10, 2017 15:42 To: Jerome Tollet (jtollet) ; Mohsin Kazmi (sykazmi) ; vpp-dev Subject: Re: [vpp-dev] Mac Address Api Changes The two APIs affected are t

Re: [vpp-dev] Mac Address Api Changes

2017-10-10 Thread John Lo (loj)
The two APIs affected are the older ones in L2FIB which use “u64 mac” instead of “u8 mac[6]” to pass MAC addresses: ·L2fib_add_del ·L2_fib_table_details I believe it is a good change to reduce confusion wrt how 6-byte MAC is stored in u64 with big/little endian hosts. The chang

[vpp-dev] Process for submitting patches to stable/1710

2017-10-10 Thread Thomas F Herbert
Dave, Florin, I have two patches in gerrit for stable/1710, both with JIRAs. Is there a chance that these can make it into 1710-rc2? They both fix problems that break rpm builds but add no additional features. I want to confirm I am following the correct procedure. One was originally submitt

Re: [vpp-dev] Mac Address Api Changes

2017-10-10 Thread Jerome Tollet (jtollet)
+1, it would be nice to harmonize those API calls. Jerome De : au nom de Mohsin Kazmi Date : lundi 9 octobre 2017 à 19:06 À : vpp-dev Objet : [vpp-dev] Mac Address Api Changes Hello,​ I am writing regarding a proposal to change API messages related to l2fib mac address. In vpp/src/vnet

[vpp-dev] Are VAPI ERROR messages normal during build?

2017-10-10 Thread Burt Silverman
The build completes without error, but I see a lot of these ERROR:VAPI messages, so I thought I'd ask if it is normal. Thanks. Burt make[5]: Entering directory '/home/burts/vpp3/build-root/build-vpp-native/vpp/vpp-api/vapi' VAPI C GEN tcp.api.json vapi/tcp.api.vapi.h VAPI C GEN span.api.json

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

2017-10-10 Thread Thomas F Herbert
On 10/10/2017 10:46 AM, Marco Varlese wrote: Hi Klement, Yes, once check-devel is in place, then we can remove -lsubunit from test/ext/Makefile. Things would still work (at least on openSUSE). I submitted a patch for review: https://gerrit.fd.io/r/#/c/8736 Subunit is a prerequisite for check

Re: [vpp-dev] Build/Install new plugin without rebuilding everything

2017-10-10 Thread Damjan Marion
> On 10 Oct 2017, at 18:12, Justin Iurman wrote: > > Hi folks, > > I was just wondering how I could build my own plugin without rebuilding > everything from scratch in vpp ? I mean, here are two ways I found to build a > plugin: > - First technique (long, rebuilds everything): > https://doc

[vpp-dev] Build/Install new plugin without rebuilding everything

2017-10-10 Thread Justin Iurman
Hi folks, I was just wondering how I could build my own plugin without rebuilding everything from scratch in vpp ? I mean, here are two ways I found to build a plugin: - First technique (long, rebuilds everything): https://docs.fd.io/vpp/17.07/sample_plugin_doc.html - Second technique (fast, on

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

2017-10-10 Thread Thomas F Herbert
On 10/10/2017 10:03 AM, Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco) wrote: Hi Marco, this issue is already being investigated by Tom Herbert. Strange thing is that check requires subunit. I wonder if it works if you install check only. Could you try removing -lsubunit from te

Re: [vpp-dev] Multiple VRFs in 1609

2017-10-10 Thread Pierre Pfister (ppfister)
Thanks a ton Jeff. I merged 8717, 8718 and proposed a different fix to 8716 (https://gerrit.fd.io/r/#/c/8729/). I also noticed netlink plugin does not compile on 1710 and master due to a change in VPP (Mostly renaming which happened here https://gerrit.fd.io/r/#/c/8366/2). I have a patch ready

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

2017-10-10 Thread Marco Varlese
Hi Klement, Yes, once check-devel is in place, then we can remove -lsubunit from test/ext/Makefile. Things would still work (at least on openSUSE). I submitted a patch for review: https://gerrit.fd.io/r/#/c/8736/ Cheers, Marco On Tue, 2017-10-10 at 14:03 +, Klement Sekera -X (ksekera - PAN

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

2017-10-10 Thread Marco Varlese
Hi Klement, Yes, once check-devel is in place, then we can remove -lsubunit from test/ext/Makefile. Things would still work (at least on openSUSE). Cheers, Marco On Tue, 2017-10-10 at 14:03 +, Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco) wrote: > Hi Marco, > > this issue is

Re: [vpp-dev] [vppsb-dev] Router plugin with VPP 1707 - incoming OSPF Hello packets are dropped by VPP

2017-10-10 Thread Neale Ranns (nranns)
Hi Michael, Both of; vppctl ip mroute 224.0.0.0/8 via GigabitEthernet0/4/0 Accept vppctl ip mroute 224.0.0.0/8 via local Forward the first says you are accepting (i.e RPF checks on) GigE0/4/0 the second says you are ‘forwarding/replicating’ to VPP’s local IP stack. The mfib equivalent of th

Re: [vpp-dev] Vlan tagged packet processing in ACL Plugin

2017-10-10 Thread Andrew Yourtchenko
Yep, Yeah it is a work in progress for sub-interface support + the corresponding unit tests... is that the use case you have in mind ? --a > On 10 Oct 2017, at 08:45, khers wrote: > > Hi, > As far as I checked in vpp 17.07 branch version, It seems that the > vlan tagged(dot1q) packets don't p

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

2017-10-10 Thread Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco)
Hi Marco, this issue is already being investigated by Tom Herbert. Strange thing is that check requires subunit. I wonder if it works if you install check only. Could you try removing -lsubunit from test/ext/Makefile? Thanks, Klement Quoting Marco Varlese (2017-10-10 16:00:00) > Hi all, > > As

[vpp-dev] Dependency on libsubunit ? (and failing to run tests)

2017-10-10 Thread Marco Varlese
Hi all, As of last week I could happily run tests (e.g. make test) on my distribution (openSUSE). When I tried again today - with latest master - I couldn't anymore: make[2]: Entering directory '/home/mvarlese/repo/vpp/test/ext' cc -o /home/mvarlese/repo/vpp/build-root/vapi_test/vapi_c_test -std

[vpp-dev] [vpp-acl] Adding a new tokenizer support in mask field while creating classify table

2017-10-10 Thread Avinash Dhar Dubey
Hello, I want to add a new tokenizer in_port in mask field while creating classify table.I dont want to make it part of l2 , l3 or l4 mask. The mask size will get increased. Will it affect the performance ?? Is there any limit on the mask size ?? Regards, Avinash

Re: [vpp-dev] Router plugin with VPP 1707 - incoming OSPF Hello packets are dropped by VPP

2017-10-10 Thread Neale Ranns (nranns)
Hi Michael, Could you give me a ‘sh trace’ ? Thanks, neale From: on behalf of Michael Borokhovich Date: Monday, 9 October 2017 at 18:14 To: vpp-dev Subject: [vpp-dev] Router plugin with VPP 1707 - incoming OSPF Hello packets are dropped by VPP Hi, After applying the fixes suggested by Je

Re: [vpp-dev] Multiple VRFs in 1609

2017-10-10 Thread Pierre Pfister (ppfister)
Thanks a ton Jeff. I merged 8717, 8718 and proposed a different fix to 8716 (https://gerrit.fd.io/r/#/c/8729/). I also noticed netlink plugin does not compile on 1710 and master due to a change in VPP (Mostly renaming which happened here https://gerrit.fd.io/r/#/c/8366/2). I have a patch ready