Re: [vpp-dev] Router plugin with VPP 1707 - incoming OSPF Hello packets are dropped by VPP

[Michael Borokhovich]

Hi Neale,

Below is the trace.

Thanks!
Michael.

00:05:18:275995: dpdk-input

  GigabitEthernet0/4/0 rx queue 0

  buffer 0x446a: current data 14, length 68, free-list 0, clone-count 0,
totlen-nifb 0, trace 0x1

  PKT MBUF: port 0, nb_segs 1, pkt_len 82

buf_len 2176, data_len 82, ol_flags 0x0, data_off 128, phys_addr
0x6990d980

packet_type 0x0

  IP4: fa:16:3e:4a:b3:60 -> 01:00:5e:00:00:05

  OSPF: 10.0.10.1 -> 224.0.0.5

tos 0xc0, ttl 1, length 68, checksum 0x2986

fragment id 0x9b15

00:05:18:276166: ip4-input

  OSPF: 10.0.10.1 -> 224.0.0.5

tos 0xc0, ttl 1, length 68, checksum 0x2986

fragment id 0x9b15

00:05:18:276403: ip4-mfib-forward-lookup

  fib 0 entry 0

00:05:18:276503: ip4-mfib-forward-rpf

  entry 0 -1

00:05:18:276516: ip4-drop

OSPF: 10.0.10.1 -> 224.0.0.5

  tos 0xc0, ttl 1, length 68, checksum 0x2986

  fragment id 0x9b15

00:05:18:276595: error-drop

  ip4-input: ip4 adjacency drop



On Tue, Oct 10, 2017 at 4:31 AM, Neale Ranns (nranns) 
wrote:

>
>
> Hi Michael,
>
>
>
> Could you give me a ‘sh trace’ ?
>
>
>
> Thanks,
>
> neale
>
>
>
> *From: * on behalf of Michael Borokhovich <
> michael...@gmail.com>
> *Date: *Monday, 9 October 2017 at 18:14
> *To: *vpp-dev 
> *Subject: *[vpp-dev] Router plugin with VPP 1707 - incoming OSPF Hello
> packets are dropped by VPP
>
>
>
> Hi,
>
>
>
> After applying the fixes suggested by Jeff, I was able to compile the
> router plugin with VPP 1707.
>
>
>
> It runs and allows to enable tap-inject and set up interfaces addresses
> without crashing.
>
>
>
> The problem I'm facing now is with setting up FRR OSPF on top of the
> VPP+router plugin.
>
>
>
> FRR OSPF is configured and I see OSPF Hello packets flowing out of the
> machine. However, the incoming OSPF Hello packets are dropped by VPP (with
> the reason "ip4 adjacency drop") and never reach the FRR.
>
>
>
> The same settings worked with VPP 1609 + router plugin. Maybe I need to
> configure something manually in VPP to allow reception of OSPF multicast
> packets?
>
>
>
> So, to summarize the problem, incoming OSPF Hello packets are dropped by
> VPP, while the outgoing hello packets successfully sent by FRR via VPP to
> the neighbouring router.
>
>
>
> Any help is appreciated.
>
>
>
> Thanks,
>
> Michael.
>
>
>
>
>
>
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Process for submitting patches to stable/1710

[Thomas F Herbert]

OK, Thanks!

I added Damjan to review.

--Tom


On 10/10/2017 05:17 PM, Florin Coras wrote:

Hi Tom,

As long as the patches have a jira ticket, procedurally all is fine 
with me. However, since we’re so close to release, I’d like Damjan, 
since he’s the build infra manager, to vet the changes.


Regards,
Florin

On Oct 10, 2017, at 12:24 PM, Thomas F Herbert > wrote:


Dave, Florin,

I have two patches in gerrit for stable/1710, both with JIRAs.

Is there a chance that these can make it into 1710-rc2? They both fix 
problems that break rpm builds but add no additional features.


I want to confirm I am following the correct procedure. One was 
originally submitted to master and rebased to stable/1710 and the 
other one was submitted directly to stable/1710.


https://gerrit.fd.io/r/8721

https://gerrit.fd.io/r/8720

https://jira.fd.io/browse/VPP-1015

https://jira.fd.io/browse/VPP-1014

--Tom


--
*Thomas F Herbert*
NFV and Fast Data Planes
Office of Technology
*Red Hat*
___
vpp-dev mailing list
vpp-dev@lists.fd.io 
https://lists.fd.io/mailman/listinfo/vpp-dev




--
*Thomas F Herbert*
NFV and Fast Data Planes
Office of Technology
*Red Hat*
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Process for submitting patches to stable/1710

[Florin Coras]

Hi Tom, 

As long as the patches have a jira ticket, procedurally all is fine with me. 
However, since we’re so close to release, I’d like Damjan, since he’s the build 
infra manager, to vet the changes. 

Regards, 
Florin

> On Oct 10, 2017, at 12:24 PM, Thomas F Herbert  wrote:
> 
> Dave, Florin,
> I have two patches in gerrit for stable/1710, both with JIRAs.
> 
> Is there a chance that these can make it into 1710-rc2? They both fix 
> problems that break rpm builds but add no additional features.
> 
> I want to confirm I am following the correct procedure. One was originally 
> submitted to master and rebased to stable/1710 and the other one was 
> submitted directly to stable/1710.
> 
> https://gerrit.fd.io/r/8721 
> https://gerrit.fd.io/r/8720 
> https://jira.fd.io/browse/VPP-1015 
> https://jira.fd.io/browse/VPP-1014 
> --Tom
> 
> -- 
> Thomas F Herbert 
> NFV and Fast Data Planes 
> Office of Technology 
> Red Hat
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Mac Address Api Changes

[Jon Loeliger]

On Tue, Oct 10, 2017 at 2:41 PM, John Lo (loj)  wrote:

> The two APIs affected are the older ones in L2FIB which use “u64 mac”
> instead of “u8 mac[6]” to pass MAC addresses:
>
> ·L2fib_add_del
>
> ·L2_fib_table_details
>
>
>
> I believe it is a good change to reduce confusion wrt how 6-byte MAC is
> stored in u64 with big/little endian hosts. The change would also require
> updates to user programs of these APIs, which we believe should be minimal.
>
>
>
> If we don’t get strong objections within a week, we will assume the change
> is acceptable and allow this API change in the master branch. It won’t
> affect 17.10 release.
>
>
>
> Regards,
>
> John
>

Sure.  +1

jdl
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Mac Address Api Changes

[Luke, Chris]

+1 Sounds good to me

From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On 
Behalf Of John Lo (loj)
Sent: Tuesday, October 10, 2017 15:42
To: Jerome Tollet (jtollet) ; Mohsin Kazmi (sykazmi) 
; vpp-dev 
Subject: Re: [vpp-dev] Mac Address Api Changes

The two APIs affected are the older ones in L2FIB which use “u64 mac” instead 
of “u8 mac[6]” to pass MAC addresses:

  *   L2fib_add_del
  *   L2_fib_table_details

I believe it is a good change to reduce confusion wrt how 6-byte MAC is stored 
in u64 with big/little endian hosts. The change would also require updates to 
user programs of these APIs, which we believe should be minimal.

If we don’t get strong objections within a week, we will assume the change is 
acceptable and allow this API change in the master branch. It won’t affect 
17.10 release.

Regards,
John

From: vpp-dev-boun...@lists.fd.io 
[mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Jerome Tollet (jtollet)
Sent: Tuesday, October 10, 2017 3:10 PM
To: Mohsin Kazmi (sykazmi) >; 
vpp-dev >
Subject: Re: [vpp-dev] Mac Address Api Changes

+1, it would be nice to harmonize those API calls.
Jerome

De : > au nom 
de Mohsin Kazmi >
Date : lundi 9 octobre 2017 à 19:06
À : vpp-dev >
Objet : [vpp-dev] Mac Address Api Changes


Hello,​



I am writing regarding a proposal to change API messages related to l2fib mac 
address.



In vpp/src/vnet/l2/l2.api file, currently two API messages related to l2fib 
uses u64 for mac address instead of u8 mac[6]. While rest of VPP API calls use 
array of six bytes to store mac address.



As u64 to store mac address is inconsistent with rest of VPP and may create 
conversion troubles to interpret to/from u8 mac[6].



The proposal is to change those API messages definitions to use standard u8 
mac[6] to store mac address. But this change may impact the users of VPP API 
and they will need to update their code.



​That said, Please let the community know if there is any specific objection or 
opinion to above proposal.



Thanks,

Mohsin




___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

[Thomas F Herbert]

On 10/10/2017 10:46 AM, Marco Varlese wrote:

Hi Klement,

Yes, once check-devel is in place, then we can remove -lsubunit from
test/ext/Makefile. Things would still work (at least on openSUSE).

I submitted a patch for review:
https://gerrit.fd.io/r/#/c/8736

Subunit is a prerequisite for check version 0.10 which is used in Fedora.
However, I don't know if check version 0.10 actually needs to be bound 
with subunit or whether

this is just an RPM dependency.



Cheers,
Marco

On Tue, 2017-10-10 at 14:03 +, Klement Sekera -X (ksekera - PANTHEON
TECHNOLOGIES at Cisco) wrote:

Hi Marco,

this issue is already being investigated by Tom Herbert. Strange thing
is that check requires subunit. I wonder if it works if you install
check only. Could you try removing -lsubunit from test/ext/Makefile?

Thanks,
Klement

Quoting Marco Varlese (2017-10-10 16:00:00)

Hi all,

As of last week I could happily run tests (e.g. make test) on my
distribution
(openSUSE).

When I tried again today - with latest master - I couldn't anymore:

make[2]: Entering directory '/home/mvarlese/repo/vpp/test/ext'
cc -o /home/mvarlese/repo/vpp/build-root/vapi_test/vapi_c_test -std=gnu99 -g
-Wall -pthread -I/home/mvarlese/repo/vpp/src
-I/home/mvarlese/repo/vpp/build-
root/install-vpp-native//vpp/include -I/home/mvarlese/repo/vpp/build-
root/vapi_test/ vapi_c_test.c -L/home/mvarlese/repo/vpp/build-root/build-
vpp-
native/vpp/.libs/ -L/home/mvarlese/repo/vpp/build-root/build-vpp-
native/vpp/vpp-
api/vapi/.libs/ -lvppinfra -lvlibmemoryclient -lsvm -lpthread -lcheck
-lsubunit
-lrt -lm -lvapiclient
/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld:
cannot
find -lsubunit
collect2: error: ld returned 1 exit status

I tried to find the newly introduced dependency on libsubunit but wasn't
successful.

Can anybody shed some light?
Separate, we do not have that package on our distro...


Cheers,
Marco

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev


--
*Thomas F Herbert*
NFV and Fast Data Planes
Office of Technology
*Red Hat*
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Build/Install new plugin without rebuilding everything

[Damjan Marion]

> On 10 Oct 2017, at 18:12, Justin Iurman  wrote:
> 
> Hi folks,
> 
> I was just wondering how I could build my own plugin without rebuilding 
> everything from scratch in vpp ? I mean, here are two ways I found to build a 
> plugin:
> - First technique (long, rebuilds everything): 
> https://docs.fd.io/vpp/17.07/sample_plugin_doc.html
> - Second technique (fast, only builds what needs to be, "sample-plugin" 
> specific): https://wiki.fd.io/view/VPP/Tutorial_DPDK_and_MacSwap#Compilation
> 
> What's the difference between the two ? Is one of the two obsolete, not 
> appropriate in that case ? I just don't get it, as it looks like there are 
> two different notions of plugins.
> 
> I don't like the first one because it rebuilds everything and it takes ages.
> 
> I'd like to use the second one, if possible. For that, I've added a file 
> called "myown-plugin.mk" in "build-data/packages" with equivalent (but 
> modified for that specific case) content as "sample-plugin.mk". Anyway, it 
> doesn't work when running "make V=0 PLATFORM=vpp TAG=vpp 
> myown-plugin-install", as I receive everytime an error. It says that it can't 
> find "myown-plugin" source in "/vpp". Which is weird because I've exactly the 
> same "myown" files (everywhere) as "sample-plugin".
> 
> What am I missing here ? Thanks !

Sample-plugin is exactly the sample of external VPP plugin which can be 
compiled separately of VPP.
Just copy the files to your location and do usual “autoreconf -fis ; 
./configure; make” sequence.

Before doing that you need to install vpp-dev development package which will 
install required headers….



___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

[vpp-dev] Build/Install new plugin without rebuilding everything

[Justin Iurman]

Hi folks,

I was just wondering how I could build my own plugin without rebuilding 
everything from scratch in vpp ? I mean, here are two ways I found to build a 
plugin:
- First technique (long, rebuilds everything): 
https://docs.fd.io/vpp/17.07/sample_plugin_doc.html
- Second technique (fast, only builds what needs to be, "sample-plugin" 
specific): https://wiki.fd.io/view/VPP/Tutorial_DPDK_and_MacSwap#Compilation

What's the difference between the two ? Is one of the two obsolete, not 
appropriate in that case ? I just don't get it, as it looks like there are two 
different notions of plugins.

I don't like the first one because it rebuilds everything and it takes ages.

I'd like to use the second one, if possible. For that, I've added a file called 
"myown-plugin.mk" in "build-data/packages" with equivalent (but modified for 
that specific case) content as "sample-plugin.mk". Anyway, it doesn't work when 
running "make V=0 PLATFORM=vpp TAG=vpp myown-plugin-install", as I receive 
everytime an error. It says that it can't find "myown-plugin" source in "/vpp". 
Which is weird because I've exactly the same "myown" files (everywhere) as 
"sample-plugin".

What am I missing here ? Thanks !

Justin
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Multiple VRFs in 1609

[Pierre Pfister (ppfister)]

Thanks a ton Jeff.

I merged 8717, 8718 and proposed a different fix to 8716 
(https://gerrit.fd.io/r/#/c/8729/).

I also noticed netlink plugin does not compile on 1710 and master due to a 
change in VPP (Mostly renaming which happened here 
https://gerrit.fd.io/r/#/c/8366/2).
I have a patch ready to fix that, but will wait for the 1710 release before 
merging it.

- Pierre


Le 9 oct. 2017 à 19:18, Shaw, Jeffrey B 
> a écrit :

I’ve submitted changes 8716, 8717, and 8718, which should fix the issues we’ve 
discussed in this thread.

Thanks,
Jeff

From: Michael Borokhovich [mailto:michael...@gmail.com]
Sent: Monday, October 09, 2017 9:07 AM
To: Ni, Hongjun >
Cc: Neale Ranns (nranns) >; Shaw, 
Jeffrey B >; 
vppsb-...@lists.fd.io; vpp-dev 
>
Subject: Re: [vpp-dev] Multiple VRFs in 1609

Thanks, Hongjun,

I will check this once I see that the routing plugin works with VPP1707.

On Fri, Oct 6, 2017 at 7:25 PM, Ni, Hongjun 
> wrote:
Hi Michael and Neale,

As per my previous fixing experience on router plugin, I guess that the cause 
may locate at:
Function tap_inject_enabel(): add IPv4 multicast route.
Please take a look at this function and multicast route involved.

-Hongjun

From: vpp-dev-boun...@lists.fd.io 
[mailto:vpp-dev-boun...@lists.fd.io] On 
Behalf Of Michael Borokhovich
Sent: Friday, October 6, 2017 11:22 PM
To: Neale Ranns (nranns) >
Cc: Shaw, Jeffrey B 
>; 
vppsb-...@lists.fd.io; vpp-dev 
>

Subject: Re: [vpp-dev] Multiple VRFs in 1609

I will look into it. It looks like the calling function is in the file 
"turbotap/turbotap/device.c" in vppsb. However, I'm not familiar with the logic 
there...

I will try to fix it temporary locally directly in the 
"vlib_increment_simple_counter" function and see if it works.

Thanks!



On Fri, Oct 6, 2017 at 11:08 AM, Neale Ranns (nranns) 
> wrote:
Hi Michael,

It would be best if you fixed the caller to not pass ~0. In this case the ~0 is 
coming from the packet VLIB_RX interface. So best to find and fix the input 
node that should have set this correctly.

/neale

From: Michael Borokhovich >
Date: Friday, 6 October 2017 at 15:49
To: "Shaw, Jeffrey B" 
>
Cc: "Pierre Pfister (ppfister)" 
>, Florin Coras 
>, vpp-dev 
>, "Neale Ranns (nranns)" 
>, 
"vppsb-...@lists.fd.io" 
>

Subject: Re: [vpp-dev] Multiple VRFs in 1609

Hi Jeff,

Regarding the workaround for the problem [3] (segfault). Do you think it is 
enough just to add a simple check e.g., if(index != ~0)? Or we have a problem 
somewhere else since the ~0 index should not be passed to this function?

Thanks,
Michael.


On Thu, Oct 5, 2017 at 1:03 PM, Shaw, Jeffrey B 
> wrote:
Hi Michael, do you really need the router plugin?  Based on the commands you’re 
using it seems you’re adding routes using the vpp cli interface, which is not 
how the router plugin is supposed to work.  Those routes won’t show up on the 
control side (i.e. Linux).  Nor is there any support for multiple routing 
tables.  The routes should be added from the control side, then they are 
mirrored to VPP.

@Pierre,
I was able to get the router plugin to work with VPP 1707 (348edb1 
[origin/stable/1707] Set MAC address needs the HW interface index).
I used vppsb commit 529ec1b [origin/master] Fix name of VCL LD_PRELOAD lib dir 
env var.

A few things went wrong:

1)  Had to disable testrtnl_plugin in vppsb/netlink[1] to get netlink to 
compile

2)  Delete the reference to vlib_buffer_chain_validate() in vppsb/router 
after symbol lookup failure[2]

3)  Work-around a segmentation fault[3] in 
vlib_increment_simple_counter()due to an index being set to ~0


I can submit two patches to fix 1 and 2.

For number 3, it looks like we might want to check for an invalid interface?  
This function is probably used often, so adding that check will be bad for 
performance.  Maybe we can check for invalid interface in process_drop_punt() 
instead.

always_inline void

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

[Marco Varlese]

Hi Klement,

Yes, once check-devel is in place, then we can remove -lsubunit from
test/ext/Makefile. Things would still work (at least on openSUSE).

I submitted a patch for review:
https://gerrit.fd.io/r/#/c/8736/


Cheers,
Marco

On Tue, 2017-10-10 at 14:03 +, Klement Sekera -X (ksekera - PANTHEON
TECHNOLOGIES at Cisco) wrote:
> Hi Marco,
> 
> this issue is already being investigated by Tom Herbert. Strange thing
> is that check requires subunit. I wonder if it works if you install
> check only. Could you try removing -lsubunit from test/ext/Makefile?
> 
> Thanks,
> Klement
> 
> Quoting Marco Varlese (2017-10-10 16:00:00)
> > Hi all,
> > 
> > As of last week I could happily run tests (e.g. make test) on my
> > distribution
> > (openSUSE).
> > 
> > When I tried again today - with latest master - I couldn't anymore:
> > 
> > make[2]: Entering directory '/home/mvarlese/repo/vpp/test/ext'
> > cc -o /home/mvarlese/repo/vpp/build-root/vapi_test/vapi_c_test -std=gnu99 -g
> > -Wall -pthread -I/home/mvarlese/repo/vpp/src
> > -I/home/mvarlese/repo/vpp/build-
> > root/install-vpp-native//vpp/include -I/home/mvarlese/repo/vpp/build-
> > root/vapi_test/ vapi_c_test.c -L/home/mvarlese/repo/vpp/build-root/build-
> > vpp-
> > native/vpp/.libs/ -L/home/mvarlese/repo/vpp/build-root/build-vpp-
> > native/vpp/vpp-
> > api/vapi/.libs/ -lvppinfra -lvlibmemoryclient -lsvm -lpthread -lcheck
> > -lsubunit
> > -lrt -lm -lvapiclient
> > /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld:
> > cannot
> > find -lsubunit
> > collect2: error: ld returned 1 exit status
> > 
> > I tried to find the newly introduced dependency on libsubunit but wasn't
> > successful. 
> > 
> > Can anybody shed some light?
> > Separate, we do not have that package on our distro...
> > 
> > 
> > Cheers,
> > Marco
> > 
> > ___
> > vpp-dev mailing list
> > vpp-dev@lists.fd.io
> > https://lists.fd.io/mailman/listinfo/vpp-dev
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

[Marco Varlese]

Hi Klement,

Yes, once check-devel is in place, then we can remove -lsubunit from
test/ext/Makefile. Things would still work (at least on openSUSE).


Cheers,
Marco

On Tue, 2017-10-10 at 14:03 +, Klement Sekera -X (ksekera - PANTHEON
TECHNOLOGIES at Cisco) wrote:
> Hi Marco,
> 
> this issue is already being investigated by Tom Herbert. Strange thing
> is that check requires subunit. I wonder if it works if you install
> check only. Could you try removing -lsubunit from test/ext/Makefile?
> 
> Thanks,
> Klement
> 
> Quoting Marco Varlese (2017-10-10 16:00:00)
> > Hi all,
> > 
> > As of last week I could happily run tests (e.g. make test) on my
> > distribution
> > (openSUSE).
> > 
> > When I tried again today - with latest master - I couldn't anymore:
> > 
> > make[2]: Entering directory '/home/mvarlese/repo/vpp/test/ext'
> > cc -o /home/mvarlese/repo/vpp/build-root/vapi_test/vapi_c_test -std=gnu99 -g
> > -Wall -pthread -I/home/mvarlese/repo/vpp/src
> > -I/home/mvarlese/repo/vpp/build-
> > root/install-vpp-native//vpp/include -I/home/mvarlese/repo/vpp/build-
> > root/vapi_test/ vapi_c_test.c -L/home/mvarlese/repo/vpp/build-root/build-
> > vpp-
> > native/vpp/.libs/ -L/home/mvarlese/repo/vpp/build-root/build-vpp-
> > native/vpp/vpp-
> > api/vapi/.libs/ -lvppinfra -lvlibmemoryclient -lsvm -lpthread -lcheck
> > -lsubunit
> > -lrt -lm -lvapiclient
> > /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld:
> > cannot
> > find -lsubunit
> > collect2: error: ld returned 1 exit status
> > 
> > I tried to find the newly introduced dependency on libsubunit but wasn't
> > successful. 
> > 
> > Can anybody shed some light?
> > Separate, we do not have that package on our distro...
> > 
> > 
> > Cheers,
> > Marco
> > 
> > ___
> > vpp-dev mailing list
> > vpp-dev@lists.fd.io
> > https://lists.fd.io/mailman/listinfo/vpp-dev
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] [vppsb-dev] Router plugin with VPP 1707 - incoming OSPF Hello packets are dropped by VPP

[Neale Ranns (nranns)]

Hi Michael,

Both of;
  vppctl ip mroute 224.0.0.0/8 via GigabitEthernet0/4/0 Accept
  vppctl ip mroute 224.0.0.0/8 via local Forward
the first says you are accepting (i.e RPF checks on) GigE0/4/0 the second says 
you are ‘forwarding/replicating’ to VPP’s local IP stack.

The mfib equivalent of the fib API you were using is;
  extern fib_node_index_t mfib_table_entry_special_add(u32 fib_index,
 const mfib_prefix_t 
*prefix,
 mfib_source_t source,
 mfib_entry_flags_t flags,
 index_t rep_dpo);

if you include the flag MFIB_ENTRY_ACCEPT_ALL_ITF then mfib will accept from 
any incoming interface, hence you won’t need an explicit ‘Accept’ rule. But 
this API is strict about the last argument ‘dpo’ being a replicate DPO type. 
See the mfib_test.c examples on how to construct one for use with the API.


/neale

From:  on behalf of Michael Borokhovich 

Date: Tuesday, 10 October 2017 at 00:41
To: "Shaw, Jeffrey B" 
Cc: "vppsb-...@lists.fd.io" , vpp-dev 

Subject: Re: [vpp-dev] [vppsb-dev] Router plugin with VPP 1707 - incoming OSPF 
Hello packets are dropped by VPP

I tried various options, like below, but none of the work. How can I use the 
mroute to specify a node (and not an interface or an address)? 

vppctl ip mroute 224.0.0.0/8 via GigabitEthernet0/4/0
vppctl ip mroute 224.0.0.0/8 via GigabitEthernet0/4/0 Accept
vppctl ip mroute 224.0.0.0/8 via GigabitEthernet0/4/0 Forward

On Mon, Oct 9, 2017 at 6:36 PM, Shaw, Jeffrey B  
wrote:
Probably, but I don’t know the command.  Essentially you want a CLI command 
that configures a fib to direct packets/flows to an arbitrary node.
 
Maybe “ip route” or “ip mroute” has what you need.
 
DBGvpp# ip help
  mroute ip mroute [add|del] / 
[table ] [via  [],
… 
  route  ip route [add|del] [count ] 
/ [table ] [via  \
   [] [weight ]] 
| [via arp  ] |
   [via 
drop|punt|local|arp|classify ] [lookup in table 
]
 
-Jeff
 
From: Michael Borokhovich [mailto:michael...@gmail.com] 
Sent: Monday, October 09, 2017 3:26 PM
To: Shaw, Jeffrey B 
Cc: vpp-dev ; vppsb-...@lists.fd.io

Subject: Re: [vppsb-dev] Router plugin with VPP 1707 - incoming OSPF Hello 
packets are dropped by VPP
 
Jef, is there a cli command I can use to instruct VPP to forward multicast to 
that node?
 
On Mon, Oct 9, 2017 at 6:23 PM, Shaw, Jeffrey B  
wrote:
We have this code, which is supposed to tell the fib that packets going to the 
224.0.0.x/24 network should be delivered to our node.
 
  {
    dpo_proto_t proto = 0;
    dpo_id_t dpo = DPO_INVALID;
    fib_prefix_t pfx = {};
 
    pfx.fp_addr.ip4.as_u32 = 0x00E0; /* 224.0.0.0 */
    pfx.fp_len = 24;
    pfx.fp_proto = FIB_PROTOCOL_IP4;
    proto = DPO_PROTO_IP4;
 
    vlib_node_add_next (vm, ip4_lookup_node.index, im->tx_node_index);
 
    dpo_set(, tap_inject_dpo_type, proto, ~0);
 
    fib_table_entry_special_dpo_add(0,
  ,
  FIB_SOURCE_API,
  FIB_ENTRY_FLAG_EXCLUSIVE,
  );
 
    dpo_reset();
  }
 
It is possible this code isn’t working the same as it has in the past.
 
With the FIB changes since the router plugin was initially developed, there 
might be a different/better way to get multicast packets delivered to our node.
 
-Jef
 
 
From: vppsb-dev-boun...@lists.fd.io [mailto:vppsb-dev-boun...@lists.fd.io] On 
Behalf Of Michael Borokhovich
Sent: Monday, October 09, 2017 3:16 PM
To: vpp-dev ; vppsb-...@lists.fd.io
Subject: Re: [vppsb-dev] Router plugin with VPP 1707 - incoming OSPF Hello 
packets are dropped by VPP
 
Here is the trace of the packet that is dropped. Any help is very appreciated.
 
00:05:18:275995: dpdk-input
  GigabitEthernet0/4/0 rx queue 0
  buffer 0x446a: current data 14, length 68, free-list 0, clone-count 0, 
totlen-nifb 0, trace 0x1
  PKT MBUF: port 0, nb_segs 1, pkt_len 82
    buf_len 2176, data_len 82, ol_flags 0x0, data_off 128, phys_addr 0x6990d980
    packet_type 0x0
  IP4: fa:16:3e:4a:b3:60 -> 01:00:5e:00:00:05
  OSPF: 10.0.10.1 -> 224.0.0.5
    tos 0xc0, ttl 1, length 68, checksum 0x2986
    fragment id 0x9b15
00:05:18:276166: ip4-input
  OSPF: 10.0.10.1 -> 224.0.0.5
    tos 0xc0, ttl 1, length 68, checksum 0x2986
    fragment id 0x9b15
00:05:18:276403: ip4-mfib-forward-lookup
  fib 0 entry 0
00:05:18:276503: ip4-mfib-forward-rpf
  entry 0 -1 
00:05:18:276516: ip4-drop
    OSPF: 10.0.10.1 -> 224.0.0.5
      tos 0xc0, ttl 

Re: [vpp-dev] Vlan tagged packet processing in ACL Plugin

[Andrew Yourtchenko]

Yep,

Yeah it is a work in progress for sub-interface support + the corresponding 
unit tests... is that the use case you have in mind ?

--a

> On 10 Oct 2017, at 08:45, khers  wrote:
> 
> Hi,
> As far as I checked in vpp 17.07 branch version, It seems that the
> vlan tagged(dot1q) packets don't pass through  ACL nodes for applying
> packet filtering rules. Is it a plan for adding vlan tagged packet
> processing in ACL Plugin?
> 
> Thanks
> Cheers
> Edward
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

[Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco)]

Hi Marco,

this issue is already being investigated by Tom Herbert. Strange thing
is that check requires subunit. I wonder if it works if you install
check only. Could you try removing -lsubunit from test/ext/Makefile?

Thanks,
Klement

Quoting Marco Varlese (2017-10-10 16:00:00)
> Hi all,
> 
> As of last week I could happily run tests (e.g. make test) on my distribution
> (openSUSE).
> 
> When I tried again today - with latest master - I couldn't anymore:
> 
> make[2]: Entering directory '/home/mvarlese/repo/vpp/test/ext'
> cc -o /home/mvarlese/repo/vpp/build-root/vapi_test/vapi_c_test -std=gnu99 -g
> -Wall -pthread -I/home/mvarlese/repo/vpp/src -I/home/mvarlese/repo/vpp/build-
> root/install-vpp-native//vpp/include -I/home/mvarlese/repo/vpp/build-
> root/vapi_test/ vapi_c_test.c -L/home/mvarlese/repo/vpp/build-root/build-vpp-
> native/vpp/.libs/ 
> -L/home/mvarlese/repo/vpp/build-root/build-vpp-native/vpp/vpp-
> api/vapi/.libs/ -lvppinfra -lvlibmemoryclient -lsvm -lpthread -lcheck 
> -lsubunit
> -lrt -lm -lvapiclient
> /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: 
> cannot
> find -lsubunit
> collect2: error: ld returned 1 exit status
> 
> I tried to find the newly introduced dependency on libsubunit but wasn't
> successful. 
> 
> Can anybody shed some light?
> Separate, we do not have that package on our distro...
> 
> 
> Cheers,
> Marco
> 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

[vpp-dev] Dependency on libsubunit ? (and failing to run tests)

[Marco Varlese]

Hi all,

As of last week I could happily run tests (e.g. make test) on my distribution
(openSUSE).

When I tried again today - with latest master - I couldn't anymore:

make[2]: Entering directory '/home/mvarlese/repo/vpp/test/ext'
cc -o /home/mvarlese/repo/vpp/build-root/vapi_test/vapi_c_test -std=gnu99 -g
-Wall -pthread -I/home/mvarlese/repo/vpp/src -I/home/mvarlese/repo/vpp/build-
root/install-vpp-native//vpp/include -I/home/mvarlese/repo/vpp/build-
root/vapi_test/ vapi_c_test.c -L/home/mvarlese/repo/vpp/build-root/build-vpp-
native/vpp/.libs/ -L/home/mvarlese/repo/vpp/build-root/build-vpp-native/vpp/vpp-
api/vapi/.libs/ -lvppinfra -lvlibmemoryclient -lsvm -lpthread -lcheck -lsubunit
-lrt -lm -lvapiclient
/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: cannot
find -lsubunit
collect2: error: ld returned 1 exit status

I tried to find the newly introduced dependency on libsubunit but wasn't
successful. 

Can anybody shed some light?
Separate, we do not have that package on our distro...


Cheers,
Marco

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

[vpp-dev] [vpp-acl] Adding a new tokenizer support in mask field while creating classify table

[Avinash Dhar Dubey]

Hello,

I want to add a new tokenizer in_port in mask field while creating classify
table.I dont want to make it part of l2 , l3 or l4 mask. The mask size will
get increased. Will it affect the performance ?? Is there any limit on the
mask size ??


Regards,
Avinash
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Router plugin with VPP 1707 - incoming OSPF Hello packets are dropped by VPP

[Neale Ranns (nranns)]

Hi Michael,

Could you give me a ‘sh trace’ ?

Thanks,
neale

From:  on behalf of Michael Borokhovich 

Date: Monday, 9 October 2017 at 18:14
To: vpp-dev 
Subject: [vpp-dev] Router plugin with VPP 1707 - incoming OSPF Hello packets 
are dropped by VPP

Hi,

After applying the fixes suggested by Jeff, I was able to compile the router 
plugin with VPP 1707.

It runs and allows to enable tap-inject and set up interfaces addresses without 
crashing.

The problem I'm facing now is with setting up FRR OSPF on top of the VPP+router 
plugin.

FRR OSPF is configured and I see OSPF Hello packets flowing out of the machine. 
However, the incoming OSPF Hello packets are dropped by VPP (with the reason 
"ip4 adjacency drop") and never reach the FRR.

The same settings worked with VPP 1609 + router plugin. Maybe I need to 
configure something manually in VPP to allow reception of OSPF multicast 
packets?

So, to summarize the problem, incoming OSPF Hello packets are dropped by VPP, 
while the outgoing hello packets successfully sent by FRR via VPP to the 
neighbouring router.

Any help is appreciated.

Thanks,
Michael.


___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Multiple VRFs in 1609

[Pierre Pfister (ppfister)]

Thanks a ton Jeff.

I merged 8717, 8718 and proposed a different fix to 8716 
(https://gerrit.fd.io/r/#/c/8729/).

I also noticed netlink plugin does not compile on 1710 and master due to a 
change in VPP (Mostly renaming which happened here 
https://gerrit.fd.io/r/#/c/8366/2).
I have a patch ready to fix that, but will wait for the 1710 release before 
merging it.

- Pierre

Le 9 oct. 2017 à 19:18, Shaw, Jeffrey B 
> a écrit :

I’ve submitted changes 8716, 8717, and 8718, which should fix the issues we’ve 
discussed in this thread.

Thanks,
Jeff


___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

[vpp-dev] Vlan tagged packet processing in ACL Plugin

[khers]

Hi,
As far as I checked in vpp 17.07 branch version, It seems that the
vlan tagged(dot1q) packets don't pass through  ACL nodes for applying
packet filtering rules. Is it a plan for adding vlan tagged packet
processing in ACL Plugin?

Thanks
Cheers
Edward
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev