Re: [vpp-dev] VRRP Unit Tests failing on Master Ubuntu

2020-03-16 Thread Dave Wallace
Hi Paul, Good point. Do you think it's worth adding an env var for running tests with intermittent failures on the LF infra?  In my experience, it is often hard to reproduce intermittent failures locally so I'm thinking that in may be useful to have a "penalty box" for flaky tests. Or I

Re: [vpp-dev] VRRP Unit Tests failing on Master Ubuntu

2020-03-13 Thread Paul Vinciguerra
Hi Dave, Please don't add broken tests to extended tests. See https://gerrit.fd.io/r/c/vpp/+/24567/12/test/test_bfd.py Thanks! On Fri, Mar 13, 2020 at 1:33 PM Dave Wallace wrote: > Matt, > > I will keep an eye on this gerrit and merge it once the verify jobs have > completed. > If there are

Re: [vpp-dev] VRRP Unit Tests failing on Master Ubuntu

2020-03-12 Thread Klement Sekera via Lists.Fd.Io
There is also test/scripts/test-loop.sh which might some users better. Regards, Klement > On 12 Mar 2020, at 19:08, Dave Wallace wrote: > > Hi Matt, > > Your patch [0] verified, Ray +1'd it, and I merged it. > > In my investigation on Naginator retries, I found an unrelated gerrit change >

Re: [vpp-dev] VRRP Unit Tests failing on Master Ubuntu

2020-03-12 Thread Matthew Smith via Lists.Fd.Io
Hi Dave, That sounds fine to me. Thanks, -Matt On Thu, Mar 12, 2020 at 11:32 AM Dave Wallace wrote: > Matt, > > I will keep an eye on this gerrit and merge it once the verify jobs have > completed. > If there are other tests which fail, are you ok if I add them to this > patch and turn it

Re: [vpp-dev] VRRP Unit Tests failing on Master Ubuntu

2020-03-12 Thread Dave Wallace
Matt, I will keep an eye on this gerrit and merge it once the verify jobs have completed. If there are other tests which fail, are you ok if I add them to this patch and turn it into a generic 'disable failing tests' gerrit change? The other possibility is that this is due to the recent

Re: [vpp-dev] VRRP Unit Tests failing on Master Ubuntu

2020-03-12 Thread Matthew Smith via Lists.Fd.Io
Change submitted - https://gerrit.fd.io/r/c/vpp/+/25834. Verification jobs are running. Hopefully they won't fail :) -Matt On Thu, Mar 12, 2020 at 10:22 AM Matthew Smith via Lists.Fd.Io wrote: > > I don't have a solution yet, but one observation has popped up quickly > > In the 2 failed

Re: [vpp-dev] VRRP Unit Tests failing on Master Ubuntu

2020-03-12 Thread Matthew Smith via Lists.Fd.Io
I don't have a solution yet, but one observation has popped up quickly In the 2 failed jobs Ray sent links for, one of them had a test fail which was not related to VRRP. There is a BFD6 test failure for the NAT change https://gerrit.fd.io/r/c/vpp/+/25462:

Re: [vpp-dev] VRRP Unit Tests failing on Master Ubuntu

2020-03-12 Thread Paul Vinciguerra
Yes. Has been for a few days. On Thu, Mar 12, 2020 at 9:25 AM Ray Kinsella wrote: > Anyone else noticing seeming spurious failures related to the VRRP > plugin's unit tests. > Some examples from un-related commits. > > Ray K > > nat: timed out session scavenging upgrade ( >

Re: [vpp-dev] VRRP Unit Tests failing on Master Ubuntu

2020-03-12 Thread Matthew Smith via Lists.Fd.Io
Hi Ray, Thanks for bringing it to my attention. I'll look into it. -Matt On Thu, Mar 12, 2020 at 8:24 AM Ray Kinsella wrote: > Anyone else noticing seeming spurious failures related to the VRRP > plugin's unit tests. > Some examples from un-related commits. > > Ray K > > nat: timed out

[vpp-dev] VRRP Unit Tests failing on Master Ubuntu

2020-03-12 Thread Ray Kinsella
Anyone else noticing seeming spurious failures related to the VRRP plugin's unit tests. Some examples from un-related commits. Ray K nat: timed out session scavenging upgrade (https://gerrit.fd.io/r/c/vpp/+/25462)