> Auto-abandon is not auto-delete.
>
> Abandoned patches remain accessible in gerrit and the 600+ patches which
> would be auto-abandoned would continue to exist in virtually the same state
> as they do today. Viewable by all and available to anyone interested in
> utilizing them (i.e.
Guys,
let’s use part of the next Tuesday community call ta talk about this and decide.
I will put it on the agenda….
—
Damjan
> On 01.02.2021., at 16:17, Dave Wallace wrote:
>
> Ole,
>
> Auto-abandon is not auto-delete.
>
> Abandoned patches remain accessible in gerrit and the 600+
Ole,
Auto-abandon is not auto-delete.
Abandoned patches remain accessible in gerrit and the 600+ patches which
would be auto-abandoned would continue to exist in virtually the same
state as they do today. Viewable by all and available to anyone
interested in utilizing them (i.e. restoring,
io on behalf of Ole Troan
Sent: Monday, February 1, 2021 15:38
To: Dave Wallace
Cc: Paul Vinciguerra; Andrew Yourtchenko; vpp-dev
Subject: Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master
Dave,
> To be perfectly honest, other than Andrew's proposal to tweak the
> auto-ab
Dave,
> To be perfectly honest, other than Andrew's proposal to tweak the
> auto-abandon parameters, I have not heard another solution that solves the
> problem of cleaning up the current queue and limiting the size of the queue
> in the future. Is anyone going to volunteer to manually
Hi Paul,
My original motivation for this proposal is to improve the stability and
availability of the CI system by not abusing it through lack of queue
maintenance.
The situation exists today because there is fundamentally a shortage of
committer bandwidth to complete code reviews. This is
Ben,
It was not intended toward you at all. In fact, in my experience, you are
very helpful. I was only looking to highlight cases that did not
specifically benefit me.
Would you like a different change for me to highlight? How about
https://gerrit.fd.io/r/c/vpp/+/27349? That is mine, though.
Hi Paul,
as you refer to this specific story which is close to my heart (as I am the one
who triggered the whole drama by -2'ed), let me clarify:
> The Netgate folks had a changeset they were waiting a month or so for a
> review, then they were told that it was too close to the release to merge
I am a firm -1.
I already have a python script that generates maintainers, but I would
rather we look at the maintainer plugin which was contributed to gerrit by
Cisco. https://gerrit.googlesource.com/plugins/maintainer/
As to Andrew's point, it is just as fair to propose that if a maintainer
Dave,
> On 28 Jan 2021, at 16:59, Dave Wallace wrote:
>
> Andrew,
>
> The only issue I have with your proposal is that there is no way to implement
> it. Gerrit auto-abandon doesn't have a way to detect 'T'.
We could approximate it by setting changeCleanup.abandonIfMergeable to false,
> On 28 Jan 2021, at 16:59, Dave Wallace wrote:
>
> Lastly, I have not heard a counter-proposal from either you or Ole on how to
> clean up the current state of the queue.
Write a tool that assigns reviews to maintainers. Generate reports and send
nag-o-grams.
Then if that doesn’t work.
Andrew,
The only issue I have with your proposal is that there is no way to
implement it. Gerrit auto-abandon doesn't have a way to detect 'T'.
While I agree with your idea that 'T' should be based on a time other
than the initial patch upload, I don't see a mechanism to do so. It
would
> On 28 Jan 2021, at 10:10, Ole Troan wrote:
>
> My impression is that there is a disconnect between someone putting
> something on gerrit and a vpp maintainer reviewing and contributor merging.
Absolutely agree on that.
As a project we certainly can do better on managing the stream of
My impression is that there is a disconnect between someone putting something
on gerrit and a vpp maintainer reviewing and contributor merging.
I was thinking of having a script processing the review queue and generating
reports for each maintainer. Then give each author a chance to get their
+1
ben
> -Original Message-
> From: vpp-dev@lists.fd.io On Behalf Of Dave Wallace
> Sent: mercredi 27 janvier 2021 22:50
> To: vpp-dev@lists.fd.io
> Subject: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master
>
> Folks,
>
> There are currently 636 open Gerrit Reviews on VPP
+1
—
Damjan
>
> On 27.01.2021., at 22:49, Dave Wallace wrote:
>
> Folks,
>
> There are currently 636 open Gerrit Reviews on VPP master [0], the oldest
> being submitted on Jun 13, 2016 [1]!
>
> I would like to propose that the Gerrit Review Auto-Abandon job [2] to reduce
> the size of
16 matches
Mail list logo
