[waffle] [PATCH 52/53] man: spelling/grammar fix

2014-11-09 Thread Emil Velikov
Signed-off-by: Emil Velikov --- man/waffle_get_proc_address.3.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/waffle_get_proc_address.3.xml b/man/waffle_get_proc_address.3.xml index fea2dff..333e127 100644 --- a/man/waffle_get_proc_address.3.xml +++ b/man

[waffle] [PATCH 53/53] man: spelling fix

2014-11-09 Thread Emil Velikov
Signed-off-by: Emil Velikov --- man/waffle_dl.3.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/waffle_dl.3.xml b/man/waffle_dl.3.xml index b089b93..463081f 100644 --- a/man/waffle_dl.3.xml +++ b/man/waffle_dl.3.xml @@ -74,7 +74,7 @@ libGL.so.1

Re: [waffle] [PATCH 47/53] cmake: ensure waffle-static name differs from the shared one

2014-11-09 Thread Emil Velikov
A lovely note which I've complete forgot. Fwiw we can squash this patch with 'cmake: Set default location for all artifacts to top-level directories' as it essentially introduces the regression. -Emil On 09/11/14 22:58, Emil Velikov wrote: > In our current state 'make

[waffle] [PATCH 7/7] glx: drop explicit linking against libGL.so

2014-11-10 Thread Emil Velikov
Use the function pointers stored in glx_platform, to communicate with the library. Signed-off-by: Emil Velikov --- .../Modules/WafflePrintConfigurationSummary.cmake | 1 - src/waffle/CMakeLists.txt | 5 --- src/waffle/glx/glx_config.c| 7

[waffle] Remove libgbm/libGL linktime dependency

2014-11-10 Thread Emil Velikov
Hello all, As the name suggests, the series removes the hard dependency of waffle of the two libraries. Note, due to the lack of link against libGL or libEGL in the final waffle, currently gbm will FAIL yet that is a mesa issue, which ought to be resolved by the time next waffle is released.

[waffle] [PATCH 4/7] gbm: drop explicit linking against libgbm.so

2014-11-10 Thread Emil Velikov
Use the function pointers stored in wgbm_platform, to communicate with the library. Signed-off-by: Emil Velikov --- .../Modules/WafflePrintConfigurationSummary.cmake | 1 - src/waffle/CMakeLists.txt | 1 - src/waffle/gbm/wgbm_display.c | 12

[waffle] [PATCH 5/7] pkg/archlinux: demote libgbm to (make|opt)depend

2014-11-10 Thread Emil Velikov
Waffle no longer links or has hard requirement of the library. Signed-off-by: Emil Velikov --- pkg/archlinux/waffle-git/PKGBUILD | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/archlinux/waffle-git/PKGBUILD b/pkg/archlinux/waffle-git/PKGBUILD index 7dea3a1..932595c

[waffle] [PATCH 1/7] pkg/archlinux: use configure autodetection

2014-11-10 Thread Emil Velikov
Since waffle 1.4 we have autodetection at configure time. Let's use it and drop a couple of lines PKGBUILD magic. Signed-off-by: Emil Velikov --- pkg/archlinux/waffle-1.4.1/PKGBUILD | 6 +- pkg/archlinux/waffle-git/PKGBUILD | 4 2 files changed, 1 insertion(+), 9 deletions(-)

Re: [waffle] [PULL] WGL support

2014-11-10 Thread Emil Velikov
On 10/11/14 06:17, Chad Versace wrote: > On Sun 09 Nov 2014, Emil Velikov wrote: > >> As mentioned earlier here is a rebase of all the wgl work so far on top >> of origin/master. > > Merged to next! So... what does that mean??? That means I'll merge your > branch

[waffle] [PATCH 2/7] pkg/archlinux: waffle does not link against libegl

2014-11-10 Thread Emil Velikov
As such demote libegl to makedepend/optdepent, so that one can build waffle, and optionally use x11_egl/gbm/wayland. Signed-off-by: Emil Velikov --- pkg/archlinux/waffle-git/PKGBUILD | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/archlinux/waffle-git/PKGBUILD b/pkg

Re: [waffle] [PATCH] gbm: drop explicit linking against libgbm.so (v2)

2014-11-12 Thread Emil Velikov
On 12/11/14 06:03, Chad Versace wrote: > From: Emil Velikov > > Use the function pointers stored in wgbm_platform, to communicate > with the library. > > Signed-off-by: Emil Velikov > Signed-off-by: Chad Versace > --- > > v2(chadv): Fix numerous upcast errors of

Re: [waffle] [PATCH] gbm: drop explicit linking against libgbm.so (v2)

2014-11-12 Thread Emil Velikov
On 12/11/14 20:43, Emil Velikov wrote: > On 12/11/14 06:03, Chad Versace wrote: >> From: Emil Velikov >> >> Use the function pointers stored in wgbm_platform, to communicate >> with the library. >> >> Signed-off-by: Emil Velikov >> Signed-off-

[waffle] [PULL] Remove libgbm/libGL linktime dependency

2014-11-12 Thread Emil Velikov
ng against libGL.so (2014-11-13 00:04:08 +) ---- Emil Velikov (7): pkg/archlinux: use configure autodetection pkg/archlinux: waffle does not link against libegl gbm: fetch the libgbm function pointers at wgbm_platform_

Re: [waffle] [RFC v2] wflinfo: add GLSL version information to wflinfo

2014-11-15 Thread Emil Velikov
Hi Dylan, On 14/11/14 17:39, Dylan Baker wrote: > v2: - Don't print for gles1, since gles1 doesn't have a shading language > and will always return FLINFO_GL_ERROR > > Signed-off-by: Dylan Baker > --- > > This addresses Jordan's comments, but from the point of view of having a > parsable o

Re: [waffle] [PULL] Remove libgbm/libGL linktime dependency

2014-11-20 Thread Emil Velikov
On 13/11/14 01:45, Chad Versace wrote: > On Thu 13 Nov 2014, Emil Velikov wrote: >> On 12/11/14 06:07, Chad Versace wrote: >>> Emil, please collect my reviewed-bys onto your branch and look over the >>> changes in my v2 of patch 4. If all looks good to you, let me kno

Re: [waffle] [RFC] Add display support to GBM backend

2014-11-20 Thread Emil Velikov
Hi all, On 19/11/14 19:38, Chad Versace wrote: > Frank sent this patch as a proof-of-concept. It's a draft, and not ready > for committing. I'm posting to the list just to start discussion. > > See [https://github.com/waffle-gl/waffle/issues/18]. I think detailed > patch discussions like this are

[waffle] [PATCH] features: list experimental WGL support

2014-11-21 Thread Emil Velikov
Coming as a product of my GSoC2014, with Waffle 1.5.0 Signed-off-by: Emil Velikov --- features.html | 4 1 file changed, 4 insertions(+) diff --git a/features.html b/features.html index 03054b1..2bfaffa 100644 --- a/features.html +++ b/features.html @@ -25,6 +25,10 @@ Wayland

Re: [waffle] merge of evelikov/remove-libgbm-libgl-libdeps-v2 breaks piglit compilation

2014-11-24 Thread Emil Velikov
Hi there, The other day I've noticed that piglit's linkdeps are completely broken, and that things were working due to shear luck :\ I was hoping that the case is only for glut powered builds, but is seems that the waffle one is effected as well. The problem: libpiglitutil_gl depends on libGL/li

Re: [waffle] merge of evelikov/remove-libgbm-libgl-libdeps-v2 breaks piglit compilation

2014-11-24 Thread Emil Velikov
made a typo in PIGLIT_BUILD_DMA_BUG_TESTS as you typed in it here. Otherwise the dma_buf tests may not have been built :) -Emil On 24/11/14 22:35, Emil Velikov wrote: > Hi there, > > The other day I've noticed that piglit's linkdeps are completely broken, > and that things were wo

Re: [waffle] merge of evelikov/remove-libgbm-libgl-libdeps-v2 breaks piglit compilation

2014-11-26 Thread Emil Velikov
On 25/11/14 16:32, Mark Janes wrote: > Emil Velikov writes: > >> Mark, expect piglit to keep causing you problems, as someone seriously >> needs give it some love. Addressing the cmake warnings would a nice start :) > > I wouldn't mind taking a look at this. I h

Re: [waffle] [PATCH] cmake: Find and set include path for wglext.h

2014-11-26 Thread Emil Velikov
Thanks for the reminder Jose. The general consensus in #cmake (halfway though the GSoC) was that find_package(OpenGL REQUIRED) for Windows development is (should) not be needed, thus I've dropped it ages ago. Either way the commit looks good imho. Reviewed-by: Emil Velikov On 26/11/14

Re: [waffle] Proposed releases for tomorrow (Tue 2 Dec)

2014-12-03 Thread Emil Velikov
On 01/12/14 18:59, Chad Versace wrote: > There are several fixes in the maintenance branch, and master now has WGL > support. > So I'm planning to release waffle-1.4.2 and waffle-1.5.0-rc1 tomorrow (Tue 2 > Dec). > > Let me know if you think I should postpone 1.5.0-rc1, or if you want to see a

Re: [waffle] [RFC] Add display support to GBM backend

2014-12-03 Thread Emil Velikov
On 01/12/14 18:42, Chad Versace wrote: > On 11/20/2014 12:04 PM, Emil Velikov wrote: [snip] >> An interesting/related point here is : >> How do we handle platforms where the display device is not the same as >> the one doing rendering. > > That will eventually become

Re: [waffle] [PATCH] revert commit 92116dae to make it build with cmake < 2.8.12

2014-12-05 Thread Emil Velikov
On 5 December 2014 at 07:20, Chad Versace wrote: > Jordan and Emil, does reverting 92116dae break anything for you? I don't > have a Debian-based machine, (and this CMake hack was made specifically > to silence Debian warnings), so I don't want to commit this without your ok. > Don't think anythin

Re: [waffle] [PATCH] cmake: Fix FindWaffle.cmake to check versions correctly

2014-12-15 Thread Emil Velikov
On 15/12/14 19:41, Dylan Baker wrote: > Ignore this email. Expect a v2 later today. > If you feel extra joyous in cmakeland, you can create a package configuration/version file [1]. It was suggested to me multiple times by the guys in #cmake but never got the courage to do it :) Thanks Emil [1]

Re: [waffle] [PATCH 1/2] waffle: add support for building Waffle using NaCl toolchain

2014-12-15 Thread Emil Velikov
On 15/12/14 12:59, Tapani Pälli wrote: > Patch adds changes required to use NaCl compiler and libraries to > build Waffle. Build can be configured to use specific version of > the NaCl SDK but currently toolchain is fixed to glibc and target > architecture hardcoded as 64bit x86. > If I understand

Re: [waffle] [PATCH 2/2] waffle: initial empty implementation of nacl backend

2014-12-15 Thread Emil Velikov
Hi Tapani, On 15/12/14 12:59, Tapani Pälli wrote: > Patch adds nacl platform skeleton. Only thing is does is that > it creates a container that holds the 3D context object and is > responsible for any communication required with browser. > A few noobish questions/requests: - Does cmake uses the

Re: [waffle] [PATCH v2 2/4] waffle: add support for building Waffle using NaCl toolchain

2014-12-21 Thread Emil Velikov
ake/toolchain-nacl-linux-glibc-x86_64.cmake \ > -DCMAKE_BUILD_TYPE=Release \ > . > > v2: cmake fixes, create toolchain files for nacl (Emil Velikov) > > Signed-off-by: Tapani Pälli > --- > Options.cmake | 5 + > cmake/Modules/WaffleDefineComp

Re: [waffle] [PATCH] waffle: make gl_basic to work with nacl

2014-12-21 Thread Emil Velikov
On 17 December 2014 at 13:12, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > .gitignore | 2 ++ > examples/CMakeLists.txt | 30 ++ > examples/gl_basic.c | 17 + > examples/index.html | 39 +++

Re: [waffle] [PATCH v2 0/4] Initial nacl patches

2014-12-21 Thread Emil Velikov
Hi Tapani, On 17 December 2014 at 10:17, Tapani Pälli wrote: > Hi; > > Here are initial nacl support patches with fixes to the issues > found by Emil. I've added toolchain files for x86 (32bit, 64bit) > under cmake directory. Toolchain files for arm-newlib and pnacl-clang > are postponed to the f

Re: [waffle] [PATCH 02/11] core: Define intptr_t variants of wcore_attrib_list functions

2014-12-21 Thread Emil Velikov
On 16 December 2014 at 08:18, Chad Versace wrote: > When designing the original Waffle 1.0 API, I made a mistake when > I chose to declare attribute lists as arrays of int32_t. Instead, they > should have been arrays of intptr_t. > > A new public function, waffle_window_create2, will have a `const

Re: [waffle] [PATCH 06/11] core: Add attrib_list param to func wcore_platform::window::create

2014-12-21 Thread Emil Velikov
On 16 December 2014 at 08:18, Chad Versace wrote: > This prepares for adding waffle_window_create2() to Waffle's public API, > which will have an attrib_list parameter. > > No attributes are supported yet. Therefore this patch validates, at the > top of each ${PLATFORM}_window_create(), that the

Re: [waffle] [PATCH 07/11] core: Add func wcore_attrib_list_copy()

2014-12-21 Thread Emil Velikov
On 16 December 2014 at 08:18, Chad Versace wrote: > This is useful for making a writable copy of a read-only attribute list. > > Signed-off-by: Chad Versace > --- > src/waffle/core/wcore_attrib_list.c | 19 +++ > src/waffle/core/wcore_attrib_list.h | 3 +++ > 2 files changed, 22

Re: [waffle] [PATCH 02/11] core: Define intptr_t variants of wcore_attrib_list functions

2014-12-21 Thread Emil Velikov
On 21 December 2014 at 14:22, Emil Velikov wrote: > On 16 December 2014 at 08:18, Chad Versace > wrote: >> When designing the original Waffle 1.0 API, I made a mistake when >> I chose to declare attribute lists as arrays of int32_t. Instead, they >> should have been arr

Re: [waffle] [PATCH 00/11] Add new public func waffle_window_create2()

2014-12-21 Thread Emil Velikov
On 16 December 2014 at 08:18, Chad Versace wrote: > Today, waffle_window() has only two parameters: width and height. > > Frank Henigman wants to extend Waffle's GBM backend with the ability to > post window contents to the display. Multiple methods exist for posting > content to the screen with t

Re: [waffle] [PATCH 00/11] Add new public func waffle_window_create2()

2014-12-29 Thread Emil Velikov
On 23/12/14 01:11, Chad Versace wrote: > On 12/21/2014 01:41 PM, Emil Velikov wrote: >> On 16 December 2014 at 08:18, Chad Versace >> wrote: >>> Today, waffle_window() has only two parameters: width and height. >>> >>> Frank Henigman wants to exten

Re: [waffle] [PATCH 07/11] core: Add func wcore_attrib_list_copy()

2014-12-29 Thread Emil Velikov
On 23/12/14 01:02, Chad Versace wrote: > On 12/21/2014 09:00 AM, Emil Velikov wrote: >> On 16 December 2014 at 08:18, Chad Versace >> wrote: >>> This is useful for making a writable copy of a read-only attribute list. >>> >>> Signed-off-by:

Re: [waffle] [PATCH 3/3] wgl: Verify the client area size matches the required size on window creation too.

2014-12-29 Thread Emil Velikov
nd verify this on release > builds too. Barring a bug somewhere I don't think it will ever get hit. And as/if we go with waffle_create_window2, as mentioned above, the asserts/error will be out of place. With the day-dreaming aside the series looks great imho. Reviewed-by: Emil Velikov >

Re: [waffle] [PATCH v2 2/4] waffle: add support for building Waffle using NaCl toolchain

2014-12-29 Thread Emil Velikov
On 22/12/14 22:28, Chad Versace wrote: > On 12/21/2014 07:53 AM, Emil Velikov wrote: >> On 17 December 2014 at 10:17, Tapani Pälli wrote: >>> Patch adds changes required to use NaCl compiler and libraries to >>> build Waffle. Build can be configured to use specific

Re: [waffle] [PATCH v2 2/4] waffle: add support for building Waffle using NaCl toolchain

2014-12-29 Thread Emil Velikov
On 29/12/14 07:47, Tapani Pälli wrote: > > > On 12/21/2014 03:53 PM, Emil Velikov wrote: >> On 17 December 2014 at 10:17, Tapani Pälli >> wrote: >>> Patch adds changes required to use NaCl compiler and libraries to >>> build Waffle. Build can be config

Re: [waffle] [PATCH v2 2/4] waffle: add support for building Waffle using NaCl toolchain

2015-01-04 Thread Emil Velikov
On 31/12/14 18:36, Chad Versace wrote: > On 12/30/2014 11:30 PM, Tapani Pälli wrote: >> On 12/30/2014 12:53 AM, Emil Velikov wrote: >>> On 22/12/14 22:28, Chad Versace wrote: >>>> On 12/21/2014 07:53 AM, Emil Velikov wrote: >>>>> On 17 December 2014 at

Re: [waffle] [PATCH 01/17] include: Define macro WAFFLE_DEPRECATED_1_06

2015-01-15 Thread Emil Velikov
On 4 January 2015 at 22:02, Chad Versace wrote: > This macro annotates symbols as deprecated in Waffle 1.6. The compiler > emits deprecation warnings only if the user enables the feature macro > for the Waffle 1.6 API. > > Signed-off-by: Chad Versace > --- > include/waffle/waffle.h | 12

Re: [waffle] [PATCH 15/17] waffle: Add public func waffle_window_create2() (v2)

2015-01-15 Thread Emil Velikov
Hi Chad, On 4 January 2015 at 22:03, Chad Versace wrote: > Today, waffle_window() has only two parameters: width and height. > > Frank Henigman wants to extend Waffle's GBM backend with the ability to > post window contents to the display. Multiple methods exist for posting > content to the scree

Re: [waffle] [PATCH 05/17] core: Define wcore_attrib_list funcs with type-generic template

2015-01-15 Thread Emil Velikov
On 4 January 2015 at 22:02, Chad Versace wrote: > The current wcore_attrib_list functions work on int32_t attribute lists. > A future commit will add variants that work on intptr_t attribute lists. > To prevent code duplication, this patch moves the definition of all > wcore_attrib_list32 function

[waffle] [PATCH 3/3] wflinfo: use waffle_teardown

2015-01-15 Thread Emil Velikov
Drop ~20k and ~10k of still reachable memory "leaks", for the glx and x11_egl platforms respectively. Signed-off-by: Emil Velikov --- src/utils/wflinfo.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/utils/wflinfo.c b/src/utils/wflinfo.c index 5a9195

[waffle] [PATCH 1/3] waffle: add public func waffle_teardown()

2015-01-15 Thread Emil Velikov
It will be used to teardown the global state, make valgrind happy and catch (point out) a bug or two in the GL/EGL/etc implementations. See the man page for more details. Signed-off-by: Emil Velikov --- include/waffle/waffle.h| 5 ++ man/common/author-emil.velikov.xml | 8

[waffle] [PATCH 2/3] examples: make use of waffle_teardown

2015-01-15 Thread Emil Velikov
hable: 43,695 bytes in 116 blocks After: definitely lost: 87 bytes in 5 blocks still reachable: 23,451 bytes in 55 blocks Signed-off-by: Emil Velikov --- examples/gl_basic.c | 6 +- examples/simple-x11-egl.c | 5 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --

[waffle] [PATCH 0/3] Add the waffle_teardown API

2015-01-15 Thread Emil Velikov
Hello all, As mentioned a while back, here is the function waffle_teardown. Its purpose is to cleanup the global state (the api_platform variable and the respective platform private data). This makes valgrind a bit happier (-20k of still reachable) and will allow the user to use multiple platform

Re: [waffle] [PATCH 0/3] Add the waffle_teardown API

2015-01-15 Thread Emil Velikov
On 15 January 2015 at 15:21, Emil Velikov wrote: > Hello all, > > As mentioned a while back, here is the function waffle_teardown. Its purpose > is to cleanup the global state (the api_platform variable and the respective > platform private data). > > This makes valgrind a

Re: [waffle] [PATCH 01/17] include: Define macro WAFFLE_DEPRECATED_1_06

2015-01-21 Thread Emil Velikov
On 20 January 2015 at 18:50, Chad Versace wrote: > On 01/15/2015 04:29 AM, Emil Velikov wrote: >> On 4 January 2015 at 22:02, Chad Versace wrote: >>> This macro annotates symbols as deprecated in Waffle 1.6. The compiler >>> emits deprecation warnings only if the use

Re: [waffle] [PATCH 05/17] core: Define wcore_attrib_list funcs with type-generic template

2015-01-21 Thread Emil Velikov
On 20 January 2015 at 18:53, Chad Versace wrote: > On 01/15/2015 04:40 AM, Emil Velikov wrote: >> On 4 January 2015 at 22:02, Chad Versace wrote: >>> The current wcore_attrib_list functions work on int32_t attribute lists. >>> A future commit will add variants that

Re: [waffle] [PATCH 07/17] core: Add arithmetic functions that detect overflow

2015-01-21 Thread Emil Velikov
On 4 January 2015 at 22:03, Chad Versace wrote: > Define the function below. All act on size_t inputs. > wcore_add_size > wcore_iadd_size : in-place addition > wcore_mul_size > wcore_imul_size : in-place multiplication > > Future patches will use the functions to safely calculate t

Re: [waffle] [PATCH 17/17] examples/gl_basic: Update to use waffle_window_create2()

2015-01-21 Thread Emil Velikov
On 4 January 2015 at 22:03, Chad Versace wrote: > Tested on GLX, X11/EGL, Wayland, and GBM. > > Signed-off-by: Chad Versace > --- > examples/gl_basic.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/examples/gl_basic.c b/examples/gl_basic.c > index 69418c8..6

Re: [waffle] [PATCH 00/17 v2] Add new public function waffle_window_create2 (v2)

2015-01-21 Thread Emil Velikov
oc failure. [emil] > - Fix some #include placements. [emil] > Hi Chad, I've just send a couple of updates to get things working for WGL/MSVC. With those applied on top of your waffle_window_create2 branch (top commit 1b9a56659c7021265a468f1b238b4591e6f702a1), make check, check-fun

Re: [waffle] [PATCH 1/3] waffle: add public func waffle_teardown()

2015-01-21 Thread Emil Velikov
On 20 January 2015 at 18:28, Chad Versace wrote: > On 01/15/2015 07:21 AM, Emil Velikov wrote: >> It will be used to teardown the global state, make valgrind happy and catch >> (point out) a bug or two in the GL/EGL/etc implementations. >> >> See the man page for more d

Re: [waffle] [PATCH] waffle: return accurate result from wegl_platform_init()

2015-01-23 Thread Emil Velikov
On 23/01/15 01:43, Frank Henigman wrote: > wegl_platform_init() now returns false if dlopen or dlsym fails. > > Signed-off-by: Frank Henigman Reviewed-by: Emil Velikov > --- > Without this, if for some reason libEGL isn't loaded, wflinfo will > crash trying to call th

Re: [waffle] [PATCH 17/17] examples/gl_basic: Update to use waffle_window_create2()

2015-01-27 Thread Emil Velikov
On 27 January 2015 at 17:32, Chad Versace wrote: > On 01/21/2015 06:12 AM, Emil Velikov wrote: >> On 4 January 2015 at 22:03, Chad Versace wrote: >>> Tested on GLX, X11/EGL, Wayland, and GBM. >>> >>> Signed-off-by: Chad Versace >>> --- >>

Re: [waffle] [PATCH] wflinfo: find glGetStringi on both Mali and WGL

2015-01-27 Thread Emil Velikov
On 26 January 2015 at 23:25, Frank Henigman wrote: > Do the glGetStringi lookup after making context current so it works on WGL. > Remove an incorrect glGetStringi lookup, which returned NULL on Mali. > > Signed-off-by: Frank Henigman Reviewed-by: Emil Velikov > --- > Not

[waffle] [PATCH 1/3] android: compilation fix

2015-01-28 Thread Emil Velikov
The function declaration of droid_window_create did not match the function definition. Update the former. Signed-off-by: Emil Velikov --- src/waffle/android/droid_window.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/waffle/android/droid_window.h b/src/waffle

[waffle] [PATCH 2/3] android: include gl_basic & wflinfo to the build

2015-01-28 Thread Emil Velikov
Both targets have their respective build scripts yet the top Android.mk does not include them. As such attempting to build them (m wflinfo) leads to an error - No rule to make target 'wflinfo'. Stop. Signed-off-by: Emil Velikov --- A would be nice for the main branches, as it gives

[waffle] [PATCH 3/3] android: export only the required functions

2015-01-28 Thread Emil Velikov
660 20 49990c346 libwaffle-1.so Overall size: 67K After: textdata bss dec hex filename 36612 560 20 371929148 libwaffle-1.so Overall size: 52K Signed-off-by: Emil Velikov --- Another "would be nice for the maint branches". Originally

[waffle] [RFC PATCH 0/3] Silence compiler warnings

2015-01-28 Thread Emil Velikov
Hi all, The following three patches silences -Wunused-parameter warnings encountered on a Android 5 build. Which prompted me - "How interesting is the build if we add -Wextra ?" - ~60 -Wunused-parameter warnings remaining. - 1 -Wsign-compare - and 212 -Woverride-init The last one we're attem

[waffle] [PATCH 3/3] egl: silence compiler unused-parameter warnings

2015-01-28 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/waffle/egl/wegl_config.c | 2 ++ src/waffle/egl/wegl_context.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/waffle/egl/wegl_config.c b/src/waffle/egl/wegl_config.c index db3d3c9..a79bc53 100644 --- a/src/waffle/egl/wegl_config.c +++ b/src/waffle

[waffle] [PATCH 2/3] wcore: silence compiler unused-parameter warnings

2015-01-28 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/waffle/core/wcore_config.h | 1 + src/waffle/core/wcore_context.h | 1 + src/waffle/core/wcore_platform.h | 2 ++ src/waffle/core/wcore_window.h | 1 + 4 files changed, 5 insertions(+) diff --git a/src/waffle/core/wcore_config.h b/src/waffle/core

[waffle] [PATCH 1/3] android: silence compiler unused-parameter warnings

2015-01-28 Thread Emil Velikov
Android 5 (lollipop) seems to add the -Wunused-parameter to the build, leading to a handful of warnings. Signed-off-by: Emil Velikov --- src/waffle/android/droid_display.c | 2 ++ src/waffle/android/droid_window.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/waffle/android

Re: [waffle] [PATCH 2/3] wcore: silence compiler unused-parameter warnings

2015-01-28 Thread Emil Velikov
On 28/01/15 17:45, Emil Velikov wrote: > Signed-off-by: Emil Velikov > --- > src/waffle/core/wcore_config.h | 1 + > src/waffle/core/wcore_context.h | 1 + > src/waffle/core/wcore_platform.h | 2 ++ > src/waffle/core/wcore_window.h | 1 + > 4 files changed, 5 insertions

Re: [waffle] [PATCH 0/3] Add the waffle_teardown API

2015-01-30 Thread Emil Velikov
On 20 January 2015 at 18:46, Chad Versace wrote: > On 01/15/2015 05:31 AM, Emil Velikov wrote: >> On 15 January 2015 at 15:21, Emil Velikov wrote: >>> Hello all, >>> >>> As mentioned a while back, here is the function waffle_teardown. Its purpose >

Re: [waffle] [PATCH] wflinfo: Fix MSVC compilation error.

2015-01-30 Thread Emil Velikov
On 30 January 2015 at 11:07, Jose Fonseca wrote: > Workaround what seems to be a bug in MSVC parser for C99. > > http://lists.freedesktop.org/archives/waffle/2015-January/000975.html Should have spotted this a Frank sent out the patch. Sorry about this Jose. Reviewed-by: Emil Velikov

Re: [waffle] [PATCH] wflinfo: Fix MSVC compilation error.

2015-01-30 Thread Emil Velikov
On 30/01/15 20:02, Jose Fonseca wrote: > On 30/01/15 16:25, Emil Velikov wrote: >> On 30 January 2015 at 11:07, Jose Fonseca wrote: >>> Workaround what seems to be a bug in MSVC parser for C99. >>> >>> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.

Re: [waffle] [PATCH 2/7] nacl: add implementation for waffle_config_choose

2015-02-03 Thread Emil Velikov
On 23 January 2015 at 07:59, Tapani Pälli wrote: > Patch fills attributes table suitable for Pepper API from > wcore_config_attrs passed by the application. > > Signed-off-by: Tapani Pälli > --- > src/waffle/nacl/nacl_config.c | 30 ++ > src/waffle/nacl/nacl_config.h

Re: [waffle] [PATCH 3/7] nacl: add implementation for waffle_context_create

2015-02-03 Thread Emil Velikov
On 23 January 2015 at 07:59, Tapani Pälli wrote: > Patch creates and initializes pp::Graphics3D context for OpenGL ES 2.0. > > Signed-off-by: Tapani Pälli > --- [...] > @@ -37,6 +43,10 @@ nacl_container_dtor(waffle::nacl_container *nc) > { > if (!nc) > return; > + + nc->ctx = pp

Re: [waffle] [PATCH 5/7] nacl: add implementation for waffle_make_current

2015-02-03 Thread Emil Velikov
On 23 January 2015 at 07:59, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > src/waffle/nacl/nacl_container.cpp | 17 + > src/waffle/nacl/nacl_container.h | 1 + > src/waffle/nacl/nacl_platform.c| 2 +- > 3 files changed, 19 insertions(+), 1 deletion(-) > > diff

Re: [waffle] [PATCH 3/7] nacl: add implementation for waffle_context_create

2015-02-03 Thread Emil Velikov
On 3 February 2015 at 15:37, Emil Velikov wrote: > On 23 January 2015 at 07:59, Tapani Pälli wrote: >> Patch creates and initializes pp::Graphics3D context for OpenGL ES 2.0. >> >> Signed-off-by: Tapani Pälli >> --- > [...] > >> @@ -37,6 +43,10 @@ nacl_co

Re: [waffle] [PATCH 6/7] nacl: add implementation for waffle_window_swap_buffers

2015-02-03 Thread Emil Velikov
On 23 January 2015 at 07:59, Tapani Pälli wrote: > Implementation for nacl is somewhat different as for other platforms, > platform needs to ensure that the previous swap has finished before > issuing another one. This is done by introducing a worker thread that > does buffer swaps from a work que

Re: [waffle] [PATCH 7/7] nacl: add implementation for waffle_dl_sym

2015-02-03 Thread Emil Velikov
On 23 January 2015 at 07:59, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli You might want to model dl handling similar to cgl_dl - both support only single waffle_dl. As such I won't pick on the diffs between the two. > +// Construct a string that maps GL function to NaCl function > +// by

Re: [waffle] [RFC] waffle: support for swap completion callback

2015-02-03 Thread Emil Velikov
On 2 February 2015 at 13:08, Tapani Pälli wrote: > Patch introduces a new API that enables application to register > a callback to be called when swapbuffers has finished. This can be > used to throttle rendering loop. > [...] > @@ -173,6 +174,9 @@ bool > waffle_is_extension_in_string(const char

Re: [waffle] [PATCH 0/7] nacl backend implementation

2015-02-03 Thread Emil Velikov
Hi Tapani, On 30 January 2015 at 10:33, Tapani Pälli wrote: > Hi; > > As a Finn I interpret silence as 'yes' :) I believe this interpretation spans across multiple countries :-P > So I started to hack on swap > completion event support. I believe it can be useful for other backends also > since

Re: [waffle] [PATCH 0/3] Add the waffle_teardown API

2015-02-03 Thread Emil Velikov
On 2 February 2015 at 21:30, Chad Versace wrote: > On 01/15/2015 07:21 AM, Emil Velikov wrote: >> Hello all, >> >> As mentioned a while back, here is the function waffle_teardown. Its purpose >> is to cleanup the global state (the api_platform variable and the respecti

Re: [waffle] [RFC PATCH 0/3] Silence compiler warnings

2015-02-03 Thread Emil Velikov
On 2 February 2015 at 22:14, Chad Versace wrote: > On 01/28/2015 09:45 AM, Emil Velikov wrote: >> Hi all, >> >> The following three patches silences -Wunused-parameter warnings >> encountered on a Android 5 build. >> >> Which prompted me - "Ho

[waffle] [PATCH 5/6] wcore: silence compiler unused-parameter warnings

2015-02-03 Thread Emil Velikov
v2: Inline wcore_display_teardown, and silence the warning. Signed-off-by: Emil Velikov Reviewed-by: Chad Versace --- src/waffle/core/wcore_config.h | 1 + src/waffle/core/wcore_context.h | 1 + src/waffle/core/wcore_display.c | 7 --- src/waffle/core/wcore_display.h | 9

[waffle] [PATCH 6/6] egl: silence compiler unused-parameter warnings

2015-02-03 Thread Emil Velikov
Signed-off-by: Emil Velikov Reviewed-by: Chad Versace --- src/waffle/egl/wegl_config.c | 2 ++ src/waffle/egl/wegl_context.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/waffle/egl/wegl_config.c b/src/waffle/egl/wegl_config.c index db3d3c9..a79bc53 100644 --- a/src/waffle/egl

[waffle] [PATCH 2/6] android: include gl_basic & wflinfo to the build

2015-02-03 Thread Emil Velikov
Both targets have their respective build scripts yet the top Android.mk does not include them. As such attempting to build them (m wflinfo) leads to an error - No rule to make target 'wflinfo'. Stop. Signed-off-by: Emil Velikov Reviewed-by: Chad Versace --- Android.mk | 7 +

[waffle] [RESEND] Android fixes & silence compiler warnings

2015-02-03 Thread Emil Velikov
As requested, this is a resend of the two 3 patch series. I've added the r-b tags, and the patches are coming directly from $ git send-email -6 so I hope they won't be messed up again. If they are, the series can be found in my github repo, branch for-chad/android-fixes As a one-liner - patch

[waffle] [PATCH 3/6] android: export only the required functions

2015-02-03 Thread Emil Velikov
660 20 49990c346 libwaffle-1.so Overall size: 67K After: textdata bss dec hex filename 36612 560 20 371929148 libwaffle-1.so Overall size: 52K Signed-off-by: Emil Velikov Reviewed-by: Chad Versace --- Android.mk | 2 +- 1 file changed, 1

[waffle] [PATCH 4/6] android: silence compiler unused-parameter warnings

2015-02-03 Thread Emil Velikov
Android 5 (lollipop) seems to add the -Wunused-parameter to the build, leading to a handful of warnings. Signed-off-by: Emil Velikov Reviewed-by: Chad Versace --- src/waffle/android/droid_display.c | 2 ++ src/waffle/android/droid_window.c | 2 ++ 2 files changed, 4 insertions(+) diff --git

[waffle] [PATCH 1/6] android: compilation fix

2015-02-03 Thread Emil Velikov
The function declaration of droid_window_create did not match the function definition. Update the former. Signed-off-by: Emil Velikov Reviewed-by: Chad Versace --- src/waffle/android/droid_window.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/waffle/android

[waffle] [PULL] Add the waffle_teardown API

2015-02-03 Thread Emil Velikov
for you to fetch changes up to de9aa633ab08bf1dac546b3f742a557708822c41: wflinfo: use waffle_teardown (2015-02-04 01:07:48 +) ---- Emil Velikov (3): waffle: add public func waffle_teardown() examples: make use of waff

Re: [waffle] [RFC] waffle: support for swap completion callback

2015-02-04 Thread Emil Velikov
On 4 February 2015 at 06:20, Tapani Pälli wrote: > > > On 02/03/2015 07:32 PM, Emil Velikov wrote: >> >> On 2 February 2015 at 13:08, Tapani Pälli wrote: >>> >>> Patch introduces a new API that enables application to register >>> a callback to be c

Re: [waffle] [PATCH] wflinfo: Fix MSVC compilation error.

2015-02-05 Thread Emil Velikov
On 4 February 2015 at 15:12, Jose Fonseca wrote: > On 30/01/15 22:21, Emil Velikov wrote: >> >> On 30/01/15 20:02, Jose Fonseca wrote: >>> >>> On 30/01/15 16:25, Emil Velikov wrote: >>>> >>>> On 30 January 2015 at 11:07, Jose Fonseca wro

[waffle] [PATCH] cmake: update minimum required MSVC version to 2013 Update 4

2015-02-05 Thread Emil Velikov
atter of which shamelessly copied from piglit. Signed-off-by: Emil Velikov --- CMakeLists.txt | 5 + README.txt | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 9bbe387..7b34160 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@

Re: [waffle] [PATCH 7/7] nacl: add implementation for waffle_dl_sym

2015-02-05 Thread Emil Velikov
On 5 February 2015 at 13:12, Tapani wrote: > On 02/03/2015 07:09 PM, Emil Velikov wrote: >> >> On 23 January 2015 at 07:59, Tapani Pälli wrote: ... >>> + >>> +uint32_t len = strlen(src) + strlen(prefix); >> >> So the function name changes from glH

[waffle] [PATCH] cmake: update minimum required MSVC version to 2013 Update 4

2015-02-05 Thread Emil Velikov
atter of which shamelessly copied from piglit. v2: Do not evaluate but check the MSVC variable. (Jose) Reviewed-by: Jose Fonseca Signed-off-by: Emil Velikov --- CMakeLists.txt | 5 + README.txt | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CMakeLists.

Re: [waffle] [PATCH] cmake: update minimum required MSVC version to 2013 Update 4

2015-02-05 Thread Emil Velikov
On 5 February 2015 at 16:51, Jose Fonseca wrote: > Emil, > > After my piglit change, I had to fix it as > > > http://cgit.freedesktop.org/piglit/commit/?id=1dca1680c1b29cf1eb242cf8c51e157ca88c929d > > otherwise CMake would complain about invalid syntax outside MSVC. > > With that, > > Reviewed-b

Re: [waffle] [PATCH 7/7] nacl: add implementation for waffle_dl_sym

2015-02-10 Thread Emil Velikov
On 6 February 2015 at 19:44, Chad Versace wrote: ... > > The way that Waffle's Linux and Mac platforms work today, the user doesn't > have to call waffle_dl_can_open(). When the user calls waffle_dl_sym(), > Waffle internally calls dlopen() if the user hasn't called waffle_dl_sym() > on that libra

Re: [waffle] [wflinfo] [RFC] platform-specific info from wflinfo

2015-02-12 Thread Emil Velikov
On 12 February 2015 at 02:01, Chad Versace wrote: > On 02/10/2015 01:20 PM, Frank Henigman wrote: >> On Tue, Feb 10, 2015 at 4:08 PM, Frank Henigman >> wrote: > >> Looks like Issue #3 is the format of the information. I thought it >> was given we should duplicate existing glxinfo/eglinfo/etc as

Re: [waffle] [PATCH v2 3/8] nacl: add implementation for waffle_config_choose

2015-02-12 Thread Emil Velikov
On 9 February 2015 at 13:24, Tapani Pälli wrote: > Patch fills attributes table suitable for Pepper API from > wcore_config_attrs passed by the application. > > v2: throw error on unsupported context type (Chad Versace) > code cleanup, comment for max attribs (Emil Velikov) &g

Re: [waffle] [PATCH v2 8/8] nacl: add implementation for waffle_dl_sym

2015-02-12 Thread Emil Velikov
On 9 February 2015 at 13:24, Tapani Pälli wrote: > v2: use wcore_calloc, code cleanup (Emil Velikov) > open dll only once in can_open (Chad Versace) > > Signed-off-by: Tapani Pälli > --- > src/waffle/nacl/nacl_platform.c | 69 > +++

[waffle] [PATCH] cgl: do not emit an error on dl_can_open

2015-02-12 Thread Emil Velikov
According to the documentation and the linux backend one should not emit an error but simply return true/false. Signed-off-by: Emil Velikov --- src/waffle/cgl/cgl_dl.m | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/waffle/cgl/cgl_dl.m b/src/waffle/cgl/cgl_dl.m

[waffle] Update on "Don't explicitly link to libraries - use libdl instead"

2015-02-12 Thread Emil Velikov
Hello all, In case you've been wondering what happened with that here it goes: Currently the following libraries could be nuked NEEDED libwayland-client.so.0 NEEDED libwayland-egl.so.1 NEEDED libX11-xcb.so.1 NEEDED libX11.so.6 NEE

Re: [waffle] [wflinfo] [RFC] platform-specific info from wflinfo

2015-02-14 Thread Emil Velikov
On 13 February 2015 at 02:22, Frank Henigman wrote: > On Thu, Feb 12, 2015 at 5:44 AM, Emil Velikov > wrote: >> On 12 February 2015 at 02:01, Chad Versace wrote: >>> On 02/10/2015 01:20 PM, Frank Henigman wrote: >>>> On Tue, Feb 10, 2015 at 4:08 PM, Frank Heni

<    1   2   3   4   5   6   >