Re: Checklist: sending patch for review.

2011-04-01 Thread Nelson Silva
Hi, It would be great to create a sample scenario with a walkthrough as well. It would be important to specify best pratices for using mercurial as well, for instance: - should we create a new local branch for working with an issue - how to send the patch against the default branch -

Checklist: sending patch for review.

2011-03-31 Thread Yuri Z
Hello Apache Wave developers I have compiled for myself a checklist for items that I need to check before sending a patch for review. It is not an official guide, but merely my private checklist that I made in the effort to minimize the amount of comments that my patches receive. Every item in the

Re: Checklist: sending patch for review.

2011-03-31 Thread Michael MacFadden
Yuri, I think this is a good start. I think we should get some comments from the thread and then post this up to the web site in the getting involved section. A couple things I would add are: - The use of @Override. - Under optimization, if dealing with loops or iteration evaluate the growth