https://bugzilla.gnome.org/show_bug.cgi?id=709852
mutter | wayland | unspecified
Matthias Clasen mclasen changed:
What|Removed |Added
Component|Backend: Wayland
https://bugzilla.gnome.org/show_bug.cgi?id=736812
mutter | wayland | 3.13.x
Bastien Nocera bugzilla changed:
What|Removed |Added
Component|Backend: Wayland
https://bugzilla.gnome.org/show_bug.cgi?id=736812
mutter | wayland | 3.13.x
Bastien Nocera bugzilla changed:
What|Removed |Added
Status|UNCONFIRMED
https://bugzilla.gnome.org/show_bug.cgi?id=709852
mutter | wayland | unspecified
Jasper St. Pierre jstpierre changed:
What|Removed |Added
Status|UNCONFIRMED
https://bugzilla.gnome.org/show_bug.cgi?id=745303
Matthias Clasen mcla...@redhat.com changed:
What|Removed |Added
GNOME target|--- |3.16
--
You are
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jasper St. Pierre jstpie...@mecheye.net changed:
What|Removed |Added
Attachment #299288|none|reviewed
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #299284|none|committed
https://bugzilla.gnome.org/show_bug.cgi?id=744933
drag...@gmail.com changed:
What|Removed |Added
CC||drag...@gmail.com
--- Comment #4 from
https://bugzilla.gnome.org/show_bug.cgi?id=744933
--- Comment #6 from Jonas Ådahl jad...@gmail.com ---
Created attachment 298365
-- https://bugzilla.gnome.org/attachment.cgi?id=298365action=edit
wayland: Make the surface actor set its own state
Since the surface actor knows more about how it
https://bugzilla.gnome.org/show_bug.cgi?id=744933
--- Comment #7 from Jonas Ådahl jad...@gmail.com ---
Created attachment 298366
-- https://bugzilla.gnome.org/attachment.cgi?id=298366action=edit
wayland: Fix surface damage region scales
Use the correct scale when processing damage from the
https://bugzilla.gnome.org/show_bug.cgi?id=744933
--- Comment #8 from Jonas Ådahl jad...@gmail.com ---
Created attachment 298367
-- https://bugzilla.gnome.org/attachment.cgi?id=298367action=edit
wayland: Sync surface actor state when changing main monitor
In order to switch to the correct
https://bugzilla.gnome.org/show_bug.cgi?id=744933
drag...@gmail.com changed:
What|Removed |Added
Attachment #298365|none|accepted-commit_now
https://bugzilla.gnome.org/show_bug.cgi?id=744933
drag...@gmail.com changed:
What|Removed |Added
Attachment #298366|none|accepted-commit_now
https://bugzilla.gnome.org/show_bug.cgi?id=744933
--- Comment #5 from Jonas Ådahl jad...@gmail.com ---
Its not. That scale might change without the client changing any of its surface
state. I have some code that reworks how thatvis handled some. I'll post a
patch next week.
--
You are receiving
Assignee|gtk-b...@gtk.org|mutter-ma...@gnome.bugs
Product|gtk+|mutter
QA Contact|gtk-b...@gtk.org|mutter-ma...@gnome.bugs
--
You are receiving this mail because:
You are on the CC list for the bug
https://bugzilla.gnome.org/show_bug.cgi?id=744933
Ray Strode [halfline] rstr...@redhat.com changed:
What|Removed |Added
Status|NEW |RESOLVED
https://bugzilla.gnome.org/show_bug.cgi?id=744933
drag...@gmail.com changed:
What|Removed |Added
Attachment #298367|none|accepted-commit_now
Component|Backend: Wayland|wayland
Assignee|gtk-b...@gtk.org|mutter-ma...@gnome.bugs
Product|gtk+|mutter
QA Contact|gtk-b...@gtk.org|mutter-ma...@gnome.bugs
--- Comment #3 from Matthias Clasen mcla
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #299288|reviewed|none
status|
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #35 from Jonas Ådahl jad...@gmail.com ---
Created attachment 301435
-- https://bugzilla.gnome.org/attachment.cgi?id=301435action=edit
wayland: Always scale cursor according to 'scaling-factor'
Always scale pointer cursors with the
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #299285|0 |1
is obsolete|
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jasper St. Pierre jstpie...@mecheye.net changed:
What|Removed |Added
Attachment #299277|none
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jasper St. Pierre jstpie...@mecheye.net changed:
What|Removed |Added
Attachment #299278|none
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #21 from Owen Taylor otay...@redhat.com ---
Review of attachment 299278:
::: src/backends/meta-cursor-tracker.c
@@ +90,3 @@
+{
+ g_object_ref (displayed_cursor);
+ tracker-displayed_cursor = displayed_cursor;
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #26 from Matthias Clasen mcla...@redhat.com ---
Just in case it helps testing: the adwaita cursor theme in master now has
'hi-dpi' sizes: 64 (=32x2) and 96 (=48x2).
--
You are receiving this mail because:
You are on the CC list for
the object, but assumed relying on the side effect was enough. If
the guideline is to do o = g_object_ref (o) I can change it.
You'd find that the vast majority of uses of g_object_ref() in mutter do use
the return value - it's very common throughout GNOME and certainly how I'd
write this type of code. I
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #32 from Jonas Ådahl jad...@gmail.com ---
(In reply to Owen Taylor from comment #29)
Review of attachment 299281 [details] [review]:
Hmm, in the context of trying to get 3.16.x working well in a hidpi
environment, this seems like
ignoring the scale set on it? (Or are we
already doing that and the problem is the lack of proper enter/leave events?)
* If we want to land this full set of patches, what I think we should do is
wait until 3.16.1 (which is Monday, I think anyways?) and mutter is
branched, and land them
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #34 from Jonas Ådahl jad...@gmail.com ---
(In reply to Owen Taylor from comment #30)
Review of attachment 299282 [details] [review]:
If the point of the refactoring is to get to a clean design, there are
elements of this patch
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #36 from Owen Taylor otay...@redhat.com ---
(In reply to Jonas Ådahl from comment #32)
(In reply to Owen Taylor from comment #29)
Review of attachment 299281 [details] [review] [review]:
Hmm, in the context of trying to get
be running as nested X11 either.
Note that I already have an enum here for what you call running mode to cut
down on the meta_is_wayland_compositor in the backend code.
https://git.gnome.org/browse/mutter/tree/src/backends/x11/meta-backend-x11.c#n49
But personally, I don't care enough about
it isn't
all that bad.
Note that I already have an enum here for what you call running mode to
cut down on the meta_is_wayland_compositor in the backend code.
https://git.gnome.org/browse/mutter/tree/src/backends/x11/meta-backend-x11.
c#n49
What I mean when I say running mode is not really
match that directory!
I don't think winsys is good term for it either. We'd have different winsys
meaning different things depending on the layer (clutter/cogl vs mutter). The
reason MetaCursorSpriteWayland is an awkward fit is because it's a mix of
Wayland client interaction logic and running
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Owen Taylor otay...@redhat.com changed:
What|Removed |Added
Attachment #309529|none|accepted-commit_now
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Owen Taylor otay...@redhat.com changed:
What|Removed |Added
Attachment #309528|none|accepted-commit_now
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Owen Taylor otay...@redhat.com changed:
What|Removed |Added
Attachment #309530|none|accepted-commit_now
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #87 from Owen Taylor otay...@redhat.com ---
(In reply to Jonas Ådahl from comment #86)
A more up to date branch can be found here:
https://github.com/jadahl/mutter/commits/wip/hidpi-cursor
I'm not uploading newer versions here
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Owen Taylor otay...@redhat.com changed:
What|Removed |Added
Attachment #309526|none|accepted-commit_now
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Owen Taylor otay...@redhat.com changed:
What|Removed |Added
Attachment #309527|none|accepted-commit_now
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #86 from Jonas Ådahl jad...@gmail.com ---
A more up to date branch can be found here:
https://github.com/jadahl/mutter/commits/wip/hidpi-cursor
I'm not uploading newer versions here because I suspect the patch order will be
messed up
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Owen Taylor otay...@redhat.com changed:
What|Removed |Added
Attachment #309531|none|accepted-commit_now
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #94 from Owen Taylor otay...@redhat.com ---
Created attachment 309854
-- https://bugzilla.gnome.org/attachment.cgi?id=309854action=edit
wayland: Introduce XWayland surface role
Being a XWayland window should be considered equivalent
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Owen Taylor otay...@redhat.com changed:
What|Removed |Added
Attachment #309532|none|needs-work
that meta_wayland_surface_set_role() doesn't
follow Mutter standards for error handling, but returns 0/-1... I'd definitely
write this as:
!= 0
as other callers do to make it clearer what is going on.
(But please don't add more functions like this, and probably this one would be
better changed.)
--
You
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #97 from Jasper St. Pierre jstpie...@mecheye.net ---
and in a brief look it appears Xwayland calls wl_shell_get_shell_surface() on
them
You're misreading the code. That's for the rootful case, where you run an X
server *fully*
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #307726|0 |1
is obsolete|
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #307719|0 |1
is obsolete|
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #76 from Jonas Ådahl jad...@gmail.com ---
Created attachment 309532
-- https://bugzilla.gnome.org/attachment.cgi?id=309532action=edit
MetaWaylandSurface: Don't respond to frame callback when role unassigned
We won't draw a
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #307721|0 |1
is obsolete|
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #307722|accepted-commit_now |none
status|
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #84 from Jonas Ådahl jad...@gmail.com ---
Created attachment 309540
-- https://bugzilla.gnome.org/attachment.cgi?id=309540action=edit
MetaCursorRenderer: Rely on update_cursor for redrawing
Calling queue_redraw() in _force_update()
in logic so that
cursor sprites changes appearance as it moves across the screen.
Renderers are adapted to handle the necessary functionality.
The logic for changing the cursor sprite appearance is done outside of
MetaCursorSprite, and actually where depends on what type of cursor it
is. In mutter we now
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #307724|0 |1
is obsolete|
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #85 from Jonas Ådahl jad...@gmail.com ---
The newly uploaded series is a rebase on top of current master with various
issues (the ones were a consensus was reached) addressed. It is not a trivial
rebase, since some patches needed to be
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #307720|accepted-commit_now |committed
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #307723|accepted-commit_now |none
status|
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #307715|reviewed|none
status|
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #307714|accepted-commit_now |none
status|
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #307716|accepted-commit_now |none
status|
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #307713|accepted-commit_now |none
status|
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #299277|accepted-commit_now |none
status|
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #299278|accepted-commit_now |none
status|
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #299283|0 |1
is obsolete|
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #299286|0 |1
is obsolete|
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #299287|0 |1
is obsolete|
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #299282|0 |1
is obsolete|
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #53 from Jonas Ådahl jad...@gmail.com ---
Created attachment 307723
-- https://bugzilla.gnome.org/attachment.cgi?id=307723action=edit
MetaWaylandPointer: Don't keep our own MetaCursorTracker pointer
There is no reason to, we can
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #51 from Jonas Ådahl jad...@gmail.com ---
Created attachment 307721
-- https://bugzilla.gnome.org/attachment.cgi?id=307721action=edit
wayland: Keep what surface a surface role is associated with
Will be useful in later commits.
--
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #47 from Jonas Ådahl jad...@gmail.com ---
Created attachment 307717
-- https://bugzilla.gnome.org/attachment.cgi?id=307717action=edit
wayland: GObject:ify surface roles
Make a surface roles into objects with vfuncs for things where
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #50 from Jonas Ådahl jad...@gmail.com ---
Created attachment 307720
-- https://bugzilla.gnome.org/attachment.cgi?id=307720action=edit
MetaCursorRenderer: Use G_DECLARE_DERIVABLE_TYPE to declare the type
--
You are receiving this
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #49 from Jonas Ådahl jad...@gmail.com ---
Created attachment 307719
-- https://bugzilla.gnome.org/attachment.cgi?id=307719action=edit
backends/x11: Draw our own cursor sprite when running nested
Use a specialized cursor renderer
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #57 from Jasper St. Pierre jstpie...@mecheye.net ---
Review of attachment 307719:
Considering I originally wrote the X11 cursor renderer with the goal of nested
in mind, I'm not exactly sure what the point is here.
--
You are
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jasper St. Pierre jstpie...@mecheye.net changed:
What|Removed |Added
Attachment #307722|none
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jasper St. Pierre jstpie...@mecheye.net changed:
What|Removed |Added
Attachment #307718|none|rejected
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jasper St. Pierre jstpie...@mecheye.net changed:
What|Removed |Added
Attachment #307715|none
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jasper St. Pierre jstpie...@mecheye.net changed:
What|Removed |Added
Attachment #307723|none
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jasper St. Pierre jstpie...@mecheye.net changed:
What|Removed |Added
Attachment #307716|none
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jasper St. Pierre jstpie...@mecheye.net changed:
What|Removed |Added
Attachment #307713|none
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jasper St. Pierre jstpie...@mecheye.net changed:
What|Removed |Added
Attachment #307714|none
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jasper St. Pierre jstpie...@mecheye.net changed:
What|Removed |Added
Attachment #307715|accepted-commit_now |reviewed
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jasper St. Pierre jstpie...@mecheye.net changed:
What|Removed |Added
Attachment #307720|none
window wl_surface's as roles internally. If
we'd had a wl_xwayland protocol, we could have a
wl_xwayland_get_xwayland_surface that assigns such a role, but the code would
look exactly the same in mutter for all other parts except when to assign the
role. If you really don't want to call it role, we
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Owen Taylor otay...@redhat.com changed:
What|Removed |Added
Attachment #309534|none|accepted-commit_now
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Owen Taylor otay...@redhat.com changed:
What|Removed |Added
Attachment #309536|none|accepted-commit_now
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Owen Taylor otay...@redhat.com changed:
What|Removed |Added
Attachment #309534|none|accepted-commit_now
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Owen Taylor otay...@redhat.com changed:
What|Removed |Added
Attachment #309537|none|needs-work
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Owen Taylor otay...@redhat.com changed:
What|Removed |Added
Attachment #309535|none|reviewed
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Owen Taylor otay...@redhat.com changed:
What|Removed |Added
Attachment #309533|none|needs-work
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #309527|accepted-commit_now |committed
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #309526|accepted-commit_now |committed
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #109 from Jonas Ådahl jad...@gmail.com ---
Attachment 309526 pushed as 4b667d1 - Rename MetaCursorReference to
MetaCursorSprite
Attachment 309527 pushed as b01f95c - Make MetaCursorSprite a GObject
Attachment 309528 pushed as cd1ce2c -
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #309531|accepted-commit_now |committed
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #309529|accepted-commit_now |committed
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #309528|accepted-commit_now |committed
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Jonas Ådahl jad...@gmail.com changed:
What|Removed |Added
Attachment #309530|accepted-commit_now |committed
86 (oh, many comments on this one now). In
the branch I did this, except I put the 4 patches I planned to push earlier
first (https://github.com/jadahl/mutter/commits/wip/hidpi-cursor is based on
https://github.com/jadahl/mutter/commits/wip/surface-roles )
::: src/wayland/meta-xwayland.c
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #116 from Owen Taylor ---
(In reply to Jonas Ådahl from comment #114)
> (In reply to Owen Taylor from comment #111)
> > Review of attachment 309538 [details] [review] [review]:
> >
> > I have this feeling that it
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Owen Taylor changed:
What|Removed |Added
Attachment #309538|none|needs-work
https://bugzilla.gnome.org/show_bug.cgi?id=744932
Owen Taylor changed:
What|Removed |Added
Attachment #309540|none|accepted-commit_now
https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #113 from Owen Taylor ---
So, I just tried to track down the code path (in your branch) that would queue
of a redraw from cursor_surface_commit() if a hardware cursor wasn't used, and
didnt' find it. How does that
1 - 100 of 369 matches
Mail list logo