Re: [PATCH libinput 6/6] tablet: add touch arbitration

On Thu, Sep 01, 2016 at 03:48:39PM -0700, Jason Gerecke wrote: > The first 5 patches look fine, but I have a few questions about this > one, especially in the unit tests: > [...] > > @@ -1466,6 +1500,16 @@ tablet_process(struct evdev_dispatch *dispatch, > > } > > > > static void > >

[PATCH wayland v2 1/2] util: Document wl_list methods

From: Yong Bakos Add doxygen comment blocks to all wl_list methods. Signed-off-by: Yong Bakos --- v2: Refine the writing for clarity. Add dox for wl_list macros, omitted in v1. Add notices for unsafe operations and invalid states

[PATCH wayland v2 2/2] tests: Add test for wl_list_length

From: Yong Bakos list-test.c did not cover wl_list_length, so add one test that specifically tests this method. Signed-off-by: Yong Bakos Reviewed-by: Eric Engestrom Reviewed-by: Pekka Paalanen

Re: [PATCH libinput 6/6] tablet: add touch arbitration

The first 5 patches look fine, but I have a few questions about this one, especially in the unit tests: On 08/21/2016 11:14 PM, Peter Hutterer wrote: > So far we've relied on the wacom kernel module to do touch arbitration for us > but that won't be the case in upcoming kernels. Implement touch

Re: [PATCH v2 libinput] tablet: if a serial comes in late, discard it

On 08/31/2016 11:43 PM, Peter Hutterer wrote: > If a tool starts reporting with serial 0 and later updates to a real serial, > discard that serial and keep reporting as serial 0. We cannot really change > the tool after proximity in as we don't know when callers query for the serial > (well, we

Re: [PATCH wayland-build-tools] Add helper script to setup and use an uninstalled environment

On 01/09/16 04:13 AM, Pekka Paalanen wrote: > On Wed, 31 Aug 2016 23:17:09 +0100 > Emil Velikov wrote: > >> On 31 August 2016 at 19:10, Derek Foreman wrote: >>> Thanks for taking a look! >>> >>> On 31/08/16 04:22 AM, Emil Velikov wrote:

Re: [PATCH wayland-build-tools] Add helper script to setup and use an uninstalled environment

On 31/08/16 05:17 PM, Emil Velikov wrote: > On 31 August 2016 at 19:10, Derek Foreman wrote: >> Thanks for taking a look! >> >> On 31/08/16 04:22 AM, Emil Velikov wrote: >>> On 30 August 2016 at 19:56, Derek Foreman wrote: From: "Reynaldo H.

Re: [PATCH wayland-build-tools] Add helper script to setup and use an uninstalled environment

On 01/09/16 07:38 AM, Emil Velikov wrote: > On 1 September 2016 at 10:13, Pekka Paalanen wrote: >> On Wed, 31 Aug 2016 23:17:09 +0100 >> Emil Velikov wrote: >> >>> On 31 August 2016 at 19:10, Derek Foreman wrote: Thanks

Re: [PATCH weston] gl-renderer: Add a #define to obtain the prototypes from the gl2 header.

On 1 September 2016 at 15:12, Emmanuel Gil Peyrot wrote: > This prevents a segfault when running on Mesa master, due to the GLES2 > symbols not being declared with the correct prototype (or at all). > > Signed-off-by: Emmanuel Gil Peyrot

[PATCH weston] compositor-wayland: Only destroy the egl_window when using GLES.

This prevents a segfault when unplugging an output when using pixman. Signed-off-by: Emmanuel Gil Peyrot --- libweston/compositor-wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libweston/compositor-wayland.c

[PATCH weston] gl-renderer: Add a #define to obtain the prototypes from the gl2 header.

This prevents a segfault when running on Mesa master, due to the GLES2 symbols not being declared with the correct prototype (or at all). Signed-off-by: Emmanuel Gil Peyrot --- libweston/gl-renderer.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH wayland-build-tools] Add helper script to setup and use an uninstalled environment

On 1 September 2016 at 10:13, Pekka Paalanen wrote: > On Wed, 31 Aug 2016 23:17:09 +0100 > Emil Velikov wrote: > >> On 31 August 2016 at 19:10, Derek Foreman wrote: >> > Thanks for taking a look! >> > >> > On 31/08/16 04:22

Re: [PATCH libinput] doc: extend build instructions for dependencies

On Thu, Sep 01, 2016 at 11:43:41AM +0100, Eric Engestrom wrote: > On Thu, Sep 01, 2016 at 11:18:12AM +0100, Eric Engestrom wrote: > > On Thu, Sep 01, 2016 at 09:53:36AM +1000, Peter Hutterer wrote: > > > Signed-off-by: Peter Hutterer > > > --- > > > Mostly sending this

Re: [PATCH libinput] doc: extend build instructions for dependencies

On Thu, Sep 01, 2016 at 11:18:12AM +0100, Eric Engestrom wrote: > On Thu, Sep 01, 2016 at 09:53:36AM +1000, Peter Hutterer wrote: > > Signed-off-by: Peter Hutterer > > --- > > Mostly sending this out for any hints on how to deal with this in Arch or > > other

Re: [PATCH libinput] Force the HP Stream 11 touchpad as a clickpad

Hi, On 01-09-16 03:38, Peter Hutterer wrote: INPUT_PROP_BUTTONPAD is not set on this device and RMI4 which should fix this is a bit too far into the future at this point. Hack around it. https://bugs.freedesktop.org/show_bug.cgi?id=97147 Signed-off-by: Peter Hutterer

Re: [PATCH libinput] doc: extend build instructions for dependencies

On Thu, Sep 01, 2016 at 09:53:36AM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > Mostly sending this out for any hints on how to deal with this in Arch or > other distributions not listed here. Let me know and I'll add it to the > list. The Arch

Re: [PATCH weston 1/2] input: Update keyboard serial on press and release

Hi > > + keyboard->grab_serial = wl_display_get_serial(compositor->wl_display); > > if (state == WL_KEYBOARD_KEY_STATE_PRESSED) { > > - keyboard->grab_serial = > > - wl_display_get_serial(compositor->wl_display); > > keyboard->grab_time = time; > >

Re: [PATCH wayland-build-tools] Add helper script to setup and use an uninstalled environment

On Wed, 31 Aug 2016 23:17:09 +0100 Emil Velikov wrote: > On 31 August 2016 at 19:10, Derek Foreman wrote: > > Thanks for taking a look! > > > > On 31/08/16 04:22 AM, Emil Velikov wrote: > >> On 30 August 2016 at 19:56, Derek Foreman

[PATCH v2 libinput] tablet: if a serial comes in late, discard it

If a tool starts reporting with serial 0 and later updates to a real serial, discard that serial and keep reporting as serial 0. We cannot really change the tool after proximity in as we don't know when callers query for the serial (well, we could know but any well-written caller will ask for the