Re: [PATCH weston v2] clients: Add XKB compose key support

2016-10-07 Thread Ran Benita
On Fri, Oct 07, 2016 at 12:56:00PM -0700, Bryce Harrington wrote: > On Fri, Oct 07, 2016 at 02:48:41PM +0300, Ran Benita wrote: > > > + /* Look up the appropriate locale, or use "C" as default */ > > > + locale = getenv("LC_ALL"); > > > + if (!locale) > > > + locale = "C"; > > > > Is

Re: [PATCH weston v2] clients: Add XKB compose key support

2016-10-07 Thread Bryce Harrington
On Fri, Oct 07, 2016 at 02:48:41PM +0300, Ran Benita wrote: > > + /* Look up the appropriate locale, or use "C" as default */ > > + locale = getenv("LC_ALL"); > > + if (!locale) > > + locale = "C"; > > Is there a reason why you decided not to use the "full" procedure, i.e. > also

Re: [PATCH weston v2] clients: Add XKB compose key support

2016-10-07 Thread Ran Benita
> + /* Look up the appropriate locale, or use "C" as default */ > + locale = getenv("LC_ALL"); > + if (!locale) > + locale = "C"; Is there a reason why you decided not to use the "full" procedure, i.e. also try LC_CTYPE and LANG? > + /* Set up XKB compose table */ > +

Re: [PATCH weston v2] clients: Add XKB compose key support

2016-10-07 Thread Daniel Stone
Hi, On 7 October 2016 at 05:24, Bryce Harrington wrote: > @@ -3016,8 +3024,38 @@ keyboard_handle_keymap(void *data, struct wl_keyboard > *keyboard, > return; > } > > + /* Look up the appropriate locale, or use "C" as default */ > +

[PATCH weston v2] clients: Add XKB compose key support

2016-10-06 Thread Bryce Harrington
This adds single-symbol compose support using libxkbcommon's compose functionality. E.g., assuming you have the right alt key defined as your compose key, typing +i+' will produce í, and +y+= will produce ¥. This makes compose key work for weston-editor, weston-terminal, weston-eventdemo, and