Re: [PATCH weston v2] clients: Add XKB compose key support

2016-10-07 Thread Ran Benita
On Fri, Oct 07, 2016 at 12:56:00PM -0700, Bryce Harrington wrote: > On Fri, Oct 07, 2016 at 02:48:41PM +0300, Ran Benita wrote: > > > + /* Look up the appropriate locale, or use "C" as default */ > > > + locale = getenv("LC_ALL"); > > > + if (!locale) > > > + locale = "C"; > > > > Is

Re: [PATCH weston v2] clients: Add XKB compose key support

2016-10-07 Thread Bryce Harrington
On Fri, Oct 07, 2016 at 02:48:41PM +0300, Ran Benita wrote: > > + /* Look up the appropriate locale, or use "C" as default */ > > + locale = getenv("LC_ALL"); > > + if (!locale) > > + locale = "C"; > > Is there a reason why you decided not to use the "full" procedure, i.e. > also

[weston] gl-renderer: conditionally call query_buffer while gl_renderer_attach

2016-10-07 Thread Vincent Abriou
While gl_renderer_attach, query_buffer should be call only if the query_buffer function exists. Signed-off-by: Vincent Abriou --- libweston/gl-renderer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libweston/gl-renderer.c

[weston] linux-dmabuf: align DMABUF exposed formats with EGL supported formats

2016-10-07 Thread Vincent Abriou
Even if EGL_EXT_image_dma_buf_import does not provide a way to query the supported pixel formats, we can at least expose to the DMABUF protocol the pixel formats already explicitly supported as fallback by gl-renderer in import_yuv_dmabuf function plus the standard RGB formats that all GPU

Re: [PATCH weston v2] clients: Add XKB compose key support

2016-10-07 Thread Ran Benita
> + /* Look up the appropriate locale, or use "C" as default */ > + locale = getenv("LC_ALL"); > + if (!locale) > + locale = "C"; Is there a reason why you decided not to use the "full" procedure, i.e. also try LC_CTYPE and LANG? > + /* Set up XKB compose table */ > +

Re: [PATCH weston 4/4] compositor: Implement horizontal output layout configuration

2016-10-07 Thread Pekka Paalanen
On Fri, 30 Sep 2016 23:25:30 +0200 Armin Krezović wrote: > This patch adds horizontal output layout configuration using > the previously added code. > > When an output is added, it looks for outputs that it should > be placed next to, if they are specified. If such

Re: [PATCH weston 3/4] compositor: Add internal output object used for layout configuration

2016-10-07 Thread Pekka Paalanen
On Fri, 30 Sep 2016 23:25:29 +0200 Armin Krezović wrote: > This adds weston specific output object, which contains information > about output's position, relative to other outputs. DRM and Windowed > backends code has been updated to make use of the new code and > parse

Re: [PATCH weston 2/4] weston: Move output position setting to compositor

2016-10-07 Thread Pekka Paalanen
On Fri, 30 Sep 2016 23:25:28 +0200 Armin Krezović wrote: > This moves current output positioning code and scale/transform > application to the compositor itself, so the compositor > can configure output layouts any way it wants. > > A helper function for setting x and

Re: [PATCH weston v2] clients: Add XKB compose key support

2016-10-07 Thread Daniel Stone
Hi, On 7 October 2016 at 05:24, Bryce Harrington wrote: > @@ -3016,8 +3024,38 @@ keyboard_handle_keymap(void *data, struct wl_keyboard > *keyboard, > return; > } > > + /* Look up the appropriate locale, or use "C" as default */ > +

Re: [PATCH weston 1/4] libweston: Export weston_output_transform_scale_init

2016-10-07 Thread Pekka Paalanen
On Fri, 30 Sep 2016 23:25:27 +0200 Armin Krezović wrote: > This is required for implementing output layout setting > which relies on current output width and height, and > those are calculated in this function. > > It also changes the function signature to make use >