Re: [PATCH wayland 2/3] scanner: Allow adding a prefix to exported symbols

2017-07-28 Thread Emil Velikov
On 27 July 2017 at 14:01, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Wed, 26 Jul 2017 16:09:32 +0100 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> On 25 July 2017 at 10:24, Pekka Paalanen <ppaala...@gmail.com> wrote: >> > On Tue, 25 Jul

Re: [PATCH 5/5] wayland-scanner.mk: default --object-type to static

2017-07-28 Thread Emil Velikov
On 27 July 2017 at 14:34, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Wed, 26 Jul 2017 14:56:21 +0100 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> From: Emil Velikov <emil.veli...@collabora.com> >> >> Unlike the core wayland library, i

Re: [PATCH 4/5] build: set the scanner --object-type option

2017-07-28 Thread Emil Velikov
On 27 July 2017 at 14:36, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Wed, 26 Jul 2017 14:56:20 +0100 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> From: Emil Velikov <emil.veli...@collabora.com> >> >> Unlike most other scanner users, t

Re: [PATCH 3/5] scanner: introduce --object-type option

2017-07-28 Thread Emil Velikov
On 27 July 2017 at 14:25, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Wed, 26 Jul 2017 14:56:19 +0100 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> From: Emil Velikov <emil.veli...@collabora.com> >> >> The option is used to indicate how

Re: [PATCH wayland 1/3] Pass input/output files as arguments to wayland-scanner

2017-07-28 Thread Emil Velikov
On 27 July 2017 at 13:53, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Wed, 26 Jul 2017 15:57:19 +0100 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> On 3 July 2017 at 10:16, Jonas Ådahl <jad...@gmail.com> wrote: >> > When input/output files

Re: [PATCH wayland 2/3] scanner: Allow adding a prefix to exported symbols

2017-07-26 Thread Emil Velikov
On 25 July 2017 at 10:24, Pekka Paalanen wrote: > On Tue, 25 Jul 2017 15:25:58 +0800 > Jonas Ådahl wrote: > >> On Mon, Jul 24, 2017 at 02:16:04PM +0300, Pekka Paalanen wrote: >> > On Mon, 3 Jul 2017 17:16:45 +0800 >> > Jonas Ådahl wrote:

Re: [PATCH wayland 1/3] Pass input/output files as arguments to wayland-scanner

2017-07-26 Thread Emil Velikov
at warning in the release notes & announcement is due. Fwiw the patch is Reviewed-by: Emil Velikov <emli.veli...@collabora.com> -Emil ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH 5/5] wayland-scanner.mk: default --object-type to static

2017-07-26 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Unlike the core wayland library, it's recommended that one statically embeds the protocol within their binary. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- wayland-scanner.mk | 2 +- 1 file changed, 1 insertion(+)

[PATCH 4/5] build: set the scanner --object-type option

2017-07-26 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Unlike most other scanner users, the core wayland interfaces are public ally available via the libwayland DSO. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 1/5] scanner: remove unused scanner.mk

2017-07-26 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Nothing in the existing codebase references the file. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/scanner.mk | 8 1 file changed, 8 deletions(-) delete mode 100644 src/scanner.mk diff --git a/src/scan

[PATCH 3/5] scanner: introduce --object-type option

2017-07-26 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> The option is used to indicate how the code will be used - would it be a part of shared or static one. In the former case one needs to export the specific symbols, although normally people want to statically build the protoco

[PATCH 2/5] scanner: use tabs for indentation.

2017-07-26 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> File uses tabs, barring the few instances fixed with this patch. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/scanner.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/scanner.c b/s

[PATCH 0/5] Allow user to specify how the code is used

2017-07-26 Thread Emil Velikov
ibility" Defines the goal, as opposed to the means. - there's no "static" option Including .c files from another is considered a bad practise - don't trick people into using it. - The default option, as provided by wayland-scanner.mk, is STATIC - No tests, yet If people are OK with t

Re: [PATCH 1/2] scanner: Add --visibility flag for setting symbol visibility

2017-07-26 Thread Emil Velikov
Hi guys, On 25 July 2017 at 11:39, Jonas Ådahl wrote: > Add a --visibility flag that enables the user to tweak the visibility > of the symbols generated by wayland-scanner. Three alternatives are > exposed: > > 'export': as has always been done up until now, export the symbols

[PATCH weston] compositor-drm: correctly set the version of the drmEventContext

2017-04-04 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> We implement v2 so use that instead of the DRM_EVENT_CONTEXT_VERSION macro. The latter defines the version of the drmEventContext struct declared in the header [used in the current build] and can be 2, 3 or even 1000. Cc: Daniel Stone

Re: [PATCH wayland v2 3/4] wayland-util: build/ship as separate shared library

2017-04-04 Thread Emil Velikov
On 4 April 2017 at 11:26, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Tue, 4 Apr 2017 11:11:32 +0100 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> On 4 April 2017 at 09:08, Pekka Paalanen <ppaala...@gmail.com> wrote: >> > On Mon, 3

Re: [PATCH wayland v2 3/4] wayland-util: build/ship as separate shared library

2017-04-04 Thread Emil Velikov
On 4 April 2017 at 09:08, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Mon, 3 Apr 2017 19:31:50 +0100 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> On 21 March 2017 at 10:05, Pekka Paalanen <ppaala...@gmail.com> wrote: >> > On Mon, 20

Re: [PATCH wayland v2 3/4] wayland-util: build/ship as separate shared library

2017-04-03 Thread Emil Velikov
On 21 March 2017 at 10:05, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Mon, 20 Mar 2017 18:21:53 +0000 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> On 17 March 2017 at 13:32, Pekka Paalanen <ppaala...@gmail.com> wrote: >> > On Fri, 17

Re: [PATCH v2] configure: add option to disable tests

2017-04-03 Thread Emil Velikov
lways >> available. >> >> So, add an option to configure to disable building tests altogether. >> >> Signed-off-by: "Yann E. MORIN" <yann.morin.1...@free.fr> >> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> >> Tested-by: Eric

Re: [PATCH v2] configure: better check for the C++ compiler

2017-04-03 Thread Emil Velikov
On 2 April 2017 at 15:11, Yann E. MORIN wrote: > Hello, > > On 2017-03-08 18:23 +0100, Yann E. MORIN spake thusly: >> When a C++ compiler is not found, then AC_PROG_CXX will set CXX to >> 'false'. >> >> However, we test that we can find $CXX, and indeed false exists in >>

Re: [PATCH wayland v2 3/4] wayland-util: build/ship as separate shared library

2017-03-20 Thread Emil Velikov
On 17 March 2017 at 13:24, Daniel Stone <dan...@fooishbar.org> wrote: > Hi, > > On 17 March 2017 at 12:07, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 17 March 2017 at 11:10, Pekka Paalanen <ppaala...@gmail.com> wrote: >>> On Thu, 16 Mar 2017 15

Re: [PATCH wayland v2 3/4] wayland-util: build/ship as separate shared library

2017-03-17 Thread Emil Velikov
On 17 March 2017 at 11:10, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Thu, 16 Mar 2017 15:32:46 +0000 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> On 16 March 2017 at 12:40, Pekka Paalanen <ppaala...@gmail.com> wrote: >> > On Tue, 21

Re: [PATCH weston v9 01/62] libweston: Add pixel-format helpers

2017-03-16 Thread Emil Velikov
On 16 March 2017 at 10:54, Daniel Stone <dan...@fooishbar.org> wrote: > Hey Emil, > > On 13 March 2017 at 17:57, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 10 March 2017 at 15:28, Daniel Stone <dan...@fooishbar.org> wrote: >>> On 9 Marc

Re: [PATCH weston v9 06/62] compositor-drm: Refactor destroy drm_fb function

2017-03-16 Thread Emil Velikov
On 16 March 2017 at 10:48, Daniel Stone <dan...@fooishbar.org> wrote: > Hey Emil, > > On 13 March 2017 at 18:03, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 10 March 2017 at 15:12, Daniel Stone <dan...@fooishbar.org> wrote: >>> Honestly, I don

Re: [PATCH wayland v2 3/4] wayland-util: build/ship as separate shared library

2017-03-16 Thread Emil Velikov
On 16 March 2017 at 12:40, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Tue, 21 Feb 2017 16:14:28 +0000 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> From: Emil Velikov <emil.veli...@collabora.com> >> >> Currently both of libwayland-{cl

Re: [PATCH wayland v2 2/4] wayland-util: split out private functionality to separate file

2017-03-15 Thread Emil Velikov
On 14 March 2017 at 18:37, Yong Bakos <j...@humanoriented.com> wrote: > Hi Emil, > >> On Feb 21, 2017, at 8:14 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> >> From: Emil Velikov <emil.veli...@collabora.com> >> >> With next commit

Re: [PATCH wayland v2 1/4] wayland-util: do not export the wl_map_* API

2017-03-15 Thread Emil Velikov
On 15 March 2017 at 10:25, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Tue, 14 Mar 2017 15:52:20 +0000 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> On 14 March 2017 at 11:31, Pekka Paalanen <ppaala...@gmail.com> wrote: >> > On Tue, 21

Re: [PATCH wayland v2 1/4] wayland-util: do not export the wl_map_* API

2017-03-14 Thread Emil Velikov
On 14 March 2017 at 11:31, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Tue, 21 Feb 2017 16:14:26 +0000 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> From: Emil Velikov <emil.veli...@collabora.com> >> >> Used only internally and explici

Re: [PATCH weston v9 03/62] compositor-drm: Calculate more cursor state up front

2017-03-13 Thread Emil Velikov
On 10 March 2017 at 15:16, Daniel Stone <dan...@fooishbar.org> wrote: > Hey Emil, > > On 9 March 2017 at 23:12, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 3 March 2017 at 23:05, Daniel Stone <dani...@collabora.com> wrote: >>> - x = (x - ou

Re: [PATCH weston v9 06/62] compositor-drm: Refactor destroy drm_fb function

2017-03-13 Thread Emil Velikov
Hi Dan, On 10 March 2017 at 15:12, Daniel Stone <dan...@fooishbar.org> wrote: > Hey Emil, > > On 9 March 2017 at 23:51, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 3 March 2017 at 23:05, Daniel Stone <dani...@collabora.com> wrote: >>> +static v

Re: [PATCH weston v9 01/62] libweston: Add pixel-format helpers

2017-03-13 Thread Emil Velikov
On 10 March 2017 at 15:28, Daniel Stone <dan...@fooishbar.org> wrote: > Hey Emil, > > On 9 March 2017 at 22:57, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> So was feeling a bit bored and decided to remind myself about all the >> crazy formats out there :-) &g

Re: [PATCH weston v9 06/62] compositor-drm: Refactor destroy drm_fb function

2017-03-09 Thread Emil Velikov
On 3 March 2017 at 23:05, Daniel Stone wrote: > From: Tomohito Esaki > > The drm_fb destroy callback to mostly the same thing regardless of > whether the buffer is a dumb buffer or gbm buffer. This patch refactors > the common parts into a new function

Re: [PATCH weston v9 03/62] compositor-drm: Calculate more cursor state up front

2017-03-09 Thread Emil Velikov
On 3 March 2017 at 23:05, Daniel Stone wrote: > - x = (x - output->base.x) * output->base.current_scale; > - y = (y - output->base.y) * output->base.current_scale; > + x = (output->cursor_plane.x - output->base.x) * > +

Re: [PATCH weston v9 01/62] libweston: Add pixel-format helpers

2017-03-09 Thread Emil Velikov
Hi Daniel, So was feeling a bit bored and decided to remind myself about all the crazy formats out there :-) I believe you've got a couple of mistakes, plus there's a couple of questions/ideas below. Note that handful of those are inspired by now format info is stored in DRM. On 3 March 2017 at

Re: [PATCH libinput] configure.ac: set AC_CONFIG_AUX_DIR

2017-03-09 Thread Emil Velikov
le these. > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> -Emil ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: Remote display with 3D acceleration using Wayland/Weston

2017-02-24 Thread Emil Velikov
On 24 February 2017 at 09:36, Pekka Paalanen wrote: > On Thu, 23 Feb 2017 17:51:24 -0600 > DRC wrote: > >> On 12/15/16 3:01 AM, Pekka Paalanen wrote: >> > The current RDP-backed is written to set up and use only the Pixman >> > renderer.

[PATCH wayland v2 4/4] build: remove white space in -uninstalled.pc.in files

2017-02-21 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> v2: Rebase, address wayland-client-uninstalled Signed-off-by: Emil Velikov <emil.veli...@collabora.com> Reviewed-by: Derek Foreman <der...@osg.samsung.com> (v1) --- src/wayland-client-uninstalled.pc.in | 2 +- s

[PATCH wayland v2 1/4] wayland-util: do not export the wl_map_* API

2017-02-21 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Used only internally and explicitly marked as such with commit cf04b0a18f2 ("Move private definitions and prototypes to new zwayland-private.h") Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- s

[PATCH wayland v2 3/4] wayland-util: build/ship as separate shared library

2017-02-21 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Currently both of libwayland-{client,server} export the same util (amongst other) symbols. Although not crucial this is something which should be avoided where possible. As such let's move the library to a shared one and introduce a stat

[PATCH wayland v2 2/4] wayland-util: split out private functionality to separate file

2017-02-21 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> With next commit we'll make wayland-util a shared library (for reasons mentioned in the commit). As such we need to make sure that the private symbols are somewhere that they can be used internally. Otherwise we'll end up with link error

[PATCH wayland v2 0/4] wayland-util to all

2017-02-21 Thread Emil Velikov
Hi all, As a continuation of an earlier thread: While not crucial, it's recommended that different libraries do not provide the same [conflicting] global symbol(s). As such I've fleshed out libwayland-util.so. It is considered internal one to wayland, since users implicitly use the API (as

Re: [PATCH wayland 1/4] wayland-util: do not export the wl_map_* API

2017-02-21 Thread Emil Velikov
Hi Daniel, all, On 21 November 2016 at 17:32, Daniel Stone <dan...@fooishbar.org> wrote: > Hi Emil, > > On 30 August 2016 at 18:24, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> From: Emil Velikov <emil.veli...@collabora.com> >> >> Use only interna

Re: [PATCH weston] clients: Fix build without Cairo/GLES2

2017-02-20 Thread Emil Velikov
-off-by: Daniel Stone <dani...@collabora.com> > Cc: Emil Velikov <emil.veli...@collabora.com> > Cc: Bryce Harrington <bry...@osg.samsung.com> > --- > clients/window.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/clients

Re: [PATCH weston v5] compositor-drm: Ignore non-KMS devices

2017-02-14 Thread Emil Velikov
ook at the udev > boot_vga issue, but other architectures which lack this, and have > multiple KMS devices present, will hit this. > > Signed-off-by: Daniel Stone <dani...@collabora.com> > Cc: Emil Velikov <emil.veli...@collabora.com> > Reported-by: Thierry Reding <

Re: [PATCH weston v4] compositor-drm: Ignore non-KMS devices

2017-02-13 Thread Emil Velikov
On 13 February 2017 at 18:57, Daniel Stone wrote: > /* > * Find primary GPU > * Some systems may have multiple DRM devices attached to a single seat. This Completely forgot: we want to update the comment above the function. > + /* Make sure this device

[PATCH weston 1/2] libweston/launcher: annotate iface(s) as constant data.

2017-02-10 Thread Emil Velikov
Already considered and handled as such. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- libweston/launcher-direct.c| 2 +- libweston/launcher-impl.h | 8 libweston/launcher-logind.c| 2 +- libweston/launcher-util.c | 6 +++--- lib

[PATCH weston 2/2] libweston/launcher: use C99 initializers for the iface(s)

2017-02-10 Thread Emil Velikov
Makes the code easier to read and browse through. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- libweston/launcher-direct.c| 14 +++--- libweston/launcher-logind.c| 14 +++--- libweston/launcher-weston-launch.c | 14 +++--- 3 files chang

Re: [PATCH v3 weston] compositor-drm: Ignore non-KMS devices

2017-02-10 Thread Emil Velikov
Hi Daniel, Not a huge expert on this code, so take the following with a grain of salt. On 10 February 2017 at 17:43, Daniel Stone wrote: > Given that we can have render-only devices, or vgem in a class of its > own, ignore any non-KMS devices in compositor-drm's device

Re: [PATCH weston v2] editor: Drop g_type_init() call

2017-01-16 Thread Emil Velikov
On 15 January 2017 at 12:26, Quentin Glidic wrote: > From: Quentin Glidic > > HAVE_PANGO is not in any AC_DEFINE(), so the check is just wrong. > g_type_init() was never called, which is fine since GLib 2.36 anyway. > It is better not

[TASK] Trivial libs related fixes (Was Re: [PATCH weston 2/6] libweston: Use the monotonic clock in weston_compositor_get_time)

2016-12-07 Thread Emil Velikov
Hi Dima, Your patch reminded me a few trivial fixes/cleanups. In case you/others feel like sorting out some low hanging fruit ;-) - wayland: bring WESTON_SEARCH_LIBS check for dlopen (libdl) and clock_gettime (librt). - weston: replace WESTON_SEARCH_LIBS([JPEG] ...) with

Re: Create cross wayland-scanner for toolchain or cross-development environment

2016-12-06 Thread Emil Velikov
Yes I fully agree that things are not perfect atm, and we want to work towards improving things. I'll see to "polishing" the scanner as early as possible. Thanks Emil ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org

Re: [RFC PATCH 0/8] Meson build system

2016-12-02 Thread Emil Velikov
On 2 December 2016 at 18:28, Daniel Stone <dan...@fooishbar.org> wrote: > Hey, > > On 2 December 2016 at 18:25, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 1 December 2016 at 15:24, Daniel Stone <dan...@fooishbar.org> wrote: >>> On 1 Decembe

Re: [RFC PATCH 0/8] Meson build system

2016-12-02 Thread Emil Velikov
On 1 December 2016 at 15:24, Daniel Stone <dan...@fooishbar.org> wrote: > Hey Emil, > > On 1 December 2016 at 14:11, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 1 December 2016 at 11:46, Daniel Stone <dan...@fooishbar.org> wrote: >>> On Intel,

Re: Create cross wayland-scanner for toolchain or cross-development environment

2016-12-02 Thread Emil Velikov
On 2 December 2016 at 14:55, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Fri, 8 Jul 2016 11:29:16 +0100 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> Hi all, >> >> Jumping the gun a bit, hope you'll forgive me :-) >> >> On 8

Re: [RFC PATCH 0/8] Meson build system

2016-12-01 Thread Emil Velikov
On 1 December 2016 at 11:46, Daniel Stone <dan...@fooishbar.org> wrote: > Hi, > > On 30 November 2016 at 10:00, Daniel Stone <dan...@fooishbar.org> wrote: >> On 30 November 2016 at 01:02, Emil Velikov <emil.l.veli...@gmail.com> wrote: >>> NB: Everything b

Re: [RFC PATCH 0/8] Meson build system

2016-11-29 Thread Emil Velikov
On 29 November 2016 at 20:50, Daniel Stone <dan...@fooishbar.org> wrote: > Hey Emil, > > On 29 November 2016 at 20:41, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> My voice doesn't carry much weight on wayland-devel still I think it >> will bring some nice fo

Re: [RFC PATCH 0/8] Meson build system

2016-11-29 Thread Emil Velikov
Hi Dan, My voice doesn't carry much weight on wayland-devel still I think it will bring some nice food for thought. As you know better than me the actual speed increase isn't in using Meson, it's due to ninja. If one is to use (write?) make backend for Meson the results wouldn't be that

[PATCH weston v2 5/8] clients/window: use weston_platform_destroy_egl_surface wrapper

2016-11-18 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> v2: Use correct (destroy) API (Dan) Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- clients/window.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/window.c b/clients/window.c index 84d585e..9c

Re: [PATCH libinput] Use AM_DISTCHECK_CONFIGURE_FLAGS, not just DISTCHECK_CONFIGURE_FLAGS

2016-11-15 Thread Emil Velikov
On 15 November 2016 at 05:11, Peter Hutterer <peter.hutte...@who-t.net> wrote: > The latter is for commandline overrides. > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> > --- > Ooops, didn't

[PATCH weston v3 2/2] simple-egl: add support for EGL_KHR_swap_buffers_with_damage

2016-11-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Functionally identical to the EXT version of the extension. v2: s/foo/swap_damage_ext_to_entrypoint/ (Eric, Daniel) v3: do the above sed for real (Frank) Signed-off-by: Emil Velikov <emil.veli...@collabora.com> Reviewed-by: Er

[PATCH weston 6/8] gl-renderer: use weston_platform_destroy_egl_surface wrapper

2016-11-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- libweston/gl-renderer.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c index 09256b4..09

[PATCH weston 8/8] clients/nested-client: call eglTerminate/eglReleaseThread at exit

2016-11-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Do a minimalistic teardown at program exist. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- clients/nested-client.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/clients/nested-client.c b/clients/nested-client.c i

[PATCH weston 7/8] tests/buffer-count-test: teardown after the test

2016-11-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Might be a bit of an overkill, but still. One should cleanup after themselves. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- tests/buffer-count-test.c | 20 +--- 1 file changed, 17 insertions(+), 3 deleti

[PATCH weston 5/8] clients/window: use weston_platform_destroy_egl_surface wrapper

2016-11-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- clients/window.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/window.c b/clients/window.c index 84d585e..dabd0b0 100644 --- a/clients/window.c +

[PATCH weston 3/8] clients/simple-egl: use weston_platform_destroy_egl_surface wrapper

2016-11-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> ... over a direct eglDestroySurface call. Provides symmetry in the create/destroy paths. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- clients/simple-egl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH weston 2/8] clients/nested-client: destroy the EGL surface during teardown

2016-11-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- clients/nested-client.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/clients/nested-client.c b/clients/nested-client.c index 9918da1..0ac6d8f 100644 --- a/clients/nes

[PATCH weston 4/8] clients/subsurfaces: use weston_platform_destroy_egl_surface wrapper

2016-11-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> ... over a direct eglDestroySurface call. Provides symmetry in the create/destroy paths. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- clients/subsurfaces.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH weston 1/8] shared/platform.h: introduce weston_platform_destroy_egl_surface()

2016-11-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Introduce the weston_platform_destroy_egl_surface() wrapper to complement the weston_platform_create_egl_surface() one. We'll use the former with the next patches trhoughout weston to consistently destroy the surface as needed. Signed-off-by

[PATCH weston 0/8] Teardown EGL/WL state where applicable

2016-11-14 Thread Emil Velikov
Hi all, Here is a bunch of trivial fixes which add the odd eglDestroySurface, eglTerminate, $other call. None of them are particularly exciting, just something I came across while fixing/testing some mesa bugs a few months ago. I'd imagine that I've missed the odd piece, but they seem like a

[PATCH weston v2 2/2] simple-egl: add support for EGL_KHR_swap_buffers_with_damage

2016-11-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Functionally identical to the EXT version of the extension. v2: s/foo/swap_damage_ext_to_entrypoint/ (Eric, Daniel) Signed-off-by: Emil Velikov <emil.veli...@collabora.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com>

[PATCH weston v2 1/2] gl-renderer: add support for EGL_KHR_swap_buffers_with_damage

2016-11-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Extension is identical to the EXT one, yet we need to check for the KHR abbreviated extension name + entry-point. v2: s/foo/swap_damage_ext_to_entrypoint/ (Eric, Daniel) Signed-off-by: Emil Velikov <emil.veli...@collabora.com> Revie

Re: [PATCH weston 1/2] gl-renderer: add support for EGL_KHR_swap_buffers_with_damage

2016-11-14 Thread Emil Velikov
On 4 November 2016 at 11:32, Eric Engestrom <eric.engest...@imgtec.com> wrote: > On Thursday, 2016-11-03 22:38:19 +0000, Emil Velikov wrote: >> Extension is identical to the EXT one, yet we need to check for the KHR >> abbreviated extension name + entry-point. >> >

Re: [PATCH wayland 3/3] tests: add scanner tests

2016-11-14 Thread Emil Velikov
On 14 November 2016 at 09:28, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Fri, 11 Nov 2016 20:31:54 +0000 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> Hi Pekka, >> >> It's great to see some tests for the scanner. There's a few thoughts I >

Re: [PATCH wayland 3/3] tests: add scanner tests

2016-11-11 Thread Emil Velikov
Hi Pekka, It's great to see some tests for the scanner. There's a few thoughts I may have mentioned before - please don't read too much into them. On 10 November 2016 at 09:57, Pekka Paalanen wrote: > From: Pekka Paalanen > > Add tests that

[PATCH weston 2/2] simple-egl: add support for EGL_KHR_swap_buffers_with_damage

2016-11-03 Thread Emil Velikov
Functionally identical to the EXT version of the extension. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- clients/simple-egl.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/clients/simple-egl.c b/clients/simple-egl.c

[RFC weston 0/2] Add support for EGL_KHR_swap_buffers_with_damage

2016-11-03 Thread Emil Velikov
Hi all, Khronos has promoted the EXT extension to KHR one and I was wondering if weston won't be interested in handling systems that support the latter and yet lack the former. Admittedly I've not seen (or looked for) any such beasts thus the RFC (also the oddly named foo - suggestions

[PATCH weston 1/2] gl-renderer: add support for EGL_KHR_swap_buffers_with_damage

2016-11-03 Thread Emil Velikov
Extension is identical to the EXT one, yet we need to check for the KHR abbreviated extension name + entry-point. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- libweston/gl-renderer.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff

Re: [PATCH weston 3/3] simple-im: Rename source file to be consistent with other client tools

2016-10-12 Thread Emil Velikov
Hi Bryce, On 12 October 2016 at 00:33, Bryce Harrington wrote: > Except for weston-info, client source files are not prefixed "weston-". > > Signed-off-by: Bryce Harrington > --- > Makefile.am| 2 +- > clients/simple-im.c|

Re: [PATCH weston] gl-renderer: Use EGL_KHR_no_config_context

2016-09-30 Thread Emil Velikov
On 28 September 2016 at 20:54, Armin Krezović wrote: > On 27.09.2016 15:18, Emmanuel Gil Peyrot wrote: >> On Tue, Sep 27, 2016 at 12:29:51PM +0200, Armin Krezović wrote: >>> This patch makes use of recently implemented >>> EGL_KHR_no_config_context extension in Mesa, >>>

Re: [PATCH wayland 0/4] Untangle the symbol export duplication

2016-09-23 Thread Emil Velikov
On 19 September 2016 at 07:08, Daniel Stone <dan...@fooishbar.org> wrote: > Hi, > I do think this is best discussed in-person later in the week, but one > quick note ... > > On 16 September 2016 at 14:47, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On

Re: [PATCH wayland v1 1/1] wayland-scanner.pc.in: prepend pc_sysrootdir

2016-09-19 Thread Emil Velikov
On 15 September 2016 at 23:22, Joe Konno wrote: > From: Joe Konno > > In a cross-compilation environment with packages depending on > wayland-scanner, ensure the path to wayland-scanner is correct. Without > this patch, the path will _not_ point to

Re: [PATCH wayland 0/4] Untangle the symbol export duplication

2016-09-16 Thread Emil Velikov
Hi Pekka, Thanks again for keeping up. On 16 September 2016 at 10:46, Pekka Paalanen wrote: > Hi, > > there seems to be two different issues discussed here. > You cought me, yes there are. > 1) libwayland-client and libwayland-server export the same interface > symbols

Re: [PATCH wayland 0/4] Untangle the symbol export duplication

2016-09-15 Thread Emil Velikov
On 15 September 2016 at 11:47, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Wed, 14 Sep 2016 16:57:17 +0100 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> Hi Pekka, >> >> Huge thanks for the input. >> >> On 14 September 2016 a

Re: [PATCH wayland 0/4] Untangle the symbol export duplication

2016-09-14 Thread Emil Velikov
Hi Pekka, Huge thanks for the input. On 14 September 2016 at 14:35, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Tue, 30 Aug 2016 18:24:18 +0100 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> Hi all, >> >> For a while I've noticed

Re: [PATCH wayland 0/4] Untangle the symbol export duplication

2016-09-14 Thread Emil Velikov
Hi all, On 30 August 2016 at 18:24, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Hi all, > > For a while I've noticed that on mesa side we have few providers of the > wl_drm_interface symbol and literally all our 'wayland binaries' are > linked against both the client an

Re: [PATCH] weston: Use libepoxy for GLESv2 functions.

2016-09-12 Thread Emil Velikov
On 12 September 2016 at 13:15, Pekka Paalanen wrote: > On Mon, 12 Sep 2016 13:56:30 +0200 > Armin Krezović wrote: > >> Khronos has decided to hide the GLESv2 function prototypes >> in GLESv2 headers and the code has landed in latest mesa git. >> >>

Re: [PATCH] RFC, weston: Use eglGetProcAddress to retrieve GLESv2 functions

2016-09-12 Thread Emil Velikov
On 12 September 2016 at 13:04, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 12 September 2016 at 12:11, Daniel Stone <dan...@fooishbar.org> wrote: >> Hi Armin, >> >> On 10 September 2016 at 21:23, Armin Krezović <krezovic.ar...@gmail.com> >> w

Re: [PATCH] RFC, weston: Use eglGetProcAddress to retrieve GLESv2 functions

2016-09-12 Thread Emil Velikov
On 12 September 2016 at 12:11, Daniel Stone wrote: > Hi Armin, > > On 10 September 2016 at 21:23, Armin Krezović > wrote: >> It appears that in current Mesa git master, GLESv2 function >> prototypes are hidden. >> >> Per Emil's suggestion on [1],

Re: [PATCH wayland-build-tools] Add helper script to setup and use an uninstalled environment

2016-09-08 Thread Emil Velikov
On 1 September 2016 at 17:49, Derek Foreman <der...@osg.samsung.com> wrote: > On 01/09/16 04:13 AM, Pekka Paalanen wrote: >> On Wed, 31 Aug 2016 23:17:09 +0100 >> Emil Velikov <emil.l.veli...@gmail.com> wrote: >> >>> On 31 August 2016 at 19:10, De

Re: [PATCH weston] gl-renderer: Add a #define to obtain the prototypes from the gl2 header.

2016-09-01 Thread Emil Velikov
On 1 September 2016 at 15:12, Emmanuel Gil Peyrot wrote: > This prevents a segfault when running on Mesa master, due to the GLES2 > symbols not being declared with the correct prototype (or at all). > > Signed-off-by: Emmanuel Gil Peyrot

Re: [PATCH wayland-build-tools] Add helper script to setup and use an uninstalled environment

2016-09-01 Thread Emil Velikov
On 1 September 2016 at 10:13, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Wed, 31 Aug 2016 23:17:09 +0100 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> On 31 August 2016 at 19:10, Derek Foreman <der...@osg.samsung.com> wrote: >> > Thanks for

Re: [PATCH wayland-build-tools] Add helper script to setup and use an uninstalled environment

2016-08-31 Thread Emil Velikov
On 31 August 2016 at 19:10, Derek Foreman <der...@osg.samsung.com> wrote: > Thanks for taking a look! > > On 31/08/16 04:22 AM, Emil Velikov wrote: >> On 30 August 2016 at 19:56, Derek Foreman <der...@osg.samsung.com> wrote: >>> From: "Reynaldo H. Ve

Re: [PATCH wayland-build-tools] Add helper script to setup and use an uninstalled environment

2016-08-31 Thread Emil Velikov
On 30 August 2016 at 19:56, Derek Foreman wrote: > From: "Reynaldo H. Verdejo Pinochet" > > The wl_uninstalled script provides a shell environment to > build and use an uninstalled Wayland/Weston setup. > > For example, this script and a fresh

[PATCH wayland 3/4] wayland-util: build/ship as separate shared library

2016-08-30 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Currently both of libwayland-{client,server} export the same util (amongst other) symbols. Although not crucial this is something which should be avoided where possible. As such let's move the library to a shared one and introduce a stat

[PATCH wayland 4/4] build: remove white space in -uninstalled.pc.in files

2016-08-30 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- Afaict the gratuitous space isn't a requirement, then again I've just read up on -uninstalled .pc files. --- src/wayland-scanner-uninstalled.pc.in | 2 +- src/wa

[PATCH wayland 0/4] Untangle the symbol export duplication

2016-08-30 Thread Emil Velikov
Hi all, For a while I've noticed that on mesa side we have few providers of the wl_drm_interface symbol and literally all our 'wayland binaries' are linked against both the client and server wayland libs. After having a look, it seems that: - the server exposes the interface symbols for

[PATCH wayland 2/4] wayland-util: split out private functionality to separate file

2016-08-30 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> With next commit we'll make wayland-util a shared library (for reasons mentioned in the commit). As such we need to make sure that the private symbols are somewhere that they can be used internally. Otherwise we'll end up with link errors.

[PATCH wayland 1/4] wayland-util: do not export the wl_map_* API

2016-08-30 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Use only internally and explicitly marked as such with commit cf04b0a18f2 ("Move private definitions and prototypes to new zwayland-private.h") Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- I could not find any

Re: [PATCH wayland-protocols] buildsystem: add missing uninstalled pkg-config infra

2016-08-30 Thread Emil Velikov
On 30 August 2016 at 15:27, Derek Foreman <der...@osg.samsung.com> wrote: > On 30/08/16 06:09 AM, Emil Velikov wrote: >> Hi all, >> >> On 29 August 2016 at 20:23, Derek Foreman <der...@osg.samsung.com> wrote: >>> Hi Bryce, >>> >>> On 26

Re: [PATCH wayland-protocols] buildsystem: add missing uninstalled pkg-config infra

2016-08-30 Thread Emil Velikov
Hi all, On 29 August 2016 at 20:23, Derek Foreman wrote: > Hi Bryce, > > On 26/08/16 08:11 PM, Bryce Harrington wrote: >> On Fri, Aug 26, 2016 at 06:06:43PM -0700, Bryce Harrington wrote: >>> It is confusing terminology to call this 'uninstalled'; sounds like this >>>

<    1   2   3   4   >