Re: [PATCH weston] man: remove redundant word in weston.ini(5)

2018-06-25 Thread Yong Bakos
al seat name that this output should be associated with. If this Reviewed-by: Yong Bakos Cheers, yong > is set then the seat's input will be confined to the output that has the seat > set on it. The expectation is that this functionality will be used in a > multiheaded en

Re: [PATCH] Fix typos in Documentation

2017-01-17 Thread Yong Bakos
Hi Rohith, > On Jan 17, 2017, at 11:41 AM, Rohith Mukku wrote: > > Signed-off-by: Rohith Mukku These spelling and grammar changes in comment blocks are Reviewed-by: Yong Bakos yong > --- > src/libinput.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) >

Re: [PATCH wayland-protocols v4] linux-dmabuf: advertise format modifiers with modifier event

2017-01-19 Thread Yong Bakos
rmat' event from zwp_linux_dmabuf_v1 > version 1. > > bump zwp_linux_dmabuf_v1, zwp_linux_buffer_params_v1 interface > versions to 3. > > v2: specify request name in event description for clarity (Yong Bakos) > v3: grammar fixup (Yong Bakos) > v4: add deprecation warning a

Re: [PATCH v2 wayland 1/5] tests: sync example.xml with wayland.xml

2017-01-20 Thread Yong Bakos
ion > > and a few other, smaller ones. > > Signed-off-by: Peter Hutterer This brings the test xml files up to date for consistency, and is: Reviewed-by: Yong Bakos Tested-by: Yong Bakos yong PS. How did you notice this? > --- > Changes to v1: > - new in this series

Re: [PATCH v2 wayland 2/5] scanner: add helper function to convert "since" to a version

2017-01-20 Thread Yong Bakos
Peter, > On Jan 11, 2017, at 4:13 PM, Peter Hutterer wrote: > > Same code we already had, just moved into a helper function > > Signed-off-by: Peter Hutterer > Reviewed-by: Yong Bakos No change from v1 here and so remains Reviewed-by: Yong Bakos Tested-by: Yong Bakos

Re: [PATCH v2 wayland 3/5] scanner: support "since" attribute for enum entries

2017-01-20 Thread Yong Bakos
atter for the output, it's just warnings, hence why they're > skipped here. > > Signed-off-by: Peter Hutterer This addition of the struct entry `since` member, with corresponding generation and testing are: Reviewed-by: Yong Bakos Tested-by: Yong Bakos yong > -

Re: [PATCH v2 wayland 4/5] protocol: add axis_source.wheel_tilt

2017-01-20 Thread Yong Bakos
Signed-off-by: Peter Hutterer > Reviewed-by: Jonas Ådahl > Acked-by: Daniel Stone > --- This protocol wheel tilt axis source addition, with since attribute, is: Reviewed-by: Yong Bakos yong > Changes to v1: > - more commit message goodness > - sync the test-scanner

Re: [PATCH v2 wayland 5/5] test: remove test attribute for 'since' parsing

2017-01-20 Thread Yong Bakos
-by: Peter Hutterer This indeed removes the temporary, contrived `since` attribute and uses the newly-existing since attribute of the wheel_tilt enum entry as the output under test. Reviewed-by: Yong Bakos Tested-by: Yong Bakos yong > --- > Changes to v1: > - new in this series &

Re: [PATCHv2] Add surface-layers protocol

2017-01-20 Thread Yong Bakos
Hi Drew, Some nits and errors indicated inline below. Across the board, would be nice to have summary attributes where they are missing. > On Jan 7, 2017, at 11:27 AM, Drew DeVault wrote: > > Signed-off-by: Drew DeVault > --- > Changes based on the (minimal) discussion this patch has recieved

Re: [PATCH] tests: add missing include

2017-01-22 Thread Yong Bakos
ibc, which breaks the build. > > Add the missing header. > > Signed-off-by: "Yann E. MORIN" Seems harmless enough. Reviewed-by: Yong Bakos yong > --- > tests/string-test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/string-test.c b/tests/s

Re: Wayland protocol licenses

2017-01-23 Thread Yong Bakos
Hi Pekka, > On Jan 23, 2017, at 12:42 AM, Pekka Paalanen wrote: > > On Fri, 20 Jan 2017 06:51:16 -0800 > Yong Bakos wrote: > >>> + >>> + >>> + >>> +Copyright © 2017 Drew DeVault >>> + >>> +Permission to u

[PATCH wayland] Use standard permission notice

2017-01-23 Thread Yong Bakos
From: Yong Bakos Signed-off-by: Yong Bakos --- src/dtddata.S | 35 +++ 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/src/dtddata.S b/src/dtddata.S index ce51133..2405066 100644 --- a/src/dtddata.S +++ b/src/dtddata.S @@ -1,23 +1,26

[PATCH weston] Use standard permission notice

2017-01-23 Thread Yong Bakos
From: Yong Bakos A handful of source files were not using the MIT Expat text in COPYING. Update these files to bring them inline with the rest, standardizing on the MIT Expat text. Signed-off-by: Yong Bakos --- clients/simple-dmabuf-intel.c | 35

[PATCH weston v2] (multiple): Use standard permission notice

2017-01-23 Thread Yong Bakos
From: Yong Bakos A handful of source files were not using the MIT Expat text in COPYING. Update these files to bring them inline with the rest, standardizing on the MIT Expat text. Signed-off-by: Yong Bakos --- v2: Add commit message prefix. clients/simple-dmabuf-intel.c | 35

[PATCH wayland v2] dtddata: Use standard permission notice

2017-01-23 Thread Yong Bakos
From: Yong Bakos Signed-off-by: Yong Bakos --- v2: Add commit message prefix. src/dtddata.S | 35 +++ 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/src/dtddata.S b/src/dtddata.S index ce51133..2405066 100644 --- a/src/dtddata.S +++ b/src

[PATCH wayland-protocols] linux-dmabuf-unstable: Use standard copyright notice

2017-01-23 Thread Yong Bakos
From: Yong Bakos Signed-off-by: Yong Bakos --- unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml | 38 ++ 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml b/unstable/linux-dmabuf/linux-dmabuf-unstable-v1

Re: [PATCH wayland] wayland-server: hide wl_priv_signal from doxygen

2017-01-25 Thread Yong Bakos
e other functions did not > appear there. > > Signed-off-by: Pekka Paalanen Forgot to add: Reviewed-by: Yong Bakos yong > --- > src/wayland-server.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/wayland-server.c b/src/wayland-ser

Re: [PATCH wayland] wayland-server: hide wl_priv_signal from doxygen

2017-01-25 Thread Yong Bakos
Hi Pekka, > On Jan 25, 2017, at 4:32 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > Fix this set of warnings appearing three times during a build: > > /home/pq/git/wayland/src/wayland-server.c:1868: warning: class > `wl_priv_signal' for related function `wl_priv_signal_init' is not >

[PATCH wayland] dtddata: Use standard permission notice

2017-01-25 Thread Yong Bakos
From: Yong Bakos Signed-off-by: Yong Bakos --- src/dtddata.S | 35 +++ 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/src/dtddata.S b/src/dtddata.S index ce51133..2405066 100644 --- a/src/dtddata.S +++ b/src/dtddata.S @@ -1,23 +1,26

Re: [PATCH] tests: Fix "new ID" type handling in argument_from_va_list test

2017-02-23 Thread Yong Bakos
and > expect an object from it. > > https://bugs.freedesktop.org/show_bug.cgi?id=99899 > > Signed-off-by: Carlos Garnacho Reviewed-by: Yong Bakos Thank you! yong > --- > tests/connection-test.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH wayland-web] FAQ: do not mention GPL

2017-02-23 Thread Yong Bakos
FAQ has raised some questions with > lawyers, too. It's just misleading. > > While at it, make it more clear which MIT license we refer to. > > Signed-off-by: Pekka Paalanen Reviewed-by: Yong Bakos yong > --- > faq.html | 4 ++-- > 1 file changed, 2 insertions(+

Re: [PATCH wayland v3] doc: start documenting Xwayland

2017-03-07 Thread Yong Bakos
Hi Pekka, One misspelling and some minor writing nits noted inline below. > On Jan 30, 2017, at 6:55 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > This is a rough intro to what Xwayland is and does, with just one > implementation detail so far (Window identification). > > I paid no

Re: [PATCH wayland v2 2/4] wayland-util: split out private functionality to separate file

2017-03-14 Thread Yong Bakos
hey can be used internally. Otherwise we'll > end up with link errors. > > v2: Rebase. > > Signed-off-by: Emil Velikov While others will certainly have to chime in and approve patches 2 - 4, the remainder of this series is Reviewed-by: Yong Bakos Tested-by: Yo

Re: [PATCH wayland] scanner: Reword fallthrough comment to quiet GCC

2017-03-17 Thread Yong Bakos
the warning by making the comment less elaborate. > > Signed-off-by: Daniel Stone This mere comment change seems innocuous enough. (Should the standard `__attribute__ ((fallthrough))` be used instead?) Reviewed-by: Yong Bakos yong > --- > src/scanner.c | 4 +--- > 1 file changed,

Re: [PATCH wayland] server: document wl_event_loop and wl_event_source

2017-03-24 Thread Yong Bakos
these methods, and while I did spend some time with each, someone else should probably chime in to verify. There are just a few minor nits, inline below, at: - wl_event_source_fd_update - wl_event_source_check - wl_event_loop_create Reviewed-by: Yong Bakos Regards, yong > --- > d

Re: [PATCH wayland-protocols 00/11] Declaring xdg-shell stable

2017-05-24 Thread Yong Bakos
Hi Jonas, Regarding renaming, > On May 24, 2017, at 2:35 AM, Jonas Ådahl wrote: > > Hi, > > I think it is time to take the next step regarding xdg_shell: declaring it > stable. The current unstable version (xdg_shell unstable v6) has been > implemented in multiple code bases, used by multiple d

Re: [RFC PATCH wayland] protocol: add wl_pointer's axis relative physical direction

2017-08-01 Thread Yong Bakos
dding the axis motion direction, we can have toolkits swap the scroll > direction for applicable widgets, getting the right behavior on all widgets. > > Signed-off-by: Peter Hutterer Other than two minor nits noted below. This is: Reviewed-by: Yong Bakos But others will certainl

Re: [PATCH wayland] cursor: add forward declaration for struct wl_buffer

2017-10-12 Thread Yong Bakos
gt; Making it easier to read and track. > > Signed-off-by: Emil Velikov This is the only other lingering type dependency in wayland-cursor.c coming from wayland-client.h et al. So, similar to the wl_shm forward declaration, this new declaration indeed makes the header self-contained.

thanks and introduction

2016-03-07 Thread Yong Bakos
Hi, Thanks for all things Wayland! My name is Yong Bakos, and I just wanted to introduce myself and beg for your patience as I will probably ask lots of noob questions - some of you have already helped me out on #wayland. I'm employed as a professor at Southern Methodist University's

Re: thanks and introduction

2016-03-09 Thread Yong Bakos
> On Mar 9, 2016, at 2:16 AM, Pekka Paalanen wrote: > > The simple-* demos are self-contained code wise, almost all the other > demos build upon the "toytoolkit" (window.c/h) which supports a lot more > features. > > One more example worth mentioning is weston-info.c, which is an > independent t

Re: thanks and introduction

2016-03-09 Thread Yong Bakos
> On Mar 9, 2016, at 1:14 PM, Bryce Harrington wrote: > > What I'm referring to are warnings that look like: > > /home/bryce/src/Wayland/wayland/wayland-1.10.90/_build/protocol/wayland-server-protocol.h:3082: > warning: The following parameters of wl_keyboard_send_key(struct wl_resource > *res

Re: thanks and introduction

2016-03-09 Thread Yong Bakos
> On Mar 9, 2016, at 6:38 PM, Bryce Harrington wrote: > > On Wed, Mar 09, 2016 at 03:21:12PM -0800, Yong Bakos wrote: >> Specifically, I am: >> >> git clone git://anongit.freedesktop.org/wayland/wayland >> cd wayland >> ./autogen.sh --prefix=$WLD >>

[PATCH] doc: Ignore html subdirectory.

2016-03-10 Thread Yong Bakos
From: Yong Bakos Signed-off-by: Yong Bakos --- doc/doxygen/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/doxygen/.gitignore b/doc/doxygen/.gitignore index 730a1ef..a85e6c0 100644 --- a/doc/doxygen/.gitignore +++ b/doc/doxygen/.gitignore @@ -1,3 +1,4 @@ doxygen_sqlite3.db

[PATCH] gitignore: Ignore sublime config and generated dtd

2016-03-10 Thread Yong Bakos
From: Yong Bakos Signed-off-by: Yong Bakos --- .gitignore | 8 +--- src/.gitignore | 1 + 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index 33e809c..e1d48a9 100644 --- a/.gitignore +++ b/.gitignore @@ -1,16 +1,18 @@ +*.3 +*.7 *.announce

Re: [PATCH] gitignore: Ignore sublime config and generated dtd

2016-03-10 Thread Yong Bakos
> On Mar 10, 2016, at 5:04 PM, Bryce Harrington wrote: > > On Thu, Mar 10, 2016 at 06:30:20PM -0600, Yong Bakos wrote: >> From: Yong Bakos >> >> Signed-off-by: Yong Bakos >> --- >> .gitignore | 8 +--- >> src/.gitignore | 1 + >

[PATCH] ignore: Add *.dtd.embed

2016-03-10 Thread Yong Bakos
From: Yong Bakos Although autogen.sh has a --disable-dtd-validation option, it is on by default, so it seems convenient to add the generated symlink to .gitignore. Signed-off-by: Yong Bakos --- src/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/src/.gitignore b/src/.gitignore

[PATCH] protocol: Add summaries to event parameters

2016-03-29 Thread Yong Bakos
From: Yong Bakos All event arg elements now have an appropriate summary attribute. This was conducted mostly in response to the undocumented parameter warnings generated during 'make check'. Signed-off-by: Yong Bakos --- protocol/wayland

Re: [PATCH] protocol: Add summaries to event parameters

2016-03-29 Thread Yong Bakos
> > From: Yong Bakos > > All event arg elements now have an appropriate summary attribute. > This was conducted mostly in response to the undocumented parameter > warnings generated during 'make check'. > > Signed-off-by: Yong Bakos > --- Sorry I bork

wayland.xml style guide and whitespace fix

2016-03-30 Thread Yong Bakos
Hi fellow hackers, I'm working on documentation fixes within wayland.xml and I'm noticing two major inconsistencies that I would like to address. The first is writing-related. Some enum entry summary attribute values start with a capital letter, while the majority do not. I'd like to standardiz

Re: [PATCH] protocol: Add summaries to event parameters

2016-03-31 Thread Yong Bakos
> On Mar 30, 2016, at 12:53 PM, Bryce Harrington wrote: > > On Tue, Mar 29, 2016 at 06:04:49PM -0500, Yong Bakos wrote: >> From: Yong Bakos >> >> All event arg elements now have an appropriate summary attribute. >> This was conducted mostly in response to the u

history/semantics of uint32_t name

2016-03-31 Thread Yong Bakos
Hi, I've been investigating the semantics of the name parameter within the wl_registry interface, prompted by a recent dialog regarding my patch of arg summary attributes in wayland.xml. I've dug around the Weston source to see what values are passed as the name argument, and where it goes... a

[PATCH wayland] scanner: Fix spacing of @param

2016-03-31 Thread Yong Bakos
From: Yong Bakos Adds one space to the @param lines in generated .h files, aligning the indentation with the rest of the comment block. Signed-off-by: Yong Bakos --- src/scanner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/scanner.c b/src/scanner.c index a895f92

Re: history/semantics of uint32_t name

2016-04-01 Thread Yong Bakos
> On Apr 1, 2016, at 12:41 PM, Bill Spitzak wrote: > > On Fri, Apr 1, 2016 at 12:59 AM, Pekka Paalanen wrote: >> On Fri, 1 Apr 2016 09:44:07 +0800 >> Jonas Ådahl wrote: >> >> > On Thu, Mar 31, 2016 at 06:48:06PM -0500, Yong Bakos wrote: >> > >

[PATCH wayland v2 0/1] protocol: Add summaries to event parameters

2016-04-02 Thread Yong Bakos
From: Yong Bakos This v2 patch incorporates some recent feedback per v1. Two things to note: 1) The 'name' parameter in wl_registry events has been changed to "numeric name" to indicate that, "yes, this is numeric but it serves as a name." This is a "bes

[PATCH wayland v2 1/1] protocol: Add summaries to event parameters

2016-04-02 Thread Yong Bakos
From: Yong Bakos All event arg elements now have an appropriate summary attribute. This was conducted mostly in response to the undocumented parameter warnings generated during 'make check'. Signed-off-by: Yong Bakos --- protocol/wayland

Re: [PATCH wayland v2 0/1] protocol: Add summaries to event parameters

2016-04-04 Thread Yong Bakos
> On Sat, Apr 2, 2016 at 2:48 PM, Yong Bakos wrote: > From: Yong Bakos > > This v2 patch incorporates some recent feedback per v1. Two things to note: > > 1) The 'name' parameter in wl_registry events has been changed to "numeric > name" >to

Re: [PATCH weston 2/3] xwayland: fix spelling mistake (Eric Engestrom)

2016-04-04 Thread Yong Bakos
> Date: Sat, 2 Apr 2016 17:03:14 +0100 > From: Eric Engestrom > To: wayland-devel@lists.freedesktop.org > Cc: Eric Engestrom > Subject: [PATCH weston 2/3] xwayland: fix spelling mistake > Message-ID: <1459612995-8573-2-git-send-email-e...@engestrom.ch> > > Signed-off-by: Eric Engestrom > --- >

Re: [PATCH weston 3/3] client: fix spelling mistake (Eric Engestrom)

2016-04-04 Thread Yong Bakos
> Date: Sat, 2 Apr 2016 17:03:15 +0100 > From: Eric Engestrom > To: wayland-devel@lists.freedesktop.org > Cc: Eric Engestrom > Subject: [PATCH weston 3/3] client: fix spelling mistake > Message-ID: <1459612995-8573-3-git-send-email-e...@engestrom.ch> > > Signed-off-by: Eric Engestrom > --- > c

Re: [PATCH libinput] fix spelling mistakes (Eric Engestrom)

2016-04-04 Thread Yong Bakos
> Date: Sun, 3 Apr 2016 01:47:43 +0100 > From: Eric Engestrom > To: wayland-devel@lists.freedesktop.org > Cc: Eric Engestrom > Subject: [PATCH libinput] fix spelling mistakes > Message-ID: <1459644463-5419-1-git-send-email-e...@engestrom.ch> > > Signed-off-by: Eric Engestrom > --- > doc/t440-s

Re: [PATCH wayland 1/2] protocol: fix spelling mistake (Eric Engestrom)

2016-04-04 Thread Yong Bakos
> Date: Sat, 2 Apr 2016 17:04:04 +0100 > From: Eric Engestrom > To: wayland-devel@lists.freedesktop.org > Cc: Eric Engestrom > Subject: [PATCH wayland 1/2] protocol: fix spelling mistake > Message-ID: <1459613045-9905-1-git-send-email-e...@engestrom.ch> > > Signed-off-by: Eric Engestrom > ---

Re: [PATCH wayland 2/2] wayland-client: fix spelling mistake (Eric Engestrom)

2016-04-04 Thread Yong Bakos
> Date: Sat, 2 Apr 2016 17:04:05 +0100 > From: Eric Engestrom > To: wayland-devel@lists.freedesktop.org > Cc: Eric Engestrom > Subject: [PATCH wayland 2/2] wayland-client: fix spelling mistake > Message-ID: <1459613045-9905-2-git-send-email-e...@engestrom.ch> > > Signed-off-by: Eric Engestrom

Re: [PATCH weston 1/3] zunitc: fix spelling mistake (Eric Engestrom)

2016-04-04 Thread Yong Bakos
> Date: Sat, 2 Apr 2016 17:03:13 +0100 > From: Eric Engestrom > To: wayland-devel@lists.freedesktop.org > Cc: Eric Engestrom > Subject: [PATCH weston 1/3] zunitc: fix spelling mistake > Message-ID: <1459612995-8573-1-git-send-email-e...@engestrom.ch> > > Signed-off-by: Eric Engestrom > --- > t

Re: [PATCH libinput] fix spelling mistakes (Eric Engestrom)

2016-04-05 Thread Yong Bakos
> On Apr 5, 2016, at 3:52 AM, Pekka Paalanen wrote: > > On Mon, 4 Apr 2016 17:55:29 -0500 > Yong Bakos wrote: > >>> Date: Sun, 3 Apr 2016 01:47:43 +0100 >>> From: Eric Engestrom >>> To: wayland-devel@lists.freedesktop.org >>> Cc: Eric En

[PATCH wayland-web] reviewing: Add Reviewed-by reply instructions

2016-04-05 Thread Yong Bakos
From: Yong Bakos Signed-off-by: Yong Bakos --- reviewing.html | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/reviewing.html b/reviewing.html index a664c50..7f8ce3d 100644 --- a/reviewing.html +++ b/reviewing.html @@ -69,8 +69,11 @@ the community. So speak up

[PATCH wayland] protocol: Correct grammar and spelling

2016-04-05 Thread Yong Bakos
From: Yong Bakos Fix grammar, spelling, tense, and other inconsistencies, based on correctness, consistency, and precedence both here and influenced by wayland-protocols. - Standardize lower case for summary attribute values. - Minor vertical whitespace removal consistency. - Standarize

Re: [PATCH wayland] protocol: Correct grammar and spelling

2016-04-05 Thread Yong Bakos
> On Apr 5, 2016, at 8:03 PM, Bryce Harrington wrote: > > On Tue, Apr 05, 2016 at 06:24:01PM -0500, Yong Bakos wrote: >> From: Yong Bakos >> >> Fix grammar, spelling, tense, and other inconsistencies, based on >> correctness, consistency, and precedence both

Re: weston-info

2016-04-06 Thread Yong Bakos
> On Apr 6, 2016, at 1:56 AM, Jonas Ådahl wrote: > > On Tue, Apr 05, 2016 at 11:55:42AM +0200, Olivier Fourdan wrote: >> Hi Pekka, >> >> On 5 April 2016 at 10:30, Pekka Paalanen wrote: >> >>> ​[...] >>> >>> >>> this is a good idea indeed. >>> >>> Originally weston-info was needed in Weston

Re: [PATCH wayland-protocols v6] text: Create second version of text input protocol

2016-04-06 Thread Yong Bakos
re the modifier indices are set by the modifiers_map event) > + > + > + > + > + > + > + > + > + > + Sets the language of the input text. The "language" argument is a > RFC-3066 > + format language tag

Re: [PATCH wayland v2] Add API to install protocol loggers on the server wl_display

2016-04-07 Thread Yong Bakos
> On Apr 7, 2016, at 6:37 AM, Giulio Camuffo wrote: > > The new wl_display_add_protocol_logger allows to set a function as > a logger, which will get called when a new request is received or an > event is sent. > This is akin to setting WAYLAND_DEBUG=1, but more powerful because it > can be enab

Re: [PATCH] Fix compilation error when git commit message has quotes (")

2016-04-07 Thread Yong Bakos
oes this fix? "A double-quote in a log message prematurely ends the enquoted string in src/git-version.h, causing an error during compilation." I know this is a simple patch, but writing a good commit message goes a long way in speeding up a review. 3) The maintainers prefer a

Re: [PATCH v4 xdg-shell-unstable-v6] xdg-shell: add preferred min/max size requests

2016-04-07 Thread Yong Bakos
> On Apr 7, 2016, at 2:39 AM, Olivier Fourdan wrote: > > Some application may wish to restrict their window in size, but > xdg-shell has no mechanism for the client to advertise such a maximum > or minimum preferred size the compositor can use. > > As a result, the compositor may try to maximize

Re: [PATCH v3] xdg-shell: add preferred min/max size requests

2016-04-07 Thread Yong Bakos
> On Apr 7, 2016, at 1:56 AM, Olivier Fourdan wrote: > > Some application may wish to restrict their window in size, but > xdg-shell has no mechanism for the client to advertise such a maximum > or minimum size the compositor can use. > > As a result, the compositor may try to maximize or fullsc

Re: [PATCH wayland v2 1/1] protocol: Add summaries to event parameters

2016-04-08 Thread Yong Bakos
On Apr 5, 2016, at 6:12 PM, Bryce Harrington wrote: > > On Sat, Apr 02, 2016 at 04:48:12PM -0500, Yong Bakos wrote: >> From: Yong Bakos >> >> All event arg elements now have an appropriate summary attribute. >> This was conducted mostly in response to the undo

Re: [PATCH v2 wayland-web] Updated build instructions for wayland-protocols and libwacom

2016-04-08 Thread Yong Bakos
On Apr 5, 2016, at 6:46 PM, Bryce Harrington wrote: > > On Fri, Mar 25, 2016 at 07:37:33PM -0700, spit...@gmail.com wrote: >> From: Bill Spitzak >> >> The Mint instructions have been tested, I had to guess at the Ubuntu12 >> instructions as I no longer have that machine. >> >> v2: Use MAKEFLAG

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-11 Thread Yong Bakos
de if maximize or > fullscreen is achievable, draw an accurate animation, etc. > > Signed-off-by: Olivier Fourdan > Bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=764413 Looks good to me. (Note: I'm a novice reviewer.) Reviewed-by: Yong Bakos yong > --- > v2: Renam

[PATCH wayland-protocols 18/19] pointer-gestures: Add missing xml declaration

2016-04-11 Thread Yong Bakos
From: Yong Bakos Signed-off-by: Yong Bakos --- unstable/pointer-gestures/pointer-gestures-unstable-v1.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/unstable/pointer-gestures/pointer-gestures-unstable-v1.xml b/unstable/pointer-gestures/pointer-gestures-unstable-v1.xml index 26928d5

[PATCH wayland-protocols 07/19] text-input: Rename text-input to text_input

2016-04-11 Thread Yong Bakos
From: Yong Bakos Interface names are lower_snake_case, and corresponding descriptions should match, for accuracy and clarity. This renaming only affects description text, to follow the convention that exists elswhere in this protocol document and in other protocol docs, when referring to

[PATCH wayland-protocols 14/19] linux-dmabuf: Add missing articles and punctuation, adjust minor whitespace

2016-04-11 Thread Yong Bakos
From: Yong Bakos Remove line breaks preceding closing interface tags, to match conventions in this, and other, protocol xml docs. Signed-off-by: Yong Bakos --- unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff

[PATCH wayland-protocols 05/19] xdg-shell: Adjust articles and correct grammar

2016-04-11 Thread Yong Bakos
From: Yong Bakos Signed-off-by: Yong Bakos --- unstable/xdg-shell/xdg-shell-unstable-v5.xml | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/unstable/xdg-shell/xdg-shell-unstable-v5.xml b/unstable/xdg-shell/xdg-shell-unstable-v5.xml index f737f06..584d1fa

[PATCH wayland-protocols 16/19] fullscreen-shell: Correct spelling of parameter name

2016-04-11 Thread Yong Bakos
From: Yong Bakos Signed-off-by: Yong Bakos --- unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml b/unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml

[PATCH wayland-protocols 09/19] tablet: Adjust vertical whitespace for consistency

2016-04-11 Thread Yong Bakos
From: Yong Bakos Add/remove vertial whitespace between xml elements according to conventions elsewhere within this, and other, protocol xml docs. Signed-off-by: Yong Bakos --- unstable/tablet/tablet-unstable-v1.xml | 4 1 file changed, 4 insertions(+) diff --git a/unstable/tablet/tablet

[PATCH wayland-protocols 17/19] fullscreen-shell: Correct grammar, punctuation, minor naming and space

2016-04-11 Thread Yong Bakos
From: Yong Bakos Add missing periods that terminate sentences. Correct ARBITRARY_MODE to match the actual enum value name. Adjust one post-period space to match the rest of the content. Downcase summary description to match the rest of the document. Add line breaks between sequential enum

[PATCH wayland-protocols 10/19] tablet: Correct grammar and punctuation

2016-04-11 Thread Yong Bakos
From: Yong Bakos Correcting minor grammar and punctuation affords clarity. Standardize the use of 'surface local coordinates' in lieu of 'surface relative'. Capitalize Wayland where appropriate, similar to other occurences. Signed-off-by: Yong Bakos --- unstable/tablet/ta

[PATCH wayland-protocols 00/19] Correct writing errors

2016-04-11 Thread Yong Bakos
From: Yong Bakos This v1 patchset consists of spelling, grammar and minor formatting changes to all protocol xml files. The approach here is to be minimally invasive and to not impart stylistic changes; only corrections and consistency changes have been made, with the motivation of accuracy and

[PATCH wayland-protocols 08/19] text-input: Correct grammar

2016-04-11 Thread Yong Bakos
From: Yong Bakos Signed-off-by: Yong Bakos --- unstable/text-input/text-input-unstable-v1.xml | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/unstable/text-input/text-input-unstable-v1.xml b/unstable/text-input/text-input-unstable-v1.xml index

[PATCH wayland-protocols 06/19] text-input: Fix indentation and paragraph whitespace

2016-04-11 Thread Yong Bakos
From: Yong Bakos Replace the tab indentation of the MIT license with appropriate spaces. Add one missing line break between two description paragraphs. Adjust two line breaks to keep descriptions under 80 chars / line. Signed-off-by: Yong Bakos --- unstable/text-input/text-input-unstable-v1

Re: [PATCH wayland-protocols 16/19] fullscreen-shell: Correct spelling of parameter name

2016-04-11 Thread Yong Bakos
Jason, See below, this one patch affects the argument name of the zwp_fullscreen_shell_v1#capability event param name. yong > On Apr 11, 2016, at 5:23 PM, Yong Bakos wrote: > > From: Yong Bakos > > Signed-off-by: Yong Bakos > --- > unstable/fullscreen-shell/fullscreen-

[PATCH wayland-protocols 03/19] xdg-shell: Downcase summary values consistently

2016-04-11 Thread Yong Bakos
From: Yong Bakos Signed-off-by: Yong Bakos --- unstable/xdg-shell/xdg-shell-unstable-v5.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/unstable/xdg-shell/xdg-shell-unstable-v5.xml b/unstable/xdg-shell/xdg-shell-unstable-v5.xml index 542491f..b845258 100644 --- a

[PATCH wayland-protocols 19/19] fullscreen-shell: Add missing xml declaration

2016-04-11 Thread Yong Bakos
From: Yong Bakos Signed-off-by: Yong Bakos --- unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml b/unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml index f076ce5

[PATCH wayland-protocols 15/19] input-method: Correct grammar, add missing line break

2016-04-11 Thread Yong Bakos
From: Yong Bakos Adds one line between two sequential request elements, to match conventions within this, and other, protocol xml docs. Signed-off-by: Yong Bakos --- unstable/input-method/input-method-unstable-v1.xml | 40 -- 1 file changed, 21 insertions(+), 19 deletions

[PATCH wayland-protocols 12/19] pointer-gestures: Correct pluralization, one space, minor vertical whitespace

2016-04-11 Thread Yong Bakos
From: Yong Bakos Adjust double-space after period to be consistent with all content. Adjust vertical whitespace surrounding first and last protocol tag to match conventions in this, and other, protocol xml docs. Signed-off-by: Yong Bakos --- unstable/pointer-gestures/pointer-gestures-unstable

[PATCH wayland-protocols 04/19] xdg-shell: Remove inconsistent spacing

2016-04-11 Thread Yong Bakos
From: Yong Bakos Convert two two-space periods to one, consistent with the rest of the content. Adjusst vertical whitespace of final closing interface tag to match conventions set forth in this, and other, protocol docs. Signed-off-by: Yong Bakos --- unstable/xdg-shell/xdg-shell-unstable-v5

[PATCH wayland-protocols 13/19] pointer-constraints: Correct spelling, grammar and consistency

2016-04-11 Thread Yong Bakos
From: Yong Bakos Downcase the protocol summary description to match other protocols. Replace 'surface-relative' with 'surface local' for consistency and clarity. Signed-off-by: Yong Bakos --- .../pointer-constraints-unstable-v1.xml | 16 ---

[PATCH wayland-protocols 02/19] presentation-time: Correct minor grammar errors

2016-04-11 Thread Yong Bakos
From: Yong Bakos Signed-off-by: Yong Bakos --- stable/presentation-time/presentation-time.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/stable/presentation-time/presentation-time.xml b/stable/presentation-time/presentation-time.xml index dc4ae68..b8de4ca 100644

[PATCH wayland-protocols 11/19] relative-pointer: Correct spelling error, one capitalization, and minor space

2016-04-11 Thread Yong Bakos
From: Yong Bakos Downcase the protocol description summary. Adjust two double-spaces to one, like the rest of the content. Signed-off-by: Yong Bakos --- unstable/relative-pointer/relative-pointer-unstable-v1.xml | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a

[PATCH wayland-protocols 01/19] readme: Correct spelling and grammar

2016-04-11 Thread Yong Bakos
From: Yong Bakos Signed-off-by: Yong Bakos --- README | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/README b/README index 324f873..da1f1d5 100644 --- a/README +++ b/README @@ -1,9 +1,9 @@ Wayland protocols - -wayland-protocols contains

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-12 Thread Yong Bakos
On Apr 12, 2016, at 2:22 AM, Jonas Ådahl wrote: > > On Tue, Apr 12, 2016 at 03:20:27AM -0400, Olivier Fourdan wrote: >> Hi Mike, >> >> - Original Message - >>> I think this should probably use uint instead of int for params since zero >>> is the "unset" number. Otherwise you have to writ

Re: [PATCH wayland-protocols 00/19] Correct writing errors

2016-04-13 Thread Yong Bakos
On Apr 13, 2016, at 2:54 PM, Bryce Harrington wrote: > > On Mon, Apr 11, 2016 at 05:22:47PM -0500, Yong Bakos wrote: >> From: Yong Bakos >> >> This v1 patchset consists of spelling, grammar and minor formatting >> changes to all protocol xml files. The appro

[PATCH wayland-build-tools] readme: Add instructions

2016-04-13 Thread Yong Bakos
From: Yong Bakos The original readme just had a link to the official build instructions, which does not help a user with these build tools. Signed-off-by: Yong Bakos --- README | 54 +- 1 file changed, 53 insertions(+), 1 deletion(-) diff

[PATCH wayland-build-tools] wl_install_deps: Add missing dependencies, remove INCLUDE_XWAYLAND logic

2016-04-13 Thread Yong Bakos
From: Yong Bakos Building on Ubuntu 15.10 x64 fails due to missing packages: libtool, libxml2-dev, libpng-dev, libglib2.0-dev, libgudev-1.0-dev, libgcrypt20-dev, x11proto-scrnsaver-dev, libxfont-dev, and libedit-dev. In addition, building with INCLUDE_XWAYLAND=0 causes failures due to missing

Re: [PATCH wayland-protocols 1/7] xdg-shell: Turn xdg_surface into a generic base interface

2016-04-14 Thread Yong Bakos
On Apr 14, 2016, at 3:28 AM, Jonas Ådahl wrote: > > Split out toplevel window like requests and events into a new interface > called xdg_toplevel, and turn xdg_surface into a generic base interface > which others extends. > > xdg_popup is changed to extend the xdg_surface. > > The configure eve

Re: [PATCH wayland-protocols 2/7] xdg-shell: Put xdg_shell events after requests

2016-04-14 Thread Yong Bakos
On Apr 14, 2016, at 3:28 AM, Jonas Ådahl wrote: > > It makes the structure consistent with most other protocols and > provides a clear separation between what is done by the server and what > is done by the client. > > Signed-off-by: Jonas Ådahl Looks good to me. Revie

Re: [PATCH wayland-protocols 6/7] xdg-shell: Make xdg_popup non-grabbing by default

2016-04-14 Thread Yong Bakos
On Apr 14, 2016, at 3:28 AM, Jonas Ådahl wrote: > > Turn xdg_popup into plain temporary child surfaces without any grabbing > or mapping order requirements by default. > > In order to create grabbing popup chains, a new request 'grab' is > introduced which enables more or less the same semantics

Re: [PATCH wayland-protocols 7/7] xdg-shell: Introduce xdg_positioner

2016-04-14 Thread Yong Bakos
On Apr 14, 2016, at 3:28 AM, Jonas Ådahl wrote: > > xdg_positioner is a method for declarative positioning of child surfaces > (currently only xdg_popup surfaces). A client creates a description of a > positioning logic using the xdg_positioner interface. The xdg_positioner > object is then used

Re: [PATCH wayland-protocols 4/7] xdg-shell: Improve error enum formatting some

2016-04-14 Thread Yong Bakos
On Apr 14, 2016, at 3:28 AM, Jonas Ådahl wrote: > > The long lines stood out, break them by putting the summary on its own > line. > > Signed-off-by: Jonas Ådahl Looks good to me. Reviewed-by: Yong Bakos yong > --- > unstable/xdg-shell/xdg-shell-unstable-v6.xml | 12

Re: [PATCH wayland-protocols 16/19] fullscreen-shell: Correct spelling of parameter name

2016-04-14 Thread Yong Bakos
On Apr 14, 2016, at 9:05 AM, Pekka Paalanen wrote: > > On Mon, 11 Apr 2016 17:30:21 -0500 > Yong Bakos wrote: > >> Jason, >> See below, this one patch affects the argument name of the >> zwp_fullscreen_shell_v1#capability event param name. >> >> yo

[PATCH wayland-build-tools] wl_install_deps: Add missing dependencies

2016-04-14 Thread Yong Bakos
From: Yong Bakos Building on Ubuntu 15.10 x64 fails due to missing packages: libtool, libxml2-dev, libpng-dev, libglib2.0-dev, libgcrypt20-dev, x11proto-scrnsaver-dev, libxfont-dev, and libedit-dev. After these changes, wl_build succeeds on Ubuntu 15.10 x64. Signed-off-by: Yong Bakos

Re: [PATCH v3] protocol: Extend wl_touch with touchpoint shape event

2016-04-14 Thread Yong Bakos
On Apr 14, 2016, at 3:23 PM, Dennis Kempin wrote: > > This CL updates the wl_touch interface with a shape and > orientation event. > The shape/orientation of a touch point is not relevant for most UI > applications, but allows a better experience in some cases > such as drawing apps. > > The eve

Re: [PATCH v3] protocol: Extend wl_touch with touchpoint shape event

2016-04-15 Thread Yong Bakos
On Apr 14, 2016, at 8:54 PM, Jonas Ådahl wrote: > > On Thu, Apr 14, 2016 at 07:04:25PM -0500, Yong Bakos wrote: >> On Apr 14, 2016, at 3:23 PM, Dennis Kempin wrote: >>> >>> This CL updates the wl_touch interface with a shape and >>> orientation event. >

Re: [PATCH wayland-protocols 1/2] stable: add viewporter draft

2016-04-18 Thread Yong Bakos
dant request needs to be removed. These will be done > in a follow-up patch to clearly show the changes. > > Signed-off-by: Pekka Paalanen There's one paragraph I think could use a rewriting, noted inline below, but since this is just a move, the writing and such is Reviewed-by: Yong Ba

  1   2   3   4   5   >