[webkit-changes] [276998] trunk

2021-05-04 Thread jiewen_tan
Title: [276998] trunk Revision 276998 Author jiewen_...@apple.com Date 2021-05-04 17:42:15 -0700 (Tue, 04 May 2021) Log Message PCM: Find a way to validate source_secret_token and source_secret_token_signature https://bugs.webkit.org/show_bug.cgi?id=224321 Reviewed by John Wilander. So

[webkit-changes] [276972] trunk/Source/WebKit

2021-05-04 Thread jiewen_tan
Title: [276972] trunk/Source/WebKit Revision 276972 Author jiewen_...@apple.com Date 2021-05-04 11:34:56 -0700 (Tue, 04 May 2021) Log Message REGRESSION: [ iOS ] 11 http/wpt/webauthn/ tests are crashing https://bugs.webkit.org/show_bug.cgi?id=225225 rdar://77074618 Reviewed by Brent Fulg

[webkit-changes] [276851] trunk/Source/WebKit

2021-04-30 Thread jiewen_tan
Title: [276851] trunk/Source/WebKit Revision 276851 Author jiewen_...@apple.com Date 2021-04-30 13:17:02 -0700 (Fri, 30 Apr 2021) Log Message _WKWebAuthenticationPanelDelegate registration and assertion SPI doesn't work without an LAContext https://bugs.webkit.org/show_bug.cgi?id=225218

[webkit-changes] [276320] trunk/Source/WebKit

2021-04-20 Thread jiewen_tan
Title: [276320] trunk/Source/WebKit Revision 276320 Author jiewen_...@apple.com Date 2021-04-20 15:13:28 -0700 (Tue, 20 Apr 2021) Log Message Platform Key registration does not prompt for user password when in biometric lockout https://bugs.webkit.org/show_bug.cgi?id=224828 Reviewed by

[webkit-changes] [276184] trunk

2021-04-16 Thread jiewen_tan
Title: [276184] trunk Revision 276184 Author jiewen_...@apple.com Date 2021-04-16 17:14:03 -0700 (Fri, 16 Apr 2021) Log Message Pass credential name to the WebAuthn UI during registration https://bugs.webkit.org/show_bug.cgi?id=224697 Reviewed by Brent Fulgham. Source/WebKit: Covered

[webkit-changes] [276180] trunk

2021-04-16 Thread jiewen_tan
Title: [276180] trunk Revision 276180 Author jiewen_...@apple.com Date 2021-04-16 16:52:30 -0700 (Fri, 16 Apr 2021) Log Message Allow using the platform authenticator on non-Touch ID Macs according to Internal requirements https://bugs.webkit.org/show_bug.cgi?id=224639 Reviewed by Danie

[webkit-changes] [275990] trunk/Source/WebKit

2021-04-14 Thread jiewen_tan
Title: [275990] trunk/Source/WebKit Revision 275990 Author jiewen_...@apple.com Date 2021-04-14 19:11:43 -0700 (Wed, 14 Apr 2021) Log Message 6 http/wpt/webauthn layout-tests are constantly timing out https://bugs.webkit.org/show_bug.cgi?id=224531 Reviewed by Brent Fulgham. Covered by

[webkit-changes] [275966] trunk/Source/WebKit

2021-04-14 Thread jiewen_tan
Title: [275966] trunk/Source/WebKit Revision 275966 Author jiewen_...@apple.com Date 2021-04-14 14:35:49 -0700 (Wed, 14 Apr 2021) Log Message Unreviewed, a comment fix after r275847 * UIProcess/WebAuthentication/Cocoa/LocalConnection.mm: (WebKit::LocalConnection::verifyUser): Explains wh

[webkit-changes] [275847] trunk/Source/WebKit

2021-04-12 Thread jiewen_tan
Title: [275847] trunk/Source/WebKit Revision 275847 Author jiewen_...@apple.com Date 2021-04-12 16:54:00 -0700 (Mon, 12 Apr 2021) Log Message Force the WebAuthn compatible mode to always show UI https://bugs.webkit.org/show_bug.cgi?id=224402 Reviewed by Brent Fulgham. Covered by manual

[webkit-changes] [275748] trunk

2021-04-08 Thread jiewen_tan
Title: [275748] trunk Revision 275748 Author jiewen_...@apple.com Date 2021-04-08 21:06:39 -0700 (Thu, 08 Apr 2021) Log Message PCM: Write more blinded secret tests https://bugs.webkit.org/show_bug.cgi?id=222018 Reviewed by John Wilander. Source/WebKit: Covered by new tests. * Networ

[webkit-changes] [275678] trunk/Source/WebCore

2021-04-08 Thread jiewen_tan
Title: [275678] trunk/Source/WebCore Revision 275678 Author jiewen_...@apple.com Date 2021-04-08 14:30:02 -0700 (Thu, 08 Apr 2021) Log Message Unreviewed, a comment fix * crypto/mac/CryptoAlgorithmAES_GCMMac.cpp: (WebCore::encryptAES_GCM): (WebCore::decyptAES_GCM): Removes unnecessary co

[webkit-changes] [275535] trunk

2021-04-06 Thread jiewen_tan
Title: [275535] trunk Revision 275535 Author jiewen_...@apple.com Date 2021-04-06 11:10:31 -0700 (Tue, 06 Apr 2021) Log Message WebCrypto in Safari will not AES-GCM encrypt 0 bytes https://bugs.webkit.org/show_bug.cgi?id=224083 Reviewed by Youenn Fablet. Source/WebCore: CommonCrypto w

[webkit-changes] [275492] trunk/Source/WebKit

2021-04-05 Thread jiewen_tan
Title: [275492] trunk/Source/WebKit Revision 275492 Author jiewen_...@apple.com Date 2021-04-05 21:49:45 -0700 (Mon, 05 Apr 2021) Log Message Allow the WebAuthn UI to inform users about BiometryLockout https://bugs.webkit.org/show_bug.cgi?id=224124 Reviewed by Brent Fulgham. * UIProces

[webkit-changes] [275370] trunk/Source

2021-04-01 Thread jiewen_tan
Title: [275370] trunk/Source Revision 275370 Author jiewen_...@apple.com Date 2021-04-01 11:09:13 -0700 (Thu, 01 Apr 2021) Log Message Allow ASCWebKitSPISupport to be used on macOS https://bugs.webkit.org/show_bug.cgi?id=224036 Reviewed by Brent Fulgham. Source/WebKit: * UIProcess/Web

[webkit-changes] [275260] trunk

2021-03-30 Thread jiewen_tan
Title: [275260] trunk Revision 275260 Author jiewen_...@apple.com Date 2021-03-30 19:52:37 -0700 (Tue, 30 Mar 2021) Log Message PCM: Introduce PrivateClickMeasurementNetworkLoader https://bugs.webkit.org/show_bug.cgi?id=17 Reviewed by Youenn Fablet. Source/WebKit: This patch refac

[webkit-changes] [275248] trunk/Source/WebKit

2021-03-30 Thread jiewen_tan
Title: [275248] trunk/Source/WebKit Revision 275248 Author jiewen_...@apple.com Date 2021-03-30 16:25:08 -0700 (Tue, 30 Mar 2021) Log Message Allow WebAuthn process talk to the ASD https://bugs.webkit.org/show_bug.cgi?id=223947 Reviewed by Brent Fulgham. * Resources/SandboxProfiles/ios

[webkit-changes] [275219] trunk/Source/WebKit

2021-03-30 Thread jiewen_tan
Title: [275219] trunk/Source/WebKit Revision 275219 Author jiewen_...@apple.com Date 2021-03-30 11:56:02 -0700 (Tue, 30 Mar 2021) Log Message Unreviewed, reverting r275197. The change is spooky. Reverted changeset: "Safari crashed and lost all tabs, after unlocking sleeping device" htt

[webkit-changes] [275197] trunk/Source/WebKit

2021-03-29 Thread jiewen_tan
Title: [275197] trunk/Source/WebKit Revision 275197 Author jiewen_...@apple.com Date 2021-03-29 23:35:13 -0700 (Mon, 29 Mar 2021) Log Message Safari crashed and lost all tabs, after unlocking sleeping device https://bugs.webkit.org/show_bug.cgi?id=223832 Reviewed by David Kilzer. A spe

[webkit-changes] [274894] trunk

2021-03-23 Thread jiewen_tan
Title: [274894] trunk Revision 274894 Author jiewen_...@apple.com Date 2021-03-23 13:00:50 -0700 (Tue, 23 Mar 2021) Log Message Provide a way to specify platform vs security key when requesting an assertion in the SPI https://bugs.webkit.org/show_bug.cgi?id=223547 Reviewed by Brent Fulg

[webkit-changes] [274689] trunk/Source/WebKit

2021-03-18 Thread jiewen_tan
Title: [274689] trunk/Source/WebKit Revision 274689 Author jiewen_...@apple.com Date 2021-03-18 16:46:23 -0700 (Thu, 18 Mar 2021) Log Message Update Keychain queries according to internal needs https://bugs.webkit.org/show_bug.cgi?id=223424 rdar://75434045 Reviewed by Brent Fulgham. Cov

[webkit-changes] [274051] trunk/Source/WebKit

2021-03-06 Thread jiewen_tan
Title: [274051] trunk/Source/WebKit Revision 274051 Author jiewen_...@apple.com Date 2021-03-06 21:35:25 -0800 (Sat, 06 Mar 2021) Log Message [WebAuthn] Expand WebAuthn Process's sandbox profile on iOS https://bugs.webkit.org/show_bug.cgi?id=222858 Reviewed by Brent Fulgham. Allows Web

[webkit-changes] [273209] trunk

2021-02-20 Thread jiewen_tan
Title: [273209] trunk Revision 273209 Author jiewen_...@apple.com Date 2021-02-20 15:17:32 -0800 (Sat, 20 Feb 2021) Log Message PCM: Store and report source unlinkable tokens https://bugs.webkit.org/show_bug.cgi?id=08 Reviewed by John Wilander. Source/WebCore: This patch hooks up

[webkit-changes] [273208] trunk/Source/WTF

2021-02-20 Thread jiewen_tan
Title: [273208] trunk/Source/WTF Revision 273208 Author jiewen_...@apple.com Date 2021-02-20 15:01:38 -0800 (Sat, 20 Feb 2021) Log Message PCM: Turn the fraud prevention on by default https://bugs.webkit.org/show_bug.cgi?id=24 Reviewed by John Wilander. * Scripts/Preferences/WebPre

[webkit-changes] [273167] trunk

2021-02-19 Thread jiewen_tan
Title: [273167] trunk Revision 273167 Author jiewen_...@apple.com Date 2021-02-19 15:15:22 -0800 (Fri, 19 Feb 2021) Log Message PCM: Generate secret token and corresponding unlinkable token https://bugs.webkit.org/show_bug.cgi?id=222019 Reviewed by John Wilander. Source/WebCore: Cover

[webkit-changes] [273133] trunk

2021-02-19 Thread jiewen_tan
Title: [273133] trunk Revision 273133 Author jiewen_...@apple.com Date 2021-02-19 01:10:16 -0800 (Fri, 19 Feb 2021) Log Message PCM: Request server public key to generate secret token https://bugs.webkit.org/show_bug.cgi?id=222141 Reviewed by John Wilander. Source/WebCore: This patch

[webkit-changes] [272826] trunk

2021-02-12 Thread jiewen_tan
Title: [272826] trunk Revision 272826 Author jiewen_...@apple.com Date 2021-02-12 17:40:41 -0800 (Fri, 12 Feb 2021) Log Message [WebAuthn] Provide SPI to query local credentials https://bugs.webkit.org/show_bug.cgi?id=221743 Reviewed by Brent Fulgham. Source/WebKit: Covered by API tes

[webkit-changes] [272708] trunk/Source/WebKit

2021-02-10 Thread jiewen_tan
Title: [272708] trunk/Source/WebKit Revision 272708 Author jiewen_...@apple.com Date 2021-02-10 22:26:32 -0800 (Wed, 10 Feb 2021) Log Message [WebAuthn] Update - [ASCAppleIDCredential initWithUser:...] to match the latest SPI https://bugs.webkit.org/show_bug.cgi?id=221723 Reviewed by Br

[webkit-changes] [272694] trunk

2021-02-10 Thread jiewen_tan
Title: [272694] trunk Revision 272694 Author jiewen_...@apple.com Date 2021-02-10 15:50:37 -0800 (Wed, 10 Feb 2021) Log Message [WebAuthn] Produce ClientDataJSON in the SPI https://bugs.webkit.org/show_bug.cgi?id=221623 Reviewed by Brent Fulgham. Source/WebKit: Instead of asking the c

[webkit-changes] [272345] trunk

2021-02-03 Thread jiewen_tan
Title: [272345] trunk Revision 272345 Author jiewen_...@apple.com Date 2021-02-03 15:46:42 -0800 (Wed, 03 Feb 2021) Log Message [WebAuthn] Allow one user gesture free prompt for each navigation https://bugs.webkit.org/show_bug.cgi?id=220897 Reviewed by Brent Fulgham. Source/WebCore: *

[webkit-changes] [272343] trunk/Source

2021-02-03 Thread jiewen_tan
Title: [272343] trunk/Source Revision 272343 Author jiewen_...@apple.com Date 2021-02-03 15:17:50 -0800 (Wed, 03 Feb 2021) Log Message PCM: Add fraud prevention experimental feature flag https://bugs.webkit.org/show_bug.cgi?id=221292 Reviewed by John Wilander. * Scripts/Preferences/Web

[webkit-changes] [272184] trunk

2021-02-01 Thread jiewen_tan
Title: [272184] trunk Revision 272184 Author jiewen_...@apple.com Date 2021-02-01 18:49:59 -0800 (Mon, 01 Feb 2021) Log Message [WebAuthn] Optimize _WKWebAuthenticationPanelDelegate for native API https://bugs.webkit.org/show_bug.cgi?id=221125 Reviewed by Brent Fulgham. Source/WebKit:

[webkit-changes] [272040] trunk/Source/WebKit

2021-01-28 Thread jiewen_tan
Title: [272040] trunk/Source/WebKit Revision 272040 Author jiewen_...@apple.com Date 2021-01-28 16:39:53 -0800 (Thu, 28 Jan 2021) Log Message [WebAuthn] Adopt new SPI to show no credentials error for the platform authenticator https://bugs.webkit.org/show_bug.cgi?id=220894 Reviewed by B

[webkit-changes] [271754] trunk/Source/WebKit

2021-01-22 Thread jiewen_tan
Title: [271754] trunk/Source/WebKit Revision 271754 Author jiewen_...@apple.com Date 2021-01-22 12:04:06 -0800 (Fri, 22 Jan 2021) Log Message [WebAuthn] No error is visible after user enters the incorrect PIN https://bugs.webkit.org/show_bug.cgi?id=220839 Reviewed by Brent Fulgham. To

[webkit-changes] [271753] trunk/Source/WebKit

2021-01-22 Thread jiewen_tan
Title: [271753] trunk/Source/WebKit Revision 271753 Author jiewen_...@apple.com Date 2021-01-22 11:53:55 -0800 (Fri, 22 Jan 2021) Log Message [WebAuthn] Should only check default browsers for the Modern WebAuthn https://bugs.webkit.org/show_bug.cgi?id=220840 Reviewed by Brent Fulgham.

[webkit-changes] [271613] trunk/Source/WebKit

2021-01-19 Thread jiewen_tan
Title: [271613] trunk/Source/WebKit Revision 271613 Author jiewen_...@apple.com Date 2021-01-19 13:27:55 -0800 (Tue, 19 Jan 2021) Log Message [WebAuthn] Polish the new WebAuthn UI https://bugs.webkit.org/show_bug.cgi?id=220617 Reviewed by Brent Fulgham. This patch does the following fe

[webkit-changes] [271467] trunk/Source/WebKit

2021-01-13 Thread jiewen_tan
Title: [271467] trunk/Source/WebKit Revision 271467 Author jiewen_...@apple.com Date 2021-01-13 15:19:23 -0800 (Wed, 13 Jan 2021) Log Message Crash at SOAuthorizationSession::dismissViewController https://bugs.webkit.org/show_bug.cgi?id=220482 Reviewed by Darin Adler. A crash report su

[webkit-changes] [271318] trunk/Source/WebKit

2021-01-08 Thread jiewen_tan
Title: [271318] trunk/Source/WebKit Revision 271318 Author jiewen_...@apple.com Date 2021-01-08 12:33:18 -0800 (Fri, 08 Jan 2021) Log Message [WebAuthn] Adopt new UI for the update flow https://bugs.webkit.org/show_bug.cgi?id=219713 Reviewed by Brent Fulgham. Covered by manual tests.

[webkit-changes] [271228] trunk/Source/WebKit

2021-01-07 Thread jiewen_tan
Title: [271228] trunk/Source/WebKit Revision 271228 Author jiewen_...@apple.com Date 2021-01-07 00:16:56 -0800 (Thu, 07 Jan 2021) Log Message Unreviewed, a build fix after r271221 * Platform/spi/Cocoa/NearFieldSPI.h: * UIProcess/WebAuthentication/Cocoa/NfcService.mm: (WebKit::NfcService:

[webkit-changes] [271221] trunk/Source/WebKit

2021-01-06 Thread jiewen_tan
Title: [271221] trunk/Source/WebKit Revision 271221 Author jiewen_...@apple.com Date 2021-01-06 17:50:34 -0800 (Wed, 06 Jan 2021) Log Message [WebAuthn] Adopt new UI for the Client PIN and dismiss flow https://bugs.webkit.org/show_bug.cgi?id=219712 Reviewed by Brent Fulgham. Covered by

[webkit-changes] [270917] trunk/Source/WebKit

2020-12-16 Thread jiewen_tan
Title: [270917] trunk/Source/WebKit Revision 270917 Author jiewen_...@apple.com Date 2020-12-16 17:32:49 -0800 (Wed, 16 Dec 2020) Log Message Unreviewed, a build fix for the latest Internal SDK * Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h: Modified Paths trunk/Source/WebKit/Cha

[webkit-changes] [270743] trunk

2020-12-12 Thread jiewen_tan
Title: [270743] trunk Revision 270743 Author jiewen_...@apple.com Date 2020-12-12 17:58:14 -0800 (Sat, 12 Dec 2020) Log Message [WebAuthn][iOS] Turn on modern WebAuthn for default browsers https://bugs.webkit.org/show_bug.cgi?id=219823 Reviewed by Brent Fulgham. Source/WebKit: Covered

[webkit-changes] [270730] trunk/Source

2020-12-11 Thread jiewen_tan
Title: [270730] trunk/Source Revision 270730 Author jiewen_...@apple.com Date 2020-12-11 21:19:32 -0800 (Fri, 11 Dec 2020) Log Message [WebAuthn] Adopt new UI for the Platform Authenticator getAssertion flow https://bugs.webkit.org/show_bug.cgi?id=219710 Reviewed by Brent Fulgham. Sour

[webkit-changes] [270724] trunk/Source/WebKit

2020-12-11 Thread jiewen_tan
Title: [270724] trunk/Source/WebKit Revision 270724 Author jiewen_...@apple.com Date 2020-12-11 18:03:32 -0800 (Fri, 11 Dec 2020) Log Message [WebAuthn] Adopt new UI for the Security Key getAssertion flow https://bugs.webkit.org/show_bug.cgi?id=219711 Reviewed by Brent Fulgham. This pa

[webkit-changes] [270721] trunk/Source/WebKit

2020-12-11 Thread jiewen_tan
Title: [270721] trunk/Source/WebKit Revision 270721 Author jiewen_...@apple.com Date 2020-12-11 16:58:40 -0800 (Fri, 11 Dec 2020) Log Message Unreviewed, build fix after r270694 * UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm: (WebKit::AuthenticatorPresenterCoord

[webkit-changes] [270694] trunk/Source/WebKit

2020-12-11 Thread jiewen_tan
Title: [270694] trunk/Source/WebKit Revision 270694 Author jiewen_...@apple.com Date 2020-12-11 11:46:49 -0800 (Fri, 11 Dec 2020) Log Message [WebAuthn] Adopt new UI for the Platform Authenticator makeCredential flow https://bugs.webkit.org/show_bug.cgi?id=219709 Reviewed by Brent Fulgh

[webkit-changes] [270619] trunk

2020-12-10 Thread jiewen_tan
Title: [270619] trunk Revision 270619 Author jiewen_...@apple.com Date 2020-12-10 03:26:15 -0800 (Thu, 10 Dec 2020) Log Message Unreviewed, build fix after r270616 Source/WebKit: Adds a platform have flag. * Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h: * UIProcess/WebAuthenticat

[webkit-changes] [270616] trunk

2020-12-10 Thread jiewen_tan
Title: [270616] trunk Revision 270616 Author jiewen_...@apple.com Date 2020-12-10 00:41:43 -0800 (Thu, 10 Dec 2020) Log Message [WebAuthn] Adopt new UI for the Security Key makeCredential flow https://bugs.webkit.org/show_bug.cgi?id=219708 Reviewed by Brent Fulgham. Source/WebKit: Thi

[webkit-changes] [269554] trunk/Source/WebKit

2020-11-11 Thread jiewen_tan
Title: [269554] trunk/Source/WebKit Revision 269554 Author jiewen_...@apple.com Date 2020-11-06 17:38:35 -0800 (Fri, 06 Nov 2020) Log Message [WebAuthn] [iOS] WebAuthn process doesn't start on iOS devices https://bugs.webkit.org/show_bug.cgi?id=218479 Reviewed by Brent Fulgham. One of

[webkit-changes] [269420] trunk

2020-11-11 Thread jiewen_tan
Title: [269420] trunk Revision 269420 Author jiewen_...@apple.com Date 2020-11-05 00:46:57 -0800 (Thu, 05 Nov 2020) Log Message [WebAuthn] Determine an AAGUID for the platform authenticators https://bugs.webkit.org/show_bug.cgi?id=217945 Reviewed by Brent Fulgham. Source/WebKit: Relyi

[webkit-changes] [269168] trunk

2020-10-29 Thread jiewen_tan
Title: [269168] trunk Revision 269168 Author jiewen_...@apple.com Date 2020-10-29 14:10:09 -0700 (Thu, 29 Oct 2020) Log Message [WebAuthn] Make WebContent process talk to the WebAuthn process for WebAuthn requests https://bugs.webkit.org/show_bug.cgi?id=218070 Reviewed by Brent Fulgham.

[webkit-changes] [268628] trunk/Source

2020-10-16 Thread jiewen_tan
Title: [268628] trunk/Source Revision 268628 Author jiewen_...@apple.com Date 2020-10-16 19:29:21 -0700 (Fri, 16 Oct 2020) Log Message [WebAuthn] Add an experimental feature flag: WebAuthenticationModernEnabled https://bugs.webkit.org/show_bug.cgi?id=217843 Reviewed by Brent Fulgham. S

[webkit-changes] [268613] trunk

2020-10-16 Thread jiewen_tan
Title: [268613] trunk Revision 268613 Author jiewen_...@apple.com Date 2020-10-16 15:23:37 -0700 (Fri, 16 Oct 2020) Log Message [WebAuthn] Remove experimental feature flag: WebAuthenticationLocalAuthenticatorEnabled https://bugs.webkit.org/show_bug.cgi?id=217796 Reviewed by Brent Fulgha

[webkit-changes] [268602] trunk

2020-10-16 Thread jiewen_tan
Title: [268602] trunk Revision 268602 Author jiewen_...@apple.com Date 2020-10-16 12:20:41 -0700 (Fri, 16 Oct 2020) Log Message [WebAuthn] Remove the "alg" field in the attestation statement https://bugs.webkit.org/show_bug.cgi?id=217720 Reviewed by Brent Fulgham. Source/WebKit: This

[webkit-changes] [268575] trunk/Source

2020-10-16 Thread jiewen_tan
Title: [268575] trunk/Source Revision 268575 Author jiewen_...@apple.com Date 2020-10-16 00:52:45 -0700 (Fri, 16 Oct 2020) Log Message [WebAuthn] Move AppAttestInternal related code from WKA to OpenSource https://bugs.webkit.org/show_bug.cgi?id=217790 Reviewed by Brent Fulgham. Source/

[webkit-changes] [268248] trunk/Source/WebKit

2020-10-08 Thread jiewen_tan
Title: [268248] trunk/Source/WebKit Revision 268248 Author jiewen_...@apple.com Date 2020-10-08 22:16:03 -0700 (Thu, 08 Oct 2020) Log Message [WebAuthn] Implement a dummy WebAuthenticationAgent https://bugs.webkit.org/show_bug.cgi?id=217401 Reviewed by Darin Adler. Part 1. This patch

[webkit-changes] [268155] trunk/Source/WebKit

2020-10-07 Thread jiewen_tan
Title: [268155] trunk/Source/WebKit Revision 268155 Author jiewen_...@apple.com Date 2020-10-07 15:27:58 -0700 (Wed, 07 Oct 2020) Log Message [WebAuthn] Implement a dummy WebAuthenticationAgent https://bugs.webkit.org/show_bug.cgi?id=217401 Reviewed by Darin Adler. Part 1. This patch

[webkit-changes] [267369] trunk

2020-09-21 Thread jiewen_tan
Title: [267369] trunk Revision 267369 Author jiewen_...@apple.com Date 2020-09-21 14:32:21 -0700 (Mon, 21 Sep 2020) Log Message [WebAuthn] Don't set the UV option if the authenticator doesn't support it https://bugs.webkit.org/show_bug.cgi?id=215836 Reviewed by Darin Adler. Source/WebC

[webkit-changes] [265158] trunk/Source/WebKit

2020-07-31 Thread jiewen_tan
Title: [265158] trunk/Source/WebKit Revision 265158 Author jiewen_...@apple.com Date 2020-07-31 13:39:04 -0700 (Fri, 31 Jul 2020) Log Message SOAuthorizationSession::dismissViewController could crash on calling WebPageProxy::platformWindow https://bugs.webkit.org/show_bug.cgi?id=214816

[webkit-changes] [264853] trunk

2020-07-24 Thread jiewen_tan
Title: [264853] trunk Revision 264853 Author jiewen_...@apple.com Date 2020-07-24 13:48:42 -0700 (Fri, 24 Jul 2020) Log Message Propagating user gesture through Fetch API https://bugs.webkit.org/show_bug.cgi?id=21 Reviewed by Youenn Fablet. Source/WebCore: This patch propagates me

[webkit-changes] [264543] trunk

2020-07-17 Thread jiewen_tan
Title: [264543] trunk Revision 264543 Author jiewen_...@apple.com Date 2020-07-17 15:58:51 -0700 (Fri, 17 Jul 2020) Log Message [WebAuthn] Cache the PIN to improve NFC user experience https://bugs.webkit.org/show_bug.cgi?id=213900 Reviewed by Brent Fulgham. Source/WebKit: Cache the PI

[webkit-changes] [264528] trunk/Source/WebKit

2020-07-17 Thread jiewen_tan
Title: [264528] trunk/Source/WebKit Revision 264528 Author jiewen_...@apple.com Date 2020-07-17 12:30:23 -0700 (Fri, 17 Jul 2020) Log Message [WebAuthn] Use MediaOnly user gesture https://bugs.webkit.org/show_bug.cgi?id=213595 Reviewed by Brent Fulgham. MediaOnly user gesture is more f

[webkit-changes] [264490] trunk

2020-07-16 Thread jiewen_tan
Title: [264490] trunk Revision 264490 Author jiewen_...@apple.com Date 2020-07-16 18:07:27 -0700 (Thu, 16 Jul 2020) Log Message [WebAuthn] Add a console message: "User gesture is required to use the platform authenticator." https://bugs.webkit.org/show_bug.cgi?id=214380 Reviewed by Devi

[webkit-changes] [263782] trunk/Source/WebKit

2020-06-30 Thread jiewen_tan
Title: [263782] trunk/Source/WebKit Revision 263782 Author jiewen_...@apple.com Date 2020-06-30 18:52:18 -0700 (Tue, 30 Jun 2020) Log Message [WebAuthn] Remove whitelistedRpId https://bugs.webkit.org/show_bug.cgi?id=213817 Reviewed by Geoffrey Garen. Remove the whitelist such that we c

[webkit-changes] [263324] trunk/Source/WebKit

2020-06-20 Thread jiewen_tan
Title: [263324] trunk/Source/WebKit Revision 263324 Author jiewen_...@apple.com Date 2020-06-20 23:10:37 -0700 (Sat, 20 Jun 2020) Log Message [AppSSO] Should do null check on m_page in dismissViewController() https://bugs.webkit.org/show_bug.cgi?id=213415 Reviewed by Alexey Proskuryakov

[webkit-changes] [263296] trunk

2020-06-19 Thread jiewen_tan
Title: [263296] trunk Revision 263296 Author jiewen_...@apple.com Date 2020-06-19 16:40:04 -0700 (Fri, 19 Jun 2020) Log Message [WebAuthn] Provide a _WKWebAuthenticationPanelUpdatePINInvalid update to UI clients if the returned PIN from the client is not valid https://bugs.webkit.org/show

[webkit-changes] [262585] trunk/Source/WebKit

2020-06-04 Thread jiewen_tan
Title: [262585] trunk/Source/WebKit Revision 262585 Author jiewen_...@apple.com Date 2020-06-04 16:54:01 -0700 (Thu, 04 Jun 2020) Log Message Disable CFNetwork AppSSO interception for Mac Catalyst https://bugs.webkit.org/show_bug.cgi?id=212787 Reviewed by Chris Dumez. * NetworkProcess/

[webkit-changes] [261723] trunk

2020-05-14 Thread jiewen_tan
Title: [261723] trunk Revision 261723 Author jiewen_...@apple.com Date 2020-05-14 16:49:04 -0700 (Thu, 14 May 2020) Log Message [WebAuthn] Relaxing signature length requirements for U2fRegister https://bugs.webkit.org/show_bug.cgi?id=209645 Reviewed by Brent Fulgham. Source/WebCore: I

[webkit-changes] [261588] trunk/Source

2020-05-12 Thread jiewen_tan
Title: [261588] trunk/Source Revision 261588 Author jiewen_...@apple.com Date 2020-05-12 17:11:00 -0700 (Tue, 12 May 2020) Log Message [WebAuthn] Don't assume extensions always exist https://bugs.webkit.org/show_bug.cgi?id=211760 Reviewed by Brent Fulgham. Source/WebCore: * Modules/we

[webkit-changes] [261366] trunk

2020-05-07 Thread jiewen_tan
Title: [261366] trunk Revision 261366 Author jiewen_...@apple.com Date 2020-05-07 19:33:15 -0700 (Thu, 07 May 2020) Log Message [WebAuthn] Roll back newly created credentials if an error occurs https://bugs.webkit.org/show_bug.cgi?id=183530 Reviewed by Brent Fulgham. Source/WebKit: We

[webkit-changes] [261118] trunk/Source

2020-05-04 Thread jiewen_tan
Title: [261118] trunk/Source Revision 261118 Author jiewen_...@apple.com Date 2020-05-04 15:26:12 -0700 (Mon, 04 May 2020) Log Message [WebAuthn] Implement +[_WKWebAuthenticationPanel clearAllLocalAuthenticatorCredentials] https://bugs.webkit.org/show_bug.cgi?id=211369 Reviewed by Brent

[webkit-changes] [260983] trunk

2020-04-30 Thread jiewen_tan
Title: [260983] trunk Revision 260983 Author jiewen_...@apple.com Date 2020-04-30 21:43:28 -0700 (Thu, 30 Apr 2020) Log Message [WebAuthn] Require user gestures for LocalAuthenticator https://bugs.webkit.org/show_bug.cgi?id=182893 Reviewed by Brent Fulgham. Source/WebKit: Covered by A

[webkit-changes] [260970] trunk

2020-04-30 Thread jiewen_tan
Title: [260970] trunk Revision 260970 Author jiewen_...@apple.com Date 2020-04-30 15:27:02 -0700 (Thu, 30 Apr 2020) Log Message [WebAuthn] Optimize LocalAuthenticator https://bugs.webkit.org/show_bug.cgi?id=183534 Reviewed by Brent Fulgham. Source/WebCore: Covered by new API tests. *

[webkit-changes] [259680] trunk

2020-04-07 Thread jiewen_tan
Title: [259680] trunk Revision 259680 Author jiewen_...@apple.com Date 2020-04-07 16:01:20 -0700 (Tue, 07 Apr 2020) Log Message [WebAuthn] Cancel WebAuthn requests when users cancel LocalAuthentication prompts https://bugs.webkit.org/show_bug.cgi?id=209923 Reviewed by Brent Fulgham. So

[webkit-changes] [258973] trunk/Tools

2020-03-24 Thread jiewen_tan
Title: [258973] trunk/Tools Revision 258973 Author jiewen_...@apple.com Date 2020-03-24 22:55:45 -0700 (Tue, 24 Mar 2020) Log Message Unreviewed, skips a test for iOS * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm: Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWe

[webkit-changes] [258961] trunk/Source

2020-03-24 Thread jiewen_tan
Title: [258961] trunk/Source Revision 258961 Author jiewen_...@apple.com Date 2020-03-24 17:03:19 -0700 (Tue, 24 Mar 2020) Log Message [WebAuthn] Customize a bit more on the macOS LocalAuthentication prompt https://bugs.webkit.org/show_bug.cgi?id=208703 Reviewed by Brent Fulgham. Part

[webkit-changes] [258602] trunk/Source/WebKit

2020-03-17 Thread jiewen_tan
Title: [258602] trunk/Source/WebKit Revision 258602 Author jiewen_...@apple.com Date 2020-03-17 15:04:48 -0700 (Tue, 17 Mar 2020) Log Message WebKit::LocalAuthenticator::deleteDuplicateCredential() should check buffer size before memcmp https://bugs.webkit.org/show_bug.cgi?id=209156 Rev

[webkit-changes] [258442] trunk/Source

2020-03-13 Thread jiewen_tan
Title: [258442] trunk/Source Revision 258442 Author jiewen_...@apple.com Date 2020-03-13 16:15:31 -0700 (Fri, 13 Mar 2020) Log Message [WebAuthn] Customize a bit more on the macOS LocalAuthentication prompt https://bugs.webkit.org/show_bug.cgi?id=208703 Reviewed by Darin Adler. Source/

[webkit-changes] [258020] trunk

2020-03-06 Thread jiewen_tan
Title: [258020] trunk Revision 258020 Author jiewen_...@apple.com Date 2020-03-06 12:42:36 -0800 (Fri, 06 Mar 2020) Log Message [WebAuthn] Do not perform Attestation with type is 'none' https://bugs.webkit.org/show_bug.cgi?id=208676 Reviewed by Brent Fulgham. Source/WebKit: Besides th

[webkit-changes] [257954] trunk

2020-03-05 Thread jiewen_tan
Title: [257954] trunk Revision 257954 Author jiewen_...@apple.com Date 2020-03-05 15:58:10 -0800 (Thu, 05 Mar 2020) Log Message [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:] https://bugs.webkit.org/show_bug.cgi?id=208

[webkit-changes] [257891] trunk/Source/WebKit

2020-03-04 Thread jiewen_tan
Title: [257891] trunk/Source/WebKit Revision 257891 Author jiewen_...@apple.com Date 2020-03-04 17:02:51 -0800 (Wed, 04 Mar 2020) Log Message Unreviewed, a build fix after r257877 * UIProcess/WebAuthentication/Cocoa/LocalConnection.mm: (WebKit::LocalConnection::verifyUser const): Restric

[webkit-changes] [257877] trunk

2020-03-04 Thread jiewen_tan
Title: [257877] trunk Revision 257877 Author jiewen_...@apple.com Date 2020-03-04 13:42:39 -0800 (Wed, 04 Mar 2020) Log Message [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI https://bugs.webkit.org/show_bug.cgi?

[webkit-changes] [257371] trunk/Source/WebKit

2020-02-25 Thread jiewen_tan
Title: [257371] trunk/Source/WebKit Revision 257371 Author jiewen_...@apple.com Date 2020-02-25 13:40:56 -0800 (Tue, 25 Feb 2020) Log Message Unreviewed, a build fix after r257269 * Platform/spi/Cocoa/LocalAuthenticationSPI.h: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/W

[webkit-changes] [257269] trunk

2020-02-24 Thread jiewen_tan
Title: [257269] trunk Revision 257269 Author jiewen_...@apple.com Date 2020-02-24 15:51:17 -0800 (Mon, 24 Feb 2020) Log Message [WebAuthn] Implement SPI for the platform authenticator https://bugs.webkit.org/show_bug.cgi?id=208087 Reviewed by Brent Fulgham. Source/WebCore: Enhances Au

[webkit-changes] [257085] trunk

2020-02-20 Thread jiewen_tan
Title: [257085] trunk Revision 257085 Author jiewen_...@apple.com Date 2020-02-20 14:05:59 -0800 (Thu, 20 Feb 2020) Log Message [WebAuthn] Replace DeviceIdentity.framework https://bugs.webkit.org/show_bug.cgi?id=207985 Reviewed by Brent Fulgham. Source/WebKit: This patch replaces the

[webkit-changes] [256661] trunk/Source/WebKit

2020-02-14 Thread jiewen_tan
Title: [256661] trunk/Source/WebKit Revision 256661 Author jiewen_...@apple.com Date 2020-02-14 17:20:38 -0800 (Fri, 14 Feb 2020) Log Message [WebAuthn] Make Local Authenticator appear as an experimental feature https://bugs.webkit.org/show_bug.cgi?id=207797 Reviewed by Brent Fulgham.

[webkit-changes] [256238] trunk/Source/WebKit

2020-02-10 Thread jiewen_tan
Title: [256238] trunk/Source/WebKit Revision 256238 Author jiewen_...@apple.com Date 2020-02-10 19:35:25 -0800 (Mon, 10 Feb 2020) Log Message [WebAuthn] Move the async code from WebAuthenticationPanelClient to AuthenticatorManager https://bugs.webkit.org/show_bug.cgi?id=206248 Reviewed b

[webkit-changes] [256201] trunk/Source/WebCore

2020-02-10 Thread jiewen_tan
Title: [256201] trunk/Source/WebCore Revision 256201 Author jiewen_...@apple.com Date 2020-02-10 12:26:04 -0800 (Mon, 10 Feb 2020) Log Message [WebAuthn] Merge some of the CTAP response decoder's code https://bugs.webkit.org/show_bug.cgi?id=205375 Reviewed by Darin Adler. This patch mak

[webkit-changes] [256062] trunk

2020-02-07 Thread jiewen_tan
Title: [256062] trunk Revision 256062 Author jiewen_...@apple.com Date 2020-02-07 14:16:54 -0800 (Fri, 07 Feb 2020) Log Message [WebAuthn] Report CTAP Client Pin Error to clients https://bugs.webkit.org/show_bug.cgi?id=205837 Reviewed by Brent Fulgham. Source/WebKit: Authenticators co

[webkit-changes] [256001] trunk

2020-02-06 Thread jiewen_tan
Title: [256001] trunk Revision 256001 Author jiewen_...@apple.com Date 2020-02-06 18:57:30 -0800 (Thu, 06 Feb 2020) Log Message [WebAuthn] authenticatorGetAssertion should be sent without pinAuth if UV = "discouraged" https://bugs.webkit.org/show_bug.cgi?id=206547 Reviewed by Brent Fulg

[webkit-changes] [255999] trunk

2020-02-06 Thread jiewen_tan
Title: [255999] trunk Revision 255999 Author jiewen_...@apple.com Date 2020-02-06 18:38:21 -0800 (Thu, 06 Feb 2020) Log Message Adopt new SOAuthorizationOption constants https://bugs.webkit.org/show_bug.cgi?id=207186 Reviewed by Brent Fulgham. Source/WebCore/PAL: * pal/cocoa/AppSSOSof

[webkit-changes] [255862] trunk

2020-02-05 Thread jiewen_tan
Title: [255862] trunk Revision 255862 Author jiewen_...@apple.com Date 2020-02-05 14:49:43 -0800 (Wed, 05 Feb 2020) Log Message Defer ending AppSSO sheets til NSWindowDidDeminiaturize or NSApplicationDidUnhide https://bugs.webkit.org/show_bug.cgi?id=207173 Reviewed by Brent Fulgham. So

[webkit-changes] [255660] trunk

2020-02-03 Thread jiewen_tan
Title: [255660] trunk Revision 255660 Author jiewen_...@apple.com Date 2020-02-03 21:29:51 -0800 (Mon, 03 Feb 2020) Log Message Pass a hint from the extension to decidePolicyForSOAuthorizationLoadWithCurrentPolicy https://bugs.webkit.org/show_bug.cgi?id=207079 Reviewed by Brent Fulgham.

[webkit-changes] [255487] trunk/Source/WebCore

2020-01-31 Thread jiewen_tan
Title: [255487] trunk/Source/WebCore Revision 255487 Author jiewen_...@apple.com Date 2020-01-31 01:07:06 -0800 (Fri, 31 Jan 2020) Log Message REGRESSION: [iOS release] http/tests/security/window-named-proto.html is a flaky timing out https://bugs.webkit.org/show_bug.cgi?id=206672 Revie

[webkit-changes] [255480] trunk/Source/WebKit

2020-01-30 Thread jiewen_tan
Title: [255480] trunk/Source/WebKit Revision 255480 Author jiewen_...@apple.com Date 2020-01-30 18:22:25 -0800 (Thu, 30 Jan 2020) Log Message Add logging to show the flow of AppSSO https://bugs.webkit.org/show_bug.cgi?id=206778 Reviewed by Brent Fulgham. * Platform/Logging.h: * UIProce

[webkit-changes] [255466] trunk

2020-01-30 Thread jiewen_tan
Title: [255466] trunk Revision 255466 Author jiewen_...@apple.com Date 2020-01-30 15:59:33 -0800 (Thu, 30 Jan 2020) Log Message Unreviewed, another speculative test fix after r255041 Source/WebKit: * UIProcess/WebAuthentication/Mock/MockLocalConnection.mm: (WebKit::MockLocalConnection::

[webkit-changes] [255188] trunk/Source/WebKit

2020-01-27 Thread jiewen_tan
Title: [255188] trunk/Source/WebKit Revision 255188 Author jiewen_...@apple.com Date 2020-01-27 15:29:00 -0800 (Mon, 27 Jan 2020) Log Message Unreviewed, a build fix after r255111 * UIProcess/WebAuthentication/Mock/MockLocalConnection.mm: Adding some missing headers. Modified Paths tru

[webkit-changes] [255111] trunk/Source/WebKit

2020-01-24 Thread jiewen_tan
Title: [255111] trunk/Source/WebKit Revision 255111 Author jiewen_...@apple.com Date 2020-01-24 17:28:03 -0800 (Fri, 24 Jan 2020) Log Message Unreviewed, a speculative test fix after r255041 * UIProcess/WebAuthentication/Mock/MockLocalConnection.mm: (WebKit::MockLocalConnection::getAttes

[webkit-changes] [255093] trunk/Source/WebKit

2020-01-24 Thread jiewen_tan
Title: [255093] trunk/Source/WebKit Revision 255093 Author jiewen_...@apple.com Date 2020-01-24 13:58:33 -0800 (Fri, 24 Jan 2020) Log Message Unreviewed, a build fix after r255056 * UIProcess/WebAuthentication/Mock/MockLocalConnection.mm: (WebKit::MockLocalConnection::getAttestation cons

[webkit-changes] [255056] trunk/Source/WebKit

2020-01-23 Thread jiewen_tan
Title: [255056] trunk/Source/WebKit Revision 255056 Author jiewen_...@apple.com Date 2020-01-23 22:37:35 -0800 (Thu, 23 Jan 2020) Log Message Unreviewed, a follow up on r254894 * UIProcess/WebAuthentication/Mock/MockLocalConnection.mm: (WebKit::MockLocalConnection::getAttestation const):

[webkit-changes] [255041] trunk/Tools

2020-01-23 Thread jiewen_tan
Title: [255041] trunk/Tools Revision 255041 Author jiewen_...@apple.com Date 2020-01-23 15:57:37 -0800 (Thu, 23 Jan 2020) Log Message WebKitTestRunner: use ad hoc signing for internal Production builds https://bugs.webkit.org/show_bug.cgi?id=206607 Reviewed by Jonathan Bedard. * WebKit

  1   2   3   4   5   >